@crossworks/app-build 0.230.59 → 0.230.60

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@crossworks/app-build",
-  "version": "0.230.59",
+  "version": "0.230.60",
   "type": "module",
   "main": "./src/index.ts",
   "types": "./src/index.ts",
@@ -14,7 +14,7 @@
     "lucide-react": "^1.25.0",
     "react": "^19.2.7",
     "react-dom": "^19.2.7",
-    "@mantle/share-ui": "npm:@crossworks/share-ui@0.230.59"
+    "@mantle/share-ui": "npm:@crossworks/share-ui@0.230.60"
   },
   "devDependencies": {
     "@types/node": "^22.20.1",
@@ -29,6 +29,6 @@
   },
   "scripts": {
     "typecheck": "tsc --noEmit",
-    "build:runtime": "node scripts/build-runtime.ts"
+    "build:runtime": "node scripts/build-runtime.ts ../../server/web"
   }
 }

package/scripts/build-runtime.ts

@@ -1,20 +1,28 @@
 /**
- * Emits the shared mini-app runtime into server/web/public/app-runtime/.
- * Run with: `node packages/app-build/scripts/build-runtime.ts` (Node strips the
- * TS types). Wired as `pnpm -C packages/app-build build:runtime` and invoked
- * from server/web's prebuild so the runtime always exists before apps render.
+ * Emits the shared mini-app runtime into an app's `public/app-runtime/`.
+ * Run with: `node packages/app-build/scripts/build-runtime.ts` from the app
+ * directory (Node strips the TS types). Invoked from `predev`/`prebuild` in
+ * server/web and in jackdaw's client/web, so the runtime always exists before
+ * apps render.
  */
+import { existsSync } from 'node:fs';
 import * as path from 'node:path';
-import { fileURLToPath } from 'node:url';
 import { buildRuntime } from '../src/build-runtime.ts';
 
-const here = path.dirname(fileURLToPath(import.meta.url));
-const repoRoot = path.resolve(here, '../../..');
-
 /**
- * Which app is asking. Each Next app serves its own copy — the ACAO:* runtime
- * has to exist on every origin that renders sandboxes — so the caller names
- * itself and this resolves the path from the repo root.
+ * Where to write. Each Next app serves its own copy — the ACAO:* runtime has
+ * to exist on every origin that renders sandboxes.
+ *
+ * Paths resolve from the CALLER'S CWD, never from this script's own location.
+ * They used to resolve against `../../..` from here, which is the repo root
+ * only while this package sits in the repo being built. Published to npm and
+ * installed by the jackdaw repo, that same expression pointed at the
+ * consumer's `node_modules/`, so `build-runtime.ts client/web` wrote the
+ * runtime to `node_modules/client/web/public/app-runtime` — a real directory
+ * nothing serves. The owner UI shipped with NO `/app-runtime/*` at all (its
+ * Docker build runs the same prebuild), and nothing failed: the build printed
+ * a success line naming the wrong path, and only a sandboxed mini-app trying
+ * to boot would notice.
  *
  * An ARGUMENT rather than an environment variable, deliberately. The callers
  * used to set `APP_RUNTIME_OUT="$PWD/…"` inline, which is POSIX shell syntax;
@@ -24,15 +32,27 @@ const repoRoot = path.resolve(here, '../../..');
  * `'APP_RUNTIME_OUT' is not recognized`. An argv entry has no shell semantics
  * to get wrong.
  *
- * `APP_RUNTIME_OUT` still works for a direct absolute-path invocation; the bare
- * default remains the server app.
+ * `APP_RUNTIME_OUT` still works for a direct absolute-path invocation.
  */
 const appArg = process.argv[2]?.trim();
-const outDir = appArg
-  ? path.resolve(repoRoot, appArg, 'public/app-runtime')
-  : process.env.APP_RUNTIME_OUT
-    ? path.resolve(process.env.APP_RUNTIME_OUT)
-    : path.resolve(repoRoot, 'server/web/public/app-runtime');
+const appDir = path.resolve(process.cwd(), appArg ?? '.');
+const outDir = process.env.APP_RUNTIME_OUT
+  ? path.resolve(process.env.APP_RUNTIME_OUT)
+  : path.join(appDir, 'public/app-runtime');
+
+// Tripwire for the failure above: a Next app always has a `public/`, so its
+// absence means the resolved app directory is not an app and the runtime is
+// about to be written somewhere nothing serves. Fail loudly here rather than
+// print a cheerful success line pointing into node_modules. Skipped when
+// APP_RUNTIME_OUT names the destination outright.
+if (!process.env.APP_RUNTIME_OUT && !existsSync(path.join(appDir, 'public'))) {
+  console.error(
+    `app-runtime: ${appDir} has no public/ directory, so it is not an app.\n` +
+      `Run this from the app directory (paths resolve from the cwd), or pass an ` +
+      `absolute destination as APP_RUNTIME_OUT.`,
+  );
+  process.exit(1);
+}
 
 const manifest = await buildRuntime(outDir);
 const n = Object.keys(manifest.imports).length;