@crossplatformai/dependency-graph 0.10.0 → 0.11.0-next.1

package/dist/cli/pr-preview.d.ts

@@ -1,3 +1,5 @@
 #!/usr/bin/env node
+import { type WorkflowValidationResult } from '../index';
+export declare function formatWorkflowPathDrift(validationResults: WorkflowValidationResult[]): string[];
 export declare function runPrPreview(): Promise<void>;
 //# sourceMappingURL=pr-preview.d.ts.map

package/dist/cli/pr-preview.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"pr-preview.d.ts","sourceRoot":"","sources":["../../src/cli/pr-preview.ts"],"names":[],"mappings":";AAoLA,wBAAsB,YAAY,IAAI,OAAO,CAAC,IAAI,CAAC,CA6MlD"}
+{"version":3,"file":"pr-preview.d.ts","sourceRoot":"","sources":["../../src/cli/pr-preview.ts"],"names":[],"mappings":";AAQA,OAAO,EAOL,KAAK,wBAAwB,EAC9B,MAAM,UAAU,CAAC;AA0DlB,wBAAgB,uBAAuB,CACrC,iBAAiB,EAAE,wBAAwB,EAAE,GAC5C,MAAM,EAAE,CAyBV;AAsGD,wBAAsB,YAAY,IAAI,OAAO,CAAC,IAAI,CAAC,CA4NlD"}

package/dist/index-cli.js

@@ -208,12 +208,6 @@ var defaultWorkflowValidationPolicy = {
   includeDevDependenciesTransitively: false
 };
 
-// src/workflow/validator.ts
-import { existsSync as existsSync4 } from "fs";
-import { readFile } from "fs/promises";
-import { glob } from "glob";
-import { parse as parseYaml2 } from "yaml";
-
 // src/workflow/discovery.ts
 import { existsSync as existsSync2, readdirSync } from "fs";
 import { join as join3 } from "path";
@@ -333,11 +327,69 @@ function getExpectedWorkflowPaths({
   return uniqueSorted(expectedPaths);
 }
 
+// src/workflow/impact.ts
+function uniqueSorted2(values) {
+  return Array.from(new Set(values)).sort();
+}
+function mergeWorkflowPolicy(policyOverrides) {
+  return {
+    ...defaultWorkflowValidationPolicy,
+    ...policyOverrides,
+    allowedRootPaths: uniqueSorted2([
+      ...defaultWorkflowValidationPolicy.allowedRootPaths,
+      ...policyOverrides?.allowedRootPaths ?? []
+    ])
+  };
+}
+function matchesWorkflowPathFilter(changedPath, workflowPathFilter) {
+  if (workflowPathFilter === changedPath) {
+    return true;
+  }
+  if (!workflowPathFilter.endsWith("/**")) {
+    return false;
+  }
+  const workflowPrefix = workflowPathFilter.slice(0, -3);
+  return changedPath.startsWith(`${workflowPrefix}/`);
+}
+function getWorkflowImpacts(rootDir, packages, changedPaths, policyOverrides) {
+  const policy = mergeWorkflowPolicy(policyOverrides);
+  const workflowTargets = discoverWorkflowTargets(rootDir, packages, policy);
+  const { packageMap } = buildPackageMap(packages, rootDir);
+  return workflowTargets.map((workflowTarget) => {
+    const calculatedPaths = uniqueSorted2([
+      ...getExpectedWorkflowPaths({
+        workflowTarget,
+        packages,
+        packageMap,
+        policy
+      }),
+      ...policy.allowedRootPaths,
+      workflowTarget.workflowPath
+    ]);
+    const matchedPaths = calculatedPaths.filter(
+      (calculatedPath) => changedPaths.some(
+        (changedPath) => matchesWorkflowPathFilter(changedPath, calculatedPath)
+      )
+    );
+    return {
+      ...workflowTarget,
+      matchedPaths: uniqueSorted2(matchedPaths)
+    };
+  }).filter((workflowImpact) => workflowImpact.matchedPaths.length > 0);
+}
+
+// src/workflow/validator.ts
+import { existsSync as existsSync4 } from "fs";
+import { readFile } from "fs/promises";
+import { join as join5 } from "path";
+import { glob } from "glob";
+import { parse as parseYaml2 } from "yaml";
+
 // src/workflow/parser.ts
 import { existsSync as existsSync3, readFileSync } from "fs";
 import { join as join4 } from "path";
 import { parse as parseYaml } from "yaml";
-function uniqueSorted2(values) {
+function uniqueSorted3(values) {
   return Array.from(new Set(values)).sort();
 }
 function parseWorkflowFile(workflowFile, rootDir) {
@@ -350,9 +402,9 @@ function parseWorkflowFile(workflowFile, rootDir) {
   const pushPaths = workflow.on?.push?.paths ?? [];
   const pullRequestPaths = workflow.on?.pull_request?.paths ?? [];
   const parsedWorkflow = {
-    pushPaths: uniqueSorted2(pushPaths),
-    pullRequestPaths: uniqueSorted2(pullRequestPaths),
-    paths: uniqueSorted2([...pushPaths, ...pullRequestPaths])
+    pushPaths: uniqueSorted3(pushPaths),
+    pullRequestPaths: uniqueSorted3(pullRequestPaths),
+    paths: uniqueSorted3([...pushPaths, ...pullRequestPaths])
   };
   if (workflow.name) {
     parsedWorkflow.name = workflow.name;
@@ -361,7 +413,7 @@ function parseWorkflowFile(workflowFile, rootDir) {
 }
 
 // src/workflow/validator.ts
-function uniqueSorted3(values) {
+function uniqueSorted4(values) {
   return Array.from(new Set(values)).sort();
 }
 function buildBroadWildcards(workspaceRoots) {
@@ -372,6 +424,23 @@ function buildBroadWildcards(workspaceRoots) {
   }
   return wildcards;
 }
+function hasGlobSyntax(path) {
+  return /[*?[\]{}]/.test(path);
+}
+function getStalePathCheckBase(path, allowedRootPaths, workflowPath) {
+  if (path === workflowPath || allowedRootPaths.includes(path) || path.startsWith("!")) {
+    return null;
+  }
+  const trailingGlobSuffix = path.endsWith("/**") ? "/**" : path.endsWith("/*") ? "/*" : null;
+  const checkBase = trailingGlobSuffix ? path.slice(0, -trailingGlobSuffix.length) : path;
+  if (!checkBase || hasGlobSyntax(checkBase)) {
+    return null;
+  }
+  if (!trailingGlobSuffix && hasGlobSyntax(path)) {
+    return null;
+  }
+  return checkBase;
+}
 function splitActualPaths(paths, workspaceRoots, allowedRootPaths, workflowPath) {
   const workspacePaths = [];
   const ignoredPaths = [];
@@ -388,8 +457,8 @@ function splitActualPaths(paths, workspaceRoots, allowedRootPaths, workflowPath)
     ignoredPaths.push(path);
   }
   return {
-    workspacePaths: uniqueSorted3(workspacePaths),
-    ignoredPaths: uniqueSorted3(ignoredPaths)
+    workspacePaths: uniqueSorted4(workspacePaths),
+    ignoredPaths: uniqueSorted4(ignoredPaths)
   };
 }
 function isCoveredByExpectedPath(actualPath, expectedPaths) {
@@ -404,7 +473,7 @@ function isCoveredByExpectedPath(actualPath, expectedPaths) {
     return actualPath.startsWith(`${expectedPrefix}/`);
   });
 }
-function validateWorkflowResult(workflow, targetPackage, expectedPaths, actualPaths, broadWildcards) {
+function validateWorkflowResult(workflow, targetPackage, expectedPaths, actualPaths, broadWildcards, additionalIssues = []) {
   const issues = [];
   const missing = expectedPaths.filter((path) => !actualPaths.includes(path));
   const unnecessary = actualPaths.filter(
@@ -433,6 +502,7 @@ function validateWorkflowResult(workflow, targetPackage, expectedPaths, actualPa
       });
     }
   }
+  issues.push(...additionalIssues);
   return {
     workflow,
     targetPackage,
@@ -444,6 +514,25 @@ function validateWorkflowResult(workflow, targetPackage, expectedPaths, actualPa
     issues
   };
 }
+function getStalePathIssues(ignoredPaths, rootDir, allowedRootPaths, workflowPath) {
+  return ignoredPaths.flatMap((path) => {
+    const checkBase = getStalePathCheckBase(
+      path,
+      allowedRootPaths,
+      workflowPath
+    );
+    if (!checkBase || existsSync4(join5(rootDir, checkBase))) {
+      return [];
+    }
+    return [
+      {
+        kind: "stale-path",
+        path,
+        message: `Stale path '${path}' does not exist`
+      }
+    ];
+  });
+}
 async function validateWorkflows(rootDir, policyOverrides) {
   const discoveredPackages = await discoverWorkspaces(rootDir, {
     fs: {
@@ -460,7 +549,7 @@ async function validateWorkflows(rootDir, policyOverrides) {
   const policy = {
     ...defaultWorkflowValidationPolicy,
     ...policyOverrides,
-    allowedRootPaths: uniqueSorted3([
+    allowedRootPaths: uniqueSorted4([
       ...defaultWorkflowValidationPolicy.allowedRootPaths,
       ...policyOverrides?.allowedRootPaths ?? []
     ])
@@ -510,7 +599,7 @@ async function validateWorkflows(rootDir, policyOverrides) {
           issues: []
         };
       }
-      const { workspacePaths: actualPaths } = splitActualPaths(
+      const { workspacePaths: actualPaths, ignoredPaths } = splitActualPaths(
         parsedWorkflow.paths,
         workspaceRoots,
         policy.allowedRootPaths,
@@ -527,7 +616,13 @@ async function validateWorkflows(rootDir, policyOverrides) {
         workflowTarget.targetPackage,
         expectedPaths,
         actualPaths,
-        broadWildcards
+        broadWildcards,
+        getStalePathIssues(
+          ignoredPaths,
+          rootDir,
+          policy.allowedRootPaths,
+          workflowTarget.workflowPath
+        )
       );
     } catch (error) {
       return {
@@ -550,14 +645,6 @@ async function validateWorkflows(rootDir, policyOverrides) {
 }
 
 // src/cli/pr-preview.ts
-var WORKFLOW_MAPPING = {
-  "deploy-web.yml": "web",
-  "deploy-api-origin.yml": "api-origin",
-  "deploy-api-edge.yml": "api-edge",
-  "release-mobile.yml": "mobile",
-  "release-desktop.yml": "desktop",
-  "release-cli.yml": "cli"
-};
 var PLATFORM_INDICATORS = [
   {
     platform: "cloudflare-workers",
@@ -596,6 +683,28 @@ var PLATFORM_INDICATORS = [
   }
 ];
 var DEFAULT_APP_DIRECTORIES = ["apps"];
+function formatWorkflowPathDrift(validationResults) {
+  const invalidResults = validationResults.filter((result) => !result.valid);
+  if (invalidResults.length === 0) {
+    return [];
+  }
+  const lines = [
+    "\u26A0\uFE0F Workflow path drift (advisory - does not affect impact above):"
+  ];
+  for (const result of invalidResults) {
+    lines.push(`  ${result.workflow} (${result.targetPackage}):`);
+    for (const issue of result.issues) {
+      if (issue.kind === "missing") {
+        lines.push(`    + ${issue.message}`);
+      } else if (issue.kind === "unnecessary") {
+        lines.push(`    - ${issue.message}`);
+      } else {
+        lines.push(`    ! ${issue.message}`);
+      }
+    }
+  }
+  return lines;
+}
 function isDeployableApp(pkg) {
   const isInAppDirectory = DEFAULT_APP_DIRECTORIES.some(
     (dir) => pkg.path.includes(`/${dir}/`) || pkg.path.endsWith(`/${dir}`)
@@ -713,23 +822,32 @@ async function runPrPreview() {
         changedPackages.add(pkg.name);
       }
     }
-    const changedWorkflows = changedFiles.filter(
-      (f) => f.path.startsWith(".github/workflows/")
+    const workflowImpacts = getWorkflowImpacts(
+      rootDir,
+      packages,
+      changedFiles.map((file) => file.path)
+    );
+    const workflowDriftLines = formatWorkflowPathDrift(
+      await validateWorkflows(rootDir)
+    );
+    const workflowAffectedApps = new Set(
+      workflowImpacts.map(
+        (workflowImpact) => workflowImpact.targetPackage ?? workflowImpact.targetSlug
+      )
     );
-    const workflowAffectedApps = /* @__PURE__ */ new Set();
-    for (const workflow of changedWorkflows) {
-      const workflowName = workflow.path.split("/").pop();
-      if (workflowName && WORKFLOW_MAPPING[workflowName]) {
-        workflowAffectedApps.add(WORKFLOW_MAPPING[workflowName]);
-      }
-    }
     console.log(
       `
 \u{1F4E6} Changed packages: ${Array.from(changedPackages).join(", ") || "none"}
 `
     );
-    if (changedPackages.size === 0) {
-      console.log("\n\u2728 No packages changed - no deployments needed\n");
+    if (changedPackages.size === 0 && workflowAffectedApps.size === 0) {
+      console.log(
+        "\n\u2728 No packages or workflow filters changed - no deployments needed\n"
+      );
+      if (workflowDriftLines.length > 0) {
+        console.log(workflowDriftLines.join("\n"));
+        console.log("");
+      }
       return;
     }
     const affected = findAffectedPackages(changedPackages, graph, {
@@ -826,6 +944,10 @@ async function runPrPreview() {
     console.log(`\u{1F4DD} = File changed`);
     console.log(`\u274C = File deleted
 `);
+    if (workflowDriftLines.length > 0) {
+      console.log(workflowDriftLines.join("\n"));
+      console.log("");
+    }
   } catch (error) {
     console.error(
       "Error:",
@@ -840,10 +962,10 @@ if (import.meta.url === new URL(process.argv[1] ?? "", "file:").href) {
 
 // src/cli/validate-workflows.ts
 import { existsSync as existsSync5, readFileSync as readFileSync3, readdirSync as readdirSync2 } from "fs";
-import { join as join5, resolve as resolve3 } from "path";
+import { join as join6, resolve as resolve3 } from "path";
 import { parse as parseYaml4 } from "yaml";
 function discoverPnpmWorkflows(rootDir) {
-  const workflowsDir = join5(rootDir, ".github/workflows");
+  const workflowsDir = join6(rootDir, ".github/workflows");
   if (!existsSync5(workflowsDir)) {
     return [];
   }
@@ -852,7 +974,7 @@ function discoverPnpmWorkflows(rootDir) {
     (file) => file.endsWith(".yml")
   );
   for (const file of files) {
-    const content = readFileSync3(join5(workflowsDir, file), "utf-8");
+    const content = readFileSync3(join6(workflowsDir, file), "utf-8");
     if (content.includes("pnpm/action-setup")) {
       workflows.push(file);
     }
@@ -865,12 +987,12 @@ function discoverPnpmDockerfiles(rootDir) {
     if (!entry.startsWith("Dockerfile")) {
       continue;
     }
-    const content = readFileSync3(join5(rootDir, entry), "utf-8");
+    const content = readFileSync3(join6(rootDir, entry), "utf-8");
     if (content.includes("pnpm@")) {
       dockerfiles.push(entry);
     }
   }
-  const appsDir = join5(rootDir, "apps");
+  const appsDir = join6(rootDir, "apps");
   if (!existsSync5(appsDir)) {
     return dockerfiles;
   }
@@ -878,7 +1000,7 @@ function discoverPnpmDockerfiles(rootDir) {
     if (!entry.isDirectory()) {
       continue;
     }
-    const dockerfilePath = join5(appsDir, entry.name, "Dockerfile");
+    const dockerfilePath = join6(appsDir, entry.name, "Dockerfile");
     if (!existsSync5(dockerfilePath)) {
       continue;
     }
@@ -891,7 +1013,7 @@ function discoverPnpmDockerfiles(rootDir) {
 }
 function getExpectedPnpmVersion(rootDir) {
   const packageJson = JSON.parse(
-    readFileSync3(join5(rootDir, "package.json"), "utf-8")
+    readFileSync3(join6(rootDir, "package.json"), "utf-8")
   );
   const packageManager = packageJson.packageManager;
   if (!packageManager?.startsWith("pnpm@")) {
@@ -900,7 +1022,7 @@ function getExpectedPnpmVersion(rootDir) {
   return packageManager.replace("pnpm@", "");
 }
 function checkWorkflowPnpmVersion(workflowFile, rootDir) {
-  const workflowPath = join5(rootDir, ".github/workflows", workflowFile);
+  const workflowPath = join6(rootDir, ".github/workflows", workflowFile);
   if (!existsSync5(workflowPath)) {
     return { valid: true };
   }
@@ -923,7 +1045,7 @@ function checkWorkflowPnpmVersion(workflowFile, rootDir) {
   return { valid: true };
 }
 function checkDockerfilePnpmVersion(dockerfile, expectedVersion, rootDir) {
-  const dockerfilePath = join5(rootDir, dockerfile);
+  const dockerfilePath = join6(rootDir, dockerfile);
   if (!existsSync5(dockerfilePath)) {
     return { valid: true };
   }