@croptop/core-v6 0.0.13 → 0.0.15

package/STYLE_GUIDE.md

@@ -197,7 +197,7 @@ interface IJBExample is IJBBase {
 | Public/external function | `camelCase` | `cashOutTokensOf` |
 | Internal/private function | `_camelCase` | `_processFee` |
 | Internal storage | `_camelCase` | `_accountingContextForTokenOf` |
-| Function parameter | `camelCase` | `projectId`, `cashOutCount` |
+| Function parameter | `camelCase` (no underscores) | `projectId`, `cashOutCount` |
 
 ## NatSpec
 
@@ -253,9 +253,12 @@ uint256 public constant MAX_RESERVED_PERCENT = 10_000;
 
 ## Function Calls
 
-Use named parameters for readability when calling functions with 3+ arguments:
+Use named arguments for all function calls with 2 or more arguments — in both `src/` and `script/`:
 
 ```solidity
+// Good — named arguments
+token.mint({account: beneficiary, amount: count});
+_transferOwnership({newOwner: address(0), projectId: 0});
 PERMISSIONS.hasPermission({
     operator: sender,
     account: account,
@@ -264,8 +267,18 @@ PERMISSIONS.hasPermission({
     includeRoot: true,
     includeWildcardProjectId: true
 });
+
+// Bad — positional arguments with 2+ args
+token.mint(beneficiary, count);
+_transferOwnership(address(0), 0);
 ```
 
+Single-argument calls use positional style: `_burn(amount)`.
+
+This also applies to constructor calls, struct literals, and inherited/library calls (e.g., OZ `_mint`, `_safeMint`, `safeTransfer`, `allowance`, `Clones.cloneDeterministic`).
+
+Named argument keys must use **camelCase** — never underscores. If a function's parameter names use underscores, rename them to camelCase first.
+
 ## Multiline Signatures
 
 ```solidity

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@croptop/core-v6",
-    "version": "0.0.13",
+    "version": "0.0.15",
     "license": "MIT",
     "repository": {
         "type": "git",
@@ -16,17 +16,17 @@
         "artifacts": "source ./.env && npx sphinx artifacts --org-id 'ea165b21-7cdc-4d7b-be59-ecdd4c26bee4' --project-name 'croptop-core-v5'"
     },
     "dependencies": {
-        "@bananapus/721-hook-v6": "^0.0.14",
-        "@bananapus/buyback-hook-v6": "^0.0.9",
-        "@bananapus/core-v6": "^0.0.15",
-        "@bananapus/ownable-v6": "^0.0.7",
-        "@bananapus/permission-ids-v6": "^0.0.7",
-        "@bananapus/router-terminal-v6": "^0.0.9",
-        "@bananapus/suckers-v6": "^0.0.8",
+        "@bananapus/721-hook-v6": "^0.0.16",
+        "@bananapus/buyback-hook-v6": "^0.0.12",
+        "@bananapus/core-v6": "^0.0.16",
+        "@bananapus/ownable-v6": "^0.0.9",
+        "@bananapus/permission-ids-v6": "^0.0.9",
+        "@bananapus/router-terminal-v6": "^0.0.11",
+        "@bananapus/suckers-v6": "^0.0.10",
         "@openzeppelin/contracts": "^5.6.1"
     },
     "devDependencies": {
-        "@rev-net/core-v6": "^0.0.8",
+        "@rev-net/core-v6": "^0.0.11",
         "@sphinx-labs/plugins": "^0.33.1"
     }
 }

package/script/ConfigureFeeProject.s.sol

@@ -1,21 +1,25 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import "@bananapus/721-hook-v6/script/helpers/Hook721DeploymentLib.sol";
-import "@bananapus/core-v6/script/helpers/CoreDeploymentLib.sol";
-import "@bananapus/suckers-v6/script/helpers/SuckerDeploymentLib.sol";
-import "@bananapus/router-terminal-v6/script/helpers/RouterTerminalDeploymentLib.sol";
-import "@rev-net/core-v6/script/helpers/RevnetCoreDeploymentLib.sol";
-import "./helpers/CroptopDeploymentLib.sol";
+import {Hook721Deployment, Hook721DeploymentLib} from "@bananapus/721-hook-v6/script/helpers/Hook721DeploymentLib.sol";
+import {CoreDeployment, CoreDeploymentLib} from "@bananapus/core-v6/script/helpers/CoreDeploymentLib.sol";
+import {SuckerDeployment, SuckerDeploymentLib} from "@bananapus/suckers-v6/script/helpers/SuckerDeploymentLib.sol";
+import {
+    RouterTerminalDeployment,
+    RouterTerminalDeploymentLib
+} from "@bananapus/router-terminal-v6/script/helpers/RouterTerminalDeploymentLib.sol";
+import {
+    RevnetCoreDeployment,
+    RevnetCoreDeploymentLib
+} from "@rev-net/core-v6/script/helpers/RevnetCoreDeploymentLib.sol";
+import {CroptopDeployment, CroptopDeploymentLib} from "./helpers/CroptopDeploymentLib.sol";
 
 import {Sphinx} from "@sphinx-labs/contracts/contracts/foundry/SphinxPlugin.sol";
 import {Script} from "forge-std/Script.sol";
 
 import {IJB721TokenUriResolver} from "@bananapus/721-hook-v6/src/interfaces/IJB721TokenUriResolver.sol";
-import {JBDeploy721TiersHookConfig} from "@bananapus/721-hook-v6/src/structs/JBDeploy721TiersHookConfig.sol";
 import {JB721InitTiersConfig} from "@bananapus/721-hook-v6/src/structs/JB721InitTiersConfig.sol";
 import {JB721TierConfig} from "@bananapus/721-hook-v6/src/structs/JB721TierConfig.sol";
-import {JB721TiersHookFlags} from "@bananapus/721-hook-v6/src/structs/JB721TiersHookFlags.sol";
 import {IJBSplitHook} from "@bananapus/core-v6/src/interfaces/IJBSplitHook.sol";
 import {IJBTerminal} from "@bananapus/core-v6/src/interfaces/IJBTerminal.sol";
 import {JBAccountingContext} from "@bananapus/core-v6/src/structs/JBAccountingContext.sol";
@@ -28,6 +32,8 @@ import {JBTokenMapping} from "@bananapus/suckers-v6/src/structs/JBTokenMapping.s
 import {REVAutoIssuance} from "@rev-net/core-v6/src/structs/REVAutoIssuance.sol";
 import {REVConfig} from "@rev-net/core-v6/src/structs/REVConfig.sol";
 import {REVCroptopAllowedPost} from "@rev-net/core-v6/src/structs/REVCroptopAllowedPost.sol";
+import {REVBaseline721HookConfig} from "@rev-net/core-v6/src/structs/REVBaseline721HookConfig.sol";
+import {REV721TiersHookFlags} from "@rev-net/core-v6/src/structs/REV721TiersHookFlags.sol";
 import {REVDeploy721TiersHookConfig} from "@rev-net/core-v6/src/structs/REVDeploy721TiersHookConfig.sol";
 import {REVDescription} from "@rev-net/core-v6/src/structs/REVDescription.sol";
 import {REVStageConfig} from "@rev-net/core-v6/src/structs/REVStageConfig.sol";
@@ -57,25 +63,44 @@ contract ConfigureFeeProjectScript is Script, Sphinx {
 
     // @notice set this to a non-zero value to re-use an existing projectID. Having it set to 0 will deploy a new
     // fee_project.
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 FEE_PROJECT_ID;
 
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint32 PREMINT_CHAIN_ID = 1;
+    // forge-lint: disable-next-line(mixed-case-variable)
     string NAME = "Croptop Publishing Network";
+    // forge-lint: disable-next-line(mixed-case-variable)
     string SYMBOL = "CPN";
+    // forge-lint: disable-next-line(mixed-case-variable)
     string PROJECT_URI = "ipfs://QmUAFevoMn1iqSEQR8LogQYRxm39TNxQTPYnuLuq5BmfEi";
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint32 NATIVE_CURRENCY = uint32(uint160(JBConstants.NATIVE_TOKEN));
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint32 ETH_CURRENCY = JBCurrencyIds.ETH;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint8 DECIMALS = 18;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 DECIMAL_MULTIPLIER = 10 ** DECIMALS;
+    // forge-lint: disable-next-line(mixed-case-variable)
     bytes32 SUCKER_SALT = "_CPN_SUCKERV6__";
+    // forge-lint: disable-next-line(mixed-case-variable)
     bytes32 ERC20_SALT = "_CPN_ERC20_SALTV6__";
+    // forge-lint: disable-next-line(mixed-case-variable)
     bytes32 HOOK_SALT = "_CPN_HOOK_SALTV6__";
+    // forge-lint: disable-next-line(mixed-case-variable)
     address OPERATOR;
+    // forge-lint: disable-next-line(mixed-case-variable)
     address TRUSTED_FORWARDER;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint48 CPN_START_TIME = 1_740_089_444;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint104 CPN_MAINNET_AUTO_ISSUANCE_ = 250_003_875_000_000_000_000_000;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint104 CPN_OP_AUTO_ISSUANCE_ = 844_894_881_600_000_000_000;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint104 CPN_BASE_AUTO_ISSUANCE_ = 844_894_881_600_000_000_000;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint104 CPN_ARB_AUTO_ISSUANCE_ = 3_844_000_000_000_000_000;
 
     function configureSphinx() public override {
@@ -168,6 +193,7 @@ contract ConfigureFeeProjectScript is Script, Sphinx {
             autoIssuances: issuanceConfs,
             splitPercent: 3800, // 38%
             splits: splits,
+            // forge-lint: disable-next-line(unsafe-typecast)
             initialIssuance: uint112(10_000 * DECIMAL_MULTIPLIER),
             issuanceCutFrequency: 120 days,
             issuanceCutPercent: 380_000_000, // 38%
@@ -201,7 +227,7 @@ contract ConfigureFeeProjectScript is Script, Sphinx {
 
         // The project's revnet configuration
         REVConfig memory revnetConfiguration = REVConfig({
-            description: REVDescription(NAME, SYMBOL, PROJECT_URI, ERC20_SALT),
+            description: REVDescription({name: NAME, ticker: SYMBOL, uri: PROJECT_URI, salt: ERC20_SALT}),
             baseCurrency: ETH_CURRENCY,
             splitOperator: OPERATOR,
             stageConfigurations: stageConfigurations
@@ -298,22 +324,21 @@ contract ConfigureFeeProjectScript is Script, Sphinx {
             terminalConfigurations: terminalConfigurations,
             suckerDeploymentConfiguration: suckerDeploymentConfiguration,
             hookConfiguration: REVDeploy721TiersHookConfig({
-                baseline721HookConfiguration: JBDeploy721TiersHookConfig({
+                baseline721HookConfiguration: REVBaseline721HookConfig({
                     name: NAME,
                     symbol: SYMBOL,
                     baseUri: "ipfs://",
                     tokenUriResolver: IJB721TokenUriResolver(address(0)),
                     contractUri: "",
                     tiersConfig: JB721InitTiersConfig({
-                        tiers: new JB721TierConfig[](0), currency: ETH_CURRENCY, decimals: DECIMALS, prices: core.prices
+                        tiers: new JB721TierConfig[](0), currency: ETH_CURRENCY, decimals: DECIMALS
                     }),
                     reserveBeneficiary: address(0),
-                    flags: JB721TiersHookFlags({
+                    flags: REV721TiersHookFlags({
                         noNewTiersWithReserves: false,
                         noNewTiersWithVotes: true,
                         noNewTiersWithOwnerMinting: true,
-                        preventOverspending: false,
-                        issueTokensForSplits: false
+                        preventOverspending: false
                     })
                 }),
                 salt: HOOK_SALT,
@@ -330,7 +355,7 @@ contract ConfigureFeeProjectScript is Script, Sphinx {
         FeeProjectConfig memory feeProjectConfig = getCroptopRevnetConfig();
 
         // Approve the basic deployer to configure the project and transfer it.
-        core.projects.approve(address(revnet.basic_deployer), FEE_PROJECT_ID);
+        core.projects.approve({to: address(revnet.basic_deployer), tokenId: FEE_PROJECT_ID});
 
         // Deploy the NANA fee project.
         revnet.basic_deployer

package/script/Deploy.s.sol

@@ -1,9 +1,9 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import "@bananapus/721-hook-v6/script/helpers/Hook721DeploymentLib.sol";
-import "@bananapus/core-v6/script/helpers/CoreDeploymentLib.sol";
-import "@bananapus/suckers-v6/script/helpers/SuckerDeploymentLib.sol";
+import {Hook721Deployment, Hook721DeploymentLib} from "@bananapus/721-hook-v6/script/helpers/Hook721DeploymentLib.sol";
+import {CoreDeployment, CoreDeploymentLib} from "@bananapus/core-v6/script/helpers/CoreDeploymentLib.sol";
+import {SuckerDeployment, SuckerDeploymentLib} from "@bananapus/suckers-v6/script/helpers/SuckerDeploymentLib.sol";
 
 import {Sphinx} from "@sphinx-labs/contracts/contracts/foundry/SphinxPlugin.sol";
 import {Script} from "forge-std/Script.sol";
@@ -22,12 +22,17 @@ contract DeployScript is Script, Sphinx {
 
     // @notice set this to a non-zero value to re-use an existing projectID. Having it set to 0 will deploy a new
     // fee_project.
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 FEE_PROJECT_ID = 0;
 
     /// @notice the salts that are used to deploy the contracts.
+    // forge-lint: disable-next-line(mixed-case-variable)
     bytes32 PUBLISHER_SALT = "_PUBLISHER_SALTV6_";
+    // forge-lint: disable-next-line(mixed-case-variable)
     bytes32 DEPLOYER_SALT = "_DEPLOYER_SALTV6_";
+    // forge-lint: disable-next-line(mixed-case-variable)
     bytes32 PROJECT_OWNER_SALT = "_PROJECT_OWNER_SALTV6_";
+    // forge-lint: disable-next-line(mixed-case-variable)
     address TRUSTED_FORWARDER;
 
     function configureSphinx() public override {
@@ -67,51 +72,61 @@ contract DeployScript is Script, Sphinx {
         CTPublisher publisher;
         {
             // Perform the check for the publisher.
-            (address _publisher, bool _publisherIsDeployed) = _isDeployed(
-                PUBLISHER_SALT,
-                type(CTPublisher).creationCode,
-                abi.encode(core.directory, core.permissions, FEE_PROJECT_ID, TRUSTED_FORWARDER)
-            );
+            (address _publisher, bool _publisherIsDeployed) = _isDeployed({
+                salt: PUBLISHER_SALT,
+                creationCode: type(CTPublisher).creationCode,
+                arguments: abi.encode(core.directory, core.permissions, FEE_PROJECT_ID, TRUSTED_FORWARDER)
+            });
 
             // Deploy it if it has not been deployed yet.
             publisher = !_publisherIsDeployed
-                ? new CTPublisher{salt: PUBLISHER_SALT}(
-                    core.directory, core.permissions, FEE_PROJECT_ID, TRUSTED_FORWARDER
-                )
+                ? new CTPublisher{salt: PUBLISHER_SALT}({
+                    directory: core.directory,
+                    permissions: core.permissions,
+                    feeProjectId: FEE_PROJECT_ID,
+                    trustedForwarder: TRUSTED_FORWARDER
+                })
                 : CTPublisher(_publisher);
         }
 
         CTDeployer deployer;
         {
             // Perform the check for the publisher.
-            (address _deployer, bool _deployerIsDeployed) = _isDeployed(
-                DEPLOYER_SALT,
-                type(CTDeployer).creationCode,
-                abi.encode(
+            (address _deployer, bool _deployerIsDeployed) = _isDeployed({
+                salt: DEPLOYER_SALT,
+                creationCode: type(CTDeployer).creationCode,
+                arguments: abi.encode(
                     core.permissions, core.projects, hook.hook_deployer, publisher, suckers.registry, TRUSTED_FORWARDER
                 )
-            );
+            });
 
             // Deploy it if it has not been deployed yet.
             deployer = !_deployerIsDeployed
-                ? new CTDeployer{salt: DEPLOYER_SALT}(
-                    core.permissions, core.projects, hook.hook_deployer, publisher, suckers.registry, TRUSTED_FORWARDER
-                )
+                ? new CTDeployer{salt: DEPLOYER_SALT}({
+                    permissions: core.permissions,
+                    projects: core.projects,
+                    deployer: hook.hook_deployer,
+                    publisher: publisher,
+                    suckerRegistry: suckers.registry,
+                    trustedForwarder: TRUSTED_FORWARDER
+                })
                 : CTDeployer(_deployer);
         }
 
         CTProjectOwner owner;
         {
             // Perform the check for the publisher.
-            (address _owner, bool _ownerIsDeployed) = _isDeployed(
-                PROJECT_OWNER_SALT,
-                type(CTProjectOwner).creationCode,
-                abi.encode(core.permissions, core.projects, publisher)
-            );
+            (address _owner, bool _ownerIsDeployed) = _isDeployed({
+                salt: PROJECT_OWNER_SALT,
+                creationCode: type(CTProjectOwner).creationCode,
+                arguments: abi.encode(core.permissions, core.projects, publisher)
+            });
 
             // Deploy it if it has not been deployed yet.
             owner = !_ownerIsDeployed
-                ? new CTProjectOwner{salt: PROJECT_OWNER_SALT}(core.permissions, core.projects, publisher)
+                ? new CTProjectOwner{salt: PROJECT_OWNER_SALT}({
+                    permissions: core.permissions, projects: core.projects, publisher: publisher
+                })
                 : CTProjectOwner(_owner);
         }
     }

package/script/helpers/CroptopDeploymentLib.sol

@@ -13,12 +13,14 @@ import {CTProjectOwner} from "../../src/CTProjectOwner.sol";
 struct CroptopDeployment {
     CTPublisher publisher;
     CTDeployer deployer;
+    // forge-lint: disable-next-line(mixed-case-variable)
     CTProjectOwner project_owner;
 }
 
 library CroptopDeploymentLib {
     // Cheat code address, 0x7109709ECfa91a80626fF3989D68f67F5b1DD12D.
     address internal constant VM_ADDRESS = address(uint160(uint256(keccak256("hevm cheat code"))));
+    // forge-lint: disable-next-line(screaming-snake-case-const)
     Vm internal constant vm = Vm(VM_ADDRESS);
 
     function getDeployment(string memory path) internal returns (CroptopDeployment memory deployment) {
@@ -41,16 +43,28 @@ library CroptopDeploymentLib {
 
     function getDeployment(
         string memory path,
+        // forge-lint: disable-next-line(mixed-case-variable)
         string memory network_name
     )
         internal
         view
         returns (CroptopDeployment memory deployment)
     {
-        deployment.publisher = CTPublisher(_getDeploymentAddress(path, "croptop-core-v6", network_name, "CTPublisher"));
-        deployment.deployer = CTDeployer(_getDeploymentAddress(path, "croptop-core-v6", network_name, "CTDeployer"));
-        deployment.project_owner =
-            CTProjectOwner(_getDeploymentAddress(path, "croptop-core-v6", network_name, "CTProjectOwner"));
+        deployment.publisher = CTPublisher(
+            _getDeploymentAddress({
+                path: path, project_name: "croptop-core-v6", network_name: network_name, contractName: "CTPublisher"
+            })
+        );
+        deployment.deployer = CTDeployer(
+            _getDeploymentAddress({
+                path: path, project_name: "croptop-core-v6", network_name: network_name, contractName: "CTDeployer"
+            })
+        );
+        deployment.project_owner = CTProjectOwner(
+            _getDeploymentAddress({
+                path: path, project_name: "croptop-core-v6", network_name: network_name, contractName: "CTProjectOwner"
+            })
+        );
     }
 
     /// @notice Get the address of a contract that was deployed by the Deploy script.
@@ -60,7 +74,9 @@ library CroptopDeploymentLib {
     /// @return The address of the contract.
     function _getDeploymentAddress(
         string memory path,
+        // forge-lint: disable-next-line(mixed-case-variable)
         string memory project_name,
+        // forge-lint: disable-next-line(mixed-case-variable)
         string memory network_name,
         string memory contractName
     )
@@ -69,7 +85,8 @@ library CroptopDeploymentLib {
         returns (address)
     {
         string memory deploymentJson =
-            vm.readFile(string.concat(path, project_name, "/", network_name, "/", contractName, ".json"));
-        return stdJson.readAddress(deploymentJson, ".address");
+        // forge-lint: disable-next-line(unsafe-cheatcode)
+        vm.readFile(string.concat(path, project_name, "/", network_name, "/", contractName, ".json"));
+        return stdJson.readAddress({json: deploymentJson, key: ".address"});
     }
 }

package/src/CTDeployer.sol

@@ -25,7 +25,6 @@ import {JBPayHookSpecification} from "@bananapus/core-v6/src/structs/JBPayHookSp
 import {JBPermissionsData} from "@bananapus/core-v6/src/structs/JBPermissionsData.sol";
 import {JBRuleset} from "@bananapus/core-v6/src/structs/JBRuleset.sol";
 import {JBRulesetConfig} from "@bananapus/core-v6/src/structs/JBRulesetConfig.sol";
-import {JBTerminalConfig} from "@bananapus/core-v6/src/structs/JBTerminalConfig.sol";
 import {JBOwnable} from "@bananapus/ownable-v6/src/JBOwnable.sol";
 import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
 import {IJBSuckerRegistry} from "@bananapus/suckers-v6/src/interfaces/IJBSuckerRegistry.sol";
@@ -269,10 +268,7 @@ contract CTDeployer is ERC2771Context, JBPermissioned, IJBRulesetDataHook, IERC7
                 tokenUriResolver: IJB721TokenUriResolver(address(0)),
                 contractUri: projectConfig.contractUri,
                 tiersConfig: JB721InitTiersConfig({
-                    tiers: new JB721TierConfig[](0),
-                    currency: JBCurrencyIds.ETH,
-                    decimals: 18,
-                    prices: controller.PRICES()
+                    tiers: new JB721TierConfig[](0), currency: JBCurrencyIds.ETH, decimals: 18
                 }),
                 reserveBeneficiary: address(0),
                 flags: JB721TiersHookFlags({
@@ -322,7 +318,7 @@ contract CTDeployer is ERC2771Context, JBPermissioned, IJBRulesetDataHook, IERC7
         }
 
         //transfer to _owner.
-        PROJECTS.transferFrom(address(this), owner, projectId);
+        PROJECTS.transferFrom({from: address(this), to: owner, tokenId: projectId});
 
         // Set permission for the project's owner to do all the NFT things.
         uint8[] memory permissionIds = new uint8[](4);
@@ -334,7 +330,10 @@ contract CTDeployer is ERC2771Context, JBPermissioned, IJBRulesetDataHook, IERC7
         PERMISSIONS.setPermissionsFor({
             account: address(this),
             permissionsData: JBPermissionsData({
-                operator: address(owner), projectId: uint64(projectId), permissionIds: permissionIds
+                operator: address(owner),
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectId: uint64(projectId),
+                permissionIds: permissionIds
             })
         });
     }

package/src/CTProjectOwner.sol

@@ -69,7 +69,10 @@ contract CTProjectOwner is IERC721Receiver, ICTProjectOwner {
         PERMISSIONS.setPermissionsFor({
             account: address(this),
             permissionsData: JBPermissionsData({
-                operator: address(PUBLISHER), projectId: uint56(tokenId), permissionIds: permissionIds
+                operator: address(PUBLISHER),
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectId: uint56(tokenId),
+                permissionIds: permissionIds
             })
         });
 

package/src/CTPublisher.sol

@@ -26,6 +26,7 @@ contract CTPublisher is JBPermissioned, ERC2771Context, ICTPublisher {
     // --------------------------- custom errors ------------------------- //
     //*********************************************************************//
 
+    // forge-lint: disable-next-line(mixed-case-variable)
     error CTPublisher_DuplicatePost(bytes32 encodedIPFSUri);
     error CTPublisher_EmptyEncodedIPFSUri();
     error CTPublisher_InsufficientEthSent(uint256 expected, uint256 sent);
@@ -63,6 +64,7 @@ contract CTPublisher is JBPermissioned, ERC2771Context, ICTPublisher {
     /// @notice The ID of the tier that an IPFS metadata has been saved to.
     /// @custom:param hook The hook for which the tier ID applies.
     /// @custom:param encodedIPFSUri The IPFS URI.
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(address hook => mapping(bytes32 encodedIPFSUri => uint256)) public override tierIdForEncodedIPFSUriOf;
 
     //*********************************************************************//
@@ -112,6 +114,7 @@ contract CTPublisher is JBPermissioned, ERC2771Context, ICTPublisher {
     /// is returned.
     function tiersFor(
         address hook,
+        // forge-lint: disable-next-line(mixed-case-variable)
         bytes32[] memory encodedIPFSUris
     )
         external
@@ -119,6 +122,7 @@ contract CTPublisher is JBPermissioned, ERC2771Context, ICTPublisher {
         override
         returns (JB721Tier[] memory tiers)
     {
+        // forge-lint: disable-next-line(mixed-case-variable)
         uint256 numberOfEncodedIPFSUris = encodedIPFSUris.length;
 
         // Initialize the tier array being returned.
@@ -170,12 +174,16 @@ contract CTPublisher is JBPermissioned, ERC2771Context, ICTPublisher {
         uint256 packed = _packedAllowanceFor[hook][category];
 
         // minimum price in bits 0-103 (104 bits).
+        // forge-lint: disable-next-line(unsafe-typecast)
         minimumPrice = uint256(uint104(packed));
         // minimum supply in bits 104-135 (32 bits).
+        // forge-lint: disable-next-line(unsafe-typecast)
         minimumTotalSupply = uint256(uint32(packed >> 104));
         // maximum supply in bits 136-167 (32 bits).
+        // forge-lint: disable-next-line(unsafe-typecast)
         maximumTotalSupply = uint256(uint32(packed >> 136));
         // maximum split percent in bits 168-199 (32 bits).
+        // forge-lint: disable-next-line(unsafe-typecast)
         maximumSplitPercent = uint256(uint32(packed >> 168));
 
         allowedAddresses = _allowedAddresses[hook][category];
@@ -445,6 +453,7 @@ contract CTPublisher is JBPermissioned, ERC2771Context, ICTPublisher {
             CTPost memory post = posts[i];
 
             // Make sure the post includes an encodedIPFSUri.
+            // forge-lint: disable-next-line(unsafe-typecast)
             if (post.encodedIPFSUri == bytes32("")) {
                 revert CTPublisher_EmptyEncodedIPFSUri();
             }
@@ -473,7 +482,7 @@ contract CTPublisher is JBPermissioned, ERC2771Context, ICTPublisher {
                         // For existing tiers, use the actual tier price (not the user-supplied post.price)
                         // to prevent fee evasion by passing price=0 for an existing tier.
                         // slither-disable-next-line calls-loop
-                        totalPrice += store.tierOf(address(hook), tierId, false).price;
+                        totalPrice += store.tierOf({hook: address(hook), id: tierId, includeResolvedUri: false}).price;
                     }
                 }
             }
@@ -519,7 +528,7 @@ contract CTPublisher is JBPermissioned, ERC2771Context, ICTPublisher {
                     }
 
                     // Make sure the address is allowed to post.
-                    if (addresses.length != 0 && !_isAllowed(_msgSender(), addresses)) {
+                    if (addresses.length != 0 && !_isAllowed({addrs: _msgSender(), addresses: addresses})) {
                         revert CTPublisher_NotInAllowList(_msgSender(), addresses);
                     }
                 }

package/src/interfaces/ICTPublisher.sol

@@ -73,6 +73,7 @@ interface ICTPublisher {
     /// @param hook The hook for which the tier ID applies.
     /// @param encodedIPFSUri The encoded IPFS URI to look up.
     /// @return The tier ID, or 0 if the URI has not been published.
+    // forge-lint: disable-next-line(mixed-case-function, mixed-case-variable)
     function tierIdForEncodedIPFSUriOf(address hook, bytes32 encodedIPFSUri) external view returns (uint256);
 
     /// @notice Get the tiers for the provided encoded IPFS URIs.
@@ -80,6 +81,7 @@ interface ICTPublisher {
     /// @param encodedIPFSUris The URIs to get tiers of.
     /// @return tiers The tiers that correspond to the provided encoded IPFS URIs. Empty tiers are returned for URIs
     /// without a tier.
+    // forge-lint: disable-next-line(mixed-case-variable)
     function tiersFor(address hook, bytes32[] memory encodedIPFSUris) external view returns (JB721Tier[] memory tiers);
 
     /// @notice Configure the allowed criteria for publishing new NFTs to a hook.

package/src/structs/CTAllowedPost.sol

@@ -11,6 +11,7 @@ pragma solidity ^0.8.0;
 /// @custom:member maximumSplitPercent The maximum split percent (out of JBConstants.SPLITS_TOTAL_PERCENT) that a
 /// poster can set. 0 means splits are not allowed.
 /// @custom:member allowedAddresses A list of addresses that are allowed to post on the category through Croptop.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct CTAllowedPost {
     address hook;
     uint24 category;

package/src/structs/CTDeployerAllowedPost.sol

@@ -10,6 +10,7 @@ pragma solidity ^0.8.0;
 /// @custom:member maximumSplitPercent The maximum split percent (out of JBConstants.SPLITS_TOTAL_PERCENT) that a
 /// poster can set. 0 means splits are not allowed.
 /// @custom:member allowedAddresses A list of addresses that are allowed to post on the category through Croptop.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct CTDeployerAllowedPost {
     uint24 category;
     uint104 minimumPrice;

package/src/structs/CTPost.sol

@@ -12,7 +12,9 @@ import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
 /// @custom:member splitPercent The percent of the tier's price to route to the splits (out of
 /// JBConstants.SPLITS_TOTAL_PERCENT).
 /// @custom:member splits The splits to route funds to when this tier is minted.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct CTPost {
+    // forge-lint: disable-next-line(mixed-case-variable)
     bytes32 encodedIPFSUri;
     uint32 totalSupply;
     uint104 price;

package/src/structs/CTProjectConfig.sol

@@ -11,6 +11,7 @@ import {CTDeployerAllowedPost} from "../structs/CTDeployerAllowedPost.sol";
 /// @param name The name of the collection where posts will go.
 /// @param symbol The symbol of the collection where posts will go.
 /// @param salt A salt to use for the deterministic deployment.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct CTProjectConfig {
     JBTerminalConfig[] terminalConfigurations;
     string projectUri;

package/src/structs/CTSuckerDeploymentConfig.sol

@@ -5,6 +5,7 @@ import {JBSuckerDeployerConfig} from "@bananapus/suckers-v6/src/structs/JBSucker
 
 /// @custom:member deployerConfigurations The information for how to suck tokens to other chains.
 /// @custom:member salt The salt to use for creating suckers so that they use the same address across chains.
+// forge-lint: disable-next-line(pascal-case-struct)
 struct CTSuckerDeploymentConfig {
     JBSuckerDeployerConfig[] deployerConfigurations;
     bytes32 salt;

package/test/CTPublisher.t.sol

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
+// forge-lint: disable-next-line(unaliased-plain-import)
 import "forge-std/Test.sol";
 
 import {IJBPermissions} from "@bananapus/core-v6/src/interfaces/IJBPermissions.sol";

package/test/CroptopAttacks.t.sol

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
+// forge-lint: disable-next-line(unaliased-plain-import)
 import "forge-std/Test.sol";
 
 import {IJBPermissions} from "@bananapus/core-v6/src/interfaces/IJBPermissions.sol";

package/test/Fork.t.sol

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.17;
 
+// forge-lint: disable-next-line(unaliased-plain-import)
 import "forge-std/Test.sol";
 
 // JB core — deploy fresh within fork.
@@ -33,7 +34,10 @@ import {JBSuckerDeployerConfig} from "@bananapus/suckers-v6/src/structs/JBSucker
 import {JBTokenMapping} from "@bananapus/suckers-v6/src/structs/JBTokenMapping.sol";
 import {IJBSuckerDeployer} from "@bananapus/suckers-v6/src/interfaces/IJBSuckerDeployer.sol";
 
+import {JBTerminalConfig} from "@bananapus/core-v6/src/structs/JBTerminalConfig.sol";
+
 // Croptop — wildcard import pulls in all structs (CTProjectConfig, CTDeployerAllowedPost, etc.).
+// forge-lint: disable-next-line(unaliased-plain-import)
 import "./../src/CTDeployer.sol";
 import {CTPublisher} from "./../src/CTPublisher.sol";
 
@@ -158,6 +162,7 @@ contract ForkTest is Test {
     // ───────────────────────── Internal deployment helpers
     // ────────────────
 
+    // forge-lint: disable-next-line(mixed-case-function)
     function _deployJBCore() internal {
         jbPermissions = new JBPermissions(trustedForwarder);
         jbProjects = new JBProjects(multisig, address(0), trustedForwarder);
@@ -191,7 +196,7 @@ contract ForkTest is Test {
         JBAddressRegistry addressRegistry = new JBAddressRegistry();
 
         JB721TiersHook hookImpl =
-            new JB721TiersHook(jbDirectory, jbPermissions, jbRulesets, store, jbSplits, trustedForwarder);
+            new JB721TiersHook(jbDirectory, jbPermissions, jbPrices, jbRulesets, store, jbSplits, trustedForwarder);
 
         hookDeployer = new JB721TiersHookDeployer(hookImpl, store, addressRegistry, trustedForwarder);
     }

package/test/Test_MetadataGeneration.t.sol

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.17;
 
+// forge-lint: disable-next-line(unaliased-plain-import)
 import "forge-std/Test.sol";
 import {JBMetadataResolver} from "@bananapus/core-v6/src/libraries/JBMetadataResolver.sol";
 
@@ -22,15 +23,22 @@ contract Test_MetadataGeneration_Unit is Test {
         bytes[] memory _datas = new bytes[](10);
 
         for (uint256 _i; _i < _ids.length; _i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             _ids[_i] = bytes4(uint32(_i + 1 * 1000));
             _datas[_i] = abi.encode(
-                bytes1(uint8(_i + 1)), uint32(69), bytes2(uint16(_i + 69)), bytes32(uint256(type(uint256).max))
+                // forge-lint: disable-next-line(unsafe-typecast)
+                bytes1(uint8(_i + 1)),
+                uint32(69),
+                // forge-lint: disable-next-line(unsafe-typecast)
+                bytes2(uint16(_i + 69)),
+                bytes32(uint256(type(uint256).max))
             );
         }
 
         bytes memory _additionalPayMetadata = _resolverHelper.createMetadata(_ids, _datas);
 
         // The referal to include in the first 32 bytes of the metadata
+        // forge-lint: disable-next-line(mixed-case-variable)
         uint256 FEE_PROJECT_ID = 420;
 
         // The additional metadata to include
@@ -65,6 +73,7 @@ contract Test_MetadataGeneration_Unit is Test {
         assertTrue(found, "datahook metadata not found");
         assertEq(targetData, abi.encode(true, tierIdsToMint), "datahook not equal");
 
+        // forge-lint: disable-next-line(unsafe-typecast)
         assertEq(uint256(bytes32(mintMetadata)), FEE_PROJECT_ID, "referal id not equal");
     }
 }

package/test/regression/DuplicateUriFeeEvasion.t.sol

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
+// forge-lint: disable-next-line(unaliased-plain-import)
 import "forge-std/Test.sol";
 
 import {IJBPermissions} from "@bananapus/core-v6/src/interfaces/IJBPermissions.sol";
@@ -258,7 +259,9 @@ contract M6_DuplicateUriFeeEvasion is Test {
     /// @notice Fuzz test: when two URIs are equal the call must revert with
     ///         CTPublisher_DuplicatePost; when they differ it must not.
     function testFuzz_duplicateDetection(bytes32 uri1, bytes32 uri2) public {
+        // forge-lint: disable-next-line(unsafe-typecast)
         vm.assume(uri1 != bytes32(""));
+        // forge-lint: disable-next-line(unsafe-typecast)
         vm.assume(uri2 != bytes32(""));
 
         _configureCategory();

package/test/regression/FeeEvasion.t.sol

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
+// forge-lint: disable-next-line(unaliased-plain-import)
 import "forge-std/Test.sol";
 
 import {IJBPermissions} from "@bananapus/core-v6/src/interfaces/IJBPermissions.sol";

package/test/regression/StaleTierIdMapping.t.sol

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
+// forge-lint: disable-next-line(unaliased-plain-import)
 import "forge-std/Test.sol";
 
 import {IJBPermissions} from "@bananapus/core-v6/src/interfaces/IJBPermissions.sol";