@croct/eslint-plugin 0.4.0 → 0.5.0

package/configs/index.d.ts

@@ -75,12 +75,6 @@ export declare const configs: {
                 };
             })[];
         };
-        overrides: {
-            files: string[];
-            rules: {
-                'sort-keys-fix/sort-keys-fix': string;
-            };
-        }[];
     };
     typescript: {
         extends: string[];
@@ -151,9 +145,6 @@ export declare const configs: {
                 })[];
                 'no-undef': string;
                 '@typescript-eslint/no-namespace': string;
-                '@typescript-eslint/no-redeclare': (string | {
-                    ignoreDeclarationMerge: boolean;
-                })[];
                 'no-new-object'?: undefined;
             };
             plugins?: undefined;
@@ -192,7 +183,6 @@ export declare const configs: {
                 '@typescript-eslint/member-delimiter-style'?: undefined;
                 'no-undef'?: undefined;
                 '@typescript-eslint/no-namespace'?: undefined;
-                '@typescript-eslint/no-redeclare'?: undefined;
             };
             env: {
                 jest: boolean;

package/configs/react.d.ts

@@ -61,10 +61,4 @@ export declare const react: {
             };
         })[];
     };
-    overrides: {
-        files: string[];
-        rules: {
-            'sort-keys-fix/sort-keys-fix': string;
-        };
-    }[];
 };

package/configs/react.js

@@ -17,7 +17,6 @@ exports.react = {
         'testing-library',
         'jest-dom',
         '@croct',
-        'sort-keys-fix',
     ],
     rules: {
         '@croct/jsx-attribute-spacing': 'error',
@@ -125,12 +124,4 @@ exports.react = {
             },
         ],
     },
-    overrides: [
-        {
-            files: ['**/styles.ts'],
-            rules: {
-                'sort-keys-fix/sort-keys-fix': 'error',
-            },
-        },
-    ],
 };

package/configs/typescript.d.ts

@@ -67,9 +67,6 @@ export declare const typescript: {
             })[];
             'no-undef': string;
             '@typescript-eslint/no-namespace': string;
-            '@typescript-eslint/no-redeclare': (string | {
-                ignoreDeclarationMerge: boolean;
-            })[];
             'no-new-object'?: undefined;
         };
         plugins?: undefined;
@@ -108,7 +105,6 @@ export declare const typescript: {
             '@typescript-eslint/member-delimiter-style'?: undefined;
             'no-undef'?: undefined;
             '@typescript-eslint/no-namespace'?: undefined;
-            '@typescript-eslint/no-redeclare'?: undefined;
         };
         env: {
             jest: boolean;

package/configs/typescript.js

@@ -79,9 +79,6 @@ exports.typescript = {
                     }],
                 'no-undef': 'off',
                 '@typescript-eslint/no-namespace': 'off',
-                '@typescript-eslint/no-redeclare': ['error', {
-                        ignoreDeclarationMerge: true,
-                    }],
             },
         },
         {

package/index.d.ts

@@ -104,12 +104,6 @@ declare const configuration: {
                     };
                 })[];
             };
-            overrides: {
-                files: string[];
-                rules: {
-                    'sort-keys-fix/sort-keys-fix': string;
-                };
-            }[];
         };
         typescript: {
             extends: string[];
@@ -180,9 +174,6 @@ declare const configuration: {
                     })[];
                     'no-undef': string;
                     '@typescript-eslint/no-namespace': string;
-                    '@typescript-eslint/no-redeclare': (string | {
-                        ignoreDeclarationMerge: boolean;
-                    })[];
                     'no-new-object'?: undefined;
                 };
                 plugins?: undefined;
@@ -221,7 +212,6 @@ declare const configuration: {
                     '@typescript-eslint/member-delimiter-style'?: undefined;
                     'no-undef'?: undefined;
                     '@typescript-eslint/no-namespace'?: undefined;
-                    '@typescript-eslint/no-redeclare'?: undefined;
                 };
                 env: {
                     jest: boolean;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@croct/eslint-plugin",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "description": "ESLint rules and presets applied to all Croct JavaScript projects.",
   "license": "MIT",
   "author": {
@@ -63,7 +63,6 @@
     "eslint": "^8.8",
     "eslint-plugin-eslint-plugin": "^4.1.0",
     "eslint-plugin-self": "^1.2.1",
-    "eslint-plugin-sort-keys-fix": "^1.1.2",
     "jest": "^27.5",
     "ts-jest": "^27.1",
     "typescript": "^4.5"

package/rules/min-chained-call-depth/index.js

@@ -1,6 +1,12 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.minChainedCallDepth = void 0;
+/*
+    eslint-disable @typescript-eslint/no-non-null-assertion
+    --
+    Disable the rule to reduce the number of branches
+*/
+const experimental_utils_1 = require("@typescript-eslint/experimental-utils");
 const ast_utils_1 = require("@typescript-eslint/utils/dist/ast-utils");
 const createRule_1 = require("../createRule");
 exports.minChainedCallDepth = (0, createRule_1.createRule)({
@@ -39,13 +45,13 @@ exports.minChainedCallDepth = (0, createRule_1.createRule)({
         function getDepth(node) {
             let depth = 0;
             let currentNode = node;
-            while (currentNode.type === 'CallExpression'
-                || currentNode.type === 'MemberExpression') {
-                if (currentNode.type === 'MemberExpression') {
+            while (currentNode.type === experimental_utils_1.AST_NODE_TYPES.CallExpression
+                || currentNode.type === experimental_utils_1.AST_NODE_TYPES.MemberExpression) {
+                if (currentNode.type === experimental_utils_1.AST_NODE_TYPES.MemberExpression) {
                     currentNode = currentNode.object;
                     depth += 1;
                 }
-                else if (currentNode.type === 'CallExpression') {
+                else if (currentNode.type === experimental_utils_1.AST_NODE_TYPES.CallExpression) {
                     currentNode = currentNode.callee;
                 }
             }
@@ -53,8 +59,8 @@ exports.minChainedCallDepth = (0, createRule_1.createRule)({
         }
         function check(node) {
             var _a, _b;
-            // If the node is a member expression inside a call expression skip, this is to ensure
-            // that we consider the correct line length of the result.
+            // If the node is a member expression inside a call/new expression skip,
+            // this is to ensure that we consider the correct line length of the result.
             //
             // Example:
             //     ```ts
@@ -63,20 +69,28 @@ exports.minChainedCallDepth = (0, createRule_1.createRule)({
             //     ```
             //     The replacement of this input should be `foo.bar();`, which has 10 character.
             //     Without this check it would consider the length up to `r`, which is 7.
-            if (node.type === 'MemberExpression' && ((_a = node.parent) === null || _a === void 0 ? void 0 : _a.type) === 'CallExpression') {
+            if (node.type === experimental_utils_1.AST_NODE_TYPES.MemberExpression
+                && ((_a = node.parent) === null || _a === void 0 ? void 0 : _a.type) === experimental_utils_1.AST_NODE_TYPES.CallExpression) {
                 return;
             }
-            // If the node is a call expression we need to validate it's callee as a member
+            // If the node is a call/new expression we need to validate it's callee as a member
             // expression.
             // If the node itself is already a member expression, like the
             // `property` in `this.property.function()`, we validate the node directly.
-            const callee = node.type === 'CallExpression' ? node.callee : node;
+            const callee = node.type === experimental_utils_1.AST_NODE_TYPES.CallExpression
+                ? node.callee
+                : node;
             if (
             // If the callee is not a member expression, we can skip.
             // For example, root level calls like `foo();`.
-            callee.type !== 'MemberExpression'
+            callee.type !== experimental_utils_1.AST_NODE_TYPES.MemberExpression
                 // If the callee is a computed member expression, like `foo[bar]()`, we can skip.
                 || callee.computed
+                /* eslint-disable-next-line @typescript-eslint/ban-ts-comment --
+                * NewExpression is a possible callee object type
+                */
+                // @ts-ignore
+                || callee.object.type === experimental_utils_1.AST_NODE_TYPES.NewExpression
                 // If the callee is already in the same line as it's object, we can skip.
                 || callee.object.loc.end.line === callee.property.loc.start.line) {
                 return;
@@ -93,7 +107,7 @@ exports.minChainedCallDepth = (0, createRule_1.createRule)({
             });
             const semicolon = sourceCode.getLastToken(node.parent, {
                 filter: token => (token.loc.start.line === property.loc.start.line
-                    && token.type === 'Punctuator'
+                    && token.type === experimental_utils_1.AST_TOKEN_TYPES.Punctuator
                     && token.value === ';'),
             });
             const lineLength = callee.object.loc.end.column