@critiq/rules 0.0.2 → 0.2.0

package/rules/typescript/ts.testing.no-skipped-test-without-ticket.rule.yaml

@@ -0,0 +1,34 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.testing.no-skipped-test-without-ticket
+  title: Skipped tests should cite a ticket or timed suppression
+  summary: Skipped or disabled tests should reference a tracked issue, expiry, or accepted suppression comment.
+  rationale: Silent skips decay into permanent holes in coverage unless they carry reviewable intent.
+  tags:
+    - testing
+    - quality
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: testing.skipped-without-ticket-reference
+    bind: issue
+emit:
+  finding:
+    category: quality.testing
+    severity: medium
+    confidence: 0.72
+    tags:
+      - testing
+      - coverage
+  message:
+    title: Add a ticket or suppression note for `${captures.issue.text}`
+    summary: "`${captures.issue.text}` skips a test without an adjacent issue key, GitHub issue URL, or TODO(expires) style note."
+  remediation:
+    summary: Link the skip to a tracker id, add a short expiry note, or replace the skip with a focused assertion.

package/rules/typescript/ts.testing.no-snapshot-without-intent.rule.yaml

@@ -0,0 +1,34 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.testing.no-snapshot-without-intent
+  title: Snapshot assertions should name intent
+  summary: Snapshot matchers without a snapshot name or preceding intent comment are hard to review in diffs.
+  rationale: Anonymous snapshots churn without communicating what behavior reviewers should protect.
+  tags:
+    - testing
+    - quality
+    - rules-catalog
+  stability: experimental
+  appliesTo: block
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  fact:
+    kind: testing.snapshot-without-review-intent
+    bind: issue
+emit:
+  finding:
+    category: quality.testing
+    severity: low
+    confidence: 0.65
+    tags:
+      - testing
+      - snapshots
+  message:
+    title: Clarify snapshot intent for `${captures.issue.text}`
+    summary: "`${captures.issue.text}` uses a snapshot matcher without a string name and without a `// snapshot:` review comment on the previous line."
+  remediation:
+    summary: Add a named snapshot, or place `// snapshot:` on the preceding line describing what the snapshot protects.

package/rules/typescript/ts.testing.no-test-only-code-in-production.rule.yaml

@@ -0,0 +1,38 @@
+apiVersion: critiq.dev/v1alpha1
+kind: Rule
+metadata:
+  id: ts.testing.no-test-only-code-in-production
+  title: Keep test-only modules and guards out of production paths
+  summary: Production modules should not import test doubles or gate behavior on test-only environment flags.
+  rationale: Test-only imports and NODE_ENV test branches can ship dead paths or accidental coupling to test harnesses.
+  tags:
+    - testing
+    - quality
+    - rules-catalog
+  stability: experimental
+  appliesTo: project
+scope:
+  languages:
+    - typescript
+    - javascript
+match:
+  any:
+    - fact:
+        kind: testing.production-imports-test-code
+        bind: issue
+    - fact:
+        kind: testing.test-only-env-branch-in-production
+        bind: issue
+emit:
+  finding:
+    category: quality.testing
+    severity: high
+    confidence: 0.8
+    tags:
+      - testing
+      - boundaries
+  message:
+    title: Remove test-only coupling in `${captures.issue.text}`
+    summary: "`${captures.issue.text}` imports a test-only module or compares runtime mode against `test` outside test paths."
+  remediation:
+    summary: Move helpers into shared neutral modules, guard test utilities behind dev-only entrypoints, and keep production code free of `NODE_ENV === 'test'` branches.