@critical-path/core 0.9.0 → 0.11.0

package/src/store/index.ts

@@ -71,6 +71,8 @@ export interface CommentRepository {
   addComment(comment: Omit<Comment, 'id' | 'createdAt' | 'updatedAt'>): Promise<Comment>;
   updateComment(id: string, updates: Partial<Comment>): Promise<Comment | null>;
   deleteComment(id: string): Promise<boolean>;
+  addReaction?(commentId: string, reaction: { emoji: string; userId: string }): Promise<Comment | null>;
+  removeReaction?(commentId: string, reaction: { emoji: string; userId: string }): Promise<Comment | null>;
 }
 
 export interface AttachmentRepository {
@@ -369,6 +371,42 @@ export class InMemoryStore implements StorageAdapter {
     return this.comments.delete(id);
   }
 
+  async addReaction(commentId: string, reaction: { emoji: string; userId: string }): Promise<Comment | null> {
+    const existing = this.comments.get(commentId);
+    if (!existing) return null;
+    const reactions = existing.reactions ? [...existing.reactions] : [];
+    const alreadyExists = reactions.some((r) => r.emoji === reaction.emoji && r.userId === reaction.userId);
+    if (!alreadyExists) {
+      reactions.push({
+        emoji: reaction.emoji,
+        userId: reaction.userId,
+        createdAt: new Date().toISOString()
+      });
+    }
+    const updated: Comment = {
+      ...existing,
+      reactions,
+      updatedAt: new Date().toISOString()
+    };
+    this.comments.set(commentId, updated);
+    return updated;
+  }
+
+  async removeReaction(commentId: string, reaction: { emoji: string; userId: string }): Promise<Comment | null> {
+    const existing = this.comments.get(commentId);
+    if (!existing) return null;
+    const reactions = (existing.reactions || []).filter(
+      (r) => !(r.emoji === reaction.emoji && r.userId === reaction.userId)
+    );
+    const updated: Comment = {
+      ...existing,
+      reactions,
+      updatedAt: new Date().toISOString()
+    };
+    this.comments.set(commentId, updated);
+    return updated;
+  }
+
   // Attachments
   async getAttachments(filter?: { taskId?: string; projectId?: string; commentId?: string }): Promise<Attachment[]> {
     return Array.from(this.attachments.values()).filter((a) => {

package/src/store/sqlite.test.ts

@@ -77,11 +77,16 @@ describe('SQLiteStore', () => {
     const comments = await store.getComments('task_1');
     expect(comments).toHaveLength(2);
 
-    const updatedComment = await store.updateComment(comment.id, { content: 'Updated content' });
+    const updatedComment = await store.updateComment(comment.id, {
+      content: 'Updated content',
+      mentions: ['planner', 'coordinator']
+    });
     expect(updatedComment?.content).toBe('Updated content');
+    expect(updatedComment?.mentions).toEqual(['planner', 'coordinator']);
 
     const fetchedComment = await store.getComment(comment.id);
     expect(fetchedComment?.content).toBe('Updated content');
+    expect(fetchedComment?.mentions).toEqual(['planner', 'coordinator']);
 
     const timeEntry = await store.logTime({
       taskId: 'task_1',
@@ -94,6 +99,17 @@ describe('SQLiteStore', () => {
     const entries = await store.getTimeEntries('task_1');
     expect(entries).toHaveLength(1);
 
+    // Emoji reactions
+    const reactComment = await store.addReaction(comment.id, { emoji: '🔥', userId: 'user_2' });
+    expect(reactComment?.reactions).toHaveLength(1);
+    expect(reactComment?.reactions?.[0].emoji).toBe('🔥');
+
+    const fetchedWithReactions = await store.getComment(comment.id);
+    expect(fetchedWithReactions?.reactions).toHaveLength(1);
+
+    const unreactComment = await store.removeReaction(comment.id, { emoji: '🔥', userId: 'user_2' });
+    expect(unreactComment?.reactions).toHaveLength(0);
+
     const deletedComment = await store.deleteComment(reply.id);
     expect(deletedComment).toBe(true);
     expect(await store.getComments('task_1')).toHaveLength(1);

package/src/store/sqlite.ts

@@ -154,6 +154,8 @@ export class SQLiteStore implements StorageAdapter {
         authorType TEXT,
         parentId TEXT,
         content TEXT NOT NULL,
+        mentions TEXT,
+        reactions TEXT,
         metadata TEXT,
         createdAt TEXT NOT NULL,
         updatedAt TEXT NOT NULL
@@ -212,6 +214,18 @@ export class SQLiteStore implements StorageAdapter {
         createdAt TEXT NOT NULL
       );
     `);
+
+    try {
+      this.db.exec('ALTER TABLE comments ADD COLUMN reactions TEXT');
+    } catch {
+      // Column may already exist
+    }
+
+    try {
+      this.db.exec('ALTER TABLE comments ADD COLUMN mentions TEXT');
+    } catch {
+      // Column may already exist
+    }
   }
 
   // --- Projects ---
@@ -682,23 +696,33 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   // --- Comments ---
+  private mapComment(row: any): Comment {
+    return {
+      id: row.id,
+      taskId: row.taskId,
+      authorId: row.authorId,
+      authorType: row.authorType,
+      parentId: row.parentId || undefined,
+      content: row.content,
+      mentions: row.mentions ? JSON.parse(row.mentions) : undefined,
+      reactions: row.reactions ? JSON.parse(row.reactions) : undefined,
+      metadata: row.metadata ? JSON.parse(row.metadata) : undefined,
+      createdAt: row.createdAt,
+      updatedAt: row.updatedAt
+    };
+  }
+
   async getComments(taskId: string): Promise<Comment[]> {
     const stmt = this.db.prepare('SELECT * FROM comments WHERE taskId = ? ORDER BY createdAt ASC');
     const rows = stmt.all(taskId) as any[];
-    return rows.map((r) => ({
-      ...r,
-      metadata: r.metadata ? JSON.parse(r.metadata) : undefined
-    }));
+    return rows.map((r) => this.mapComment(r));
   }
 
   async getComment(id: string): Promise<Comment | null> {
     const stmt = this.db.prepare('SELECT * FROM comments WHERE id = ?');
     const row = stmt.get(id) as any;
     if (!row) return null;
-    return {
-      ...row,
-      metadata: row.metadata ? JSON.parse(row.metadata) : undefined
-    };
+    return this.mapComment(row);
   }
 
   async addComment(comment: Omit<Comment, 'id' | 'createdAt' | 'updatedAt'>): Promise<Comment> {
@@ -707,8 +731,8 @@ export class SQLiteStore implements StorageAdapter {
     const newComment: Comment = { ...comment, id, createdAt: now, updatedAt: now };
 
     const stmt = this.db.prepare(`
-      INSERT INTO comments (id, taskId, authorId, authorType, parentId, content, metadata, createdAt, updatedAt)
-      VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)
+      INSERT INTO comments (id, taskId, authorId, authorType, parentId, content, mentions, reactions, metadata, createdAt, updatedAt)
+      VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
     `);
     stmt.run(
       newComment.id,
@@ -717,6 +741,8 @@ export class SQLiteStore implements StorageAdapter {
       newComment.authorType || 'user',
       newComment.parentId || null,
       newComment.content,
+      newComment.mentions ? JSON.stringify(newComment.mentions) : null,
+      newComment.reactions ? JSON.stringify(newComment.reactions) : null,
       newComment.metadata ? JSON.stringify(newComment.metadata) : null,
       newComment.createdAt,
       newComment.updatedAt
@@ -740,6 +766,8 @@ export class SQLiteStore implements StorageAdapter {
         authorType = ?,
         parentId = ?,
         content = ?,
+        mentions = ?,
+        reactions = ?,
         metadata = ?,
         updatedAt = ?
       WHERE id = ?
@@ -749,6 +777,8 @@ export class SQLiteStore implements StorageAdapter {
       updated.authorType || 'user',
       updated.parentId || null,
       updated.content,
+      updated.mentions ? JSON.stringify(updated.mentions) : null,
+      updated.reactions ? JSON.stringify(updated.reactions) : null,
       updated.metadata ? JSON.stringify(updated.metadata) : null,
       updated.updatedAt,
       id
@@ -762,6 +792,30 @@ export class SQLiteStore implements StorageAdapter {
     return (result.changes ?? 0) > 0;
   }
 
+  async addReaction(commentId: string, reaction: { emoji: string; userId: string }): Promise<Comment | null> {
+    const existing = await this.getComment(commentId);
+    if (!existing) return null;
+    const reactions = existing.reactions ? [...existing.reactions] : [];
+    const alreadyExists = reactions.some((r) => r.emoji === reaction.emoji && r.userId === reaction.userId);
+    if (!alreadyExists) {
+      reactions.push({
+        emoji: reaction.emoji,
+        userId: reaction.userId,
+        createdAt: new Date().toISOString()
+      });
+    }
+    return this.updateComment(commentId, { reactions });
+  }
+
+  async removeReaction(commentId: string, reaction: { emoji: string; userId: string }): Promise<Comment | null> {
+    const existing = await this.getComment(commentId);
+    if (!existing) return null;
+    const reactions = (existing.reactions || []).filter(
+      (r) => !(r.emoji === reaction.emoji && r.userId === reaction.userId)
+    );
+    return this.updateComment(commentId, { reactions });
+  }
+
   // --- Attachments ---
   async getAttachments(filter?: { taskId?: string; projectId?: string; commentId?: string }): Promise<Attachment[]> {
     let sql = 'SELECT * FROM attachments';

package/src/types/index.ts

@@ -185,6 +185,12 @@ export interface Iteration {
 
 export type AuthorType = 'user' | 'agent' | 'system';
 
+export interface CommentReaction {
+  emoji: string;
+  userId: string;
+  createdAt?: string;
+}
+
 export interface Comment {
   id: string;
   taskId: string;
@@ -192,6 +198,8 @@ export interface Comment {
   authorType?: AuthorType;
   parentId?: string; // Threaded reply support
   content: string;
+  mentions?: string[];
+  reactions?: CommentReaction[];
   metadata?: Record<string, unknown>;
   createdAt: string;
   updatedAt: string;
@@ -291,6 +299,8 @@ export type WebhookEvent =
   | 'comment.created'
   | 'comment.updated'
   | 'comment.deleted'
+  | 'comment.reaction.added'
+  | 'comment.reaction.removed'
   | 'attachment.created'
   | 'attachment.deleted'
   | 'iteration.started'

package/src/utils/index.ts

@@ -1,4 +1,5 @@
 export * from './status.js';
 export * from './key.js';
 export * from './workflow.js';
+export * from './mentions.js';
 

package/src/utils/mentions.test.ts

@@ -0,0 +1,82 @@
+import { describe, it, expect } from 'vitest';
+import { extractMentions, parseMentionSegments } from './mentions.js';
+
+describe('mentions utility', () => {
+  describe('extractMentions', () => {
+    it('returns empty array for empty or non-string input', () => {
+      expect(extractMentions('')).toEqual([]);
+      expect(extractMentions(null as any)).toEqual([]);
+      expect(extractMentions(undefined as any)).toEqual([]);
+    });
+
+    it('extracts single mention', () => {
+      expect(extractMentions('Hello @planner, please review.')).toEqual(['planner']);
+    });
+
+    it('extracts multiple mentions and deduplicates them', () => {
+      const text = 'Hey @jane and @planner, can @jane check with @coordinator?';
+      expect(extractMentions(text)).toEqual(['jane', 'planner', 'coordinator']);
+    });
+
+    it('supports quoted handles with spaces', () => {
+      const text = 'Assigning to @"Agent Planner" and @"Jane Doe"';
+      expect(extractMentions(text)).toEqual(['Agent Planner', 'Jane Doe']);
+    });
+
+    it('ignores email addresses without leading space or boundary', () => {
+      const text = 'Send mail to user@example.com or ping @alex';
+      expect(extractMentions(text)).toEqual(['alex']);
+    });
+
+    it('handles mentions with dashes, underscores, and periods', () => {
+      const text = 'Call @agent-1, @super_user, and @john.doe';
+      expect(extractMentions(text)).toEqual(['agent-1', 'super_user', 'john.doe']);
+    });
+  });
+
+  describe('parseMentionSegments', () => {
+    it('returns empty array for empty string', () => {
+      expect(parseMentionSegments('')).toEqual([]);
+    });
+
+    it('returns single text segment if no mentions', () => {
+      expect(parseMentionSegments('Just a normal comment without tags.')).toEqual([
+        { type: 'text', value: 'Just a normal comment without tags.' }
+      ]);
+    });
+
+    it('correctly segments text with single mention in the middle', () => {
+      const result = parseMentionSegments('Hello @planner, please check.');
+      expect(result).toEqual([
+        { type: 'text', value: 'Hello ' },
+        { type: 'mention', value: '@planner', handle: 'planner' },
+        { type: 'text', value: ', please check.' }
+      ]);
+    });
+
+    it('correctly segments text starting with a mention', () => {
+      const result = parseMentionSegments('@planner can you take a look?');
+      expect(result).toEqual([
+        { type: 'mention', value: '@planner', handle: 'planner' },
+        { type: 'text', value: ' can you take a look?' }
+      ]);
+    });
+
+    it('correctly segments text ending with a mention', () => {
+      const result = parseMentionSegments('Assigned to @coordinator');
+      expect(result).toEqual([
+        { type: 'text', value: 'Assigned to ' },
+        { type: 'mention', value: '@coordinator', handle: 'coordinator' }
+      ]);
+    });
+
+    it('correctly segments quoted mentions', () => {
+      const result = parseMentionSegments('Ping @"Agent Supervisor" ASAP');
+      expect(result).toEqual([
+        { type: 'text', value: 'Ping ' },
+        { type: 'mention', value: '@"Agent Supervisor"', handle: 'Agent Supervisor' },
+        { type: 'text', value: ' ASAP' }
+      ]);
+    });
+  });
+});

package/src/utils/mentions.ts

@@ -0,0 +1,89 @@
+export interface MentionSegment {
+  type: 'text' | 'mention';
+  value: string;
+  handle?: string;
+}
+
+/**
+ * Regex matching mentions:
+ * - Quoted mentions: @"Jane Doe"
+ * - Standard mentions: @jane_doe, @planner, @user-1, @john.smith
+ * Note: Does not match emails like foo@bar.com (requires word boundary or start of string before @).
+ */
+export const MENTION_REGEX = /(?:^|\s)@(?:"([^"]+)"|([a-zA-Z0-9_.-]+))/g;
+
+/**
+ * Extracts unique mention handles from a text string.
+ * Strips quotes and the leading '@' symbol.
+ * Preserves the order of their first appearance.
+ */
+export function extractMentions(content: string): string[] {
+  if (!content || typeof content !== 'string') return [];
+
+  const mentions: string[] = [];
+  const seen = new Set<string>();
+
+  // Reset regex lastIndex
+  const regex = new RegExp(MENTION_REGEX.source, 'g');
+  let match: RegExpExecArray | null;
+
+  while ((match = regex.exec(content)) !== null) {
+    const handle = match[1] ?? match[2];
+    if (handle && !seen.has(handle)) {
+      seen.add(handle);
+      mentions.push(handle);
+    }
+  }
+
+  return mentions;
+}
+
+/**
+ * Segments a text string into plain text parts and mention tokens.
+ * Useful for rendering highlighted mention badges or links in UI components.
+ */
+export function parseMentionSegments(content: string): MentionSegment[] {
+  if (!content) return [];
+
+  const segments: MentionSegment[] = [];
+  const regex = new RegExp(MENTION_REGEX.source, 'g');
+  let lastIndex = 0;
+  let match: RegExpExecArray | null;
+
+  while ((match = regex.exec(content)) !== null) {
+    const fullMatch = match[0];
+    const leadingWhitespace = fullMatch.startsWith(' ') || fullMatch.startsWith('\t') || fullMatch.startsWith('\n')
+      ? fullMatch[0]
+      : '';
+    const mentionToken = fullMatch.slice(leadingWhitespace.length);
+    const handle = match[1] ?? match[2];
+    const matchStart = match.index + leadingWhitespace.length;
+
+    // Push text before this mention if any
+    if (matchStart > lastIndex) {
+      segments.push({
+        type: 'text',
+        value: content.slice(lastIndex, matchStart)
+      });
+    }
+
+    // Push the mention token
+    segments.push({
+      type: 'mention',
+      value: mentionToken,
+      handle
+    });
+
+    lastIndex = match.index + fullMatch.length;
+  }
+
+  // Push any remaining text after the last match
+  if (lastIndex < content.length) {
+    segments.push({
+      type: 'text',
+      value: content.slice(lastIndex)
+    });
+  }
+
+  return segments;
+}

package/tsconfig.tsbuildinfo

@@ -1 +1 @@
-{"root":["./src/index.test.ts","./src/index.ts","./src/use-case-validation.test.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/types/index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/status.ts","./src/utils/workflow.ts"],"version":"5.9.3"}
+{"root":["./src/index.test.ts","./src/index.ts","./src/use-case-validation.test.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/types/index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/mentions.test.ts","./src/utils/mentions.ts","./src/utils/status.ts","./src/utils/workflow.ts"],"version":"5.9.3"}