@critical-path/core 0.33.0 → 0.35.0

package/src/store/sqlite.ts

@@ -373,7 +373,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async createProject(project: Omit<Project, 'id' | 'createdAt' | 'updatedAt'>): Promise<Project> {
-    const id = `proj_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `proj_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const key = project.key || generateProjectKey(project.name);
     const newProj: Project = { ...project, key, id, createdAt: now, updatedAt: now };
@@ -451,7 +451,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async createWorkflow(workflow: Omit<Workflow, 'id' | 'createdAt' | 'updatedAt'>): Promise<Workflow> {
-    const id = `wf_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `wf_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const newWf: Workflow = { ...workflow, id, createdAt: now, updatedAt: now };
 
@@ -529,7 +529,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async createTeam(team: Omit<Team, 'id' | 'createdAt' | 'updatedAt'>): Promise<Team> {
-    const id = `team_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `team_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const newTeam: Team = { ...team, id, createdAt: now, updatedAt: now };
 
@@ -592,7 +592,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async createContainer(container: Omit<TaskContainer, 'id' | 'createdAt' | 'updatedAt'>): Promise<TaskContainer> {
-    const id = `cnt_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `cnt_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const newContainer: TaskContainer = { ...container, id, createdAt: now, updatedAt: now };
 
@@ -655,7 +655,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async createDeliverable(deliverable: CreateDeliverableInput): Promise<Deliverable> {
-    const id = `deliv_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `deliv_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const newDeliverable: Deliverable = {
       ...deliverable,
@@ -802,7 +802,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async createTask(task: Omit<Task, 'id' | 'createdAt' | 'updatedAt'>): Promise<Task> {
-    const id = `task_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `task_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const newTask: Task = { ...task, id, createdAt: now, updatedAt: now };
 
@@ -948,7 +948,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async createIteration(iteration: Omit<Iteration, 'id' | 'createdAt'>): Promise<Iteration> {
-    const id = `iter_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `iter_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const newIteration: Iteration = { ...iteration, id, createdAt: now };
 
@@ -1029,7 +1029,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async addComment(comment: Omit<Comment, 'id' | 'createdAt' | 'updatedAt'>): Promise<Comment> {
-    const id = `cmt_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `cmt_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const newComment: Comment = { ...comment, id, createdAt: now, updatedAt: now };
 
@@ -1166,7 +1166,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async createAttachment(attachment: Omit<Attachment, 'id' | 'createdAt' | 'updatedAt'>): Promise<Attachment> {
-    const id = `att_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `att_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const newAtt: Attachment = {
       ...attachment,
@@ -1267,7 +1267,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async logActivity(activity: Omit<Activity, 'id' | 'createdAt'>): Promise<Activity> {
-    const id = `act_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `act_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const newAct: Activity = { ...activity, id, createdAt: now };
 
@@ -1295,7 +1295,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async logTime(entry: Omit<TimeEntry, 'id' | 'loggedAt'> & { loggedAt?: string }): Promise<TimeEntry> {
-    const id = `time_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `time_${crypto.randomUUID()}`;
     const now = entry.loggedAt || new Date().toISOString();
     const newEntry: TimeEntry = { ...entry, id, loggedAt: now };
 
@@ -1322,7 +1322,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async addDependency(dep: Omit<TaskDependency, 'id'>): Promise<TaskDependency> {
-    const id = `dep_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `dep_${crypto.randomUUID()}`;
     const newDep: TaskDependency = { ...dep, id };
 
     const stmt = this.db.prepare(`
@@ -1395,7 +1395,7 @@ export class SQLiteStore implements StorageAdapter {
   }
 
   async addWebhook(webhook: Omit<Webhook, 'id' | 'createdAt'>): Promise<Webhook> {
-    const id = `wh_${Math.random().toString(36).substring(2, 9)}`;
+    const id = `wh_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const newWh: Webhook = { ...webhook, id, createdAt: now };
 

package/src/testing/conformance.ts

@@ -140,6 +140,24 @@ export function runStorageAdapterConformance({ name, createStore, describe, it,
       expect(updated.parentId === null).toBe(false);
     });
 
+    it('returns copies, so mutating results or reused inputs does not change stored records', async () => {
+      const store = await createStore();
+      const project = await store.createProject({ name: 'P' });
+      const input = { projectId: project.id, title: 'Original', status: 'todo', priority: 'medium', tags: ['a'] };
+      const created = await store.createTask(input);
+
+      input.tags.push('mutated-input');
+      input.title = 'Mutated input';
+      const fetched = (await store.getTask(created.id))!;
+      fetched.tags!.push('mutated-result');
+      fetched.title = 'Mutated result';
+      (await store.getTasks(project.id))[0].title = 'Mutated list';
+
+      const stored = await store.getTask(created.id);
+      expect(stored?.title).toBe('Original');
+      expect(stored?.tags).toEqual(['a']);
+    });
+
     it('follows the not-found contract', async () => {
       const store = await createStore();
       expect(await store.getProject('missing')).toBeNull();

package/tsconfig.tsbuildinfo

@@ -1 +1 @@
-{"root":["./src/deliverables.test.ts","./src/index.test.ts","./src/index.ts","./src/status.test.ts","./src/task-state.test.ts","./src/use-case-validation.test.ts","./src/domain/authorization.ts","./src/domain/calendar.test.ts","./src/domain/calendar.ts","./src/domain/cpm.test.ts","./src/domain/cpm.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/errors.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/domain/ladder.test.ts","./src/domain/ladder.ts","./src/domain/metrics.test.ts","./src/domain/metrics.ts","./src/domain/task-duration.test.ts","./src/domain/workload.test.ts","./src/domain/workload.ts","./src/engine/actor.test.ts","./src/engine/authorization.test.ts","./src/engine/cascade.test.ts","./src/engine/config.test.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/plugins/plugins.test.ts","./src/schemas/index.ts","./src/schemas/schemas.test.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/conformance.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/query.test.ts","./src/store/query.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/testing/conformance.ts","./src/testing/index.ts","./src/types/index.ts","./src/utils/fractional-index.test.ts","./src/utils/fractional-index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/mentions.test.ts","./src/utils/mentions.ts","./src/utils/status.ts","./src/utils/workflow.ts","./src/webhooks/dispatcher.ts","./src/webhooks/index.ts","./src/webhooks/signature.ts","./src/webhooks/webhooks.test.ts"],"version":"5.9.3"}
+{"root":["./src/deliverables.test.ts","./src/index.test.ts","./src/index.ts","./src/status.test.ts","./src/task-state.test.ts","./src/use-case-validation.test.ts","./src/domain/authorization.ts","./src/domain/calendar.test.ts","./src/domain/calendar.ts","./src/domain/cpm.test.ts","./src/domain/cpm.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/errors.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/domain/ladder.test.ts","./src/domain/ladder.ts","./src/domain/metrics.test.ts","./src/domain/metrics.ts","./src/domain/task-duration.test.ts","./src/domain/workload.test.ts","./src/domain/workload.ts","./src/engine/actor.test.ts","./src/engine/authorization.test.ts","./src/engine/cascade.test.ts","./src/engine/config.test.ts","./src/engine/entity-events.test.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/plugins/plugins.test.ts","./src/schemas/index.ts","./src/schemas/schemas.test.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/conformance.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/query.test.ts","./src/store/query.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/testing/conformance.ts","./src/testing/index.ts","./src/types/index.ts","./src/utils/fractional-index.test.ts","./src/utils/fractional-index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/mentions.test.ts","./src/utils/mentions.ts","./src/utils/status.ts","./src/utils/workflow.ts","./src/webhooks/dispatcher.ts","./src/webhooks/index.ts","./src/webhooks/signature.ts","./src/webhooks/webhooks.test.ts"],"version":"5.9.3"}