@critical-path/core 0.32.0 → 0.34.0

package/src/domain/entities.ts

@@ -146,7 +146,7 @@ export class TaskEntity extends BaseEntity {
     input: CreateTaskInput,
     options?: { id?: string; workflow?: Workflow; customFieldDefs?: CustomFieldDefinition[] }
   ): TaskEntity {
-    const id = options?.id || `task_${Math.random().toString(36).substring(2, 9)}`;
+    const id = options?.id || `task_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
 
     if (options?.customFieldDefs) {
@@ -186,7 +186,7 @@ export class TaskEntity extends BaseEntity {
     });
 
     const createdEvent: TaskCreatedEvent = {
-      id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+      id: `evt_${crypto.randomUUID()}`,
       name: 'task.created',
       aggregateId: task.id,
       aggregateType: 'Task',
@@ -277,7 +277,7 @@ export class TaskEntity extends BaseEntity {
     this.markUpdated();
 
     const event: TaskStatusChangedEvent = {
-      id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+      id: `evt_${crypto.randomUUID()}`,
       name: 'task.status_changed',
       aggregateId: this.id,
       aggregateType: 'Task',
@@ -310,7 +310,7 @@ export class TaskEntity extends BaseEntity {
     this.markUpdated();
 
     const timeEntry: TimeEntry = {
-      id: `time_${Math.random().toString(36).substring(2, 9)}`,
+      id: `time_${crypto.randomUUID()}`,
       taskId: this.id,
       userId: entry.userId || this.assigneeId || 'system',
       hours: entry.hours,
@@ -320,7 +320,7 @@ export class TaskEntity extends BaseEntity {
     };
 
     const event: TimeLoggedEvent = {
-      id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+      id: `evt_${crypto.randomUUID()}`,
       name: 'time.logged',
       aggregateId: this.id,
       aggregateType: 'Task',
@@ -338,7 +338,7 @@ export class TaskEntity extends BaseEntity {
   public addTodo(title: string, id?: string): TaskTodoItem {
     const previous = this.toPlain();
     const item: TaskTodoItem = {
-      id: id || `todo_${Math.random().toString(36).substring(2, 9)}`,
+      id: id || `todo_${crypto.randomUUID()}`,
       title,
       completed: false,
       createdAt: new Date().toISOString()
@@ -350,7 +350,7 @@ export class TaskEntity extends BaseEntity {
     this.markUpdated();
 
     const event: TaskUpdatedEvent = {
-      id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+      id: `evt_${crypto.randomUUID()}`,
       name: 'task.updated',
       aggregateId: this.id,
       aggregateType: 'Task',
@@ -375,7 +375,7 @@ export class TaskEntity extends BaseEntity {
       this.markUpdated();
 
       const event: TaskUpdatedEvent = {
-        id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+        id: `evt_${crypto.randomUUID()}`,
         name: 'task.updated',
         aggregateId: this.id,
         aggregateType: 'Task',
@@ -397,7 +397,7 @@ export class TaskEntity extends BaseEntity {
     this.markUpdated();
 
     const event: TaskUpdatedEvent = {
-      id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+      id: `evt_${crypto.randomUUID()}`,
       name: 'task.updated',
       aggregateId: this.id,
       aggregateType: 'Task',
@@ -459,7 +459,7 @@ export class TaskEntity extends BaseEntity {
     this.markUpdated();
 
     const event: TaskUpdatedEvent = {
-      id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+      id: `evt_${crypto.randomUUID()}`,
       name: 'task.updated',
       aggregateId: this.id,
       aggregateType: 'Task',
@@ -554,7 +554,7 @@ export class ProjectEntity extends BaseEntity {
     input: CreateProjectInput,
     options?: { id?: string }
   ): ProjectEntity {
-    const id = options?.id || `proj_${Math.random().toString(36).substring(2, 9)}`;
+    const id = options?.id || `proj_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
     const key = input.key || generateProjectKey(input.name);
 
@@ -567,7 +567,7 @@ export class ProjectEntity extends BaseEntity {
     });
 
     const event: ProjectCreatedEvent = {
-      id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+      id: `evt_${crypto.randomUUID()}`,
       name: 'project.created',
       aggregateId: project.id,
       aggregateType: 'Project',
@@ -638,7 +638,7 @@ export class DeliverableEntity extends BaseEntity {
     input: CreateDeliverableInput,
     options?: { id?: string; customFieldDefs?: CustomFieldDefinition[] }
   ): DeliverableEntity {
-    const id = options?.id || `deliv_${Math.random().toString(36).substring(2, 9)}`;
+    const id = options?.id || `deliv_${crypto.randomUUID()}`;
     const now = new Date().toISOString();
 
     if (options?.customFieldDefs) {
@@ -656,7 +656,7 @@ export class DeliverableEntity extends BaseEntity {
     });
 
     const createdEvent: DeliverableCreatedEvent = {
-      id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+      id: `evt_${crypto.randomUUID()}`,
       name: 'deliverable.created',
       aggregateId: deliverable.id,
       aggregateType: 'Deliverable',
@@ -682,7 +682,7 @@ export class DeliverableEntity extends BaseEntity {
     this.markUpdated();
 
     const event: DeliverableStatusChangedEvent = {
-      id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+      id: `evt_${crypto.randomUUID()}`,
       name: 'deliverable.status_changed',
       aggregateId: this.id,
       aggregateType: 'Deliverable',
@@ -708,7 +708,7 @@ export class DeliverableEntity extends BaseEntity {
       this.markUpdated();
 
       const event: DeliverableUpdatedEvent = {
-        id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+        id: `evt_${crypto.randomUUID()}`,
         name: 'deliverable.updated',
         aggregateId: this.id,
         aggregateType: 'Deliverable',
@@ -742,7 +742,7 @@ export class DeliverableEntity extends BaseEntity {
     this.markUpdated();
 
     const event: DeliverableUpdatedEvent = {
-      id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+      id: `evt_${crypto.randomUUID()}`,
       name: 'deliverable.updated',
       aggregateId: this.id,
       aggregateType: 'Deliverable',

package/src/domain/events.ts

@@ -174,6 +174,41 @@ export interface TeamCreatedEvent extends DomainEvent<{ team: Team }> {
   readonly aggregateType: 'Team';
 }
 
+export interface TeamUpdatedEvent extends DomainEvent<{ team: Team; previous: Team }> {
+  readonly name: 'team.updated';
+  readonly aggregateType: 'Team';
+}
+
+export interface TeamDeletedEvent extends DomainEvent<{ teamId: string; name: string; tenantId?: string }> {
+  readonly name: 'team.deleted';
+  readonly aggregateType: 'Team';
+}
+
+export interface ContainerUpdatedEvent extends DomainEvent<{ container: TaskContainer; previous: TaskContainer }> {
+  readonly name: 'container.updated';
+  readonly aggregateType: 'Container';
+}
+
+export interface ContainerDeletedEvent extends DomainEvent<{ containerId: string; projectId: string; name: string }> {
+  readonly name: 'container.deleted';
+  readonly aggregateType: 'Container';
+}
+
+export interface IterationCreatedEvent extends DomainEvent<{ iteration: Iteration }> {
+  readonly name: 'iteration.created';
+  readonly aggregateType: 'Iteration';
+}
+
+export interface IterationUpdatedEvent extends DomainEvent<{ iteration: Iteration; previous: Iteration }> {
+  readonly name: 'iteration.updated';
+  readonly aggregateType: 'Iteration';
+}
+
+export interface IterationDeletedEvent extends DomainEvent<{ iterationId: string; projectId: string; name: string }> {
+  readonly name: 'iteration.deleted';
+  readonly aggregateType: 'Iteration';
+}
+
 export interface ContainerCreatedEvent extends DomainEvent<{ container: TaskContainer }> {
   readonly name: 'container.created';
   readonly aggregateType: 'Container';
@@ -225,7 +260,14 @@ export type CriticalPathDomainEvent =
   | IterationStartedEvent
   | IterationCompletedEvent
   | TeamCreatedEvent
+  | TeamUpdatedEvent
+  | TeamDeletedEvent
   | ContainerCreatedEvent
+  | ContainerUpdatedEvent
+  | ContainerDeletedEvent
+  | IterationCreatedEvent
+  | IterationUpdatedEvent
+  | IterationDeletedEvent
   | DeliverableCreatedEvent
   | DeliverableUpdatedEvent
   | DeliverableStatusChangedEvent
@@ -289,6 +331,8 @@ export const DOMAIN_EVENT_NAMES = [
   'comment.reaction.removed',
   'comment.updated',
   'container.created',
+  'container.deleted',
+  'container.updated',
   'deliverable.created',
   'deliverable.deleted',
   'deliverable.status_changed',
@@ -296,7 +340,10 @@ export const DOMAIN_EVENT_NAMES = [
   'dependency.added',
   'dependency.removed',
   'iteration.completed',
+  'iteration.created',
+  'iteration.deleted',
   'iteration.started',
+  'iteration.updated',
   'project.created',
   'project.deleted',
   'project.updated',
@@ -307,6 +354,8 @@ export const DOMAIN_EVENT_NAMES = [
   'task.unblocked',
   'task.updated',
   'team.created',
+  'team.deleted',
+  'team.updated',
   'time.logged',
   'workflow.created',
   'workflow.deleted',

package/src/engine/entity-events.test.ts

@@ -0,0 +1,67 @@
+import { describe, it, expect } from 'vitest';
+import { CriticalPathEngine, type DomainEvent } from '../index.js';
+
+function record(engine: CriticalPathEngine) {
+  const events: DomainEvent[] = [];
+  engine.events.subscribe('*', (e) => void events.push(e));
+  return events;
+}
+
+describe('team, container and iteration events', () => {
+  it('publishes updated and deleted events with the previous state', async () => {
+    const engine = new CriticalPathEngine();
+    const project = await engine.createProject({ name: 'Events' });
+    const team = await engine.createTeam({ name: 'Core', memberIds: [] });
+    const container = await engine.createContainer({ projectId: project.id, name: 'Epic' });
+    const events = record(engine);
+    const iteration = await engine.createIteration({ projectId: project.id, name: 'S1', status: 'planning' });
+
+    await engine.updateTeam(team.id, { name: 'Platform' });
+    await engine.updateContainer(container.id, { name: 'Epic 2' });
+    await engine.updateIteration(iteration.id, { goal: 'Ship' });
+    await engine.deleteTeam(team.id);
+    await engine.deleteContainer(container.id);
+    await engine.deleteIteration(iteration.id);
+
+    expect(events.map((e) => e.name)).toEqual([
+      'iteration.created',
+      'team.updated',
+      'container.updated',
+      'iteration.updated',
+      'team.deleted',
+      'container.deleted',
+      'iteration.deleted'
+    ]);
+    const teamUpdated = events.find((e) => e.name === 'team.updated')!.payload as any;
+    expect(teamUpdated.previous.name).toBe('Core');
+    expect(teamUpdated.team.name).toBe('Platform');
+    expect(events.find((e) => e.name === 'iteration.deleted')!.payload).toMatchObject({ projectId: project.id, name: 'S1' });
+    expect(new Set(events.map((e) => e.id)).size).toBe(events.length);
+  });
+
+  it('routes deletion webhooks to the owning tenant', async () => {
+    const delivered: Array<{ url: string; event: string }> = [];
+    const engine = new CriticalPathEngine({
+      webhookDelivery: {
+        fetch: (async (url: string, init: RequestInit) => {
+          delivered.push({ url, event: JSON.parse(init.body as string).event });
+          return new Response(null, { status: 204 });
+        }) as unknown as typeof fetch
+      }
+    });
+    const acme = engine.withActor({ userId: 'a', tenantId: 'acme' });
+    const globex = engine.withActor({ userId: 'g', tenantId: 'globex' });
+    await acme.createWebhook({ name: 'Acme', url: 'https://hooks.example.com/acme', events: ['team.deleted', 'container.deleted'] });
+    await globex.createWebhook({ name: 'Globex', url: 'https://hooks.example.com/globex', events: ['*'] });
+
+    const project = await acme.createProject({ name: 'Acme' });
+    const team = await acme.createTeam({ name: 'Team', memberIds: [] });
+    const container = await acme.createContainer({ projectId: project.id, name: 'C' });
+    await acme.deleteTeam(team.id);
+    await acme.deleteContainer(container.id);
+    await engine.webhooks.idle();
+
+    expect(delivered.map((d) => d.event).sort()).toEqual(['container.deleted', 'team.deleted']);
+    expect(delivered.every((d) => d.url.endsWith('/acme'))).toBe(true);
+  });
+});