@critical-path/core 0.29.0 → 0.31.0

package/src/store/query.ts

@@ -0,0 +1,113 @@
+import type { Activity, Task } from '../types/index.js';
+import { ValidationError } from '../domain/errors.js';
+
+export const DEFAULT_PAGE_SIZE = 100;
+export const MAX_PAGE_SIZE = 500;
+
+/** Filters for `queryTasks`. All given filters must match. */
+export interface TaskQuery {
+  projectId?: string;
+  /** Restrict to these projects (used for authorization when no `projectId` is given). */
+  projectIds?: string[];
+  /** Any of these statuses. */
+  status?: string[];
+  /** Matches `assigneeId` or any entry in `assignees`. */
+  assigneeId?: string;
+  /** Any of these priorities. */
+  priority?: string[];
+  iterationId?: string;
+  deliverableId?: string;
+  containerId?: string;
+  /** A task id for its subtasks, or `null` for top-level tasks only. */
+  parentId?: string | null;
+  limit?: number;
+  /** Opaque cursor from a previous page's `nextCursor`. */
+  cursor?: string;
+}
+
+export interface ActivityQuery {
+  projectId?: string;
+  projectIds?: string[];
+  taskId?: string;
+  limit?: number;
+  cursor?: string;
+}
+
+/** One page of results. `nextCursor` is set when more results exist. */
+export interface Page<T> {
+  items: T[];
+  nextCursor?: string;
+}
+
+/** Clamps a requested page size to `[1, MAX_PAGE_SIZE]`, defaulting to `DEFAULT_PAGE_SIZE`. */
+export function pageSize(limit: number | undefined): number {
+  if (limit === undefined || !Number.isFinite(limit)) return DEFAULT_PAGE_SIZE;
+  return Math.min(Math.max(1, Math.floor(limit)), MAX_PAGE_SIZE);
+}
+
+/** Cursors encode the last item's sort key and id (keyset pagination). */
+export function encodeCursor(sortKey: string, id: string): string {
+  return btoa(JSON.stringify([sortKey, id])).replace(/=+$/, '');
+}
+
+export function decodeCursor(cursor: string | undefined): [string, string] | undefined {
+  if (!cursor) return undefined;
+  try {
+    const value = JSON.parse(atob(cursor));
+    if (Array.isArray(value) && value.length === 2 && value.every((v) => typeof v === 'string')) {
+      return value as [string, string];
+    }
+  } catch {
+    // fall through
+  }
+  throw new ValidationError('Invalid pagination cursor.');
+}
+
+export function matchesTaskQuery(task: Task, query: TaskQuery): boolean {
+  if (query.projectId && task.projectId !== query.projectId) return false;
+  if (query.projectIds && !query.projectIds.includes(task.projectId)) return false;
+  if (query.status?.length && !query.status.includes(task.status)) return false;
+  if (query.priority?.length && !query.priority.includes(task.priority)) return false;
+  if (query.iterationId && task.iterationId !== query.iterationId) return false;
+  if (query.deliverableId && task.deliverableId !== query.deliverableId) return false;
+  if (query.containerId && task.containerId !== query.containerId) return false;
+  if (query.parentId === null && task.parentId) return false;
+  if (query.parentId && task.parentId !== query.parentId) return false;
+  if (query.assigneeId && task.assigneeId !== query.assigneeId && !task.assignees?.some((a) => a.id === query.assigneeId)) {
+    return false;
+  }
+  return true;
+}
+
+export function matchesActivityQuery(activity: Activity, query: ActivityQuery): boolean {
+  if (query.projectId && activity.projectId !== query.projectId) return false;
+  if (query.projectIds && (!activity.projectId || !query.projectIds.includes(activity.projectId))) return false;
+  if (query.taskId && activity.taskId !== query.taskId) return false;
+  return true;
+}
+
+/**
+ * Sorts by `(sortKey, id)` and returns the page after `cursor`. Tasks page oldest first
+ * (`asc`), activity feeds newest first (`desc`).
+ */
+export function paginate<T extends { id: string }>(
+  items: T[],
+  sortKey: (item: T) => string,
+  direction: 'asc' | 'desc',
+  limit: number | undefined,
+  cursor: string | undefined
+): Page<T> {
+  const sign = direction === 'asc' ? 1 : -1;
+  const compare = (a: [string, string], b: [string, string]) =>
+    sign * (a[0] < b[0] ? -1 : a[0] > b[0] ? 1 : a[1] < b[1] ? -1 : a[1] > b[1] ? 1 : 0);
+  const after = decodeCursor(cursor);
+  const sorted = [...items].sort((a, b) => compare([sortKey(a), a.id], [sortKey(b), b.id]));
+  const remaining = after ? sorted.filter((item) => compare([sortKey(item), item.id], after) > 0) : sorted;
+  const size = pageSize(limit);
+  const page = remaining.slice(0, size);
+  const last = page[page.length - 1];
+  return {
+    items: page,
+    nextCursor: remaining.length > size && last ? encodeCursor(sortKey(last), last.id) : undefined
+  };
+}

package/src/store/sqlite.ts

@@ -1,5 +1,6 @@
 import type { DatabaseSync } from 'node:sqlite';
 import type { StorageAdapter } from './index.js';
+import { decodeCursor, encodeCursor, pageSize, type ActivityQuery, type Page, type TaskQuery } from './query.js';
 import type {
   Project,
   Task,
@@ -288,6 +289,17 @@ export class SQLiteStore implements StorageAdapter {
       // Column may already exist
     }
 
+    // Indexes for filtered queries and keyset pagination
+    this.db.exec(`
+      CREATE INDEX IF NOT EXISTS idx_tasks_project_created ON tasks (projectId, createdAt, id);
+      CREATE INDEX IF NOT EXISTS idx_tasks_parent ON tasks (parentId);
+      CREATE INDEX IF NOT EXISTS idx_activities_project_created ON activities (projectId, createdAt, id);
+      CREATE INDEX IF NOT EXISTS idx_activities_task_created ON activities (taskId, createdAt, id);
+      CREATE INDEX IF NOT EXISTS idx_comments_task ON comments (taskId);
+      CREATE INDEX IF NOT EXISTS idx_dependencies_task ON dependencies (taskId);
+      CREATE INDEX IF NOT EXISTS idx_dependencies_upstream ON dependencies (dependsOnTaskId);
+    `);
+
     for (const column of ['name TEXT', 'tenantId TEXT']) {
       try {
         this.db.exec(`ALTER TABLE webhooks ADD COLUMN ${column}`);
@@ -688,6 +700,55 @@ export class SQLiteStore implements StorageAdapter {
     return rows.map((r) => this.mapTask(r));
   }
 
+  async queryTasks(query: TaskQuery): Promise<Page<Task>> {
+    const where: string[] = [];
+    const params: Array<string | number> = [];
+    const inList = (column: string, values: string[]) => {
+      where.push(`${column} IN (${values.map(() => '?').join(', ')})`);
+      params.push(...values);
+    };
+
+    if (query.projectId) {
+      where.push('projectId = ?');
+      params.push(query.projectId);
+    }
+    if (query.projectIds) {
+      if (query.projectIds.length === 0) return { items: [] };
+      inList('projectId', query.projectIds);
+    }
+    if (query.status?.length) inList('status', query.status);
+    if (query.priority?.length) inList('priority', query.priority);
+    for (const column of ['iterationId', 'deliverableId', 'containerId'] as const) {
+      if (query[column]) {
+        where.push(`${column} = ?`);
+        params.push(query[column]!);
+      }
+    }
+    if (query.parentId === null) where.push('parentId IS NULL');
+    else if (query.parentId) {
+      where.push('parentId = ?');
+      params.push(query.parentId);
+    }
+    if (query.assigneeId) {
+      where.push(
+        "(assigneeId = ? OR EXISTS (SELECT 1 FROM json_each(COALESCE(assignees, '[]')) WHERE json_extract(value, '$.id') = ?))"
+      );
+      params.push(query.assigneeId, query.assigneeId);
+    }
+    const after = decodeCursor(query.cursor);
+    if (after) {
+      where.push('(createdAt > ? OR (createdAt = ? AND id > ?))');
+      params.push(after[0], after[0], after[1]);
+    }
+
+    const size = pageSize(query.limit);
+    const sql = `SELECT * FROM tasks ${where.length ? `WHERE ${where.join(' AND ')}` : ''} ORDER BY createdAt ASC, id ASC LIMIT ?`;
+    const rows = this.db.prepare(sql).all(...params, size + 1) as any[];
+    const items = rows.slice(0, size).map((r) => this.mapTask(r));
+    const last = items[items.length - 1];
+    return { items, nextCursor: rows.length > size && last ? encodeCursor(last.createdAt, last.id) : undefined };
+  }
+
   async getTask(id: string): Promise<Task | null> {
     const stmt = this.db.prepare('SELECT * FROM tasks WHERE id = ?');
     const row = stmt.get(id) as any;
@@ -1124,6 +1185,38 @@ export class SQLiteStore implements StorageAdapter {
     );
   }
 
+  async queryActivities(query: ActivityQuery): Promise<Page<Activity>> {
+    const where: string[] = [];
+    const params: Array<string | number> = [];
+    if (query.projectId) {
+      where.push('projectId = ?');
+      params.push(query.projectId);
+    }
+    if (query.projectIds) {
+      if (query.projectIds.length === 0) return { items: [] };
+      where.push(`projectId IN (${query.projectIds.map(() => '?').join(', ')})`);
+      params.push(...query.projectIds);
+    }
+    if (query.taskId) {
+      where.push('taskId = ?');
+      params.push(query.taskId);
+    }
+    const after = decodeCursor(query.cursor);
+    if (after) {
+      where.push('(createdAt < ? OR (createdAt = ? AND id < ?))');
+      params.push(after[0], after[0], after[1]);
+    }
+
+    const size = pageSize(query.limit);
+    const sql = `SELECT * FROM activities ${where.length ? `WHERE ${where.join(' AND ')}` : ''} ORDER BY createdAt DESC, id DESC LIMIT ?`;
+    const rows = this.db.prepare(sql).all(...params, size + 1) as any[];
+    const items: Activity[] = rows
+      .slice(0, size)
+      .map((r) => dropNulls({ ...r, details: r.details ? JSON.parse(r.details) : undefined }));
+    const last = items[items.length - 1];
+    return { items, nextCursor: rows.length > size && last ? encodeCursor(last.createdAt, last.id) : undefined };
+  }
+
   async logActivity(activity: Omit<Activity, 'id' | 'createdAt'>): Promise<Activity> {
     const id = `act_${Math.random().toString(36).substring(2, 9)}`;
     const now = new Date().toISOString();

package/tsconfig.tsbuildinfo

@@ -1 +1 @@
-{"root":["./src/deliverables.test.ts","./src/index.test.ts","./src/index.ts","./src/status.test.ts","./src/task-state.test.ts","./src/use-case-validation.test.ts","./src/domain/authorization.ts","./src/domain/calendar.test.ts","./src/domain/calendar.ts","./src/domain/cpm.test.ts","./src/domain/cpm.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/errors.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/domain/ladder.test.ts","./src/domain/ladder.ts","./src/domain/metrics.test.ts","./src/domain/metrics.ts","./src/domain/task-duration.test.ts","./src/domain/workload.test.ts","./src/domain/workload.ts","./src/engine/actor.test.ts","./src/engine/authorization.test.ts","./src/engine/cascade.test.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/plugins/plugins.test.ts","./src/schemas/index.ts","./src/schemas/schemas.test.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/types/index.ts","./src/utils/fractional-index.test.ts","./src/utils/fractional-index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/mentions.test.ts","./src/utils/mentions.ts","./src/utils/status.ts","./src/utils/workflow.ts","./src/webhooks/dispatcher.ts","./src/webhooks/index.ts","./src/webhooks/signature.ts","./src/webhooks/webhooks.test.ts"],"version":"5.9.3"}
+{"root":["./src/deliverables.test.ts","./src/index.test.ts","./src/index.ts","./src/status.test.ts","./src/task-state.test.ts","./src/use-case-validation.test.ts","./src/domain/authorization.ts","./src/domain/calendar.test.ts","./src/domain/calendar.ts","./src/domain/cpm.test.ts","./src/domain/cpm.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/errors.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/domain/ladder.test.ts","./src/domain/ladder.ts","./src/domain/metrics.test.ts","./src/domain/metrics.ts","./src/domain/task-duration.test.ts","./src/domain/workload.test.ts","./src/domain/workload.ts","./src/engine/actor.test.ts","./src/engine/authorization.test.ts","./src/engine/cascade.test.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/plugins/plugins.test.ts","./src/schemas/index.ts","./src/schemas/schemas.test.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/query.test.ts","./src/store/query.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/types/index.ts","./src/utils/fractional-index.test.ts","./src/utils/fractional-index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/mentions.test.ts","./src/utils/mentions.ts","./src/utils/status.ts","./src/utils/workflow.ts","./src/webhooks/dispatcher.ts","./src/webhooks/index.ts","./src/webhooks/signature.ts","./src/webhooks/webhooks.test.ts"],"version":"5.9.3"}