@critical-path/core 0.25.0 → 0.26.0

package/src/schemas/index.ts

@@ -111,7 +111,9 @@ export const CreateProjectSchema = strictObject({
   name: nonEmpty,
   description: z.string().optional(),
   ownerId: z.string().optional(),
-  members: z.array(z.string()).optional(),
+  members: z
+    .array(strictObject({ userId: nonEmpty, role: z.enum(['admin', 'project_manager', 'contributor', 'viewer']) }))
+    .optional(),
   teamIds: z.array(z.string()).optional(),
   workflowId: z.string().optional(),
   taskTypes: z.array(TaskTypeDefinitionSchema).optional(),
@@ -303,6 +305,8 @@ export const UploadAttachmentSchema = strictObject({
 });
 
 export const PresignAttachmentSchema = strictObject({
+  /** Project the upload belongs to; scoped callers may only write under `projects/<projectId>/`. */
+  projectId: nonEmpty,
   storageKey: nonEmpty,
   expiresInSeconds: z.number().int().positive().optional(),
   contentType: z.string().optional()

package/src/schemas/schemas.test.ts

@@ -46,7 +46,8 @@ type SameKeys<Schema, Expected> = [Exclude<keyof Schema, keyof Expected>, Exclud
   : { extraInSchema: Exclude<keyof Schema, keyof Expected>; missingFromSchema: Exclude<keyof Expected, keyof Schema> };
 
 type Infer<S extends z.ZodTypeAny> = z.infer<S>;
-type ServerAssigned = 'id' | 'createdAt' | 'updatedAt';
+// tenantId is stamped from the actor by the engine, never accepted from payloads.
+type ServerAssigned = 'id' | 'createdAt' | 'updatedAt' | 'tenantId';
 // Identity is resolved by the server (withActor), never accepted in payloads.
 type CommentIdentity = 'authorId' | 'authorType';
 type UploaderIdentity = 'uploaderId' | 'uploaderType';
@@ -55,7 +56,7 @@ const keyChecks: true[] = [
   true as SameKeys<Infer<typeof CreateTaskSchema>, Omit<CreateTaskInput, 'key'>>,
   true as SameKeys<Infer<typeof UpdateTaskSchema>, Omit<Task, ServerAssigned | 'key' | 'projectId'>>,
   // `workflow` is a denormalised copy resolved from `workflowId`, so it is not writable.
-  true as SameKeys<Infer<typeof CreateProjectSchema>, Omit<CreateProjectInput, 'workflow'>>,
+  true as SameKeys<Infer<typeof CreateProjectSchema>, Omit<CreateProjectInput, 'workflow' | 'tenantId'>>,
   true as SameKeys<Infer<typeof UpdateProjectSchema>, Omit<Project, ServerAssigned | 'workflow'>>,
   true as SameKeys<Infer<typeof CreateWorkflowSchema>, Omit<Workflow, ServerAssigned>>,
   true as SameKeys<Infer<typeof CreateDeliverableSchema>, CreateDeliverableInput>,

package/src/store/sqlite.ts

@@ -279,6 +279,14 @@ export class SQLiteStore implements StorageAdapter {
     } catch {
       // Column may already exist
     }
+
+    for (const table of ['projects', 'workflows', 'teams']) {
+      try {
+        this.db.exec(`ALTER TABLE ${table} ADD COLUMN tenantId TEXT`);
+      } catch {
+        // Column may already exist
+      }
+    }
   }
 
   // --- Projects ---
@@ -301,8 +309,8 @@ export class SQLiteStore implements StorageAdapter {
     const newProj: Project = { ...project, key, id, createdAt: now, updatedAt: now };
 
     const stmt = this.db.prepare(`
-      INSERT INTO projects (id, key, name, description, ownerId, members, teamIds, workflowId, taskTypes, statusDefinitions, priorityDefinitions, customFieldDefinitions, createdAt, updatedAt)
-      VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+      INSERT INTO projects (id, key, name, description, ownerId, members, teamIds, workflowId, taskTypes, statusDefinitions, priorityDefinitions, customFieldDefinitions, tenantId, createdAt, updatedAt)
+      VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
     `);
     stmt.run(
       newProj.id,
@@ -317,6 +325,7 @@ export class SQLiteStore implements StorageAdapter {
       JSON.stringify(newProj.statusDefinitions || []),
       JSON.stringify(newProj.priorityDefinitions || []),
       JSON.stringify(newProj.customFieldDefinitions || []),
+      newProj.tenantId ?? null,
       newProj.createdAt,
       newProj.updatedAt
     );
@@ -375,8 +384,8 @@ export class SQLiteStore implements StorageAdapter {
     const newWf: Workflow = { ...workflow, id, createdAt: now, updatedAt: now };
 
     const stmt = this.db.prepare(`
-      INSERT INTO workflows (id, name, description, statuses, transitions, taskTypes, defaultStatusKey, isDefault, createdAt, updatedAt)
-      VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+      INSERT INTO workflows (id, name, description, statuses, transitions, taskTypes, defaultStatusKey, isDefault, tenantId, createdAt, updatedAt)
+      VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
     `);
     stmt.run(
       newWf.id,
@@ -387,6 +396,7 @@ export class SQLiteStore implements StorageAdapter {
       newWf.taskTypes ? JSON.stringify(newWf.taskTypes) : null,
       newWf.defaultStatusKey || null,
       newWf.isDefault ? 1 : 0,
+      newWf.tenantId ?? null,
       newWf.createdAt,
       newWf.updatedAt
     );
@@ -452,8 +462,8 @@ export class SQLiteStore implements StorageAdapter {
     const newTeam: Team = { ...team, id, createdAt: now, updatedAt: now };
 
     const stmt = this.db.prepare(`
-      INSERT INTO teams (id, name, description, leaderId, memberIds, createdAt, updatedAt)
-      VALUES (?, ?, ?, ?, ?, ?, ?)
+      INSERT INTO teams (id, name, description, leaderId, memberIds, tenantId, createdAt, updatedAt)
+      VALUES (?, ?, ?, ?, ?, ?, ?, ?)
     `);
     stmt.run(
       newTeam.id,
@@ -461,6 +471,7 @@ export class SQLiteStore implements StorageAdapter {
       newTeam.description || null,
       newTeam.leaderId || null,
       JSON.stringify(newTeam.memberIds || []),
+      newTeam.tenantId ?? null,
       newTeam.createdAt,
       newTeam.updatedAt
     );
@@ -1195,6 +1206,7 @@ export class SQLiteStore implements StorageAdapter {
   private mapProject(row: any): Project {
     return {
       ...row,
+      tenantId: row.tenantId ?? undefined,
       workflowId: row.workflowId || undefined,
       taskTypes: row.taskTypes ? JSON.parse(row.taskTypes) : undefined,
       members: row.members ? JSON.parse(row.members) : [],
@@ -1208,6 +1220,7 @@ export class SQLiteStore implements StorageAdapter {
   private mapWorkflow(row: any): Workflow {
     return {
       ...row,
+      tenantId: row.tenantId ?? undefined,
       statuses: row.statuses ? JSON.parse(row.statuses) : [],
       transitions: row.transitions ? JSON.parse(row.transitions) : [],
       taskTypes: row.taskTypes ? JSON.parse(row.taskTypes) : undefined,
@@ -1218,6 +1231,7 @@ export class SQLiteStore implements StorageAdapter {
   private mapTeam(row: any): Team {
     return {
       ...row,
+      tenantId: row.tenantId ?? undefined,
       memberIds: row.memberIds ? JSON.parse(row.memberIds) : []
     };
   }

package/src/types/index.ts

@@ -78,6 +78,8 @@ export interface Team {
   memberIds: string[];
   weeklyCapacityHours?: number;
   schedule?: WorkSchedule;
+  /** Tenant that owns the team. Set by the engine from the creating actor. */
+  tenantId?: string;
   createdAt: string;
   updatedAt: string;
 }
@@ -117,6 +119,8 @@ export interface Workflow {
   taskTypes?: TaskTypeDefinition[];
   defaultStatusKey?: string;
   isDefault?: boolean;
+  /** Tenant that owns the workflow. Set by the engine from the creating actor. */
+  tenantId?: string;
   createdAt: string;
   updatedAt: string;
 }
@@ -127,7 +131,10 @@ export interface Project {
   name: string;
   description?: string;
   ownerId?: string;
-  members?: string[]; // user IDs
+  /** Project membership and roles, used by role-based authorization policies. */
+  members?: ProjectMember[];
+  /** Tenant that owns the project. Set by the engine from the creating actor; never from payloads. */
+  tenantId?: string;
   teamIds?: string[]; // team IDs
   workflowId?: string;
   workflow?: Workflow;
@@ -305,6 +312,21 @@ export interface Actor {
   userId: string;
   username?: string;
   actorType?: AuthorType;
+  /**
+   * Tenant the actor belongs to. When set, the actor only sees projects, workflows and teams
+   * with the same `tenantId`, and everything it creates is stamped with it.
+   */
+  tenantId?: string;
+  /** Workspace-wide roles, e.g. `['admin']`. Interpreted by the authorization policy. */
+  roles?: string[];
+}
+
+/** A user's role on a project. */
+export type ProjectRole = Role;
+
+export interface ProjectMember {
+  userId: string;
+  role: ProjectRole;
 }
 
 export interface CommentReaction {
@@ -462,6 +484,13 @@ export interface CriticalPathPlugin {
 }
 
 export interface CriticalPathConfig {
+  /**
+   * Authorization policy applied to every call made through a `withActor` view (which is how
+   * `@critical-path/server` and the MCP server call the engine). Calls on the base engine are
+   * trusted. Use `createRolePolicy()` for project-membership roles, or supply your own.
+   * When omitted, actors may do anything within their tenant.
+   */
+  authorize?: AuthorizationPolicy;
   store?: 'memory' | 'sqlite' | unknown;
   fileStorage?: FileStorageAdapter;
   plugins?: CriticalPathPlugin[];
@@ -742,3 +771,39 @@ export interface WorkloadDistributionOptions {
   teamSchedules?: Record<string, WorkSchedule>;
 }
 
+// ==========================================
+// Authorization
+// ==========================================
+
+/**
+ * Operations the engine authorizes. Project-scoped actions are checked against a project;
+ * `project.create` and `workspace.manage` (workflows, teams, webhooks) are workspace-level.
+ */
+export type AuthorizationAction =
+  | 'project.read'
+  | 'project.create'
+  | 'project.update'
+  | 'project.delete'
+  | 'project.manage_members'
+  | 'task.create'
+  | 'task.update'
+  | 'task.delete'
+  | 'comment.create'
+  | 'comment.moderate'
+  | 'attachment.create'
+  | 'attachment.delete'
+  | 'time.log'
+  | 'plan.manage'
+  | 'workspace.manage';
+
+export interface AuthorizationRequest {
+  actor: Actor;
+  action: AuthorizationAction;
+  /** The project the action targets, for project-scoped actions. */
+  project?: Project;
+  /** The specific record, when relevant (e.g. the comment being edited). */
+  resource?: { type: 'task' | 'comment' | 'attachment'; ownerId?: string };
+}
+
+export type AuthorizationPolicy = (request: AuthorizationRequest) => boolean | Promise<boolean>;
+

package/tsconfig.tsbuildinfo

@@ -1 +1 @@
-{"root":["./src/deliverables.test.ts","./src/index.test.ts","./src/index.ts","./src/status.test.ts","./src/task-state.test.ts","./src/use-case-validation.test.ts","./src/domain/calendar.test.ts","./src/domain/calendar.ts","./src/domain/cpm.test.ts","./src/domain/cpm.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/errors.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/domain/ladder.test.ts","./src/domain/ladder.ts","./src/domain/metrics.test.ts","./src/domain/metrics.ts","./src/domain/task-duration.test.ts","./src/domain/workload.test.ts","./src/domain/workload.ts","./src/engine/actor.test.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/schemas/index.ts","./src/schemas/schemas.test.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/types/index.ts","./src/utils/fractional-index.test.ts","./src/utils/fractional-index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/mentions.test.ts","./src/utils/mentions.ts","./src/utils/status.ts","./src/utils/workflow.ts"],"version":"5.9.3"}
+{"root":["./src/deliverables.test.ts","./src/index.test.ts","./src/index.ts","./src/status.test.ts","./src/task-state.test.ts","./src/use-case-validation.test.ts","./src/domain/authorization.ts","./src/domain/calendar.test.ts","./src/domain/calendar.ts","./src/domain/cpm.test.ts","./src/domain/cpm.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/errors.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/domain/ladder.test.ts","./src/domain/ladder.ts","./src/domain/metrics.test.ts","./src/domain/metrics.ts","./src/domain/task-duration.test.ts","./src/domain/workload.test.ts","./src/domain/workload.ts","./src/engine/actor.test.ts","./src/engine/authorization.test.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/schemas/index.ts","./src/schemas/schemas.test.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/types/index.ts","./src/utils/fractional-index.test.ts","./src/utils/fractional-index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/mentions.test.ts","./src/utils/mentions.ts","./src/utils/status.ts","./src/utils/workflow.ts"],"version":"5.9.3"}