@critical-path/core 0.21.0 → 0.23.0

package/src/utils/fractional-index.ts

@@ -108,40 +108,35 @@ export function getIntegerPart(key: string): string {
 }
 
 /**
- * Computes a fractional midpoint suffix between suffixA and suffixB.
+ * Computes a fractional suffix strictly between suffixes `a` and `b` (a < result < b).
+ * Missing digits in `a` are treated as '0', so `a` may be shorter than `b`.
+ * `b === null` means there is no upper bound.
  */
 function midpointSuffix(a: string, b: string | null): string {
-  let i = 0;
-  while (i < a.length && b !== null && i < b.length && a[i] === b[i]) {
-    i++;
+  if (b !== null) {
+    let n = 0;
+    while (n < b.length && (a[n] ?? '0') === b[n]) {
+      n++;
+    }
+    if (n > 0) {
+      return b.slice(0, n) + midpointSuffix(a.slice(n), b.slice(n));
+    }
   }
 
-  const common = a.slice(0, i);
-  const charA = i < a.length ? a[i] : null;
-  const charB = b !== null && i < b.length ? b[i] : null;
-
-  const digitA = charA !== null ? BASE_62.indexOf(charA) : 0;
-  const digitB = charB !== null ? BASE_62.indexOf(charB) : BASE_62.length;
+  const digitA = a.length > 0 ? BASE_62.indexOf(a[0]) : 0;
+  const digitB = b !== null ? BASE_62.indexOf(b[0]) : BASE_62.length;
 
   if (digitB - digitA > 1) {
-    const mid = Math.floor((digitA + digitB) / 2);
-    return common + BASE_62[mid];
+    return BASE_62[Math.floor((digitA + digitB) / 2)];
   }
 
-  if (charA !== null) {
-    const restA = a.slice(i + 1);
-    const restB = b !== null && i < b.length && charA === charB ? b.slice(i + 1) : null;
-    return common + charA + midpointSuffix(restA, restB);
-  }
-
-  if (b !== null && i < b.length) {
-    if (digitB === 0) {
-      const restB = b.slice(i + 1);
-      return common + '0' + midpointSuffix('', restB);
-    }
+  // Adjacent digits: if b has more digits, its first digit alone already sits between a and b.
+  if (b !== null && b.length > 1) {
+    return b[0];
   }
 
-  return common + 'V';
+  // Otherwise keep a's digit and subdivide the remainder with no upper bound.
+  return BASE_62[digitA] + midpointSuffix(a.slice(1), null);
 }
 
 /**
@@ -185,8 +180,7 @@ export function generateKeyBetween(
 
   // Both a and b are present
   if (a! >= b!) {
-    // Graceful fallback for inverted or equal keys
-    return a! + 'V';
+    throw new RangeError(`generateKeyBetween: lower bound "${a}" must sort before upper bound "${b}"`);
   }
 
   const intA = getIntegerPart(a!);

package/tsconfig.tsbuildinfo

@@ -1 +1 @@
-{"root":["./src/deliverables.test.ts","./src/index.test.ts","./src/index.ts","./src/status.test.ts","./src/task-state.test.ts","./src/use-case-validation.test.ts","./src/domain/calendar.test.ts","./src/domain/calendar.ts","./src/domain/cpm.test.ts","./src/domain/cpm.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/domain/ladder.test.ts","./src/domain/ladder.ts","./src/domain/metrics.test.ts","./src/domain/metrics.ts","./src/domain/task-duration.test.ts","./src/domain/workload.test.ts","./src/domain/workload.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/types/index.ts","./src/utils/fractional-index.test.ts","./src/utils/fractional-index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/mentions.test.ts","./src/utils/mentions.ts","./src/utils/status.ts","./src/utils/workflow.ts"],"version":"5.9.3"}
+{"root":["./src/deliverables.test.ts","./src/index.test.ts","./src/index.ts","./src/status.test.ts","./src/task-state.test.ts","./src/use-case-validation.test.ts","./src/domain/calendar.test.ts","./src/domain/calendar.ts","./src/domain/cpm.test.ts","./src/domain/cpm.ts","./src/domain/custom-fields.ts","./src/domain/ddd.test.ts","./src/domain/entities.ts","./src/domain/errors.ts","./src/domain/events.ts","./src/domain/graph.ts","./src/domain/index.ts","./src/domain/ladder.test.ts","./src/domain/ladder.ts","./src/domain/metrics.test.ts","./src/domain/metrics.ts","./src/domain/task-duration.test.ts","./src/domain/workload.test.ts","./src/domain/workload.ts","./src/engine/actor.test.ts","./src/engine/index.ts","./src/plugins/index.ts","./src/storage/file-storage.ts","./src/storage/firebase-storage.ts","./src/storage/index.ts","./src/storage/s3.ts","./src/storage/storage.test.ts","./src/store/firebase.test.ts","./src/store/firebase.ts","./src/store/index.ts","./src/store/sqlite.test.ts","./src/store/sqlite.ts","./src/types/index.ts","./src/utils/fractional-index.test.ts","./src/utils/fractional-index.ts","./src/utils/index.ts","./src/utils/key.test.ts","./src/utils/key.ts","./src/utils/mentions.test.ts","./src/utils/mentions.ts","./src/utils/status.ts","./src/utils/workflow.ts"],"version":"5.9.3"}