@critical-path/core 0.20.2 → 0.22.0

package/dist/utils/status.js

@@ -139,4 +139,198 @@ export function deriveTaskLifecycleState(task, customDefinitionsOrOptions, legac
         isCancelled
     };
 }
+/**
+ * Extracts a list of StatusDefinitions from either a Workflow or an array of definitions.
+ */
+export function extractStatusDefinitions(workflowOrStatuses) {
+    if (!workflowOrStatuses)
+        return undefined;
+    if (Array.isArray(workflowOrStatuses)) {
+        return workflowOrStatuses;
+    }
+    if (typeof workflowOrStatuses === 'object' && workflowOrStatuses !== null) {
+        const statuses = workflowOrStatuses.statuses;
+        if (Array.isArray(statuses)) {
+            return statuses;
+        }
+    }
+    return undefined;
+}
+/**
+ * Checks whether a task is flagged as a draft outside the active workflow.
+ */
+export function isDraftTask(task) {
+    if (!task)
+        return false;
+    return Boolean(task.isDraft);
+}
+/**
+ * Checks whether a task is archived.
+ */
+export function isArchivedTask(task) {
+    if (!task)
+        return false;
+    return (Boolean(task.archived) ||
+        Boolean(task.archivedAt) ||
+        task.status === 'archived' ||
+        Boolean(task.customFields?.isArchived));
+}
+/**
+ * Checks whether a task is soft-deleted / trashed.
+ */
+export function isTrashedTask(task) {
+    if (!task)
+        return false;
+    return (Boolean(task.trashed) ||
+        Boolean(task.trashedAt) ||
+        task.status === 'trashed' ||
+        Boolean(task.customFields?.isTrashed));
+}
+/**
+ * Checks whether a task is trashed, archived, or soft-deleted.
+ */
+export function isTrashedOrArchivedTask(task) {
+    if (!task)
+        return false;
+    return isTrashedTask(task) || isArchivedTask(task);
+}
+/**
+ * Determines whether a task is part of the legitimate project workflow.
+ * A workflow task is not trashed, not archived, and not a draft.
+ */
+export function isWorkflowTask(task) {
+    if (!task)
+        return false;
+    return !isTrashedTask(task) && !isArchivedTask(task) && !isDraftTask(task);
+}
+export const isTaskDraft = isDraftTask;
+export const isTaskArchived = isArchivedTask;
+export const isTaskTrashed = isTrashedTask;
+export const isTaskTrashedOrArchived = isTrashedOrArchivedTask;
+export const isTaskWorkflow = isWorkflowTask;
+/**
+ * Resolves the canonical SemanticStatus for a task based on the project's workflow or default heuristics.
+ */
+export function getTaskSemanticStatus(task, workflowOrStatuses) {
+    if (!task)
+        return 'not_started';
+    const customDefs = extractStatusDefinitions(workflowOrStatuses);
+    // 1. Look up the task's status in custom workflow definitions
+    if (task.status) {
+        if (customDefs) {
+            const match = customDefs.find((s) => s.key === task.status);
+            if (match?.category)
+                return match.category;
+            if (match) {
+                if (match.completionState === 'done') {
+                    return match.isCancelled ? 'canceled' : 'completed';
+                }
+                if (match.executionState === 'active') {
+                    return 'in_progress';
+                }
+                if (match.completionState === 'not_done') {
+                    return 'not_started';
+                }
+            }
+        }
+        // 2. Default status definition lookup from @critical-path/core for standard statuses
+        const normalizedKey = task.status.toLowerCase().replace(/[-\s]+/g, '_');
+        const defaultDef = DEFAULT_STATUS_DEFINITIONS[task.status] || DEFAULT_STATUS_DEFINITIONS[normalizedKey];
+        if (defaultDef?.category) {
+            return defaultDef.category;
+        }
+    }
+    // 3. If task has an explicit valid semanticStatus (for custom/unknown status), use it
+    if (task.semanticStatus) {
+        const raw = String(task.semanticStatus).toLowerCase();
+        if (raw === 'completed' ||
+            raw === 'in_progress' ||
+            raw === 'not_started' ||
+            raw === 'canceled' ||
+            raw === 'cancelled') {
+            return raw === 'cancelled' ? 'canceled' : raw;
+        }
+    }
+    // 4. Fallback to resolveStatusDefinition for general fallback or 'not_started'
+    if (task.status) {
+        const def = resolveStatusDefinition(task.status, customDefs);
+        if (def?.category) {
+            return def.category;
+        }
+    }
+    return 'not_started';
+}
+/**
+ * Determines whether a task has reached completion in its lifecycle.
+ */
+export function isTaskCompleted(task, workflowOrStatuses) {
+    if (!task)
+        return false;
+    return getTaskSemanticStatus(task, workflowOrStatuses) === 'completed';
+}
+export const isTaskDone = isTaskCompleted;
+/**
+ * Determines whether a task is actively in progress.
+ */
+export function isTaskInProgress(task, workflowOrStatuses) {
+    if (!task)
+        return false;
+    return getTaskSemanticStatus(task, workflowOrStatuses) === 'in_progress';
+}
+/**
+ * Determines whether a task is pending or not yet started.
+ */
+export function isTaskNotStarted(task, workflowOrStatuses) {
+    if (!task)
+        return false;
+    return getTaskSemanticStatus(task, workflowOrStatuses) === 'not_started';
+}
+/**
+ * Determines whether a task has been canceled or abandoned.
+ */
+export function isTaskCanceled(task, workflowOrStatuses) {
+    if (!task)
+        return false;
+    return getTaskSemanticStatus(task, workflowOrStatuses) === 'canceled';
+}
+/**
+ * Determines whether a task is active in an ongoing project workflow.
+ * An active task:
+ * 1. Is not trashed or archived.
+ * 2. Is not a draft (exists within the active workflow).
+ * 3. Has not reached terminal completion ('completed') or terminal abandonment ('canceled').
+ */
+export function isTaskActive(task, workflowOrStatuses) {
+    if (!task)
+        return false;
+    if (isTrashedOrArchivedTask(task))
+        return false;
+    if (isDraftTask(task))
+        return false;
+    const sem = getTaskSemanticStatus(task, workflowOrStatuses);
+    return sem !== 'completed' && sem !== 'canceled';
+}
+/**
+ * Checks whether a task currently has no assigned owner.
+ */
+export function isTaskUnassigned(task) {
+    if (!task)
+        return true;
+    const rawId = task.assigneeId ? String(task.assigneeId).trim() : '';
+    const hasAssigneeId = rawId !== '' && rawId.toLowerCase() !== 'unassigned';
+    const hasValidAssignees = Array.isArray(task.assignees) &&
+        task.assignees.some((a) => {
+            if (!a)
+                return false;
+            if (typeof a === 'string') {
+                const s = a.trim();
+                return s !== '' && s.toLowerCase() !== 'unassigned';
+            }
+            const id = a.id ? String(a.id).trim() : '';
+            const name = a.name ? String(a.name).trim() : '';
+            return ((id !== '' && id.toLowerCase() !== 'unassigned') ||
+                (name !== '' && name.toLowerCase() !== 'unassigned'));
+        });
+    return !hasAssigneeId && !hasValidAssignees;
+}
 //# sourceMappingURL=status.js.map

package/dist/utils/status.js.map

@@ -1 +1 @@
-{"version":3,"file":"status.js","sourceRoot":"","sources":["../../src/utils/status.ts"],"names":[],"mappings":"AAOA,MAAM,CAAC,MAAM,0BAA0B,GAAqC;IAC1E,OAAO,EAAE,EAAE,GAAG,EAAE,SAAS,EAAE,KAAK,EAAE,SAAS,EAAE,QAAQ,EAAE,aAAa,EAAE;IACtE,IAAI,EAAE,EAAE,GAAG,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,aAAa,EAAE;IAC9D,WAAW,EAAE,EAAE,GAAG,EAAE,aAAa,EAAE,KAAK,EAAE,aAAa,EAAE,QAAQ,EAAE,aAAa,EAAE;IAClF,SAAS,EAAE,EAAE,GAAG,EAAE,WAAW,EAAE,KAAK,EAAE,WAAW,EAAE,QAAQ,EAAE,aAAa,EAAE;IAC5E,IAAI,EAAE,EAAE,GAAG,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,QAAQ,EAAE,WAAW,EAAE;IAC3D,QAAQ,EAAE,EAAE,GAAG,EAAE,UAAU,EAAE,KAAK,EAAE,UAAU,EAAE,QAAQ,EAAE,UAAU,EAAE;CACvE,CAAC;AASF,MAAM,UAAU,uBAAuB,CACrC,SAAiB,EACjB,iBAAsC;IAEtC,IAAI,iBAAiB,EAAE,CAAC;QACtB,MAAM,KAAK,GAAG,iBAAiB,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,GAAG,KAAK,SAAS,CAAC,CAAC;QACrE,IAAI,KAAK;YAAE,OAAO,KAAK,CAAC;IAC1B,CAAC;IACD,IAAI,0BAA0B,CAAC,SAAS,CAAC,EAAE,CAAC;QAC1C,OAAO,0BAA0B,CAAC,SAAS,CAAC,CAAC;IAC/C,CAAC;IAED,kDAAkD;IAClD,MAAM,KAAK,GAAG,SAAS,CAAC,WAAW,EAAE,CAAC;IACtC,IAAI,QAAQ,GAAmB,aAAa,CAAC;IAC7C,IAAI,CAAC,UAAU,EAAE,WAAW,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,EAAE,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QACzG,QAAQ,GAAG,UAAU,CAAC;IACxB,CAAC;SAAM,IAAI,CAAC,MAAM,EAAE,WAAW,EAAE,UAAU,EAAE,QAAQ,EAAE,UAAU,EAAE,OAAO,EAAE,WAAW,EAAE,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QACnI,QAAQ,GAAG,WAAW,CAAC;IACzB,CAAC;SAAM,IAAI,CAAC,aAAa,EAAE,QAAQ,EAAE,SAAS,EAAE,WAAW,EAAE,QAAQ,EAAE,SAAS,EAAE,IAAI,EAAE,UAAU,EAAE,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QAC9I,QAAQ,GAAG,aAAa,CAAC;IAC3B,CAAC;IAED,OAAO;QACL,GAAG,EAAE,SAAS;QACd,KAAK,EAAE,SAAS;QAChB,QAAQ;KACT,CAAC;AACJ,CAAC;AAED,MAAM,UAAU,wBAAwB,CACtC,IAAU,EACV,0BAA4E,EAC5E,mBAA0B;IAE1B,IAAI,iBAAiD,CAAC;IACtD,IAAI,aAAa,GAAG,mBAAmB,IAAI,IAAI,IAAI,EAAE,CAAC;IACtD,IAAI,aAAa,GAAW,EAAE,CAAC;IAC/B,IAAI,oBAAoB,GAAG,CAAC,CAAC;IAE7B,IAAI,KAAK,CAAC,OAAO,CAAC,0BAA0B,CAAC,EAAE,CAAC;QAC9C,iBAAiB,GAAG,0BAA0B,CAAC;IACjD,CAAC;SAAM,IAAI,0BAA0B,EAAE,CAAC;QACtC,iBAAiB,GAAG,0BAA0B,CAAC,iBAAiB,CAAC;QACjE,IAAI,0BAA0B,CAAC,aAAa,EAAE,CAAC;YAC7C,aAAa,GAAG,0BAA0B,CAAC,aAAa,CAAC;QAC3D,CAAC;QACD,IAAI,0BAA0B,CAAC,aAAa,EAAE,CAAC;YAC7C,aAAa,GAAG,0BAA0B,CAAC,aAAa,CAAC;QAC3D,CAAC;QACD,IAAI,0BAA0B,CAAC,oBAAoB,KAAK,SAAS,EAAE,CAAC;YAClE,oBAAoB,GAAG,0BAA0B,CAAC,oBAAoB,CAAC;QACzE,CAAC;IACH,CAAC;IAED,MAAM,GAAG,GAAG,uBAAuB,CAAC,IAAI,CAAC,MAAM,EAAE,iBAAiB,CAAC,CAAC;IACpE,MAAM,cAAc,GAAmB,GAAG,CAAC,QAAQ,CAAC;IACpD,MAAM,MAAM,GAAG,cAAc,KAAK,WAAW,IAAI,cAAc,KAAK,UAAU,CAAC;IAC/E,MAAM,QAAQ,GAAG,cAAc,KAAK,aAAa,CAAC;IAClD,MAAM,WAAW,GAAG,cAAc,KAAK,UAAU,CAAC;IAElD,+BAA+B;IAC/B,MAAM,aAAa,GAAG,aAAa,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE;QAC/C,MAAM,WAAW,GAAG,uBAAuB,CAAC,CAAC,CAAC,MAAM,EAAE,iBAAiB,CAAC,CAAC;QACzE,OAAO,WAAW,CAAC,QAAQ,KAAK,WAAW,CAAC;IAC9C,CAAC,CAAC,CAAC;IACH,MAAM,eAAe,GAAG,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;IACvD,MAAM,mBAAmB,GAAG,OAAO,CAAC,IAAI,CAAC,SAAS,KAAK,IAAI,CAAC,CAAC;IAC7D,MAAM,SAAS,GAAG,CAAC,MAAM,IAAI,CAAC,eAAe,CAAC,MAAM,GAAG,CAAC,IAAI,mBAAmB,CAAC,CAAC;IACjF,MAAM,OAAO,GAAG,cAAc,KAAK,aAAa,IAAI,CAAC,SAAS,CAAC;IAE/D,6BAA6B;IAC7B,IAAI,SAAS,GAAG,KAAK,CAAC;IACtB,IAAI,CAAC,MAAM,IAAI,IAAI,CAAC,OAAO,EAAE,CAAC;QAC5B,MAAM,GAAG,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACnC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,OAAO,EAAE,CAAC,IAAI,GAAG,GAAG,aAAa,EAAE,CAAC;YACjD,SAAS,GAAG,IAAI,CAAC;QACnB,CAAC;IACH,CAAC;IAED,IAAI,UAAU,GAAG,KAAK,CAAC;IACvB,IAAI,cAAc,KAAK,aAAa,IAAI,IAAI,CAAC,gBAAgB,EAAE,CAAC;QAC9D,MAAM,YAAY,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,gBAAgB,CAAC,CAAC;QACrD,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,OAAO,EAAE,CAAC,IAAI,YAAY,GAAG,aAAa,EAAE,CAAC;YACnE,UAAU,GAAG,IAAI,CAAC;QACpB,CAAC;IACH,CAAC;IAED,MAAM,WAAW,GAAG,cAAc,KAAK,aAAa,IAAI,CAAC,IAAI,CAAC,WAAW,IAAI,CAAC,IAAI,CAAC,gBAAgB,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC;IAErH,iCAAiC;IACjC,MAAM,WAAW,GAAG,OAAO,CAAC,IAAI,CAAC,UAAU,IAAI,CAAC,IAAI,CAAC,SAAS,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC;IAC9F,MAAM,YAAY,GAAG,CAAC,MAAM,IAAI,CAAC,WAAW,CAAC;IAE7C,IAAI,SAAS,GAAG,KAAK,CAAC;IACtB,IAAI,cAAc,KAAK,aAAa,EAAE,CAAC;QACrC,MAAM,YAAY,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;QACpH,IAAI,YAAY,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;YACnD,MAAM,WAAW,GAAG,oBAAoB,GAAG,EAAE,GAAG,EAAE,GAAG,EAAE,GAAG,IAAI,CAAC;YAC/D,IAAI,aAAa,CAAC,OAAO,EAAE,GAAG,YAAY,CAAC,OAAO,EAAE,GAAG,WAAW,EAAE,CAAC;gBACnE,SAAS,GAAG,IAAI,CAAC;YACnB,CAAC;QACH,CAAC;IACH,CAAC;IAED,+BAA+B;IAC/B,IAAI,cAAc,GAAG,KAAK,CAAC;IAC3B,MAAM,OAAO,GAAG,IAAI,CAAC,WAAW,IAAI,IAAI,CAAC,WAAW,CAAC;IACrD,MAAM,UAAU,GAAG,IAAI,CAAC,cAAc,CAAC;IACvC,IAAI,UAAU,KAAK,SAAS,IAAI,UAAU,GAAG,CAAC,IAAI,OAAO,KAAK,SAAS,IAAI,OAAO,GAAG,UAAU,EAAE,CAAC;QAChG,cAAc,GAAG,IAAI,CAAC;IACxB,CAAC;IACD,MAAM,OAAO,GAAG,IAAI,CAAC,qBAAqB,CAAC;IAC3C,MAAM,UAAU,GAAG,IAAI,CAAC,wBAAwB,CAAC;IACjD,IAAI,UAAU,KAAK,SAAS,IAAI,UAAU,GAAG,CAAC,IAAI,OAAO,KAAK,SAAS,IAAI,OAAO,GAAG,UAAU,EAAE,CAAC;QAChG,cAAc,GAAG,IAAI,CAAC;IACxB,CAAC;IAED,IAAI,aAAa,GAAG,KAAK,CAAC;IAC1B,IAAI,cAAc,KAAK,aAAa,IAAI,IAAI,CAAC,eAAe,EAAE,CAAC;QAC7D,MAAM,KAAK,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;QAC7C,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;YAC5B,MAAM,SAAS,GAAG,aAAa,CAAC,OAAO,EAAE,GAAG,KAAK,CAAC,OAAO,EAAE,CAAC;YAC5D,MAAM,YAAY,GAAG,SAAS,GAAG,CAAC,IAAI,GAAG,EAAE,GAAG,EAAE,CAAC,CAAC;YAClD,IAAI,UAAU,KAAK,SAAS,IAAI,UAAU,GAAG,CAAC,IAAI,YAAY,GAAG,UAAU,EAAE,CAAC;gBAC5E,aAAa,GAAG,IAAI,CAAC;YACvB,CAAC;iBAAM,IAAI,UAAU,KAAK,SAAS,IAAI,UAAU,GAAG,CAAC,IAAI,CAAC,SAAS,GAAG,CAAC,IAAI,GAAG,EAAE,CAAC,CAAC,GAAG,UAAU,EAAE,CAAC;gBAChG,aAAa,GAAG,IAAI,CAAC;YACvB,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO;QACL,cAAc;QACd,OAAO;QACP,SAAS;QACT,eAAe;QACf,SAAS;QACT,UAAU;QACV,WAAW;QACX,YAAY;QACZ,SAAS;QACT,cAAc;QACd,aAAa;QACb,MAAM;QACN,QAAQ;QACR,WAAW;KACZ,CAAC;AACJ,CAAC"}
+{"version":3,"file":"status.js","sourceRoot":"","sources":["../../src/utils/status.ts"],"names":[],"mappings":"AAQA,MAAM,CAAC,MAAM,0BAA0B,GAAqC;IAC1E,OAAO,EAAE,EAAE,GAAG,EAAE,SAAS,EAAE,KAAK,EAAE,SAAS,EAAE,QAAQ,EAAE,aAAa,EAAE;IACtE,IAAI,EAAE,EAAE,GAAG,EAAE,MAAM,EAAE,KAAK,EAAE,OAAO,EAAE,QAAQ,EAAE,aAAa,EAAE;IAC9D,WAAW,EAAE,EAAE,GAAG,EAAE,aAAa,EAAE,KAAK,EAAE,aAAa,EAAE,QAAQ,EAAE,aAAa,EAAE;IAClF,SAAS,EAAE,EAAE,GAAG,EAAE,WAAW,EAAE,KAAK,EAAE,WAAW,EAAE,QAAQ,EAAE,aAAa,EAAE;IAC5E,IAAI,EAAE,EAAE,GAAG,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,QAAQ,EAAE,WAAW,EAAE;IAC3D,QAAQ,EAAE,EAAE,GAAG,EAAE,UAAU,EAAE,KAAK,EAAE,UAAU,EAAE,QAAQ,EAAE,UAAU,EAAE;CACvE,CAAC;AASF,MAAM,UAAU,uBAAuB,CACrC,SAAiB,EACjB,iBAAsC;IAEtC,IAAI,iBAAiB,EAAE,CAAC;QACtB,MAAM,KAAK,GAAG,iBAAiB,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,GAAG,KAAK,SAAS,CAAC,CAAC;QACrE,IAAI,KAAK;YAAE,OAAO,KAAK,CAAC;IAC1B,CAAC;IACD,IAAI,0BAA0B,CAAC,SAAS,CAAC,EAAE,CAAC;QAC1C,OAAO,0BAA0B,CAAC,SAAS,CAAC,CAAC;IAC/C,CAAC;IAED,kDAAkD;IAClD,MAAM,KAAK,GAAG,SAAS,CAAC,WAAW,EAAE,CAAC;IACtC,IAAI,QAAQ,GAAmB,aAAa,CAAC;IAC7C,IAAI,CAAC,UAAU,EAAE,WAAW,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,EAAE,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QACzG,QAAQ,GAAG,UAAU,CAAC;IACxB,CAAC;SAAM,IAAI,CAAC,MAAM,EAAE,WAAW,EAAE,UAAU,EAAE,QAAQ,EAAE,UAAU,EAAE,OAAO,EAAE,WAAW,EAAE,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QACnI,QAAQ,GAAG,WAAW,CAAC;IACzB,CAAC;SAAM,IAAI,CAAC,aAAa,EAAE,QAAQ,EAAE,SAAS,EAAE,WAAW,EAAE,QAAQ,EAAE,SAAS,EAAE,IAAI,EAAE,UAAU,EAAE,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QAC9I,QAAQ,GAAG,aAAa,CAAC;IAC3B,CAAC;IAED,OAAO;QACL,GAAG,EAAE,SAAS;QACd,KAAK,EAAE,SAAS;QAChB,QAAQ;KACT,CAAC;AACJ,CAAC;AAED,MAAM,UAAU,wBAAwB,CACtC,IAAU,EACV,0BAA4E,EAC5E,mBAA0B;IAE1B,IAAI,iBAAiD,CAAC;IACtD,IAAI,aAAa,GAAG,mBAAmB,IAAI,IAAI,IAAI,EAAE,CAAC;IACtD,IAAI,aAAa,GAAW,EAAE,CAAC;IAC/B,IAAI,oBAAoB,GAAG,CAAC,CAAC;IAE7B,IAAI,KAAK,CAAC,OAAO,CAAC,0BAA0B,CAAC,EAAE,CAAC;QAC9C,iBAAiB,GAAG,0BAA0B,CAAC;IACjD,CAAC;SAAM,IAAI,0BAA0B,EAAE,CAAC;QACtC,iBAAiB,GAAG,0BAA0B,CAAC,iBAAiB,CAAC;QACjE,IAAI,0BAA0B,CAAC,aAAa,EAAE,CAAC;YAC7C,aAAa,GAAG,0BAA0B,CAAC,aAAa,CAAC;QAC3D,CAAC;QACD,IAAI,0BAA0B,CAAC,aAAa,EAAE,CAAC;YAC7C,aAAa,GAAG,0BAA0B,CAAC,aAAa,CAAC;QAC3D,CAAC;QACD,IAAI,0BAA0B,CAAC,oBAAoB,KAAK,SAAS,EAAE,CAAC;YAClE,oBAAoB,GAAG,0BAA0B,CAAC,oBAAoB,CAAC;QACzE,CAAC;IACH,CAAC;IAED,MAAM,GAAG,GAAG,uBAAuB,CAAC,IAAI,CAAC,MAAM,EAAE,iBAAiB,CAAC,CAAC;IACpE,MAAM,cAAc,GAAmB,GAAG,CAAC,QAAQ,CAAC;IACpD,MAAM,MAAM,GAAG,cAAc,KAAK,WAAW,IAAI,cAAc,KAAK,UAAU,CAAC;IAC/E,MAAM,QAAQ,GAAG,cAAc,KAAK,aAAa,CAAC;IAClD,MAAM,WAAW,GAAG,cAAc,KAAK,UAAU,CAAC;IAElD,+BAA+B;IAC/B,MAAM,aAAa,GAAG,aAAa,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE;QAC/C,MAAM,WAAW,GAAG,uBAAuB,CAAC,CAAC,CAAC,MAAM,EAAE,iBAAiB,CAAC,CAAC;QACzE,OAAO,WAAW,CAAC,QAAQ,KAAK,WAAW,CAAC;IAC9C,CAAC,CAAC,CAAC;IACH,MAAM,eAAe,GAAG,aAAa,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC;IACvD,MAAM,mBAAmB,GAAG,OAAO,CAAC,IAAI,CAAC,SAAS,KAAK,IAAI,CAAC,CAAC;IAC7D,MAAM,SAAS,GAAG,CAAC,MAAM,IAAI,CAAC,eAAe,CAAC,MAAM,GAAG,CAAC,IAAI,mBAAmB,CAAC,CAAC;IACjF,MAAM,OAAO,GAAG,cAAc,KAAK,aAAa,IAAI,CAAC,SAAS,CAAC;IAE/D,6BAA6B;IAC7B,IAAI,SAAS,GAAG,KAAK,CAAC;IACtB,IAAI,CAAC,MAAM,IAAI,IAAI,CAAC,OAAO,EAAE,CAAC;QAC5B,MAAM,GAAG,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACnC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,OAAO,EAAE,CAAC,IAAI,GAAG,GAAG,aAAa,EAAE,CAAC;YACjD,SAAS,GAAG,IAAI,CAAC;QACnB,CAAC;IACH,CAAC;IAED,IAAI,UAAU,GAAG,KAAK,CAAC;IACvB,IAAI,cAAc,KAAK,aAAa,IAAI,IAAI,CAAC,gBAAgB,EAAE,CAAC;QAC9D,MAAM,YAAY,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,gBAAgB,CAAC,CAAC;QACrD,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,OAAO,EAAE,CAAC,IAAI,YAAY,GAAG,aAAa,EAAE,CAAC;YACnE,UAAU,GAAG,IAAI,CAAC;QACpB,CAAC;IACH,CAAC;IAED,MAAM,WAAW,GAAG,cAAc,KAAK,aAAa,IAAI,CAAC,IAAI,CAAC,WAAW,IAAI,CAAC,IAAI,CAAC,gBAAgB,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC;IAErH,iCAAiC;IACjC,MAAM,WAAW,GAAG,OAAO,CAAC,IAAI,CAAC,UAAU,IAAI,CAAC,IAAI,CAAC,SAAS,IAAI,IAAI,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC;IAC9F,MAAM,YAAY,GAAG,CAAC,MAAM,IAAI,CAAC,WAAW,CAAC;IAE7C,IAAI,SAAS,GAAG,KAAK,CAAC;IACtB,IAAI,cAAc,KAAK,aAAa,EAAE,CAAC;QACrC,MAAM,YAAY,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;QACpH,IAAI,YAAY,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;YACnD,MAAM,WAAW,GAAG,oBAAoB,GAAG,EAAE,GAAG,EAAE,GAAG,EAAE,GAAG,IAAI,CAAC;YAC/D,IAAI,aAAa,CAAC,OAAO,EAAE,GAAG,YAAY,CAAC,OAAO,EAAE,GAAG,WAAW,EAAE,CAAC;gBACnE,SAAS,GAAG,IAAI,CAAC;YACnB,CAAC;QACH,CAAC;IACH,CAAC;IAED,+BAA+B;IAC/B,IAAI,cAAc,GAAG,KAAK,CAAC;IAC3B,MAAM,OAAO,GAAG,IAAI,CAAC,WAAW,IAAI,IAAI,CAAC,WAAW,CAAC;IACrD,MAAM,UAAU,GAAG,IAAI,CAAC,cAAc,CAAC;IACvC,IAAI,UAAU,KAAK,SAAS,IAAI,UAAU,GAAG,CAAC,IAAI,OAAO,KAAK,SAAS,IAAI,OAAO,GAAG,UAAU,EAAE,CAAC;QAChG,cAAc,GAAG,IAAI,CAAC;IACxB,CAAC;IACD,MAAM,OAAO,GAAG,IAAI,CAAC,qBAAqB,CAAC;IAC3C,MAAM,UAAU,GAAG,IAAI,CAAC,wBAAwB,CAAC;IACjD,IAAI,UAAU,KAAK,SAAS,IAAI,UAAU,GAAG,CAAC,IAAI,OAAO,KAAK,SAAS,IAAI,OAAO,GAAG,UAAU,EAAE,CAAC;QAChG,cAAc,GAAG,IAAI,CAAC;IACxB,CAAC;IAED,IAAI,aAAa,GAAG,KAAK,CAAC;IAC1B,IAAI,cAAc,KAAK,aAAa,IAAI,IAAI,CAAC,eAAe,EAAE,CAAC;QAC7D,MAAM,KAAK,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;QAC7C,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,OAAO,EAAE,CAAC,EAAE,CAAC;YAC5B,MAAM,SAAS,GAAG,aAAa,CAAC,OAAO,EAAE,GAAG,KAAK,CAAC,OAAO,EAAE,CAAC;YAC5D,MAAM,YAAY,GAAG,SAAS,GAAG,CAAC,IAAI,GAAG,EAAE,GAAG,EAAE,CAAC,CAAC;YAClD,IAAI,UAAU,KAAK,SAAS,IAAI,UAAU,GAAG,CAAC,IAAI,YAAY,GAAG,UAAU,EAAE,CAAC;gBAC5E,aAAa,GAAG,IAAI,CAAC;YACvB,CAAC;iBAAM,IAAI,UAAU,KAAK,SAAS,IAAI,UAAU,GAAG,CAAC,IAAI,CAAC,SAAS,GAAG,CAAC,IAAI,GAAG,EAAE,CAAC,CAAC,GAAG,UAAU,EAAE,CAAC;gBAChG,aAAa,GAAG,IAAI,CAAC;YACvB,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO;QACL,cAAc;QACd,OAAO;QACP,SAAS;QACT,eAAe;QACf,SAAS;QACT,UAAU;QACV,WAAW;QACX,YAAY;QACZ,SAAS;QACT,cAAc;QACd,aAAa;QACb,MAAM;QACN,QAAQ;QACR,WAAW;KACZ,CAAC;AACJ,CAAC;AAgBD;;GAEG;AACH,MAAM,UAAU,wBAAwB,CACtC,kBAA4D;IAE5D,IAAI,CAAC,kBAAkB;QAAE,OAAO,SAAS,CAAC;IAC1C,IAAI,KAAK,CAAC,OAAO,CAAC,kBAAkB,CAAC,EAAE,CAAC;QACtC,OAAO,kBAAwC,CAAC;IAClD,CAAC;IACD,IAAI,OAAO,kBAAkB,KAAK,QAAQ,IAAI,kBAAkB,KAAK,IAAI,EAAE,CAAC;QAC1E,MAAM,QAAQ,GAAI,kBAA0B,CAAC,QAAQ,CAAC;QACtD,IAAI,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,EAAE,CAAC;YAC5B,OAAO,QAA8B,CAAC;QACxC,CAAC;IACH,CAAC;IACD,OAAO,SAAS,CAAC;AACnB,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,WAAW,CAAC,IAAiC;IAC3D,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,OAAO,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;AAC/B,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,cAAc,CAAC,IAAiC;IAC9D,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,OAAO,CACL,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC;QACtB,OAAO,CAAC,IAAI,CAAC,UAAU,CAAC;QACxB,IAAI,CAAC,MAAM,KAAK,UAAU;QAC1B,OAAO,CAAE,IAAI,CAAC,YAAoB,EAAE,UAAU,CAAC,CAChD,CAAC;AACJ,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,aAAa,CAAC,IAAiC;IAC7D,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,OAAO,CACL,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC;QACrB,OAAO,CAAC,IAAI,CAAC,SAAS,CAAC;QACvB,IAAI,CAAC,MAAM,KAAK,SAAS;QACzB,OAAO,CAAE,IAAI,CAAC,YAAoB,EAAE,SAAS,CAAC,CAC/C,CAAC;AACJ,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,uBAAuB,CAAC,IAAiC;IACvE,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,OAAO,aAAa,CAAC,IAAI,CAAC,IAAI,cAAc,CAAC,IAAI,CAAC,CAAC;AACrD,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,cAAc,CAAC,IAAiC;IAC9D,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,OAAO,CAAC,aAAa,CAAC,IAAI,CAAC,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;AAC7E,CAAC;AAED,MAAM,CAAC,MAAM,WAAW,GAAG,WAAW,CAAC;AACvC,MAAM,CAAC,MAAM,cAAc,GAAG,cAAc,CAAC;AAC7C,MAAM,CAAC,MAAM,aAAa,GAAG,aAAa,CAAC;AAC3C,MAAM,CAAC,MAAM,uBAAuB,GAAG,uBAAuB,CAAC;AAC/D,MAAM,CAAC,MAAM,cAAc,GAAG,cAAc,CAAC;AAE7C;;GAEG;AACH,MAAM,UAAU,qBAAqB,CACnC,IAAiC,EACjC,kBAA4D;IAE5D,IAAI,CAAC,IAAI;QAAE,OAAO,aAAa,CAAC;IAEhC,MAAM,UAAU,GAAG,wBAAwB,CAAC,kBAAkB,CAAC,CAAC;IAEhE,8DAA8D;IAC9D,IAAI,IAAI,CAAC,MAAM,EAAE,CAAC;QAChB,IAAI,UAAU,EAAE,CAAC;YACf,MAAM,KAAK,GAAG,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,GAAG,KAAK,IAAI,CAAC,MAAM,CAAC,CAAC;YAC5D,IAAI,KAAK,EAAE,QAAQ;gBAAE,OAAO,KAAK,CAAC,QAAQ,CAAC;YAC3C,IAAI,KAAK,EAAE,CAAC;gBACV,IAAK,KAAa,CAAC,eAAe,KAAK,MAAM,EAAE,CAAC;oBAC9C,OAAQ,KAAa,CAAC,WAAW,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,WAAW,CAAC;gBAC/D,CAAC;gBACD,IAAK,KAAa,CAAC,cAAc,KAAK,QAAQ,EAAE,CAAC;oBAC/C,OAAO,aAAa,CAAC;gBACvB,CAAC;gBACD,IAAK,KAAa,CAAC,eAAe,KAAK,UAAU,EAAE,CAAC;oBAClD,OAAO,aAAa,CAAC;gBACvB,CAAC;YACH,CAAC;QACH,CAAC;QAED,qFAAqF;QACrF,MAAM,aAAa,GAAG,IAAI,CAAC,MAAM,CAAC,WAAW,EAAE,CAAC,OAAO,CAAC,SAAS,EAAE,GAAG,CAAC,CAAC;QACxE,MAAM,UAAU,GACd,0BAA0B,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,0BAA0B,CAAC,aAAa,CAAC,CAAC;QACvF,IAAI,UAAU,EAAE,QAAQ,EAAE,CAAC;YACzB,OAAO,UAAU,CAAC,QAAQ,CAAC;QAC7B,CAAC;IACH,CAAC;IAED,sFAAsF;IACtF,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;QACxB,MAAM,GAAG,GAAG,MAAM,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC,WAAW,EAAE,CAAC;QACtD,IACE,GAAG,KAAK,WAAW;YACnB,GAAG,KAAK,aAAa;YACrB,GAAG,KAAK,aAAa;YACrB,GAAG,KAAK,UAAU;YAClB,GAAG,KAAK,WAAW,EACnB,CAAC;YACD,OAAO,GAAG,KAAK,WAAW,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAE,GAAsB,CAAC;QACpE,CAAC;IACH,CAAC;IAED,+EAA+E;IAC/E,IAAI,IAAI,CAAC,MAAM,EAAE,CAAC;QAChB,MAAM,GAAG,GAAG,uBAAuB,CAAC,IAAI,CAAC,MAAM,EAAE,UAAU,CAAC,CAAC;QAC7D,IAAI,GAAG,EAAE,QAAQ,EAAE,CAAC;YAClB,OAAO,GAAG,CAAC,QAAQ,CAAC;QACtB,CAAC;IACH,CAAC;IAED,OAAO,aAAa,CAAC;AACvB,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,eAAe,CAC7B,IAAiC,EACjC,kBAA4D;IAE5D,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,OAAO,qBAAqB,CAAC,IAAI,EAAE,kBAAkB,CAAC,KAAK,WAAW,CAAC;AACzE,CAAC;AAED,MAAM,CAAC,MAAM,UAAU,GAAG,eAAe,CAAC;AAE1C;;GAEG;AACH,MAAM,UAAU,gBAAgB,CAC9B,IAAiC,EACjC,kBAA4D;IAE5D,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,OAAO,qBAAqB,CAAC,IAAI,EAAE,kBAAkB,CAAC,KAAK,aAAa,CAAC;AAC3E,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,gBAAgB,CAC9B,IAAiC,EACjC,kBAA4D;IAE5D,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,OAAO,qBAAqB,CAAC,IAAI,EAAE,kBAAkB,CAAC,KAAK,aAAa,CAAC;AAC3E,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,cAAc,CAC5B,IAAiC,EACjC,kBAA4D;IAE5D,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,OAAO,qBAAqB,CAAC,IAAI,EAAE,kBAAkB,CAAC,KAAK,UAAU,CAAC;AACxE,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,YAAY,CAC1B,IAAiC,EACjC,kBAA4D;IAE5D,IAAI,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IACxB,IAAI,uBAAuB,CAAC,IAAI,CAAC;QAAE,OAAO,KAAK,CAAC;IAChD,IAAI,WAAW,CAAC,IAAI,CAAC;QAAE,OAAO,KAAK,CAAC;IACpC,MAAM,GAAG,GAAG,qBAAqB,CAAC,IAAI,EAAE,kBAAkB,CAAC,CAAC;IAC5D,OAAO,GAAG,KAAK,WAAW,IAAI,GAAG,KAAK,UAAU,CAAC;AACnD,CAAC;AAED;;GAEG;AACH,MAAM,UAAU,gBAAgB,CAAC,IAAiC;IAChE,IAAI,CAAC,IAAI;QAAE,OAAO,IAAI,CAAC;IAEvB,MAAM,KAAK,GAAG,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;IACpE,MAAM,aAAa,GAAG,KAAK,KAAK,EAAE,IAAI,KAAK,CAAC,WAAW,EAAE,KAAK,YAAY,CAAC;IAE3E,MAAM,iBAAiB,GACrB,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,SAAS,CAAC;QAC7B,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,CAAM,EAAE,EAAE;YAC7B,IAAI,CAAC,CAAC;gBAAE,OAAO,KAAK,CAAC;YACrB,IAAI,OAAO,CAAC,KAAK,QAAQ,EAAE,CAAC;gBAC1B,MAAM,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,CAAC;gBACnB,OAAO,CAAC,KAAK,EAAE,IAAI,CAAC,CAAC,WAAW,EAAE,KAAK,YAAY,CAAC;YACtD,CAAC;YACD,MAAM,EAAE,GAAG,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;YAC3C,MAAM,IAAI,GAAG,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;YACjD,OAAO,CACL,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,WAAW,EAAE,KAAK,YAAY,CAAC;gBAChD,CAAC,IAAI,KAAK,EAAE,IAAI,IAAI,CAAC,WAAW,EAAE,KAAK,YAAY,CAAC,CACrD,CAAC;QACJ,CAAC,CAAC,CAAC;IAEL,OAAO,CAAC,aAAa,IAAI,CAAC,iBAAiB,CAAC;AAC9C,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@critical-path/core",
-  "version": "0.20.2",
+  "version": "0.22.0",
   "description": "Core headless domain engine, plugin architecture, and data stores for Critical Path",
   "author": "Jack James",
   "license": "MIT",
@@ -18,7 +18,6 @@
     }
   },
   "devDependencies": {
-    "@types/better-sqlite3": "^9.6.0",
     "@types/node": "^24.0.0",
     "typescript": "^5.7.0",
     "vitest": "^3.0.0"
@@ -26,9 +25,6 @@
   "engines": {
     "node": ">=24.0.0"
   },
-  "dependencies": {
-    "better-sqlite3": "^13.0.3"
-  },
   "scripts": {
     "build": "tsc --build",
     "test": "vitest run",

package/src/domain/ddd.test.ts

@@ -250,6 +250,28 @@ describe('Domain-Driven Design (DDD) Enhancements Suite', () => {
         })
       ).rejects.toThrow(CircularDependencyError);
     });
+
+    it('detects cycles longer than the immediate neighbours in engine.addDependency', async () => {
+      const engine = new CriticalPathEngine();
+      const project = await engine.createProject({ name: 'Long Cycle' });
+      const [a, b, c, d] = await Promise.all(
+        ['A', 'B', 'C', 'D'].map((title) => engine.createTask({ projectId: project.id, title }))
+      );
+
+      await engine.addDependency({ taskId: a.id, dependsOnTaskId: b.id, type: 'blocking' });
+      await engine.addDependency({ taskId: b.id, dependsOnTaskId: c.id, type: 'blocking' });
+      await engine.addDependency({ taskId: c.id, dependsOnTaskId: d.id, type: 'blocking' });
+
+      // D -> A closes A -> B -> C -> D -> A
+      await expect(
+        engine.addDependency({ taskId: d.id, dependsOnTaskId: a.id, type: 'blocking' })
+      ).rejects.toThrow(CircularDependencyError);
+
+      // A diamond is not a cycle: A -> D is fine because D does not reach A
+      await expect(
+        engine.addDependency({ taskId: a.id, dependsOnTaskId: d.id, type: 'blocking' })
+      ).resolves.toMatchObject({ taskId: a.id, dependsOnTaskId: d.id });
+    });
   });
 
   describe('Rich Domain Aggregates (TaskEntity & ProjectEntity)', () => {

package/src/domain/entities.ts

@@ -29,6 +29,7 @@ import { validateTransition, WorkflowValidationError } from '../utils/workflow.j
 import { resolveStatusDefinition } from '../utils/status.js';
 import { validateCustomFieldValues } from './custom-fields.js';
 import { generateProjectKey } from '../utils/key.js';
+import { ValidationError } from './errors.js';
 
 export abstract class BaseEntity {
   public readonly id: string;
@@ -294,8 +295,8 @@ export class TaskEntity extends BaseEntity {
   public logTime(
     entry: { hours: number; isBillable?: boolean; userId?: string; description?: string }
   ): TimeEntry {
-    if (entry.hours <= 0) {
-      throw new Error('Logged hours must be a positive number.');
+    if (!Number.isFinite(entry.hours) || entry.hours <= 0) {
+      throw new ValidationError('Logged hours must be a positive number.');
     }
 
     this.loggedHours = (this.loggedHours || 0) + entry.hours;

package/src/domain/errors.ts

@@ -0,0 +1,19 @@
+/**
+ * Thrown when input fails a domain rule. Route handlers map it to HTTP 400.
+ */
+export class ValidationError extends Error {
+  constructor(message: string) {
+    super(message);
+    this.name = 'ValidationError';
+  }
+}
+
+/**
+ * Thrown when a referenced entity does not exist. Route handlers map it to HTTP 404.
+ */
+export class NotFoundError extends Error {
+  constructor(message: string) {
+    super(message);
+    this.name = 'NotFoundError';
+  }
+}

package/src/domain/events.ts

@@ -134,6 +134,11 @@ export interface ProjectUpdatedEvent extends DomainEvent<{ project: Project; pre
   readonly aggregateType: 'Project';
 }
 
+export interface ProjectDeletedEvent extends DomainEvent<{ projectId: string; name: string; deletedTaskIds: string[] }> {
+  readonly name: 'project.deleted';
+  readonly aggregateType: 'Project';
+}
+
 export interface WorkflowCreatedEvent extends DomainEvent<{ workflow: Workflow }> {
   readonly name: 'workflow.created';
   readonly aggregateType: 'Workflow';
@@ -207,6 +212,7 @@ export type CriticalPathDomainEvent =
   | TaskDependencyAddedEvent
   | ProjectCreatedEvent
   | ProjectUpdatedEvent
+  | ProjectDeletedEvent
   | WorkflowCreatedEvent
   | WorkflowUpdatedEvent
   | WorkflowDeletedEvent

package/src/domain/index.ts

@@ -1,6 +1,7 @@
 export * from './events.js';
 export * from './custom-fields.js';
 export * from './graph.js';
+export * from './errors.js';
 export * from './entities.js';
 export * from './cpm.js';
 export * from './ladder.js';

package/src/domain/task-duration.test.ts

@@ -315,4 +315,40 @@ describe('Task Execution Timestamps & Cumulative In-Progress Duration', () => {
       vi.useRealTimers();
     }
   });
+
+  it('sets completedAt and actualEndDate on completion and resets progress when reopening', async () => {
+    vi.useFakeTimers();
+    try {
+      const store = new InMemoryStore();
+      const engine = new CriticalPathEngine({ store });
+
+      const project = await engine.createProject({ name: 'Progress Transition Proj' });
+      vi.setSystemTime(new Date('2026-10-01T10:00:00Z'));
+      const task = await engine.createTask({
+        projectId: project.id,
+        title: 'Task for completion test',
+        status: 'in_progress',
+        progress: 50
+      });
+
+      // Complete the task
+      vi.setSystemTime(new Date('2026-10-01T12:00:00Z'));
+      const completed = await engine.updateTask(task.id, { status: 'done' });
+      expect(completed?.status).toBe('done');
+      expect(completed?.actualEndDate).toBe('2026-10-01T12:00:00.000Z');
+      expect(completed?.completedAt).toBe('2026-10-01T12:00:00.000Z');
+      expect(completed?.progress).toBe(100);
+
+      // Reopen to todo -> actualEndDate & completedAt cleared, progress reset from 100 to 0
+      vi.setSystemTime(new Date('2026-10-01T13:00:00Z'));
+      const reopened = await engine.updateTask(task.id, { status: 'todo' });
+      expect(reopened?.status).toBe('todo');
+      expect(reopened?.actualEndDate).toBeUndefined();
+      expect(reopened?.completedAt).toBeUndefined();
+      expect(reopened?.progress).toBe(0);
+    } finally {
+      vi.useRealTimers();
+    }
+  });
 });
+

package/src/engine/index.ts

@@ -56,6 +56,7 @@ import {
   TaskDeletedEvent,
   ProjectCreatedEvent,
   ProjectUpdatedEvent,
+  ProjectDeletedEvent,
   WorkflowCreatedEvent,
   WorkflowUpdatedEvent,
   WorkflowDeletedEvent,
@@ -80,6 +81,7 @@ import {
 import { validateAttachmentUrl, AttachmentValidationError } from '../domain/entities.js';
 import { validateCustomFieldValues } from '../domain/custom-fields.js';
 import { detectDependencyCycle, CircularDependencyError } from '../domain/graph.js';
+import { ValidationError, NotFoundError } from '../domain/errors.js';
 import { calculateCPM, type CPMOptions } from '../domain/cpm.js';
 import { buildTimelineLadder, aggregateConcreteEvidenceForTask } from '../domain/ladder.js';
 import {
@@ -340,6 +342,46 @@ export class CriticalPathEngine {
     return updated;
   }
 
+  /**
+   * Deletes a project and its tasks. Each task goes through `deleteTask`, so plugin
+   * hooks run and `task.deleted` events fire before `project.deleted` is published.
+   */
+  async deleteProject(id: string): Promise<boolean> {
+    const existing = await this.store.getProject(id);
+    if (!existing) return false;
+
+    const tasks = await this.store.getTasks(id);
+    const deletedTaskIds: string[] = [];
+    for (const task of tasks) {
+      if (await this.deleteTask(task.id)) {
+        deletedTaskIds.push(task.id);
+      }
+    }
+
+    const deleted = await this.store.deleteProject(id);
+    if (deleted) {
+      const now = new Date().toISOString();
+      const event: ProjectDeletedEvent = {
+        id: `evt_${Math.random().toString(36).substring(2, 9)}`,
+        name: 'project.deleted',
+        aggregateId: id,
+        aggregateType: 'Project',
+        occurredAt: now,
+        payload: { projectId: id, name: existing.name, deletedTaskIds }
+      };
+      await this.events.publish(event);
+
+      await this.store.logActivity({
+        projectId: id,
+        actorId: 'system',
+        action: 'project.deleted',
+        details: { name: existing.name, deletedTaskCount: deletedTaskIds.length }
+      });
+      this.dispatchWebhook('project.deleted', { projectId: id, name: existing.name, deletedTaskIds });
+    }
+    return deleted;
+  }
+
   // --- Tasks ---
   async getTasks(projectId?: string): Promise<Task[]> {
     return this.store.getTasks(projectId);
@@ -373,6 +415,7 @@ export class CriticalPathEngine {
     const actualStartDate = processedInput.actualStartDate ?? taskInput.actualStartDate ?? (statusDef.category === 'in_progress' ? now : undefined);
     const inProgressSince = processedInput.inProgressSince ?? taskInput.inProgressSince ?? (statusDef.category === 'in_progress' ? now : undefined);
     const actualEndDate = processedInput.actualEndDate ?? taskInput.actualEndDate ?? ((statusDef.category === 'completed' || statusDef.category === 'canceled') ? now : undefined);
+    const completedAt = processedInput.completedAt ?? taskInput.completedAt ?? (statusDef.category === 'completed' ? now : undefined);
 
     const isInitialBlocked = processedInput.isBlocked ?? taskInput.isBlocked ?? false;
     const blockedSince = processedInput.blockedSince ?? taskInput.blockedSince ?? (isInitialBlocked && statusDef.category === 'in_progress' ? now : undefined);
@@ -397,6 +440,7 @@ export class CriticalPathEngine {
       plannedStartDate: processedInput.plannedStartDate ?? taskInput.plannedStartDate,
       actualStartDate,
       actualEndDate,
+      completedAt,
       dueDate: processedInput.dueDate ?? taskInput.dueDate,
       estimatedHours: processedInput.estimatedHours ?? taskInput.estimatedHours,
       loggedHours: processedInput.loggedHours ?? taskInput.loggedHours ?? 0,
@@ -577,26 +621,54 @@ export class CriticalPathEngine {
         if (isTaskBlocked && !processedUpdates.blockedSince) {
           processedUpdates.blockedSince = now;
         }
+        // Moving from completed/canceled to in_progress resets completion timestamp and progress
         if (
-          (existingStatusDef.category === 'completed' || existingStatusDef.category === 'canceled') &&
-          processedUpdates.actualEndDate === undefined
+          existingStatusDef.category === 'completed' || existingStatusDef.category === 'canceled'
         ) {
-          processedUpdates.actualEndDate = undefined;
+          if (processedUpdates.actualEndDate === undefined) {
+            processedUpdates.actualEndDate = undefined;
+          }
+          if (processedUpdates.completedAt === undefined) {
+            processedUpdates.completedAt = undefined;
+          }
+          if (existing.progress === 100 && processedUpdates.progress === undefined) {
+            processedUpdates.progress = 0;
+          }
         }
       } else if (
         (existingStatusDef.category === 'completed' || existingStatusDef.category === 'canceled') &&
-        newStatusDef.category === 'not_started' &&
-        processedUpdates.actualEndDate === undefined
+        newStatusDef.category === 'not_started'
       ) {
-        processedUpdates.actualEndDate = undefined;
+        // Moving from completed/canceled to not_started resets completion timestamp and progress
+        if (processedUpdates.actualEndDate === undefined) {
+          processedUpdates.actualEndDate = undefined;
+        }
+        if (processedUpdates.completedAt === undefined) {
+          processedUpdates.completedAt = undefined;
+        }
+        if (existing.progress === 100 && processedUpdates.progress === undefined) {
+          processedUpdates.progress = 0;
+        }
       }
 
       // 3. Entering completed or canceled
-      if ((newStatusDef.category === 'completed' || newStatusDef.category === 'canceled') && !processedUpdates.actualEndDate) {
-        processedUpdates.actualEndDate = now;
-        if (newStatusDef.category === 'completed' && processedUpdates.progress === undefined && (existing.progress || 0) < 100) {
+      if (newStatusDef.category === 'completed') {
+        if (!processedUpdates.actualEndDate) {
+          processedUpdates.actualEndDate = now;
+        }
+        if (!processedUpdates.completedAt) {
+          processedUpdates.completedAt = now;
+        }
+        if (processedUpdates.progress === undefined && (existing.progress || 0) < 100) {
           processedUpdates.progress = 100;
         }
+      } else if (newStatusDef.category === 'canceled') {
+        if (!processedUpdates.actualEndDate) {
+          processedUpdates.actualEndDate = now;
+        }
+        if (processedUpdates.completedAt === undefined) {
+          processedUpdates.completedAt = undefined;
+        }
       }
     }
 
@@ -886,14 +958,9 @@ export class CriticalPathEngine {
 
   // --- Task Dependencies & Graph ---
   async addDependency(dep: Omit<TaskDependency, 'id'>): Promise<TaskDependency> {
-    const existingDependencies = await this.store.getDependencies(dep.taskId);
-    const allProjectDeps = [
-      ...existingDependencies,
-      ...(await this.store.getDependencies(dep.dependsOnTaskId))
-    ];
-
     // Enforce Directed Acyclic Graph (DAG) Invariant
-    const cycleCheck = detectDependencyCycle(allProjectDeps, dep);
+    const reachableDeps = await this.collectUpstreamDependencies(dep.dependsOnTaskId);
+    const cycleCheck = detectDependencyCycle(reachableDeps, dep);
     if (cycleCheck.hasCycle) {
       throw new CircularDependencyError(dep.taskId, dep.dependsOnTaskId, cycleCheck.cyclePath);
     }
@@ -914,6 +981,37 @@ export class CriticalPathEngine {
     return created;
   }
 
+  /**
+   * Collects every dependency edge reachable upstream from `startTaskId`. A new edge
+   * `taskId -> dependsOnTaskId` creates a cycle exactly when `taskId` is reachable from
+   * `dependsOnTaskId`, so this is the full set of edges the cycle check needs.
+   */
+  private async collectUpstreamDependencies(startTaskId: string): Promise<TaskDependency[]> {
+    const edges = new Map<string, TaskDependency>();
+    const visited = new Set<string>();
+    let frontier = [startTaskId];
+
+    while (frontier.length > 0) {
+      const next: string[] = [];
+      const results = await Promise.all(frontier.map((id) => this.store.getDependencies(id)));
+      frontier.forEach((id) => visited.add(id));
+
+      for (const deps of results) {
+        for (const d of deps) {
+          // getDependencies returns edges in both directions; follow only outgoing ones.
+          if (!visited.has(d.taskId)) continue;
+          edges.set(d.id, d);
+          if (!visited.has(d.dependsOnTaskId) && !next.includes(d.dependsOnTaskId)) {
+            next.push(d.dependsOnTaskId);
+          }
+        }
+      }
+      frontier = next;
+    }
+
+    return Array.from(edges.values());
+  }
+
   async getTaskDependencyGraph(taskId: string): Promise<TaskDependencyGraph> {
     const dependencies = await this.store.getDependencies(taskId);
     const upstreamTaskIds = new Set<string>();
@@ -966,8 +1064,8 @@ export class CriticalPathEngine {
 
   // --- Time Tracking ---
   async logTime(entry: Omit<TimeEntry, 'id' | 'loggedAt' | 'userId'> & { userId?: string; loggedAt?: string }): Promise<TimeEntry> {
-    if (entry.hours <= 0) {
-      throw new Error('Logged hours must be a positive number.');
+    if (!Number.isFinite(entry.hours) || entry.hours <= 0) {
+      throw new ValidationError('Logged hours must be a positive number.');
     }
 
     const task = await this.store.getTask(entry.taskId);
@@ -1258,7 +1356,7 @@ export class CriticalPathEngine {
   async readAttachmentText(id: string): Promise<string> {
     const attachment = await this.getAttachment(id);
     if (!attachment) {
-      throw new Error(`Attachment with id "${id}" not found.`);
+      throw new NotFoundError(`Attachment with id "${id}" not found.`);
     }
 
     if (attachment.storageKey && this.fileStorage && typeof this.fileStorage.download === 'function') {
@@ -1631,7 +1729,7 @@ export class CriticalPathEngine {
   ): Promise<TimelineLadder> {
     const project = await this.store.getProject(projectId);
     if (!project) {
-      throw new Error(`Project with ID "${projectId}" not found.`);
+      throw new NotFoundError(`Project with ID "${projectId}" not found.`);
     }
 
     let tasks = await this.store.getTasks(projectId);

package/src/index.test.ts

@@ -3,6 +3,30 @@ import { CriticalPathEngine, deriveTaskLifecycleState, DEFAULT_VFX_WORKFLOW } fr
 import type { CriticalPathPlugin } from './types/index.js';
 
 describe('CriticalPathEngine Core Tests', () => {
+  it('deletes a project with its tasks and publishes deletion events', async () => {
+    const engine = new CriticalPathEngine();
+    const proj = await engine.createProject({ key: 'DEL', name: 'Doomed Project' });
+    const keep = await engine.createProject({ key: 'KEEP', name: 'Survivor' });
+    const t1 = await engine.createTask({ projectId: proj.id, title: 'One' });
+    const t2 = await engine.createTask({ projectId: proj.id, title: 'Two' });
+    const other = await engine.createTask({ projectId: keep.id, title: 'Other' });
+
+    const published: string[] = [];
+    engine.events.subscribe('*', (event) => {
+      published.push(event.name);
+    });
+
+    expect(await engine.deleteProject(proj.id)).toBe(true);
+    expect(await engine.getProject(proj.id)).toBeNull();
+    expect(await engine.getTask(t1.id)).toBeNull();
+    expect(await engine.getTask(t2.id)).toBeNull();
+    expect(await engine.getTask(other.id)).not.toBeNull();
+    expect(published.filter((n) => n === 'task.deleted')).toHaveLength(2);
+    expect(published.at(-1)).toBe('project.deleted');
+
+    expect(await engine.deleteProject(proj.id)).toBe(false);
+  });
+
   it('creates projects and tasks with activity logs', async () => {
     const engine = new CriticalPathEngine();