@crewx/shared 0.0.6-rc.22 → 0.0.6-rc.24

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@crewx/shared",
-  "version": "0.0.6-rc.22",
+  "version": "0.0.6-rc.24",
   "main": "skill-tracer.js",
   "exports": {
     ".": {
@@ -28,7 +28,7 @@
   },
   "description": "Shared utilities for CrewX built-in packages",
   "dependencies": {
-    "@crewx/sdk": "0.9.0-rc.107"
+    "@crewx/sdk": "0.9.0-rc.109"
   },
   "devDependencies": {
     "@types/node": "^20.0.0",

package/skill-tracer.js

@@ -24,9 +24,7 @@ const { generateId } = require('@crewx/sdk');
  * crewx.db 경로 찾기
  */
 function getDbPath() {
-  if (process.env.CREWX_TRACES_DB || process.env.CREWX_DB) {
-    return process.env.CREWX_TRACES_DB || process.env.CREWX_DB;
-  }
+  if (process.env.CREWX_DB) return process.env.CREWX_DB;
 
   return path.join(os.homedir(), '.crewx', 'crewx.db');
 }
@@ -35,141 +33,67 @@ function getDbPath() {
 const getTracesDbPath = getDbPath;
 
 /**
- * crewx.db 연결 및 테이블 확인
- * Returns null if better-sqlite3 is unavailable or DB cannot be opened.
+ * Open an already initialized crewx.db for trace writes.
+ * This function never creates a database, directory, or schema.
+ * Returns null if better-sqlite3 is unavailable, the database is missing, or
+ * the existing file does not contain the tracing tables used by this module.
  */
 function getDb() {
   if (!Database) return null;
 
   const dbPath = getDbPath();
-  const dir = path.dirname(dbPath);
-
-  if (!fs.existsSync(dir)) {
-    fs.mkdirSync(dir, { recursive: true });
-  }
+  if (!fs.existsSync(dbPath)) return null;
 
-  const db = new Database(dbPath);
-  db.exec('PRAGMA journal_mode = WAL');
-  db.exec('PRAGMA busy_timeout = 5000');
-  db.exec('PRAGMA foreign_keys = ON');
-
-  db.exec(`
-    CREATE TABLE IF NOT EXISTS tasks (
-      id TEXT PRIMARY KEY,
-      agent_id TEXT NOT NULL,
-      user_id TEXT,
-      prompt TEXT NOT NULL,
-      mode TEXT NOT NULL DEFAULT 'execute',
-      status TEXT NOT NULL DEFAULT 'running',
-      result TEXT,
-      error TEXT,
-      started_at TEXT NOT NULL,
-      completed_at TEXT,
-      duration_ms INTEGER,
-      metadata TEXT,
-      project_id TEXT,
-      project_name TEXT
-    )
-  `);
-
-  db.exec(`
-    CREATE TABLE IF NOT EXISTS spans (
-      id TEXT PRIMARY KEY,
-      task_id TEXT,
-      parent_span_id TEXT,
-      name TEXT NOT NULL,
-      kind TEXT NOT NULL DEFAULT 'internal',
-      status TEXT NOT NULL DEFAULT 'ok',
-      started_at TEXT NOT NULL,
-      completed_at TEXT,
-      duration_ms INTEGER,
-      input TEXT,
-      output TEXT,
-      error TEXT,
-      attributes TEXT,
-      FOREIGN KEY (task_id) REFERENCES tasks(id) ON DELETE SET NULL,
-      FOREIGN KEY (parent_span_id) REFERENCES spans(id) ON DELETE SET NULL
-    )
-  `);
-
-  ensureProjectColumns(db);
-  ensureSpansTaskIdNullable(db);
-
-  return db;
-}
-
-function ensureProjectColumns(db) {
+  let db;
   try {
-    const columns = db.prepare('PRAGMA table_info(tasks)').all().map((col) => col.name);
-    if (!columns.includes('project_id')) {
-      db.exec(`ALTER TABLE tasks ADD COLUMN project_id TEXT`);
-    }
-    if (!columns.includes('project_name')) {
-      db.exec(`ALTER TABLE tasks ADD COLUMN project_name TEXT`);
-    }
-    db.exec(`CREATE INDEX IF NOT EXISTS idx_tasks_project_id ON tasks(project_id)`);
-  } catch {
-    // Best-effort; ignore failures
-  }
-}
+    db = new Database(dbPath, { fileMustExist: true });
+    db.exec('PRAGMA journal_mode = WAL');
+    db.exec('PRAGMA busy_timeout = 5000');
+    db.exec('PRAGMA foreign_keys = ON');
 
-function ensureSpansTaskIdNullable(db) {
-  try {
-    const columns = db.prepare('PRAGMA table_info(spans)').all();
-    const taskIdColumn = columns.find((col) => col.name === 'task_id');
-    if (!taskIdColumn || taskIdColumn.notnull === 0) {
-      return;
+    if (!hasTraceSchema(db)) {
+      db.close();
+      return null;
     }
 
-    db.exec('PRAGMA foreign_keys = OFF');
-    db.exec('BEGIN');
-    db.exec(`
-      CREATE TABLE spans_backup (
-        id TEXT PRIMARY KEY,
-        task_id TEXT,
-        parent_span_id TEXT,
-        name TEXT NOT NULL,
-        kind TEXT NOT NULL DEFAULT 'internal',
-        status TEXT NOT NULL DEFAULT 'ok',
-        started_at TEXT NOT NULL,
-        completed_at TEXT,
-        duration_ms INTEGER,
-        input TEXT,
-        output TEXT,
-        error TEXT,
-        attributes TEXT,
-        FOREIGN KEY (task_id) REFERENCES tasks(id) ON DELETE SET NULL,
-        FOREIGN KEY (parent_span_id) REFERENCES spans_backup(id) ON DELETE SET NULL
-      )
-    `);
-    db.exec(`
-      INSERT INTO spans_backup (
-        id, task_id, parent_span_id, name, kind, status, started_at,
-        completed_at, duration_ms, input, output, error, attributes
-      )
-      SELECT
-        id, task_id, parent_span_id, name, kind, status, started_at,
-        completed_at, duration_ms, input, output, error, attributes
-      FROM spans
-    `);
-    db.exec('DROP TABLE spans');
-    db.exec('ALTER TABLE spans_backup RENAME TO spans');
-    db.exec('COMMIT');
-    db.exec('PRAGMA foreign_keys = ON');
-  } catch {
+    return db;
+  } catch (error) {
     try {
-      db.exec('ROLLBACK');
+      db?.close();
     } catch {
-      // Best-effort rollback
-    }
-    try {
-      db.exec('PRAGMA foreign_keys = ON');
-    } catch {
-      // Best-effort; ignore failures
+      // Best-effort cleanup after an open or pragma failure.
     }
+    throw error;
   }
 }
 
+function hasTraceSchema(db) {
+  const requiredColumns = {
+    tasks: ['id'],
+    spans: [
+      'id',
+      'task_id',
+      'name',
+      'kind',
+      'status',
+      'started_at',
+      'completed_at',
+      'duration_ms',
+      'input',
+      'output',
+      'error',
+      'attributes',
+    ],
+  };
+
+  return Object.entries(requiredColumns).every(([tableName, columns]) => {
+    const availableColumns = new Set(
+      db.prepare(`PRAGMA table_info(${tableName})`).all().map((column) => column.name),
+    );
+    return columns.every((column) => availableColumns.has(column));
+  });
+}
+
 function resolveProjectContext() {
   const projectPath = path.resolve(process.cwd());
   return {

package/tests/skill-tracer.test.ts

@@ -6,6 +6,36 @@ import Database from 'better-sqlite3';
 
 const SPAN_ID_PATTERN = /^spn_[A-Za-z0-9]{8}$/;
 
+function createTracerDb(dbPath: string): void {
+  fs.mkdirSync(path.dirname(dbPath), { recursive: true });
+  const db = new Database(dbPath);
+  db.exec(`
+    CREATE TABLE tasks (
+      id TEXT PRIMARY KEY,
+      agent_id TEXT,
+      prompt TEXT,
+      status TEXT,
+      started_at TEXT
+    );
+    CREATE TABLE spans (
+      id TEXT PRIMARY KEY,
+      task_id TEXT,
+      parent_span_id TEXT,
+      name TEXT NOT NULL,
+      kind TEXT NOT NULL DEFAULT 'internal',
+      status TEXT NOT NULL DEFAULT 'ok',
+      started_at TEXT NOT NULL,
+      completed_at TEXT,
+      duration_ms INTEGER,
+      input TEXT,
+      output TEXT,
+      error TEXT,
+      attributes TEXT
+    );
+  `);
+  db.close();
+}
+
 describe('shared/skill-tracer', () => {
   const sharedDir = path.resolve(__dirname, '..');
 
@@ -48,6 +78,7 @@ describe('shared/skill-tracer', () => {
 
     process.env.CREWX_DB = dbPath;
     delete process.env.CREWX_TASK_ID;
+    createTracerDb(dbPath);
 
     try {
       const trace = tracer.trace('memory', 'index core_sqa');
@@ -69,6 +100,39 @@ describe('shared/skill-tracer', () => {
       fs.rmSync(tempDir, { recursive: true, force: true });
     }
   });
+
+  it('does not create a missing target database and no-ops without throwing', () => {
+    const tracer = require(path.join(sharedDir, 'skill-tracer.js'));
+    const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'skill-tracer-missing-'));
+    const dbPath = path.join(tempDir, 'nested', 'crewx.db');
+    const previousDbPath = process.env.CREWX_DB;
+    const previousTaskId = process.env.CREWX_TASK_ID;
+
+    process.env.CREWX_DB = dbPath;
+    delete process.env.CREWX_TASK_ID;
+
+    try {
+      expect(() => {
+        const trace = tracer.trace('memory', 'index core_sqa');
+        expect(trace._skipped).toBe(true);
+        trace.ok('ignored');
+      }).not.toThrow();
+      expect(fs.existsSync(dbPath)).toBe(false);
+      expect(fs.existsSync(path.dirname(dbPath))).toBe(false);
+    } finally {
+      if (previousDbPath === undefined) {
+        delete process.env.CREWX_DB;
+      } else {
+        process.env.CREWX_DB = previousDbPath;
+      }
+      if (previousTaskId === undefined) {
+        delete process.env.CREWX_TASK_ID;
+      } else {
+        process.env.CREWX_TASK_ID = previousTaskId;
+      }
+      fs.rmSync(tempDir, { recursive: true, force: true });
+    }
+  });
 });
 
 describe('shared/skill-tracer output capture', () => {
@@ -85,6 +149,7 @@ describe('shared/skill-tracer output capture', () => {
     prevTaskId = process.env.CREWX_TASK_ID;
     process.env.CREWX_DB = dbPath;
     delete process.env.CREWX_TASK_ID;
+    createTracerDb(dbPath);
   });
 
   afterEach(() => {