@crewx/shared 0.0.4 → 0.0.6-rc.1

package/package.json

@@ -1,9 +1,12 @@
 {
   "name": "@crewx/shared",
-  "version": "0.0.4",
+  "version": "0.0.6-rc.1",
   "main": "skill-tracer.js",
   "description": "Shared utilities for CrewX built-in packages",
   "dependencies": {
-    "@crewx/sdk": "*"
+    "@crewx/sdk": "0.8.9-rc.14"
+  },
+  "scripts": {
+    "test": "echo no tests"
   }
-}
+}

package/test-tracer.js

@@ -1,5 +1,5 @@
 /**
- * skill-tracer 테스트
+ * skill-tracer test
  */
 
 const { trace, run, getDbPath } = require('./skill-tracer');
@@ -7,33 +7,33 @@ const { trace, run, getDbPath } = require('./skill-tracer');
 console.log('=== skill-tracer PoC Test ===\n');
 console.log('crewx.db path:', getDbPath());
 
-// 테스트 1: trace() 수동 사용
-console.log('\n[Test 1] trace() 수동 사용');
+// Test 1: manual trace() use
+console.log('\n[Test 1] manual trace() use');
 const t = trace('test-skill', 'manual test command', 'test-agent');
 console.log('taskId:', t.taskId);
 console.log('skipped:', t._skipped);
 t.ok('test result');
-console.log('-> 완료\n');
+console.log('-> done\n');
 
-// 테스트 2: run() 래퍼 사용 (성공)
-console.log('[Test 2] run() 래퍼 - 성공 케이스');
+// Test 2: run() wrapper success
+console.log('[Test 2] run() wrapper - success case');
 run('test-skill', async () => {
-  console.log('-> 함수 실행 중...');
+  console.log('-> function running...');
   return { status: 'success', data: 123 };
 }).then(() => {
-  console.log('-> 완료\n');
+  console.log('-> done\n');
 
-  // 테스트 3: run() 래퍼 사용 (실패)
-  console.log('[Test 3] run() 래퍼 - 실패 케이스');
+  // Test 3: run() wrapper failure
+  console.log('[Test 3] run() wrapper - failure case');
   return run('test-skill', async () => {
-    throw new Error('의도적 에러');
+    throw new Error('intentional error');
   }).catch(e => {
-    console.log('-> 에러 캡처됨:', e.message);
-    console.log('-> 완료\n');
+    console.log('-> error captured:', e.message);
+    console.log('-> done\n');
   });
 }).then(() => {
-  // 결과 확인
-  console.log('=== crewx.db 확인 ===');
+  // Verify results
+  console.log('=== crewx.db check ===');
   const Database = require('better-sqlite3');
   const db = new Database(getDbPath());
   const rows = db.prepare(`
@@ -44,11 +44,11 @@ run('test-skill', async () => {
     LIMIT 5
   `).all();
 
-  console.log('\n최근 test-skill 기록:');
+  console.log('\nRecent test-skill records:');
   rows.forEach(r => {
     console.log(`  [${r.status}] ${r.prompt.substring(0, 50)}... (${r.duration_ms}ms)`);
   });
 
   db.close();
-  console.log('\n=== 테스트 완료 ===');
+  console.log('\n=== test complete ===');
 });

package/tests/skill-tracer.test.ts

@@ -0,0 +1,159 @@
+import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import path from 'path';
+import fs from 'fs';
+import os from 'os';
+import Database from 'better-sqlite3';
+
+const SPAN_ID_PATTERN = /^spn_[A-Za-z0-9]{8}$/;
+
+describe('shared/skill-tracer', () => {
+  const sharedDir = path.resolve(__dirname, '..');
+
+  it('should be requireable from shared package', () => {
+    const tracer = require(path.join(sharedDir, 'skill-tracer.js'));
+    expect(tracer).toBeDefined();
+    expect(typeof tracer.trace).toBe('function');
+    expect(typeof tracer.run).toBe('function');
+    expect(typeof tracer.getDbPath).toBe('function');
+    expect(typeof tracer.getTracesDbPath).toBe('function');
+  });
+
+  it('should have package.json with correct name', () => {
+    const pkg = JSON.parse(fs.readFileSync(path.join(sharedDir, 'package.json'), 'utf-8'));
+    expect(pkg.name).toBe('@crewx/shared');
+    expect(pkg.main).toBe('skill-tracer.js');
+  });
+
+  it('re-export wrapper at skills/lib should work', () => {
+    const wrapperPath = path.resolve(__dirname, '../../../../skills/lib/skill-tracer.js');
+    const tracer = require(wrapperPath);
+    expect(tracer).toBeDefined();
+    expect(typeof tracer.trace).toBe('function');
+    expect(typeof tracer.run).toBe('function');
+  });
+
+  it('getDbPath should default to ~/.crewx/crewx.db', () => {
+    const tracer = require(path.join(sharedDir, 'skill-tracer.js'));
+    const dbPath = tracer.getDbPath();
+    expect(dbPath).toContain('.crewx');
+    expect(dbPath).toContain('crewx.db');
+  });
+
+  it('uses @crewx/sdk generateId from CJS when direct traces create spans', () => {
+    const tracer = require(path.join(sharedDir, 'skill-tracer.js'));
+    const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'skill-tracer-'));
+    const dbPath = path.join(tempDir, '.crewx', 'crewx.db');
+    const previousDbPath = process.env.CREWX_DB;
+    const previousTaskId = process.env.CREWX_TASK_ID;
+
+    process.env.CREWX_DB = dbPath;
+    delete process.env.CREWX_TASK_ID;
+
+    try {
+      const trace = tracer.trace('memory', 'index core_sqa');
+      expect(trace._skipped).toBe(false);
+      expect(trace.taskId).toBeNull();
+      expect(trace.spanId).toMatch(SPAN_ID_PATTERN);
+      trace.ok('done');
+    } finally {
+      if (previousDbPath === undefined) {
+        delete process.env.CREWX_DB;
+      } else {
+        process.env.CREWX_DB = previousDbPath;
+      }
+      if (previousTaskId === undefined) {
+        delete process.env.CREWX_TASK_ID;
+      } else {
+        process.env.CREWX_TASK_ID = previousTaskId;
+      }
+      fs.rmSync(tempDir, { recursive: true, force: true });
+    }
+  });
+});
+
+describe('shared/skill-tracer output capture', () => {
+  const sharedDir = path.resolve(__dirname, '..');
+  let tempDir: string;
+  let dbPath: string;
+  let prevDb: string | undefined;
+  let prevTaskId: string | undefined;
+
+  beforeEach(() => {
+    tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'tracer-output-'));
+    dbPath = path.join(tempDir, 'crewx.db');
+    prevDb = process.env.CREWX_DB;
+    prevTaskId = process.env.CREWX_TASK_ID;
+    process.env.CREWX_DB = dbPath;
+    delete process.env.CREWX_TASK_ID;
+  });
+
+  afterEach(() => {
+    if (prevDb === undefined) delete process.env.CREWX_DB;
+    else process.env.CREWX_DB = prevDb;
+    if (prevTaskId === undefined) delete process.env.CREWX_TASK_ID;
+    else process.env.CREWX_TASK_ID = prevTaskId;
+    fs.rmSync(tempDir, { recursive: true, force: true });
+  });
+
+  it('ok() captures output and stores in span', () => {
+    const tracer = require(path.join(sharedDir, 'skill-tracer.js'));
+    const t = tracer.trace('test', 'cmd');
+    t.ok('hello output');
+    const db = new Database(dbPath);
+    const row = db.prepare('SELECT output FROM spans ORDER BY started_at DESC LIMIT 1').get() as any;
+    db.close();
+    expect(row.output).toBe('hello output');
+  });
+
+  it('ok() truncates output > 32KB with head/tail pattern', () => {
+    const tracer = require(path.join(sharedDir, 'skill-tracer.js'));
+    const bigOutput = 'A'.repeat(40000);
+    const t = tracer.trace('test', 'cmd');
+    t.ok(bigOutput);
+    const db = new Database(dbPath);
+    const row = db.prepare('SELECT output, attributes FROM spans ORDER BY started_at DESC LIMIT 1').get() as any;
+    db.close();
+    const attrs = JSON.parse(row.attributes);
+    expect(attrs.output_truncated).toBe(true);
+    expect(attrs.output_bytes_original).toBe(40000);
+    expect(row.output).toContain('[omitted=');
+    expect(row.output.length).toBeLessThan(40000);
+  });
+
+  it('ok() captures stderr in attributes', () => {
+    const tracer = require(path.join(sharedDir, 'skill-tracer.js'));
+    const t = tracer.trace('test', 'cmd');
+    t.ok('main output', { stderr: 'some error output' });
+    const db = new Database(dbPath);
+    const row = db.prepare('SELECT output, attributes FROM spans ORDER BY started_at DESC LIMIT 1').get() as any;
+    db.close();
+    expect(row.output).toBe('main output');
+    const attrs = JSON.parse(row.attributes);
+    expect(attrs.stderr).toBe('some error output');
+  });
+
+  it('ok() truncates large stderr', () => {
+    const tracer = require(path.join(sharedDir, 'skill-tracer.js'));
+    const bigStderr = 'E'.repeat(40000);
+    const t = tracer.trace('test', 'cmd');
+    t.ok('output', { stderr: bigStderr });
+    const db = new Database(dbPath);
+    const row = db.prepare('SELECT attributes FROM spans ORDER BY started_at DESC LIMIT 1').get() as any;
+    db.close();
+    const attrs = JSON.parse(row.attributes);
+    expect(attrs.stderr_truncated).toBe(true);
+    expect(attrs.stderr_bytes_original).toBe(40000);
+    expect(attrs.stderr).toContain('[omitted=');
+  });
+
+  it('run() captures stdout when fn returns void', async () => {
+    const tracer = require(path.join(sharedDir, 'skill-tracer.js'));
+    await tracer.run('test-skill', async () => {
+      process.stdout.write('captured via run\n');
+    });
+    const db = new Database(dbPath);
+    const row = db.prepare('SELECT output FROM spans ORDER BY started_at DESC LIMIT 1').get() as any;
+    db.close();
+    expect(row.output).toBe('captured via run\n');
+  });
+});