@crewx/cli 0.9.0-rc.109 → 0.9.0-rc.110

package/dist/commands/detached.d.ts

@@ -6,7 +6,7 @@
  * trace context and are never repurposed as the runner assignment.
  */
 import { TaskRepository } from '@crewx/sdk/repository';
-import type { TaskActor } from '@crewx/sdk';
+import type { DurableTaskAdmission, TaskActor } from '@crewx/sdk';
 export type ReceiptActorKind = 'human' | 'agent' | 'system' | 'unknown';
 export interface ReceiptActor {
     kind: ReceiptActorKind;
@@ -20,6 +20,14 @@ export declare function resolveCliTaskActor(metadata: Record<string, unknown>, a
  * cron runners cannot diverge after root context is stripped.
  */
 export declare function resolveReceiptActor(metadata: Record<string, unknown>, agentId?: string | undefined): ReceiptActor;
+/**
+ * Report a blocked direct admission (WI-CTO-20260919-004 R2 finding #1) to
+ * the operator. Never called for an adopted (already pending) receipt — see
+ * admitDurableTask()'s own doc comment.
+ */
+export declare function reportAdmissionBlocked(admission: Extract<DurableTaskAdmission, {
+    ok: false;
+}>): void;
 /**
  * Remove receipt-selection flags, respecting the `--` literal-args sentinel.
  */

package/dist/commands/detached.js

@@ -9,6 +9,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.resolveCliTaskActor = resolveCliTaskActor;
 exports.resolveReceiptActor = resolveReceiptActor;
+exports.reportAdmissionBlocked = reportAdmissionBlocked;
 exports.extractReceiptFlags = extractReceiptFlags;
 exports.resolveReceiptMode = resolveReceiptMode;
 exports.adoptAssignedTask = adoptAssignedTask;
@@ -50,6 +51,14 @@ function resolveReceiptActor(metadata, agentId = process.env['CREWX_AGENT_ID'])
     const actor = resolveCliTaskActor(metadata, agentId);
     return { kind: actor.actorKind, id: actor.actorId };
 }
+/**
+ * Report a blocked direct admission (WI-CTO-20260919-004 R2 finding #1) to
+ * the operator. Never called for an adopted (already pending) receipt — see
+ * admitDurableTask()'s own doc comment.
+ */
+function reportAdmissionBlocked(admission) {
+    process.stderr.write(`${admission.message}\n`);
+}
 const DETACHED_RUNNER_POLL_INTERVAL_MS = 200;
 const DETACHED_RUNNER_ADOPTION_TIMEOUT_MS = 30_000;
 const DETACHED_VALUE_FLAGS = [
@@ -421,7 +430,18 @@ async function runDetached(command, filteredArgs, reason) {
         process.exit(2);
         return;
     }
-    const taskId = (0, sdk_1.generateId)('tsk');
+    // This process is a separate OS process from the embedded server and
+    // would otherwise never see a desktop update's admission gate at all
+    // (WI-CTO-20260919-004 R2 finding #1) — reserve-then-check before the
+    // pending receipt is written below, not after; see admitDurableTask()'s
+    // own doc comment for why that ordering closes the TOCTOU.
+    const admission = (0, sdk_1.admitDurableTask)(`direct-cli:${command}`);
+    if (!admission.ok) {
+        reportAdmissionBlocked(admission);
+        process.exit(1);
+        return;
+    }
+    const taskId = admission.taskId;
     const startedAt = new Date().toISOString();
     const workspacePath = process.cwd();
     const hasWorkspaceConfig = (0, fs_1.existsSync)((0, path_1.join)(workspacePath, 'crewx.yaml'))
@@ -455,10 +475,17 @@ async function runDetached(command, filteredArgs, reason) {
         });
     }
     catch (error) {
+        // The receipt's own pending row failed to persist — nothing durable was
+        // admitted, so the reservation's job is done regardless.
+        admission.release();
         process.stderr.write(`Failed to create detached task receipt: ${errorMessage(error)}\n`);
         process.exit(1);
         return;
     }
+    // The pending row above is now the durable, DB-visible signal of this
+    // work's admission — the reservation only ever existed to bridge the gap
+    // before it landed.
+    admission.release();
     const runnerArgs = buildDetachedRunnerArgs(filteredArgs, agentRef, finalMessage);
     const commandForRunner = runnerCommand(command);
     const logDir = (0, path_1.join)((0, os_1.homedir)(), '.crewx', 'logs');

package/dist/commands/execute.js

@@ -178,63 +178,86 @@ async function handleExecute(args, command = 'execute', emitState = (0, emit_tra
             taskActor = (0, detached_1.readAssignedTaskActor)(taskRepo, adoption.taskId);
         }
     }
+    // A synchronous `crewx x` runs in this same process, but this process is
+    // still separate from the embedded server and never sees its in-memory
+    // UpdateGateService (WI-CTO-20260919-004 R2 finding #1) — only the durable
+    // marker it writes. Reserve-then-check before calling into the SDK below,
+    // not after; see admitDurableTask()'s own doc comment. Never checked for
+    // an adopted receipt (selfTaskId set): that work was already admitted by
+    // whichever process first created its pending DB row.
+    let admission;
+    if (selfTaskId === undefined) {
+        admission = (0, sdk_1.admitDurableTask)(`direct-cli:${command}`);
+        if (!admission.ok) {
+            (0, detached_1.reportAdmissionBlocked)(admission);
+            (0, emit_trailer_1.emitDelegationResult)({ command, trace: inheritedTrace, isError: true, state: emitState });
+            process.exit(1);
+            return;
+        }
+    }
     let exitCode = 0;
     let result;
     try {
-        result = await crewx.execute(agentRef, finalMessage, {
-            provider,
-            model,
-            effort: effort || undefined,
-            overdrive: overdrive || undefined,
-            threadId: thread,
-            taskId: selfTaskId,
-            actor: assignedTaskId === undefined ? actor : taskActor,
-            metadata: Object.keys(parsedMetadata).length > 0 ? parsedMetadata : undefined,
-            vars: Object.keys(vars).length > 0 ? vars : undefined,
-            trace: inheritedTrace,
-        });
-        if (!result.ok) {
-            const errMsg = result.error?.message ?? 'Execute failed';
-            console.error(errMsg);
-            (0, write_output_1.appendError)(out, errMsg);
+        try {
+            result = await crewx.execute(agentRef, finalMessage, {
+                provider,
+                model,
+                effort: effort || undefined,
+                overdrive: overdrive || undefined,
+                threadId: thread,
+                taskId: selfTaskId,
+                actor: assignedTaskId === undefined ? actor : taskActor,
+                metadata: Object.keys(parsedMetadata).length > 0 ? parsedMetadata : undefined,
+                vars: Object.keys(vars).length > 0 ? vars : undefined,
+                trace: inheritedTrace,
+            });
+            if (!result.ok) {
+                const errMsg = result.error?.message ?? 'Execute failed';
+                console.error(errMsg);
+                (0, write_output_1.appendError)(out, errMsg);
+                exitCode = 1;
+            }
+            else {
+                if (verbose) {
+                    process.stderr.write(`\n📊 Results from ${agentRef}:\n`);
+                    process.stderr.write('═'.repeat(60) + '\n');
+                    process.stderr.write('🟢 Status: Success\n');
+                    process.stderr.write(`🤖 Provider: ${result.meta.provider}\n`);
+                    process.stderr.write(`⏱️  Duration: ${result.meta.durationMs}ms\n`);
+                    process.stderr.write('\n📄 Response:\n');
+                    process.stderr.write('─'.repeat(40) + '\n');
+                }
+                (0, write_output_1.writeResult)(out, result.data);
+                if (verbose)
+                    process.stderr.write('\n✅ Execute completed successfully\n');
+            }
+        }
+        catch (err) {
+            const errMsg = err instanceof Error ? err.message : String(err);
+            console.error(`Error: ${errMsg}`);
+            (0, write_output_1.appendError)(out, `Error: ${errMsg}`);
             exitCode = 1;
         }
-        else {
-            if (verbose) {
-                process.stderr.write(`\n📊 Results from ${agentRef}:\n`);
-                process.stderr.write('═'.repeat(60) + '\n');
-                process.stderr.write('🟢 Status: Success\n');
-                process.stderr.write(`🤖 Provider: ${result.meta.provider}\n`);
-                process.stderr.write(`⏱️  Duration: ${result.meta.durationMs}ms\n`);
-                process.stderr.write('\n📄 Response:\n');
-                process.stderr.write('─'.repeat(40) + '\n');
+        finally {
+            try {
+                await crewx.close();
+            }
+            catch (err) {
+                (0, emit_trailer_1.emitDelegationResult)({
+                    command,
+                    trace: inheritedTrace,
+                    taskId: result?.meta.taskId,
+                    agentId: result?.meta.agentId,
+                    isError: true,
+                    state: emitState,
+                });
+                throw err;
             }
-            (0, write_output_1.writeResult)(out, result.data);
-            if (verbose)
-                process.stderr.write('\n✅ Execute completed successfully\n');
         }
     }
-    catch (err) {
-        const errMsg = err instanceof Error ? err.message : String(err);
-        console.error(`Error: ${errMsg}`);
-        (0, write_output_1.appendError)(out, `Error: ${errMsg}`);
-        exitCode = 1;
-    }
     finally {
-        try {
-            await crewx.close();
-        }
-        catch (err) {
-            (0, emit_trailer_1.emitDelegationResult)({
-                command,
-                trace: inheritedTrace,
-                taskId: result?.meta.taskId,
-                agentId: result?.meta.agentId,
-                isError: true,
-                state: emitState,
-            });
-            throw err;
-        }
+        if (admission?.ok)
+            admission.release();
     }
     (0, emit_trailer_1.emitDelegationResult)({
         command,

package/dist/commands/query.js

@@ -175,64 +175,87 @@ async function handleQuery(args, command = 'query', emitState = (0, emit_trailer
             taskActor = (0, detached_1.readAssignedTaskActor)(taskRepo, adoption.taskId);
         }
     }
+    // A synchronous `crewx q` runs in this same process, but this process is
+    // still separate from the embedded server and never sees its in-memory
+    // UpdateGateService (WI-CTO-20260919-004 R2 finding #1) — only the durable
+    // marker it writes. Reserve-then-check before calling into the SDK below,
+    // not after; see admitDurableTask()'s own doc comment. Never checked for
+    // an adopted receipt (selfTaskId set): that work was already admitted by
+    // whichever process first created its pending DB row.
+    let admission;
+    if (selfTaskId === undefined) {
+        admission = (0, sdk_1.admitDurableTask)(`direct-cli:${command}`);
+        if (!admission.ok) {
+            (0, detached_1.reportAdmissionBlocked)(admission);
+            (0, emit_trailer_1.emitDelegationResult)({ command, trace: inheritedTrace, isError: true, state: emitState });
+            process.exit(1);
+            return;
+        }
+    }
     let exitCode = 0;
     let result;
     try {
-        result = await crewx.query(agentRef, finalMessage, {
-            provider,
-            model,
-            effort: effort || undefined,
-            overdrive: overdrive || undefined,
-            threadId: thread,
-            taskId: selfTaskId,
-            actor: assignedTaskId === undefined ? actor : taskActor,
-            metadata: Object.keys(parsedMetadata).length > 0 ? parsedMetadata : undefined,
-            vars: Object.keys(vars).length > 0 ? vars : undefined,
-            trace: inheritedTrace,
-        });
-        if (!result.ok) {
-            const errMsg = result.error?.message ?? 'Query failed';
-            console.error(errMsg);
-            (0, write_output_1.appendError)(out, errMsg);
+        try {
+            result = await crewx.query(agentRef, finalMessage, {
+                provider,
+                model,
+                effort: effort || undefined,
+                overdrive: overdrive || undefined,
+                threadId: thread,
+                taskId: selfTaskId,
+                actor: assignedTaskId === undefined ? actor : taskActor,
+                metadata: Object.keys(parsedMetadata).length > 0 ? parsedMetadata : undefined,
+                vars: Object.keys(vars).length > 0 ? vars : undefined,
+                trace: inheritedTrace,
+            });
+            if (!result.ok) {
+                const errMsg = result.error?.message ?? 'Query failed';
+                console.error(errMsg);
+                (0, write_output_1.appendError)(out, errMsg);
+                exitCode = 1;
+            }
+            else {
+                if (verbose) {
+                    process.stderr.write(`\n📊 Results from ${agentRef}:\n`);
+                    process.stderr.write('═'.repeat(60) + '\n');
+                    process.stderr.write('🟢 Status: Success\n');
+                    process.stderr.write(`🤖 Provider: ${result.meta.provider}\n`);
+                    process.stderr.write(`⏱️  Duration: ${result.meta.durationMs}ms\n`);
+                    process.stderr.write('\n📄 Response:\n');
+                    process.stderr.write('─'.repeat(40) + '\n');
+                }
+                (0, write_output_1.writeResult)(out, result.data);
+                if (verbose) {
+                    process.stderr.write('\n✅ Query completed successfully\n');
+                }
+            }
+        }
+        catch (err) {
+            const errMsg = err instanceof Error ? err.message : String(err);
+            console.error(`Error: ${errMsg}`);
+            (0, write_output_1.appendError)(out, `Error: ${errMsg}`);
             exitCode = 1;
         }
-        else {
-            if (verbose) {
-                process.stderr.write(`\n📊 Results from ${agentRef}:\n`);
-                process.stderr.write('═'.repeat(60) + '\n');
-                process.stderr.write('🟢 Status: Success\n');
-                process.stderr.write(`🤖 Provider: ${result.meta.provider}\n`);
-                process.stderr.write(`⏱️  Duration: ${result.meta.durationMs}ms\n`);
-                process.stderr.write('\n📄 Response:\n');
-                process.stderr.write('─'.repeat(40) + '\n');
+        finally {
+            try {
+                await crewx.close();
             }
-            (0, write_output_1.writeResult)(out, result.data);
-            if (verbose) {
-                process.stderr.write('\n✅ Query completed successfully\n');
+            catch (err) {
+                (0, emit_trailer_1.emitDelegationResult)({
+                    command,
+                    trace: inheritedTrace,
+                    taskId: result?.meta.taskId,
+                    agentId: result?.meta.agentId,
+                    isError: true,
+                    state: emitState,
+                });
+                throw err;
             }
         }
     }
-    catch (err) {
-        const errMsg = err instanceof Error ? err.message : String(err);
-        console.error(`Error: ${errMsg}`);
-        (0, write_output_1.appendError)(out, `Error: ${errMsg}`);
-        exitCode = 1;
-    }
     finally {
-        try {
-            await crewx.close();
-        }
-        catch (err) {
-            (0, emit_trailer_1.emitDelegationResult)({
-                command,
-                trace: inheritedTrace,
-                taskId: result?.meta.taskId,
-                agentId: result?.meta.agentId,
-                isError: true,
-                state: emitState,
-            });
-            throw err;
-        }
+        if (admission?.ok)
+            admission.release();
     }
     (0, emit_trailer_1.emitDelegationResult)({
         command,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@crewx/cli",
-  "version": "0.9.0-rc.109",
+  "version": "0.9.0-rc.110",
   "license": "UNLICENSED",
   "engines": {
     "node": ">=20.19.0"
@@ -25,19 +25,19 @@
     "better-sqlite3": "*",
     "dotenv": "17.2.3",
     "isomorphic-git": "1.37.1",
-    "@crewx/sdk": "0.9.0-rc.109",
-    "@crewx/knowledge-core": "0.1.17-rc.119",
-    "@crewx/search": "0.1.10-rc.105",
-    "@crewx/doc": "0.1.9-rc.102",
-    "@crewx/memory": "0.1.23-rc.126",
-    "@crewx/wbs": "0.1.10-rc.135",
-    "@crewx/cron": "0.1.10-rc.144",
-    "@crewx/workflow": "0.3.22-rc.155",
-    "@crewx/skill": "0.1.20-rc.3",
-    "@crewx/notify": "0.1.0-rc.80",
-    "@crewx/chromex": "0.1.0-rc.142",
-    "@crewx/shared": "0.0.6-rc.24",
-    "@crewx/wi": "0.1.10-rc.129"
+    "@crewx/sdk": "0.9.0-rc.110",
+    "@crewx/knowledge-core": "0.1.17-rc.120",
+    "@crewx/memory": "0.1.23-rc.127",
+    "@crewx/doc": "0.1.9-rc.103",
+    "@crewx/search": "0.1.10-rc.106",
+    "@crewx/wbs": "0.1.10-rc.136",
+    "@crewx/cron": "0.1.10-rc.145",
+    "@crewx/skill": "0.1.20-rc.4",
+    "@crewx/workflow": "0.3.22-rc.156",
+    "@crewx/chromex": "0.1.0-rc.143",
+    "@crewx/notify": "0.1.0-rc.81",
+    "@crewx/wi": "0.1.10-rc.130",
+    "@crewx/shared": "0.0.6-rc.25"
   },
   "devDependencies": {
     "@types/better-sqlite3": "*",