@crewhaus/target-onchain 0.1.1 → 0.1.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@crewhaus/target-onchain",
-  "version": "0.1.1",
+  "version": "0.1.3",
   "type": "module",
   "description": "Codegen for the §47 `onchain` event-driven daemon. Emits a self-contained agent.ts that subscribes to chain triggers, classifies inbound events, dedupes by tx-hash + log-index, and runs one agent turn per event.",
   "main": "src/index.ts",
@@ -12,15 +12,15 @@
     "test": "bun test src"
   },
   "dependencies": {
-    "@crewhaus/errors": "0.1.1",
-    "@crewhaus/infra-utils": "0.1.1",
-    "@crewhaus/ir": "0.1.1"
+    "@crewhaus/errors": "0.1.3",
+    "@crewhaus/infra-utils": "0.1.3",
+    "@crewhaus/ir": "0.1.3"
   },
   "license": "Apache-2.0",
   "author": {
     "name": "Max Meier",
-    "email": "max@studiomax.io",
-    "url": "https://studiomax.io"
+    "email": "max@crewhaus.ai",
+    "url": "https://crewhaus.ai"
   },
   "repository": {
     "type": "git",
@@ -32,12 +32,7 @@
     "url": "https://github.com/crewhaus/factory/issues"
   },
   "publishConfig": {
-    "access": "restricted"
+    "access": "public"
   },
-  "files": [
-    "src",
-    "README.md",
-    "LICENSE",
-    "NOTICE"
-  ]
+  "files": ["src", "README.md", "LICENSE", "NOTICE"]
 }

package/src/index.test.ts

@@ -133,6 +133,105 @@ describe("emitOnchain — happy path", () => {
     expect(c).toContain('"allowedContracts":["treasury"]');
     expect(c).toContain('"maxValueUsd":5000');
   });
+
+  // SECURITY: maxValueWei is the ONLY native-value cap wallet-engine can
+  // enforce (maxValueUsd hard-throws with no oracle); it must reach the
+  // emitted TRANSACTION_POLICY literal so the ceiling is actually applied.
+  test("renders transaction_policy.maxValueWei into the emitted literal", () => {
+    const bundle = emitOnchain(
+      baseIr({
+        transactionPolicy: {
+          defaultWriteApproval: "policy",
+          allowedContracts: [],
+          simulationRequired: true,
+          maxValueWei: "1000000000000000000",
+        },
+      }),
+    );
+    const c = bundle.files[0]?.content ?? "";
+    expect(c).toContain('"maxValueWei":"1000000000000000000"');
+  });
+
+  // #151 activation — the policy must carry a resolved contractId -> address
+  // map so the wallet-engine can bind tx.to to the declared contract.
+  test("populates transaction_policy.contractAddresses from declared contracts[]", () => {
+    const bundle = emitOnchain(
+      baseIr({
+        contracts: [
+          { id: "treasury", chainId: "base-mainnet", address: "0xTREASURY", abiRef: "abi://safe" },
+          { id: "vault", chainId: "base-mainnet", address: "0xVAULT", abiRef: "abi://erc20" },
+        ],
+      }),
+    );
+    const c = bundle.files[0]?.content ?? "";
+    expect(c).toContain('"contractAddresses":{"treasury":"0xTREASURY","vault":"0xVAULT"}');
+  });
+
+  test("omits contractAddresses when no contracts are declared", () => {
+    const bundle = emitOnchain(baseIr({ contracts: [] }));
+    const c = bundle.files[0]?.content ?? "";
+    expect(c).not.toContain("contractAddresses");
+  });
+
+  // #159 (CWE-798) — a wallet keyRef that is an env ref or a kms:// / hsm://
+  // handle is fine; a bare literal (esp. a raw hex private key) must not be
+  // baked into the emitted artifact.
+  test("renders a wallet env-ref keyRef as a process.env lookup", () => {
+    const bundle = emitOnchain(
+      baseIr({
+        wallets: [
+          {
+            id: "treasurer",
+            chainId: "base-mainnet",
+            custody: "kms",
+            signingPolicy: "policy-gated",
+            keyRef: { kind: "env", name: "TREASURER_KEY" },
+          },
+        ],
+      }),
+    );
+    const c = bundle.files[0]?.content ?? "";
+    expect(c).toContain('process.env["TREASURER_KEY"]');
+  });
+
+  test("renders a kms:// keyRef handle verbatim", () => {
+    const bundle = emitOnchain(
+      baseIr({
+        wallets: [
+          {
+            id: "treasurer",
+            chainId: "base-mainnet",
+            custody: "kms",
+            signingPolicy: "policy-gated",
+            keyRef: { kind: "literal", value: "kms://aws/treasurer-key" },
+          },
+        ],
+      }),
+    );
+    const c = bundle.files[0]?.content ?? "";
+    expect(c).toContain('"kms://aws/treasurer-key"');
+  });
+
+  test("rejects a literal (hex private key) wallet keyRef", () => {
+    expect(() =>
+      emitOnchain(
+        baseIr({
+          wallets: [
+            {
+              id: "treasurer",
+              chainId: "base-mainnet",
+              custody: "local",
+              signingPolicy: "automated",
+              keyRef: {
+                kind: "literal",
+                value: "0x59c6995e998f97a5a0044966f0945389dc9e86dae88c7a8412f4603b6b78690d",
+              },
+            },
+          ],
+        }),
+      ),
+    ).toThrow(TargetEmitError);
+  });
 });
 
 describe("emitOnchain — validation", () => {
@@ -154,3 +253,18 @@ describe("emitOnchain — validation", () => {
     ).toThrow(/not declared in chains/);
   });
 });
+
+describe("emitOnchain — spec-name codegen injection (#147)", () => {
+  test("a crafted name cannot break out of the header comment", () => {
+    // Block-comment escape: a `*/` (plus a newline) in the name would, with a
+    // raw `/* … */` header, terminate the comment and inject top-level code.
+    const evil = "safe */ globalThis.__PWNED_ONCHAIN__ = 1; /*\nmore";
+    const content = emitOnchain(baseIr({ name: evil })).files[0]?.content ?? "";
+    // Header is now a `//` line comment using the JSON-escaped name.
+    expect(content).toMatch(/^\/\/ Compiled from spec:/m);
+    // The payload only ever appears inside the escaped SPEC_NAME string and the
+    // comment — never as a top-level statement at column 0.
+    expect(content).not.toMatch(/^globalThis\.__PWNED_ONCHAIN__/m);
+    expect(content).not.toContain("*/\nglobalThis");
+  });
+});

package/src/index.ts

@@ -50,6 +50,24 @@ function renderSecretRef(ref: IrSecretRef): string {
   )}); })()`;
 }
 
+/**
+ * #159 (CWE-798) — a wallet signing key must never be a bare literal in
+ * the emitted DO-NOT-EDIT artifact. The compiler's `lowerWalletKeyRef`
+ * already rejects literal keyRefs at lower time; this is the
+ * defense-in-depth guard at the emit boundary (e.g. for a hand-built IR
+ * that bypassed the lowerer). Env refs pass; only `kms://` / `hsm://`
+ * key handles are permitted as literals.
+ */
+const KEY_HANDLE_RE = /^(kms|hsm):\/\/.+/;
+function renderWalletKeyRef(walletId: string, ref: IrSecretRef): string {
+  if (ref.kind === "literal" && !KEY_HANDLE_RE.test(ref.value)) {
+    throw new TargetEmitError(
+      `wallet "${walletId}" keyRef is a literal signing key; refusing to embed it in the generated bundle. Use an environment reference or a kms:// / hsm:// handle.`,
+    );
+  }
+  return renderSecretRef(ref);
+}
+
 function renderChain(chain: IrChainV0["chains"][number]): string {
   const rpcs = chain.rpcUrls.map(renderSecretRef).join(", ");
   const finality =
@@ -68,7 +86,8 @@ function renderChain(chain: IrChainV0["chains"][number]): string {
 }
 
 function renderWallet(w: IrChainV0["wallets"][number]): string {
-  const keyRefStr = w.keyRef !== undefined ? `,\n    keyRef: ${renderSecretRef(w.keyRef)}` : "";
+  const keyRefStr =
+    w.keyRef !== undefined ? `,\n    keyRef: ${renderWalletKeyRef(w.id, w.keyRef)}` : "";
   return [
     "  {",
     `    id: ${JSON.stringify(w.id)},`,
@@ -120,11 +139,21 @@ export function emitOnchain(ir: IrChainV0): Bundle {
   }
 
   const policy = ir.transactionPolicy;
+  // #151 — resolve the declared contracts[] (id -> address) into the policy so
+  // the wallet-engine can bind `tx.to` to the address registered for a claimed
+  // contractId. Without this map a whitelisted id can still be pointed at an
+  // arbitrary address.
+  const contractAddresses: Record<string, string> = {};
+  for (const c of ir.contracts) {
+    contractAddresses[c.id] = c.address;
+  }
   const policyLiteral = JSON.stringify({
     defaultWriteApproval: policy.defaultWriteApproval,
     allowedContracts: policy.allowedContracts,
     simulationRequired: policy.simulationRequired,
     ...(policy.maxValueUsd !== undefined ? { maxValueUsd: policy.maxValueUsd } : {}),
+    ...(policy.maxValueWei !== undefined ? { maxValueWei: policy.maxValueWei } : {}),
+    ...(ir.contracts.length > 0 ? { contractAddresses } : {}),
   });
 
   const chains = ir.chains.map(renderChain).join(",\n");
@@ -135,11 +164,12 @@ export function emitOnchain(ir: IrChainV0): Bundle {
   const instructions = escapeJsonString(ir.agent.instructions);
   const name = escapeJsonString(ir.name);
 
-  const content = `/**
- * Generated by @crewhaus/target-onchain (§47 onchain daemon).
- * Compiled from spec: ${ir.name}
- * DO NOT EDIT — re-run \`crewhaus compile\` to regenerate.
- */
+  // Header is a `//` line comment using the JSON-escaped name: a raw ir.name in
+  // a block comment lets a crafted spec.name containing `*/` (or a newline) break
+  // out of the comment and inject top-level code — RCE on build/run (#147).
+  const content = `// Generated by @crewhaus/target-onchain (§47 onchain daemon).
+// Compiled from spec: ${name}
+// DO NOT EDIT — re-run \`crewhaus compile\` to regenerate.
 import { classifyBoundary } from "@crewhaus/boundary-classifier";
 import { createEvmAdapter } from "@crewhaus/chain-adapter-evm";