@crewhaus/canary-controller 0.1.1 → 0.1.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@crewhaus/canary-controller",
-  "version": "0.1.1",
+  "version": "0.1.3",
   "type": "module",
   "description": "Percent-of-traffic rollout with eval-gated promotion. Hash-routes requests across two pinned versions and auto-rolls-back on regression.",
   "main": "src/index.ts",
@@ -12,16 +12,16 @@
     "test": "bun test src"
   },
   "dependencies": {
-    "@crewhaus/audit-log": "0.1.1",
-    "@crewhaus/deployment-controller": "0.1.1",
-    "@crewhaus/errors": "0.1.1",
-    "@crewhaus/spec-registry": "0.1.1"
+    "@crewhaus/audit-log": "0.1.3",
+    "@crewhaus/deployment-controller": "0.1.3",
+    "@crewhaus/errors": "0.1.3",
+    "@crewhaus/spec-registry": "0.1.3"
   },
   "license": "Apache-2.0",
   "author": {
     "name": "Max Meier",
-    "email": "max@studiomax.io",
-    "url": "https://studiomax.io"
+    "email": "max@crewhaus.ai",
+    "url": "https://crewhaus.ai"
   },
   "repository": {
     "type": "git",
@@ -33,12 +33,7 @@
     "url": "https://github.com/crewhaus/factory/issues"
   },
   "publishConfig": {
-    "access": "restricted"
+    "access": "public"
   },
-  "files": [
-    "src",
-    "README.md",
-    "LICENSE",
-    "NOTICE"
-  ]
+  "files": ["src", "README.md", "LICENSE", "NOTICE"]
 }

package/src/index.test.ts

@@ -90,6 +90,48 @@ describe("canary-controller — T3 traffic routing", () => {
       ctrl.route({ name: "x", fromVersion: "v1", toVersion: "v2", trafficPercent: 150 }, "r"),
     ).toThrow(CanaryError);
   });
+
+  test("negative trafficPercent throws", async () => {
+    const reg = createFileBackedRegistry({ rootDir: join(tmpRoot, "specs") });
+    const deploy = createDeploymentController({ registry: reg });
+    const ctrl = createCanaryController({ registry: reg, deploymentController: deploy });
+    expect(() =>
+      ctrl.route({ name: "x", fromVersion: "v1", toVersion: "v2", trafficPercent: -1 }, "r"),
+    ).toThrow(CanaryError);
+  });
+
+  test("NaN trafficPercent throws instead of silently routing all traffic to control", async () => {
+    // Regression: `NaN < 0` and `NaN > 100` are both false, so without an
+    // explicit finiteness check a NaN percentage slips past validation and
+    // every request silently falls back to fromVersion (isCanary always false).
+    const reg = createFileBackedRegistry({ rootDir: join(tmpRoot, "specs") });
+    const deploy = createDeploymentController({ registry: reg });
+    const ctrl = createCanaryController({ registry: reg, deploymentController: deploy });
+    expect(() =>
+      ctrl.route(
+        { name: "x", fromVersion: "v1", toVersion: "v2", trafficPercent: Number.NaN },
+        "r",
+      ),
+    ).toThrow(CanaryError);
+    expect(() =>
+      ctrl.route(
+        { name: "x", fromVersion: "v1", toVersion: "v2", trafficPercent: Number.NaN },
+        "r",
+      ),
+    ).toThrow(/trafficPercent must be in 0\.\.100/);
+  });
+
+  test("Infinity trafficPercent throws", async () => {
+    const reg = createFileBackedRegistry({ rootDir: join(tmpRoot, "specs") });
+    const deploy = createDeploymentController({ registry: reg });
+    const ctrl = createCanaryController({ registry: reg, deploymentController: deploy });
+    expect(() =>
+      ctrl.route(
+        { name: "x", fromVersion: "v1", toVersion: "v2", trafficPercent: Number.POSITIVE_INFINITY },
+        "r",
+      ),
+    ).toThrow(CanaryError);
+  });
 });
 
 describe("canary-controller — eval gate", () => {

package/src/index.ts

@@ -92,7 +92,11 @@ export type CanaryControllerOptions = {
 export function createCanaryController(opts: CanaryControllerOptions): CanaryController {
   return {
     route(config, requestId): CanaryRoutingDecision {
-      if (config.trafficPercent < 0 || config.trafficPercent > 100) {
+      if (
+        !Number.isFinite(config.trafficPercent) ||
+        config.trafficPercent < 0 ||
+        config.trafficPercent > 100
+      ) {
         throw new CanaryError(`trafficPercent must be in 0..100; got ${config.trafficPercent}`);
       }
       const bucket = computeBucket(config.tenantId, requestId);