@cregis-dev/cckit 0.3.0 → 0.4.1

package/src/core/plugin-installer.js

@@ -1,232 +1,278 @@
-/**
- * Plugin installer — handles distributing plugins to Claude Code and Trae.
- *
- * Claude Code: writes plugin IDs into `.claude/settings.json` enabledPlugins.
- * Trae: extracts skills/commands/agents from plugin templates into `.trae/`.
- */
-
-import path from 'node:path'
-import fse from 'fs-extra'
-import { listFiles, copyWithInterpolation, interpolate } from '../utils/fs.js'
-import { convertAgentForTrae, convertCommandForTrae } from '../adapters/trae-adapter.js'
-
-// ─── Plugin Resolution ──────────────────────────────────────────────────────
-
-/**
- * Get plugin IDs marked as default in the registry.
- *
- * @param {object} registry - Registry object with plugins section
- * @returns {string[]} Default plugin IDs
- */
-export function getDefaultPlugins(registry) {
-  const plugins = registry.plugins || {}
-  return Object.entries(plugins)
-    .filter(([, def]) => def.default)
-    .map(([id]) => id)
-}
-
-/**
- * Resolve requested plugin IDs to plugin definitions with constructed template paths.
- * Note: Template directory existence is validated later by installPlugins().
- *
- * @param {object} registry - Registry object
- * @param {string[]} pluginIds - Requested plugin IDs
- * @param {string} templateBase - Absolute path to cckit templates/ directory
- * @param {object} logger - Logger instance
- * @returns {{ found: Array<{ id: string, def: object, templateDir: string }>, skipped: Array<{ id: string, reason: string }> }}
- */
-export function resolvePlugins(registry, pluginIds, templateBase, logger) {
-  const plugins = registry.plugins || {}
-  const found = []
-  const skipped = []
-
-  for (const id of pluginIds) {
-    const def = plugins[id]
-    if (!def) {
-      logger.warn(`Plugin "${id}" not found in registry, skipping`)
-      skipped.push({ id, reason: 'not in registry' })
-      continue
-    }
-
-    const templateDir = path.join(templateBase, 'plugins', id)
-    found.push({ id, def, templateDir })
-  }
-
-  return { found, skipped }
-}
-
-// ─── Claude Code Installation ───────────────────────────────────────────────
-
-/**
- * Install plugins for Claude Code by writing enabledPlugins to settings.json.
- *
- * @param {Array<{ id: string, def: object }>} plugins - Resolved plugins
- * @param {string} targetDir - Project root directory
- * @param {object} logger - Logger instance
- * @returns {Promise<string[]>} List of enabled plugin keys
- */
-export async function installForClaudeCode(plugins, targetDir, logger) {
-  const settingsPath = path.join(targetDir, '.claude', 'settings.json')
-  let existing = {}
-
-  try {
-    if (await fse.pathExists(settingsPath)) {
-      const raw = await fse.readFile(settingsPath, 'utf8')
-      existing = JSON.parse(raw)
-    }
-  } catch (err) {
-    logger.warn(`settings.json parse error, backing up and recreating: ${err.message}`)
-    const backupPath = `${settingsPath}.bak.${Date.now()}`
-    await fse.copy(settingsPath, backupPath)
-    existing = {}
-  }
-
-  const newPlugins = {}
-  for (const { id, def } of plugins) {
-    const key = `${id}@${def.marketplace}`
-    newPlugins[key] = true
-  }
-
-  const merged = {
-    ...existing,
-    enabledPlugins: {
-      ...(existing.enabledPlugins || {}),
-      ...newPlugins,
-    },
-  }
-
-  await fse.ensureDir(path.dirname(settingsPath))
-  await fse.writeFile(settingsPath, JSON.stringify(merged, null, 2) + '\n', 'utf8')
-
-  const enabledKeys = Object.keys(newPlugins)
-  logger.debug(`Claude Code: enabled ${enabledKeys.length} plugins in settings.json`)
-  return enabledKeys
-}
-
-// ─── Trae Installation ──────────────────────────────────────────────────────
-
-/**
- * Install a category of plugin markdown files with adapter transformation.
- *
- * @param {string} srcDir - Source directory containing .md files
- * @param {string} destDir - Destination directory
- * @param {Function} adapter - Content transform function (content, filename) => content
- * @param {object} variables - Interpolation variables
- * @returns {Promise<number>} Number of files installed
- */
-async function installPluginCategory(srcDir, destDir, adapter, variables) {
-  if (!await fse.pathExists(srcDir)) return 0
-
-  await fse.ensureDir(destDir)
-  const files = await listFiles(srcDir)
-  let count = 0
-
-  for (const relPath of files) {
-    if (!relPath.endsWith('.md')) continue
-    const srcFile = path.join(srcDir, relPath)
-    let content = await fse.readFile(srcFile, 'utf8')
-    content = interpolate(content, variables)
-
-    const destName = `${path.basename(relPath, '.md')}.md`
-    content = adapter(content, destName)
-    await fse.writeFile(path.join(destDir, destName), content, 'utf8')
-    count++
-  }
-
-  return count
-}
-
-/**
- * Install plugins for Trae by extracting skills/commands/agents.
- *
- * @param {Array<{ id: string, def: object, templateDir: string }>} plugins - Resolved plugins with template paths
- * @param {string} targetDir - Project root directory
- * @param {object} variables - Interpolation variables
- * @param {object} logger - Logger instance
- * @returns {Promise<{ files: number, details: Array<{ id: string, skills: number, commands: number, agents: number }> }>}
- */
-export async function installForTrae(plugins, targetDir, variables, logger) {
-  let totalFiles = 0
-  const details = []
-
-  for (const { id, templateDir } of plugins) {
-    try {
-      const counts = { skills: 0, commands: 0, agents: 0 }
-
-      // Skills → .trae/skills/<pluginId>/ (direct copy + interpolation)
-      const skillsSrc = path.join(templateDir, 'skills')
-      if (await fse.pathExists(skillsSrc)) {
-        const skillsDest = path.join(targetDir, '.trae', 'skills', id)
-        counts.skills = await copyWithInterpolation(skillsSrc, skillsDest, variables)
-        totalFiles += counts.skills
-      }
-
-      // Commands → .trae/rules/<pluginId>/commands/<name>.md (with adapter)
-      counts.commands = await installPluginCategory(
-        path.join(templateDir, 'commands'),
-        path.join(targetDir, '.trae', 'rules', id, 'commands'),
-        convertCommandForTrae,
-        variables
-      )
-      totalFiles += counts.commands
-
-      // Agents → .trae/rules/<pluginId>/agents/<name>.md (with adapter)
-      counts.agents = await installPluginCategory(
-        path.join(templateDir, 'agents'),
-        path.join(targetDir, '.trae', 'rules', id, 'agents'),
-        convertAgentForTrae,
-        variables
-      )
-      totalFiles += counts.agents
-
-      details.push({ id, ...counts })
-      logger.debug(`  Trae plugin "${id}": ${counts.skills} skills, ${counts.commands} commands, ${counts.agents} agents`)
-    } catch (err) {
-      throw new Error(`Failed to install Trae content for plugin "${id}": ${err.message}`)
-    }
-  }
-
-  return { files: totalFiles, details }
-}
-
-// ─── Main Entry ─────────────────────────────────────────────────────────────
-
-/**
- * Install plugins for all selected IDEs.
- *
- * @param {{
- *   plugins: Array<{ id: string, def: object, templateDir: string }>,
- *   targetDir: string,
- *   ides: string[],
- *   variables: object,
- *   logger: object
- * }} opts
- * @returns {Promise<{ claudeCode: string[], trae: object, installed: string[] }>}
- */
-export async function installPlugins({ plugins, targetDir, ides, variables, logger }) {
-  const result = { claudeCode: [], trae: { files: 0, details: [] }, installed: [] }
-
-  // Claude Code: write ALL plugin IDs to settings.json (no templates needed)
-  if (ides.includes('claude-code') && plugins.length > 0) {
-    result.claudeCode = await installForClaudeCode(plugins, targetDir, logger)
-  }
-
-  // Trae: extract content from plugins that have templates
-  const available = []
-  for (const p of plugins) {
-    if (await fse.pathExists(p.templateDir)) {
-      available.push(p)
-    } else {
-      logger.warn(`Plugin "${p.id}" template not found at ${p.templateDir}, skipping Trae extraction`)
-    }
-  }
-
-  if (ides.includes('trae') && available.length > 0) {
-    result.trae = await installForTrae(available, targetDir, variables, logger)
-  }
-
-  // Track all plugins as installed (settings.json counts even without templates)
-  result.installed = plugins.map(p => p.id)
-  return result
-}
-
+/**
+ * Plugin installer — handles distributing plugins to Claude Code and Trae.
+ *
+ * Claude Code: writes plugin IDs into `.claude/settings.json` enabledPlugins.
+ * Trae: extracts skills/commands/agents from plugin templates into `.trae/`.
+ */
+
+import path from 'node:path'
+import fse from 'fs-extra'
+import { listFiles, copyWithInterpolation, interpolate } from '../utils/fs.js'
+import { convertAgentForTrae, convertCommandForTrae } from '../adapters/trae-adapter.js'
+
+// ─── Claude Code Base Settings ──────────────────────────────────────────────
+
+/**
+ * Default environment overrides written to `.claude/settings.json`.
+ * These disable telemetry, error reporting, and the /bug command.
+ */
+const CLAUDE_CODE_ENV_DEFAULTS = {
+  DISABLE_BUG_COMMAND: '1',
+  DISABLE_ERROR_REPORTING: '1',
+  DISABLE_TELEMETRY: '1',
+  MCP_TIMEOUT: '60000',
+  MAX_THINKING_TOKENS: '31999',
+  CLAUDE_CODE_MAX_OUTPUT_TOKENS: '64000',
+}
+
+// ─── Plugin Resolution ──────────────────────────────────────────────────────
+
+/**
+ * Get plugin IDs marked as default in the registry.
+ *
+ * @param {object} registry - Registry object with plugins section
+ * @returns {string[]} Default plugin IDs
+ */
+export function getDefaultPlugins(registry) {
+  const plugins = registry.plugins || {}
+  return Object.entries(plugins)
+    .filter(([, def]) => def.default)
+    .map(([id]) => id)
+}
+
+/**
+ * Resolve requested plugin IDs to plugin definitions with constructed template paths.
+ * Note: Template directory existence is validated later by installPlugins().
+ *
+ * @param {object} registry - Registry object
+ * @param {string[]} pluginIds - Requested plugin IDs
+ * @param {string} templateBase - Absolute path to cckit templates/ directory
+ * @param {object} logger - Logger instance
+ * @returns {{ found: Array<{ id: string, def: object, templateDir: string }>, skipped: Array<{ id: string, reason: string }> }}
+ */
+export function resolvePlugins(registry, pluginIds, templateBase, logger) {
+  const plugins = registry.plugins || {}
+  const found = []
+  const skipped = []
+
+  for (const id of pluginIds) {
+    const def = plugins[id]
+    if (!def) {
+      logger.warn(`Plugin "${id}" not found in registry, skipping`)
+      skipped.push({ id, reason: 'not in registry' })
+      continue
+    }
+
+    const templateDir = path.join(templateBase, 'plugins', id)
+    found.push({ id, def, templateDir })
+  }
+
+  return { found, skipped }
+}
+
+// ─── Claude Code Installation ───────────────────────────────────────────────
+
+/**
+ * Install plugins for Claude Code by writing enabledPlugins and
+ * extraKnownMarketplaces (for non-built-in marketplaces) to settings.json.
+ *
+ * Plugins with a `marketplaceSource` field in their registry definition will
+ * have their marketplace source added to `extraKnownMarketplaces`, enabling
+ * Claude Code to auto-prompt users for marketplace trust and plugin installation.
+ *
+ * @param {Array<{ id: string, def: object }>} plugins - Resolved plugins
+ * @param {string} targetDir - Project root directory
+ * @param {object} logger - Logger instance
+ * @returns {Promise<string[]>} List of enabled plugin keys
+ */
+export async function installForClaudeCode(plugins, targetDir, logger) {
+  const settingsPath = path.join(targetDir, '.claude', 'settings.json')
+  let existing = {}
+
+  try {
+    if (await fse.pathExists(settingsPath)) {
+      const raw = await fse.readFile(settingsPath, 'utf8')
+      existing = JSON.parse(raw)
+    }
+  } catch (err) {
+    logger.warn(`settings.json parse error, backing up and recreating: ${err.message}`)
+    const backupPath = `${settingsPath}.bak.${Date.now()}`
+    await fse.copy(settingsPath, backupPath)
+    existing = {}
+  }
+
+  const newPlugins = {}
+  const newMarketplaces = {}
+
+  for (const { id, def } of plugins) {
+    const key = `${id}@${def.marketplace}`
+    newPlugins[key] = true
+
+    // Collect non-built-in marketplace sources (dedupe by marketplace name)
+    if (def.marketplaceSource && !newMarketplaces[def.marketplace]) {
+      newMarketplaces[def.marketplace] = { source: { ...def.marketplaceSource } }
+    }
+  }
+
+  const merged = {
+    ...existing,
+    env: {
+      ...(existing.env || {}),
+      ...CLAUDE_CODE_ENV_DEFAULTS,
+    },
+    enabledPlugins: {
+      ...(existing.enabledPlugins || {}),
+      ...newPlugins,
+    },
+  }
+
+  const enabledKeys = Object.keys(newPlugins)
+  const marketplaceNames = Object.keys(newMarketplaces)
+
+  // Only write extraKnownMarketplaces when there are non-built-in marketplaces
+  if (marketplaceNames.length > 0) {
+    merged.extraKnownMarketplaces = {
+      ...(existing.extraKnownMarketplaces || {}),
+      ...newMarketplaces,
+    }
+  }
+
+  await fse.ensureDir(path.dirname(settingsPath))
+  await fse.writeFile(settingsPath, JSON.stringify(merged, null, 2) + '\n', 'utf8')
+
+  logger.debug(`Claude Code: enabled ${enabledKeys.length} plugins in settings.json`)
+  if (marketplaceNames.length > 0) {
+    logger.debug(`Claude Code: registered ${marketplaceNames.length} extra marketplace(s): ${marketplaceNames.join(', ')}`)
+  }
+  return enabledKeys
+}
+
+// ─── Trae Installation ──────────────────────────────────────────────────────
+
+/**
+ * Install a category of plugin markdown files with adapter transformation.
+ *
+ * @param {string} srcDir - Source directory containing .md files
+ * @param {string} destDir - Destination directory
+ * @param {Function} adapter - Content transform function (content, filename) => content
+ * @param {object} variables - Interpolation variables
+ * @returns {Promise<number>} Number of files installed
+ */
+async function installPluginCategory(srcDir, destDir, adapter, variables) {
+  if (!await fse.pathExists(srcDir)) return 0
+
+  await fse.ensureDir(destDir)
+  const files = await listFiles(srcDir)
+  let count = 0
+
+  for (const relPath of files) {
+    if (!relPath.endsWith('.md')) continue
+    const srcFile = path.join(srcDir, relPath)
+    let content = await fse.readFile(srcFile, 'utf8')
+    content = interpolate(content, variables)
+
+    const destName = `${path.basename(relPath, '.md')}.md`
+    content = adapter(content, destName)
+    await fse.writeFile(path.join(destDir, destName), content, 'utf8')
+    count++
+  }
+
+  return count
+}
+
+/**
+ * Install plugins for Trae by extracting skills/commands/agents.
+ *
+ * @param {Array<{ id: string, def: object, templateDir: string }>} plugins - Resolved plugins with template paths
+ * @param {string} targetDir - Project root directory
+ * @param {object} variables - Interpolation variables
+ * @param {object} logger - Logger instance
+ * @returns {Promise<{ files: number, details: Array<{ id: string, skills: number, commands: number, agents: number }> }>}
+ */
+export async function installForTrae(plugins, targetDir, variables, logger) {
+  let totalFiles = 0
+  const details = []
+
+  for (const { id, templateDir } of plugins) {
+    try {
+      const counts = { skills: 0, commands: 0, agents: 0 }
+
+      // Skills → .trae/skills/<pluginId>/ (direct copy + interpolation)
+      const skillsSrc = path.join(templateDir, 'skills')
+      if (await fse.pathExists(skillsSrc)) {
+        const skillsDest = path.join(targetDir, '.trae', 'skills', id)
+        counts.skills = await copyWithInterpolation(skillsSrc, skillsDest, variables)
+        totalFiles += counts.skills
+      }
+
+      // Commands → .trae/rules/<pluginId>/commands/<name>.md (with adapter)
+      counts.commands = await installPluginCategory(
+        path.join(templateDir, 'commands'),
+        path.join(targetDir, '.trae', 'rules', id, 'commands'),
+        convertCommandForTrae,
+        variables
+      )
+      totalFiles += counts.commands
+
+      // Agents → .trae/rules/<pluginId>/agents/<name>.md (with adapter)
+      counts.agents = await installPluginCategory(
+        path.join(templateDir, 'agents'),
+        path.join(targetDir, '.trae', 'rules', id, 'agents'),
+        convertAgentForTrae,
+        variables
+      )
+      totalFiles += counts.agents
+
+      details.push({ id, ...counts })
+      logger.debug(`  Trae plugin "${id}": ${counts.skills} skills, ${counts.commands} commands, ${counts.agents} agents`)
+    } catch (err) {
+      throw new Error(`Failed to install Trae content for plugin "${id}": ${err.message}`)
+    }
+  }
+
+  return { files: totalFiles, details }
+}
+
+// ─── Main Entry ─────────────────────────────────────────────────────────────
+
+/**
+ * Install plugins for all selected IDEs.
+ *
+ * @param {{
+ *   plugins: Array<{ id: string, def: object, templateDir: string }>,
+ *   targetDir: string,
+ *   ides: string[],
+ *   variables: object,
+ *   logger: object
+ * }} opts
+ * @returns {Promise<{ claudeCode: string[], trae: object, installed: string[] }>}
+ */
+export async function installPlugins({ plugins, targetDir, ides, variables, logger }) {
+  const result = { claudeCode: [], trae: { files: 0, details: [] }, installed: [] }
+
+  // Claude Code: write settings.json (env defaults + plugin IDs + marketplace sources)
+  if (ides.includes('claude-code')) {
+    result.claudeCode = await installForClaudeCode(plugins, targetDir, logger)
+  }
+
+  // Trae: extract content from plugins that have templates
+  if (ides.includes('trae') && plugins.length > 0) {
+    const available = []
+    for (const p of plugins) {
+      if (await fse.pathExists(p.templateDir)) {
+        available.push(p)
+      } else {
+        logger.warn(`Plugin "${p.id}" template not found at ${p.templateDir}, skipping Trae extraction`)
+      }
+    }
+
+    if (available.length > 0) {
+      result.trae = await installForTrae(available, targetDir, variables, logger)
+    }
+  }
+
+  // Track all plugins as installed (settings.json counts even without templates)
+  result.installed = plugins.map(p => p.id)
+  return result
+}
+