@credibledata/cred-cli 0.0.102 → 0.0.103

package/src/commands/package/publish.spec.ts

@@ -50,14 +50,20 @@ describe("publish", () => {
       debug: boolean,
       autoConfirm: boolean,
       setLatest: boolean,
-      asyncIndexing?: boolean,
    ) => Promise<void>;
 
    // Store the original archiver module so we can restore it
    let originalArchiverModule: any;
    const archiverModulePath = require.resolve("archiver");
 
+   // publish reports failure by setting process.exitCode, so each test starts from a
+   // known 0 and the suite restores whatever the runner had — a leaked non-zero would
+   // fail the whole mocha run regardless of the assertions.
+   let originalExitCode: number | string | undefined;
+
    beforeEach(() => {
+      originalExitCode = process.exitCode;
+      process.exitCode = 0;
       sandbox = sinon.createSandbox();
 
       // Create mock archive
@@ -143,6 +149,7 @@ describe("publish", () => {
    });
 
    afterEach(() => {
+      process.exitCode = originalExitCode;
       sandbox.restore();
       // Restore original archiver module
       if (originalArchiverModule) {
@@ -184,14 +191,12 @@ describe("publish", () => {
       expect(createOrUpdatePackageStub.firstCall.args[2]).to.equal(
          "test-package",
       );
-      // arg[3] is the new `async` flag; package/version shift by one.
-      expect(createOrUpdatePackageStub.firstCall.args[3]).to.equal(false);
-      expect(createOrUpdatePackageStub.firstCall.args[4]).to.deep.include({
+      expect(createOrUpdatePackageStub.firstCall.args[3]).to.deep.include({
          name: "test-package",
          description: "Test package",
          replicationCount: 2,
       });
-      expect(createOrUpdatePackageStub.firstCall.args[5]).to.deep.include({
+      expect(createOrUpdatePackageStub.firstCall.args[4]).to.deep.include({
          id: "1.0.0",
       });
       expect(
@@ -220,7 +225,7 @@ describe("publish", () => {
 
       await publish("http://test-server", 2, false, true, true);
 
-      expect(createOrUpdatePackageStub.firstCall.args[4]).to.deep.include({
+      expect(createOrUpdatePackageStub.firstCall.args[3]).to.deep.include({
          latestVersion: "1.0.0",
       });
    });
@@ -244,7 +249,7 @@ describe("publish", () => {
 
       await publish("http://test-server", 2, false, true, false);
 
-      expect(createOrUpdatePackageStub.firstCall.args[4]).to.not.have.property(
+      expect(createOrUpdatePackageStub.firstCall.args[3]).to.not.have.property(
          "latestVersion",
       );
    });
@@ -318,7 +323,7 @@ describe("publish", () => {
 
       await publish("http://test-server", 2, false, true, false);
 
-      expect(createOrUpdatePackageStub.firstCall.args[7]).to.equal(
+      expect(createOrUpdatePackageStub.firstCall.args[6]).to.equal(
          expectedHash,
       );
    });
@@ -354,6 +359,10 @@ describe("publish", () => {
             sinon.match("Please, make sure that you are logged in"),
          ),
       ).to.be.true;
+      expect(
+         process.exitCode,
+         "a publish that never ran must not exit 0",
+      ).to.equal(1);
    });
 
    it("should handle invalid token", async () => {
@@ -390,6 +399,10 @@ describe("publish", () => {
             sinon.match("No token found. Please login."),
          ),
       ).to.be.true;
+      expect(
+         process.exitCode,
+         "a publish that never ran must not exit 0",
+      ).to.equal(1);
    });
 
    it("should handle invalid manifest", async () => {
@@ -398,6 +411,11 @@ describe("publish", () => {
       await publish("http://test-server", 2, false, true, false);
 
       expect(createOrUpdatePackageStub.called).to.be.false;
+      // validateManifest logs its own reason, so only the exit code is asserted here.
+      expect(
+         process.exitCode,
+         "a publish that never ran must not exit 0",
+      ).to.equal(1);
    });
 
    it("should handle missing organization", async () => {
@@ -443,6 +461,10 @@ describe("publish", () => {
             sinon.match("Please, make sure that you are logged in"),
          ),
       ).to.be.true;
+      expect(
+         process.exitCode,
+         "a publish that never ran must not exit 0",
+      ).to.equal(1);
    });
 
    it("should handle missing project", async () => {
@@ -484,6 +506,10 @@ describe("publish", () => {
             sinon.match("Please, make sure to set an environment"),
          ),
       ).to.be.true;
+      expect(
+         process.exitCode,
+         "a publish that never ran must not exit 0",
+      ).to.equal(1);
    });
 
    it("should handle missing publisher.json", async () => {
@@ -503,6 +529,10 @@ describe("publish", () => {
             ),
          ),
       ).to.be.true;
+      expect(
+         process.exitCode,
+         "a publish that never ran must not exit 0",
+      ).to.equal(1);
    });
 
    it("should request confirmation when autoConfirm is false", async function () {
@@ -544,6 +574,9 @@ describe("publish", () => {
       expect(createOrUpdatePackageStub.called).to.be.false;
       expect(loggerStub.info.calledWith(sinon.match("Operation cancelled."))).to
          .be.true;
+      // Declining the prompt is an answer, not a failure: it can only happen
+      // interactively, and a human who said no does not want a failed command.
+      expect(process.exitCode, "cancelling is not a failure").to.equal(0);
    });
 
    it("should handle API errors", async function () {
@@ -570,28 +603,10 @@ describe("publish", () => {
       expect(
          loggerStub.error.calledWith(sinon.match("Failed to publish package")),
       ).to.be.true;
-   });
-
-   it("should pass async=true to the API when asyncIndexing is set", async function () {
-      this.timeout(5000);
-      const mockManifest = {
-         name: "test-package",
-         version: "1.0.0",
-         description: "Test package",
-      };
-      const mockPackageData = Buffer.from("test package data");
-
-      readFileSyncStub.callsFake((filePath: string) => {
-         if (filePath === "publisher.json") return JSON.stringify(mockManifest);
-         return mockPackageData;
-      });
-      getConfirmationStub.resolves(true);
-      createOrUpdatePackageStub.resolves({ data: {} });
-      unlinkStub.callsArg(1);
-
-      await publish("http://test-server", 2, false, true, false, true);
-
-      expect(createOrUpdatePackageStub.firstCall.args[3]).to.equal(true);
+      // The log alone is not the contract: CI and scripts wrap `cred publish` and
+      // read its exit code, so a rejected publish exiting 0 reports success for a
+      // package that was never published.
+      expect(process.exitCode).to.equal(1);
    });
 
    it("should log package URL after successful publish", async function () {

package/src/commands/package/publish.ts

@@ -13,30 +13,48 @@ import { validateManifest } from "../../validator";
 const packagesApi = new PackagesApi(new Configuration());
 const PACKAGE_MANIFEST_NAME = "publisher.json";
 
+/**
+ * Record a publish failure: log it (when the caller has a message of its own to give)
+ * and mark the process failed.
+ *
+ * Every early return below is a publish that did not happen, so each one has to carry the
+ * same non-zero exit as a server rejection. CI and scripts wrap `cred publish` and read
+ * its exit code; exiting 0 tells them a package is there when it is not. Declining the
+ * confirmation prompt is deliberately NOT routed through here — that is an answer rather
+ * than a failure, and it can only happen interactively.
+ */
+function failPublish(message?: string): void {
+   if (message) {
+      logger.error(message);
+   }
+   process.exitCode = 1;
+}
+
 export async function publish(
    controlPlane: string,
    replicationCount: number,
    debug: boolean,
    autoConfirm: boolean,
    setLatest: boolean,
-   asyncIndexing: boolean = false,
 ) {
    const clientConfig = new ClientConfiguration();
 
    if (!clientConfig.doesConfigExists()) {
-      logger.error("Please, make sure that you are logged in");
+      failPublish("Please, make sure that you are logged in");
       return;
    }
 
    const tokenValidation = clientConfig.isTokenValid();
    if (!tokenValidation.valid) {
-      logger.error(
+      failPublish(
          tokenValidation.reason || "Please, make sure that you are logged in",
       );
       return;
    }
 
    if (!validateManifest()) {
+      // validateManifest logs its own reason; only the exit code is missing.
+      failPublish();
       return;
    }
 
@@ -44,17 +62,17 @@ export async function publish(
    const organizationName = clientConfig.getOrganization();
 
    if (!organizationName) {
-      logger.error("Please, make sure that you are logged in");
+      failPublish("Please, make sure that you are logged in");
       return;
    }
 
    if (!environmentName) {
-      logger.error("Please, make sure to set an environment");
+      failPublish("Please, make sure to set an environment");
       return;
    }
 
    if (!fs.existsSync(PACKAGE_MANIFEST_NAME)) {
-      logger.error(
+      failPublish(
          `Failed to publish the package. Could not find ${PACKAGE_MANIFEST_NAME}, please ensure you are in a directory containing ${PACKAGE_MANIFEST_NAME}`,
       );
       return;
@@ -90,7 +108,6 @@ export async function publish(
       packageManifest.version,
       debug,
       setLatest,
-      asyncIndexing,
    );
    await removeTmpPackage(tmpPackagePath);
 }
@@ -135,7 +152,6 @@ async function pushTmpPackageToRemoteServer(
    versionId: string,
    debug: boolean,
    setLatest: boolean,
-   asyncIndexing: boolean,
 ): Promise<undefined> {
    logger.info("Pushing package " + name + " version " + versionId);
 
@@ -180,11 +196,14 @@ async function pushTmpPackageToRemoteServer(
          organizationName,
          environmentName,
          name,
-         asyncIndexing,
          _package,
          version,
          packageContents,
          md5Hash,
+         // draftId / workspace: a zip upload has no git-backed draft, so the server
+         // records no provenance. Positional because `options` must stay last.
+         undefined,
+         undefined,
          {
             baseURL: controlPlane,
             headers: clientConfig.getHeaders(),
@@ -200,7 +219,9 @@ async function pushTmpPackageToRemoteServer(
       );
       logger.info(`Package available at: ${packageUrl}`);
    } catch (e) {
-      logger.error("Failed to publish package");
+      // The server rejected it: a model that does not compile, or a `#@ persist`
+      // declaration the publisher refuses to load.
+      failPublish("Failed to publish package");
       printOutError(e, debug);
    }
 }