@creator.co/wapi 1.3.19-alpha1 → 1.4.0-alpha1

package/tests/Database/integrations/pg/PostgresDatabase.test.ts

@@ -10,11 +10,15 @@ const config: DbConfig<'pg'> = {
   host: 'host',
   port: 1234,
   database: 'database',
-  driver: 'driver',
   maxConnections: 1,
   autoCommit: true,
 }
 
+const config2: DbConfig<'pg'> = {
+  ...config,
+  readReplica: config,
+}
+
 const expectedImplConfig = {
   host: config.host,
   port: config.port,
@@ -25,25 +29,47 @@ const expectedImplConfig = {
 }
 
 describe('PostgresDatabase', () => {
-  test('PostgresDatabase', async () => {
-    const mockTrans = {
+  let mockTrans
+  let mockClient
+  beforeEach(() => {
+    mockTrans = {
       query: jest.fn(() => {}),
     } as any
-    const mockClient = jest.fn(
+    mockClient = jest.fn(
       () =>
         ({
           connect: async () => mockTrans,
         }) as PoolClient
     )
     PostgresDatabase['pgProvider'] = mockClient as any
+  })
 
+  test('PostgresDatabase', async () => {
     const underTest = new PostgresDatabase(config)
-    expect(mockClient).toBeCalledWith(expectedImplConfig)
+    expect(mockClient).toHaveBeenNthCalledWith(1, expectedImplConfig)
+
+    const trans = await underTest.transaction()
+
+    expect(mockTrans.query).toBeCalledWith('BEGIN')
+    expect(trans.reader).toBeUndefined()
+    expect(trans.writer).toBeInstanceOf(Object)
+    expect(trans.writer.connect).toBeInstanceOf(Function)
+    expect(trans).toBeInstanceOf(Function)
+    expect(trans['transaction']).toBe(mockTrans)
+  })
+
+  test('PostgresDatabase - read replica', async () => {
+    const underTest = new PostgresDatabase(config2)
+    expect(mockClient).toHaveBeenNthCalledWith(2, expectedImplConfig)
 
     const trans = await underTest.transaction()
 
     expect(mockTrans.query).toBeCalledWith('BEGIN')
+    expect(trans.reader).toBeInstanceOf(Object)
+    expect(trans.reader.connect).toBeInstanceOf(Function)
+    expect(trans.writer).toBeInstanceOf(Object)
+    expect(trans.writer.connect).toBeInstanceOf(Function)
     expect(trans).toBeInstanceOf(Function)
-    expect(trans['delegate']).toBe(mockTrans)
+    expect(trans['transaction']).toBe(mockTrans)
   })
 })

package/tests/Database/integrations/pg/PostgresTransaction.test.ts

@@ -1,10 +1,10 @@
-import { PoolClient } from 'pg'
+import { Pool, PoolClient } from 'pg'
 
 import type { DbConfig } from '../../../../src/Database'
 import { PostgresDatabase } from '../../../../src/Database/integrations/pgsql/PostgresDatabase'
 import { PostgresTransactionImpl } from '../../../../src/Database/integrations/pgsql/PostgresTransaction'
 
-const testResources = (config: Partial<DbConfig<'pg'>>) => {
+const testResources = async (config: Partial<DbConfig<'pg'>>) => {
   const database = {
     config: {
       autoCommit: true,
@@ -12,7 +12,7 @@ const testResources = (config: Partial<DbConfig<'pg'>>) => {
     } as DbConfig<'pg'>,
   } as PostgresDatabase
 
-  const delegate = jest.fn().mockImplementation(() => {
+  const transaction = jest.fn().mockImplementation(() => {
     return {
       commit: jest.fn(),
       rollback: jest.fn(),
@@ -20,18 +20,35 @@ const testResources = (config: Partial<DbConfig<'pg'>>) => {
     }
   })() as any as PoolClient
 
+  const writer = jest.fn().mockImplementation(() => {
+    return {
+      connect: jest.fn(() => transaction),
+    }
+  })() as any as Pool
+
   return {
-    delegate,
-    underTest: PostgresTransactionImpl.wrapDelegate(delegate, database),
+    transaction,
+    writer,
+    underTest: await PostgresTransactionImpl.newTransaction(writer, database),
   }
 }
 
 describe('PostgresTransaction', () => {
+  test('Transaction starts opened', async () => {
+    const { transaction, underTest } = await testResources({})
+    expect(underTest.isOpen()).toBe(true)
+    expect(transaction.query).toHaveBeenNthCalledWith(1, 'BEGIN')
+
+    await expect(underTest.begin).rejects.toThrowError(
+      'Cannot begin, transaction is already opened!'
+    )
+  })
+
   test('Can only commit once', async () => {
-    const { delegate, underTest } = testResources({})
+    const { transaction, underTest } = await testResources({})
     await underTest.commit()
     expect(underTest.isOpen()).toBe(false)
-    expect(delegate.query).toBeCalledWith('COMMIT')
+    expect(transaction.query).toBeCalledWith('COMMIT')
 
     await expect(underTest.commit).rejects.toThrowError(
       'Cannot commit, transaction is already closed!'
@@ -39,13 +56,62 @@ describe('PostgresTransaction', () => {
   })
 
   test('Can only rollback once', async () => {
-    const { delegate, underTest } = testResources({})
+    const { transaction, underTest } = await testResources({})
     await underTest.rollback()
     expect(underTest.isOpen()).toBe(false)
-    expect(delegate.query).toBeCalledWith('ROLLBACK')
+    expect(transaction.query).toBeCalledWith('ROLLBACK')
 
     await expect(underTest.rollback).rejects.toThrowError(
       'Cannot rollback, transaction is already closed!'
     )
   })
+
+  test("Can't open transaction twice", async () => {
+    const { transaction, underTest } = await testResources({})
+    expect(underTest.isOpen()).toBe(true)
+    expect(transaction.query).toHaveBeenNthCalledWith(1, 'BEGIN')
+
+    await expect(underTest.begin).rejects.toThrowError(
+      'Cannot begin, transaction is already opened!'
+    )
+  })
+
+  test('Can commit, begin and commit again ', async () => {
+    const { transaction, underTest } = await testResources({})
+    await underTest.commit()
+    expect(underTest.isOpen()).toBe(false)
+    expect(transaction.query).toBeCalledWith('COMMIT')
+    await underTest.begin()
+    expect(underTest.isOpen()).toBe(true)
+    expect(transaction.query).toHaveBeenNthCalledWith(3, 'BEGIN')
+    await underTest.commit()
+    expect(underTest.isOpen()).toBe(false)
+    expect(transaction.query).toHaveBeenNthCalledWith(4, 'COMMIT')
+  })
+
+  test('Can commit, begin and rollback ', async () => {
+    const { transaction, underTest } = await testResources({})
+    await underTest.commit()
+    expect(underTest.isOpen()).toBe(false)
+    expect(transaction.query).toBeCalledWith('COMMIT')
+    await underTest.begin()
+    expect(underTest.isOpen()).toBe(true)
+    expect(transaction.query).toHaveBeenNthCalledWith(3, 'BEGIN')
+    await underTest.rollback()
+    expect(underTest.isOpen()).toBe(false)
+    expect(transaction.query).toHaveBeenNthCalledWith(4, 'ROLLBACK')
+  })
+
+  test('Can rollback, begin and commit ', async () => {
+    const { transaction, underTest } = await testResources({})
+    await underTest.rollback()
+    expect(underTest.isOpen()).toBe(false)
+    expect(transaction.query).toBeCalledWith('ROLLBACK')
+    await underTest.begin()
+    expect(underTest.isOpen()).toBe(true)
+    expect(transaction.query).toHaveBeenNthCalledWith(3, 'BEGIN')
+    await underTest.commit()
+    expect(underTest.isOpen()).toBe(false)
+    expect(transaction.query).toHaveBeenNthCalledWith(4, 'COMMIT')
+  })
 })

package/tsconfig.json

@@ -15,6 +15,7 @@
     "target": "es5",
     "outDir": "dist",
     "declaration": true,
+    "skipLibCheck": true,
     "strictNullChecks": true
   }
 }