@createiq/htmldiff 1.2.0-beta.2 → 1.2.0-beta.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@createiq/htmldiff",
-  "version": "1.2.0-beta.2",
+  "version": "1.2.0-beta.3",
   "description": "TypeScript port of htmldiff.net",
   "type": "module",
   "author": "Mathew Mannion <mathew.mannion@linklaters.com>",

package/src/ThreeWayTable.ts

@@ -303,7 +303,21 @@ function preprocessByContent(
   return { modifiedGenesis, modifiedCp, modifiedMe, placeholderToDiff }
 }
 
-const POSITIONAL_PAIR_SIMILARITY_THRESHOLD = 0.5
+// Positional pairing is the strict-default for three-way table merge:
+// when all three inputs have the same number of tables in the same
+// order, we pair them by index and let `diffTableThreeWay` handle
+// per-table cell/row level differences. The similarity guard below
+// only kicks in to *reject* positional alignment when a pair is
+// SO dissimilar that it's near-certainly a table reorder/rename
+// where content-LCS pairing would be materially better. The
+// threshold is intentionally low — the 2-way path has no such guard
+// and pairs purely by index (its `diffTable` falls back through
+// same-dimension → equal-row-count → row-LCS → whole-table on its
+// own), so the three-way path was stricter than its sibling and
+// silently dropped to whole-table del+ins for legitimate edits
+// like "rename one column and tweak its values". Aligning the
+// threshold here keeps the two-way and three-way paths in step.
+const POSITIONAL_PAIR_SIMILARITY_THRESHOLD = 0.15
 
 function positionallyAligned(
   genesis: string,

package/test/HtmlDiff.threeWay.tables.spec.ts

@@ -298,4 +298,30 @@ describe('HtmlDiff.executeThreeWay (tables, genesis-spine)', () => {
       expect(HtmlDiff.executeThreeWay('<p>a</p>', '<p>a</p>', '<p>a</p>')).toBe('<p>a</p>')
     })
   })
+
+  describe('positional pairing under moderate dissimilarity', () => {
+    it('column rename + value rewrite still routes through cell-level diff (not whole-table del+ins)', () => {
+      // Real-world regression: cp renamed a column ("Form/Document/Certificate"
+      // → "Extra column") and replaced the values in that column with short
+      // tokens. Word-level Jaccard between the genesis table and cp's edited
+      // table drops to ~0.38 — under the 0.5 threshold the three-way path
+      // used to take, which kicked the diff into multi-table content-LCS
+      // and produced whole-table del+ins (the cp's CP-bubble showed the
+      // entire old table struck through and the entire new table inserted).
+      // 2-way had no such guard and produced a cell-level diff for the same
+      // inputs; lowering the 3-way threshold brings the two paths in step.
+      const genesis =
+        '<table><tr><td>A</td><td>Form/Document/Certificate</td><td>Date</td></tr><tr><td>Party A</td><td>IRS W-8</td><td>On execution</td></tr></table>'
+      const cp =
+        '<table><tr><td>A</td><td>Extra column</td><td>Date</td></tr><tr><td>Party A</td><td>Yes</td><td>On execution</td></tr></table>'
+      const me = genesis
+      const out = HtmlDiff.executeThreeWay(genesis, cp, me)
+      // Expect cell-level cp attribution INSIDE the table cells, NOT a
+      // whole-table del+ins wrapping the entire <table>.
+      expect(out).not.toMatch(/<del[^>]*><table/)
+      expect(out).toMatch(/data-author='cp'/)
+      expect(out).toContain('Extra column')
+      expect(out).toContain('Form/Document/Certificate')
+    })
+  })
 })