@createiq/htmldiff 1.0.5-beta.3 → 1.0.5

package/src/HtmlDiff.ts

@@ -2,7 +2,6 @@ import Action from './Action'
 import Match from './Match'
 import MatchFinder from './MatchFinder'
 import Operation from './Operation'
-import { preprocessTables, restoreTablePlaceholders } from './TableDiff'
 import Utils from './Utils'
 import WordSplitter from './WordSplitter'
 
@@ -65,21 +64,9 @@ export default class HtmlDiff {
     'span',
   ])
 
-  /**
-   * Hard cap on nested `HtmlDiff.execute` calls (table preprocessing
-   * recurses through `diffCell` for cell content). Each level allocates
-   * fresh DP matrices and word arrays; without a guard a maliciously
-   * nested table-in-cell-in-table-in-cell input could blow stack and
-   * memory. Set high enough to comfortably handle real legal documents
-   * (tables nested 2-3 deep at most), low enough to short-circuit
-   * pathological input.
-   */
-  private static MaxTablePreprocessDepth = 8
-
   private content: string[] = []
   private newText: string
   private oldText: string
-  private readonly tablePreprocessDepth: number
 
   private specialTagDiffStack: string[] = []
   private newWords: string[] = []
@@ -147,18 +134,14 @@ export default class HtmlDiff {
    * Initializes a new instance of the class.
    * @param oldText The old text.
    * @param newText The new text.
-   * @param tablePreprocessDepth Internal: nested-call depth for table
-   *   preprocessing. Callers should leave at default (0); the recursive
-   *   `diffCell` callback in TableDiff bumps it.
    */
-  constructor(oldText: string, newText: string, tablePreprocessDepth = 0) {
+  constructor(oldText: string, newText: string) {
     this.oldText = oldText
     this.newText = newText
-    this.tablePreprocessDepth = tablePreprocessDepth
   }
 
-  static execute(oldText: string, newText: string, tablePreprocessDepth = 0) {
-    return new HtmlDiff(oldText, newText, tablePreprocessDepth).build()
+  static execute(oldText: string, newText: string) {
+    return new HtmlDiff(oldText, newText).build()
   }
 
   /**
@@ -171,34 +154,6 @@ export default class HtmlDiff {
       return this.newText
     }
 
-    // Table preprocessing: when both sides have matching `<table>` structures,
-    // diff cells positionally so cross-cell content shifts produce one
-    // independent del/ins per cell rather than cell-misaligned output.
-    // Recursion guarded by MaxTablePreprocessDepth to bound work on
-    // deeply-nested table-in-cell-in-table inputs. Caller-configured
-    // settings (block expressions, accuracy thresholds) are propagated to
-    // the recursive cell diff so cell-level output is consistent with the
-    // top-level configuration.
-    const blockExpressions = this.blockExpressions
-    const repeatingWordsAccuracy = this.repeatingWordsAccuracy
-    const orphanMatchThreshold = this.orphanMatchThreshold
-    const ignoreWhitespaceDifferences = this.ignoreWhitespaceDifferences
-    const tablePreprocess =
-      this.tablePreprocessDepth >= HtmlDiff.MaxTablePreprocessDepth
-        ? null
-        : preprocessTables(this.oldText, this.newText, (oldCell, newCell) => {
-            const inner = new HtmlDiff(oldCell, newCell, this.tablePreprocessDepth + 1)
-            for (const expr of blockExpressions) inner.addBlockExpression(expr)
-            inner.repeatingWordsAccuracy = repeatingWordsAccuracy
-            inner.orphanMatchThreshold = orphanMatchThreshold
-            inner.ignoreWhitespaceDifferences = ignoreWhitespaceDifferences
-            return inner.build()
-          })
-    if (tablePreprocess) {
-      this.oldText = tablePreprocess.modifiedOld
-      this.newText = tablePreprocess.modifiedNew
-    }
-
     this.splitInputsToWords()
     this.buildContentProjections()
 
@@ -215,8 +170,7 @@ export default class HtmlDiff {
       this.performOperation(op)
     }
 
-    const result = this.content.join('')
-    return tablePreprocess ? restoreTablePlaceholders(result, tablePreprocess.placeholderToDiff) : result
+    return this.content.join('')
   }
 
   /**
@@ -563,7 +517,7 @@ export default class HtmlDiff {
         const openingAndClosingTagsMatch =
           !!openingTag && Utils.getTagName(openingTag) === Utils.getTagName(words[tagIndexToCompare])
 
-        if (openingTag && openingAndClosingTagsMatch) {
+        if (!!openingTag && openingAndClosingTagsMatch) {
           specialCaseTagInjection = '</ins>'
           specialCaseTagInjectionIsBefore = true
         }

package/test/HtmlDiff.spec.ts

@@ -51,7 +51,7 @@ describe('HtmlDiff', () => {
     [
       '<table><tr><td>col1</td><td>col2</td></tr><tr><td>Data 1</td><td>Data 2</td></tr></table>',
       '<table><tr><td>col1</td><td>col2</td></tr></table>',
-      "<table><tr><td>col1</td><td>col2</td></tr><tr class='diffdel'><td class='diffdel'><del class='diffdel'>Data 1</del></td><td class='diffdel'><del class='diffdel'>Data 2</del></td></tr></table>",
+      "<table><tr><td>col1</td><td>col2</td></tr><tr><td><del class='diffdel'>Data 1</del></td><td><del class='diffdel'>Data 2</del></td></tr></table>",
     ],
     [
       'text',

package/.claude/settings.local.json

@@ -1,15 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "Bash(diff -u test/input1.html test/input2.html)",
-      "Bash(npm test -- test/Bug.spec.tsx)",
-      "Bash(timeout 30s npm run test:ci -- test/Bug.spec.tsx)",
-      "Bash(npm run build)",
-      "Bash(timeout 10s npm run test:ci -- test/Bug.spec.tsx)",
-      "Bash(npm run lint)",
-      "Bash(npm run test:ci)",
-      "Bash(npm run bench:ci)"
-    ],
-    "deny": []
-  }
-}