@creact-labs/creact 0.2.7 → 0.2.9

package/dist/primitives/instance.js

@@ -26,7 +26,7 @@ function shallowEqual(a, b) {
 }
 // Registry of all instance nodes by ID
 const nodeRegistry = new Map();
-// Track which fiber owns each nodeId (to detect duplicate siblings)
+// Track which fiber path owns each nodeId (to detect duplicate siblings)
 const nodeOwnership = new Map();
 // Output hydration map - populated before render to restore outputs from previous run
 const outputHydrationMap = new Map();
@@ -99,16 +99,17 @@ export function useInstance(construct, props) {
     }
     const constructType = construct.name || 'Unknown';
     // Check for duplicate siblings (requires keys)
-    // Allow same fiber to re-register (reactive re-render), but not different fibers
-    const existingOwner = nodeOwnership.get(nodeId);
-    if (existingOwner && existingOwner !== fiber) {
+    // Allow same fiber path to re-register (reactive re-render), but not different paths
+    const existingOwnerPath = nodeOwnership.get(nodeId);
+    const currentFiberPath = fiber.path.join('.');
+    if (existingOwnerPath && existingOwnerPath !== currentFiberPath) {
         throw new Error(`Multiple instances of ${constructType} at the same level require unique keys.\n` +
             `Add a key prop to differentiate them:\n\n` +
             `  {items.map((item) => (\n` +
             `    <MyResource key={item.id} ... />\n` +
             `  ))}`);
     }
-    nodeOwnership.set(nodeId, fiber);
+    nodeOwnership.set(nodeId, currentFiberPath);
     // Create or get existing node
     let node = nodeRegistry.get(nodeId);
     if (!node) {
@@ -121,9 +122,23 @@ export function useInstance(construct, props) {
             outputSignals: new Map(),
             children: [],
             setOutputs(outputs) {
-                // Clear ownership before batch triggers re-renders
-                // When signals update, components re-execute and create new fibers
-                // that need to claim the same nodeIds
+                // First check if any values actually changed
+                let hasChanges = false;
+                for (const [key, value] of Object.entries(outputs)) {
+                    if (!this.outputSignals.has(key)) {
+                        hasChanges = true;
+                        break;
+                    }
+                    const [read] = this.outputSignals.get(key);
+                    if (!shallowEqual(read(), value)) {
+                        hasChanges = true;
+                        break;
+                    }
+                }
+                // Early exit if nothing changed - no re-render needed
+                if (!hasChanges)
+                    return;
+                // Only clear ownership and batch if there are actual changes
                 nodeOwnership.clear();
                 batch(() => {
                     for (const [key, value] of Object.entries(outputs)) {
@@ -132,7 +147,6 @@ export function useInstance(construct, props) {
                         }
                         else {
                             const [read, write] = this.outputSignals.get(key);
-                            // Only update if value actually changed
                             if (!shallowEqual(read(), value)) {
                                 write(value);
                             }
@@ -214,15 +228,28 @@ export function fillInstanceOutputs(nodeId, outputs) {
     const node = nodeRegistry.get(nodeId);
     if (!node)
         return;
-    // Clear ownership before batch triggers re-renders
-    // When signals update, components re-execute and create new fibers
-    // that need to claim the same nodeIds
+    // First check if any values actually changed
+    let hasChanges = false;
+    for (const [key, value] of Object.entries(outputs)) {
+        if (!node.outputSignals.has(key)) {
+            hasChanges = true;
+            break;
+        }
+        const [read] = node.outputSignals.get(key);
+        if (!shallowEqual(read(), value)) {
+            hasChanges = true;
+            break;
+        }
+    }
+    // Early exit if nothing changed - no re-render needed
+    if (!hasChanges)
+        return;
+    // Only clear ownership and batch if there are actual changes
     nodeOwnership.clear();
     batch(() => {
         for (const [key, value] of Object.entries(outputs)) {
             if (node.outputSignals.has(key)) {
                 const [read, write] = node.outputSignals.get(key);
-                // Only update if value actually changed
                 if (!shallowEqual(read(), value)) {
                     write(value);
                 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@creact-labs/creact",
-  "version": "0.2.7",
+  "version": "0.2.9",
   "type": "module",
   "description": "Declarative universal reactive runtime",
   "main": "dist/index.js",