@crawlee/core 4.0.0-beta.11 → 4.0.0-beta.110

package/autoscaling/autoscaled_pool.js

@@ -1,31 +1,23 @@
 import ow from 'ow';
 import { addTimeoutToPromise } from '@apify/timeout';
 import { betterClearInterval, betterSetInterval } from '@apify/utilities';
-import { Configuration } from '../configuration.js';
 import { CriticalError } from '../errors.js';
-import { log as defaultLog } from '../log.js';
-import { Snapshotter } from './snapshotter.js';
-import { SystemStatus } from './system_status.js';
+import { serviceLocator } from '../service_locator.js';
 /**
  * Manages a pool of asynchronous resource-intensive tasks that are executed in parallel.
- * The pool only starts new tasks if there is enough free CPU and memory available
- * and the Javascript event loop is not blocked.
- *
- * The information about the CPU and memory usage is obtained by the {@link Snapshotter} class,
- * which makes regular snapshots of system resources that may be either local
- * or from the Apify cloud infrastructure in case the process is running on the Apify platform.
- * Meaningful data gathered from these snapshots is provided to `AutoscaledPool` by the {@link SystemStatus} class.
+ * The pool only starts new tasks while its {@link IConcurrencySystem|concurrency system} reports free capacity —
+ * that governor is what monitors CPU, memory and event loop load and autoscales the concurrency budget.
  *
  * Before running the pool, you need to implement the following three functions:
- * {@link AutoscaledPoolOptions.runTaskFunction},
- * {@link AutoscaledPoolOptions.isTaskReadyFunction} and
- * {@link AutoscaledPoolOptions.isFinishedFunction}.
+ * {@link AutoscaledPoolOptions.runTaskFunction|`runTaskFunction`},
+ * {@link TaskLoopPredicates.isTaskReadyFunction|`isTaskReadyFunction`} and
+ * {@link TaskLoopPredicates.isFinishedFunction|`isFinishedFunction`}.
  *
  * The auto-scaled pool is started by calling the {@link AutoscaledPool.run} function.
- * The pool periodically queries the {@link AutoscaledPoolOptions.isTaskReadyFunction} function
- * for more tasks, managing optimal concurrency, until the function resolves to `false`. The pool then queries
- * the {@link AutoscaledPoolOptions.isFinishedFunction}. If it resolves to `true`, the run finishes after all running tasks complete.
- * If it resolves to `false`, it assumes there will be more tasks available later and keeps periodically querying for tasks.
+ * The pool periodically queries `isTaskReadyFunction` for more tasks, managing optimal concurrency, until the function
+ * resolves to `false`. The pool then queries `isFinishedFunction`. If it resolves to `true`, the run finishes after all
+ * running tasks complete. If it resolves to `false`, it assumes there will be more tasks available later and keeps
+ * periodically querying for tasks.
  * If any of the tasks throws then the {@link AutoscaledPool.run} function rejects the promise with an error.
  *
  * The pool evaluates whether it should start a new task every time one of the tasks finishes
@@ -34,8 +26,12 @@ import { SystemStatus } from './system_status.js';
  * **Example usage:**
  *
  * ```javascript
+ * const concurrencySystem = new ConcurrencySystem({ maxConcurrency: 50 });
+ * await concurrencySystem.start();
+ *
  * const pool = new AutoscaledPool({
- *     maxConcurrency: 50,
+ *     concurrencySystem,
+ *     consumer: { id: 'my-pool' },
  *     runTaskFunction: async () => {
  *         // Run some resource-intensive asynchronous operation here.
  *     },
@@ -50,177 +46,116 @@ import { SystemStatus } from './system_status.js';
  *     }
  * });
  *
- * await pool.run();
+ * try {
+ *     await pool.run();
+ * } finally {
+ *     await concurrencySystem.stop();
+ * }
  * ```
- * @category Scaling
+ *
+ * @internal
  */
 export class AutoscaledPool {
-    config;
-    log;
+    #log;
     // Configurable properties.
-    desiredConcurrencyRatio;
-    scaleUpStepRatio;
-    scaleDownStepRatio;
-    maybeRunIntervalMillis;
-    loggingIntervalMillis;
-    autoscaleIntervalMillis;
-    taskTimeoutMillis;
-    runTaskFunction;
-    isFinishedFunction;
-    isTaskReadyFunction;
-    maxTasksPerMinute;
+    #maybeRunIntervalMillis;
+    #taskTimeoutMillis;
+    #runTaskFunction;
+    #isFinishedFunction;
+    #isTaskReadyFunction;
+    #concurrencySystem;
+    #consumer;
     // Internal properties.
-    _minConcurrency;
-    _maxConcurrency;
-    _desiredConcurrency;
-    _currentConcurrency = 0;
-    isStopped = false;
-    lastLoggingTime;
-    resolve = null;
-    reject = null;
-    snapshotter;
-    systemStatus;
-    autoscaleInterval;
-    maybeRunInterval;
-    queryingIsTaskReady;
-    queryingIsFinished;
-    tasksDonePerSecondInterval;
-    _tasksPerMinute = Array.from({ length: 60 }, () => 0);
-    constructor(options, config = Configuration.getGlobalConfig()) {
-        this.config = config;
+    #isStopped = false;
+    #resolve = null;
+    #reject = null;
+    #maybeRunInterval;
+    #queryingIsTaskReady;
+    #queryingIsFinished;
+    /**
+     * This pool's *own* in-flight task count, as opposed to {@link AutoscaledPool.currentConcurrency}, which is the
+     * (possibly shared) governor's total. `pause()` and `maybeFinish()` care only about this pool draining.
+     */
+    #ownConcurrency = 0;
+    constructor(options) {
         ow(options, ow.object.exactShape({
             runTaskFunction: ow.function,
             isFinishedFunction: ow.function,
             isTaskReadyFunction: ow.function,
-            maxConcurrency: ow.optional.number.integer.greaterThanOrEqual(1),
-            minConcurrency: ow.optional.number.integer.greaterThanOrEqual(1),
-            desiredConcurrency: ow.optional.number.integer.greaterThanOrEqual(1),
-            desiredConcurrencyRatio: ow.optional.number.greaterThan(0).lessThan(1),
-            scaleUpStepRatio: ow.optional.number.greaterThan(0).lessThan(1),
-            scaleDownStepRatio: ow.optional.number.greaterThan(0).lessThan(1),
             maybeRunIntervalSecs: ow.optional.number.greaterThan(0),
-            loggingIntervalSecs: ow.any(ow.number.greaterThan(0), ow.nullOrUndefined),
-            autoscaleIntervalSecs: ow.optional.number.greaterThan(0),
             taskTimeoutSecs: ow.optional.number.greaterThanOrEqual(0),
-            systemStatusOptions: ow.optional.object,
-            snapshotterOptions: ow.optional.object,
             log: ow.optional.object,
-            maxTasksPerMinute: ow.optional.number.integerOrInfinite.greaterThanOrEqual(1),
+            concurrencySystem: ow.object,
+            consumer: ow.object.partialShape({ id: ow.string.nonEmpty }),
         }));
-        const { runTaskFunction, isFinishedFunction, isTaskReadyFunction, maxConcurrency = 200, minConcurrency = 1, desiredConcurrency, desiredConcurrencyRatio = 0.9, scaleUpStepRatio = 0.05, scaleDownStepRatio = 0.05, maybeRunIntervalSecs = 0.5, loggingIntervalSecs = 60, taskTimeoutSecs = 0, autoscaleIntervalSecs = 10, systemStatusOptions, snapshotterOptions, log = defaultLog, maxTasksPerMinute = Infinity, } = options;
-        this.log = log.child({ prefix: 'AutoscaledPool' });
+        const { runTaskFunction, isFinishedFunction, isTaskReadyFunction, maybeRunIntervalSecs = 0.5, taskTimeoutSecs = 0, log = serviceLocator.getLogger(), concurrencySystem, consumer, } = options;
+        this.#log = log.child({ prefix: 'AutoscaledPool' });
         // Configurable properties.
-        this.desiredConcurrencyRatio = desiredConcurrencyRatio;
-        this.scaleUpStepRatio = scaleUpStepRatio;
-        this.scaleDownStepRatio = scaleDownStepRatio;
-        this.maybeRunIntervalMillis = maybeRunIntervalSecs * 1000;
-        this.loggingIntervalMillis = loggingIntervalSecs * 1000;
-        this.autoscaleIntervalMillis = autoscaleIntervalSecs * 1000;
-        this.taskTimeoutMillis = taskTimeoutSecs * 1000;
-        this.runTaskFunction = runTaskFunction;
-        this.isFinishedFunction = isFinishedFunction;
-        this.isTaskReadyFunction = isTaskReadyFunction;
-        this.maxTasksPerMinute = maxTasksPerMinute;
+        this.#maybeRunIntervalMillis = maybeRunIntervalSecs * 1000;
+        this.#taskTimeoutMillis = taskTimeoutSecs * 1000;
+        this.#runTaskFunction = runTaskFunction;
+        this.#isFinishedFunction = isFinishedFunction;
+        this.#isTaskReadyFunction = isTaskReadyFunction;
+        this.#concurrencySystem = concurrencySystem;
+        this.#consumer = consumer;
         // Internal properties.
-        this._minConcurrency = minConcurrency;
-        this._maxConcurrency = maxConcurrency;
-        this._desiredConcurrency = Math.min(desiredConcurrency ?? minConcurrency, maxConcurrency);
-        this._currentConcurrency = 0;
-        this.isStopped = false;
-        this.resolve = null;
-        this.reject = null;
-        this._autoscale = this._autoscale.bind(this);
-        this._maybeRunTask = this._maybeRunTask.bind(this);
-        this._incrementTasksDonePerSecond = this._incrementTasksDonePerSecond.bind(this);
-        // Create instances with correct options.
-        const ssoCopy = { ...systemStatusOptions };
-        ssoCopy.snapshotter ??= new Snapshotter({
-            ...snapshotterOptions,
-            log: this.log,
-            config: this.config,
-            client: this.config.getStorageClient(),
-        });
-        ssoCopy.config ??= this.config;
-        this.snapshotter = ssoCopy.snapshotter;
-        this.systemStatus = new SystemStatus(ssoCopy);
+        this.#isStopped = false;
+        this.#resolve = null;
+        this.#reject = null;
+        this.maybeRunTask = this.maybeRunTask.bind(this);
     }
     /**
-     * Gets the minimum number of tasks running in parallel.
-     */
-    get minConcurrency() {
-        return this._minConcurrency;
-    }
-    /**
-     * Sets the minimum number of tasks running in parallel.
+     * The governor backing this pool, as supplied to the constructor — exposed as the read-only
+     * {@link IConcurrencySystem} contract.
      *
-     * *WARNING:* If you set this value too high with respect to the available system memory and CPU, your code might run extremely slow or crash.
-     * If you're not sure, just keep the default value and the concurrency will scale up automatically.
-     */
-    set minConcurrency(value) {
-        ow(value, ow.optional.number.integer.greaterThanOrEqual(1));
-        this._minConcurrency = value;
-    }
-    /**
-     * Gets the maximum number of tasks running in parallel.
+     * This and the two getters below are telemetry only: concurrency is configured and tuned on the concrete
+     * {@link ConcurrencySystem} its owner holds, never through the pool.
      */
-    get maxConcurrency() {
-        return this._maxConcurrency;
+    get system() {
+        return this.#concurrencySystem;
     }
-    /**
-     * Sets the maximum number of tasks running in parallel.
-     */
-    set maxConcurrency(value) {
-        ow(value, ow.optional.number.integer.greaterThanOrEqual(1));
-        this._maxConcurrency = value;
-    }
-    /**
-     * Gets the desired concurrency for the pool,
-     * which is an estimated number of parallel tasks that the system can currently support.
-     */
+    /** The estimated number of parallel tasks the governor can currently support. */
     get desiredConcurrency() {
-        return this._desiredConcurrency;
-    }
-    /**
-     * Sets the desired concurrency for the pool, i.e. the number of tasks that should be running
-     * in parallel if there's large enough supply of tasks.
-     */
-    set desiredConcurrency(value) {
-        ow(value, ow.optional.number.integer.greaterThanOrEqual(1));
-        this._desiredConcurrency = value;
+        return this.#concurrencySystem.desiredConcurrency;
     }
     /**
-     * Gets the number of parallel tasks currently running in the pool.
+     * The number of parallel tasks currently booked against the governor. When it is shared, this counts every
+     * borrowing pool's tasks, not just this one's.
      */
     get currentConcurrency() {
-        return this._currentConcurrency;
+        return this.#concurrencySystem.currentConcurrency;
     }
     /**
      * Runs the auto-scaled pool. Returns a promise that gets resolved or rejected once
      * all the tasks are finished or one of them fails.
+     *
+     * Throws if the {@link IConcurrencySystem|concurrency system} it borrows was never started — the pool assumes
+     * a running governor and cannot start one it does not own.
      */
     async run() {
+        // Checked here, on an awaited path — the capacity queries inside the task loop run from intervals and
+        // `setImmediate`, where a throw would become an unhandled rejection and hang `run()` forever.
+        if (!this.#concurrencySystem.isRunning) {
+            throw new CriticalError('The ConcurrencySystem this AutoscaledPool borrows has not been started, so system load would not be ' +
+                'monitored and the concurrency would never be adjusted. Whoever creates a ConcurrencySystem owns ' +
+                'its lifecycle: call `await concurrencySystem.start()` before running the pools or crawlers that ' +
+                'use it, and `await concurrencySystem.stop()` once they are all done.');
+        }
         const poolPromise = new Promise((resolve, reject) => {
-            this.resolve = resolve;
-            this.reject = reject;
+            this.#resolve = resolve;
+            this.#reject = reject;
         });
-        await this.snapshotter.start();
-        // This interval checks the system status and updates the desired concurrency accordingly.
-        this.autoscaleInterval = betterSetInterval(this._autoscale, this.autoscaleIntervalMillis);
         // This is here because if we scale down to let's say 1, then after each promise is finished
-        // this._maybeRunTask() doesn't trigger another one. So if that 1 instance gets stuck it results
+        // this.maybeRunTask() doesn't trigger another one. So if that 1 instance gets stuck it results
         // in the crawler getting stuck and even after scaling up it never triggers another promise.
-        this.maybeRunInterval = betterSetInterval(this._maybeRunTask, this.maybeRunIntervalMillis);
-        if (this.maxTasksPerMinute !== Infinity) {
-            // Start the interval that resets the counter of tasks per minute.
-            this.tasksDonePerSecondInterval = betterSetInterval(this._incrementTasksDonePerSecond, 1000);
-        }
+        this.#maybeRunInterval = betterSetInterval(this.maybeRunTask, this.#maybeRunIntervalMillis);
         try {
             await poolPromise;
         }
         finally {
             // If resolve is null, the pool is already destroyed.
-            if (this.resolve)
-                await this._destroy();
+            if (this.#resolve)
+                await this.destroy();
         }
     }
     /**
@@ -235,10 +170,10 @@ export class AutoscaledPool {
      * parts of their asynchronous chains of commands will not execute.
      */
     async abort() {
-        this.isStopped = true;
-        if (this.resolve) {
-            this.resolve();
-            await this._destroy();
+        this.#isStopped = true;
+        if (this.#resolve) {
+            this.#resolve();
+            await this.destroy();
         }
     }
     /**
@@ -251,29 +186,36 @@ export class AutoscaledPool {
      *
      * The promise returned from the {@link AutoscaledPool.run} function will not resolve
      * when `.pause()` is invoked (unlike abort, which resolves it).
+     *
+     * > *NOTE:* Pausing the pool does not suspend the (possibly shared) {@link ConcurrencySystem} — its
+     * autoscaling and resource monitoring keep running, since other pools borrowing it may still be active. To silence
+     * it during a long pause, its owner can `stop()` and `start()` it again.
      */
     async pause(timeoutSecs) {
-        if (this.isStopped)
+        if (this.#isStopped)
             return;
-        this.isStopped = true;
+        this.#isStopped = true;
         await new Promise((resolve, reject) => {
             let timeout;
+            let interval;
             if (timeoutSecs) {
                 timeout = setTimeout(() => {
+                    // Clean up the polling interval to prevent it from leaking on timeout.
+                    clearInterval(interval);
                     const err = new Error("The pool's running tasks did not finish" +
                         `in ${timeoutSecs} secs after pool.pause() invocation.`);
                     reject(err);
                 }, timeoutSecs);
             }
-            const interval = setInterval(() => {
-                if (this._currentConcurrency <= 0) {
+            interval = setInterval(() => {
+                if (this.#ownConcurrency <= 0) {
                     // Clean up timeout and interval to prevent process hanging.
                     if (timeout)
                         clearTimeout(timeout);
                     clearInterval(interval);
                     resolve();
                 }
-            }, this.maybeRunIntervalMillis);
+            }, this.#maybeRunIntervalMillis);
         });
     }
     /**
@@ -283,251 +225,154 @@ export class AutoscaledPool {
      * Tasks will automatically start running again in `options.maybeRunIntervalSecs`.
      */
     resume() {
-        this.isStopped = false;
+        this.#isStopped = false;
     }
     /**
      * Explicitly check the queue for new tasks. The AutoscaledPool checks the queue for new tasks periodically,
      * every `maybeRunIntervalSecs` seconds. If you want to trigger the processing immediately, use this method.
      */
     async notify() {
-        setImmediate(this._maybeRunTask);
+        setImmediate(this.maybeRunTask);
     }
     /**
      * Starts a new task
      * if the number of running tasks (current concurrency) is lower than desired concurrency
      * and the system is not currently overloaded
-     * and this.isTaskReadyFunction() returns true.
+     * and `isTaskReadyFunction()` returns true.
      *
      * It doesn't allow multiple concurrent runs of this method.
      */
-    async _maybeRunTask(intervalCallback) {
-        this.log.perf('Attempting to run a task.');
+    async maybeRunTask(intervalCallback) {
+        this.#log.perf('Attempting to run a task.');
         // Check if the function was invoked by the maybeRunInterval and use an empty function if not.
         const done = intervalCallback || (() => { });
         // Prevent starting a new task if:
         // - the pool is paused or aborted
-        if (this.isStopped) {
-            this.log.perf('Task will not run. AutoscaledPool is stopped.');
+        if (this.#isStopped) {
+            this.#log.perf('Task will not run. AutoscaledPool is stopped.');
             return done();
         }
         // - we are already querying for a task.
-        if (this.queryingIsTaskReady) {
-            this.log.perf('Task will not run. Waiting for a ready task.');
+        if (this.#queryingIsTaskReady) {
+            this.#log.perf('Task will not run. Waiting for a ready task.');
             return done();
         }
-        // - we would exceed desired concurrency.
-        if (this._currentConcurrency >= this._desiredConcurrency) {
-            this.log.perf('Task will not run. Desired concurrency achieved.');
-            return done();
-        }
-        // - system is overloaded now and we are at or above minConcurrency
-        const currentStatus = this.systemStatus.getCurrentStatus();
-        const { isSystemIdle } = currentStatus;
-        if (!isSystemIdle && this._currentConcurrency >= this._minConcurrency) {
-            this.log.perf('Task will not be run. System is overloaded.', currentStatus);
-            return done();
+        // - the budget has room for us.
+        if (!this.#concurrencySystem.hasCapacityForTask(this.#consumer)) {
+            done();
+            // A shared governor's budget can stay saturated by another pool indefinitely, so we still have to be able
+            // to notice that *this* pool has run out of work — `maybeFinish()` is the only thing that ever resolves
+            // `run()`. It no-ops while this pool has tasks of its own in flight, which is every case in which an
+            // unshared governor reports no capacity.
+            return this.maybeFinish();
         }
         // - a task is ready.
-        this.queryingIsTaskReady = true;
+        this.#queryingIsTaskReady = true;
         let isTaskReady;
         try {
-            this.log.perf('Checking for ready tasks.');
-            isTaskReady = await this.isTaskReadyFunction();
+            this.#log.perf('Checking for ready tasks.');
+            isTaskReady = await this.#isTaskReadyFunction();
         }
         catch (e) {
             const err = e;
-            this.log.perf('Checking for ready tasks failed.');
+            this.#log.perf('Checking for ready tasks failed.');
             // We might have already rejected this promise.
-            if (this.reject) {
+            if (this.#reject) {
                 // No need to log all concurrent errors.
-                this.log.exception(err, 'isTaskReadyFunction failed');
-                this.reject(err);
+                this.#log.exception(err, 'isTaskReadyFunction failed');
+                this.#reject(err);
             }
         }
         finally {
-            this.queryingIsTaskReady = false;
+            this.#queryingIsTaskReady = false;
         }
         if (!isTaskReady) {
-            this.log.perf('Task will not run. No tasks are ready.');
+            this.#log.perf('Task will not run. No tasks are ready.');
             done();
             // No tasks could mean that we're finished with all tasks.
-            return this._maybeFinish();
+            return this.maybeFinish();
         }
-        // - we have already reached the maximum tasks per minute
-        // we need to check this *after* checking if a task is ready to prevent hanging the pool
-        // for an extra minute if there are no more tasks
-        if (this._isOverMaxRequestLimit) {
-            this.log.perf('Task will not run. Maximum tasks per minute reached.');
+        // - the budget still has room. Re-checked atomically, because another pool sharing the governor may have taken
+        // the last free slot while we awaited `isTaskReadyFunction` above.
+        if (!this.#concurrencySystem.tryRegisterTaskStart(this.#consumer)) {
             return done();
         }
+        this.#ownConcurrency++;
         try {
             // Everything's fine. Run task.
-            this._currentConcurrency++;
-            this._tasksPerMinute[0]++;
             // Try to run next task to build up concurrency,
             // but defer it so it doesn't create a cycle.
-            setImmediate(this._maybeRunTask);
+            setImmediate(this.maybeRunTask);
             // We need to restart interval here, so that it doesn't get blocked by a stalled task.
             done();
             // Execute the current task.
-            this.log.perf('Running a task.');
-            if (this.taskTimeoutMillis > 0) {
-                await addTimeoutToPromise(async () => this.runTaskFunction(), this.taskTimeoutMillis, `runTaskFunction timed out after ${this.taskTimeoutMillis / 1000} seconds.`);
+            this.#log.perf('Running a task.');
+            if (this.#taskTimeoutMillis > 0) {
+                await addTimeoutToPromise(async () => this.#runTaskFunction(), this.#taskTimeoutMillis, `runTaskFunction timed out after ${this.#taskTimeoutMillis / 1000} seconds.`);
             }
             else {
-                await this.runTaskFunction();
+                await this.#runTaskFunction();
             }
-            this.log.perf('Task finished.');
-            this._currentConcurrency--;
-            // Run task after the previous one finished.
-            setImmediate(this._maybeRunTask);
+            this.#log.perf('Task finished.');
+            // Run task after the previous one finished. Only on success: a failed task rejects the pool, and
+            // nudging the loop afterwards could start work on an already destroyed pool.
+            setImmediate(this.maybeRunTask);
         }
         catch (e) {
             const err = e;
-            this.log.perf('Running a task failed.');
+            this.#log.perf('Running a task failed.');
             // We might have already rejected this promise.
-            if (this.reject) {
+            if (this.#reject) {
                 // No need to log all concurrent errors.
                 if (
                 // avoid reprinting the same critical error multiple times, as it will be printed by Nodejs at the end anyway
                 !(e instanceof CriticalError)) {
-                    this.log.exception(err, 'runTaskFunction failed.');
+                    this.#log.exception(err, 'runTaskFunction failed.');
                 }
-                this.reject(err);
+                this.#reject(err);
             }
         }
-        return undefined;
-    }
-    /**
-     * Gets called every autoScaleIntervalSecs and evaluates the current system status.
-     * If the system IS NOT overloaded and the settings allow it, it scales up.
-     * If the system IS overloaded and the settings allow it, it scales down.
-     */
-    _autoscale(intervalCallback) {
-        // Don't scale if paused.
-        if (this.isStopped)
-            return intervalCallback();
-        // Don't scale if we've hit the maximum requests per minute
-        if (this._isOverMaxRequestLimit)
-            return intervalCallback();
-        // Only scale up if:
-        // - system has not been overloaded lately.
-        const systemStatus = this.systemStatus.getHistoricalStatus();
-        const { isSystemIdle } = systemStatus;
-        // - we're not already at max concurrency.
-        const weAreNotAtMax = this._desiredConcurrency < this._maxConcurrency;
-        // - current concurrency reaches at least the given ratio of desired concurrency.
-        const minCurrentConcurrency = Math.floor(this._desiredConcurrency * this.desiredConcurrencyRatio);
-        const weAreReachingDesiredConcurrency = this._currentConcurrency >= minCurrentConcurrency;
-        if (isSystemIdle && weAreNotAtMax && weAreReachingDesiredConcurrency)
-            this._scaleUp(systemStatus);
-        // Always scale down if:
-        // - the system has been overloaded lately.
-        const isSystemOverloaded = !isSystemIdle;
-        // - we're over min concurrency.
-        const weAreNotAtMin = this._desiredConcurrency > this._minConcurrency;
-        if (isSystemOverloaded && weAreNotAtMin)
-            this._scaleDown(systemStatus);
-        // On periodic intervals, print comprehensive log information
-        if (this.loggingIntervalMillis > 0) {
-            const now = Date.now();
-            if (this.lastLoggingTime == null) {
-                this.lastLoggingTime = now;
-            }
-            else if (now > this.lastLoggingTime + this.loggingIntervalMillis) {
-                this.lastLoggingTime = now;
-                this.log.info('state', {
-                    currentConcurrency: this._currentConcurrency,
-                    desiredConcurrency: this._desiredConcurrency,
-                    systemStatus,
-                });
-            }
+        finally {
+            this.#concurrencySystem.registerTaskEnd(this.#consumer);
+            this.#ownConcurrency--;
         }
-        // Start a new interval cycle.
-        return intervalCallback();
-    }
-    /**
-     * Scales the pool up by increasing
-     * the desired concurrency by the scaleUpStepRatio.
-     *
-     * @param systemStatus for logging
-     */
-    _scaleUp(systemStatus) {
-        const step = Math.ceil(this._desiredConcurrency * this.scaleUpStepRatio);
-        this._desiredConcurrency = Math.min(this._maxConcurrency, this._desiredConcurrency + step);
-        this.log.debug('scaling up', {
-            oldConcurrency: this._desiredConcurrency - step,
-            newConcurrency: this._desiredConcurrency,
-            systemStatus,
-        });
-    }
-    /**
-     * Scales the pool down by decreasing
-     * the desired concurrency by the scaleDownStepRatio.
-     *
-     * @param systemStatus for logging
-     */
-    _scaleDown(systemStatus) {
-        const step = Math.ceil(this._desiredConcurrency * this.scaleDownStepRatio);
-        this._desiredConcurrency = Math.max(this._minConcurrency, this._desiredConcurrency - step);
-        this.log.debug('scaling down', {
-            oldConcurrency: this._desiredConcurrency + step,
-            newConcurrency: this._desiredConcurrency,
-            systemStatus,
-        });
+        return undefined;
     }
     /**
-     * If there are no running tasks and this.isFinishedFunction() returns true then closes
+     * If there are no running tasks and `isFinishedFunction()` returns true then closes
      * the pool and resolves the pool's promise returned by the run() method.
      *
      * It doesn't allow multiple concurrent runs of this method.
      */
-    async _maybeFinish() {
-        if (this.queryingIsFinished)
+    async maybeFinish() {
+        if (this.#queryingIsFinished)
             return;
-        if (this._currentConcurrency > 0)
+        if (this.#ownConcurrency > 0)
             return;
-        this.queryingIsFinished = true;
+        this.#queryingIsFinished = true;
         try {
-            const isFinished = await this.isFinishedFunction();
-            if (isFinished && this.resolve)
-                this.resolve();
+            const isFinished = await this.#isFinishedFunction();
+            if (isFinished && this.#resolve)
+                this.#resolve();
         }
         catch (e) {
             const err = e;
-            if (this.reject) {
+            if (this.#reject) {
                 // No need to log all concurrent errors.
-                this.log.exception(err, 'isFinishedFunction failed.');
-                this.reject(err);
+                this.#log.exception(err, 'isFinishedFunction failed.');
+                this.#reject(err);
             }
         }
         finally {
-            this.queryingIsFinished = false;
+            this.#queryingIsFinished = false;
         }
     }
     /**
      * Cleans up resources.
      */
-    async _destroy() {
-        this.resolve = null;
-        this.reject = null;
-        betterClearInterval(this.autoscaleInterval);
-        betterClearInterval(this.maybeRunInterval);
-        if (this.tasksDonePerSecondInterval)
-            betterClearInterval(this.tasksDonePerSecondInterval);
-        if (this.snapshotter)
-            await this.snapshotter.stop();
-    }
-    _incrementTasksDonePerSecond(intervalCallback) {
-        this._tasksPerMinute.unshift(0);
-        this._tasksPerMinute.pop();
-        return intervalCallback();
-    }
-    get _isOverMaxRequestLimit() {
-        if (this.maxTasksPerMinute === Infinity) {
-            return false;
-        }
-        return this._tasksPerMinute.reduce((acc, curr) => acc + curr, 0) >= this.maxTasksPerMinute;
+    async destroy() {
+        this.#resolve = null;
+        this.#reject = null;
+        betterClearInterval(this.#maybeRunInterval);
     }
 }
-//# sourceMappingURL=autoscaled_pool.js.map