@crawlee/basic 4.0.0-beta.17 → 4.0.0-beta.171

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (84) hide show
  1. package/README.md +14 -14
  2. package/index.d.ts +10 -2
  3. package/index.js +10 -1
  4. package/internals/autoscaling/autoscaled_pool.d.ts +196 -0
  5. package/internals/autoscaling/autoscaled_pool.js +385 -0
  6. package/internals/autoscaling/concurrency_system.d.ts +267 -0
  7. package/internals/autoscaling/concurrency_system.js +364 -0
  8. package/internals/autoscaling/cpu_load_signal.d.ts +43 -0
  9. package/internals/autoscaling/cpu_load_signal.js +46 -0
  10. package/internals/autoscaling/event_loop_load_signal.d.ts +51 -0
  11. package/internals/autoscaling/event_loop_load_signal.js +60 -0
  12. package/internals/autoscaling/index.d.ts +9 -0
  13. package/internals/autoscaling/index.js +9 -0
  14. package/internals/autoscaling/load_signal.d.ts +98 -0
  15. package/internals/autoscaling/load_signal.js +103 -0
  16. package/internals/autoscaling/memory_load_signal.d.ts +47 -0
  17. package/internals/autoscaling/memory_load_signal.js +104 -0
  18. package/internals/autoscaling/snapshotter.d.ts +84 -0
  19. package/internals/autoscaling/snapshotter.js +67 -0
  20. package/internals/autoscaling/storage_backend_load_signal.d.ts +56 -0
  21. package/internals/autoscaling/storage_backend_load_signal.js +73 -0
  22. package/internals/autoscaling/system_status.d.ts +122 -0
  23. package/internals/autoscaling/system_status.js +139 -0
  24. package/internals/autoscaling/weighted_avg.d.ts +5 -0
  25. package/internals/autoscaling/weighted_avg.js +14 -0
  26. package/internals/basic-crawler.d.ts +462 -332
  27. package/internals/basic-crawler.js +1384 -803
  28. package/internals/cookie_utils.d.ts +44 -0
  29. package/internals/cookie_utils.js +122 -0
  30. package/internals/crawler-run.d.ts +76 -0
  31. package/internals/crawler-run.js +142 -0
  32. package/internals/crawlers/context_pipeline.d.ts +70 -0
  33. package/internals/crawlers/context_pipeline.js +122 -0
  34. package/internals/crawlers/crawler_commons.d.ts +193 -0
  35. package/internals/crawlers/crawler_commons.js +1 -0
  36. package/internals/crawlers/error_snapshotter.d.ts +57 -0
  37. package/internals/crawlers/error_snapshotter.js +117 -0
  38. package/internals/crawlers/error_tracker.d.ts +54 -0
  39. package/internals/crawlers/error_tracker.js +308 -0
  40. package/internals/crawlers/index.d.ts +5 -0
  41. package/internals/crawlers/index.js +4 -0
  42. package/internals/crawlers/internals/types.d.ts +7 -0
  43. package/internals/crawlers/internals/types.js +1 -0
  44. package/internals/crawlers/statistics.d.ts +318 -0
  45. package/internals/crawlers/statistics.js +525 -0
  46. package/internals/enqueue_links/enqueue_links.d.ts +152 -0
  47. package/internals/enqueue_links/enqueue_links.js +76 -0
  48. package/internals/enqueue_links/index.d.ts +2 -0
  49. package/internals/enqueue_links/index.js +2 -0
  50. package/internals/enqueue_links/shared.d.ts +98 -0
  51. package/internals/enqueue_links/shared.js +259 -0
  52. package/internals/errors.d.ts +58 -0
  53. package/internals/errors.js +72 -0
  54. package/internals/http.d.ts +9 -0
  55. package/internals/http.js +28 -0
  56. package/internals/request-timeout.d.ts +48 -0
  57. package/internals/request-timeout.js +73 -0
  58. package/internals/router.d.ts +306 -0
  59. package/internals/router.js +310 -0
  60. package/internals/send-request.d.ts +4 -4
  61. package/internals/send-request.js +21 -23
  62. package/internals/session_pool/consts.d.ts +3 -0
  63. package/internals/session_pool/consts.js +3 -0
  64. package/internals/session_pool/errors.d.ts +7 -0
  65. package/internals/session_pool/errors.js +11 -0
  66. package/internals/session_pool/fingerprint.d.ts +9 -0
  67. package/internals/session_pool/fingerprint.js +30 -0
  68. package/internals/session_pool/index.d.ts +4 -0
  69. package/internals/session_pool/index.js +4 -0
  70. package/internals/session_pool/session.d.ts +153 -0
  71. package/internals/session_pool/session.js +221 -0
  72. package/internals/session_pool/session_pool.d.ts +242 -0
  73. package/internals/session_pool/session_pool.js +429 -0
  74. package/internals/sitemap_request_loader.d.ts +196 -0
  75. package/internals/sitemap_request_loader.js +432 -0
  76. package/internals/throttling_request_manager.d.ts +217 -0
  77. package/internals/throttling_request_manager.js +829 -0
  78. package/package.json +19 -13
  79. package/index.d.ts.map +0 -1
  80. package/index.js.map +0 -1
  81. package/internals/basic-crawler.d.ts.map +0 -1
  82. package/internals/basic-crawler.js.map +0 -1
  83. package/internals/send-request.d.ts.map +0 -1
  84. package/internals/send-request.js.map +0 -1
@@ -1,16 +1,48 @@
1
- import { writeFile } from 'node:fs/promises';
1
+ import { mkdir, writeFile } from 'node:fs/promises';
2
2
  import { dirname } from 'node:path';
3
- import { AutoscaledPool, Configuration, ContextPipeline, ContextPipelineCleanupError, ContextPipelineInitializationError, ContextPipelineInterruptedError, CriticalError, Dataset, enqueueLinks, EnqueueStrategy, GotScrapingHttpClient, KeyValueStore, mergeCookies, NonRetryableError, purgeDefaultStorages, RequestHandlerError, RequestListAdapter, RequestManagerTandem, RequestProvider, RequestQueue, RequestQueueV1, RequestState, RetryRequestError, Router, SessionError, SessionPool, Statistics, validators, } from '@crawlee/core';
4
- import { getObjectType, isAsyncIterable, isIterable, RobotsTxtFile, ROTATE_PROXY_ERRORS } from '@crawlee/utils';
5
- import { stringify } from 'csv-stringify/sync';
6
- import { ensureDir, writeJSON } from 'fs-extra/esm';
7
- import ow from 'ow';
3
+ import { bindMethodsToServiceLocator, Configuration, createStorageTransaction, Request, CriticalError, currentStorageTransaction, Dataset, EnqueueStrategy, EventManager, EventType, getObjectType, KeyValueStore, log, NonRetryableError, OwnedOrInjected, purgeDefaultStorages, RequestManagerTandem, RequestQueue, RequestState, ServiceLocator, serviceLocator, SessionError, validators, withDirectStorageAccess, } from '@crawlee/core';
4
+ import { BaseHttpClient, FetchHttpClient } from '@crawlee/http-client';
5
+ import { isAsyncIterable, isIterable, parseArgument, ROTATE_PROXY_ERRORS, schemas } from '@crawlee/utils/internal';
6
+ import { RobotsTxtFile } from '@crawlee/utils';
8
7
  import { getDomain } from 'tldts';
8
+ import { z } from 'zod';
9
9
  import { LruCache } from '@apify/datastructures';
10
- import defaultLog, { LogLevel } from '@apify/log';
11
- import { addTimeoutToPromise, TimeoutError, tryCancel } from '@apify/timeout';
10
+ import { addTimeoutToPromise, extendTimeout, storage as timeoutStorage, TimeoutError, tryCancel } from '@apify/timeout';
12
11
  import { cryptoRandomObjectId } from '@apify/utilities';
12
+ import { ConcurrencySystem } from './autoscaling/concurrency_system.js';
13
+ import { mergeCookies } from './cookie_utils.js';
14
+ import { ContextPipeline } from './crawlers/context_pipeline.js';
15
+ import { ContextPipelineCleanupError, ContextPipelineInitializationError, ContextPipelineInterruptedError, MissingSessionError, NavigationSkippedError, PersistentRateLimitError, RequestHandlerError, RequestThrottledError, RetryRequestError, } from './errors.js';
16
+ import { Statistics } from './crawlers/statistics.js';
17
+ import { applyRequestTransform, buildEnqueueStrategyPatterns, constructUrlPatternObjects, createRequestOptions, createSkippedRequestArgs, filterRequestOptionsByPatterns, } from './enqueue_links/index.js';
18
+ import { parseRetryAfterHeader } from './http.js';
19
+ import { CrawlerRun } from './crawler-run.js';
20
+ import { extendTimeoutKey, navigationDeadlineKey, raceWithTimeout, timeoutExpiredKey, } from './request-timeout.js';
13
21
  import { createSendRequest } from './send-request.js';
22
+ import { Router, validateUserData } from './router.js';
23
+ import { BLOCKED_STATUS_CODES } from './session_pool/consts.js';
24
+ import { Session } from './session_pool/session.js';
25
+ import { SessionPool } from './session_pool/session_pool.js';
26
+ import { ThrottlingRequestManager } from './throttling_request_manager.js';
27
+ class LazyDefaultHttpClient extends BaseHttpClient {
28
+ #delegatePromise;
29
+ constructor(options) {
30
+ super(options);
31
+ this.#delegatePromise = import('@crawlee/impit-client')
32
+ .then(({ ImpitHttpClient }) => new ImpitHttpClient(options))
33
+ .catch(() => {
34
+ (options?.logger ?? log).warning('Optional dependency @crawlee/impit-client is not installed. ' +
35
+ 'Falling back to native fetch — proxy support and browser fingerprinting are unavailable.');
36
+ return new FetchHttpClient(options);
37
+ });
38
+ }
39
+ fetch() {
40
+ throw new Error('LazyDefaultHttpClient delegates `sendRequest` entirely; `fetch` is never called.');
41
+ }
42
+ async sendRequest(...args) {
43
+ return (await this.#delegatePromise).sendRequest(...args);
44
+ }
45
+ }
14
46
  /**
15
47
  * Since there's no set number of seconds before the container is terminated after
16
48
  * a migration event, we need some reasonable number to use for RequestList persistence.
@@ -21,107 +53,118 @@ import { createSendRequest } from './send-request.js';
21
53
  * @ignore
22
54
  */
23
55
  const SAFE_MIGRATION_WAIT_MILLIS = 20000;
24
- /**
25
- * Provides a simple framework for parallel crawling of web pages.
26
- * The URLs to crawl are fed either from a static list of URLs
27
- * or from a dynamic queue of URLs enabling recursive crawling of websites.
28
- *
29
- * `BasicCrawler` is a low-level tool that requires the user to implement the page
30
- * download and data extraction functionality themselves.
31
- * If we want a crawler that already facilitates this functionality,
32
- * we should consider using {@link CheerioCrawler}, {@link PuppeteerCrawler} or {@link PlaywrightCrawler}.
33
- *
34
- * `BasicCrawler` invokes the user-provided {@link BasicCrawlerOptions.requestHandler|`requestHandler`}
35
- * for each {@link Request} object, which represents a single URL to crawl.
36
- * The {@link Request} objects are fed from the {@link RequestList} or {@link RequestQueue}
37
- * instances provided by the {@link BasicCrawlerOptions.requestList|`requestList`} or {@link BasicCrawlerOptions.requestQueue|`requestQueue`}
38
- * constructor options, respectively. If neither `requestList` nor `requestQueue` options are provided,
39
- * the crawler will open the default request queue either when the {@link BasicCrawler.addRequests|`crawler.addRequests()`} function is called,
40
- * or if `requests` parameter (representing the initial requests) of the {@link BasicCrawler.run|`crawler.run()`} function is provided.
41
- *
42
- * If both {@link BasicCrawlerOptions.requestList|`requestList`} and {@link BasicCrawlerOptions.requestQueue|`requestQueue`} options are used,
43
- * the instance first processes URLs from the {@link RequestList} and automatically enqueues all of them
44
- * to the {@link RequestQueue} before it starts their processing. This ensures that a single URL is not crawled multiple times.
45
- *
46
- * The crawler finishes if there are no more {@link Request} objects to crawl.
47
- *
48
- * New requests are only dispatched when there is enough free CPU and memory available,
49
- * using the functionality provided by the {@link AutoscaledPool} class.
50
- * All {@link AutoscaledPool} configuration options can be passed to the {@link BasicCrawlerOptions.autoscaledPoolOptions|`autoscaledPoolOptions`}
51
- * parameter of the `BasicCrawler` constructor.
52
- * For user convenience, the {@link AutoscaledPoolOptions.minConcurrency|`minConcurrency`} and
53
- * {@link AutoscaledPoolOptions.maxConcurrency|`maxConcurrency`} options of the
54
- * underlying {@link AutoscaledPool} constructor are available directly in the `BasicCrawler` constructor.
55
- *
56
- * **Example usage:**
57
- *
58
- * ```javascript
59
- * import { BasicCrawler, Dataset } from 'crawlee';
60
- *
61
- * // Create a crawler instance
62
- * const crawler = new BasicCrawler({
63
- * async requestHandler({ request, sendRequest }) {
64
- * // 'request' contains an instance of the Request class
65
- * // Here we simply fetch the HTML of the page and store it to a dataset
66
- * const { body } = await sendRequest({
67
- * url: request.url,
68
- * method: request.method,
69
- * body: request.payload,
70
- * headers: request.headers,
71
- * });
72
- *
73
- * await Dataset.pushData({
74
- * url: request.url,
75
- * html: body,
76
- * })
77
- * },
78
- * });
79
- *
80
- * // Enqueue the initial requests and run the crawler
81
- * await crawler.run([
82
- * 'http://www.example.com/page-1',
83
- * 'http://www.example.com/page-2',
84
- * ]);
85
- * ```
86
- * @category Crawlers
87
- */
56
+ const deferredCleanupKey = Symbol('deferredCleanup');
57
+ // The request timeout plumbing (the window helper, the context symbols, and the race) lives in its own module.
58
+ export { navigationDeadlineKey, remainingNavigationWindowMillis } from './request-timeout.js';
59
+ const urlPatternSchema = z.union([
60
+ z.string(),
61
+ z.instanceof(RegExp),
62
+ schemas.objectWithKeys(['glob']),
63
+ schemas.objectWithKeys(['regexp']),
64
+ ]);
65
+ // `looseObject` (rather than `strictObject`) lets subclasses forward their own extraction-only options
66
+ // (e.g. `selector`) straight through without having to strip them out first.
67
+ const addRequestsOptionsSchema = z.looseObject({
68
+ forefront: z.boolean().optional(),
69
+ cache: z.boolean().optional(),
70
+ waitForAllRequestsToBeAdded: z.boolean().optional(),
71
+ batchSize: schemas.anyNumber.optional(),
72
+ waitBetweenBatchesMillis: schemas.anyNumber.optional(),
73
+ maxNewRequests: schemas.anyNumber.optional(),
74
+ limit: schemas.anyNumber.optional(),
75
+ baseUrl: z.string().optional(),
76
+ userData: schemas.anyObject.optional(),
77
+ label: z.string().optional(),
78
+ sessionId: z.string().optional(),
79
+ skipNavigation: z.boolean().optional(),
80
+ include: schemas.arrayOf(urlPatternSchema, 'URL patterns').min(1).optional(),
81
+ exclude: schemas.arrayOf(urlPatternSchema, 'URL patterns').optional(),
82
+ transformRequestFunction: schemas.anyFunction.optional(),
83
+ strategy: z.enum(EnqueueStrategy).optional(),
84
+ onSkippedRequest: schemas.anyFunction.optional(),
85
+ });
88
86
  export class BasicCrawler {
89
- config;
90
- static CRAWLEE_STATE_KEY = 'CRAWLEE_STATE';
87
+ static #CRAWLEE_STATE_KEY = 'CRAWLEE_STATE';
91
88
  /**
92
- * A reference to the underlying {@link Statistics} class that collects and logs run statistics for requests.
89
+ * Tracks the number of crawler instances created. The first crawler uses the default
90
+ * request queue; subsequent ones get their own queue via a unique alias so they don't
91
+ * collide.
93
92
  */
94
- stats;
93
+ // kept as TS-private: tests reset the counter at runtime
94
+ static instanceCount = 0;
95
95
  /**
96
- * A reference to the underlying {@link RequestList} class that manages the crawler's {@link Request|requests}.
97
- * Only available if used by the crawler.
96
+ * Tracks crawler instances that accessed shared state without having an explicit id.
97
+ * Used to detect and warn about multiple crawlers sharing the same state.
98
98
  */
99
- requestList;
99
+ static #useStateAnonymousIndices = new Set();
100
+ /** Backs the {@link BasicCrawler.statistics|`statistics`} getter. */
101
+ #statisticsDep;
100
102
  /**
101
- * Dynamic queue of URLs to be processed. This is useful for recursive crawling of websites.
102
- * A reference to the underlying {@link RequestQueue} class that manages the crawler's {@link Request|requests}.
103
- * Only available if used by the crawler.
103
+ * The statistics instance collecting the crawler's run statistics - either the injected `statistics` option or a
104
+ * crawler-built default. Typed as {@link IStatistics} so custom implementations can be plugged in.
104
105
  */
105
- requestQueue;
106
+ get statistics() {
107
+ return this.#statisticsDep.value;
108
+ }
106
109
  /**
107
- * The main request-handling component of the crawler. It's initialized during the crawler startup.
110
+ * The main request-handling component of the crawler. It manages the requests that the crawler processes,
111
+ * combining any provided request loader and/or queue. It's initialized during the crawler startup or lazily
112
+ * via {@link BasicCrawler.getRequestManager|`getRequestManager()`}.
108
113
  */
109
114
  requestManager;
115
+ /** Backs the {@link BasicCrawler.sessionPool|`sessionPool`} getter. */
116
+ #sessionPoolDep;
110
117
  /**
111
- * A reference to the underlying {@link SessionPool} class that manages the crawler's {@link Session|sessions}.
112
- * Only available if used by the crawler.
118
+ * A reference to the underlying session pool that manages the crawler's {@link Session|sessions}. Typed as
119
+ * {@link ISessionPool} so custom implementations can be plugged in via the `sessionPool` constructor option.
113
120
  */
114
- sessionPool;
121
+ get sessionPool() {
122
+ return this.#sessionPoolDep.value;
123
+ }
124
+ /**
125
+ * Whether the request-processing-time hint has already been forwarded to the request manager. The hint
126
+ * derives only from `requestHandlerTimeoutMillis` (constant for the crawler's lifetime) and is raise-only,
127
+ * so it only needs to be applied once, at the first async access of the manager.
128
+ */
129
+ #requestManagerTimeoutsApplied = false;
130
+ /**
131
+ * Resolves the governor for one run: either the injected
132
+ * {@link BasicCrawlerOptions.concurrencySystem|`concurrencySystem`} (borrowed) or a freshly built default with
133
+ * the concurrency shortcuts folded in (owned, so the crawler starts and stops it).
134
+ */
135
+ #resolveConcurrencySystem;
136
+ /** The last run started on this instance. It outlives the run, so anything that drives one goes through `#liveRun`. */
137
+ #run;
138
+ #concurrencySystem;
139
+ /** The run in progress, if any — a finished run is history and cannot be driven. */
140
+ get #liveRun() {
141
+ return this.#run?.isLive === true ? this.#run : undefined;
142
+ }
143
+ /** The run whose task loop is dispatching, if any — only that one can be paused and resumed. */
144
+ get #dispatchingRun() {
145
+ return this.#liveRun?.isDispatching === true ? this.#liveRun : undefined;
146
+ }
147
+ /** Whether a {@link BasicCrawler.run|`run()`} is in progress on this instance. */
148
+ get running() {
149
+ return this.#liveRun !== undefined;
150
+ }
115
151
  /**
116
- * A reference to the underlying {@link AutoscaledPool} class that manages the concurrency of the crawler.
117
- * > *NOTE:* This property is only initialized after calling the {@link BasicCrawler.run|`crawler.run()`} function.
118
- * We can use it to change the concurrency settings on the fly,
119
- * to pause the crawler by calling {@link AutoscaledPool.pause|`autoscaledPool.pause()`}
120
- * or to abort it by calling {@link AutoscaledPool.abort|`autoscaledPool.abort()`}.
152
+ * The concurrency governor the run in progress is booking its requests against — either the
153
+ * {@link BasicCrawlerOptions.concurrencySystem|`concurrencySystem`} that was injected, or the default the
154
+ * crawler built for itself. Read it for telemetry: `desiredConcurrency`, `currentConcurrency`, `isRunning`.
155
+ *
156
+ * > *NOTE:* `undefined` outside a run, and a crawler-owned default is rebuilt for every run — so read it
157
+ * during a run rather than caching it across runs.
158
+ *
159
+ * {@link IConcurrencySystem} is deliberately read-only. Tuning concurrency *while a crawl is running* means
160
+ * owning the instance: build a {@link ConcurrencySystem} yourself and inject it, then set
161
+ * `minConcurrency`/`maxConcurrency`/`desiredConcurrency` on your own reference.
121
162
  */
122
- autoscaledPool;
163
+ get concurrencySystem() {
164
+ return this.#concurrencySystem?.value;
165
+ }
123
166
  /**
124
- * A reference to the underlying {@link ProxyConfiguration} class that manages the crawler's proxies.
167
+ * A reference to the underlying {@link IProxyConfiguration} instance that manages the crawler's proxies.
125
168
  * Only available if used by the crawler.
126
169
  */
127
170
  proxyConfiguration;
@@ -130,238 +173,553 @@ export class BasicCrawler {
130
173
  * See {@link Router.addHandler|`router.addHandler()`} and {@link Router.addDefaultHandler|`router.addDefaultHandler()`}.
131
174
  */
132
175
  router = Router.create();
133
- contextPipelineBuilder;
134
- _contextPipeline;
176
+ #basicContextPipeline;
177
+ /**
178
+ * The basic part of the context pipeline. Unlike the subclass pipeline, this
179
+ * part has no major side effects (e.g. launching a browser). It also makes typing more explicit, as subclass
180
+ * pipelines expect the basic crawler fields to already be present in the context at runtime.
181
+ *
182
+ * Context built with this pipeline can be passed into multiple crawler pipelines at once.
183
+ * This is used e.g. in the {@link AdaptivePlaywrightCrawler|`AdaptivePlaywrightCrawler`}.
184
+ */
185
+ get basicContextPipeline() {
186
+ if (this.#basicContextPipeline === undefined) {
187
+ this.#basicContextPipeline = this.buildBasicContextPipeline();
188
+ }
189
+ return this.#basicContextPipeline;
190
+ }
191
+ #contextPipeline;
135
192
  get contextPipeline() {
136
- if (this._contextPipeline === undefined) {
137
- this._contextPipeline = this.contextPipelineBuilder();
193
+ if (this.#contextPipeline === undefined) {
194
+ this.#contextPipeline = this.buildFinalContextPipeline();
138
195
  }
139
- return this._contextPipeline;
196
+ return this.#contextPipeline;
197
+ }
198
+ #hasFinishedBefore = false;
199
+ /** Whether a `run()` on this instance has already finished - a repeated one continues where it left off. */
200
+ get hasFinishedBefore() {
201
+ return this.#hasFinishedBefore;
202
+ }
203
+ #log;
204
+ get log() {
205
+ return this.#log;
140
206
  }
141
- running = false;
142
- hasFinishedBefore = false;
143
- log;
144
207
  requestHandler;
145
- errorHandler;
146
- failedRequestHandler;
147
- requestHandlerTimeoutMillis;
208
+ #errorHandler;
209
+ #failedRequestHandler;
210
+ #requestHandlerTimeoutMillis;
148
211
  internalTimeoutMillis;
149
- maxRequestRetries;
150
- maxCrawlDepth;
151
- sameDomainDelayMillis;
152
- domainAccessedTime;
153
- maxSessionRotations;
154
- maxRequestsPerCrawl;
155
- handledRequestsCount = 0;
156
- statusMessageLoggingInterval;
157
- statusMessageCallback;
158
- sessionPoolOptions;
159
- useSessionPool;
160
- autoscaledPoolOptions;
161
- events;
212
+ #maxRequestRetries;
213
+ #maxCrawlDepth;
214
+ #maxRequestsPerCrawl;
215
+ get handledRequestsCount() {
216
+ return this.statistics.state.requestsSucceeded + this.statistics.state.requestsFailed;
217
+ }
218
+ #statusMessageLoggingInterval;
219
+ #statusMessageCallback;
220
+ blockedStatusCodes = new Set();
221
+ additionalHttpErrorStatusCodes;
222
+ #ignoreHttpErrorStatusCodes;
223
+ /**
224
+ * The resolved options for the crawler's own task loop — the crawler-owned `runTaskFunction`, the (possibly
225
+ * user-overridden) ready/finished predicates and cadence/logging. Concurrency configuration lives on the
226
+ * {@link ConcurrencySystem} instead, and the loop's `consumer` identity is the crawler's own, so neither is
227
+ * settable here.
228
+ */
229
+ #taskLoopOptions;
162
230
  httpClient;
163
231
  retryOnBlocked;
164
- respectRobotsTxtFile;
165
- onSkippedRequest;
166
- _closeEvents;
167
- shouldLogMaxProcessedRequestsExceeded = true;
168
- shouldLogMaxEnqueuedRequestsExceeded = true;
169
- experiments;
170
- robotsTxtFileCache;
171
- _experimentWarnings = {};
232
+ #respectRobotsTxtFile;
233
+ /** Whether `runInStorageTransaction()` opens a transaction at all. */
234
+ #transactionalStorageEnabled;
235
+ /** The resolved per-storage-type write policy overrides forwarded to each request's transaction. */
236
+ #storageWritePolicy;
237
+ #onSkippedRequest;
238
+ #robotsTxtFileCache;
239
+ #identity;
240
+ #contextPipelineOptions;
241
+ /**
242
+ * @internal
243
+ */
172
244
  static optionsShape = {
173
- contextPipelineBuilder: ow.optional.object,
174
- extendContext: ow.optional.function,
175
- requestList: ow.optional.object.validate(validators.requestList),
176
- requestQueue: ow.optional.object.validate(validators.requestQueue),
245
+ contextPipelineBuilder: schemas.anyObject.optional(),
246
+ extendContext: schemas.anyFunction.optional(),
247
+ requestList: validators.requestList.optional(),
248
+ requestQueue: validators.requestQueue.optional(),
249
+ requestManager: validators.requestManager.optional(),
177
250
  // Subclasses override this function instead of passing it
178
251
  // in constructor, so this validation needs to apply only
179
252
  // if the user creates an instance of BasicCrawler directly.
180
- requestHandler: ow.optional.function,
181
- requestHandlerTimeoutSecs: ow.optional.number,
182
- errorHandler: ow.optional.function,
183
- failedRequestHandler: ow.optional.function,
184
- maxRequestRetries: ow.optional.number,
185
- sameDomainDelaySecs: ow.optional.number,
186
- maxSessionRotations: ow.optional.number,
187
- maxRequestsPerCrawl: ow.optional.number,
188
- maxCrawlDepth: ow.optional.number,
189
- autoscaledPoolOptions: ow.optional.object,
190
- sessionPoolOptions: ow.optional.object,
191
- useSessionPool: ow.optional.boolean,
192
- proxyConfiguration: ow.optional.object.validate(validators.proxyConfiguration),
193
- statusMessageLoggingInterval: ow.optional.number,
194
- statusMessageCallback: ow.optional.function,
195
- retryOnBlocked: ow.optional.boolean,
196
- respectRobotsTxtFile: ow.optional.any(ow.boolean, ow.object),
197
- onSkippedRequest: ow.optional.function,
198
- httpClient: ow.optional.object,
253
+ requestHandler: schemas.anyFunction.optional(),
254
+ requestHandlerTimeoutSecs: schemas.anyNumber.optional(),
255
+ errorHandler: schemas.anyFunction.optional(),
256
+ failedRequestHandler: schemas.anyFunction.optional(),
257
+ maxRequestRetries: schemas.anyNumber.default(3),
258
+ sameDomainDelaySecs: schemas.anyNumber.default(0),
259
+ maxRequestsPerCrawl: schemas.anyNumber.optional(),
260
+ maxCrawlDepth: schemas.anyNumber.optional(),
261
+ // No zod default — subclasses provide their own fallback (e.g. HTTP-optimized pool options).
262
+ taskLoopOptions: schemas.anyObject.optional(),
263
+ concurrencySystem: schemas.anyObject.optional(),
264
+ sessionPool: validators.sessionPool.optional(),
265
+ proxyConfiguration: validators.proxyConfiguration.optional(),
266
+ statusMessageLoggingInterval: schemas.anyNumber.default(10),
267
+ statusMessageCallback: schemas.anyFunction.optional(),
268
+ additionalHttpErrorStatusCodes: schemas.arrayOf(schemas.anyNumber, 'numbers').default(() => []),
269
+ ignoreHttpErrorStatusCodes: schemas.arrayOf(schemas.anyNumber, 'numbers').default(() => []),
270
+ blockedStatusCodes: schemas.arrayOf(schemas.anyNumber, 'numbers').optional(),
271
+ retryOnBlocked: z.boolean().default(false),
272
+ respectRobotsTxtFile: z.union([z.boolean(), schemas.anyObject]).default(false),
273
+ transactionalStorage: z
274
+ .union([z.boolean(), z.strictObject({ requestQueue: z.enum(['deferred', 'writeThrough']).optional() })])
275
+ .optional(),
276
+ onSkippedRequest: schemas.anyFunction.optional(),
277
+ httpClient: schemas.httpClient.optional(),
278
+ configuration: z.instanceof(Configuration).optional(),
279
+ storageBackend: validators.storageBackend.optional(),
280
+ eventManager: z.instanceof(EventManager).optional(),
281
+ logger: validators.logger.optional(),
199
282
  // AutoscaledPool shorthands
200
- minConcurrency: ow.optional.number,
201
- maxConcurrency: ow.optional.number,
202
- maxRequestsPerMinute: ow.optional.number.integerOrInfinite.positive.greaterThanOrEqual(1),
203
- keepAlive: ow.optional.boolean,
204
- // internal
205
- log: ow.optional.object,
206
- experiments: ow.optional.object,
207
- statisticsOptions: ow.optional.object,
283
+ minConcurrency: schemas.anyNumber.optional(),
284
+ maxConcurrency: schemas.anyNumber.optional(),
285
+ initialConcurrency: schemas.anyNumber.optional(),
286
+ maxRequestsPerMinute: schemas.anyNumber
287
+ .refine((value) => Number.isInteger(value) || value === Infinity, 'Expected an integer or infinite number')
288
+ .refine((value) => value >= 1, 'Expected a number greater than or equal to 1')
289
+ .optional(),
290
+ keepAlive: z.boolean().optional(),
291
+ statistics: schemas.anyObject.optional(),
292
+ id: z.string().optional(),
208
293
  };
294
+ static #optionsSchema = z.strictObject(BasicCrawler.optionsShape);
209
295
  /**
210
296
  * All `BasicCrawler` parameters are passed via an options object.
211
297
  */
212
- constructor(options = {}, // cast because the constructor logic handles missing `contextPipelineBuilder` - the type is just for DX
213
- config = Configuration.getGlobalConfig()) {
214
- this.config = config;
215
- ow(options, 'BasicCrawlerOptions', ow.object.exactShape(BasicCrawler.optionsShape));
216
- const { requestList, requestQueue, requestManager, maxRequestRetries = 3, sameDomainDelaySecs = 0, maxSessionRotations = 10, maxRequestsPerCrawl, maxCrawlDepth, autoscaledPoolOptions = {}, keepAlive, sessionPoolOptions = {}, useSessionPool = true, proxyConfiguration,
298
+ constructor(options = {}) {
299
+ const parsedOptions = parseArgument(options, BasicCrawler.#optionsSchema, 'BasicCrawlerOptions');
300
+ const {
301
+ // oxlint-disable-next-line typescript/no-deprecated -- still accepted and folded into `requestManager` for back-compat
302
+ requestList,
303
+ // oxlint-disable-next-line typescript/no-deprecated -- still accepted and folded into `requestManager` for back-compat
304
+ requestQueue, requestManager, maxRequestRetries, sameDomainDelaySecs, maxRequestsPerCrawl, maxCrawlDepth, taskLoopOptions = {}, concurrencySystem, keepAlive, sessionPool, proxyConfiguration, additionalHttpErrorStatusCodes, ignoreHttpErrorStatusCodes,
305
+ // Service locator options
306
+ configuration, storageBackend, eventManager, logger,
217
307
  // AutoscaledPool shorthands
218
- minConcurrency, maxConcurrency, maxRequestsPerMinute, retryOnBlocked = false, respectRobotsTxtFile = false, onSkippedRequest, requestHandler, requestHandlerTimeoutSecs, errorHandler, failedRequestHandler, statusMessageLoggingInterval = 10, statusMessageCallback, statisticsOptions, httpClient,
219
- // internal
220
- log = defaultLog.child({ prefix: this.constructor.name }), experiments = {}, } = options;
221
- // Store the builder so that it can be run when the contextPipeline is needed.
222
- // Invoking it immediately would cause problems with parent constructor call order.
223
- this.contextPipelineBuilder = () => {
224
- let contextPipeline = (options.contextPipelineBuilder?.() ??
225
- ContextPipeline.create()); // Thanks to the RequireContextPipeline, contextPipeline will only be undefined if InitialContextType is CrawlingContext
226
- if (options.extendContext !== undefined) {
227
- contextPipeline = contextPipeline.compose({
228
- action: async (context) => await options.extendContext(context),
229
- });
308
+ minConcurrency, maxConcurrency, initialConcurrency, maxRequestsPerMinute, blockedStatusCodes: blockedStatusCodesInput, retryOnBlocked, respectRobotsTxtFile, transactionalStorage, onSkippedRequest, requestHandler, requestHandlerTimeoutSecs, errorHandler, failedRequestHandler, statusMessageLoggingInterval, statusMessageCallback, statistics, httpClient, id, } = parsedOptions;
309
+ // All concurrency configuration lives on the `ConcurrencySystem`, so the shortcuts have nowhere to go once
310
+ // one is supplied - and silently dropping a `maxConcurrency` the user asked for is how crawls end up
311
+ // hammering a site.
312
+ if (concurrencySystem !== undefined &&
313
+ (minConcurrency !== undefined ||
314
+ maxConcurrency !== undefined ||
315
+ initialConcurrency !== undefined ||
316
+ maxRequestsPerMinute !== undefined)) {
317
+ throw new Error('The `minConcurrency`/`maxConcurrency`/`initialConcurrency`/`maxRequestsPerMinute` shortcuts ' +
318
+ 'cannot be combined with `concurrencySystem` - they configure the default `ConcurrencySystem` ' +
319
+ 'that a supplied one replaces. Pass them to the `ConcurrencySystem` constructor instead.');
320
+ }
321
+ // Create per-crawler service locator if custom services were provided.
322
+ // This wraps every method on the crawler instance so that calls to the global `serviceLocator`
323
+ // (via AsyncLocalStorage) resolve to this scoped instance instead.
324
+ // We also enter the scope for the rest of the constructor body, so that any code below
325
+ // that accesses `serviceLocator` will see the correct (scoped) instance.
326
+ let serviceLocatorScope = { enterScope: () => { }, exitScope: () => { } };
327
+ if (storageBackend ||
328
+ eventManager ||
329
+ logger ||
330
+ (configuration !== undefined && configuration !== serviceLocator.getConfiguration())) {
331
+ // Inherit the ambient locator's already-set services for anything not explicitly
332
+ // provided - e.g. only passing a `logger` must not detach the crawler from a globally
333
+ // configured storage backend.
334
+ const ambientServices = serviceLocator.getServicesIfSet();
335
+ const scopedServiceLocator = new ServiceLocator(configuration ?? ambientServices.configuration, eventManager ?? ambientServices.eventManager, storageBackend ?? ambientServices.storageBackend, logger ?? ambientServices.logger);
336
+ serviceLocatorScope = bindMethodsToServiceLocator(scopedServiceLocator, this);
337
+ }
338
+ try {
339
+ serviceLocatorScope.enterScope();
340
+ this.#contextPipelineOptions = {
341
+ contextPipelineBuilder: parsedOptions.contextPipelineBuilder,
342
+ extendContext: parsedOptions.extendContext,
343
+ };
344
+ this.#log = serviceLocator.getLogger().child({ prefix: this.constructor.name });
345
+ // Initialize the Configuration instance to avoid lazy loading in the components
346
+ serviceLocator.getConfiguration();
347
+ const instanceIndex = BasicCrawler.instanceCount++;
348
+ this.#identity = { instanceIndex, hasExplicitId: id !== undefined, id: id ?? String(instanceIndex) };
349
+ if (requestManager !== undefined && (requestList !== undefined || requestQueue !== undefined)) {
350
+ throw new Error('The `requestManager` option cannot be used in conjunction with `requestList` and/or `requestQueue`');
351
+ }
352
+ const suppliedManager = requestManager ?? requestQueue;
353
+ // Offered before building a pacer of our own: anything that paces takes the floor - through any
354
+ // number of wrappers, since they all forward - so no domain ends up with two clocks.
355
+ const floorTaken = sameDomainDelaySecs > 0 &&
356
+ (suppliedManager?.recordPacingSignal({
357
+ reason: 'minIntervalEverywhere',
358
+ intervalMs: sameDomainDelaySecs * 1000,
359
+ // What `sameDomainDelaySecs` has always meant: one clock per site, subdomains included.
360
+ scope: 'registrableDomain',
361
+ }) ??
362
+ false);
363
+ const pacerNeeded = sameDomainDelaySecs > 0 && !floorTaken;
364
+ // Built here rather than at first use so it can sit *inside* the tandem below, which is where a
365
+ // loader's transferred requests pass through it.
366
+ const writableManager = pacerNeeded
367
+ ? new ThrottlingRequestManager({
368
+ domains: 'all',
369
+ minCrawlDelaySecs: sameDomainDelaySecs,
370
+ throttleBy: 'registrableDomain',
371
+ persistStateKey: `CRAWLEE_THROTTLED_DOMAINS_${this.#identity.id}`,
372
+ // A factory, because the default queue is only opened on first use.
373
+ inner: suppliedManager ?? (() => this.openOwnedRequestQueue()),
374
+ })
375
+ : suppliedManager;
376
+ if (requestList !== undefined) {
377
+ // The list is read first, while new requests still have somewhere writable to go; the tandem also
378
+ // forwards `persistState()` to the loader.
379
+ this.requestManager = new RequestManagerTandem(requestList, writableManager ?? (() => this.openOwnedRequestQueue()));
380
+ }
381
+ else if (writableManager !== undefined) {
382
+ // A RequestQueue is itself a request manager.
383
+ this.requestManager = writableManager;
230
384
  }
231
- contextPipeline = contextPipeline.compose({
232
- action: async (context) => {
233
- const { request } = context;
234
- if (!this.requestMatchesEnqueueStrategy(request)) {
235
- // eslint-disable-next-line dot-notation
236
- const message = `Skipping request ${request.id} (starting url: ${request.url} -> loaded url: ${request.loadedUrl}) because it does not match the enqueue strategy (${request['enqueueStrategy']}).`;
237
- this.log.debug(message);
238
- request.noRetry = true;
239
- request.state = RequestState.SKIPPED;
240
- await this.handleSkippedRequest({ url: request.url, reason: 'redirect' });
241
- throw new ContextPipelineInterruptedError(message);
385
+ this.httpClient = httpClient ?? new LazyDefaultHttpClient({ logger: this.log });
386
+ this.proxyConfiguration = proxyConfiguration;
387
+ this.#statusMessageLoggingInterval = statusMessageLoggingInterval;
388
+ this.#statusMessageCallback = statusMessageCallback;
389
+ this.#robotsTxtFileCache = new LruCache({ maxLength: 1000 });
390
+ this.additionalHttpErrorStatusCodes = new Set([...additionalHttpErrorStatusCodes]);
391
+ this.#ignoreHttpErrorStatusCodes = new Set([...ignoreHttpErrorStatusCodes]);
392
+ this.requestHandler = requestHandler ?? this.router;
393
+ this.#failedRequestHandler = failedRequestHandler;
394
+ this.#errorHandler = errorHandler;
395
+ if (requestHandlerTimeoutSecs) {
396
+ this.#requestHandlerTimeoutMillis = requestHandlerTimeoutSecs * 1000;
397
+ }
398
+ else {
399
+ this.#requestHandlerTimeoutMillis = 60_000;
400
+ }
401
+ this.retryOnBlocked = retryOnBlocked;
402
+ this.#respectRobotsTxtFile = respectRobotsTxtFile;
403
+ // The cast undoes ow's assertion signature, which mangles `boolean | object` unions.
404
+ const transactionalStorageOption = transactionalStorage;
405
+ this.#transactionalStorageEnabled = transactionalStorageOption !== false;
406
+ this.#storageWritePolicy = typeof transactionalStorageOption === 'object' ? transactionalStorageOption : {};
407
+ this.#onSkippedRequest = onSkippedRequest;
408
+ // allow at least 5min for internal timeouts
409
+ this.internalTimeoutMillis =
410
+ serviceLocator.getConfiguration().internalTimeoutMillis ??
411
+ Math.max(this.#requestHandlerTimeoutMillis * 2, 300e3);
412
+ this.#maxRequestRetries = maxRequestRetries;
413
+ this.#maxCrawlDepth = maxCrawlDepth;
414
+ this.#statisticsDep = OwnedOrInjected.resolve(statistics,
415
+ // A crawler-built default tracks the built-in fields only. A non-empty `StatisticStateExtension` can
416
+ // only be satisfied by an injected instance carrying the matching `state`, so this branch does
417
+ // not run in that case - hence the cast.
418
+ () => new Statistics({
419
+ logMessage: `${this.constructor.name} request statistics:`,
420
+ log: this.log,
421
+ id: this.#identity.id,
422
+ }));
423
+ if (sessionPool && proxyConfiguration) {
424
+ this.log.warning('Both `sessionPool` and `proxyConfiguration` were provided to the crawler. ' +
425
+ 'The `proxyConfiguration` is ignored - sessions from the supplied pool keep whatever ' +
426
+ '`proxyInfo` they were created with. Configure proxies on the pool instead, ' +
427
+ 'e.g. via `addSession({ proxyInfo })` or a custom `createSessionFunction`.');
428
+ }
429
+ this.#sessionPoolDep = OwnedOrInjected.resolve(sessionPool, () => new SessionPool({
430
+ createSessionFunction: async (opts) => new Session({
431
+ ...opts?.sessionOptions,
432
+ proxyInfo: opts?.sessionOptions?.proxyInfo ?? (await this.proxyConfiguration?.newProxyInfo()),
433
+ }),
434
+ }));
435
+ this.blockedStatusCodes = new Set(blockedStatusCodesInput ?? BLOCKED_STATUS_CODES);
436
+ const maxSignedInteger = 2 ** 31 - 1;
437
+ if (this.#requestHandlerTimeoutMillis > maxSignedInteger) {
438
+ this.log.warning(`requestHandlerTimeoutMillis ${this.#requestHandlerTimeoutMillis}` +
439
+ ` does not fit a signed 32-bit integer. Limiting the value to ${maxSignedInteger}`);
440
+ this.#requestHandlerTimeoutMillis = maxSignedInteger;
441
+ }
442
+ this.internalTimeoutMillis = Math.min(this.internalTimeoutMillis, maxSignedInteger);
443
+ this.#maxRequestsPerCrawl = maxRequestsPerCrawl;
444
+ const isMaxPagesExceeded = () => this.#maxRequestsPerCrawl && this.#maxRequestsPerCrawl <= this.handledRequestsCount;
445
+ // eslint-disable-next-line prefer-const
446
+ let { isFinishedFunction, isTaskReadyFunction } = taskLoopOptions;
447
+ // override even if `isFinishedFunction` provided by user - `keepAlive` has higher priority
448
+ if (keepAlive) {
449
+ isFinishedFunction = async () => false;
450
+ }
451
+ const crawlerOwnedTaskLoopConfiguration = {
452
+ runTaskFunction: async () => {
453
+ const source = this.requestManager;
454
+ if (!source)
455
+ throw new Error('Request provider is not initialized!');
456
+ const request = await this.resolveRequest();
457
+ if (!request) {
458
+ return;
459
+ }
460
+ // Started here, rather than in `handleRequest`, so that a failure during context pipeline
461
+ // initialization (e.g. a browser page timing out before the request handler ever runs) is
462
+ // still accounted for by `recordRequestFailure` below - which is a no-op without a
463
+ // matching `recordRequestStart`.
464
+ this.statistics.recordRequestStart(request.id || request.uniqueKey);
465
+ const crawlingContext = { request };
466
+ try {
467
+ // The transaction spans the whole pipeline call, covering the navigation hooks
468
+ // and `extendContext` too; `handleRequest` drives its outcome explicitly.
469
+ await this.runInStorageTransaction(async () =>
470
+ // Navigation, the navigation hooks and the request handler are timed individually, but the
471
+ // phases between them are not, so a request could still get stuck indefinitely. This is the
472
+ // catch-all for that - see `raceWithTimeout` for why it is a bare timer, not a timeout frame.
473
+ await this.withRequestTimeout(crawlingContext, this.basicContextPipeline
474
+ .chain(this.contextPipeline)
475
+ .call(crawlingContext, (ctx) => this.handleRequest(ctx, source, request))));
476
+ }
477
+ catch (error) {
478
+ // ContextPipelineInterruptedError means the request was intentionally skipped
479
+ // (e.g., doesn't match enqueue strategy after redirect). Just return gracefully.
480
+ if (error instanceof ContextPipelineInterruptedError) {
481
+ this.statistics.discardRequestRecord(request.id || request.uniqueKey);
482
+ await this.timeoutAndRetry(async () => this.requestManager?.markRequestAsHandled(request), this.internalTimeoutMillis, `Marking request ${crawlingContext.request.url} (${crawlingContext.request.id}) as handled timed out after ${this.internalTimeoutMillis / 1e3} seconds.`);
483
+ return;
484
+ }
485
+ // If the error happened during pipeline initialization (e.g., navigation timeout, session/proxy error,
486
+ // i.e. not in user's requestHandler), handle it through the normal error flow. A bare `TimeoutError`
487
+ // here is the internal timeout above firing - anything else thrown inside the pipeline arrives wrapped.
488
+ const isPipelineError = error instanceof ContextPipelineInitializationError ||
489
+ error instanceof SessionError ||
490
+ error instanceof TimeoutError;
491
+ if (isPipelineError) {
492
+ const unwrappedError = this.unwrapError(error);
493
+ await this.requestFunctionErrorHandler(unwrappedError, crawlingContext, request, this.requestManager);
494
+ // SessionError already retired the session in `requestFunctionErrorHandler`;
495
+ // skip `markBad` to avoid double-counting usage/error score.
496
+ if (!this.errorAbsolvesSession(unwrappedError)) {
497
+ crawlingContext.session?.markBad();
498
+ }
499
+ return;
500
+ }
501
+ throw this.unwrapError(error);
502
+ }
503
+ finally {
504
+ // Run request-scoped deferred cleanups only after the whole request lifecycle - including the user's error handler - has finished.
505
+ const deferredCleanup = crawlingContext[deferredCleanupKey] ?? [];
506
+ await Promise.all(deferredCleanup.map((fn) => fn().catch((cleanupError) => this.log.debug('Error in deferred cleanup', { error: cleanupError }))));
242
507
  }
243
- return context;
244
508
  },
245
- });
246
- return contextPipeline;
247
- };
248
- if (requestManager !== undefined) {
249
- if (requestList !== undefined || requestQueue !== undefined) {
250
- throw new Error('The `requestManager` option cannot be used in conjunction with `requestList` and/or `requestQueue`');
251
- }
252
- this.requestManager = requestManager;
253
- this.requestQueue = requestManager; // TODO(v4) - the cast is not fully legitimate here, but it's fine for internal usage by the BasicCrawler
509
+ isTaskReadyFunction: async () => {
510
+ if (isMaxPagesExceeded()) {
511
+ this.#liveRun?.logOnce('shuttingDown', 'Crawler reached the maxRequestsPerCrawl limit of ' +
512
+ `${this.#maxRequestsPerCrawl} requests and will shut down soon. Requests that are in progress will be allowed to finish.`);
513
+ return false;
514
+ }
515
+ if (this.#run?.stopRequested) {
516
+ this.#liveRun?.logOnce('shuttingDown', 'No new requests are allowed because the `stop()` method has been called. ' +
517
+ 'Ongoing requests will be allowed to complete.');
518
+ return false;
519
+ }
520
+ return isTaskReadyFunction ? await isTaskReadyFunction() : await this.isTaskReadyFunction();
521
+ },
522
+ isFinishedFunction: async () => {
523
+ if (isMaxPagesExceeded()) {
524
+ this.log.info(`Earlier, the crawler reached the maxRequestsPerCrawl limit of ${this.#maxRequestsPerCrawl} requests ` +
525
+ 'and all requests that were in progress at that time have now finished. ' +
526
+ `In total, the crawler processed ${this.handledRequestsCount} requests and will shut down.`);
527
+ return true;
528
+ }
529
+ if (this.#run?.stopRequested) {
530
+ this.log.info('The crawler has finished all the remaining ongoing requests and will shut down now.');
531
+ return true;
532
+ }
533
+ // `maybeFinish()` calls this only once nothing is in flight (`autoscaled_pool.ts`) - the point
534
+ // where a crawl that cannot progress becomes distinguishable from one that is merely waiting,
535
+ // and the only place where throwing does not abandon requests mid-processing.
536
+ const state = await this.requestManager?.checkReadiness();
537
+ // Under `keepAlive`, outliving a domain that will not let us through is the whole point.
538
+ if (state?.status === 'stalled' && !keepAlive) {
539
+ throw new PersistentRateLimitError(`Giving up: ${state.reason}`);
540
+ }
541
+ const isFinished = isFinishedFunction
542
+ ? await isFinishedFunction()
543
+ : state === undefined || state.status === 'finished';
544
+ if (isFinished) {
545
+ const reason = isFinishedFunction
546
+ ? "Crawler's custom isFinishedFunction() returned true, the crawler will shut down."
547
+ : 'All requests from the queue have been processed, the crawler will shut down.';
548
+ this.log.info(reason);
549
+ }
550
+ return isFinished;
551
+ },
552
+ log: this.log,
553
+ };
554
+ this.#taskLoopOptions = { ...taskLoopOptions, ...crawlerOwnedTaskLoopConfiguration };
555
+ this.#resolveConcurrencySystem = () => OwnedOrInjected.resolve(concurrencySystem, () => this.createDefaultConcurrencySystem({
556
+ minConcurrency,
557
+ maxConcurrency,
558
+ maxTasksPerMinute: maxRequestsPerMinute,
559
+ // Spread conditionally - an explicit `undefined` would clobber a subclass default, see
560
+ // `HTTP_OPTIMIZED_CONCURRENCY_SYSTEM_OPTIONS`.
561
+ ...(initialConcurrency !== undefined && { desiredConcurrency: initialConcurrency }),
562
+ log: this.log,
563
+ }));
254
564
  }
255
- else {
256
- this.requestList = requestList;
257
- this.requestQueue = requestQueue;
258
- }
259
- this.httpClient = httpClient ?? new GotScrapingHttpClient();
260
- this.proxyConfiguration = proxyConfiguration;
261
- this.log = log;
262
- this.statusMessageLoggingInterval = statusMessageLoggingInterval;
263
- this.statusMessageCallback = statusMessageCallback;
264
- this.events = config.getEventManager();
265
- this.domainAccessedTime = new Map();
266
- this.experiments = experiments;
267
- this.robotsTxtFileCache = new LruCache({ maxLength: 1000 });
268
- this.handleSkippedRequest = this.handleSkippedRequest.bind(this);
269
- this.requestHandler = requestHandler ?? this.router;
270
- this.failedRequestHandler = failedRequestHandler;
271
- this.errorHandler = errorHandler;
272
- if (requestHandlerTimeoutSecs) {
273
- this.requestHandlerTimeoutMillis = requestHandlerTimeoutSecs * 1000;
565
+ finally {
566
+ serviceLocatorScope.exitScope();
274
567
  }
275
- else {
276
- this.requestHandlerTimeoutMillis = 60_000;
277
- }
278
- this.retryOnBlocked = retryOnBlocked;
279
- this.respectRobotsTxtFile = respectRobotsTxtFile;
280
- this.onSkippedRequest = onSkippedRequest;
281
- const tryEnv = (val) => (val == null ? null : +val);
282
- // allow at least 5min for internal timeouts
283
- this.internalTimeoutMillis =
284
- tryEnv(process.env.CRAWLEE_INTERNAL_TIMEOUT) ?? Math.max(this.requestHandlerTimeoutMillis * 2, 300e3);
285
- // override the default internal timeout of request queue to respect `requestHandlerTimeoutMillis`
286
- if (this.requestQueue) {
287
- this.requestQueue.internalTimeoutMillis = this.internalTimeoutMillis;
288
- // for request queue v2, we want to lock requests for slightly longer than the request handler timeout so that there is some padding for locking-related overhead,
289
- // but never for less than a minute
290
- this.requestQueue.requestLockSecs = Math.max(this.requestHandlerTimeoutMillis / 1000 + 5, 60);
291
- }
292
- this.maxRequestRetries = maxRequestRetries;
293
- this.maxCrawlDepth = maxCrawlDepth;
294
- this.sameDomainDelayMillis = sameDomainDelaySecs * 1000;
295
- this.maxSessionRotations = maxSessionRotations;
296
- this.stats = new Statistics({
297
- logMessage: `${log.getOptions().prefix} request statistics:`,
298
- log,
299
- config,
300
- ...statisticsOptions,
301
- });
302
- this.sessionPoolOptions = {
303
- ...sessionPoolOptions,
304
- log,
305
- };
306
- if (this.retryOnBlocked) {
307
- this.sessionPoolOptions.blockedStatusCodes = sessionPoolOptions.blockedStatusCodes ?? [];
308
- if (this.sessionPoolOptions.blockedStatusCodes.length !== 0) {
309
- log.warning(`Both 'blockedStatusCodes' and 'retryOnBlocked' are set. Please note that the 'retryOnBlocked' feature might not work as expected.`);
310
- }
568
+ }
569
+ /**
570
+ * Builds the crawler-owned default {@link ConcurrencySystem} from the resolved
571
+ * `minConcurrency`/`maxConcurrency`/`initialConcurrency`/`maxRequestsPerMinute` shortcuts. Not called when a
572
+ * {@link BasicCrawlerOptions.concurrencySystem|`concurrencySystem`} was injected.
573
+ *
574
+ * Subclasses may override this to tune the default system (e.g. {@link HttpCrawler} raises the starting
575
+ * concurrency and relaxes the event loop signal) while still honouring the user's shortcuts.
576
+ */
577
+ createDefaultConcurrencySystem(options) {
578
+ return new ConcurrencySystem(options);
579
+ }
580
+ /**
581
+ * Determines if the given HTTP status code is an error status code given
582
+ * the default behaviour and user-set preferences.
583
+ * @param status
584
+ * @returns `true` if the status code is considered an error, `false` otherwise
585
+ */
586
+ isErrorStatusCode(status) {
587
+ const excludeError = this.#ignoreHttpErrorStatusCodes.has(status);
588
+ const includeError = this.additionalHttpErrorStatusCodes.has(status);
589
+ return (status >= 500 && !excludeError) || includeError;
590
+ }
591
+ /**
592
+ * Builds the basic context pipeline that transforms `{ request }` into a full `CrawlingContext`.
593
+ * This handles base context creation, session resolution, and context helpers.
594
+ */
595
+ buildBasicContextPipeline() {
596
+ return ContextPipeline.create()
597
+ .compose({ action: this.checkRobotsTxt.bind(this) })
598
+ .compose({ action: (context) => this.createBaseContext(context) })
599
+ .compose({ action: this.resolveSession.bind(this) })
600
+ .compose({ action: this.createContextHelpers.bind(this) });
601
+ }
602
+ async checkRobotsTxt({ request }) {
603
+ if (!(await this.isAllowedBasedOnRobotsTxtFile(request.url))) {
604
+ this.log.warning(`Skipping request ${request.url} (${request.id}) because it is disallowed based on robots.txt`);
605
+ request.state = RequestState.SKIPPED;
606
+ request.noRetry = true;
607
+ await this.#handleSkippedRequest({
608
+ request,
609
+ reason: 'robotsTxt',
610
+ });
611
+ throw new ContextPipelineInterruptedError(`Skipping request ${request.url} as disallowed by robots.txt`);
311
612
  }
312
- this.useSessionPool = useSessionPool;
313
- const maxSignedInteger = 2 ** 31 - 1;
314
- if (this.requestHandlerTimeoutMillis > maxSignedInteger) {
315
- log.warning(`requestHandlerTimeoutMillis ${this.requestHandlerTimeoutMillis}` +
316
- ` does not fit a signed 32-bit integer. Limiting the value to ${maxSignedInteger}`);
317
- this.requestHandlerTimeoutMillis = maxSignedInteger;
318
- }
319
- this.internalTimeoutMillis = Math.min(this.internalTimeoutMillis, maxSignedInteger);
320
- this.maxRequestsPerCrawl = maxRequestsPerCrawl;
321
- const isMaxPagesExceeded = () => this.maxRequestsPerCrawl && this.maxRequestsPerCrawl <= this.handledRequestsCount;
322
- // eslint-disable-next-line prefer-const
323
- let { isFinishedFunction, isTaskReadyFunction } = autoscaledPoolOptions;
324
- // override even if `isFinishedFunction` provided by user - `keepAlive` has higher priority
325
- if (keepAlive) {
326
- isFinishedFunction = async () => false;
327
- }
328
- const basicCrawlerAutoscaledPoolConfiguration = {
329
- minConcurrency: minConcurrency ?? autoscaledPoolOptions?.minConcurrency,
330
- maxConcurrency: maxConcurrency ?? autoscaledPoolOptions?.maxConcurrency,
331
- maxTasksPerMinute: maxRequestsPerMinute ?? autoscaledPoolOptions?.maxTasksPerMinute,
332
- runTaskFunction: this._runTaskFunction.bind(this),
333
- isTaskReadyFunction: async () => {
334
- if (isMaxPagesExceeded()) {
335
- if (this.shouldLogMaxProcessedRequestsExceeded) {
336
- log.info('Crawler reached the maxRequestsPerCrawl limit of ' +
337
- `${this.maxRequestsPerCrawl} requests and will shut down soon. Requests that are in progress will be allowed to finish.`);
338
- this.shouldLogMaxProcessedRequestsExceeded = false;
339
- }
340
- return false;
341
- }
342
- return isTaskReadyFunction ? await isTaskReadyFunction() : await this._isTaskReadyFunction();
613
+ return {};
614
+ }
615
+ /**
616
+ * Builds the subclass-specific context pipeline that transforms a `CrawlingContext` into the crawler's target context type.
617
+ * Subclasses should override this to add their own pipeline stages.
618
+ */
619
+ buildContextPipeline() {
620
+ return ContextPipeline.create();
621
+ }
622
+ createBaseContext(context) {
623
+ const deferredCleanup = [];
624
+ return {
625
+ id: cryptoRandomObjectId(10),
626
+ log: this.log,
627
+ pushData: this.pushData.bind(this),
628
+ useState: this.useState.bind(this),
629
+ getKeyValueStore: async (identifier) => KeyValueStore.open(identifier),
630
+ registerDeferredCleanup: (cleanup) => {
631
+ deferredCleanup.push(cleanup);
343
632
  },
344
- isFinishedFunction: async () => {
345
- if (isMaxPagesExceeded()) {
346
- log.info(`Earlier, the crawler reached the maxRequestsPerCrawl limit of ${this.maxRequestsPerCrawl} requests ` +
347
- 'and all requests that were in progress at that time have now finished. ' +
348
- `In total, the crawler processed ${this.handledRequestsCount} requests and will shut down.`);
349
- return true;
633
+ afterStorageCommit: (callback) => {
634
+ const transaction = currentStorageTransaction();
635
+ if (transaction === undefined) {
636
+ throw new Error('afterStorageCommit() needs an active storage transaction, and there is none. ' +
637
+ "With `transactionalStorage: false` the request's writes are applied as they are " +
638
+ 'made, so they throw at the call site instead of at commit time.');
350
639
  }
351
- const isFinished = isFinishedFunction
352
- ? await isFinishedFunction()
353
- : await this._defaultIsFinishedFunction();
354
- if (isFinished) {
355
- const reason = isFinishedFunction
356
- ? "Crawler's custom isFinishedFunction() returned true, the crawler will shut down."
357
- : 'All requests from the queue have been processed, the crawler will shut down.';
358
- log.info(reason);
640
+ transaction.afterCommit(callback);
641
+ },
642
+ extendTimeout: (secs) => {
643
+ const extraMillis = secs * 1000;
644
+ // the current `addTimeoutToPromise` window (the request handler, or a navigation hook)...
645
+ extendTimeout(extraMillis);
646
+ // ...the internal timeout around the whole request, which is not an `addTimeoutToPromise` frame...
647
+ context[extendTimeoutKey]?.(extraMillis);
648
+ // ...and, when called from within the navigation phase, its shared window, so extending a hook
649
+ // extends the whole navigation budget rather than just that hook's step.
650
+ if (context[navigationDeadlineKey] !== undefined) {
651
+ context[navigationDeadlineKey] += extraMillis;
359
652
  }
360
- return isFinished;
361
653
  },
362
- log,
654
+ [deferredCleanupKey]: deferredCleanup,
655
+ };
656
+ }
657
+ async resolveRequest() {
658
+ const request = await this.timeoutAndRetry(this.fetchNextRequest.bind(this), this.internalTimeoutMillis, `Fetching next request timed out after ${this.internalTimeoutMillis / 1e3} seconds.`);
659
+ // Reset loadedUrl so an old one is not carried over to retries.
660
+ if (request) {
661
+ request.loadedUrl = undefined;
662
+ }
663
+ return request;
664
+ }
665
+ async resolveSession({ request }) {
666
+ const session = await this.timeoutAndRetry(async () => {
667
+ const existingSession = await this.sessionPool.getSession(request.sessionId);
668
+ if (!existingSession) {
669
+ throw new ContextPipelineInitializationError(new MissingSessionError(request.sessionId));
670
+ }
671
+ return existingSession;
672
+ }, this.internalTimeoutMillis, `Fetching session timed out after ${this.internalTimeoutMillis / 1e3} seconds.`);
673
+ return { session, proxyInfo: session?.proxyInfo };
674
+ }
675
+ async createContextHelpers({ request, session }) {
676
+ const addRequests = async (requests, options = {}) => {
677
+ const newCrawlDepth = request.crawlDepth + 1;
678
+ const requestsGenerator = this.addCrawlDepthRequestGenerator(requests, newCrawlDepth);
679
+ return await this.addRequests(requestsGenerator, options);
363
680
  };
364
- this.autoscaledPoolOptions = { ...autoscaledPoolOptions, ...basicCrawlerAutoscaledPoolConfiguration };
681
+ const sendRequest = createSendRequest(this.httpClient, request, session);
682
+ return { addRequests, sendRequest };
683
+ }
684
+ buildFinalContextPipeline() {
685
+ const subclassPipeline = (this.#contextPipelineOptions.contextPipelineBuilder?.() ??
686
+ this.buildContextPipeline());
687
+ // `extendContext` runs *before* the subclass navigation pipeline (which includes the
688
+ // pre/post-navigation hooks). This makes the extension visible to those hooks and to the
689
+ // request handler alike. The trade-off is that `extendContext` cannot access
690
+ // navigation-dependent context members (e.g. `page`, `response`, `$`, `body`), as those
691
+ // don't exist yet at this point in the pipeline.
692
+ // The `extendContext` output (`ContextExtension`) is carried through the subclass pipeline at
693
+ // runtime (the pipeline copies each middleware's returned members onto the shared context), but
694
+ // TypeScript cannot express that `Context` transitively includes `ContextExtension` here. The
695
+ // casts below are sound because `buildFinalContextPipeline` is declared to return the fully
696
+ // resolved `ExtendedContext` (= `Context & ContextExtension`).
697
+ const { extendContext } = this.#contextPipelineOptions;
698
+ let contextPipeline;
699
+ if (extendContext !== undefined) {
700
+ contextPipeline = ContextPipeline.create()
701
+ .compose({ action: async (context) => await extendContext(context) })
702
+ .chain(subclassPipeline);
703
+ }
704
+ else {
705
+ contextPipeline = subclassPipeline;
706
+ }
707
+ contextPipeline = contextPipeline.compose({
708
+ action: async (context) => {
709
+ const { request } = context;
710
+ if (request && !this.requestMatchesEnqueueStrategy(request)) {
711
+ // eslint-disable-next-line dot-notation
712
+ const message = `Skipping request ${request.id} (starting url: ${request.url} -> loaded url: ${request.loadedUrl}) because it does not match the enqueue strategy (${request['enqueueStrategy']}).`;
713
+ this.log.debug(message);
714
+ request.noRetry = true;
715
+ request.state = RequestState.SKIPPED;
716
+ await this.#handleSkippedRequest({ request, reason: 'redirect' });
717
+ throw new ContextPipelineInterruptedError(message);
718
+ }
719
+ return context;
720
+ },
721
+ });
722
+ return contextPipeline;
365
723
  }
366
724
  /**
367
725
  * Checks if the given error is a proxy error by comparing its message to a list of known proxy error messages.
@@ -370,157 +728,212 @@ export class BasicCrawler {
370
728
  * @param error The error to check.
371
729
  */
372
730
  isProxyError(error) {
373
- return ROTATE_PROXY_ERRORS.some((x) => this._getMessageFromError(error)?.includes(x));
731
+ return ROTATE_PROXY_ERRORS.some((x) => this.getMessageFromError(error)?.includes(x));
374
732
  }
375
733
  /**
734
+ * Sets the status message for the current crawler run.
735
+ *
376
736
  * This method is periodically called by the crawler, every `statusMessageLoggingInterval` seconds.
737
+ *
738
+ * The message is logged and broadcast via the {@link EventType.STATUS_MESSAGE|`statusMessage`}
739
+ * event. Integrations such as the Apify SDK subscribe to that event and forward the message to
740
+ * their status-reporting backend (e.g. the Apify platform).
377
741
  */
378
- async setStatusMessage(message, options = {}) {
742
+ setStatusMessage(message, options = {}) {
379
743
  const data = options.isStatusMessageTerminal != null ? { terminal: options.isStatusMessageTerminal } : undefined;
380
- this.log.internal(LogLevel[options.level ?? 'DEBUG'], message, data);
381
- const client = this.config.getStorageClient();
382
- if (!client.setStatusMessage) {
383
- return;
384
- }
385
- // just to be sure, this should be fast
386
- await addTimeoutToPromise(async () => client.setStatusMessage(message, options), 1000, 'Setting status message timed out after 1s').catch((e) => this.log.debug(e.message));
744
+ // Each allowed level has its own method on the logger, so this goes through them rather than through
745
+ // `logWithLevel`, which is abstract and therefore cannot be instrumented.
746
+ this.log[{ DEBUG: 'debug', INFO: 'info', WARNING: 'warning', ERROR: 'error' }[options.level ?? 'DEBUG']](message, data);
747
+ // Broadcast the status message through the event system. Consumers (e.g. the Apify SDK) can
748
+ // subscribe to `EventType.STATUS_MESSAGE` and propagate it to their status-reporting backend.
749
+ // Setting the status message is not a storage concern, so we intentionally don't route it
750
+ // through the storage client anymore.
751
+ serviceLocator.getEventManager().emit(EventType.STATUS_MESSAGE, {
752
+ crawlerId: this.#identity.id,
753
+ message,
754
+ isStatusMessageTerminal: options.isStatusMessageTerminal,
755
+ level: options.level,
756
+ });
387
757
  }
388
758
  getPeriodicLogger() {
389
- let previousState = { ...this.stats.state };
759
+ let previousState = { ...this.statistics.state };
390
760
  const getOperationMode = () => {
391
- const { requestsFailed } = this.stats.state;
761
+ const { requestsFailed } = this.statistics.state;
392
762
  const { requestsFailed: previousRequestsFailed } = previousState;
393
- previousState = { ...this.stats.state };
394
- if (requestsFailed - previousRequestsFailed > 0) {
395
- return 'ERROR';
763
+ previousState = { ...this.statistics.state };
764
+ const failedDelta = requestsFailed - previousRequestsFailed;
765
+ if (failedDelta > 0) {
766
+ return { mode: 'ERROR', failedDelta };
396
767
  }
397
- return 'REGULAR';
768
+ return { mode: 'REGULAR', failedDelta: 0 };
398
769
  };
399
770
  const log = async () => {
400
- const operationMode = getOperationMode();
771
+ const { mode: operationMode, failedDelta } = getOperationMode();
401
772
  let message;
402
773
  if (operationMode === 'ERROR') {
403
- message = `Experiencing problems, ${this.stats.state.requestsFailed - previousState.requestsFailed || this.stats.state.requestsFailed} failed requests in the past ${this.statusMessageLoggingInterval} seconds.`;
774
+ message = `Experiencing problems, ${failedDelta} failed requests in the past ${this.#statusMessageLoggingInterval} seconds.`;
404
775
  }
405
776
  else {
406
- const total = this.requestManager?.getTotalCount();
407
- message = `Crawled ${this.stats.state.requestsFinished}${total ? `/${total}` : ''} pages, ${this.stats.state.requestsFailed} failed requests, desired concurrency ${this.autoscaledPool?.desiredConcurrency ?? 0}.`;
777
+ const total = await this.requestManager?.getTotalCount();
778
+ message = `Crawled ${this.statistics.state.requestsSucceeded}${total ? `/${total}` : ''} pages, ${this.statistics.state.requestsFailed} failed requests, desired concurrency ${this.concurrencySystem?.desiredConcurrency ?? 0}.`;
408
779
  }
409
- if (this.statusMessageCallback) {
410
- await this.statusMessageCallback({
780
+ if (this.#statusMessageCallback) {
781
+ await this.#statusMessageCallback({
411
782
  crawler: this,
412
- state: this.stats.state,
783
+ state: this.statistics.state,
413
784
  previousState,
414
785
  message,
415
786
  });
416
787
  return;
417
788
  }
418
- await this.setStatusMessage(message);
789
+ this.setStatusMessage(message);
419
790
  };
420
- const interval = setInterval(log, this.statusMessageLoggingInterval * 1e3);
791
+ const interval = setInterval(log, this.#statusMessageLoggingInterval * 1e3);
421
792
  return { log, stop: () => clearInterval(interval) };
422
793
  }
423
794
  /**
424
- * Runs the crawler. Returns a promise that resolves once all the requests are processed
425
- * and `autoscaledPool.isFinished` returns `true`.
795
+ * Runs the crawler. Returns a promise that resolves once every request has been processed and the crawler's
796
+ * finished-check ({@link BasicCrawlerOptions.taskLoopOptions|`taskLoopOptions.isFinishedFunction`}, or the
797
+ * default "the request manager is empty") reports that the crawl is over.
426
798
  *
427
799
  * We can use the `requests` parameter to enqueue the initial requests — it is a shortcut for
428
800
  * running {@link BasicCrawler.addRequests|`crawler.addRequests()`} before {@link BasicCrawler.run|`crawler.run()`}.
429
801
  *
802
+ * Calling `run()` again on the same instance keeps crawling the same request manager - requests the previous
803
+ * run handled (a failed one counts as handled) are not processed again. Purge the queue or open a fresh one
804
+ * if that is what you want.
805
+ *
430
806
  * @param [requests] The requests to add.
431
- * @param [options] Options for the request queue.
807
+ * @param [options] Options for adding the initial requests.
432
808
  */
433
809
  async run(requests, options) {
434
- if (this.running) {
435
- throw new Error('This crawler instance is already running, you can add more requests to it via `crawler.addRequests()`.');
436
- }
437
- const { purgeRequestQueue = true, ...addRequestsOptions } = options ?? {};
438
- if (this.hasFinishedBefore) {
439
- // When executing the run method for the second time explicitly,
440
- // we need to purge the default RQ to allow processing the same requests again - this is important so users can
441
- // pass in failed requests back to the `crawler.run()`, otherwise they would be considered as handled and
442
- // ignored - as a failed requests is still handled.
443
- if (this.requestQueue?.name === 'default' && purgeRequestQueue) {
444
- await this.requestQueue.drop();
445
- this.requestQueue = await this._getRequestQueue();
446
- this.requestManager = undefined;
447
- await this.initializeRequestManager();
448
- this.handledRequestsCount = 0; // This would've been reset by this._init() further down below, but at that point `handledRequestsCount` could prevent `addRequests` from adding the initial requests
810
+ // A crawl is the top level of its own transaction and timeout scope, not a participant in the caller's.
811
+ return withDirectStorageAccess(async () => timeoutStorage.exit(async () => {
812
+ if (this.running) {
813
+ throw new Error('This crawler instance is already running, you can add more requests to it via `crawler.addRequests()`.');
449
814
  }
450
- this.stats.reset();
451
- await this.stats.resetStore();
452
- await this.sessionPool?.resetStore();
453
- }
454
- this.running = true;
455
- this.shouldLogMaxProcessedRequestsExceeded = true;
456
- this.shouldLogMaxEnqueuedRequestsExceeded = true;
457
- await purgeDefaultStorages({
458
- onlyPurgeOnce: true,
459
- client: this.config.getStorageClient(),
460
- config: this.config,
461
- });
462
- if (requests) {
463
- await this.addRequests(requests, addRequestsOptions);
464
- }
465
- await this._init();
466
- await this.stats.startCapturing();
467
- const periodicLogger = this.getPeriodicLogger();
468
- // Don't await, we don't want to block the execution
469
- void this.setStatusMessage('Starting the crawler.', { level: 'INFO' });
470
- const sigintHandler = async () => {
471
- this.log.warning('Pausing... Press CTRL+C again to force exit. To resume, do: CRAWLEE_PURGE_ON_START=0 npm start');
472
- await this._pauseOnMigration();
473
- await this.autoscaledPool.abort();
474
- };
475
- // Attach a listener to handle migration and aborting events gracefully.
476
- const boundPauseOnMigration = this._pauseOnMigration.bind(this);
477
- process.once('SIGINT', sigintHandler);
478
- this.events.on("migrating" /* EventType.MIGRATING */, boundPauseOnMigration);
479
- this.events.on("aborting" /* EventType.ABORTING */, boundPauseOnMigration);
480
- let stats = {};
481
- try {
482
- await this.autoscaledPool.run();
483
- }
484
- finally {
485
- await this.teardown();
486
- await this.stats.stopCapturing();
487
- process.off('SIGINT', sigintHandler);
488
- this.events.off("migrating" /* EventType.MIGRATING */, boundPauseOnMigration);
489
- this.events.off("aborting" /* EventType.ABORTING */, boundPauseOnMigration);
490
- const finalStats = this.stats.calculate();
491
- stats = {
492
- requestsFinished: this.stats.state.requestsFinished,
493
- requestsFailed: this.stats.state.requestsFailed,
494
- retryHistogram: this.stats.requestRetryHistogram,
495
- ...finalStats,
496
- };
497
- this.log.info('Final request statistics:', stats);
498
- if (this.stats.errorTracker.total !== 0) {
499
- const prettify = ([count, info]) => `${count}x: ${info.at(-1).trim()} (${info[0]})`;
500
- this.log.info(`Error analysis:`, {
501
- totalErrors: this.stats.errorTracker.total,
502
- uniqueErrors: this.stats.errorTracker.getUniqueErrorCount(),
503
- mostCommonErrors: this.stats.errorTracker.getMostPopularErrors(3).map(prettify),
815
+ if (this.#hasFinishedBefore) {
816
+ // A supplied statistics instance keeps whatever state it was handed - only wipe a default we built.
817
+ await this.#statisticsDep.ifOwned(async (stats) => {
818
+ stats.reset();
819
+ await stats.resetStore();
820
+ });
821
+ // A session pool the crawler built follows the same blank-slate rule as its statistics.
822
+ await this.#sessionPoolDep.ifOwned(async (pool) => {
823
+ pool.reset();
824
+ await pool.resetStore();
504
825
  });
505
826
  }
506
- const client = this.config.getStorageClient();
507
- if (client.teardown) {
508
- let finished = false;
509
- setTimeout(() => {
510
- if (!finished) {
511
- this.log.info('Waiting for the storage to write its state to file system.');
827
+ // An owned governor is rebuilt for every run, so it always starts from a clean slate — stale
828
+ // resource snapshots or a previous run's scaled desired concurrency would otherwise distort this
829
+ // run's scaling. An injected one is long-lived and its lifecycle belongs to the caller.
830
+ this.#concurrencySystem = this.#resolveConcurrencySystem();
831
+ const run = new CrawlerRun({
832
+ log: this.log,
833
+ concurrencySystem: this.#concurrencySystem.value,
834
+ taskLoopOptions: this.#taskLoopOptions,
835
+ consumer: this.#identity,
836
+ });
837
+ this.#run = run;
838
+ try {
839
+ await purgeDefaultStorages({
840
+ onlyPurgeOnce: true,
841
+ storageBackend: serviceLocator.getStorageBackend(),
842
+ configuration: serviceLocator.getConfiguration(),
843
+ });
844
+ if (requests) {
845
+ await this.addRequests(requests, options);
846
+ }
847
+ // An injected governor is the caller's to run; an owned one is started here and stopped again
848
+ // below if the startup fails. Either way the task loop rejects one that is not running.
849
+ await this.#concurrencySystem.ifOwned((system) => system.start());
850
+ await this.init();
851
+ await this.statistics.startCapturing();
852
+ }
853
+ catch (error) {
854
+ // Clean up here before propagating, otherwise a failed startup would leave the process hanging.
855
+ await this.teardown().catch((teardownError) => {
856
+ this.log.exception(teardownError, 'Cleaning up after a failed crawler startup failed.');
857
+ });
858
+ // The run never began, so let the instance be run again instead of leaving it wedged as `running`.
859
+ await run.finish();
860
+ await this.#concurrencySystem.ifOwned((system) => system.stop());
861
+ throw error;
862
+ }
863
+ const periodicLogger = this.getPeriodicLogger();
864
+ this.setStatusMessage('Starting the crawler.', { level: 'INFO' });
865
+ const sigintHandler = async () => {
866
+ this.log.warning('Pausing... Press CTRL+C again to force exit. To resume, do: CRAWLEE_PURGE_ON_START=0 npm start');
867
+ await this.pauseOnMigration();
868
+ await run.abort();
869
+ };
870
+ // Attach a listener to handle migration and aborting events gracefully.
871
+ const boundPauseOnMigration = this.pauseOnMigration.bind(this);
872
+ process.once('SIGINT', sigintHandler);
873
+ const eventManager = serviceLocator.getEventManager();
874
+ eventManager.on(EventType.MIGRATING, boundPauseOnMigration);
875
+ eventManager.on(EventType.ABORTING, boundPauseOnMigration);
876
+ let stats = {};
877
+ try {
878
+ await run.dispatchRequests();
879
+ }
880
+ finally {
881
+ await this.statistics.stopCapturing();
882
+ await this.teardown();
883
+ process.off('SIGINT', sigintHandler);
884
+ eventManager.off(EventType.MIGRATING, boundPauseOnMigration);
885
+ eventManager.off(EventType.ABORTING, boundPauseOnMigration);
886
+ const finalStats = this.statistics.calculate();
887
+ stats = {
888
+ requestsSucceeded: this.statistics.state.requestsSucceeded,
889
+ requestsFailed: this.statistics.state.requestsFailed,
890
+ retryHistogram: this.statistics.requestRetryHistogram,
891
+ ...finalStats,
892
+ };
893
+ this.log.info('Final request statistics:', stats);
894
+ // A crawl that did nothing while the manager holds only handled requests is a mistake whoever
895
+ // handled them - this run, another crawler on the same queue, or a previous process. Starting
896
+ // against handled requests is not: that is what resuming a crawl looks like.
897
+ if (stats.requestsSucceeded + stats.requestsFailed === 0) {
898
+ // Never let the diagnostic itself break the run.
899
+ const alreadyHandled = (await this.requestManager?.getHandledCount().catch(() => 0)) ?? 0;
900
+ if (alreadyHandled > 0) {
901
+ this.log.warningOnce('This crawl processed no requests - the request manager holds ' +
902
+ `${alreadyHandled} request${alreadyHandled === 1 ? '' : 's'}, all of them ` +
903
+ 'already handled, and a failed request counts as handled too. Nothing ' +
904
+ 'empties a queue between runs, so to crawl them again, purge it ' +
905
+ '(`await queue.purge()`) or use a fresh one (e.g. ' +
906
+ '`RequestQueue.open({ alias: "second-run" })`) with a freshly created ' +
907
+ 'crawler instance.');
512
908
  }
513
- }, 1000);
514
- await client.teardown();
515
- finished = true;
909
+ }
910
+ if (this.statistics.errorTracker.total !== 0) {
911
+ const prettify = ([count, info]) => `${count}x: ${info.at(-1).trim()} (${info[0]})`;
912
+ this.log.info(`Error analysis:`, {
913
+ totalErrors: this.statistics.errorTracker.total,
914
+ uniqueErrors: this.statistics.errorTracker.getUniqueErrorCount(),
915
+ mostCommonErrors: this.statistics.errorTracker.getMostPopularErrors(3).map(prettify),
916
+ });
917
+ }
918
+ const client = serviceLocator.getStorageBackend();
919
+ if (client.teardown) {
920
+ let finished = false;
921
+ setTimeout(() => {
922
+ if (!finished) {
923
+ this.log.info('Waiting for the storage to write its state to file system.');
924
+ }
925
+ }, 1000);
926
+ await client.teardown();
927
+ finished = true;
928
+ }
929
+ periodicLogger.stop();
930
+ this.setStatusMessage(`Finished! Total ${this.statistics.state.requestsSucceeded + this.statistics.state.requestsFailed} requests: ${this.statistics.state.requestsSucceeded} succeeded, ${this.statistics.state.requestsFailed} failed.`, { isStatusMessageTerminal: true, level: 'INFO' });
931
+ await run.finish();
932
+ await this.#concurrencySystem.ifOwned((system) => system.stop());
933
+ this.#hasFinishedBefore = true;
516
934
  }
517
- periodicLogger.stop();
518
- // Don't await, we don't want to block the execution
519
- void this.setStatusMessage(`Finished! Total ${this.stats.state.requestsFinished + this.stats.state.requestsFailed} requests: ${this.stats.state.requestsFinished} succeeded, ${this.stats.state.requestsFailed} failed.`, { isStatusMessageTerminal: true, level: 'INFO' });
520
- this.running = false;
521
- this.hasFinishedBefore = true;
522
- }
523
- return stats;
935
+ return stats;
936
+ }));
524
937
  }
525
938
  /**
526
939
  * Gracefully stops the current run of the crawler.
@@ -529,60 +942,159 @@ export class BasicCrawler {
529
942
  *
530
943
  * To stop the crawler immediately, use {@link BasicCrawler.teardown|`crawler.teardown()`} instead.
531
944
  */
532
- stop(message = 'The crawler has been gracefully stopped.') {
533
- // Gracefully starve the this.autoscaledPool, so it doesn't start new tasks. Resolves once the pool is cleared.
534
- this.autoscaledPool
535
- ?.pause()
536
- // Resolves the `autoscaledPool.run()` promise in the `BasicCrawler.run()` method. Since the pool is already paused, it resolves immediately and doesn't kill any tasks.
537
- .then(async () => this.autoscaledPool?.abort())
538
- .then(() => this.log.info(message))
539
- .catch((err) => {
540
- this.log.error('An error occurred when stopping the crawler:', err);
541
- });
945
+ stop(reason = 'The crawler has been gracefully stopped.') {
946
+ const run = this.#liveRun;
947
+ if (run === undefined) {
948
+ this.log.warning('Cannot stop a crawler that is not running.');
949
+ return;
950
+ }
951
+ run.stop(reason);
542
952
  }
543
- async getRequestQueue() {
544
- if (!this.requestQueue && this.requestList) {
545
- this.log.warningOnce('When using RequestList and RequestQueue at the same time, you should instantiate both explicitly and provide them in the crawler options, to ensure correctly handled restarts of the crawler.');
953
+ /**
954
+ * Stops dispatching new requests, letting the in-progress ones finish. Resolves once they have settled, or rejects
955
+ * after `timeoutSecs` if they take too long. Unlike {@link BasicCrawler.stop|`stop()`}, this does not end the
956
+ * run — {@link BasicCrawler.run|`run()`} stays pending until {@link BasicCrawler.resume|`resume()`}.
957
+ *
958
+ * > *NOTE:* The {@link BasicCrawler.concurrencySystem|concurrency system} keeps monitoring and autoscaling
959
+ * throughout, since a shared one may still be serving other crawlers.
960
+ */
961
+ async pause(timeoutSecs) {
962
+ const run = this.#dispatchingRun;
963
+ if (run === undefined) {
964
+ this.log.warning('Cannot pause a crawler that is not running.');
965
+ return;
546
966
  }
547
- if (!this.requestQueue) {
548
- this.requestQueue = await this._getRequestQueue();
549
- this.requestManager = undefined;
967
+ await run.pause(timeoutSecs);
968
+ }
969
+ /**
970
+ * Resumes a run suspended with {@link BasicCrawler.pause|`pause()`}, letting the crawler dispatch requests
971
+ * again. A no-op on a crawler that is not paused.
972
+ */
973
+ resume() {
974
+ const run = this.#dispatchingRun;
975
+ if (run === undefined) {
976
+ this.log.warning('Cannot resume a crawler that is not running.');
977
+ return;
550
978
  }
979
+ run.resume();
980
+ }
981
+ /**
982
+ * Returns the crawler's {@link IRequestManager|request manager}, opening the default {@link RequestQueue}
983
+ * if none has been configured or opened yet.
984
+ */
985
+ async getRequestManager() {
551
986
  if (!this.requestManager) {
552
- this.requestManager =
553
- this.requestList === undefined
554
- ? this.requestQueue
555
- : new RequestManagerTandem(this.requestList, this.requestQueue);
987
+ this.requestManager = await this.openOwnedRequestQueue();
988
+ }
989
+ // Apply the processing-time hint here (an async lifecycle point) rather than in the constructor,
990
+ // now that `setExpectedRequestProcessingTimeSecs` is async. The hint is raise-only and idempotent,
991
+ // but guard so we do not re-issue it on every call.
992
+ if (!this.#requestManagerTimeoutsApplied) {
993
+ this.#requestManagerTimeoutsApplied = true;
994
+ await this.applyRequestManagerTimeouts(this.requestManager);
995
+ }
996
+ return this.requestManager;
997
+ }
998
+ /**
999
+ * @deprecated Use {@link BasicCrawler.getRequestManager|`getRequestManager()`} instead. This returns the
1000
+ * crawler's request manager, which is no longer guaranteed to be a {@link RequestQueue}.
1001
+ */
1002
+ async getRequestQueue() {
1003
+ return this.getRequestManager();
1004
+ }
1005
+ /**
1006
+ * Opens the default {@link RequestQueue} — the crawler's own, read from when the caller supplied nothing.
1007
+ * @private
1008
+ */
1009
+ async openOwnedRequestQueue() {
1010
+ // The first crawler instance uses the default queue (null identifier);
1011
+ // subsequent instances get their own queue via a unique alias so they don't collide.
1012
+ const identifier = this.#identity.instanceIndex === 0 ? null : { alias: `__default_${this.#identity.id}__` };
1013
+ return RequestQueue.open(identifier, { configuration: serviceLocator.getConfiguration() });
1014
+ }
1015
+ /**
1016
+ * Tells a request manager how long we expect to hold a fetched request, so that one backed by a
1017
+ * locking storage backend keeps it reserved for slightly longer than the request handler timeout
1018
+ * (with some padding for overhead), but never for less than a minute. This prevents a long-running
1019
+ * request from being handed out a second time while it is still being processed — and it works
1020
+ * regardless of whether the manager is a plain {@link RequestQueue} or a `RequestManagerTandem`.
1021
+ */
1022
+ async applyRequestManagerTimeouts(requestManager) {
1023
+ // A router route may hold a request for longer than the crawler's own timeout, and we cannot know
1024
+ // which routes a run will hit, so reserve for the longest one any route asked for. The hint is
1025
+ // raise-only, so erring high here is safe.
1026
+ const maxRouteTimeoutSecs = this.requestHandler.getMaxTimeoutSecs?.() ?? 0;
1027
+ const handlerTimeoutSecs = Math.max(this.#requestHandlerTimeoutMillis / 1000, maxRouteTimeoutSecs);
1028
+ await requestManager.setExpectedRequestProcessingTimeSecs?.(Math.max(handlerTimeoutSecs + 5, 60));
1029
+ }
1030
+ /**
1031
+ * Validates a request source's `userData` against the {@link RouteSchemas|Standard Schema} registered
1032
+ * for its label on the crawler's schema-router (if any), throwing a {@link RequestValidationError} on
1033
+ * mismatch. A no-op when the user's request handler is not a schema-router, or no schema is registered for
1034
+ * the request's label. Applied by the crawler on the add paths it owns — `crawler.addRequests`,
1035
+ * `crawler.run`, `context.addRequests` and `context.enqueueLinks`.
1036
+ */
1037
+ async validateRequestUserData(source) {
1038
+ if (typeof source === 'string') {
1039
+ return;
556
1040
  }
557
- return this.requestQueue;
1041
+ const getSchema = this.requestHandler.getSchema;
1042
+ if (typeof getSchema !== 'function') {
1043
+ return;
1044
+ }
1045
+ // Resolve the label via its public accessors only — the top-level `label` of a `RequestOptions` or the
1046
+ // `Request.label` getter — rather than reaching into `userData`, where the request happens to store it.
1047
+ const target = source;
1048
+ const schema = getSchema(target.label);
1049
+ if (!schema) {
1050
+ return;
1051
+ }
1052
+ // Store the parsed value rather than the raw input, so the queue holds the same coerced `userData` the
1053
+ // handler will see. Assigning through a `Request` instance's setter keeps its internal `__crawlee` meta.
1054
+ target.userData = await validateUserData(target.label, schema, target.userData ?? {});
558
1055
  }
559
1056
  async useState(defaultValue = {}) {
560
- const kvs = await KeyValueStore.open(null, { config: this.config });
561
- return kvs.getAutoSavedValue(BasicCrawler.CRAWLEE_STATE_KEY, defaultValue);
1057
+ const kvs = await KeyValueStore.open(null, { configuration: serviceLocator.getConfiguration() });
1058
+ if (this.#identity.hasExplicitId) {
1059
+ const stateKey = `${BasicCrawler.#CRAWLEE_STATE_KEY}_${this.#identity.id}`;
1060
+ return kvs.getAutoSavedValue(stateKey, defaultValue);
1061
+ }
1062
+ BasicCrawler.#useStateAnonymousIndices.add(this.#identity.instanceIndex);
1063
+ if (BasicCrawler.#useStateAnonymousIndices.size > 1) {
1064
+ serviceLocator
1065
+ .getLogger()
1066
+ .warningOnce('Multiple crawler instances are calling useState() without an explicit `id` option. \n' +
1067
+ 'This means they will share the same state object, which is likely unintended. \n' +
1068
+ 'To fix this, provide a unique `id` option to each crawler instance. \n' +
1069
+ 'Example: new BasicCrawler({ id: "my-crawler-1", ... })');
1070
+ }
1071
+ return kvs.getAutoSavedValue(BasicCrawler.#CRAWLEE_STATE_KEY, defaultValue);
562
1072
  }
563
- get pendingRequestCountApproximation() {
564
- return this.requestManager?.getPendingCount() ?? 0;
1073
+ async #getPendingRequestCountApproximation() {
1074
+ return (await this.requestManager?.getPendingCount()) ?? 0;
565
1075
  }
566
- calculateEnqueuedRequestLimit(explicitLimit) {
567
- if (this.maxRequestsPerCrawl === undefined) {
1076
+ async #calculateEnqueuedRequestLimit(explicitLimit) {
1077
+ if (this.#maxRequestsPerCrawl === undefined) {
568
1078
  return explicitLimit;
569
1079
  }
570
- const limit = Math.max(0, this.maxRequestsPerCrawl - this.handledRequestsCount - this.pendingRequestCountApproximation);
1080
+ const limit = Math.max(0, this.#maxRequestsPerCrawl - this.handledRequestsCount - (await this.#getPendingRequestCountApproximation()));
571
1081
  return Math.min(limit, explicitLimit ?? Infinity);
572
1082
  }
573
- async handleSkippedRequest(options) {
574
- if (options.reason === 'limit' && this.shouldLogMaxEnqueuedRequestsExceeded) {
575
- this.log.info('The number of requests enqueued by the crawler reached the maxRequestsPerCrawl limit of ' +
576
- `${this.maxRequestsPerCrawl} requests and no further requests will be added.`);
577
- this.shouldLogMaxEnqueuedRequestsExceeded = false;
578
- }
579
- if (options.reason === 'enqueueLimit') {
580
- const enqueuedRequestLimit = this.calculateEnqueuedRequestLimit();
581
- if (enqueuedRequestLimit === undefined || enqueuedRequestLimit !== 0) {
582
- this.log.info('The number of requests enqueued by the crawler reached the enqueueLinks limit.');
1083
+ async #handleSkippedRequest(options) {
1084
+ // A skipped request is a *successful* outcome, but the interrupt still unwinds through the
1085
+ // transaction scope, which rolls back - so the skip bookkeeping must write directly.
1086
+ await withDirectStorageAccess(async () => {
1087
+ // Enqueueing happens outside a run too - `addRequests()` before the first `run()` - so these dedupe
1088
+ // against the logger for the crawler's lifetime rather than per run.
1089
+ if (options.reason === 'limit') {
1090
+ this.log.info('The number of requests enqueued by the crawler reached the maxRequestsPerCrawl limit of ' +
1091
+ `${this.#maxRequestsPerCrawl} requests and no further requests will be added.`, undefined, { once: true });
583
1092
  }
584
- }
585
- await this.onSkippedRequest?.(options);
1093
+ if (options.reason === 'depth') {
1094
+ this.log.info(`The crawler reached the maxCrawlDepth limit of ${this.#maxCrawlDepth} and no further requests will be enqueued.`, undefined, { once: true });
1095
+ }
1096
+ await this.#onSkippedRequest?.(options);
1097
+ });
586
1098
  }
587
1099
  /**
588
1100
  * Adds requests to the queue in batches. By default, it will resolve after the initial batch is added, and continue
@@ -590,76 +1102,146 @@ export class BasicCrawler {
590
1102
  * the batches via `waitBetweenBatchesMillis`. If you want to wait for all batches to be added to the queue, you can use
591
1103
  * the `waitForAllRequestsToBeAdded` promise you get in the response object.
592
1104
  *
1105
+ * Optionally, the requests can be filtered using `include`/`exclude` glob or regexp patterns and an
1106
+ * enqueue `strategy` (both AND-ed together, same as {@link CrawlingContext.enqueueLinks|`enqueueLinks`}),
1107
+ * relative to `baseUrl`. Unlike `enqueueLinks`, there is no implicit "current page" to anchor the strategy
1108
+ * to, so `strategy` defaults to {@link EnqueueStrategy.All|`all`} here.
1109
+ *
593
1110
  * This is an alias for calling `addRequestsBatched()` on the implicit `RequestQueue` for this crawler instance.
594
1111
  *
595
1112
  * @param requests The requests to add
596
1113
  * @param options Options for the request queue
597
1114
  */
598
1115
  async addRequests(requests, options = {}) {
599
- await this.getRequestQueue();
600
- const requestLimit = this.calculateEnqueuedRequestLimit();
601
- const skippedBecauseOfRobots = new Set();
602
- const skippedBecauseOfLimit = new Set();
603
- const skippedBecauseOfMaxCrawlDepth = new Set();
1116
+ await this.getRequestManager();
1117
+ if (!isIterable(requests) && !isAsyncIterable(requests)) {
1118
+ throw new Error(`Expected an iterable or async iterable, got ${getObjectType(requests)}`);
1119
+ }
1120
+ parseArgument(options, addRequestsOptionsSchema, 'EnqueueUrlsOptions');
1121
+ // `label`/`userData` apply to every request this call produces, so a single upfront validation
1122
+ // against the label's schema covers them all and fails the whole call fast, rather than failing
1123
+ // lazily once the generator below is drained. Skipped when neither is set - each item still gets
1124
+ // its own per-item validation below, and validating an absent label/userData here would spuriously
1125
+ // check them against a registered default-route schema.
1126
+ if (options.label !== undefined || options.userData !== undefined) {
1127
+ await this.validateRequestUserData({ label: options.label, userData: options.userData });
1128
+ }
1129
+ const requestLimit = await this.#calculateEnqueuedRequestLimit(options.limit);
1130
+ const strategy = options.strategy ?? EnqueueStrategy.All;
1131
+ const urlExcludePatternObjects = options.exclude?.length
1132
+ ? constructUrlPatternObjects(options.exclude)
1133
+ : [];
1134
+ const urlPatternObjects = options.include?.length
1135
+ ? constructUrlPatternObjects(options.include)
1136
+ : [];
1137
+ // The strategy always applies, even when `include` patterns are provided - the two are AND-ed together
1138
+ // (a URL must match an `include` pattern *and* satisfy the strategy). This mirrors crawlee-python.
1139
+ const enqueueStrategyPatterns = options.baseUrl
1140
+ ? buildEnqueueStrategyPatterns(options.baseUrl, strategy)
1141
+ : [];
604
1142
  const isAllowedBasedOnRobotsTxtFile = this.isAllowedBasedOnRobotsTxtFile.bind(this);
605
- const maxCrawlDepth = this.maxCrawlDepth;
606
- ow(requests, ow.object
607
- .is((value) => isIterable(value) || isAsyncIterable(value))
608
- .message((value) => `Expected an iterable or async iterable, got ${getObjectType(value)}`));
1143
+ const maxCrawlDepth = this.#maxCrawlDepth;
1144
+ const validateRequestUserData = this.validateRequestUserData.bind(this);
1145
+ const allSkipped = [];
1146
+ // A skipped source (which can carry arbitrary userData) is only retained if something reads it -
1147
+ // otherwise the URL alone is enough to build the callback argument and to log with.
1148
+ const hasSkippedRequestCallback = this.#onSkippedRequest !== undefined || options.onSkippedRequest !== undefined;
1149
+ const keepSkippedSource = (source) => (hasSkippedRequestCallback ? source : source.url);
1150
+ const reportSkippedRequests = async () => {
1151
+ const skippedRequests = allSkipped.splice(0);
1152
+ if (skippedRequests.length === 0) {
1153
+ return;
1154
+ }
1155
+ const skippedRobotsUrls = skippedRequests
1156
+ .filter((s) => s.reason === 'robotsTxt')
1157
+ .map(({ source }) => (typeof source === 'string' ? source : source.url));
1158
+ if (skippedRobotsUrls.length > 0) {
1159
+ this.log.warning(`Some requests were skipped because they were disallowed based on the robots.txt file`, { skipped: skippedRobotsUrls });
1160
+ }
1161
+ // Only log the limit message when an explicit `limit` was passed (not the internal
1162
+ // `maxRequestsPerCrawl`-derived one), and only once per call.
1163
+ if (options.limit !== undefined && skippedRequests.some((s) => s.reason === 'limit')) {
1164
+ this.log.info(requestLimit === options.limit
1165
+ ? `Skipping requests in this call due to the enqueueLinks limit of ${options.limit}.`
1166
+ : `Skipping requests in this call due to the remaining maxRequestsPerCrawl budget of ${requestLimit}, which is lower than the enqueueLinks limit of ${options.limit}.`);
1167
+ }
1168
+ await Promise.all(skippedRequests.map(async ({ source, reason }) => {
1169
+ const args = createSkippedRequestArgs(source, reason);
1170
+ await this.#handleSkippedRequest(args);
1171
+ await options.onSkippedRequest?.(args);
1172
+ }));
1173
+ };
609
1174
  async function* filteredRequests() {
610
- let yieldedRequestCount = 0;
611
1175
  for await (const request of requests) {
612
- const url = typeof request === 'string' ? request : request.url;
613
- if (requestLimit !== undefined && yieldedRequestCount >= requestLimit) {
614
- skippedBecauseOfLimit.add(url);
1176
+ const [requestOptions] = createRequestOptions([typeof request === 'string' ? request : request], { ...options, strategy });
1177
+ if (!requestOptions) {
1178
+ continue; // invalid URL, silently dropped (matches `createRequestOptions`'s own filtering)
1179
+ }
1180
+ if (maxCrawlDepth !== undefined && requestOptions.crawlDepth > maxCrawlDepth) {
1181
+ allSkipped.push({ source: keepSkippedSource(requestOptions), reason: 'depth' });
615
1182
  continue;
616
1183
  }
617
- if (maxCrawlDepth !== undefined && request.crawlDepth > maxCrawlDepth) {
618
- skippedBecauseOfMaxCrawlDepth.add(url);
1184
+ if (!(await isAllowedBasedOnRobotsTxtFile(requestOptions.url))) {
1185
+ allSkipped.push({ source: keepSkippedSource(requestOptions), reason: 'robotsTxt' });
619
1186
  continue;
620
1187
  }
621
- if (await isAllowedBasedOnRobotsTxtFile(url)) {
622
- yield request;
623
- yieldedRequestCount += 1;
1188
+ const onSkippedByFilter = (opts) => allSkipped.push({ source: keepSkippedSource(opts), reason: 'filters' });
1189
+ // Filter by user patterns first (with exclude)...
1190
+ let filtered = filterRequestOptionsByPatterns([requestOptions], urlPatternObjects.length > 0 ? urlPatternObjects : undefined, urlExcludePatternObjects, strategy, onSkippedByFilter);
1191
+ // ...then filter by the enqueue strategy (making this an AND check)
1192
+ filtered = filterRequestOptionsByPatterns(filtered, enqueueStrategyPatterns.length > 0 ? enqueueStrategyPatterns : undefined, [], strategy, onSkippedByFilter);
1193
+ if (filtered.length === 0) {
1194
+ continue;
624
1195
  }
625
- else {
626
- skippedBecauseOfRobots.add(url);
1196
+ let [finalOptions] = filtered;
1197
+ if (options.transformRequestFunction) {
1198
+ const transformed = applyRequestTransform([finalOptions], options.transformRequestFunction, (r) => allSkipped.push({ source: keepSkippedSource(r), reason: r.skippedReason ?? 'transform' }));
1199
+ if (transformed.length === 0) {
1200
+ continue;
1201
+ }
1202
+ [finalOptions] = transformed;
627
1203
  }
1204
+ await validateRequestUserData(finalOptions);
1205
+ yield new Request(finalOptions);
628
1206
  }
629
1207
  }
630
- const result = await this.requestManager.addRequestsBatched(filteredRequests(), options);
631
- if (skippedBecauseOfRobots.size > 0) {
632
- this.log.warning(`Some requests were skipped because they were disallowed based on the robots.txt file`, {
633
- skipped: [...skippedBecauseOfRobots],
634
- });
635
- }
636
- if (skippedBecauseOfRobots.size > 0 ||
637
- skippedBecauseOfLimit.size > 0 ||
638
- skippedBecauseOfMaxCrawlDepth.size > 0) {
639
- await Promise.all([...skippedBecauseOfRobots]
640
- .map((url) => {
641
- return this.handleSkippedRequest({ url, reason: 'robotsTxt' });
642
- })
643
- .concat([...skippedBecauseOfLimit].map((url) => {
644
- return this.handleSkippedRequest({ url, reason: 'limit' });
645
- }), [...skippedBecauseOfMaxCrawlDepth].map((url) => {
646
- return this.handleSkippedRequest({ url, reason: 'depth' });
647
- })));
648
- }
649
- return result;
1208
+ const result = await this.requestManager.addRequestsBatched(filteredRequests(), {
1209
+ forefront: options.forefront,
1210
+ waitForAllRequestsToBeAdded: options.waitForAllRequestsToBeAdded,
1211
+ batchSize: options.batchSize,
1212
+ waitBetweenBatchesMillis: options.waitBetweenBatchesMillis,
1213
+ maxNewRequests: requestLimit,
1214
+ });
1215
+ // Report requests skipped due to the maxNewRequests budget (i.e. maxRequestsPerCrawl limit, or an
1216
+ // explicit `limit` option)
1217
+ for (const request of result.requestsOverLimit ?? []) {
1218
+ allSkipped.push({ source: request, reason: 'limit' });
1219
+ }
1220
+ await reportSkippedRequests();
1221
+ const waitForAllRequestsToBeAdded = result.waitForAllRequestsToBeAdded.then(async (addedRequests) => {
1222
+ await reportSkippedRequests();
1223
+ return addedRequests;
1224
+ });
1225
+ // Keep callback failures observable to callers that await this promise without emitting an unhandled rejection
1226
+ // when callers intentionally leave background additions running, matching `drainRequestBatches` behavior.
1227
+ void waitForAllRequestsToBeAdded.catch(() => { });
1228
+ return { ...result, waitForAllRequestsToBeAdded };
650
1229
  }
651
1230
  /**
652
1231
  * Pushes data to the specified {@link Dataset}, or the default crawler {@link Dataset} by calling {@link Dataset.pushData}.
653
1232
  */
654
- async pushData(data, datasetIdOrName) {
655
- const dataset = await this.getDataset(datasetIdOrName);
1233
+ async pushData(data, datasetIdentifier) {
1234
+ tryCancel();
1235
+ const dataset = await this.getDataset(datasetIdentifier);
656
1236
  return dataset.pushData(data);
657
1237
  }
658
1238
  /**
659
1239
  * Retrieves the specified {@link Dataset}, or the default crawler {@link Dataset}.
660
1240
  */
661
- async getDataset(idOrName) {
662
- return Dataset.open(idOrName, { config: this.config });
1241
+ async getDataset(identifier) {
1242
+ return Dataset.open(identifier, {
1243
+ configuration: serviceLocator.getConfiguration(),
1244
+ });
663
1245
  }
664
1246
  /**
665
1247
  * Retrieves data from the default crawler {@link Dataset} by calling {@link Dataset.getData}.
@@ -674,8 +1256,9 @@ export class BasicCrawler {
674
1256
  */
675
1257
  async exportData(path, format, options) {
676
1258
  const supportedFormats = ['json', 'csv'];
677
- if (!format && path.match(/\.(json|csv)$/i)) {
678
- format = path.toLowerCase().match(/\.(json|csv)$/)[1];
1259
+ const formatMatch = /\.(json|csv)$/i.exec(path);
1260
+ if (!format && formatMatch) {
1261
+ format = formatMatch[1].toLowerCase();
679
1262
  }
680
1263
  if (!format) {
681
1264
  throw new Error(`Failed to infer format from the path: '${path}'. Supported formats: ${supportedFormats.join(', ')}`);
@@ -694,6 +1277,7 @@ export class BasicCrawler {
694
1277
  const keys = options?.collectAllKeys
695
1278
  ? Array.from(new Set(items.flatMap(Object.keys)))
696
1279
  : Object.keys(items[0]);
1280
+ const { stringify } = await import('csv-stringify/sync');
697
1281
  value = stringify([
698
1282
  keys,
699
1283
  ...items.map((item) => {
@@ -701,13 +1285,13 @@ export class BasicCrawler {
701
1285
  }),
702
1286
  ]);
703
1287
  }
704
- await ensureDir(dirname(path));
1288
+ await mkdir(dirname(path), { recursive: true });
705
1289
  await writeFile(path, value);
706
1290
  this.log.info(`Export to ${path} finished!`);
707
1291
  }
708
1292
  if (format === 'json') {
709
- await ensureDir(dirname(path));
710
- await writeJSON(path, items, { spaces: 4 });
1293
+ await mkdir(dirname(path), { recursive: true });
1294
+ await writeFile(path, `${JSON.stringify(items, null, 4)}\n`);
711
1295
  this.log.info(`Export to ${path} finished!`);
712
1296
  }
713
1297
  return items;
@@ -715,57 +1299,184 @@ export class BasicCrawler {
715
1299
  /**
716
1300
  * Initializes the crawler.
717
1301
  */
718
- async _init() {
719
- if (!this.events.isInitialized()) {
720
- await this.events.init();
721
- this._closeEvents = true;
722
- }
723
- // Initialize AutoscaledPool before awaiting _loadHandledRequestCount(),
724
- // so that the caller can get a reference to it before awaiting the promise returned from run()
725
- // (otherwise there would be no way)
726
- this.autoscaledPool = new AutoscaledPool(this.autoscaledPoolOptions, this.config);
727
- if (this.useSessionPool) {
728
- this.sessionPool = await SessionPool.open(this.sessionPoolOptions, this.config);
729
- // Assuming there are not more than 20 browsers running at once;
730
- this.sessionPool.setMaxListeners(20);
731
- }
732
- await this.initializeRequestManager();
733
- await this._loadHandledRequestCount();
1302
+ async init() {
1303
+ const run = this.#liveRun;
1304
+ if (run === undefined) {
1305
+ throw new Error('There is no crawl in progress - `run()` is the only thing that starts one.');
1306
+ }
1307
+ const eventManager = serviceLocator.getEventManager();
1308
+ if (!eventManager.isInitialized()) {
1309
+ await eventManager.init();
1310
+ run.ownsEventManager = true;
1311
+ }
1312
+ // Warn once at startup if the internal timeout is shorter than the phases it is meant to outlast. It is
1313
+ // floored per request so it will not actually cut them short, but the configured value is then effectively
1314
+ // ignored, which is worth flagging. Checked here (not in the constructor) because a subclass sets its
1315
+ // navigation timeout only after `super()`.
1316
+ const phasesMillis = this.getNavigationTimeoutMillis() + this.resolveRequestHandlerTimeoutMillis(undefined);
1317
+ if (this.internalTimeoutMillis < phasesMillis) {
1318
+ this.log.warning(`CRAWLEE_INTERNAL_TIMEOUT (${this.internalTimeoutMillis / 1000}s) is shorter than the navigation ` +
1319
+ `and request handler timeouts combined (${phasesMillis / 1000}s); it will be raised per request ` +
1320
+ `so it does not cut them short.`);
1321
+ }
1322
+ await this.getRequestManager();
1323
+ }
1324
+ /**
1325
+ * The navigation timeout (pre-navigation hooks, navigation, and post-navigation hooks) in milliseconds, used
1326
+ * to size the internal request timeout. `BasicCrawler` has no navigation phase, so this is 0; the HTTP and
1327
+ * browser crawlers override it with their `navigationTimeoutSecs`.
1328
+ */
1329
+ getNavigationTimeoutMillis() {
1330
+ return 0;
1331
+ }
1332
+ /**
1333
+ * Races the request against the internal timeout (see {@link raceWithTimeout}), sized to outlast the phases
1334
+ * that have their own timeout - the navigation, its hooks, and the request handler - so a legitimately slow
1335
+ * request, a per-route override, or a low `CRAWLEE_INTERNAL_TIMEOUT` is not cut short mid-phase. It takes
1336
+ * whichever is larger: the configured internal timeout, or this request's combined phase budget.
1337
+ */
1338
+ async withRequestTimeout(crawlingContext, work) {
1339
+ const { request } = crawlingContext;
1340
+ const phasesMillis = this.getNavigationTimeoutMillis() + this.resolveRequestHandlerTimeoutMillis(request.label);
1341
+ const timeoutMillis = Math.max(this.internalTimeoutMillis, phasesMillis);
1342
+ await raceWithTimeout(crawlingContext, work, { timeoutMillis, requestId: request.id });
1343
+ }
1344
+ /**
1345
+ * The request handler timeout for a request with the given route label. A router route may override the
1346
+ * crawler's own `requestHandlerTimeoutSecs`; anything else falls back to `fallbackMillis`.
1347
+ *
1348
+ * @param label The request's route label, or `undefined` for the default route / no specific request.
1349
+ * @param fallbackMillis Timeout to use when no route overrides it.
1350
+ */
1351
+ resolveRequestHandlerTimeoutMillis(label, fallbackMillis = this.#requestHandlerTimeoutMillis) {
1352
+ return this.getRouteTimeoutMillis(label) ?? fallbackMillis;
1353
+ }
1354
+ /**
1355
+ * The timeout the router route with the given label asked for, or `undefined` when it did not override one
1356
+ * (or the request handler is not a router at all).
1357
+ */
1358
+ getRouteTimeoutMillis(label) {
1359
+ const getTimeoutSecs = this.requestHandler.getTimeoutSecs;
1360
+ if (typeof getTimeoutSecs !== 'function') {
1361
+ return undefined;
1362
+ }
1363
+ const timeoutSecs = getTimeoutSecs(label);
1364
+ return timeoutSecs === undefined ? undefined : timeoutSecs * 1000;
734
1365
  }
735
1366
  async runRequestHandler(crawlingContext) {
736
- await this.contextPipeline.call(crawlingContext, async (finalContext) => {
737
- await addTimeoutToPromise(async () => this.requestHandler(finalContext), this.requestHandlerTimeoutMillis, `requestHandler timed out after ${this.requestHandlerTimeoutMillis / 1000} seconds (${finalContext.request.id}).`);
1367
+ const timeoutMillis = this.resolveRequestHandlerTimeoutMillis(crawlingContext.request.label);
1368
+ await addTimeoutToPromise(async () => this.requestHandler(crawlingContext), timeoutMillis, `requestHandler timed out after ${timeoutMillis / 1000} seconds (${crawlingContext.request.id}).`);
1369
+ }
1370
+ /**
1371
+ * Runs `callback` inside a {@link StorageTransaction}, unless transactional storage is disabled.
1372
+ * Deliberately does **not** commit on return - `handleRequest` swallows request handler failures, so
1373
+ * a normal return says nothing about success. `handleRequest` owns the outcome.
1374
+ */
1375
+ async runInStorageTransaction(callback) {
1376
+ if (!this.#transactionalStorageEnabled) {
1377
+ return callback();
1378
+ }
1379
+ const transaction = createStorageTransaction({
1380
+ policy: this.#storageWritePolicy,
1381
+ commitTimeoutMillis: this.internalTimeoutMillis,
738
1382
  });
1383
+ let threw = true;
1384
+ try {
1385
+ const result = await transaction.run(callback);
1386
+ threw = false;
1387
+ return result;
1388
+ }
1389
+ finally {
1390
+ if (transaction.state === 'open') {
1391
+ // `handleRequest` commits or rolls back on every normal path, so an open transaction on
1392
+ // a normal return is a wiring bug; on a propagating throw (a pipeline-level failure) it is
1393
+ // expected. Either way, discard the unvalidated writes; only the former is worth flagging.
1394
+ if (!threw) {
1395
+ this.log.error('Internal error: a storage transaction was still open after the request pipeline ' +
1396
+ 'returned normally. Its writes are being discarded. Please report this.');
1397
+ }
1398
+ transaction.rollback();
1399
+ }
1400
+ // Unconditional: `failed` is a terminal state that the branch above never reaches.
1401
+ transaction.dispose();
1402
+ }
739
1403
  }
740
1404
  /**
741
1405
  * Handles blocked request
742
1406
  */
743
- _throwOnBlockedRequest(session, statusCode) {
744
- const isBlocked = session.retireOnBlockedStatusCodes(statusCode);
745
- if (isBlocked) {
746
- throw new Error(`Request blocked - received ${statusCode} status code.`);
1407
+ throwOnBlockedRequest(statusCode) {
1408
+ if (this.retryOnBlocked)
1409
+ return;
1410
+ if (this.blockedStatusCodes.has(statusCode)) {
1411
+ throw new SessionError(`Request blocked - received ${statusCode} status code.`);
747
1412
  }
748
1413
  }
749
1414
  async isAllowedBasedOnRobotsTxtFile(url) {
750
- if (!this.respectRobotsTxtFile) {
1415
+ if (!this.#respectRobotsTxtFile) {
751
1416
  return true;
752
1417
  }
753
1418
  const robotsTxtFile = await this.getRobotsTxtFileForUrl(url);
754
- const userAgent = typeof this.respectRobotsTxtFile === 'object' ? this.respectRobotsTxtFile?.userAgent : '*';
1419
+ const userAgent = typeof this.#respectRobotsTxtFile === 'object' ? this.#respectRobotsTxtFile?.userAgent : '*';
1420
+ if (robotsTxtFile) {
1421
+ const crawlDelay = robotsTxtFile.getCrawlDelay(userAgent);
1422
+ if (crawlDelay !== undefined) {
1423
+ this.applyCrawlDelay(url, crawlDelay);
1424
+ }
1425
+ }
755
1426
  return !robotsTxtFile || robotsTxtFile.isAllowed(url, userAgent);
756
1427
  }
1428
+ /**
1429
+ * Records an HTTP 429 against the URL's domain so the request manager can hold the retry back.
1430
+ *
1431
+ * @param retryAfterHeader The raw `Retry-After` response header, if the server sent one.
1432
+ * @returns `true` if the manager took responsibility for the delay, in which case the caller should throw
1433
+ * {@link RequestThrottledError} rather than treating the response as a blocked session.
1434
+ */
1435
+ recordDomainRateLimit(url, retryAfterHeader) {
1436
+ if (this.requestManager?.recordPacingSignal({
1437
+ reason: 'rateLimited',
1438
+ url,
1439
+ waitMs: parseRetryAfterHeader(retryAfterHeader) ?? undefined,
1440
+ })) {
1441
+ return true;
1442
+ }
1443
+ const domain = hostnameOrUrl(url);
1444
+ this.log.warningOnce(`"${domain}" responded with HTTP 429 (Too Many Requests), but the crawler's request manager does not ` +
1445
+ 'pace that domain, so the response is handled like any other, with no per-domain delay. Set ' +
1446
+ `\`sameDomainDelaySecs\`, or pass a \`ThrottlingRequestManager\` covering "${domain}" as ` +
1447
+ '`requestManager`, to honour `Retry-After` and apply exponential backoff instead.');
1448
+ return false;
1449
+ }
1450
+ /** Hands a robots.txt `Crawl-delay` to the request manager, warning if it will not be honoured. */
1451
+ applyCrawlDelay(url, delaySeconds) {
1452
+ // robots.txt is per-origin; `hostname` is the closest pacing scope and errs wide (http and https to one
1453
+ // host share a clock).
1454
+ if (this.requestManager?.recordPacingSignal({
1455
+ reason: 'minInterval',
1456
+ url,
1457
+ intervalMs: delaySeconds * 1000,
1458
+ scope: 'hostname',
1459
+ })) {
1460
+ return;
1461
+ }
1462
+ const domain = hostnameOrUrl(url);
1463
+ this.log.warningOnce(`robots.txt for "${domain}" defines a crawl-delay of ${delaySeconds}s, but the crawler's request ` +
1464
+ 'manager does not pace that domain, so its requests will not be paced. Set ' +
1465
+ `\`sameDomainDelaySecs\`, or pass a \`ThrottlingRequestManager\` covering "${domain}" as ` +
1466
+ '`requestManager`.');
1467
+ }
757
1468
  async getRobotsTxtFileForUrl(url) {
758
- if (!this.respectRobotsTxtFile) {
1469
+ if (!this.#respectRobotsTxtFile) {
759
1470
  return undefined;
760
1471
  }
761
1472
  try {
762
1473
  const origin = new URL(url).origin;
763
- const cachedRobotsTxtFile = this.robotsTxtFileCache.get(origin);
1474
+ const cachedRobotsTxtFile = this.#robotsTxtFileCache.get(origin);
764
1475
  if (cachedRobotsTxtFile) {
765
1476
  return cachedRobotsTxtFile;
766
1477
  }
767
- const robotsTxtFile = await RobotsTxtFile.find(url);
768
- this.robotsTxtFileCache.add(origin, robotsTxtFile);
1478
+ const robotsTxtFile = await RobotsTxtFile.find(url, { logger: this.log });
1479
+ this.#robotsTxtFileCache.add(origin, robotsTxtFile);
769
1480
  return robotsTxtFile;
770
1481
  }
771
1482
  catch (e) {
@@ -773,10 +1484,10 @@ export class BasicCrawler {
773
1484
  return undefined;
774
1485
  }
775
1486
  }
776
- async _pauseOnMigration() {
777
- if (this.autoscaledPool) {
778
- // if run wasn't called, this is going to crash
779
- await this.autoscaledPool.pause(SAFE_MIGRATION_WAIT_MILLIS).catch((err) => {
1487
+ async pauseOnMigration() {
1488
+ const run = this.#dispatchingRun;
1489
+ if (run) {
1490
+ await run.pause(SAFE_MIGRATION_WAIT_MILLIS).catch((err) => {
780
1491
  if (err.message.includes('running tasks did not finish')) {
781
1492
  this.log.error('The crawler was paused due to migration to another host, ' +
782
1493
  "but some requests did not finish in time. Those requests' results may be duplicated.");
@@ -786,14 +1497,16 @@ export class BasicCrawler {
786
1497
  }
787
1498
  });
788
1499
  }
789
- const requestListPersistPromise = (async () => {
790
- if (this.requestList) {
791
- if (await this.requestList.isFinished())
1500
+ const requestManagerPersistPromise = (async () => {
1501
+ // The request manager persists its read-only loader's state, if it has one that supports
1502
+ // persistence (e.g. a tandem wrapping a `RequestList`). For a plain `RequestQueue`, this is a no-op.
1503
+ if (this.requestManager?.persistState) {
1504
+ if ((await this.requestManager.checkReadiness()).status === 'finished')
792
1505
  return;
793
- await this.requestList.persistState().catch((err) => {
1506
+ await this.requestManager.persistState().catch((err) => {
794
1507
  if (err.message.includes('Cannot persist state.')) {
795
1508
  this.log.error("The crawler attempted to persist its request list's state and failed due to missing or " +
796
- 'invalid config. Make sure to use either RequestList.open() or the "stateKeyPrefix" option of RequestList ' +
1509
+ 'invalid configuration. Make sure to use either RequestList.open() or the "stateKeyPrefix" option of RequestList ' +
797
1510
  'constructor to ensure your crawling state is persisted through host migrations and restarts.');
798
1511
  }
799
1512
  else {
@@ -803,153 +1516,52 @@ export class BasicCrawler {
803
1516
  });
804
1517
  }
805
1518
  })();
806
- await Promise.all([requestListPersistPromise, this.stats.persistState()]);
807
- }
808
- /**
809
- * Initializes the RequestManager based on the configured requestList and requestQueue.
810
- */
811
- async initializeRequestManager() {
812
- if (this.requestManager !== undefined) {
813
- return;
814
- }
815
- if (this.requestList && this.requestQueue) {
816
- // Create a RequestManagerTandem if both RequestList and RequestQueue are provided
817
- this.requestManager = new RequestManagerTandem(this.requestList, this.requestQueue);
818
- }
819
- else if (this.requestQueue) {
820
- // Use RequestQueue directly if only it is provided
821
- this.requestManager = this.requestQueue;
822
- }
823
- else if (this.requestList) {
824
- // Use RequestList directly if only it is provided
825
- // Make it compatible with the IRequestManager interface
826
- this.requestManager = new RequestListAdapter(this.requestList);
827
- }
828
- // If neither RequestList nor RequestQueue is provided, leave the requestManager uninitialized until `getRequestQueue` is called
1519
+ await Promise.all([requestManagerPersistPromise, this.statistics.persistState?.()]);
829
1520
  }
830
1521
  /**
831
1522
  * Fetches the next request to process from the underlying request provider.
832
1523
  */
833
- async _fetchNextRequest() {
1524
+ async fetchNextRequest() {
834
1525
  if (this.requestManager === undefined) {
835
- throw new Error(`_fetchNextRequest called on an uninitialized crawler`);
1526
+ throw new Error(`fetchNextRequest called on an uninitialized crawler`);
836
1527
  }
837
1528
  return this.requestManager.fetchNextRequest();
838
1529
  }
839
- /**
840
- * Delays processing of the request based on the `sameDomainDelaySecs` option,
841
- * adding it back to the queue after the timeout passes. Returns `true` if the request
842
- * should be ignored and will be reclaimed to the queue once ready.
843
- */
844
- delayRequest(request, source) {
845
- const domain = getDomain(request.url);
846
- if (!domain || !request) {
847
- return false;
848
- }
849
- const now = Date.now();
850
- const lastAccessTime = this.domainAccessedTime.get(domain);
851
- if (!lastAccessTime || now - lastAccessTime >= this.sameDomainDelayMillis) {
852
- this.domainAccessedTime.set(domain, now);
853
- return false;
854
- }
855
- if (source instanceof RequestQueueV1) {
856
- // eslint-disable-next-line dot-notation
857
- source['inProgress']?.delete(request.id);
858
- }
859
- const delay = lastAccessTime + this.sameDomainDelayMillis - now;
860
- this.log.debug(`Request ${request.url} (${request.id}) will be reclaimed after ${delay} milliseconds due to same domain delay`);
861
- setTimeout(async () => {
862
- this.log.debug(`Adding request ${request.url} (${request.id}) back to the queue`);
863
- if (source instanceof RequestQueueV1) {
864
- // eslint-disable-next-line dot-notation
865
- source['inProgress'].add(request.id);
866
- }
867
- await source.reclaimRequest(request, { forefront: request.userData?.__crawlee?.forefront });
868
- }, delay);
869
- return true;
870
- }
871
- /**
872
- * Wrapper around requestHandler that fetches requests from RequestList/RequestQueue
873
- * then retries them in a case of an error, etc.
874
- */
875
- async _runTaskFunction() {
876
- const source = this.requestManager;
877
- if (!source)
878
- throw new Error('Request provider is not initialized!');
879
- const request = await this._timeoutAndRetry(this._fetchNextRequest.bind(this), this.internalTimeoutMillis, `Fetching next request timed out after ${this.internalTimeoutMillis / 1e3} seconds.`);
880
- tryCancel();
881
- const session = this.useSessionPool
882
- ? await this._timeoutAndRetry(async () => {
883
- return await this.sessionPool.newSession({
884
- proxyInfo: await this.proxyConfiguration?.newProxyInfo({
885
- request: request ?? undefined,
886
- }),
887
- maxUsageCount: 1,
888
- });
889
- }, this.internalTimeoutMillis, `Fetching session timed out after ${this.internalTimeoutMillis / 1e3} seconds.`)
890
- : undefined;
891
- tryCancel();
892
- if (!request || this.delayRequest(request, source)) {
1530
+ /** Handles a single request - runs the request handler with retries, error handling, and lifecycle management. */
1531
+ async handleRequest(crawlingContext, requestSource, request) {
1532
+ // An earlier phase we cannot cancel (e.g. a slow `extendContext`) may have run past the internal timeout,
1533
+ // which already failed the request in `runTaskFunction`. Bail before running the handler so it does not
1534
+ // execute (and re-report) on top of a request the crawler has already moved past.
1535
+ if (crawlingContext[timeoutExpiredKey]?.()) {
893
1536
  return;
894
1537
  }
895
- if (!(await this.isAllowedBasedOnRobotsTxtFile(request.url))) {
896
- this.log.warning(`Skipping request ${request.url} (${request.id}) because it is disallowed based on robots.txt`);
897
- request.state = RequestState.SKIPPED;
898
- request.noRetry = true;
899
- await source.markRequestHandled(request);
900
- await this.handleSkippedRequest({
901
- url: request.url,
902
- reason: 'robotsTxt',
903
- });
904
- return;
905
- }
906
- // Reset loadedUrl so an old one is not carried over to retries.
907
- request.loadedUrl = undefined;
908
1538
  const statisticsId = request.id || request.uniqueKey;
909
- this.stats.startJob(statisticsId);
910
- const deferredCleanup = [];
911
- const crawlingContext = {
912
- id: cryptoRandomObjectId(10),
913
- log: this.log,
914
- request,
915
- session,
916
- proxyInfo: session?.proxyInfo,
917
- enqueueLinks: async (options) => {
918
- const requestQueue = await this.getRequestQueue();
919
- return await this.enqueueLinksWithCrawlDepth(options, request, requestQueue);
920
- },
921
- addRequests: async (requests, options = {}) => {
922
- const newCrawlDepth = request.crawlDepth + 1;
923
- const requestsGenerator = this.addCrawlDepthRequestGenerator(requests, newCrawlDepth);
924
- await this.addRequests(requestsGenerator, options);
925
- },
926
- pushData: this.pushData.bind(this),
927
- useState: this.useState.bind(this),
928
- sendRequest: createSendRequest(this.httpClient, request, session),
929
- getKeyValueStore: async (idOrName) => KeyValueStore.open(idOrName, { config: this.config }),
930
- registerDeferredCleanup: (cleanup) => {
931
- deferredCleanup.push(cleanup);
932
- },
933
- };
1539
+ // Opened by `runInStorageTransaction`; absent when disabled or when the subclass opens its own.
1540
+ const transaction = currentStorageTransaction();
934
1541
  let isRequestLocked = true;
935
1542
  try {
936
1543
  request.state = RequestState.REQUEST_HANDLER;
937
1544
  await this.runRequestHandler(crawlingContext);
938
- await this._timeoutAndRetry(async () => source.markRequestHandled(request), this.internalTimeoutMillis, `Marking request ${request.url} (${request.id}) as handled timed out after ${this.internalTimeoutMillis / 1e3} seconds.`);
939
- isRequestLocked = false; // markRequestHandled succeeded and unlocked the request
940
- this.stats.finishJob(statisticsId, request.retryCount);
941
- this.handledRequestsCount++;
1545
+ // Commit *before* marking the request as handled, so a commit failure fails the request and
1546
+ // it is retried. This also closes the transaction, so everything below passes through.
1547
+ await transaction?.commit();
1548
+ await this.timeoutAndRetry(async () => requestSource.markRequestAsHandled(request), this.internalTimeoutMillis, `Marking request ${request.url} (${request.id}) as handled timed out after ${this.internalTimeoutMillis / 1e3} seconds.`);
1549
+ isRequestLocked = false; // markRequestAsHandled succeeded and unlocked the request
1550
+ this.statistics.recordRequestSuccess(statisticsId, request.retryCount);
942
1551
  // reclaim session if request finishes successfully
943
1552
  request.state = RequestState.DONE;
944
- crawlingContext.session?.markGood();
1553
+ crawlingContext.session.markGood();
945
1554
  }
946
1555
  catch (rawError) {
1556
+ // Roll back *before* any error handler runs - error handlers write to real storage precisely
1557
+ // because the transaction is already closed. A no-op when the commit above succeeded.
1558
+ transaction?.rollback();
947
1559
  const err = this.unwrapError(rawError);
948
1560
  try {
949
1561
  request.state = RequestState.ERROR_HANDLER;
950
- await addTimeoutToPromise(async () => this._requestFunctionErrorHandler(err, crawlingContext, source), this.internalTimeoutMillis, `Handling request failure of ${request.url} (${request.id}) timed out after ${this.internalTimeoutMillis / 1e3} seconds.`);
1562
+ await addTimeoutToPromise(async () => this.requestFunctionErrorHandler(err, crawlingContext, request, requestSource), this.internalTimeoutMillis, `Handling request failure of ${request.url} (${request.id}) timed out after ${this.internalTimeoutMillis / 1e3} seconds.`);
951
1563
  if (!(err instanceof CriticalError)) {
952
- isRequestLocked = false; // _requestFunctionErrorHandler calls either markRequestHandled or reclaimRequest
1564
+ isRequestLocked = false; // requestFunctionErrorHandler calls either markRequestAsHandled or reclaimRequest
953
1565
  }
954
1566
  request.state = RequestState.DONE;
955
1567
  }
@@ -967,49 +1579,26 @@ export class BasicCrawler {
967
1579
  request.state = RequestState.ERROR;
968
1580
  throw unwrappedSecondaryError;
969
1581
  }
970
- // decrease the session score if the request fails (but the error handler did not throw)
971
- crawlingContext.session?.markBad();
1582
+ // decrease the session score if the request fails (but the error handler did not throw);
1583
+ // skip when the error is a SessionError, which already retired the session
1584
+ if (!this.errorAbsolvesSession(err)) {
1585
+ crawlingContext.session.markBad();
1586
+ }
972
1587
  }
973
1588
  finally {
974
- await Promise.all(deferredCleanup.map((cleanup) => cleanup()));
975
- // Safety net - release the lock if nobody managed to do it before
976
- if (isRequestLocked && source instanceof RequestProvider) {
1589
+ // Safety net - return the request to the queue if nobody managed to mark it as handled
1590
+ // or reclaim it before (e.g. after a CriticalError). Reclaiming a request that is no longer
1591
+ // in progress is a harmless no-op on the storage backend.
1592
+ if (isRequestLocked && requestSource instanceof RequestQueue) {
977
1593
  try {
978
- await source.client.deleteRequestLock(request.id);
1594
+ await requestSource.reclaimRequest(request);
979
1595
  }
980
1596
  catch {
981
- // We don't have the lock, or the request was never locked. Either way it's fine
1597
+ // The request was never in progress, or could not be reclaimed. Either way it's fine.
982
1598
  }
983
1599
  }
984
1600
  }
985
1601
  }
986
- /**
987
- * Wrapper around the crawling context's `enqueueLinks` method:
988
- * - Injects `crawlDepth` to each request being added based on the crawling context request.
989
- * - Provides defaults for the `enqueueLinks` options based on the crawler configuration.
990
- * - These options can be overridden by the user.
991
- * @internal
992
- */
993
- async enqueueLinksWithCrawlDepth(options, request, requestQueue) {
994
- const transformRequestFunctionWrapper = (newRequest) => {
995
- newRequest.crawlDepth = request.crawlDepth + 1;
996
- if (this.maxCrawlDepth !== undefined && newRequest.crawlDepth > this.maxCrawlDepth) {
997
- newRequest.skippedReason = 'depth';
998
- return false;
999
- }
1000
- // After injecting the crawlDepth, we call the user-provided transform function, if there is one.
1001
- return options.transformRequestFunction?.(newRequest) ?? newRequest;
1002
- };
1003
- return await enqueueLinks({
1004
- requestQueue,
1005
- robotsTxtFile: await this.getRobotsTxtFileForUrl(request.url),
1006
- onSkippedRequest: this.handleSkippedRequest,
1007
- limit: this.calculateEnqueuedRequestLimit(options.limit),
1008
- // Allow user options to override defaults set above ⤴
1009
- ...options,
1010
- transformRequestFunction: transformRequestFunctionWrapper,
1011
- });
1012
- }
1013
1602
  /**
1014
1603
  * Generator function that yields requests injected with the given crawl depth.
1015
1604
  * @internal
@@ -1029,7 +1618,7 @@ export class BasicCrawler {
1029
1618
  * Run async callback with given timeout and retry. Returns the result of the callback.
1030
1619
  * @ignore
1031
1620
  */
1032
- async _timeoutAndRetry(handler, timeout, error, maxRetries = 3, retried = 1) {
1621
+ async timeoutAndRetry(handler, timeout, error, maxRetries = 3, retried = 1) {
1033
1622
  try {
1034
1623
  return await addTimeoutToPromise(handler, timeout, error);
1035
1624
  }
@@ -1037,28 +1626,24 @@ export class BasicCrawler {
1037
1626
  if (retried <= maxRetries) {
1038
1627
  // we retry on any error, not just timeout
1039
1628
  this.log.warning(`${e.message} (retrying ${retried}/${maxRetries})`);
1040
- return this._timeoutAndRetry(handler, timeout, error, maxRetries, retried + 1);
1629
+ return this.timeoutAndRetry(handler, timeout, error, maxRetries, retried + 1);
1041
1630
  }
1042
1631
  throw e;
1043
1632
  }
1044
1633
  }
1045
1634
  /**
1046
- * Returns true if either RequestList or RequestQueue have a request ready for processing.
1635
+ * Whether the request manager has a request ready for processing. A manager that is only `waiting` also gets a
1636
+ * wake-up scheduled, so a paced crawl resumes on its clock rather than on the task loop's polling interval.
1047
1637
  */
1048
- async _isTaskReadyFunction() {
1049
- return this.requestManager !== undefined && !(await this.requestManager.isEmpty());
1050
- }
1051
- /**
1052
- * Returns true if both RequestList and RequestQueue have all requests finished.
1053
- */
1054
- async _defaultIsFinishedFunction() {
1055
- return !this.requestManager || (await this.requestManager.isFinished());
1056
- }
1057
- async _rotateSession(crawlingContext) {
1058
- const { request } = crawlingContext;
1059
- request.sessionRotationCount ??= 0;
1060
- request.sessionRotationCount++;
1061
- crawlingContext.session?.retire();
1638
+ async isTaskReadyFunction() {
1639
+ if (this.requestManager === undefined) {
1640
+ return false;
1641
+ }
1642
+ const state = await this.requestManager.checkReadiness();
1643
+ if (state.status === 'waiting' && state.readyAt !== undefined) {
1644
+ this.#run?.scheduleWake(state.readyAt);
1645
+ }
1646
+ return state.status === 'ready';
1062
1647
  }
1063
1648
  /**
1064
1649
  * Unwraps errors thrown by the context pipeline to get the actual user error.
@@ -1074,27 +1659,38 @@ export class BasicCrawler {
1074
1659
  }
1075
1660
  /**
1076
1661
  * Handles errors thrown by user provided requestHandler()
1662
+ *
1663
+ * @param request The request object, passed separately to circumvent potential dynamic logic in crawlingContext.request
1077
1664
  */
1078
- async _requestFunctionErrorHandler(error, crawlingContext, source) {
1079
- const { request } = crawlingContext;
1665
+ async requestFunctionErrorHandler(error, crawlingContext, request, source) {
1666
+ if (error instanceof RequestThrottledError) {
1667
+ // The domain told us to come back later, so the request was never really attempted. Put it back
1668
+ // without recording a failure - it costs neither a retry nor session reputation.
1669
+ this.log.debug(`Deferring request because its domain is rate-limiting us. ${error.message}`, {
1670
+ id: request.id,
1671
+ url: request.url,
1672
+ });
1673
+ await source.reclaimRequest(request, { forefront: request.userData?.__crawlee?.forefront });
1674
+ return;
1675
+ }
1080
1676
  request.pushErrorMessage(error);
1081
1677
  if (error instanceof CriticalError) {
1082
1678
  throw error;
1083
1679
  }
1084
- const shouldRetryRequest = this._canRequestBeRetried(request, error);
1680
+ const shouldRetryRequest = this.canRequestBeRetried(request, error);
1085
1681
  if (shouldRetryRequest) {
1086
- await this.stats.errorTrackerRetry.addAsync(error, crawlingContext);
1087
- await this.errorHandler?.(crawlingContext, // valid cast - ExtendedContext transitively extends CrawlingContext
1682
+ await this.statistics.errorTrackerRetry.addAsync(error, crawlingContext);
1683
+ await this.#errorHandler?.(crawlingContext, // valid cast - ExtendedContext transitively extends CrawlingContext
1088
1684
  error);
1089
1685
  if (error instanceof SessionError) {
1090
- await this._rotateSession(crawlingContext);
1686
+ crawlingContext.session?.retire();
1091
1687
  }
1092
1688
  if (!request.noRetry) {
1093
1689
  request.retryCount++;
1094
1690
  const { url, retryCount, id } = request;
1095
1691
  // We don't want to see the stack trace in the logs by default, when we are going to retry the request.
1096
1692
  // Thus, we print the full stack trace only when CRAWLEE_VERBOSE_LOG environment variable is set to true.
1097
- const message = this._getMessageFromError(error);
1693
+ const message = this.getMessageFromError(error);
1098
1694
  this.log.warning(`Reclaiming failed request back to the list or queue. ${message}`, {
1099
1695
  id,
1100
1696
  url,
@@ -1104,40 +1700,33 @@ export class BasicCrawler {
1104
1700
  return;
1105
1701
  }
1106
1702
  }
1703
+ if (error instanceof SessionError) {
1704
+ crawlingContext.session?.retire();
1705
+ }
1107
1706
  // If the request is non-retryable, the error and snapshot aren't saved in the errorTrackerRetry object.
1108
1707
  // Therefore, we pass the crawlingContext to the errorTracker.add method, enabling snapshot capture.
1109
1708
  // This is to make sure the error snapshot is not duplicated in the errorTrackerRetry and errorTracker objects.
1110
1709
  const { noRetry, maxRetries } = request;
1111
1710
  if (noRetry || !maxRetries) {
1112
- await this.stats.errorTracker.addAsync(error, crawlingContext);
1711
+ await this.statistics.errorTracker.addAsync(error, crawlingContext);
1113
1712
  }
1114
1713
  else {
1115
- this.stats.errorTracker.add(error);
1714
+ this.statistics.errorTracker.add(error);
1116
1715
  }
1117
1716
  // If we get here, the request is either not retryable
1118
1717
  // or failed more than retryCount times and will not be retried anymore.
1119
1718
  // Mark the request as failed and do not retry.
1120
- this.handledRequestsCount++;
1121
- await source.markRequestHandled(request);
1122
- this.stats.failJob(request.id || request.uniqueKey, request.retryCount);
1123
- await this._handleFailedRequestHandler(crawlingContext, error); // This function prints an error message.
1124
- }
1125
- async _tagUserHandlerError(cb) {
1126
- try {
1127
- return (await cb());
1128
- }
1129
- catch (e) {
1130
- Object.defineProperty(e, 'triggeredFromUserHandler', { value: true });
1131
- throw e;
1132
- }
1719
+ await source.markRequestAsHandled(request);
1720
+ this.statistics.recordRequestFailure(request.id || request.uniqueKey, request.retryCount);
1721
+ await this.handleFailedRequestHandler(crawlingContext, error); // This function prints an error message.
1133
1722
  }
1134
- async _handleFailedRequestHandler(crawlingContext, error) {
1723
+ async handleFailedRequestHandler(crawlingContext, error) {
1135
1724
  // Always log the last error regardless if the user provided a failedRequestHandler
1136
1725
  const { id, url, method, uniqueKey } = crawlingContext.request;
1137
- const message = this._getMessageFromError(error, true);
1726
+ const message = this.getMessageFromError(error, true);
1138
1727
  this.log.error(`Request failed and reached maximum retries. ${message}`, { id, url, method, uniqueKey });
1139
- if (this.failedRequestHandler) {
1140
- await this.failedRequestHandler?.(crawlingContext, // valid cast - ExtendedContext transitively extends CrawlingContext
1728
+ if (this.#failedRequestHandler) {
1729
+ await this.#failedRequestHandler?.(crawlingContext, // valid cast - ExtendedContext transitively extends CrawlingContext
1141
1730
  error);
1142
1731
  }
1143
1732
  }
@@ -1146,7 +1735,7 @@ export class BasicCrawler {
1146
1735
  * @param error The error received
1147
1736
  * @returns The message to be logged
1148
1737
  */
1149
- _getMessageFromError(error, forceStack = false) {
1738
+ getMessageFromError(error, forceStack = false) {
1150
1739
  if ([TypeError, SyntaxError, ReferenceError].some((type) => error instanceof type)) {
1151
1740
  forceStack = true;
1152
1741
  }
@@ -1160,11 +1749,16 @@ export class BasicCrawler {
1160
1749
  ? (error.stack ?? [error.message || error, ...stackLines].join('\n'))
1161
1750
  : [error.message || error, userLine].join('\n');
1162
1751
  }
1163
- _canRequestBeRetried(request, error) {
1164
- // Request should never be retried, or the error encountered makes it not able to be retried, or the session rotation limit has been reached
1165
- if (request.noRetry ||
1166
- error instanceof NonRetryableError ||
1167
- (error instanceof SessionError && this.maxSessionRotations <= (request.sessionRotationCount ?? 0))) {
1752
+ /**
1753
+ * Whether the session should be spared for this error - either because it was already retired, or because the
1754
+ * failure says nothing about the session (a rate limit is a property of the domain).
1755
+ */
1756
+ errorAbsolvesSession(error) {
1757
+ return error instanceof SessionError || error instanceof RequestThrottledError;
1758
+ }
1759
+ canRequestBeRetried(request, error) {
1760
+ // Request should never be retried, or the error encountered makes it not able to be retried.
1761
+ if (request.noRetry || error instanceof NonRetryableError) {
1168
1762
  return false;
1169
1763
  }
1170
1764
  // User requested retry (we ignore retry count here as its explicitly told by the user to retry)
@@ -1172,58 +1766,66 @@ export class BasicCrawler {
1172
1766
  return true;
1173
1767
  }
1174
1768
  // Ensure there are more retries available for the request
1175
- const maxRequestRetries = request.maxRetries ?? this.maxRequestRetries;
1769
+ const maxRequestRetries = request.maxRetries ?? this.#maxRequestRetries;
1176
1770
  return request.retryCount < maxRequestRetries;
1177
1771
  }
1178
1772
  /**
1179
- * Updates handledRequestsCount from possibly stored counts, usually after worker migration.
1180
- */
1181
- async _loadHandledRequestCount() {
1182
- if (this.requestManager) {
1183
- this.handledRequestsCount = await this.requestManager.handledCount();
1184
- }
1185
- }
1186
- async _executeHooks(hooks, ...args) {
1187
- if (Array.isArray(hooks) && hooks.length) {
1188
- for (const hook of hooks) {
1189
- await hook(...args);
1190
- }
1191
- }
1192
- }
1193
- /**
1194
- * Stops the crawler immediately.
1773
+ * Ends the run in progress immediately, without waiting for the requests already in flight.
1195
1774
  *
1196
- * This method doesn't wait for currently active requests to finish.
1775
+ * This runs at the end of every {@link BasicCrawler.run|`run()`}, so what it releases is per-run only, and
1776
+ * a repeated `run()` has to find everything it needs either intact or re-establishable. What outlives a run is
1777
+ * released by {@link BasicCrawler.destroy|`destroy()`} instead.
1197
1778
  *
1198
1779
  * To stop the crawler gracefully (waiting for all running requests to finish), use {@link BasicCrawler.stop|`crawler.stop()`} instead.
1199
1780
  */
1200
1781
  async teardown() {
1201
- this.events.emit("persistState" /* EventType.PERSIST_STATE */, { isMigrating: false });
1202
- await this.sessionPool?.teardown();
1203
- if (this._closeEvents) {
1204
- await this.events.close();
1205
- }
1206
- await this.autoscaledPool?.abort();
1782
+ const eventManager = serviceLocator.getEventManager();
1783
+ const ownsEventManager = this.#run?.ownsEventManager === true;
1784
+ // First, so that the pool writes its final state once - its teardown stops it listening before the
1785
+ // persistence event below goes out.
1786
+ await this.#sessionPoolDep.ifOwned(async (pool) => pool.teardown());
1787
+ // When this crawler initialized the event manager, its close() call emits
1788
+ // the final persistence event after the crawler-specific state has been
1789
+ // saved. External event managers still need an explicit event here.
1790
+ if (!ownsEventManager) {
1791
+ eventManager.emit(EventType.PERSIST_STATE, { isMigrating: false });
1792
+ }
1793
+ if (ownsEventManager) {
1794
+ await eventManager.close();
1795
+ }
1796
+ await this.#run?.end();
1797
+ }
1798
+ /**
1799
+ * Releases what the crawler owns beyond a single run — in the browser crawlers, the browser pool. A finished
1800
+ * `run()` has already released everything a run owns, so this is only needed before dropping a crawler you
1801
+ * could otherwise have run again.
1802
+ */
1803
+ async destroy() {
1804
+ // An abandoned run - one whose `run()` never returned - would otherwise keep dispatching requests.
1805
+ await this.#run?.end();
1806
+ }
1807
+ async [Symbol.asyncDispose]() {
1808
+ await this.destroy();
1207
1809
  }
1208
- _getCookieHeaderFromRequest(request) {
1810
+ getCookieHeaderFromRequest(request) {
1209
1811
  if (request.headers?.Cookie && request.headers?.cookie) {
1210
1812
  this.log.warning(`Encountered mixed casing for the cookie headers for request ${request.url} (${request.id}). Their values will be merged.`);
1211
1813
  return mergeCookies(request.url, [request.headers.cookie, request.headers.Cookie]);
1212
1814
  }
1213
1815
  return request.headers?.Cookie || request.headers?.cookie || '';
1214
1816
  }
1215
- async _getRequestQueue() {
1216
- // Check if it's explicitly disabled
1217
- if (this.experiments.requestLocking === false) {
1218
- if (!this._experimentWarnings.requestLocking) {
1219
- this.log.info('Using the old RequestQueue implementation without request locking.');
1220
- this._experimentWarnings.requestLocking = true;
1817
+ requestMatchesEnqueueStrategy(request) {
1818
+ // If `skipNavigation` was used, just return `true`
1819
+ try {
1820
+ // eslint-disable-next-line @typescript-eslint/no-unused-expressions
1821
+ request.loadedUrl;
1822
+ }
1823
+ catch (err) {
1824
+ if (err instanceof NavigationSkippedError) {
1825
+ return true;
1221
1826
  }
1222
- return RequestQueueV1.open(null, { config: this.config });
1827
+ throw err;
1223
1828
  }
1224
- return RequestQueue.open(null, { config: this.config });
1225
- }
1226
- requestMatchesEnqueueStrategy(request) {
1227
1829
  const { url, loadedUrl } = request;
1228
1830
  // eslint-disable-next-line dot-notation -- private access
1229
1831
  const strategy = request['enqueueStrategy'];
@@ -1261,31 +1863,10 @@ export class BasicCrawler {
1261
1863
  }
1262
1864
  }
1263
1865
  }
1264
- /**
1265
- * Creates new {@link Router} instance that works based on request labels.
1266
- * This instance can then serve as a {@link BasicCrawlerOptions.requestHandler|`requestHandler`} of our {@link BasicCrawler}.
1267
- * Defaults to the {@link BasicCrawlingContext}.
1268
- *
1269
- * > Serves as a shortcut for using `Router.create<BasicCrawlingContext>()`.
1270
- *
1271
- * ```ts
1272
- * import { BasicCrawler, createBasicRouter } from 'crawlee';
1273
- *
1274
- * const router = createBasicRouter();
1275
- * router.addHandler('label-a', async (ctx) => {
1276
- * ctx.log.info('...');
1277
- * });
1278
- * router.addDefaultHandler(async (ctx) => {
1279
- * ctx.log.info('...');
1280
- * });
1281
- *
1282
- * const crawler = new BasicCrawler({
1283
- * requestHandler: router,
1284
- * });
1285
- * await crawler.run();
1286
- * ```
1287
- */
1866
+ /** The hostname of `url`, falling back to the whole string when it is not parseable - for log messages only. */
1867
+ function hostnameOrUrl(url) {
1868
+ return URL.canParse(url) ? new URL(url).hostname : url;
1869
+ }
1288
1870
  export function createBasicRouter(routes) {
1289
1871
  return Router.create(routes);
1290
1872
  }
1291
- //# sourceMappingURL=basic-crawler.js.map