@cratis/scene.components 3.3.1 → 3.5.0

package/for_cratisComponentsPackage/when_describing_query_arguments.ts

@@ -0,0 +1,15 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { cratisComponentsPackageManifest } from '../cratisComponentsPackage';
+
+describe('when describing query arguments', () => {
+    it('should keep both collection table names in the manifest', () => {
+        cratisComponentsPackageManifest.components.should.include('dataTable');
+        cratisComponentsPackageManifest.components.should.include('table');
+    });
+
+    it('should describe the optional object property without promising single-result support', () => {
+        (cratisComponentsPackageManifest.description ?? '').should.contain('dataTable and table accept optional object-valued queryArguments for collection queries');
+    });
+});

package/for_cratisComponentsPackage/when_describing_single_result.ts

@@ -0,0 +1,20 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { expect } from 'vitest';
+import { componentRegistryKey } from '@cratis/scene.react';
+import { cratisComponents, cratisComponentsPackageName } from '../cratisComponents';
+import { cratisComponentsPackageManifest } from '../cratisComponentsPackage';
+import { SceneSingleResult } from '../data/SceneSingleResult';
+
+describe('when describing the single result view', () => {
+    it('registers the same component advertised by the manifest', () => {
+        expect(cratisComponentsPackageManifest.components).toContain('singleResult');
+        expect(cratisComponents[componentRegistryKey(cratisComponentsPackageName, 'singleResult')]).toBe(SceneSingleResult);
+    });
+
+    it('describes an explicitly enabled read-only own-field capability', () => {
+        expect(cratisComponentsPackageManifest.description).toContain('read-only scalar own resultField');
+        expect(cratisComponentsPackageManifest.description).toContain('enabled: true');
+    });
+});

package/forms/fields/SceneRadioButtonField.tsx

@@ -20,13 +20,16 @@ const RadioButtonField = lazy(async () => ({ default: (await import('@cratis/com
  * numeric code is common enough that forcing it through as `'1'` would bind the wrong value.
  */
 export function SceneRadioButtonField({ element }: RegisteredComponentProps) {
+    // Use the same reader as CommandFormField's binding gate; that gate owns missing-property feedback.
+    const name = stringProperty(element.properties, 'property');
     const buttonValue = stringProperty(element.properties, 'buttonValue') ?? numberProperty(element.properties, 'buttonValue') ?? '';
 
     return (
         <CommandFormField element={element}>
-            {binding => (
+            {binding => name !== undefined && (
                 <RadioButtonField
                     {...binding}
+                    name={name}
                     buttonValue={buttonValue}
                     label={stringProperty(element.properties, 'label')}
                     className={stringProperty(element.properties, 'className')}

package/forms/fields/for_SceneRadioButtonField/when_mapping_the_group_name.tsx

@@ -0,0 +1,45 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { act, cleanup, render, screen } from '@testing-library/react';
+import { expect, vi } from 'vitest';
+import { externalComponent } from '../../../given';
+
+// The public Components radio props require a native group name independently of the display title.
+describe('when mapping the radio group name', () => {
+    const received = vi.fn<(props: { name: string; title: string; value: (instance: Record<string, unknown>) => unknown }) => void>();
+    let SceneRadioButtonField: typeof import('../SceneRadioButtonField').SceneRadioButtonField;
+
+    beforeEach(async () => {
+        vi.resetModules();
+        received.mockClear();
+        vi.doMock('@cratis/components/CommandForm', () => ({
+            RadioButtonField: (props: Parameters<typeof received>[0]) => { received(props); return <input type='radio' name={props.name} />; },
+        }));
+        ({ SceneRadioButtonField } = await import('../SceneRadioButtonField'));
+    });
+
+    afterEach(() => {
+        cleanup();
+        vi.doUnmock('@cratis/components/CommandForm');
+        vi.resetModules();
+    });
+
+    it('should group options by the explicit property, regardless of titles or labels', async () => {
+        await act(async () => {
+            render(<>{['First title', 'Second title'].map((title, index) => <SceneRadioButtonField key={title} element={externalComponent('Cratis.Components:radioButtonField', { property: 'choice', title, label: 'Display label', buttonValue: index })} slots={{}} />)}</>);
+        });
+        expect(screen.getAllByRole('radio').map(radio => radio.getAttribute('name'))).toEqual(['choice', 'choice']);
+        expect(received.mock.calls.map(([props]) => props.value({ choice: 2 }))).toEqual([2, 2]);
+    });
+
+    for (const property of [undefined, 42, null, {}, []]) {
+        it(`should visibly reject malformed property ${JSON.stringify(property)} instead of using the title`, async () => {
+            await act(async () => {
+                render(<SceneRadioButtonField element={externalComponent('Cratis.Components:radioButtonField', { property, title: 'Not a binding' })} slots={{}} />);
+            });
+            expect(screen.getByText("Missing 'property' on Cratis.Components:radioButtonField")).toBeTruthy();
+            expect(received).not.toHaveBeenCalled();
+        });
+    }
+});

package/forms/fields/for_resolveFieldBinding/when_resolving_a_field_binding.ts

@@ -3,8 +3,14 @@
 
 import { externalComponent } from '../../../given';
 import { resolveFieldBinding } from '../resolveFieldBinding';
+import type { FieldBinding } from '../FieldBinding';
 
 describe('when resolving a field binding', () => {
+    it('should preserve manually constructed field bindings without a native group name', () => {
+        const binding: FieldBinding = { value: instance => instance.customerName, title: 'Customer' };
+        binding.value({ customerName: 'Acme' })!.should.equal('Acme');
+    });
+
     describe('and the element names a property with a title and description', () => {
         const binding = resolveFieldBinding(
             externalComponent('Cratis.Components:inputTextField', {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@cratis/scene.components",
-    "version": "3.3.1",
+    "version": "3.5.0",
     "description": "The Cratis Components package: exposes @cratis/components' Arc-bound data, form and dialog composites as Scene components. Built on PrimeReact and Tailwind, and declares both as dependencies.",
     "keywords": [
         "cratis",
@@ -53,15 +53,17 @@
         "build-storybook": "storybook build"
     },
     "dependencies": {
-        "@cratis/scene.engine": "3.3.1",
-        "@cratis/scene.model": "3.3.1",
-        "@cratis/scene.react": "3.3.1"
+        "@cratis/scene.engine": "3.5.0",
+        "@cratis/scene.model": "3.5.0",
+        "@cratis/scene.react": "3.5.0"
     },
     "devDependencies": {
-        "@cratis/components": "^4.2.2",
-        "@cratis/scene.engine": "3.3.1",
-        "@cratis/scene.model": "3.3.1",
-        "@cratis/scene.react": "3.3.1",
+        "@cratis/arc": "22.16.1",
+        "@cratis/arc.react": "22.16.1",
+        "@cratis/components": "^4.6.0",
+        "@cratis/scene.engine": "3.5.0",
+        "@cratis/scene.model": "3.5.0",
+        "@cratis/scene.react": "3.5.0",
         "@storybook/addon-links": "^10.6.0",
         "@storybook/react": "^10.6.0",
         "@storybook/react-vite": "^10.6.0",
@@ -71,8 +73,18 @@
         "storybook": "^10.6.0"
     },
     "peerDependencies": {
+        "@cratis/arc": "^22.16.1",
+        "@cratis/arc.react": "^22.16.1",
         "@cratis/components": "^4.1.1",
         "react": "^19.0.0",
         "react-dom": "^19.0.0"
+    },
+    "peerDependenciesMeta": {
+        "@cratis/arc": {
+            "optional": true
+        },
+        "@cratis/arc.react": {
+            "optional": true
+        }
     }
 }

package/pages/SceneDataPage.tsx

@@ -6,7 +6,7 @@ import { RegisteredComponentProps } from '@cratis/scene.react';
 import { ArcRuntimeBoundary, BindingKind, MissingBinding, resolveElementBinding } from '../bindings';
 import { stringArrayProperty, stringProperty } from '../properties';
 
-const DataPage = lazy(async () => ({ default: (await import('@cratis/components/DataPage')).DataPage }));
+const DataPage = lazy(async () => ({ default: (await import('../bindings/ArcBoundComponents')).BoundDataPage }));
 
 /**
  * The `Cratis.Components:dataPage` component - `DataPage` from `@cratis/components/DataPage`.