@cratis/pi 7.102.0 → 7.103.0

package/package/corpus/rules/profiles.md

@@ -86,11 +86,20 @@ profile includes neither Screenplay nor Stage.
 | Profile ID | Description | Automatically Includes |
 |---|---|---|
 | `cratis/engineering` | Engineering conventions and workflows | `cratis/engineering/core`, `cratis/engineering/csharp`, `cratis/engineering/elixir`, `cratis/engineering/go`, `cratis/engineering/kotlin`, `cratis/engineering/react`, `cratis/engineering/typescript` |
-| `cratis/engineering/csharp` | C# engineering conventions and framework Orleans jobs (`cratis-orleans-jobs`, alongside `orleans.md`) | `cratis/engineering/core` |
+| `cratis/engineering/csharp` | C# engineering conventions, .NET engineering skills, and framework Orleans jobs (`cratis-orleans-jobs`, alongside `orleans.md`) | `cratis/engineering/core`, `cratis/engineering/dotnet` |
+| `cratis/engineering/dotnet` | Upstream .NET engineering workflows | `cratis/engineering/dotnet/performance`, `cratis/engineering/dotnet/diagnostics`, `cratis/engineering/dotnet/msbuild`, `cratis/engineering/dotnet/orleans`, `cratis/engineering/dotnet/testing`, `cratis/engineering/dotnet/refactoring` |
+| `cratis/engineering/dotnet/performance` | Microbenchmarking, performance patterns, SIMD, and profiling | (no child profiles) |
+| `cratis/engineering/dotnet/diagnostics` | Trace and crash-dump collection | (no child profiles) |
+| `cratis/engineering/dotnet/msbuild` | MSBuild troubleshooting, build authoring, output paths, and binlogs | (no child profiles) |
+| `cratis/engineering/dotnet/orleans` | Orleans primitives, hosting, persistence, and runtime behavior | (no child profiles) |
+| `cratis/engineering/dotnet/testing` | Test-platform detection, runner commands, filters, and coverage | (no child profiles) |
+| `cratis/engineering/dotnet/refactoring` | Behavior-preserving C# refactoring and AOT compatibility | (no child profiles) |
 | `cratis/engineering/go` | Go framework parity and immutable module releases | `cratis/engineering/core`, `cratis/language/go` |
 | `cratis/engineering/typescript` | TypeScript engineering conventions | `cratis/engineering/core` |
 | `cratis/engineering/react` | React engineering conventions | `cratis/engineering/core` |
 
+The `cratis/engineering/dotnet` profiles carry upstream skills under MIT, with attribution and changes in each skill's NOTICE. Cratis rules and the `cratis-*` skills win where they differ.
+
 The `cratis/engineering` profile also carries [issue-assignment.md](./issue-assignment.md): when an agent starts work on a numbered issue in a known repository and nobody is assigned, it assigns the current `gh` user.
 
 ### Language Profiles

package/package/corpus/rules/pull-requests.md

@@ -8,6 +8,8 @@ applyTo: "**/*"
 
 **The PR description is published verbatim as the GitHub release. In repositories released by `cratis/release-action`, it also closes every issue written as `(#n)`; elsewhere, follow the repository's own release and issue-closing process.** Write the note the person upgrading should read, not a development write-up. The same contract applies to release notes typed into a manual workflow run or written straight into a release. Where it is installed, the `policy / verify` check enforces it on release-bound PRs into the default branch carrying `major`/`minor`/`patch` (it re-runs when the label is added); its release-note step warns on `no-release` and unlabelled PRs, which must still be written this way because any of them may become releasable. `release-action` does not run for a `no-release` PR, so `(#n)` closes nothing there. Editing the description re-runs the check. HTML comments are not shown on the release page and the check ignores them for headings, keywords and placeholders, and `release-action` removes them before publishing, so a `(#n)` only inside a comment closes nothing; the check fails it, so never put an issue reference in a comment. The template's own comment can stay: its `(#123)` examples are inline code, and the comment is not published.
 
+**A change to a hook script or its wiring (`.cratis/ai/hooks/**`) needs a release-note line that tells consumers to run `cratis ai update`; a hook fix does not reach a repository until they do.**
+
 ### Allowed shape
 
 - Follow the repository's pull request template (`.github/pull_request_template.md`) within this contract.

package/package/corpus/rules/secrets.md

@@ -20,6 +20,10 @@ Every line is tagged **[contract]** (binding) per the Three Levels of Authority
 - **[contract] Project the field you need and say which one:** `-o jsonpath='{.spec.containers[*].image}'`,
   `-o custom-columns=…`, `kubectl get … -o name`, status fields, `kubectl logs`, `docker inspect --format`.
   Read a `.env.example`, never the `.env`.
+- **[contract] The hook reads command text only.** It cannot see a command piped into a shell
+  (`… | sh`, `bash -c "$(…)"`), a recursive search with no named file (`grep -r PASSWORD .`), or a
+  value reached through a variable, alias or script. These stay your rule to keep; output redaction
+  is the only backstop.
 
 ## Values
 

package/package/corpus/skills/analyzing-dotnet-performance/LICENSE

@@ -0,0 +1,23 @@
+The MIT License (MIT)
+
+Copyright (c) .NET Foundation and Contributors
+
+All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/package/corpus/skills/analyzing-dotnet-performance/NOTICE

@@ -0,0 +1,36 @@
+.NET Performance Patterns
+Copyright (c) .NET Foundation and Contributors
+Licensed under the MIT License. See LICENSE.
+
+Upstream source: https://github.com/dotnet/skills/blob/a6bf43ab61967c30919334986515163ab24d7635/plugins/dotnet-diag/skills/analyzing-dotnet-performance/SKILL.md
+
+Changes made by Cratis:
+
+LICENSE:
+- Copy upstream MIT license and copyright verbatim.
+
+SKILL.md:
+- Replace "I/O" with "input/output" in the description to satisfy the neutral-voice rule.
+- Normalize frontmatter serialization, add MIT license where absent; preserve name and description.
+- Add marked modification/source comment and applicability/Cratis precedence line.
+- Rewrite the description to the Cratis shape (what it does, Use when, Not for) and drop references to skills that are not part of this corpus.
+
+references/structural-patterns.md:
+- Qualify sealing advice to preserve published framework/library public API compatibility.
+
+references/async-patterns.md:
+- Add or normalize the top Contents list from existing headings; preserve section content.
+
+references/collections-and-linq.md:
+- Add or normalize the top Contents list from existing headings; preserve section content.
+
+references/critical-patterns.md:
+- Add or normalize the top Contents list from existing headings; preserve section content.
+
+references/io-and-serialization.md:
+- Add or normalize the top Contents list from existing headings; preserve section content.
+
+references/memory-and-strings.md:
+- Add or normalize the top Contents list from existing headings; preserve section content.
+
+NOTICE: Add this attribution, change list, and any download/execution disclosure.

package/package/corpus/skills/analyzing-dotnet-performance/SKILL.md

@@ -0,0 +1,214 @@
+---
+name: analyzing-dotnet-performance
+description: 'Scans .NET code for about 50 performance anti-patterns across async, memory, strings, collections, LINQ, regex, serialization, and input/output, with tiered severity. Use when analyzing .NET code for optimization opportunities, reviewing hot paths, or auditing allocation-heavy patterns. Not for measuring or profiling a running process (use profiling or microbenchmarking) or for SIMD work (use vectorization).'
+license: MIT
+---
+
+<!-- Modified by Cratis from dotnet's original (MIT): frontmatter, applicability, navigation and the changes listed in NOTICE. Upstream: https://github.com/dotnet/skills (plugins/dotnet-diag/skills/analyzing-dotnet-performance/SKILL.md; see NOTICE) -->
+
+# .NET Performance Patterns
+
+Cratis rules in `.cratis/ai/rules/` (including `csharp.md`, `specs.csharp.md`, and `orleans.md`) and the `cratis-*` skills win where they differ.
+
+Scan C#/.NET code for performance anti-patterns and produce prioritized findings with concrete fixes. Patterns sourced from the official .NET performance blog series, distilled to customer-actionable guidance.
+
+## When to Use
+
+- Reviewing C#/.NET code for performance optimization opportunities
+- Auditing hot paths for allocation-heavy or inefficient patterns
+- Systematic scan of a codebase for known anti-patterns before release
+- Second-opinion analysis after manual performance review
+
+## When Not to Use
+
+- **Algorithmic complexity analysis** — this skill targets API usage patterns, not algorithm design
+- **Code not on a hot path** with no performance requirements — avoid premature optimization
+
+## Inputs
+
+| Input | Required | Description |
+|-------|----------|-------------|
+| Source code | Yes | C# files, code blocks, or repository paths to scan |
+| Hot-path context | Recommended | Which code paths are performance-critical |
+| Target framework | Recommended | .NET version (some patterns require .NET 8+) |
+| Scan depth | Optional | `critical-only`, `standard` (default), or `comprehensive` |
+
+## Workflow
+
+### Step 1: Load Critical Reference
+
+Resolve bundled paths from the directory that contains this `SKILL.md`, not from the user's workspace. Load this reference file first:
+
+- `references/critical-patterns.md`
+
+If a direct read fails, list this skill's `references/` directory once and retry only when the listing shows the expected file. Do not use workspace file or text search to locate the skill installation.
+
+### Step 2: Detect Code Signals and Select Topic Recipes
+
+Scan the code for signals that indicate which pattern categories to check. Use the `## Detection` section from the critical reference when available and the inline recipes in Step 3 for initial signal detection.
+
+After detecting signals, load only the topic-specific references selected by scan depth:
+
+- `critical-only`: No additional references (use only `critical-patterns.md`)
+- `standard` (default): Load references matching detected signals from this list:
+  - `references/async-patterns.md` — async/Task/ValueTask signals
+  - `references/memory-and-strings.md` — Span/Memory/string allocation signals
+  - `references/regex-patterns.md` — Regex signals
+  - `references/collections-and-linq.md` — Dictionary/List/LINQ signals
+  - `references/io-and-serialization.md` — JsonSerializer/HttpClient/Stream signals
+  - `references/structural-patterns.md` — always loaded (unsealed classes checked regardless)
+- `comprehensive`: Load all six topic-specific references above
+
+For coverage reporting, the selected references are `references/critical-patterns.md` plus only the topic-specific references selected above. If any selected reference remains unavailable after retry, use the inline recipes in Step 3 for the missing coverage. Include `Reference coverage: reduced; unavailable: <paths>; used inline recipes for missing references.` in the final report, with `<paths>` replaced by the missing relative paths of the selected references only.
+
+Use the `## Detection` sections from loaded reference files and the inline recipes in Step 3 for categories whose reference files are unavailable.
+
+| Signal in Code | Topic |
+|----------------|-------|
+| `async`, `await`, `Task`, `ValueTask` | Async patterns |
+| `Span<`, `Memory<`, `stackalloc`, `ArrayPool`, `string.Substring`, `.Replace(`, `.ToLower()`, `+=` in loops, `params` | Memory & strings |
+| `Regex`, `[GeneratedRegex]`, `Regex.Match`, `RegexOptions.Compiled` | Regex patterns |
+| `Dictionary<`, `List<`, `.ToList()`, `.Where(`, `.Select(`, LINQ methods, `static readonly Dictionary<` | Collections & LINQ |
+| `JsonSerializer`, `HttpClient`, `Stream`, `FileStream` | I/O & serialization |
+
+Always check structural patterns (unsealed classes) regardless of signals.
+
+**Scan depth controls scope:**
+- `critical-only`: Only critical patterns (deadlocks, >10x regressions)
+- `standard` (default): Critical + detected topic patterns
+- `comprehensive`: All pattern categories
+
+### Step 3: Scan and Report
+
+**For files under 500 lines, read the entire file first** — you'll spot most patterns faster than running individual grep recipes. Use grep to confirm counts and catch patterns you might miss visually.
+
+For each relevant pattern category, run the detection recipes below. Report exact counts, not estimates.
+
+**Core scan recipes** (run these when reference files aren't available):
+```
+# Strings & memory
+grep -n '\.IndexOf(\"' FILE                    # Missing StringComparison
+grep -n '\.Substring(' FILE                    # Substring allocations
+grep -En '\.(StartsWith|EndsWith|Contains)\s*\(' FILE  # Missing StringComparison
+grep -n '\.ToLower()\|\.ToUpper()' FILE        # Culture-sensitive + allocation
+grep -n '\.Replace(' FILE                      # Chained Replace allocations
+grep -n 'params ' FILE                         # params array allocation
+
+# Collections & LINQ
+grep -n '\.Select\|\.Where\|\.OrderBy\|\.GroupBy' FILE  # LINQ on hot path
+grep -n '\.All\|\.Any' FILE                    # LINQ on string/char
+grep -n 'new Dictionary<\|new List<' FILE      # Per-call allocation
+grep -n 'static readonly Dictionary<' FILE     # FrozenDictionary candidate
+
+# Regex
+grep -n 'RegexOptions.Compiled' FILE           # Compiled regex budget
+grep -n 'new Regex(' FILE                      # Per-call regex
+grep -n 'GeneratedRegex' FILE                  # Positive: source-gen regex
+
+# Structural
+grep -n 'public class \|internal class ' FILE  # Unsealed classes
+grep -n 'sealed class' FILE                    # Already sealed
+grep -n ': IEquatable' FILE                    # Positive: struct equality
+```
+
+**Rules:**
+- Run every relevant recipe for the detected pattern categories
+- **Emit a scan execution checklist** before classifying findings — list each recipe and the hit count
+- A result of **0 hits** is valid and valuable (confirms good practice)
+- If reference files were loaded, also run their `## Detection` recipes
+
+**Verify-the-Inverse Rule:** For absence patterns, always count both sides and report the ratio (e.g., "N of M classes are sealed"). The ratio determines severity — 0/185 is systematic, 12/15 is a consistency fix.
+
+### Step 3b: Cross-File Consistency Check
+
+If an optimized pattern is found in one file, check whether sibling files (same directory, same interface, same base class) use the un-optimized equivalent. Flag as 🟡 Moderate with the optimized file as evidence.
+
+### Step 3c: Compound Allocation Check
+
+After running scan recipes, look for these multi-allocation patterns that single-line recipes miss:
+
+1. **Branched `.Replace()` chains:** Methods that call `.Replace()` across multiple `if/else` branches — report total allocation count across all branches, not just per-line.
+2. **Cross-method chaining:** When a public method delegates to another method that itself allocates intermediates (e.g., A calls B which does 3 regex replaces, then A calls C), report the total chain cost as one finding.
+3. **Compound `+=` with embedded allocating calls:** Lines like `result += $"...{Foo().ToLower()}"` are 2+ allocations (interpolation + ToLower + concatenation) — flag the compound cost, not just the `.ToLower()`.
+4. **`string.Format` specificity:** Distinguish resource-loaded format strings (not fixable) from compile-time literal format strings (fixable with interpolation). Enumerate the actionable sites.
+
+### Step 4: Classify and Prioritize Findings
+
+Assign each finding a severity:
+
+| Severity | Criteria | Action |
+|----------|----------|--------|
+| 🔴 **Critical** | Deadlocks, crashes, security vulnerabilities, >10x regression | Must fix |
+| 🟡 **Moderate** | 2-10x improvement opportunity, best practice for hot paths | Should fix on hot paths |
+| ℹ️ **Info** | Pattern applies but code may not be on a hot path | Consider if profiling shows impact |
+
+**Prioritization rules:**
+1. If the user identified hot-path code, elevate all findings in that code to their maximum severity
+2. If hot-path context is unknown, report 🔴 Critical findings unconditionally; report 🟡 Moderate findings with a note: _"Impactful if this code is on a hot path"_
+3. Never suggest micro-optimizations on code that is clearly not performance-sensitive
+
+**Scale-based severity escalation:**
+When the same pattern appears across many instances, escalate severity:
+- 1-10 instances of the same anti-pattern → report at the pattern's base severity
+- 11-50 instances → escalate ℹ️ Info patterns to 🟡 Moderate
+- 50+ instances → escalate to 🟡 Moderate with elevated priority; flag as a codebase-wide systematic issue
+
+Always report exact counts (from scan recipes), not estimates or agent summaries.
+
+### Step 5: Generate Findings
+
+**Keep findings compact.** Each finding is one short block — not an essay. Group by severity (🔴 → 🟡 → ℹ️), not by file.
+
+Format per finding:
+
+```
+#### ID. Title (N instances)
+**Impact:** one-line impact statement
+**Files:** file1.cs:L1, file2.cs:L2, ... (list locations, don't build tables)
+**Fix:** one-line description of the change (e.g., "Add `StringComparison.Ordinal` parameter")
+**Caveat:** only if non-obvious (version requirement, correctness risk)
+```
+
+**Rules for compact output:**
+- **No ❌/✅ code blocks** for trivial fixes (adding a keyword, parameter, or type change). A one-line fix description suffices.
+- **Only include code blocks** for non-obvious transformations (e.g., replacing a LINQ chain with a foreach loop, or hoisting a closure).
+- **File locations as inline comma-separated list**, not a table. Use `File.cs:L42` format.
+- **No explanatory prose** beyond the Impact line — the severity icon already conveys urgency.
+- **Merge related findings** that share the same fix (e.g., all `.ToLower()` calls go in one finding, not split by file).
+- **Positive findings** in a bullet list, not a table. One line per pattern: `✅ Pattern — evidence`.
+
+End with a summary table and disclaimer:
+
+```markdown
+| Severity | Count | Top Issue |
+|----------|-------|-----------|
+| 🔴 Critical | N | ... |
+| 🟡 Moderate | N | ... |
+| ℹ️ Info | N | ... |
+
+> ⚠️ **Disclaimer:** These results are generated by an AI assistant and are non-deterministic. Findings may include false positives, miss real issues, or suggest changes that are incorrect for your specific context. Always verify recommendations with benchmarks and human review before applying changes to production code.
+```
+
+## Validation
+
+Before delivering results, verify:
+
+- [ ] All critical patterns were checked (from reference files or inline recipes)
+- [ ] Topic-specific recipes run only when matching signals detected
+- [ ] Each finding includes a concrete code fix
+- [ ] Scan execution checklist is complete (all recipes run)
+- [ ] Summary table included at end
+
+## Common Pitfalls
+
+| Pitfall | Correct Approach |
+|---------|-----------------|
+| Flagging every `Dictionary` as needing `FrozenDictionary` | Only flag if the dictionary is never mutated after construction |
+| Suggesting `Span<T>` in async methods | Use `Memory<T>` in async code; `Span<T>` only in sync hot paths |
+| Reporting LINQ outside hot paths | Only flag LINQ in identified hot paths or tight loops; LINQ is acceptable in code that runs infrequently. Since .NET 7, LINQ Min/Max/Sum/Average are vectorized — blanket bans on LINQ are misguided |
+| Suggesting `ConfigureAwait(false)` in app code | Only applicable in library code; not primarily a performance concern |
+| Recommending `ValueTask` everywhere | Only for hot paths with frequent synchronous completion |
+| Flagging `new HttpClient()` in DI services | Check if `IHttpClientFactory` is already in use |
+| Suggesting `[GeneratedRegex]` for dynamic patterns | Only flag when the pattern string is a compile-time literal |
+| Suggesting `CollectionsMarshal.AsSpan` broadly | Only for ultra-hot paths with benchmarked evidence; adds complexity and fragility |
+| Suggesting `unsafe` code for micro-optimizations | Avoid `unsafe` except where absolutely necessary — do not recommend it for micro-optimizations that don't matter. Safe alternatives like `Span<T>`, `stackalloc` in safe context, and `ArrayPool` cover the vast majority of performance needs |

package/package/corpus/skills/analyzing-dotnet-performance/references/async-patterns.md

@@ -0,0 +1,122 @@
+# Async & Concurrency Patterns
+
+## Contents
+
+- Don't Expose Async Wrappers for Sync Methods
+- Don't Expose Sync Wrappers for Async Methods
+- Use ValueTask for Hot Paths with Frequent Sync Completion
+- Use Channels for Producer/Consumer
+- Avoid False Sharing with Thread-Local State
+- Detection
+  - Patterns Requiring Manual Review
+
+### Don't Expose Async Wrappers for Sync Methods
+🟡 **AVOID** wrapping sync methods with `Task.Run` in libraries | .NET Core+
+
+❌
+```csharp
+public Task<int> ComputeHashAsync(byte[] data) =>
+    Task.Run(() => ComputeHash(data));
+```
+✅
+```csharp
+public int ComputeHash(byte[] data) { /* CPU-bound work */ }
+// Consumer decides: var hash = await Task.Run(() => lib.ComputeHash(data));
+```
+
+**Impact: Eliminates unnecessary thread pool queue/dequeue overhead per call.**
+
+### Don't Expose Sync Wrappers for Async Methods
+🟡 **AVOID** creating sync wrappers that block on async implementations | .NET Core+
+
+❌
+```csharp
+public string GetData() => GetDataAsync().Result;
+```
+✅
+```csharp
+public async Task<string> GetDataAsync() { /* ... */ }
+```
+
+**Impact: Prevents deadlocks and thread pool starvation from hidden sync-over-async blocking.**
+
+### Use ValueTask for Hot Paths with Frequent Sync Completion
+🟡 **DO** use `ValueTask<T>` on hot paths where sync completion is common | .NET Core 2.1+
+
+❌
+```csharp
+public async Task<int> ReadAsync(Memory<byte> buffer)
+{
+    if (_bufferedCount > 0)
+        return ReadFromBuffer(buffer.Span);
+    return await ReadAsyncCore(buffer);
+}
+```
+✅
+```csharp
+public ValueTask<int> ReadAsync(Memory<byte> buffer)
+{
+    if (_bufferedCount > 0)
+        return new ValueTask<int>(ReadFromBuffer(buffer.Span));
+    return new ValueTask<int>(ReadAsyncCore(buffer));
+}
+```
+
+**Impact: Eliminates Task\<T\> allocation on synchronous completion — the struct stores results inline.**
+
+### Use Channels for Producer/Consumer
+🟡 **DO** use `System.Threading.Channels` for producer-consumer patterns | .NET Core 3.0+
+
+❌
+```csharp
+var queue = new BlockingCollection<WorkItem>();
+var item = queue.Take();
+```
+✅
+```csharp
+var channel = Channel.CreateUnbounded<WorkItem>();
+
+// Producer
+await channel.Writer.WriteAsync(item);
+
+// Consumer
+await foreach (var item in channel.Reader.ReadAllAsync())
+    Process(item);
+```
+
+**Impact: ~25% faster, ~95% fewer GC collections vs manual approaches.**
+
+### Avoid False Sharing with Thread-Local State
+🟡 **AVOID** adjacent mutable fields written by different threads | .NET 7+
+
+❌
+```csharp
+class SharedCounters
+{
+    public long Counter1;
+    public long Counter2;
+}
+```
+✅
+```csharp
+[StructLayout(LayoutKind.Explicit, Size = 128)]
+struct PaddedCounter
+{
+    [FieldOffset(0)] public long Value;
+}
+```
+
+**Impact: Eliminates cross-core cache invalidation — can improve multi-threaded throughput by 10x+.**
+
+## Detection
+
+Scan recipes for async anti-patterns. Run these and report exact counts.
+
+```bash
+# async void methods (correctness issue — crashes on exception)
+grep -rn --include='*.cs' 'async void' --exclude-dir=bin --exclude-dir=obj . | grep -v 'event' | wc -l
+```
+
+### Patterns Requiring Manual Review
+
+- **Sync-over-async** (`.Result`, `.Wait()`): `.Result` matches any property named Result — needs type context to confirm it's `Task.Result`

package/package/corpus/skills/analyzing-dotnet-performance/references/collections-and-linq.md

@@ -0,0 +1,220 @@
+# Collections & LINQ Patterns
+
+## Contents
+
+- Use FrozenDictionary/FrozenSet for Read-Heavy Lookup Tables
+- Use Dictionary Alternate Lookup for Span-Based Keys
+- Use CollectionsMarshal.GetValueRefOrNullRef for Lookup-and-Update
+- Use Collection Expressions [] for Zero-Allocation Span Creation
+- Use EnsureCapacity on List/Stack/Queue Before Bulk Adds
+- Use TryGetNonEnumeratedCount for Pre-Sizing
+- Hoist Static Data Out of Method Bodies
+- Add Overloads to Avoid params Array Allocation
+- Detection
+  - Patterns Requiring Manual Review
+
+### Use FrozenDictionary/FrozenSet for Read-Heavy Lookup Tables
+🟡 **DO** use `FrozenDictionary`/`FrozenSet` for collections created once and read many times | .NET 8+
+
+❌
+```csharp
+private static readonly Dictionary<string, int> s_statusCodes = new()
+{
+    ["OK"] = 200, ["NotFound"] = 404, ["InternalServerError"] = 500
+};
+```
+✅
+```csharp
+private static readonly FrozenDictionary<string, int> s_statusCodes =
+    new Dictionary<string, int>
+    {
+        ["OK"] = 200, ["NotFound"] = 404, ["InternalServerError"] = 500
+    }.ToFrozenDictionary();
+```
+
+**Impact: ~50% faster lookups than Dictionary, ~14x faster than ImmutableDictionary.**
+
+### Use Dictionary Alternate Lookup for Span-Based Keys
+🟡 **DO** use `GetAlternateLookup<ReadOnlySpan<char>>()` to avoid string allocation on lookups | .NET 9+
+
+❌
+```csharp
+string key = headerLine.Substring(0, colonIndex);
+if (s_dict.TryGetValue(key, out int value)) { /* ... */ }
+```
+✅
+```csharp
+var lookup = s_dict.GetAlternateLookup<ReadOnlySpan<char>>();
+ReadOnlySpan<char> key = headerLine.AsSpan(0, colonIndex);
+if (lookup.TryGetValue(key, out int value)) { }
+```
+
+**Impact: Avoids string allocation per lookup — especially valuable in parser/protocol hot paths.**
+
+### Use CollectionsMarshal.GetValueRefOrNullRef for Lookup-and-Update
+🟡 **DO** use `CollectionsMarshal.GetValueRefOrAddDefault` for dictionary update patterns | .NET 6+
+
+❌
+```csharp
+_counts.TryGetValue(key, out int count);
+_counts[key] = count + 1;
+```
+✅
+```csharp
+ref int count = ref CollectionsMarshal.GetValueRefOrAddDefault(_counts, key, out _);
+count++;
+```
+
+**Impact: ~48% faster for lookup-and-update patterns (95µs → 49µs).**
+
+### Use Collection Expressions [] for Zero-Allocation Span Creation
+🟡 **DO** use collection expressions for `Span<T>` targets | C# 12 / .NET 8+
+
+❌
+```csharp
+int[] values = new int[] { a, b, c, d };
+```
+✅
+```csharp
+Span<int> values = [a, b, c, d];
+ReadOnlySpan<int> daysInMonth = [31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31];
+```
+
+**Impact: Zero heap allocation for span-targeted collection expressions.**
+
+### Use EnsureCapacity on List/Stack/Queue Before Bulk Adds
+🟡 **DO** call `EnsureCapacity` before bulk insertions | .NET 6+
+
+❌
+```csharp
+var list = new List<int>();
+for (int i = 0; i < 10000; i++)
+    list.Add(i);
+```
+✅
+```csharp
+var list = new List<int>();
+list.EnsureCapacity(10000);
+for (int i = 0; i < 10000; i++)
+    list.Add(i);
+```
+
+**Impact: Reduces reallocations and array copies during bulk operations.**
+
+### Use TryGetNonEnumeratedCount for Pre-Sizing
+🟡 **DO** use `TryGetNonEnumeratedCount` to pre-size destination collections | .NET 6+
+
+❌
+```csharp
+var results = new List<int>();
+foreach (var item in source)
+    results.Add(Transform(item));
+```
+✅
+```csharp
+var results = source.TryGetNonEnumeratedCount(out int count)
+    ? new List<int>(count)
+    : new List<int>();
+foreach (var item in source)
+    results.Add(Transform(item));
+```
+
+**Impact: Avoids O(n) enumeration for counting; eliminates resizing allocations.**
+
+### Hoist Static Data Out of Method Bodies
+🟡 **AVOID** creating collections with static/deterministic data inside method bodies | .NET Core+
+
+❌
+```csharp
+public string Convert(long number)
+{
+    var groupsMap = new Dictionary<long, Func<long, string>>
+    {
+        { 1_000_000_000, n => $"{Convert(n)} billion" },
+        { 1_000_000, n => $"{Convert(n)} million" },
+        { 1_000, n => $"{Convert(n)} thousand" },
+    };
+}
+```
+✅
+```csharp
+private static readonly FrozenDictionary<long, Func<long, string>> s_groupsMap =
+    new Dictionary<long, Func<long, string>>
+    {
+        { 1_000_000_000, n => $"{Convert(n)} billion" },
+        { 1_000_000, n => $"{Convert(n)} million" },
+        { 1_000, n => $"{Convert(n)} thousand" },
+    }.ToFrozenDictionary();
+
+public string Convert(long number)
+{
+    // ... use s_groupsMap
+}
+```
+
+**Impact: Eliminates collection + internal storage + closure allocations per call. For a Dictionary with N entries, saves ~N+3 allocations per invocation.**
+
+### Add Overloads to Avoid params Array Allocation
+🟡 **DO** add 1- and 2-argument overloads for methods that accept `params T[]`, or use `params ReadOnlySpan<T>` on .NET 9+ | .NET Core+
+
+❌
+```csharp
+public static string Transform(this string input, params IStringTransformer[] transformers) =>
+    transformers.Aggregate(input, (current, t) => t.Transform(current));
+
+"hello".Transform(To.TitleCase);
+```
+✅
+```csharp
+// Option A: Explicit overloads for common arities
+public static string Transform(this string input, IStringTransformer transformer) =>
+    transformer.Transform(input);
+
+public static string Transform(this string input, IStringTransformer t1, IStringTransformer t2) =>
+    t2.Transform(t1.Transform(input));
+
+public static string Transform(this string input, params IStringTransformer[] transformers) =>
+    transformers.Aggregate(input, (current, t) => t.Transform(current));
+
+// Option B (.NET 9+ / C# 13): params ReadOnlySpan<T> — zero heap allocation
+public static string Transform(this string input, params ReadOnlySpan<IStringTransformer> transformers)
+{
+    foreach (var t in transformers)
+        input = t.Transform(input);
+    return input;
+}
+```
+
+**Impact: Eliminates one array allocation per call for the common 1- and 2-argument cases. `params ReadOnlySpan<T>` eliminates it for all arities.**
+
+## Detection
+
+Scan recipes for collection and LINQ anti-patterns. Run these and report exact counts.
+
+```bash
+# Static Dictionary not using FrozenDictionary (read-only after init)
+grep -rn --include='*.cs' 'static readonly Dictionary<' --exclude-dir=bin --exclude-dir=obj . | wc -l
+
+# Static FrozenDictionary (already optimized — verify the inverse)
+grep -rn --include='*.cs' 'static readonly FrozenDictionary<' --exclude-dir=bin --exclude-dir=obj . | wc -l
+
+# Per-call List allocation (inside method bodies, not static/readonly fields)
+grep -rn --include='*.cs' 'new List<' --exclude-dir=bin --exclude-dir=obj . | grep -v 'static\|readonly' | wc -l
+
+# Per-call Dictionary allocation (inside method bodies, not static/readonly fields)
+grep -rn --include='*.cs' 'new Dictionary<' --exclude-dir=bin --exclude-dir=obj . | grep -v 'static\|readonly' | wc -l
+
+# StringComparer.CurrentCulture usage (almost always wrong in library code — use Ordinal)
+grep -rn --include='*.cs' 'StringComparer.CurrentCulture' --exclude-dir=bin --exclude-dir=obj . | wc -l
+
+# LINQ chains in extension/hot-path files (.Select, .Where, .Cast, .Take, .Aggregate)
+grep -rn --include='*.cs' -E '\.(Select|Where|Cast|Take|Aggregate)\(' --exclude-dir=bin --exclude-dir=obj . | wc -l
+```
+
+For the LINQ chain recipe: any hit in a file whose name ends in `Extensions.cs`, `Formatter.cs`, or implements a method called from a public extension method is a hot-path candidate. Inspect each hit in these files and flag LINQ chains that allocate delegates, enumerators, or intermediate collections on every call. Hits in localization converters or one-time initialization are lower priority.
+
+### Patterns Requiring Manual Review
+
+- **ContainsKey + indexer double-lookup**: Requires verifying the same key is used in a subsequent indexer access — multi-line/multi-statement context
+- **LINQ on hot paths**: The LINQ chain recipe above catches call sites, but distinguishing hot-path from cold-path requires context. Prioritize hits in `*Extensions.cs` and `*Formatter.cs` files, which are typically called on every user invocation
+- **`new Dictionary/List<` in method bodies vs fields**: The grep heuristic (`grep -v 'static\|readonly'`) catches most cases but may include false positives from field initializers without `static`/`readonly` — spot-check flagged lines