@cratis/eslint-plugin-arc 20.44.2 → 20.45.0

package/README.md

@@ -7,6 +7,7 @@ base config, [`@cratis/eslint-config`](https://www.npmjs.com/package/@cratis/esl
 |---|---|
 | `skip-generated-proxies` (processor) | Skips Arc-generated proxy files wholesale. They carry a `// @generated by Cratis` header (and a `**DO NOT EDIT**` banner), cannot be edited, and are regenerated by the build — so any finding on them is un-actionable. Keyed on the header because proxies sit intermixed with hand-written `.ts`. |
 | `no-hooks-in-view-model` | Disallows React hook calls inside MVVM view models (classes named `*ViewModel`). A view model must be a plain, React-free class; inject Cratis abstractions instead of calling hooks. |
+| `no-direct-mobx-react-import` | Disallows direct imports from `mobx-react` or `mobx-react-lite`. The MobX binding is an internal detail of `@cratis/arc.react.mvvm`, which re-exports `observer` (the sanctioned leaf observer boundary) — import it from there so the binding can evolve without breaking consumers. |
 
 ## Install
 

package/index.js

@@ -1,5 +1,6 @@
 import { createRequire } from 'node:module';
 import { noHooksInViewModel } from './lib/noHooksInViewModel.js';
+import { noDirectMobxReactImport } from './lib/noDirectMobxReactImport.js';
 import { isGeneratedProxy, skipGeneratedProxies } from './lib/skipGeneratedProxies.js';
 
 const { version } = createRequire(import.meta.url)('./package.json');
@@ -10,7 +11,10 @@ const { version } = createRequire(import.meta.url)('./package.json');
 // directly. Composes on top of @cratis/eslint-config.
 const plugin = {
     meta: { name: '@cratis/eslint-plugin-arc', version },
-    rules: { 'no-hooks-in-view-model': noHooksInViewModel },
+    rules: {
+        'no-hooks-in-view-model': noHooksInViewModel,
+        'no-direct-mobx-react-import': noDirectMobxReactImport,
+    },
     processors: { 'skip-generated-proxies': skipGeneratedProxies },
     configs: {},
 };
@@ -33,6 +37,7 @@ Object.assign(plugin.configs, {
             plugins: { '@cratis/arc': plugin },
             rules: {
                 '@cratis/arc/no-hooks-in-view-model': 'error',
+                '@cratis/arc/no-direct-mobx-react-import': 'error',
             },
         },
     ],
@@ -40,4 +45,4 @@ Object.assign(plugin.configs, {
 
 export default plugin;
 export const { configs, rules, processors, meta } = plugin;
-export { noHooksInViewModel, skipGeneratedProxies, isGeneratedProxy };
+export { noHooksInViewModel, noDirectMobxReactImport, skipGeneratedProxies, isGeneratedProxy };

package/lib/noDirectMobxReactImport.js

@@ -0,0 +1,33 @@
+const FORBIDDEN_MODULES = new Set(['mobx-react', 'mobx-react-lite']);
+
+// Flags direct imports from 'mobx-react' or 'mobx-react-lite'. In a Cratis Arc application the
+// MobX binding is an internal detail of @cratis/arc.react.mvvm: 'observer' (the sanctioned leaf
+// observer boundary) is re-exported from there, so consumers should never reach for the underlying
+// MobX React packages directly. Importing 'observer' through @cratis/arc.react.mvvm lets the binding
+// evolve without breaking consumers and keeps the sanctioned boundary discoverable.
+export const noDirectMobxReactImport = {
+    meta: {
+        type: 'problem',
+        docs: {
+            description: "Disallow direct imports from 'mobx-react' or 'mobx-react-lite'; import 'observer' from '@cratis/arc.react.mvvm' instead.",
+            recommended: true,
+            url: 'https://github.com/Cratis/Arc/blob/main/Source/JavaScript/Arc.ESLint/README.md',
+        },
+        schema: [],
+        messages: {
+            noDirectImport: "Do not import from '{{module}}'. Import 'observer' from '@cratis/arc.react.mvvm' instead — the MobX binding is an internal detail of Cratis Arc MVVM.",
+        },
+    },
+    create(context) {
+        return {
+            ImportDeclaration(node) {
+                const module = node.source.value;
+                if (FORBIDDEN_MODULES.has(module)) {
+                    context.report({ node: node.source, messageId: 'noDirectImport', data: { module } });
+                }
+            },
+        };
+    },
+};
+
+export default noDirectMobxReactImport;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@cratis/eslint-plugin-arc",
-    "version": "20.44.2",
+    "version": "20.45.0",
     "description": "Cratis Arc ESLint rules: skip generated proxies and keep MVVM view models React-free. Compose on top of @cratis/eslint-config.",
     "author": "Cratis",
     "license": "MIT",