@cratis/components.migrator 4.14.0 → 4.14.2

package/README.md

@@ -2,10 +2,10 @@
 
 The Components 4 Migrator updates a Components 3 codebase to the Components 4 public contracts. It moves root namespaces to explicit subpath imports, replaces deprecated Button appearance props, and changes legacy event-wrapper callbacks to semantic value callbacks. The CLI uses syntax-aware codemods internally, but each command is named for the migration it performs, can be run independently, and is idempotent. Components 4 keeps only package-wide provider setup at the root; every component is imported from its explicit subpath (`@cratis/components/Canvas`, for example). The companion `@cratis/eslint-plugin-components` package's `no-root-barrel-import` rule enforces this once a consumer has migrated.
 
-> **Publication status:** The install examples target the owner-authorized 4.0.0 npm release. When
-> reading this README from repository source before that release, verify availability with
-> `npm view @cratis/components.migrator@4.0.0 version`; source contributors run the workspace
-> commands from this checkout instead. The Migrator is never an application runtime dependency.
+The package is published on npm and released at the same version as `@cratis/components`
+(4.0.0 onward). Run it with `npx`, `pnpm dlx`, or `yarn dlx` as shown below; it is never an
+application runtime dependency. Contributors to this repository can run the workspace scripts
+directly instead.
 
 The published package is a **CLI-only** tool. Its public surface is the documented `cratis-components-*` executable names (plus `./package.json` for tooling metadata); `lib/`, `scripts/`, and individual transforms are implementation details and are blocked by the package export map. Do not import them from application code or build custom migration APIs on them.
 
@@ -181,21 +181,16 @@ The transform never guesses through JSX spreads, dynamic legacy values, duplicat
 
 ## `change-handler`
 
-`cratis-components-change-handler` resolves affected Components-owned JSX identifiers imported with aliases or namespaces from `@cratis/components/Dropdown`, `@cratis/components/CommandForm`, and `@cratis/components/CommandForm/fields`. It rewrites only a structurally-proven single forwarding callback:
+`cratis-components-change-handler` resolves Components-owned JSX identifiers imported with aliases or namespaces from `@cratis/components/Dropdown`, `@cratis/components/CommandForm`, and `@cratis/components/CommandForm/fields`. It rewrites structurally-proven single forwarding callbacks on standalone `Dropdown` and CommandForm field `onValueChange` props:
 
 ```tsx
-// Safe rewrites
+// Before
 <Dropdown onChange={(event) => setRole(event.value)} />
-<InputTextField onChange={(event) => setName(event.target.value)} />
-<CheckboxField onChange={({ target: { checked } }) => setEnabled(checked)} />
-
-// become
+// After
 <Dropdown onChange={(value) => setRole(value)} />
-<InputTextField onChange={(value) => setName(value)} />
-<CheckboxField onChange={(value) => setEnabled(value)} />
 ```
 
-The affected CommandForm fields cover legacy `target`/`currentTarget` `value`, `checked`, and `valueAsNumber` payloads, plus `DropdownField`/`MultiSelectField` `event.value`. Already-semantic callbacks and callback references such as `onChange={setValue}` are unchanged.
+For Components 4 CommandForm fields, the codemod leaves `onChange` unchanged and reports an actionable diagnostic instead of changing its callback. Arc's `asCommandFormField` wrappers do not expose `onChange` as a field prop in Components 4, so keeping the attribute would produce TS2322 even if the callback were rewritten. Move its side effects to the enclosing `CommandForm`'s `onFieldChange(command, fieldName, oldValue, newValue, validationInfo?)` callback. Legacy `onValueChange` field callbacks with a proven event payload are rewritten to semantic values; already-semantic `onValueChange` callbacks are untouched. The [Components 3 to 4 migration guide](https://cratis.io/components/migration/3-to-4/) covers this case.
 
 Multi-statement, multi-use, wrong-payload, destructuring-with-default/rest, and native-event-dependent callbacks are refused, reported, and annotated once:
 
@@ -254,7 +249,9 @@ node Migrator/scripts/change-handler.js --check Source
 cd Migrator && yarn test
 ```
 
-Repository fixtures for every supported and unsupported case live under
+Repository fixtures for every supported and unsupported root-import case live under
 `Migrator/test/fixtures`,
 each as an `input.ts`/`expected.ts` pair (`input.ts` and `expected.ts` are identical for an
-unsupported case, since nothing should change).
+unsupported case, since nothing should change). The Button and change-handler transforms use
+`input.tsx`/`expected.tsx` pairs under `Migrator/test/button-fixtures` and
+`Migrator/test/change-handler-fixtures`.

package/lib/changeHandlerTransform.js

@@ -96,6 +96,14 @@ export function transformChangeHandlers(fileName, text, options = {}) {
             if (!ts.isJsxAttribute(attribute)) continue;
             const propName = attribute.name.getText(sourceFile);
             if (propName !== 'onChange' && propName !== 'onValueChange') continue;
+            if (target.group === 'CommandForm' && propName === 'onChange') {
+                report(
+                    attribute,
+                    target.component,
+                    "Components 4 field props do not accept onChange; move the handler to the enclosing CommandForm's onFieldChange(command, fieldName, oldValue, newValue, validationInfo?)",
+                );
+                continue;
+            }
             if (
                 !attribute.initializer ||
                 !ts.isJsxExpression(attribute.initializer) ||

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@cratis/components.migrator",
-    "version": "4.14.0",
+    "version": "4.14.2",
     "description": "Migration tooling for updating @cratis/components consumers from Components 3 to Components 4.",
     "author": "Cratis",
     "license": "MIT",