@cratis/chronicle 6.34.0 → 6.36.0

package/reactors/for_ReactorDispatcher/when_selecting_explicit_handlers.spec.ts

@@ -0,0 +1,64 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { EventObservationState } from '@cratis/chronicle.contracts';
+import { beforeEach, chai, describe, it } from 'vitest';
+import { eventType } from '../../events/eventTypeDecorator.js';
+import { handles, onceOnly, replay } from '../index.js';
+import { getReactorEventTypes, selectReactorHandler } from '../ReactorDispatcher.js';
+
+chai.should();
+
+@eventType('selected-handler')
+class AuthorRegistered {}
+
+function selected(type: new () => object, state: EventObservationState) {
+    return selectReactorHandler(getReactorEventTypes(type, [AuthorRegistered]), type, undefined, 'selected-handler', state)!;
+}
+
+describe('when selecting an explicit handler with a replay alternative', () => {
+    class Observer {
+        @handles(AuthorRegistered)
+        @onceOnly()
+        notify() {}
+
+        @replay(AuthorRegistered)
+        rebuild() {}
+    }
+    it('should select the explicit method for live events', () => {
+        selected(Observer, EventObservationState.Initial).methodName!.should.equal('notify');
+    });
+    it('should select the replay alternative even when the live method is onceOnly', () => {
+        selected(Observer, EventObservationState.Replay).should.deep.equal({ methodName: 'rebuild', isReplay: true, skipReplay: false });
+    });
+});
+
+describe('when selecting an explicit handler without a replay alternative', () => {
+    class Observer { @handles(AuthorRegistered) notify() {} }
+    let handler: ReturnType<typeof selected>;
+    beforeEach(() => { handler = selected(Observer, EventObservationState.Replay); });
+    it('should use the explicit method during replay too', () => {
+        handler.should.deep.equal({ methodName: 'notify', isReplay: true, skipReplay: false });
+    });
+});
+
+describe('when an explicit handler is onceOnly', () => {
+    class Observer { @onceOnly() @handles(AuthorRegistered) notify() {} }
+    it('should not skip live delivery', () => {
+        selected(Observer, EventObservationState.Initial).skipReplay.should.be.false;
+    });
+    it('should skip replay delivery', () => {
+        selected(Observer, EventObservationState.Replay).skipReplay.should.be.true;
+    });
+});
+
+describe('when a method declares both live and replay roles', () => {
+    class Observer { @handles(AuthorRegistered) @replay(AuthorRegistered) notify() {} }
+    it('should reject the ambiguous declaration during discovery', () => {
+        (() => getReactorEventTypes(Observer, [AuthorRegistered])).should.throw(/notify.*Observer.*cannot combine @handles and @replay/);
+    });
+    it('should reject replay above handles too', () => {
+        class Reversed { @replay(AuthorRegistered) @handles(AuthorRegistered) notify() {} }
+        (() => getReactorEventTypes(Reversed, [AuthorRegistered])).should.throw(/notify.*Reversed.*cannot combine @handles and @replay/);
+    });
+});

package/reactors/for_Reactors/when_activating_a_field_override.spec.ts

@@ -0,0 +1,62 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { EventContext, EventType, ObservationState, ReplayState, type ReactorMessage } from '@cratis/chronicle.contracts';
+import { beforeEach, chai, describe, it } from 'vitest';
+import type { IClientArtifactsProvider } from '../../artifacts/index.js';
+import type { ChronicleConnection } from '../../connection/index.js';
+import { ConnectionLifecycle } from '../../connection/ConnectionLifecycle.js';
+import type { IEventLog } from '../../eventSequences/IEventLog.js';
+import type { IEventStore } from '../../IEventStore.js';
+import { eventType } from '../../events/eventTypeDecorator.js';
+import { handles, reactor, Reactors } from '../index.js';
+
+chai.should();
+
+@eventType('field-reactor-event')
+class AuthorRegistered {}
+const calls: string[] = [];
+class Base {
+    @handles(AuthorRegistered) notify() { calls.push('base'); }
+    beginReplay() { calls.push('replay'); }
+    endReplay() {}
+}
+@reactor('field-reactor')
+class Derived extends Base {
+    override notify = () => { calls.push('field'); };
+}
+
+for (const replayState of [ReplayState.REPLAY_STATE_None, ReplayState.BeginReplay]) {
+    describe(`when activating a reactor with a field override for replay state ${replayState}`, () => {
+        let result: ReactorMessage;
+        let disposed: boolean;
+        beforeEach(async () => {
+            calls.length = 0;
+            disposed = false;
+            const lifecycle = new ConnectionLifecycle();
+            let finish!: () => void;
+            const finished = new Promise<void>(resolve => { finish = resolve; });
+            async function* stream(queue: AsyncIterable<ReactorMessage>) {
+                const messages = queue[Symbol.asyncIterator]();
+                await messages.next();
+                yield { Events: [{ Content: '{}', Context: EventContext.fromPartial({
+                    EventType: EventType.fromPartial({ Id: 'field-reactor-event', Generation: 1 }), SequenceNumber: 1n
+                }) }], Partition: 'author', ReplayState: replayState, InitialState: '' };
+                result = (await messages.next()).value!;
+                await lifecycle.disconnected(error => { throw error; });
+                finish();
+            }
+            const reactors = new Reactors({ reactors: [Derived], eventTypes: [AuthorRegistered] } as unknown as IClientArtifactsProvider,
+                { reactors: { observe: stream } } as unknown as ChronicleConnection, 'store', 'tenant', lifecycle, {} as IEventLog,
+                undefined, { readModels: {} } as IEventStore, type => ({ instance: new type(), dispose: () => { disposed = true; } }));
+            try { await reactors.register(); await finished; } finally { reactors.dispose(); }
+        });
+        it('should fail delivery without invoking the field or replay notification', () => {
+            calls.should.have.lengthOf(0);
+            result.Content!.Value1!.State.should.equal(ObservationState.Failed);
+            result.Content!.Value1!.ExceptionMessages.join(' ').should.contain(
+                "Override 'notify' on 'Derived' hides @handles(AuthorRegistered) declared on 'Base'; use a method with @handles instead of an instance field.");
+        });
+        it('should release the rejected activation lease', () => { disposed.should.be.true; });
+    });
+}

package/reactors/for_Reactors/when_delivering_to_instance_handlers.spec.ts

@@ -0,0 +1,108 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { EventContext, EventObservationState, EventType, ObservationState, ReplayState, type ReactorMessage } from '@cratis/chronicle.contracts';
+import { beforeEach, chai, describe, it } from 'vitest';
+import type { IClientArtifactsProvider } from '../../artifacts/index.js';
+import type { ChronicleConnection } from '../../connection/index.js';
+import { ConnectionLifecycle } from '../../connection/ConnectionLifecycle.js';
+import type { IEventLog } from '../../eventSequences/IEventLog.js';
+import type { IEventStore } from '../../IEventStore.js';
+import { eventType } from '../../events/eventTypeDecorator.js';
+import { handles, reactor, Reactors, replay } from '../index.js';
+
+chai.should();
+
+@eventType('instance-reactor-event')
+class AuthorRegistered {}
+const calls: string[] = [];
+
+@reactor('bound-conventional-reactor')
+class BoundConventional {
+    readonly marker = 'bound conventional';
+    constructor() { this.authorRegistered = this.authorRegistered.bind(this); }
+    authorRegistered() { calls.push(this.marker); }
+}
+
+@reactor('bound-explicit-reactor')
+class BoundExplicit {
+    readonly marker = 'bound explicit';
+    constructor() { this.notify = this.notify.bind(this); }
+    @handles(AuthorRegistered)
+    notify() { calls.push(this.marker); }
+}
+
+class BoundExplicitBase {
+    readonly marker = 'twice bound explicit';
+    constructor() { this.notify = this.notify.bind(this); }
+    @handles(AuthorRegistered)
+    notify() { calls.push(this.marker); }
+}
+
+@reactor('twice-bound-explicit-reactor')
+class TwiceBoundExplicit extends BoundExplicitBase {
+    constructor() { super(); this.notify = this.notify.bind(this); }
+}
+
+class Conventional {
+    authorRegistered() { calls.push('base'); }
+}
+
+@reactor('field-conventional-reactor')
+class FieldConventional extends Conventional {
+    override authorRegistered = () => { calls.push('field conventional'); };
+}
+
+@reactor('bound-replay-reactor')
+class BoundReplay {
+    readonly marker = 'bound replay';
+    constructor() { this.restore = this.restore.bind(this); }
+    @replay(AuthorRegistered)
+    restore() { calls.push(this.marker); }
+}
+
+class Replay {
+    @replay(AuthorRegistered)
+    restore() { calls.push('base replay'); }
+}
+
+@reactor('field-replay-reactor')
+class FieldReplay extends Replay {
+    override restore = () => { calls.push('field replay'); };
+}
+
+for (const { type, expected, observationState } of [
+    { type: BoundConventional, expected: 'bound conventional', observationState: EventObservationState.Initial },
+    { type: BoundExplicit, expected: 'bound explicit', observationState: EventObservationState.Initial },
+    { type: TwiceBoundExplicit, expected: 'twice bound explicit', observationState: EventObservationState.Initial },
+    { type: FieldConventional, expected: 'field conventional', observationState: EventObservationState.Initial },
+    { type: BoundReplay, expected: 'bound replay', observationState: EventObservationState.Replay },
+    { type: FieldReplay, expected: 'field replay', observationState: EventObservationState.Replay }
+]) {
+    describe(`when delivering to the ${expected} reactor handler without an activator`, () => {
+        let result: ReactorMessage;
+        beforeEach(async () => {
+            calls.length = 0;
+            const lifecycle = new ConnectionLifecycle();
+            let finish!: () => void;
+            const finished = new Promise<void>(resolve => { finish = resolve; });
+            async function* stream(queue: AsyncIterable<ReactorMessage>) {
+                const messages = queue[Symbol.asyncIterator]();
+                await messages.next();
+                yield { Events: [{ Content: '{}', Context: EventContext.fromPartial({
+                    EventType: EventType.fromPartial({ Id: 'instance-reactor-event', Generation: 1 }), SequenceNumber: 1n,
+                    ObservationState: observationState
+                }) }], Partition: 'author', ReplayState: ReplayState.REPLAY_STATE_None, InitialState: '' };
+                result = (await messages.next()).value!;
+                await lifecycle.disconnected(error => { throw error; });
+                finish();
+            }
+            const reactors = new Reactors({ reactors: [type], eventTypes: [AuthorRegistered] } as unknown as IClientArtifactsProvider,
+                { reactors: { observe: stream } } as unknown as ChronicleConnection, 'store', 'tenant', lifecycle, {} as IEventLog,
+                undefined, { readModels: {} } as IEventStore);
+            try { await reactors.register(); await finished; } finally { reactors.dispose(); }
+        });
+        it('should invoke the instance handler', () => { calls.should.deep.equal([expected]); });
+        it('should complete delivery', () => { result.Content!.Value1!.State.should.equal(ObservationState.Success); });
+    });
+}

package/reactors/for_Reactors/when_observing_explicit_handlers.legacy.spec.ts

@@ -0,0 +1,77 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { EventContext, EventObservationState, EventType, type ReactorMessage } from '@cratis/chronicle.contracts';
+import { beforeEach, chai, describe, it } from 'vitest';
+import type { IClientArtifactsProvider } from '../../artifacts/index.js';
+import type { ChronicleConnection } from '../../connection/index.js';
+import { ConnectionLifecycle } from '../../connection/ConnectionLifecycle.js';
+import type { IEventLog } from '../../eventSequences/IEventLog.js';
+import { eventType } from '../../events/eventTypeDecorator.js';
+import { handles, onceOnly, reactor, Reactors, replay } from '../index.js';
+
+chai.should();
+
+@eventType('legacy-delivered-handler')
+class AuthorRegistered { constructor(readonly name = '') {} }
+
+const calls: string[] = [];
+@reactor('legacy-delivery')
+class AuthorReactor {
+    @handles(AuthorRegistered)
+    @onceOnly()
+    notify(event: AuthorRegistered) { calls.push(`live:${event.name}`); }
+}
+@reactor('legacy-delivery-with-replay')
+class ReplayAuthorReactor extends AuthorReactor {
+    @replay(AuthorRegistered)
+    rebuild(event: AuthorRegistered) { calls.push(`replay:${event.name}`); }
+}
+
+for (const [type, expected] of [
+    [AuthorReactor, ['live:Ada']],
+    [ReplayAuthorReactor, ['live:Ada', 'replay:Ada']]
+] as const) {
+    describe(`when observing live and replay events with explicit legacy handlers on ${type.name}`, () => {
+        let registration: ReactorMessage;
+        let result: ReactorMessage;
+        beforeEach(async () => {
+            calls.length = 0;
+            const lifecycle = new ConnectionLifecycle();
+            let finish!: () => void;
+            const finished = new Promise<void>(resolve => { finish = resolve; });
+            async function* stream(queue: AsyncIterable<ReactorMessage>) {
+                const messages = queue[Symbol.asyncIterator]();
+                registration = (await messages.next()).value!;
+                yield {
+                    Events: [EventObservationState.Initial, EventObservationState.Replay].map((state, index) => ({
+                        Context: EventContext.fromPartial({
+                            EventType: EventType.fromPartial({ Id: 'legacy-delivered-handler', Generation: 1 }),
+                            SequenceNumber: BigInt(index + 1), ObservationState: state
+                        }),
+                        Content: JSON.stringify({ name: 'Ada' })
+                    })),
+                    Partition: 'author', ReplayState: 0, InitialState: ''
+                };
+                result = (await messages.next()).value!;
+                await lifecycle.disconnected(error => { throw error; });
+                finish();
+            }
+            const connection = { reactors: { observe: stream } } as unknown as ChronicleConnection;
+            const artifacts = { reactors: [type], eventTypes: [AuthorRegistered] } as unknown as IClientArtifactsProvider;
+            const reactors = new Reactors(artifacts, connection, 'store', 'tenant', lifecycle, {} as IEventLog);
+            try {
+                await reactors.register();
+                await finished;
+            } finally { reactors.dispose(); }
+        });
+        it('should subscribe to the explicitly named event type', () => {
+            registration.Content!.Value0!.Reactor!.EventTypes.map(entry => entry.EventType!.Id)
+                .should.deep.equal(['legacy-delivered-handler']);
+        });
+        it('should invoke only the appropriate handlers', () => { calls.should.deep.equal(expected); });
+        it('should acknowledge both deliveries', () => {
+            result.Content!.Value1!.LastSuccessfulObservation.should.equal(2n);
+        });
+    });
+}

package/reactors/for_Reactors/when_registering_explicit_handlers.spec.ts

@@ -0,0 +1,53 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { beforeEach, chai, describe, it, vi } from 'vitest';
+import type { IClientArtifactsProvider } from '../../artifacts/index.js';
+import type { ChronicleConnection } from '../../connection/index.js';
+import { ConnectionLifecycle } from '../../connection/ConnectionLifecycle.js';
+import type { IEventLog } from '../../eventSequences/IEventLog.js';
+import { eventType } from '../../events/eventTypeDecorator.js';
+import { handles, reactor, Reactors } from '../index.js';
+
+chai.should();
+
+@eventType('registration-handled-event')
+class AuthorRegistered {}
+@eventType('unselected-handled-event')
+class Unregistered {}
+
+@reactor('valid-handlers')
+class Valid { @handles(AuthorRegistered) notify() {} }
+@reactor('missing-handler-event')
+class Missing { @handles(Unregistered) notify() {} }
+@reactor('duplicate-handlers')
+class Duplicate {
+    @handles(AuthorRegistered) notify() {}
+    authorRegistered() {}
+}
+
+for (const [type, message] of [
+    [Missing, /notify.*Missing.*Unregistered.*no registered event type/],
+    [Duplicate, /multiple handlers.*registration-handled-event.*notify.*authorRegistered/]
+] as const) {
+    describe(`when registering a reactor with invalid explicit handlers on ${type.name}`, () => {
+        const observe = vi.fn();
+        let error: unknown;
+        beforeEach(async () => {
+            observe.mockReset();
+            error = undefined;
+            const artifacts = { reactors: [Valid, type], eventTypes: [AuthorRegistered] } as unknown as IClientArtifactsProvider;
+            const connection = { reactors: { observe } } as unknown as ChronicleConnection;
+            const reactors = new Reactors(artifacts, connection, 'store', 'tenant', new ConnectionLifecycle(), {} as IEventLog);
+            try { await reactors.register(); } catch (caught) { error = caught; }
+            finally { reactors.dispose(); }
+        });
+        it('should reject registration with an actionable error', () => {
+            (error instanceof Error).should.be.true;
+            (error as Error).message.should.match(message);
+        });
+        it('should not start any observation before validating all reactors', () => {
+            observe.mock.calls.should.have.lengthOf(0);
+        });
+    });
+}

package/reactors/index.ts

@@ -3,6 +3,7 @@
 
 export { ReactorId } from './ReactorId.js';
 export { reactor, getReactorMetadata, isReactor } from './reactor.js';
+export { handles } from '../events/handles.js';
 export { onceOnly } from './onceOnly.js';
 export { replay } from './replay.js';
 export type { ReactorMetadata } from './reactor.js';

package/reducers/ReducerEventDispatcher.ts

@@ -2,31 +2,20 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 import type { Constructor } from '@cratis/fundamentals';
-import { getEventTypeMetadata } from '../events/eventTypeDecorator.js';
+import { createHandlerInstanceValidator } from '../observation/createHandlerInstanceValidator.js';
+import { getEventHandlers } from '../observation/getEventHandlers.js';
 import type { EventContext } from '../events/EventContext.js';
 import type { ReducerEventHandler } from './ReducerEventHandler.js';
 
 /** Selects and invokes the same reducer handlers for kernel deliveries and in-process scenarios. */
 export class ReducerEventDispatcher {
     readonly handlers: ReducerEventHandler[];
+    readonly validateInstance: (instance: object) => void;
 
     /** Discovers event methods from the artifact event types. */
     constructor(reducerType: Constructor, eventTypes: readonly Constructor[]) {
-        const proto = reducerType.prototype as Record<string, unknown>;
-        this.handlers = [];
-        for (const eventTypeClass of eventTypes) {
-            const metadata = getEventTypeMetadata(eventTypeClass);
-            if (!metadata) continue;
-            const className = (eventTypeClass as Function).name;
-            const methodName = className.charAt(0).toLowerCase() + className.slice(1);
-            if (typeof proto[methodName] === 'function') {
-                this.handlers.push({
-                    id: metadata.eventType.id.value,
-                    generation: metadata.eventType.generation.value,
-                    methodName
-                });
-            }
-        }
+        this.handlers = getEventHandlers(reducerType, eventTypes);
+        this.validateInstance = createHandlerInstanceValidator(reducerType, this.handlers.map(handler => handler.methodName));
     }
 
     /** Resolves a registered event type, or returns undefined for an unsubscribed event. */

package/reducers/ReducerEventHandler.ts

@@ -1,9 +1,7 @@
 // Copyright (c) Cratis. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-/** Event type and camel-case method selected for a reducer observation. */
-export interface ReducerEventHandler {
-    readonly id: string;
-    readonly generation: number;
-    readonly methodName: string;
-}
+import type { EventHandler } from '../observation/EventHandler.js';
+
+/** Event type and method selected for a reducer observation. */
+export type ReducerEventHandler = EventHandler;

package/reducers/Reducers.ts

@@ -105,6 +105,7 @@ export class Reducers implements IReducers {
 
     private readonly _logger: ReturnType<typeof createLogger>;
     private readonly _lifecycle: ConnectionLifecycle;
+    private readonly _unsubscribeDisconnected: () => void;
     private readonly _reducers = new Map<string, Constructor>();
     private readonly _queues = new Map<string, AsyncQueue<ReducerMessage>>();
     private readonly _observations = new Map<string, AbortController>();
@@ -136,7 +137,7 @@ export class Reducers implements IReducers {
     ) {
         this._logger = createLogger('@cratis/chronicle/reducers', _connection.logger);
         this._lifecycle = lifecycle;
-        lifecycle.onDisconnected(async () => {
+        this._unsubscribeDisconnected = lifecycle.onDisconnected(async () => {
             this._logger.info('Disconnected — stopping all reducer observations');
             this._registered = false;
             this.disconnectAll();
@@ -145,6 +146,7 @@ export class Reducers implements IReducers {
 
     /** Stops observations permanently when the owning client is disposed. */
     dispose(): void {
+        this._unsubscribeDisconnected();
         this._disposed = true;
         this._registered = false;
         this.disconnectAll();
@@ -172,13 +174,16 @@ export class Reducers implements IReducers {
             await this.discover();
         }
 
+        const registrations = [...this._reducers].map(([id, type]) => ({
+            id, type, dispatcher: new ReducerEventDispatcher(type, this._clientArtifacts.eventTypes)
+        }));
         assertUniqueReadModelIds(this._clientArtifacts.readModels);
         await this.registerReadModels();
 
         if (this._disposed) return;
         this._logger.info('Registering reducers', { count: this._reducers.size });
-        for (const [id, reducerType] of this._reducers) {
-            this.startObservation(id, reducerType);
+        for (const { id, type, dispatcher } of registrations) {
+            this.startObservation(id, type, dispatcher);
         }
 
         this._registered = true;
@@ -236,12 +241,12 @@ export class Reducers implements IReducers {
         return JSON.stringify(minimalSchema);
     }
 
-    private startObservation(id: string, reducerType: Constructor): void {
+    private startObservation(id: string, reducerType: Constructor,
+        dispatcher: ReducerEventDispatcher): void {
         runInBackgroundContext(() => {
             if (this._disposed) return;
             const metadata = getReducerMetadata(reducerType)!;
             const eventSequenceId = metadata.eventSequenceId ?? EventSequenceId.eventLog.value;
-            const dispatcher = new ReducerEventDispatcher(reducerType, this._clientArtifacts.eventTypes);
             const readModelName = this.getReducerReadModelIdentifier(reducerType);
 
             this._logger.info('Starting reducer observation', {
@@ -269,7 +274,7 @@ export class Reducers implements IReducers {
             this._logger.error('Reducer observation loop exited with error', { reducerId: id, error });
         }
 
-        this.scheduleReobserve(id, reducerType);
+        this.scheduleReobserve(id, reducerType, dispatcher);
     }
 
     /**
@@ -282,7 +287,7 @@ export class Reducers implements IReducers {
      * retried, and the delay keeps a stream that keeps ending from becoming a hot
      * loop.
      */
-    private scheduleReobserve(id: string, reducerType: Constructor): void {
+    private scheduleReobserve(id: string, reducerType: Constructor, dispatcher: ReducerEventDispatcher): void {
         // A disconnect clears the registration; the reconnect re-registers every
         // reducer from scratch, so retrying here as well would double up.
         if (!this._registered || this._disposed) {
@@ -295,7 +300,7 @@ export class Reducers implements IReducers {
             }
 
             this._logger.info('Re-establishing reducer observation', { reducerId: id });
-            this.startObservation(id, reducerType);
+            this.startObservation(id, reducerType, dispatcher);
         }, Reducers._reobserveDelayMs));
 
         handle.unref?.();
@@ -353,6 +358,7 @@ export class Reducers implements IReducers {
 
         try {
             const reducerInstance = this._artifactActivator ? undefined : new (reducerType as new () => Record<string, Function>)();
+            if (reducerInstance) dispatcher.validateInstance(reducerInstance);
 
             for await (const operation of this._connection.reducers.observe(queue, { signal: controller.signal })) {
                 let lastSuccessfullyObservedEvent = SEQUENCE_NUMBER_UNAVAILABLE;
@@ -376,9 +382,12 @@ export class Reducers implements IReducers {
                             readModels: this._eventStore.readModels, eventSequenceId, partition: operation.Partition,
                             signal: controller.signal, delivery: ArtifactDelivery.ReplayNotification,
                             replayState: operation.ReplayState
-                        }, this._artifactActivator, artifact => runActivated(artifact, () =>
-                            notifyReplayLifecycle(artifact.instance, operation.ReplayState, operation.Partition),
-                            { delivery: ArtifactDelivery.ReplayNotification, replayState: operation.ReplayState }), this._connection.logger);
+                        }, this._artifactActivator, artifact => {
+                            dispatcher.validateInstance(artifact.instance);
+                            return runActivated(artifact, () =>
+                                notifyReplayLifecycle(artifact.instance, operation.ReplayState, operation.Partition),
+                                { delivery: ArtifactDelivery.ReplayNotification, replayState: operation.ReplayState });
+                        }, this._connection.logger);
                     } else if (reducerInstance) {
                         await notifyReplayLifecycle(reducerInstance, operation.ReplayState, operation.Partition);
                     }
@@ -448,7 +457,10 @@ export class Reducers implements IReducers {
                             readModels: this._eventStore.readModels, eventSequenceId, partition: operation.Partition,
                             signal: controller.signal, delivery: ArtifactDelivery.Events,
                             eventContext: toClientEventContext(firstInvocableEvent.Context!)
-                        }, this._artifactActivator, processEvents, this._connection.logger);
+                        }, this._artifactActivator, artifact => {
+                            dispatcher.validateInstance(artifact.instance);
+                            return processEvents(artifact);
+                        }, this._connection.logger);
                     } catch (err) {
                         this._logger.error('Error activating reducer', { reducerId: id, error: err });
                         exceptionMessages.push(String(err));

package/reducers/for_ReducerEventDispatcher/when_invoking_an_explicit_handler.spec.ts

@@ -0,0 +1,51 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { beforeEach, chai, describe, it } from 'vitest';
+import { eventType } from '../../events/eventTypeDecorator.js';
+import { EventType } from '../../events/EventType.js';
+import type { EventContext } from '../../events/EventContext.js';
+import { handles } from '../index.js';
+import { ReducerEventDispatcher } from '../ReducerEventDispatcher.js';
+
+chai.should();
+
+@eventType('explicit-reducer-delivery')
+class AuthorRegistered { constructor(readonly name: string) {} }
+
+class AuthorReducer {
+    @handles(AuthorRegistered)
+    update(event: AuthorRegistered, state: { names: string[] } | undefined, context: EventContext) {
+        return { names: [...(state?.names ?? []), event.name], id: context.eventSourceId };
+    }
+}
+
+class FieldReducer extends AuthorReducer {
+    override update = () => ({ names: [], id: 'hidden' });
+}
+
+describe('when an instance field hides an inherited reducer handler', () => {
+    it('should reject the field against the preflight method', () => {
+        const dispatcher = new ReducerEventDispatcher(FieldReducer, [AuthorRegistered]);
+        (() => dispatcher.validateInstance(new FieldReducer())).should.throw(
+            "Override 'update' on 'FieldReducer' hides @handles(AuthorRegistered) declared on 'AuthorReducer'; use a method with @handles instead of an instance field.");
+    });
+});
+
+describe('when invoking an explicit reducer handler', () => {
+    let result: unknown;
+    beforeEach(async () => {
+        const dispatcher = new ReducerEventDispatcher(AuthorReducer, [AuthorRegistered]);
+        const instance = new AuthorReducer() as unknown as Record<string, Function>;
+        const context: EventContext = {
+            sequenceNumber: 1n, eventSourceId: 'author', eventType: EventType.parse('explicit-reducer-delivery'),
+            occurred: new Date(), correlationId: '', causation: [], tags: []
+        };
+        const handler = dispatcher.handlerFor('explicit-reducer-delivery')!;
+        const initial = await dispatcher.invoke(instance, handler, new AuthorRegistered('Ada'), undefined, context);
+        result = await dispatcher.invoke(instance, handler, new AuthorRegistered('Grace'), initial, context);
+    });
+    it('should pass the event state and context to the named method', () => {
+        (result as object).should.deep.equal({ names: ['Ada', 'Grace'], id: 'author' });
+    });
+});