@cratis/arc 20.40.1 → 20.41.0

package/index.ts

@@ -1,6 +1,7 @@
 // Copyright (c) Cratis. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
+import '@cratis/fundamentals/reflection';
 import * as commands from './commands';
 import * as identity from './identity';
 import * as messaging from './messaging';

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@cratis/arc",
-    "version": "20.40.1",
+    "version": "20.41.0",
     "description": "",
     "author": "Cratis",
     "license": "MIT",
@@ -69,7 +69,7 @@
         "up": "yarn g:up"
     },
     "dependencies": {
-        "@cratis/fundamentals": "^7.15.1",
+        "@cratis/fundamentals": "^7.16.0",
         "rxjs": "^7.8.2"
     }
 }

package/queries/QueryResult.ts

@@ -129,14 +129,17 @@ export class QueryResult<TDataType = object> implements IQueryResult<TDataType>
 
         if (result.data) {
             let data: object = result.data;
+            const isPrimitive = instanceType === String || instanceType === Number || instanceType === Boolean;
             if (enumerable) {
                 if (Array.isArray(result.data)) {
-                    data = JsonSerializer.deserializeArrayFromInstance(instanceType, data);
+                    data = isPrimitive
+                        ? Array.from(result.data)
+                        : JsonSerializer.deserializeArrayFromInstance(instanceType, data);
                 } else {
                     data = [];
                 }
             } else {
-                data = JsonSerializer.deserializeFromInstance(instanceType, data);
+                data = isPrimitive ? data : JsonSerializer.deserializeFromInstance(instanceType, data);
             }
 
             this.data = data as TDataType;
@@ -145,10 +148,17 @@ export class QueryResult<TDataType = object> implements IQueryResult<TDataType>
         }
 
         if (enumerable && result.changeSet) {
+            const isPrimitive = instanceType === String || instanceType === Number || instanceType === Boolean;
             this.changeSet = {
-                added: JsonSerializer.deserializeArrayFromInstance(instanceType, result.changeSet.added ?? []),
-                replaced: JsonSerializer.deserializeArrayFromInstance(instanceType, result.changeSet.replaced ?? []),
-                removed: JsonSerializer.deserializeArrayFromInstance(instanceType, result.changeSet.removed ?? []),
+                added: isPrimitive
+                    ? Array.from(result.changeSet.added ?? [])
+                    : JsonSerializer.deserializeArrayFromInstance(instanceType, result.changeSet.added ?? []),
+                replaced: isPrimitive
+                    ? Array.from(result.changeSet.replaced ?? [])
+                    : JsonSerializer.deserializeArrayFromInstance(instanceType, result.changeSet.replaced ?? []),
+                removed: isPrimitive
+                    ? Array.from(result.changeSet.removed ?? [])
+                    : JsonSerializer.deserializeArrayFromInstance(instanceType, result.changeSet.removed ?? []),
             } as ChangeSet<unknown>;
         }
     }

package/queries/ValidateRequestArguments.ts

@@ -17,9 +17,9 @@ export function ValidateRequestArguments(requestName: string, expectedRequestArg
         } else {
             for (const argument of expectedRequestArguments) {
                 if (!actualArguments.hasOwnProperty(argument) ||
-                    actualArguments[argument] == undefined ||
-                    actualArguments[argument] == null ||
-                    actualArguments[argument] == '') {
+                    actualArguments[argument] === undefined ||
+                    actualArguments[argument] === null ||
+                    actualArguments[argument] === '') {
                     missing.push(argument);
                 }
             }

package/queries/for_ValidateRequestArguments/when_validating_arguments/with_empty_string_value.ts

@@ -0,0 +1,14 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { ValidateRequestArguments } from '../../ValidateRequestArguments';
+
+describe('when validating arguments with an empty string value', () => {
+    let result: boolean;
+
+    beforeEach(() => {
+        result = ValidateRequestArguments('TestRequest', ['name'], { name: '' });
+    });
+
+    it('should return false', () => result.should.be.false);
+});

package/queries/for_ValidateRequestArguments/when_validating_arguments/with_missing_property.ts

@@ -0,0 +1,14 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { ValidateRequestArguments } from '../../ValidateRequestArguments';
+
+describe('when validating arguments with a missing required property', () => {
+    let result: boolean;
+
+    beforeEach(() => {
+        result = ValidateRequestArguments('TestRequest', ['name'], { other: 'value' });
+    });
+
+    it('should return false', () => result.should.be.false);
+});

package/queries/for_ValidateRequestArguments/when_validating_arguments/with_no_required_arguments.ts

@@ -0,0 +1,14 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { ValidateRequestArguments } from '../../ValidateRequestArguments';
+
+describe('when validating arguments with no required arguments', () => {
+    let result: boolean;
+
+    beforeEach(() => {
+        result = ValidateRequestArguments('TestRequest', [], {});
+    });
+
+    it('should return true', () => result.should.be.true);
+});

package/queries/for_ValidateRequestArguments/when_validating_arguments/with_null_value.ts

@@ -0,0 +1,14 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { ValidateRequestArguments } from '../../ValidateRequestArguments';
+
+describe('when validating arguments with a null value', () => {
+    let result: boolean;
+
+    beforeEach(() => {
+        result = ValidateRequestArguments('TestRequest', ['name'], { name: null });
+    });
+
+    it('should return false', () => result.should.be.false);
+});

package/queries/for_ValidateRequestArguments/when_validating_arguments/with_numeric_zero_value.ts

@@ -0,0 +1,14 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { ValidateRequestArguments } from '../../ValidateRequestArguments';
+
+describe('when validating arguments with a numeric zero value', () => {
+    let result: boolean;
+
+    beforeEach(() => {
+        result = ValidateRequestArguments('TestRequest', ['offset'], { offset: 0 });
+    });
+
+    it('should return true', () => result.should.be.true);
+});

package/queries/for_ValidateRequestArguments/when_validating_arguments/with_undefined_value.ts

@@ -0,0 +1,14 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { ValidateRequestArguments } from '../../ValidateRequestArguments';
+
+describe('when validating arguments with an undefined value', () => {
+    let result: boolean;
+
+    beforeEach(() => {
+        result = ValidateRequestArguments('TestRequest', ['name'], { name: undefined });
+    });
+
+    it('should return false', () => result.should.be.false);
+});

package/queries/for_ValidateRequestArguments/when_validating_arguments/with_valid_string_value.ts

@@ -0,0 +1,14 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { ValidateRequestArguments } from '../../ValidateRequestArguments';
+
+describe('when validating arguments with a valid string value', () => {
+    let result: boolean;
+
+    beforeEach(() => {
+        result = ValidateRequestArguments('TestRequest', ['name'], { name: 'some-value' });
+    });
+
+    it('should return true', () => result.should.be.true);
+});

package/queries/for_ValidateRequestArguments/when_validating_arguments/without_arguments_object.ts

@@ -0,0 +1,14 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { ValidateRequestArguments } from '../../ValidateRequestArguments';
+
+describe('when validating arguments without an arguments object', () => {
+    let result: boolean;
+
+    beforeEach(() => {
+        result = ValidateRequestArguments('TestRequest', ['name'], undefined);
+    });
+
+    it('should return false', () => result.should.be.false);
+});