@cratis/arc 20.4.1 → 20.5.0

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@cratis/arc",
-    "version": "20.4.1",
+    "version": "20.5.0",
     "description": "",
     "author": "Cratis",
     "license": "MIT",

package/queries/QueryResult.ts

@@ -130,7 +130,7 @@ export class QueryResult<TDataType = object> implements IQueryResult<TDataType>
 
             this.data = data as TDataType;
         } else {
-            this.data = null as TDataType;
+            this.data = (enumerable ? [] : {}) as TDataType;
         }
     }
 

package/queries/QueryResultWithState.ts

@@ -13,7 +13,7 @@ export class QueryResultWithState<TDataType> implements IQueryResult<TDataType>
 
     static empty<TDataType>(defaultValue: TDataType): QueryResultWithState<TDataType> {
         return new QueryResultWithState(
-            defaultValue,
+            defaultValue ?? ([] as unknown as TDataType),
             PagingInfo.noPaging,
             true,
             true,
@@ -27,7 +27,7 @@ export class QueryResultWithState<TDataType> implements IQueryResult<TDataType>
 
     static initial<TDataType>(defaultValue: TDataType): QueryResultWithState<TDataType> {
         return new QueryResultWithState(
-            defaultValue,
+            defaultValue ?? ([] as unknown as TDataType),
             PagingInfo.noPaging,
             true,
             true,
@@ -81,7 +81,7 @@ export class QueryResultWithState<TDataType> implements IQueryResult<TDataType>
      */
     static fromQueryResult<TDataType>(queryResult: QueryResult<TDataType>, isPerforming: boolean) {
         return new QueryResultWithState<TDataType>(
-            queryResult.data,
+            queryResult.data ?? ([] as unknown as TDataType),
             queryResult.paging,
             queryResult.isSuccess,
             queryResult.isAuthorized,

package/queries/for_QueryResult/when_asking_has_data/and_it_is_null_for_enumerable.ts

@@ -0,0 +1,29 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { QueryResult } from '../../QueryResult';
+
+/* eslint-disable @typescript-eslint/no-explicit-any */
+
+describe('when asking has data and it is null for enumerable query', () => {
+    const queryResult = new QueryResult<any>({
+        isSuccess: true,
+        isAuthorized: true,
+        isValid: true,
+        hasExceptions: false,
+        exceptionMessages: [],
+        exceptionStackTrace: '',
+        paging: {
+            totalItems: 0,
+            totalPages: 0,
+            page: 0,
+            size: 0
+        },
+        validationResults: [],
+        data: null
+    }, Object, true);
+
+    it('should consider it to not have data', () => queryResult.hasData.should.be.false);
+    it('should have data that is not null', () => (queryResult.data !== null).should.be.true);
+    it('should have data that is an empty array', () => queryResult.data.should.deep.equal([]));
+});

package/queries/for_QueryResult/when_asking_has_data/and_it_is_null_for_non_enumerable.ts

@@ -0,0 +1,29 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { QueryResult } from '../../QueryResult';
+
+/* eslint-disable @typescript-eslint/no-explicit-any */
+
+describe('when asking has data and it is null for non-enumerable query', () => {
+    const queryResult = new QueryResult<any>({
+        isSuccess: true,
+        isAuthorized: true,
+        isValid: true,
+        hasExceptions: false,
+        exceptionMessages: [],
+        exceptionStackTrace: '',
+        paging: {
+            totalItems: 0,
+            totalPages: 0,
+            page: 0,
+            size: 0
+        },
+        validationResults: [],
+        data: null
+    }, Object, false);
+
+    it('should consider to have data since empty object is truthy', () => queryResult.hasData.should.be.true);
+    it('should have data that is not null', () => (queryResult.data !== null).should.be.true);
+    it('should have data that is an empty object', () => queryResult.data.should.deep.equal({}));
+});

package/queries/for_QueryResultWithState/when_creating_empty/with_null_default_value.ts

@@ -0,0 +1,13 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { QueryResultWithState } from '../../QueryResultWithState';
+
+describe('when creating empty with null default value', () => {
+    const result = QueryResultWithState.empty<string[]>(null as unknown as string[]);
+
+    it('should have data that is not undefined', () => (result.data !== undefined).should.be.true);
+    it('should have data that is not null', () => (result.data !== null).should.be.true);
+    it('should not have data', () => result.hasData.should.be.false);
+    it('should not be performing', () => result.isPerforming.should.be.false);
+});

package/queries/for_QueryResultWithState/when_creating_empty/with_undefined_default_value.ts

@@ -0,0 +1,13 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { QueryResultWithState } from '../../QueryResultWithState';
+
+describe('when creating empty with undefined default value', () => {
+    const result = QueryResultWithState.empty<string[]>(undefined as unknown as string[]);
+
+    it('should have data that is not undefined', () => (result.data !== undefined).should.be.true);
+    it('should have data that is not null', () => (result.data !== null).should.be.true);
+    it('should not have data', () => result.hasData.should.be.false);
+    it('should not be performing', () => result.isPerforming.should.be.false);
+});

package/queries/for_QueryResultWithState/when_creating_from_query_result/with_null_data.ts

@@ -0,0 +1,30 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { QueryResult } from '../../QueryResult';
+import { QueryResultWithState } from '../../QueryResultWithState';
+
+describe('when creating from query result with null data', () => {
+    const queryResult = new QueryResult<object>({
+        data: null as unknown as object,
+        isSuccess: true,
+        isAuthorized: true,
+        isValid: true,
+        hasExceptions: false,
+        validationResults: [],
+        exceptionMessages: [],
+        exceptionStackTrace: '',
+        paging: {
+            totalItems: 0,
+            totalPages: 0,
+            page: 0,
+            size: 0
+        }
+    }, Object, true);
+
+    const result = QueryResultWithState.fromQueryResult(queryResult, false);
+
+    it('should have data that is not undefined', () => (result.data !== undefined).should.be.true);
+    it('should have data that is not null', () => (result.data !== null).should.be.true);
+    it('should not have data', () => result.hasData.should.be.false);
+});

package/queries/for_QueryResultWithState/when_creating_from_query_result/with_undefined_data.ts

@@ -0,0 +1,30 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { QueryResult } from '../../QueryResult';
+import { QueryResultWithState } from '../../QueryResultWithState';
+
+describe('when creating from query result with undefined data', () => {
+    const queryResult = new QueryResult<object>({
+        data: undefined as unknown as object,
+        isSuccess: true,
+        isAuthorized: true,
+        isValid: true,
+        hasExceptions: false,
+        validationResults: [],
+        exceptionMessages: [],
+        exceptionStackTrace: '',
+        paging: {
+            totalItems: 0,
+            totalPages: 0,
+            page: 0,
+            size: 0
+        }
+    }, Object, true);
+
+    const result = QueryResultWithState.fromQueryResult(queryResult, false);
+
+    it('should have data that is not undefined', () => (result.data !== undefined).should.be.true);
+    it('should have data that is not null', () => (result.data !== null).should.be.true);
+    it('should not have data', () => result.hasData.should.be.false);
+});

package/queries/for_QueryResultWithState/when_creating_initial/with_null_default_value.ts

@@ -0,0 +1,13 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { QueryResultWithState } from '../../QueryResultWithState';
+
+describe('when creating initial with null default value', () => {
+    const result = QueryResultWithState.initial<string[]>(null as unknown as string[]);
+
+    it('should have data that is not undefined', () => (result.data !== undefined).should.be.true);
+    it('should have data that is not null', () => (result.data !== null).should.be.true);
+    it('should not have data', () => result.hasData.should.be.false);
+    it('should be performing', () => result.isPerforming.should.be.true);
+});

package/queries/for_QueryResultWithState/when_creating_initial/with_undefined_default_value.ts

@@ -0,0 +1,13 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { QueryResultWithState } from '../../QueryResultWithState';
+
+describe('when creating initial with undefined default value', () => {
+    const result = QueryResultWithState.initial<string[]>(undefined as unknown as string[]);
+
+    it('should have data that is not undefined', () => (result.data !== undefined).should.be.true);
+    it('should have data that is not null', () => (result.data !== null).should.be.true);
+    it('should not have data', () => result.hasData.should.be.false);
+    it('should be performing', () => result.isPerforming.should.be.true);
+});

package/queries/for_QueryResultWithState/when_creating_initial/with_valid_default_value.ts

@@ -0,0 +1,13 @@
+// Copyright (c) Cratis. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+import { QueryResultWithState } from '../../QueryResultWithState';
+
+describe('when creating initial with valid default value', () => {
+    const defaultValue = [{ id: '1', name: 'test' }];
+    const result = QueryResultWithState.initial(defaultValue);
+
+    it('should use the provided default value', () => result.data.should.equal(defaultValue));
+    it('should have data', () => result.hasData.should.be.true);
+    it('should be performing', () => result.isPerforming.should.be.true);
+});