@cr1ms0n/pi-subagent 0.8.3 → 0.8.5

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 0.8.5 — 2026-09-10
+
+### Read-only FFF search tools
+
+- Classify `fffind`, `ffgrep`, and `fff-multi-grep` as read-only tools so `explore` and `review` profiles can use the `@ff-labs/pi-fff` search tools without granting write access.
+
+## 0.8.4 — 2026-09-10
+
+### Pi-owned thinking levels
+
+- Treat route and task `thinking` values as opaque Pi strings instead of a
+  hard-coded local enum, preserving model-specific values such as `max` and
+  passing them to Pi unchanged. Pi remains responsible for model capability
+  validation and mapping.
+
 ## 0.8.3 — 2026-09-10
 
 ### Model-policy thinking defaults

package/README.md

@@ -254,12 +254,14 @@ fallback lists are ignored for model selection. The minimal template is:
 }
 ```
 
-`thinking` is optional and accepts `off`, `minimal`, `low`, `medium`, `high`,
-or `xhigh`. It is a route default, not a strict policy value. Resolution order
-is: explicit task `thinking` > agent frontmatter `thinking` > profile
-`taskDefaults.<profile>.thinking` > the selected `modelPolicy` route's
-`thinking` > the parent session's thinking level. Omitting it preserves the
-existing behavior.
+`thinking` is optional and is an opaque Pi thinking-level string. Common values
+include `off`, `minimal`, `low`, `medium`, `high`, `xhigh`, and `max`, but the
+package does not remap or restrict model-specific values. Pi receives the value
+unchanged and decides whether the active model supports it. It is a route default,
+not a strict policy value. Resolution order is: explicit task `thinking` > agent
+frontmatter `thinking` > profile `taskDefaults.<profile>.thinking` > the selected
+`modelPolicy` route's `thinking` > the parent session's thinking level. Omitting it
+preserves the existing behavior.
 
 Every new `task`/`tasks[]` item must pass the exact mapped `model`. Omit
 `fallback_models` to use the configured list; when supplied it must match the

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cr1ms0n/pi-subagent",
-  "version": "0.8.3",
+  "version": "0.8.5",
   "description": "Community fork of Luke Parke's pi-subagent with explicit model policy and model visibility for Pi",
   "type": "module",
   "license": "MIT",

package/skills/subagent/SKILL.md

@@ -97,9 +97,11 @@ Every new task must pass a `model` that exactly matches the current
 `taskDefaults.model`, and parent-session model inheritance are ignored. An
 agent route replaces the default route, and configured fallback order is
 immutable. Omit `fallback_models` to use the route; if supplied, it must match
-exactly. An optional route `thinking` value (`off`, `minimal`, `low`, `medium`,
-`high`, or `xhigh`) is a default; explicit task, agent, and profile
-`taskDefaults.thinking` values override it. Management actions do not require
-model. The extension re-reads this policy on each dispatch and injects it into
+exactly. An optional route `thinking` value is an opaque Pi thinking-level
+string; common values include `off`, `minimal`, `low`, `medium`, `high`, `xhigh`,
+and `max`, but model-specific values are passed through unchanged. It is a
+default; explicit task, agent, and profile `taskDefaults.thinking` values
+override it. Management actions do not require model. The extension re-reads
+this policy on each dispatch and injects it into
 the parent prompt. If the policy is missing or invalid, management remains
 available but new spawns and synthesis are rejected.

package/src/model-policy.ts

@@ -1,7 +1,7 @@
 import * as fs from "node:fs/promises";
 import * as os from "node:os";
 import * as path from "node:path";
-import { THINKING_LEVELS, isThinkingLevel, type ThinkingLevel } from "./thinking.js";
+import { isThinkingLevel, type ThinkingLevel } from "./thinking.js";
 
 export const MODEL_POLICY_CONFIG_FILE = path.join(os.homedir(), ".pi", "subagent.json");
 
@@ -55,7 +55,7 @@ function route(value: unknown, pathName: string, source: string): ModelRoute {
   if (fallbackModels.includes(model)) invalid(source, `${pathName}.fallbackModels must not repeat the primary model`);
   const thinking = record.thinking;
   if (thinking !== undefined && !isThinkingLevel(thinking)) {
-    invalid(source, `${pathName}.thinking must be one of: ${THINKING_LEVELS.join(", ")}`);
+    invalid(source, `${pathName}.thinking must be a non-empty Pi thinking level string without whitespace or control characters`);
   }
   return Object.freeze({
     model,

package/src/persistence.ts

@@ -1,7 +1,8 @@
 import { Buffer } from "node:buffer";
 import type { SubagentConfig } from "./config.js";
-import type { ChildProcessIdentity, RunMode, RunSnapshot, RunState, TaskProfile, TimeoutPhase, UsageStats } from "./types.js";
+import type { ChildProcessIdentity, RunMode, RunSnapshot, RunState, TaskProfile, TaskSpec, TimeoutPhase, UsageStats } from "./types.js";
 import { emptyUsage } from "./types.js";
+import { isThinkingLevel } from "./thinking.js";
 
 export const RUN_ENTRY_TYPE = "subagent-run-v1";
 
@@ -23,7 +24,7 @@ export interface PersistedResult {
   errorMessage?: string;
   usage: UsageStats;
   model?: string;
-  thinking?: "off" | "minimal" | "low" | "medium" | "high" | "xhigh";
+  thinking?: TaskSpec["thinking"];
   profile?: TaskProfile;
   canWrite?: boolean;
   outputFile?: string;
@@ -141,7 +142,7 @@ function normalizeResult(value: unknown): PersistedResult | undefined {
     errorMessage: typeof r.errorMessage === "string" ? utf8Prefix(r.errorMessage, 2_000) : undefined,
     usage: normalizeUsage(r.usage),
     model: typeof r.model === "string" ? r.model : undefined,
-    thinking: ["off", "minimal", "low", "medium", "high", "xhigh"].includes(String(r.thinking)) ? r.thinking : undefined,
+    thinking: isThinkingLevel(r.thinking) ? r.thinking : undefined,
     profile: ["explore", "review", "general"].includes(String(r.profile)) ? r.profile : undefined,
     canWrite: typeof r.canWrite === "boolean" ? r.canWrite : undefined,
     outputFile: typeof r.outputFile === "string" ? r.outputFile : undefined,

package/src/policy.ts

@@ -8,6 +8,7 @@ import type { ParallelTaskInput, SubagentParams } from "./schema.js";
 import { BACKEND_NAMES, checkCapabilities, type BackendName } from "./backend.js";
 import { resolveBackend } from "./backends/index.js";
 import { validateModelRequest, type ModelPolicySnapshot } from "./model-policy.js";
+import { isThinkingLevel } from "./thinking.js";
 
 export const DEPTH_ENV_VAR = "PI_SUBAGENT_DEPTH";
 export const SPAWNS_ENV_VAR = "PI_SUBAGENT_SPAWNS";
@@ -16,6 +17,9 @@ export const READ_ONLY_TOOLS = new Set([
   "grep",
   "find",
   "ls",
+  "fffind",
+  "ffgrep",
+  "fff-multi-grep",
   "firecrawl_scrape",
   "firecrawl_search",
   "firecrawl_map",
@@ -200,6 +204,9 @@ function normalizeTask(
   // validated above and is exclusively owned by modelPolicy.
   const profileDefaults: TaskDefaults = defaults.taskDefaults?.[profile] ?? {};
   const effectiveThinking = item.thinking ?? agent?.thinking ?? profileDefaults.thinking ?? modelRoute.thinking ?? parent.thinking;
+  if (effectiveThinking !== undefined && !isThinkingLevel(effectiveThinking)) {
+    return { error: `Task ${index + 1}: thinking must be a non-empty Pi thinking level string without whitespace or control characters` };
+  }
   const label = item.description?.trim()
     ? item.description.trim().slice(0, 60)
     : agent

package/src/schema.ts

@@ -1,13 +1,10 @@
 import { Type, type Static } from "typebox";
 
-const ThinkingLevel = Type.Union([
-  Type.Literal("off"),
-  Type.Literal("minimal"),
-  Type.Literal("low"),
-  Type.Literal("medium"),
-  Type.Literal("high"),
-  Type.Literal("xhigh"),
-]);
+const ThinkingLevel = Type.String({
+  minLength: 1,
+  maxLength: 64,
+  description: "Opaque Pi thinking level passed through unchanged. Pi/model-specific values such as max are allowed; the active Pi process decides support.",
+});
 
 const OutputMode = Type.Union([Type.Literal("inline"), Type.Literal("file-only")]);
 const Profile = Type.Union([Type.Literal("explore"), Type.Literal("review"), Type.Literal("general")]);
@@ -31,7 +28,7 @@ export const TaskFields = {
   description: Type.Optional(Type.String({ description: "Short human label (3-5 words) shown in UIs and result indexes." })),
   system_prompt: Type.Optional(Type.String({ description: "Extra system prompt appended to the child's prompt (does not replace it)." })),
   model: Type.Optional(Type.String({ description: "**REQUIRED for every spawn call (task/tasks).** Exact model id from modelPolicy, in provider/model-id form. Calls without an explicit model are rejected; agent-file model, taskDefaults, and parent-session inheritance are ignored. Management actions (status/wait/cancel/steer/diff/apply/discard) do not need it." })),
-  thinking: Type.Optional({ ...ThinkingLevel, description: "Reasoning effort for the child. Defaults to agent thinking, profile taskDefaults.thinking, modelPolicy route thinking, then the parent's level." }),
+  thinking: Type.Optional({ ...ThinkingLevel, description: "Opaque Pi thinking level for the child. Values such as max are passed through unchanged; Pi/model support decides validity. Defaults to agent thinking, profile taskDefaults.thinking, modelPolicy route thinking, then the parent's level." }),
   tools: Type.Optional(Type.Array(Type.String(), { description: "Optional tool allowlist. explore/review profiles reject write-capable tools." })),
   profile: Type.Optional({ ...Profile, description: "Capability profile: explore/review are strictly read-only; general inherits the parent's active tools and may write." }),
   cwd: Type.Optional(Type.String({ description: "Working directory for the child process." })),

package/src/thinking.ts

@@ -1,6 +1,18 @@
-export const THINKING_LEVELS = ["off", "minimal", "low", "medium", "high", "xhigh"] as const;
-export type ThinkingLevel = (typeof THINKING_LEVELS)[number];
+/**
+ * Opaque thinking-level value understood by the active Pi/model.
+ *
+ * Pi owns the vocabulary and model-specific mappings (for example `max` may
+ * be supported by one model while another exposes a different set). The
+ * subagent package must therefore validate only the transport-safe shape and
+ * pass the value through unchanged.
+ */
+export type ThinkingLevel = string;
+
+const MAX_THINKING_LEVEL_LENGTH = 64;
 
 export function isThinkingLevel(value: unknown): value is ThinkingLevel {
-  return typeof value === "string" && (THINKING_LEVELS as readonly string[]).includes(value);
+  return typeof value === "string"
+    && value.length > 0
+    && value.length <= MAX_THINKING_LEVEL_LENGTH
+    && !/[\s\u0000-\u001f\u007f]/u.test(value);
 }