@cplieger/web-terminal-ui 8.3.1 → 8.3.2

package/README.md

@@ -97,7 +97,7 @@ The IME module follows the design of [xterm.js](https://github.com/xtermjs/xterm
 
 ## Contributing
 
-Issues and pull requests are welcome. See [CONTRIBUTING.md](CONTRIBUTING.md) for the conventions and how to run the checks locally.
+Issues and pull requests are welcome. See [CONTRIBUTING.md](CONTRIBUTING.md).
 
 ## Disclaimer
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cplieger/web-terminal-ui",
-  "version": "8.3.1",
+  "version": "8.3.2",
   "type": "module",
   "description": "Reference touch-first browser UI for @cplieger/web-terminal-engine: a composable kernel + feature modules (tabs, activity monitor, mobile toolbar, context menu, IME, predictive echo, viewport handling) and CSS. One createTerminal() call.",
   "license": "MPL-2.0",
@@ -50,18 +50,18 @@
     "@stryker-mutator/core": "10.0.0",
     "@stryker-mutator/typescript-checker": "10.0.0",
     "@stryker-mutator/vitest-runner": "10.0.0",
-    "@types/node": "26.6.3",
+    "@types/node": "26.6.4",
     "@typescript/native": "npm:typescript@7.0.2",
     "@vitest/browser": "5.0.3",
     "@vitest/browser-playwright": "5.0.3",
     "@vitest/coverage-v8": "5.0.3",
-    "eslint": "10.11.0",
+    "eslint": "10.12.0",
     "fast-check": "4.10.2",
     "html-validate": "11.16.1",
     "knip": "6.39.0",
     "playwright": "1.63.0",
     "prettier": "3.9.9",
-    "stylelint": "17.15.0",
+    "stylelint": "17.16.0",
     "stylelint-config-standard": "40.0.0",
     "typescript": "npm:@typescript/typescript6@6.0.2",
     "typescript-eslint": "8.71.0",

package/src/composition.ts

@@ -190,7 +190,7 @@ export function createComposition(opts: CompositionOptions): Composition {
 
   return {
     isComposing,
-    isCompositionOpen: () => composing || pendingSend !== null,
+    isCompositionOpen: () => composing,
     cancelComposition,
     positionCompositionView,
     teardown,

package/src/features/context-menu.ts

@@ -226,9 +226,6 @@ export function contextMenu(opts: ContextMenuOptions = {}): TerminalFeature {
         pressSelection = selectionTextWithin(surface);
       };
       const onTouchMove = (e: TouchEvent): void => {
-        if (!pressLive) {
-          return;
-        }
         const t = e.touches.length === 1 ? e.touches[0] : undefined;
         if (!t) {
           pressLive = false;
@@ -258,11 +255,9 @@ export function contextMenu(opts: ContextMenuOptions = {}): TerminalFeature {
           return; // this press selected text; the OS callout owns it
         }
         show(pressX, pressY);
-        if (menu.classList.contains("visible")) {
-          // Armed at the release edge, so the trailing click this same gesture
-          // emits is always inside the window.
-          swallow.arm();
-        }
+        // Armed at the release edge, so the trailing click this same gesture
+        // emits is always inside the window.
+        swallow.arm();
       };
       const onTouchCancel = (): void => {
         pressLive = false;

package/src/features/predictive-echo.ts

@@ -49,7 +49,6 @@ export function predictiveEcho(): TerminalFeature {
           predict.reset();
         },
         teardown() {
-          predict.reset();
           ctx.render.setPredictedCursor(0, 0, false);
         },
       };

package/src/features/tabs/index.ts

@@ -545,11 +545,11 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
       }
       // forgetCueSeen drops an acknowledgement, so the session's NEXT input/done
       // is a fresh cue: called when its status moves off the acknowledged value
-      // (a new working phase, an exit) and when the session goes away.
+      // (a new working phase, an exit) and when the session goes away. Every
+      // caller ends in syncChrome, which repaints the out-of-page surfaces.
       function forgetCueSeen(id: string): void {
         if (cueSeen.delete(id)) {
           writeCueSeen(win, cueSeen);
-          paintAttention();
         }
       }
       // The out-of-page surfaces render the SAME unseen-cue set the switch dot
@@ -600,9 +600,6 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
           swSwitchDot.dataset["status"] = switchNotify;
           swSwitchDot.title = statusPhrase(switchNotify);
         }
-        // The out-of-page surfaces answer to the same set, so they repaint
-        // wherever this does: a raise, and every clear through clearSwitchNotify.
-        paintAttention();
       }
       function clearSwitchNotify(): void {
         switchNotify = "";
@@ -931,7 +928,7 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
       }
       function keyboardParkedOnChrome(): boolean {
         const active = doc.activeElement;
-        return active !== null && (bar.contains(active) || switcher.contains(active));
+        return bar.contains(active) || switcher.contains(active);
       }
       function keyboardInPaneInput(): boolean {
         const active = doc.activeElement;
@@ -1254,8 +1251,6 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
         for (const tab of tabList) {
           scroller.appendChild(tab.el);
         }
-        paintActive();
-        syncMobile();
       }
 
       // closeKeyGrid closes the mobile key grid (if a keyboardToggle is wired and
@@ -1298,9 +1293,7 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
           }
           collapseClearTimer = win.setTimeout(() => {
             collapseClearTimer = null;
-            if (!expanded) {
-              clearRows();
-            }
+            clearRows();
           }, 260);
         }
       }
@@ -1414,10 +1407,7 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
             activityCount: tab.activityCount,
           }),
         );
-        el.addEventListener("click", (e) => {
-          if ((e.target as HTMLElement).closest(".wt-tab-close")) {
-            return; // handled by the close button
-          }
+        el.addEventListener("click", () => {
           if (editingId === tab.id) {
             return; // the rename field owns this chip
           }
@@ -1983,10 +1973,6 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
       // would ignore an inline transform and refuse to move. `translate` composes
       // with it instead, so the two can own one chip at the same time.
       function applyShift(px: ReadonlyMap<HTMLElement, number>, trans: string): void {
-        if (shiftTimer !== null) {
-          win.clearTimeout(shiftTimer);
-          shiftTimer = null;
-        }
         for (const [el, dx] of px) {
           el.style.transition = trans;
           el.style.translate = `${String(Math.round(dx))}px`;
@@ -2105,7 +2091,7 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
         if (before !== null && before.parentNode !== scroller) {
           return;
         }
-        if (before === dragged || before === dragged.nextElementSibling) {
+        if (before === dragged.nextElementSibling) {
           return;
         }
         flipTo(() => {
@@ -2162,16 +2148,12 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
         return [...scroller.querySelectorAll<HTMLElement>(".wt-tab")].indexOf(el) + 1;
       }
       function announceTarget(el: HTMLElement): void {
-        const at = slotPosition(el);
-        if (at > 0) {
-          ctx.announce(`Drop position ${String(at)}`);
-        }
+        ctx.announce(`Drop position ${String(slotPosition(el))}`);
       }
       function announceMoved(el: HTMLElement): void {
         const tab = tabList.find((t) => t.el === el);
-        const at = slotPosition(el);
-        if (tab && at > 0) {
-          ctx.announce(`Moved ${tab.display} to position ${String(at)}`);
+        if (tab) {
+          ctx.announce(`Moved ${tab.display} to position ${String(slotPosition(el))}`);
         }
       }
 
@@ -2222,10 +2204,7 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
         if (removed !== draggingEl) {
           return;
         }
-        removed.classList.remove("wt-tab-dragging");
         draggingEl = null;
-        dropped = false;
-        endReorderPreview();
         endShift();
         clearDragGhost();
       }
@@ -2238,14 +2217,12 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
             order.push(t);
           }
         }
-        if (order.length === tabList.length) {
-          tabList.length = 0;
-          tabList.push(...order);
-          // Before syncChrome: it ends in applyServerOrder, which would undo this
-          // move while the tabs still carry their old positions.
-          publishOrder();
-          syncChrome();
-        }
+        tabList.length = 0;
+        tabList.push(...order);
+        // Before syncChrome: it ends in applyServerOrder, which would undo this
+        // move while the tabs still carry their old positions.
+        publishOrder();
+        syncChrome();
       }
 
       // The write half of tab-order sync, called only from the paths that COMMIT
@@ -2254,9 +2231,6 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
       // the strip straight back. A 409 means this client's list is stale, so the
       // server's word is taken; any other failure leaves the arrangement local.
       function publishOrder(): void {
-        if (tabList.length === 0) {
-          return;
-        }
         tabList.forEach((tab, i) => {
           tab.order = i;
         });
@@ -2486,7 +2460,7 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
         // far left while the create POST is in flight. The replacement lands as any
         // new tab does, and dropping the old tab is then an ordinary non-last
         // close, so this intercept does not re-fire. A user close only.
-        if (remote && tabList.length === 1 && tabList[0]?.id === id) {
+        if (remote && tabList.length === 1) {
           await create();
           // A failed create adds nothing (and toasts): keep the existing tab
           // rather than stranding the user on an empty strip.
@@ -2687,10 +2661,6 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
       // Recorded at entry because the exit paths cannot tell a keyboard-started
       // edit (focus returns to the chip) from a pointer one (to the terminal).
       let editFrom: "keyboard" | "pointer" = "pointer";
-      // Pinned-name requests in flight, COUNTED per id: two renames of one tab can
-      // be out at once, and a bare Set let the first completion clear the marker
-      // while the second's PUT was still open, so that rename failed silently.
-      const namesInFlight = new Map<string, number>();
 
       /** restoreFocusAfterEdit sends focus where the entry path implies. The
        *  terminal branch is gated exactly like switchTo's focus-on-switch: on a
@@ -2745,8 +2715,8 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
         }
         // Optimistic: paint it now, guarded by a monotonic counter AND the tab's
         // birth epoch so a slow response cannot roll back a newer rename, a later
-        // clear, a remote update, or — if this id were ever reused by a fresh
-        // session — a different tab entirely.
+        // clear, or — if this id were ever reused by a fresh session — a
+        // different tab entirely.
         const seq = ++t.nameSeq;
         const born = t.born;
         t.pinnedTitle = name;
@@ -2761,28 +2731,15 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
           ctx.announce(fallback ? "Custom name removed" : `Using automatic name: ${text}`);
         }
         const request = name === "" ? api.clearPinnedTitle(id) : api.setPinnedTitle(id, name);
-        // Counted only once the request exists: an api implementation that throws
-        // instead of rejecting would otherwise leave a count behind that no
-        // .finally ever releases, and the id would read as in flight forever.
-        namesInFlight.set(id, (namesInFlight.get(id) ?? 0) + 1);
-        void request
-          .catch(() => {
-            const cur = tabList.find((x) => x.id === id);
-            if (cur?.born !== born || cur.nameSeq !== seq) {
-              return; // gone, reused, or superseded: the newer state stands
-            }
-            cur.pinnedTitle = before;
-            syncChrome();
-            ctx.toast("Could not save the terminal name");
-          })
-          .finally(() => {
-            const left = (namesInFlight.get(id) ?? 0) - 1;
-            if (left > 0) {
-              namesInFlight.set(id, left);
-            } else {
-              namesInFlight.delete(id);
-            }
-          });
+        void request.catch(() => {
+          const cur = tabList.find((x) => x.id === id);
+          if (cur?.born !== born || cur.nameSeq !== seq) {
+            return; // gone, reused, or superseded: the newer state stands
+          }
+          cur.pinnedTitle = before;
+          syncChrome();
+          ctx.toast("Could not save the terminal name");
+        });
         return true;
       }
 
@@ -2973,7 +2930,7 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
         hideTabMenu();
         const idx = tabList.findIndex((t) => t.id === id);
         const target = tabList[idx];
-        if (idx < 0 || !target) {
+        if (!target) {
           return;
         }
         const n = tabList.length;
@@ -3134,17 +3091,11 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
           t.title = rec.title;
         }
         // "" is meaningful here: it is how a clear made in ANOTHER browser reaches
-        // this one. The bump is gated on a DIFFERING value because the wire echoes
-        // pinnedTitle on every event, and an unconditional bump would mark an
-        // in-flight local rename as superseded by its own echo.
-        if (rec.pinnedTitle !== undefined && rec.pinnedTitle !== (t.pinnedTitle ?? "")) {
+        // this one. It never bumps nameSeq: SSE delivery and REST mutation are not
+        // one total order, so a record arriving during a pending request may
+        // predate our own PUT, and a bump would suppress that request's rollback.
+        if (rec.pinnedTitle !== undefined) {
           t.pinnedTitle = rec.pinnedTitle;
-          // SSE delivery and REST mutation are not one total order: during a
-          // pending request the record may predate our own PUT, and bumping would
-          // suppress that request's rollback and its failure toast.
-          if (!namesInFlight.has(rec.id)) {
-            t.nameSeq++;
-          }
         }
       }
 
@@ -3350,20 +3301,13 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
         if (!draggingEl) {
           return;
         }
-        e.preventDefault();
         if (e.dataTransfer) {
           e.dataTransfer.dropEffect = "move";
         }
         trackRest(e.clientX);
       });
-      // The preventDefault is load-bearing: WebKit's default for an uncancelled
-      // drop is to LOAD the payload as a URL, so dropping a tab on iPadOS
-      // navigated the page to /<session-id>.
+      // onDocTabDrop cancels both events here too, as they bubble.
       bar.addEventListener("drop", (e) => {
-        if (!draggingEl) {
-          return;
-        }
-        e.preventDefault();
         dropOnStrip(e.clientX);
       });
       function dropOnStrip(clientX: number): void {
@@ -3388,7 +3332,7 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
           return;
         }
         const next = e.relatedTarget;
-        if (next === null || !bar.contains(next as Node)) {
+        if (!bar.contains(next as Node | null)) {
           endRestNet();
         }
       });
@@ -3412,10 +3356,11 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
         ctx.shell.root.classList.toggle("wt-drop-left", half === "left");
         ctx.shell.root.classList.toggle("wt-drop-right", half === "right");
       }
-      // A tab released anywhere OTHER than the strip must be inert, not a
-      // navigation, so the whole document is a drop target for the life of a tab
-      // drag; over a half of the pane row it is a snap. Gated on draggingEl so a
-      // file dropped on the page is the browser's.
+      // A tab released anywhere must be inert, not a navigation: WebKit's default
+      // for an uncancelled drop is to LOAD the payload as a URL, which sent iPadOS
+      // to /<session-id>. So the whole document, the strip included, is a drop
+      // target for the life of a tab drag; over a half of the pane row it is a
+      // snap. Gated on draggingEl so a file dropped on the page is the browser's.
       const onDocTabDrop = (e: DragEvent): void => {
         if (!draggingEl) {
           return;
@@ -3499,7 +3444,7 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
         const rule = pointerDragActivation(e.pointerType);
         const el =
           e.target instanceof win.Element ? e.target.closest<HTMLElement>(".wt-tab") : null;
-        if (rule === null || !e.isPrimary || press !== null || el?.parentNode !== scroller) {
+        if (rule === null || !e.isPrimary || el?.parentNode !== scroller) {
           return;
         }
         const tab = tabList.find((t) => t.el === el);
@@ -3529,7 +3474,9 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
         win.addEventListener("pointermove", onPressMove, opts);
         win.addEventListener("pointerup", onPressUp, opts);
         win.addEventListener("pointercancel", onPressCancel, opts);
-        win.addEventListener("pointerdown", onPressSecond, opts);
+        // Registered after this press's own pointerdown has passed the window, so
+        // any pointerdown it sees is another pointer.
+        win.addEventListener("pointerdown", cancelPointerPress, opts);
         win.addEventListener("keydown", onPressKey, opts);
         win.addEventListener("blur", cancelPointerPress, { signal: off.signal });
         doc.addEventListener("visibilitychange", onPressVisibility, { signal: off.signal });
@@ -3608,11 +3555,6 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
           cancelPointerPress();
         }
       }
-      function onPressSecond(e: PointerEvent): void {
-        if (press !== null && press.id !== e.pointerId) {
-          cancelPointerPress();
-        }
-      }
       // lostpointercapture bubbles, and the chip's implicit touch capture ending
       // when the bar takes it over is not a loss.
       function onPressLostCapture(e: PointerEvent): void {
@@ -3657,7 +3599,7 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
           return;
         }
         const target = doc.elementFromPoint(x, y);
-        if (target !== null && bar.contains(target)) {
+        if (bar.contains(target)) {
           paintDropHalf(null);
           if (release) {
             dropOnStrip(x);

package/src/features/tabs/model.ts

@@ -293,7 +293,7 @@ export const MAX_PERSISTED_CUE_SEEN = 200;
  *  lost acknowledgement only re-lights a dot the user can dismiss again. */
 export function parseCueSeen(raw: string | null): Map<string, CueStatus> {
   const out = new Map<string, CueStatus>();
-  if (raw === null || raw === "") {
+  if (raw === null) {
     return out;
   }
   let data: unknown;
@@ -608,9 +608,6 @@ function parseRetryAfter(header: string | null, now: number): number | undefined
     return undefined;
   }
   const raw = header.trim();
-  if (raw === "") {
-    return undefined;
-  }
   if (/^\d+$/.test(raw)) {
     return Math.min(Number(raw) * 1000, RETRY_AFTER_MAX_MS);
   }
@@ -627,9 +624,6 @@ function parseRetryAfter(header: string | null, now: number): number | undefined
 async function readServerMessage(r: Response): Promise<string | undefined> {
   try {
     const body: unknown = await r.json();
-    if (typeof body !== "object" || body === null) {
-      return undefined;
-    }
     const fields = body as { error?: unknown; message?: unknown };
     for (const candidate of [fields.error, fields.message]) {
       if (typeof candidate === "string" && candidate.trim() !== "") {

package/src/kernel/a11y.ts

@@ -29,7 +29,15 @@ export interface Announcer {
 /** Delay before a cleared live region is re-set with the new message (ms).
  *  Long enough for assistive tech to register the clear and the set as two
  *  distinct mutations (a sub-frame gap is not). */
-const REANNOUNCE_DELAY_MS = 100;
+let REANNOUNCE_DELAY_MS = 100;
+
+/** @internal Test seam: re-set every later announcement after `ms`; returns the
+ *  previous value so the caller can restore it. */
+export function setReannounceDelayMs(ms: number): number {
+  const previous = REANNOUNCE_DELAY_MS;
+  REANNOUNCE_DELAY_MS = ms;
+  return previous;
+}
 
 /** Build the single pair of live regions inside root. */
 export function createAnnouncer(root: HTMLElement): Announcer {
@@ -58,10 +66,7 @@ export function createAnnouncer(root: HTMLElement): Announcer {
     // distinct mutations — the same rationale ui-primitives' announce()
     // documents for its shared region.
     el.textContent = "";
-    const pending = timers.get(el);
-    if (pending !== undefined) {
-      win.clearTimeout(pending);
-    }
+    win.clearTimeout(timers.get(el));
     timers.set(
       el,
       win.setTimeout(() => {

package/src/kernel/conn-state.ts

@@ -62,12 +62,10 @@ export function createConnState(opts: {
     // Suppress transient states until the initial load is over (the loading
     // overlay owns the screen). Terminal states ("ended" and "incompatible")
     // must pass through because no later frame or reconnect will explain the
-    // failure; "offline" also passes once the initial-failure limit is reached.
+    // failure; offline, which before load is reached only at the initial-failure
+    // limit (closed() returns before it until then), passes for the same reason.
     // connectionBanner renders "open" as hidden.
-    const passesLoadingGate =
-      state === "ended" ||
-      state === "incompatible" ||
-      (state === "offline" && consecutiveFailures >= INITIAL_FAILURE_LIMIT);
+    const passesLoadingGate = state === "ended" || state === "incompatible" || state === "offline";
     if (!loaded && !passesLoadingGate) {
       opts.onState("open"); // nothing to show yet
       return;
@@ -140,10 +138,6 @@ export function createConnState(opts: {
     },
     idle(): void {
       consecutiveFailures = 0;
-      if (restartedTimer !== null) {
-        timers.clearTimeout(restartedTimer);
-        restartedTimer = null;
-      }
       setState("idle", 0);
     },
     setLoaded(): void {

package/src/kernel/loading-status.ts

@@ -165,10 +165,7 @@ export function attachLoadingStatus(
       }
       current = text;
       pinned = true;
-      if (rotation !== undefined) {
-        win.clearInterval(rotation);
-        rotation = undefined;
-      }
+      win.clearInterval(rotation);
       show(text);
       announce(text);
     },
@@ -179,16 +176,11 @@ export function attachLoadingStatus(
       // cancellable callback, can run, and it is the one reader of `stopped`.
       // show() and announce() do not re-test it; a timer armed outside later()
       // is what the "stop() leaves no timer armed" test catches.
-      if (stopped) {
-        return;
-      }
       stopped = true;
       for (const t of timers) {
         win.clearTimeout(t);
       }
-      if (rotation !== undefined) {
-        win.clearInterval(rotation);
-      }
+      win.clearInterval(rotation);
       visible.remove();
       live.remove();
     },

package/src/kernel/pane.ts

@@ -220,7 +220,8 @@ export interface PaneKernel extends PaneHandle {
    *  gets when the closing transition ends. */
   setHidden(value: boolean): void;
   /** The shell is about to slide this pane's box: nothing it measures from now
-   *  until its viewport settles is final, and the settle sends the size. */
+   *  until its viewport settles is final, and the settle sends the size. Live
+   *  panes only: a failed pane is torn down before the split next opens. */
   holdGeometry(): void;
   /** Whether this pane's input is a stop in the document's Tab order. On while
    *  the split is open and the pane shows a tab, so Tab runs left input, divider,
@@ -437,15 +438,10 @@ function buildPaneInto(
   let hidden = false;
   let rootReleased = false;
 
-  let ready = false;
   let firstFrameRendered = false;
   let fontsLoaded = false;
   let wsOpen = false;
   function markReady(): void {
-    if (ready) {
-      return;
-    }
-    ready = true;
     connState.setLoaded();
     services.loading.firstFrame();
   }
@@ -981,7 +977,7 @@ function buildPaneInto(
       }
       // Nobody owns the keyboard: focus in a shadow root, a dialog or an ARIA
       // widget all report non-body and all bail.
-      if (doc.activeElement !== null && doc.activeElement !== doc.body) {
+      if (doc.activeElement !== doc.body) {
         return;
       }
       if (composition.isComposing()) {
@@ -1514,9 +1510,7 @@ function buildPaneInto(
       hidden = value;
     },
     holdGeometry() {
-      if (!destroyed) {
-        viewport.beginTransition();
-      }
+      viewport.beginTransition();
     },
     setTabStop(value) {
       input.tabIndex = value ? 0 : -1;

package/src/kernel/scrollback-storage.ts

@@ -214,7 +214,6 @@ export function localScrollbackStorage(
   function sweep(): void {
     const now = Date.now();
     const live: { key: string; savedAt: number; chars: number }[] = [];
-    let total = 0;
     for (const entry of ownEntries()) {
       // An unreadable timestamp is treated as expired: the kernel would refuse
       // the entry anyway, so keeping it only consumes quota.
@@ -223,10 +222,6 @@ export function localScrollbackStorage(
         continue;
       }
       live.push({ key: entry.key, savedAt: entry.savedAt, chars: entry.chars });
-      total += entry.chars;
-    }
-    if (total <= maxBytes) {
-      return;
     }
     // Newest first, then keep entries while they fit and drop the rest: an entry
     // the user last saw a minute ago is worth more than one from this morning.

package/src/kernel/selection.ts

@@ -12,9 +12,6 @@ export function selectionTextWithin(container: Element): string {
     return "";
   }
   const text = sel.toString();
-  if (text.length === 0) {
-    return "";
-  }
   for (let i = 0; i < sel.rangeCount; i++) {
     const range = sel.getRangeAt(i);
     if (!container.contains(range.startContainer) || !container.contains(range.endContainer)) {

package/src/kernel/shell.ts

@@ -549,9 +549,6 @@ function createShellInto(
     applyRatioVar();
   }
   function fireSplitChange(): void {
-    if (changeListeners.size === 0) {
-      return;
-    }
     const state = splitState();
     for (const cb of [...changeListeners]) {
       cb(state);
@@ -608,9 +605,6 @@ function createShellInto(
   // may rest on the empty pane the replacement is headed for, so the handle faces
   // where the new tab will land.
   function select(side: PaneSide): boolean {
-    if (!isPaneSide(side)) {
-      return false;
-    }
     const state = paneAt(side)?.state();
     if (state !== "shown" && !(state === "empty" && !anyShown())) {
       return false;
@@ -1064,7 +1058,7 @@ function createShellInto(
       return;
     }
     for (const feature of features) {
-      if (destroyed || kernel.isDestroyed()) {
+      if (kernel.isDestroyed()) {
         return;
       }
       const outcome = await kernel.setupFeature(feature);
@@ -1072,9 +1066,6 @@ function createShellInto(
         failPane(slot, { phase: "feature-setup", feature: outcome.feature, cause: outcome.cause });
         return;
       }
-      if (outcome.status === "aborted") {
-        return;
-      }
     }
   }
   function buildSecondary(slot: Slot): void {
@@ -1231,7 +1222,7 @@ function createShellInto(
     return true;
   }
   function closeSide(side: PaneSide): boolean {
-    if (!isPaneSide(side) || !splitOpen || destroyed) {
+    if (!splitOpen || destroyed) {
       return false;
     }
     const squeezed = slotAt(side);
@@ -1266,9 +1257,6 @@ function createShellInto(
     );
   }
   function onShellResize(): void {
-    if (destroyed) {
-      return;
-    }
     paintShellNarrow();
     for (const p of builtPanes()) {
       p.updateNarrow();
@@ -1427,9 +1415,6 @@ function createShellInto(
 
   let rootReleased = false;
   function cleanupRuntime(): void {
-    if (destroyed) {
-      return;
-    }
     destroyed = true;
     // The tracked stores are about to become unreachable, and the connections
     // whose epochs the save is filed under go with the drain.
@@ -1441,7 +1426,6 @@ function createShellInto(
     if (destroyed) {
       return;
     }
-    primaryKernel.markFailed();
     cleanupRuntime();
     dismissLoadingOverlay();
     let handled = false;
@@ -1517,21 +1501,12 @@ function createShellInto(
       selectedPane().focus();
     },
     send(bytes) {
-      if (destroyed) {
-        return;
-      }
       selectedPane().send(bytes);
     },
     reset() {
-      if (destroyed) {
-        return;
-      }
       selectedPane().reset();
     },
     reattach() {
-      if (destroyed) {
-        return;
-      }
       selectedPane().reattach();
     },
     destroy() {

package/src/kernel/split-handle.ts

@@ -237,9 +237,6 @@ export function createSplitHandle(shell: SplitHandleShell): SplitHandle {
       return;
     }
     const state = split.state();
-    if (!state.open || state.collapsed) {
-      return;
-    }
     ev.preventDefault();
     const span = root.clientWidth - SPLIT_GUTTER_PX;
     const { min, max } = bounds();

package/src/predict.ts

@@ -31,7 +31,6 @@ export function createPredictor(): Predictor {
   let predCol = 0;
   let predActive = false;
   let predPendingWrap = false;
-  let predFrozen = false;
   let cols = 80;
   let rows = 30;
   let onChange: (() => void) | null = null;
@@ -40,8 +39,6 @@ export function createPredictor(): Predictor {
     predRow = 0;
     predCol = 0;
     predActive = false;
-    predPendingWrap = false;
-    predFrozen = false;
     onChange?.();
   }
 
@@ -73,23 +70,17 @@ export function createPredictor(): Predictor {
       predRow = serverRow;
       predCol = serverCol;
       predPendingWrap = false;
-      predFrozen = cursorHidden ?? false;
-      predActive = !predFrozen;
+      predActive = !(cursorHidden ?? false);
       onChange?.();
     },
     applyInput(bytes) {
-      if (!predActive || predFrozen) {
+      if (!predActive) {
         return;
       }
       let i = 0;
       while (i < bytes.length) {
         // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- index checked by loop condition
         const b = bytes[i]!;
-        if (b === 0x1b) {
-          predActive = false;
-          onChange?.();
-          return;
-        }
         if (b === 0x08 || b === 0x7f) {
           predPendingWrap = false;
           if (predCol > 0) {

package/src/viewport.ts

@@ -9,7 +9,15 @@ import { windowOf } from "./kernel/realm.js";
 
 // Long enough to bridge the iOS keyboard slide (~250ms) with margin for fonts
 // and reflow.
-const SETTLE_MS = 350;
+let SETTLE_MS = 350;
+
+/** @internal Test seam: arm every settle started from now on at `ms`; returns the
+ *  previous value so the caller can restore it. */
+export function setSettleMs(ms: number): number {
+  const previous = SETTLE_MS;
+  SETTLE_MS = ms;
+  return previous;
+}
 
 /** The visual viewport against the layout viewport, in whole CSS px. */
 interface KeyboardGeometry {