@cplieger/web-terminal-ui 8.3.0 → 8.3.2

package/src/kernel/pane.ts

@@ -220,7 +220,8 @@ export interface PaneKernel extends PaneHandle {
    *  gets when the closing transition ends. */
   setHidden(value: boolean): void;
   /** The shell is about to slide this pane's box: nothing it measures from now
-   *  until its viewport settles is final, and the settle sends the size. */
+   *  until its viewport settles is final, and the settle sends the size. Live
+   *  panes only: a failed pane is torn down before the split next opens. */
   holdGeometry(): void;
   /** Whether this pane's input is a stop in the document's Tab order. On while
    *  the split is open and the pane shows a tab, so Tab runs left input, divider,
@@ -437,15 +438,10 @@ function buildPaneInto(
   let hidden = false;
   let rootReleased = false;
 
-  let ready = false;
   let firstFrameRendered = false;
   let fontsLoaded = false;
   let wsOpen = false;
   function markReady(): void {
-    if (ready) {
-      return;
-    }
-    ready = true;
     connState.setLoaded();
     services.loading.firstFrame();
   }
@@ -981,7 +977,7 @@ function buildPaneInto(
       }
       // Nobody owns the keyboard: focus in a shadow root, a dialog or an ARIA
       // widget all report non-body and all bail.
-      if (doc.activeElement !== null && doc.activeElement !== doc.body) {
+      if (doc.activeElement !== doc.body) {
         return;
       }
       if (composition.isComposing()) {
@@ -1514,9 +1510,7 @@ function buildPaneInto(
       hidden = value;
     },
     holdGeometry() {
-      if (!destroyed) {
-        viewport.beginTransition();
-      }
+      viewport.beginTransition();
     },
     setTabStop(value) {
       input.tabIndex = value ? 0 : -1;

package/src/kernel/scrollback-storage.ts

@@ -214,7 +214,6 @@ export function localScrollbackStorage(
   function sweep(): void {
     const now = Date.now();
     const live: { key: string; savedAt: number; chars: number }[] = [];
-    let total = 0;
     for (const entry of ownEntries()) {
       // An unreadable timestamp is treated as expired: the kernel would refuse
       // the entry anyway, so keeping it only consumes quota.
@@ -223,10 +222,6 @@ export function localScrollbackStorage(
         continue;
       }
       live.push({ key: entry.key, savedAt: entry.savedAt, chars: entry.chars });
-      total += entry.chars;
-    }
-    if (total <= maxBytes) {
-      return;
     }
     // Newest first, then keep entries while they fit and drop the rest: an entry
     // the user last saw a minute ago is worth more than one from this morning.

package/src/kernel/selection.ts

@@ -12,9 +12,6 @@ export function selectionTextWithin(container: Element): string {
     return "";
   }
   const text = sel.toString();
-  if (text.length === 0) {
-    return "";
-  }
   for (let i = 0; i < sel.rangeCount; i++) {
     const range = sel.getRangeAt(i);
     if (!container.contains(range.startContainer) || !container.contains(range.endContainer)) {

package/src/kernel/shell.ts

@@ -549,9 +549,6 @@ function createShellInto(
     applyRatioVar();
   }
   function fireSplitChange(): void {
-    if (changeListeners.size === 0) {
-      return;
-    }
     const state = splitState();
     for (const cb of [...changeListeners]) {
       cb(state);
@@ -608,9 +605,6 @@ function createShellInto(
   // may rest on the empty pane the replacement is headed for, so the handle faces
   // where the new tab will land.
   function select(side: PaneSide): boolean {
-    if (!isPaneSide(side)) {
-      return false;
-    }
     const state = paneAt(side)?.state();
     if (state !== "shown" && !(state === "empty" && !anyShown())) {
       return false;
@@ -1064,7 +1058,7 @@ function createShellInto(
       return;
     }
     for (const feature of features) {
-      if (destroyed || kernel.isDestroyed()) {
+      if (kernel.isDestroyed()) {
         return;
       }
       const outcome = await kernel.setupFeature(feature);
@@ -1072,9 +1066,6 @@ function createShellInto(
         failPane(slot, { phase: "feature-setup", feature: outcome.feature, cause: outcome.cause });
         return;
       }
-      if (outcome.status === "aborted") {
-        return;
-      }
     }
   }
   function buildSecondary(slot: Slot): void {
@@ -1231,7 +1222,7 @@ function createShellInto(
     return true;
   }
   function closeSide(side: PaneSide): boolean {
-    if (!isPaneSide(side) || !splitOpen || destroyed) {
+    if (!splitOpen || destroyed) {
       return false;
     }
     const squeezed = slotAt(side);
@@ -1266,9 +1257,6 @@ function createShellInto(
     );
   }
   function onShellResize(): void {
-    if (destroyed) {
-      return;
-    }
     paintShellNarrow();
     for (const p of builtPanes()) {
       p.updateNarrow();
@@ -1427,9 +1415,6 @@ function createShellInto(
 
   let rootReleased = false;
   function cleanupRuntime(): void {
-    if (destroyed) {
-      return;
-    }
     destroyed = true;
     // The tracked stores are about to become unreachable, and the connections
     // whose epochs the save is filed under go with the drain.
@@ -1441,7 +1426,6 @@ function createShellInto(
     if (destroyed) {
       return;
     }
-    primaryKernel.markFailed();
     cleanupRuntime();
     dismissLoadingOverlay();
     let handled = false;
@@ -1517,21 +1501,12 @@ function createShellInto(
       selectedPane().focus();
     },
     send(bytes) {
-      if (destroyed) {
-        return;
-      }
       selectedPane().send(bytes);
     },
     reset() {
-      if (destroyed) {
-        return;
-      }
       selectedPane().reset();
     },
     reattach() {
-      if (destroyed) {
-        return;
-      }
       selectedPane().reattach();
     },
     destroy() {

package/src/kernel/split-handle.ts

@@ -237,9 +237,6 @@ export function createSplitHandle(shell: SplitHandleShell): SplitHandle {
       return;
     }
     const state = split.state();
-    if (!state.open || state.collapsed) {
-      return;
-    }
     ev.preventDefault();
     const span = root.clientWidth - SPLIT_GUTTER_PX;
     const { min, max } = bounds();

package/src/predict.ts

@@ -31,7 +31,6 @@ export function createPredictor(): Predictor {
   let predCol = 0;
   let predActive = false;
   let predPendingWrap = false;
-  let predFrozen = false;
   let cols = 80;
   let rows = 30;
   let onChange: (() => void) | null = null;
@@ -40,8 +39,6 @@ export function createPredictor(): Predictor {
     predRow = 0;
     predCol = 0;
     predActive = false;
-    predPendingWrap = false;
-    predFrozen = false;
     onChange?.();
   }
 
@@ -73,23 +70,17 @@ export function createPredictor(): Predictor {
       predRow = serverRow;
       predCol = serverCol;
       predPendingWrap = false;
-      predFrozen = cursorHidden ?? false;
-      predActive = !predFrozen;
+      predActive = !(cursorHidden ?? false);
       onChange?.();
     },
     applyInput(bytes) {
-      if (!predActive || predFrozen) {
+      if (!predActive) {
         return;
       }
       let i = 0;
       while (i < bytes.length) {
         // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- index checked by loop condition
         const b = bytes[i]!;
-        if (b === 0x1b) {
-          predActive = false;
-          onChange?.();
-          return;
-        }
         if (b === 0x08 || b === 0x7f) {
           predPendingWrap = false;
           if (predCol > 0) {

package/src/viewport.ts

@@ -9,7 +9,15 @@ import { windowOf } from "./kernel/realm.js";
 
 // Long enough to bridge the iOS keyboard slide (~250ms) with margin for fonts
 // and reflow.
-const SETTLE_MS = 350;
+let SETTLE_MS = 350;
+
+/** @internal Test seam: arm every settle started from now on at `ms`; returns the
+ *  previous value so the caller can restore it. */
+export function setSettleMs(ms: number): number {
+  const previous = SETTLE_MS;
+  SETTLE_MS = ms;
+  return previous;
+}
 
 /** The visual viewport against the layout viewport, in whole CSS px. */
 interface KeyboardGeometry {