@cplieger/web-terminal-ui 7.0.0 → 7.0.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cplieger/web-terminal-ui",
-  "version": "7.0.0",
+  "version": "7.0.2",
   "type": "module",
   "description": "Reference touch-first browser UI for @cplieger/web-terminal-engine: a composable kernel + feature modules (tabs, activity monitor, mobile toolbar, context menu, IME, predictive echo, viewport handling) and CSS. One createTerminal() call.",
   "license": "MPL-2.0",
@@ -55,7 +55,7 @@
     "@vitest/coverage-v8": "4.1.11",
     "eslint": "10.8.1",
     "fast-check": "4.9.0",
-    "happy-dom": "20.11.2",
+    "happy-dom": "20.11.6",
     "html-validate": "11.8.0",
     "knip": "6.32.2",
     "prettier": "3.9.6",

package/src/features/context-menu.ts

@@ -188,9 +188,6 @@ export function contextMenu(opts: ContextMenuOptions = {}): TerminalFeature {
             clipboard.paste();
           });
         }
-        if (menu.childElementCount === 0) {
-          return; // nothing to offer
-        }
         // Make visible (so it has measurable size), then place it within the
         // visible viewport via the shared point-anchored positioner (clamp to the
         // visual viewport; flip above the finger near the bottom edge).

package/src/features/tabs/index.ts

@@ -244,7 +244,12 @@ async function createSessionHonouringRetry(
   isTornDown: () => boolean,
 ): Promise<SessionInfo> {
   const startedAt = Date.now();
-  let lastAnnouncedAt = 0;
+  // The elapsed reading of the last announcement, or null when nothing has been
+  // announced yet. NOT a 0 sentinel: elapsed is legitimately 0 when the server
+  // refuses inside the first millisecond (a host on the same machine), and a 0
+  // sentinel read that as "never spoken" and re-announced on the next refusal —
+  // the one thing the throttle below exists to prevent.
+  let lastAnnouncedAt: number | null = null;
   for (;;) {
     try {
       return await api.create();
@@ -266,7 +271,7 @@ async function createSessionHonouringRetry(
       // only said "not yet" -- and the first announcement fires before any retry
       // has happened at all, so a user two seconds into a boot was told
       // "retrying" about a request that had been made exactly once.
-      if (lastAnnouncedAt === 0 || elapsed - lastAnnouncedAt >= CREATE_RETRY_REANNOUNCE_MS) {
+      if (lastAnnouncedAt === null || elapsed - lastAnnouncedAt >= CREATE_RETRY_REANNOUNCE_MS) {
         lastAnnouncedAt = elapsed;
         const reason = err.serverMessage ?? "Server is not ready yet";
         ctx.toast(`${reason}; waiting…`, 8000);
@@ -2868,13 +2873,20 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
       // still be), to the terminal otherwise. Recorded at entry because the exit
       // paths cannot tell them apart.
       let editFrom: "keyboard" | "pointer" = "pointer";
-      // Tab ids with a pinned-name request in flight. While an id is here, a status
-      // record carrying a DIFFERENT value is applied for display but does not
-      // supersede the request: SSE delivery order and REST mutation order are not
-      // one total order, so a record sampled BEFORE our PUT can arrive after it,
-      // and treating it as newer authority would suppress the request's own
-      // rollback and its failure toast.
-      const namesInFlight = new Set<string>();
+      // Tab ids with pinned-name requests in flight, COUNTED per id. While a count
+      // is held, a status record carrying a DIFFERENT value is applied for display
+      // but does not supersede the request: SSE delivery order and REST mutation
+      // order are not one total order, so a record sampled BEFORE our PUT can
+      // arrive after it, and treating it as newer authority would suppress the
+      // request's own rollback and its failure toast.
+      // Counted rather than a Set of ids, because two renames of one tab can be out
+      // at once and the invariant is "no request of OURS is in flight", not "no id
+      // is marked": a bare Set let the first request's completion clear the marker
+      // while the second's PUT was still open, and the second rename then failed
+      // silently. A per-request token would carry more information, but the only
+      // reader asks whether ANY request is out for this id, and the failure handler
+      // already distinguishes its own supersession by (born, nameSeq).
+      const namesInFlight = new Map<string, number>();
 
       /** restoreFocusAfterEdit sends focus where the entry path implies. The
        *  terminal branch is gated exactly like switchTo's focus-on-switch: on a
@@ -2944,8 +2956,11 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
           const { text, fallback } = baseLabel(t);
           ctx.announce(fallback ? "Custom name removed" : `Using automatic name: ${text}`);
         }
-        namesInFlight.add(id);
         const request = name === "" ? api.clearPinnedTitle(id) : api.setPinnedTitle(id, name);
+        // Counted only once the request exists: an api implementation that throws
+        // instead of rejecting would otherwise leave a count behind that no
+        // .finally ever releases, and the id would read as in flight forever.
+        namesInFlight.set(id, (namesInFlight.get(id) ?? 0) + 1);
         void request
           .catch(() => {
             const cur = tabList.find((x) => x.id === id);
@@ -2957,7 +2972,12 @@ export function tabs(opts: TabsOptions = {}): TerminalFeature<TabsApi> {
             ctx.toast("Couldn't save the terminal name");
           })
           .finally(() => {
-            namesInFlight.delete(id);
+            const left = (namesInFlight.get(id) ?? 0) - 1;
+            if (left > 0) {
+              namesInFlight.set(id, left);
+            } else {
+              namesInFlight.delete(id);
+            }
           });
         return true;
       }

package/src/kernel/kernel.ts

@@ -274,17 +274,21 @@ function buildTerminal(
   // Narrow = compact in EITHER dimension: skinny (a phone in portrait, a
   // narrow embedded panel) or short (a phone in landscape). The one
   // ResizeObserver below fires on both width and height changes.
+  //
+  // Constructed unconditionally: ResizeObserver is a hard requirement of this
+  // library, not an enhancement. viewport.init() and the tabs strip both
+  // construct one with no guard, and the same buildTerminal builds a WeakRef
+  // (whose browser floor is strictly higher), so a `typeof ResizeObserver ===
+  // "function"` guard here could only ever protect a browser that crashes
+  // moments later. It used to be here, and it was measured dead.
   const isNarrow = (): boolean =>
     root.clientWidth <= NARROW_MAX_PX || root.clientHeight <= SHORT_MAX_PX;
   function updateNarrow(): void {
     root.classList.toggle("wt-narrow", isNarrow());
   }
   updateNarrow();
-  let narrowObserver: ResizeObserver | null = null;
-  if (typeof ResizeObserver === "function") {
-    narrowObserver = new ResizeObserver(updateNarrow);
-    narrowObserver.observe(root);
-  }
+  let narrowObserver: ResizeObserver | null = new ResizeObserver(updateNarrow);
+  narrowObserver.observe(root);
 
   // --- Document title (kernel-owned, composed from two inputs) ---
   //
@@ -790,29 +794,29 @@ function buildTerminal(
   );
 
   /**
-   * Applies the part of a `mapKeyboardEvent` result that BOTH keydown paths (the
-   * focused textarea below, and the document-level type-to-focus fallback in the
-   * focus-strategy section) handle identically. Returns false only for "ignore",
-   * the one arm the two callers resolve differently: the textarea lets its own
-   * `input` event deliver the character, while the fallback has no `input` event
-   * coming and must send the character itself.
+   * Applies a `mapKeyboardEvent` result. BOTH keydown paths — the focused textarea
+   * below, and the document-level type-to-focus fallback in the focus-strategy
+   * section — handle every arm identically, including "ignore": the textarea lets
+   * its own `input` event deliver the character, and the fallback has already
+   * resolved that case before it gets here, computing the typed character itself
+   * because no `input` event is coming for a key that targeted the body.
    *
-   * Switching over the whole `KeyboardResult` union in one place is what keeps
-   * the two paths from drifting — handling only "send" in the fallback silently
-   * dropped Shift+PageUp, which is exactly what a reader who just selected some
-   * scrollback presses next.
+   * Switching over the whole `KeyboardResult` union in one place is what keeps the
+   * two paths from drifting — handling only "send" in the fallback silently dropped
+   * Shift+PageUp, which is exactly what a reader who just selected some scrollback
+   * presses next.
    */
-  function applyMappedKey(ev: KeyboardEvent, result: keyboard.KeyboardResult): boolean {
+  function applyMappedKey(ev: KeyboardEvent, result: keyboard.KeyboardResult): void {
     switch (result.kind) {
       case "send":
         ev.preventDefault();
         sendText(result.bytes);
-        return true;
+        return;
       case "scroll-up": {
         ev.preventDefault();
         const h = termWrap.clientHeight;
         termWrap.scrollTop = Math.max(0, termWrap.scrollTop - h);
-        return true;
+        return;
       }
       case "scroll-down": {
         ev.preventDefault();
@@ -823,10 +827,10 @@ function buildTerminal(
         // reasoning as the engine's bottom writes.
         const max = Math.max(0, termWrap.scrollHeight - h);
         termWrap.scrollTop = Math.min(max, termWrap.scrollTop + h);
-        return true;
+        return;
       }
       case "ignore":
-        return false;
+        return;
     }
   }
 
@@ -842,9 +846,9 @@ function buildTerminal(
           return;
         }
       }
-      // A false return ("ignore") needs nothing here: the `input` listener above
-      // delivers the character, which is also how IME and dead-key composition
-      // output reaches the terminal.
+      // Nothing more is needed for an "ignore": the `input` listener above delivers
+      // the character, which is also how IME and dead-key composition output
+      // reaches the terminal.
       applyMappedKey(ev, mapKeyboardEvent(ev, modes));
     },
     { signal },