@cplieger/web-terminal-engine 5.0.5 → 5.0.9

package/jsr.json

@@ -1,6 +1,6 @@
 {
   "name": "@cplieger/web-terminal-engine",
-  "version": "5.0.5",
+  "version": "5.0.9",
   "license": "MPL-2.0",
   "exports": {
     ".": "./src/index.ts"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cplieger/web-terminal-engine",
-  "version": "5.0.5",
+  "version": "5.0.9",
   "type": "module",
   "scripts": {
     "typecheck": "tsc -p tsconfig.json",
@@ -17,15 +17,17 @@
     "@stryker-mutator/vitest-runner": "10.0.0",
     "@types/pngjs": "6.0.5",
     "@typescript/native": "npm:typescript@7.0.2",
+    "@vitest/browser": "4.1.11",
+    "@vitest/browser-playwright": "4.1.11",
     "@vitest/coverage-v8": "4.1.11",
     "esbuild": "0.28.2",
-    "eslint": "10.8.1",
+    "eslint": "10.9.1",
     "fast-check": "4.9.0",
-    "happy-dom": "20.11.2",
+    "playwright": "1.62.1",
     "pngjs": "7.0.0",
     "prettier": "3.9.6",
     "typescript": "npm:@typescript/typescript6@6.0.2",
-    "typescript-eslint": "8.67.0",
+    "typescript-eslint": "8.68.0",
     "vitest": "4.1.11"
   },
   "overrides": {

package/src/connection.ts

@@ -700,10 +700,6 @@ export function sendResize(): void {
   sendControl({ type: "resize", cols, rows });
 }
 
-// resetLedger drops a session's reliable-input accounting. Called when the
-// server's boot epoch changes (restart) or when the server no longer recognizes
-// the session -- both invalidate the local bytesSent/bytesAcked/outbox state.
-// The three entry points below differ only in whether the UI hears about it.
 // resetLedger drops a session's reliable-input accounting. Called whenever the
 // server no longer holds the ledger these counters were keyed to (a restart, an
 // idle-GC'd resume key, a session the server does not recognize): its
@@ -782,7 +778,21 @@ function retransmitOutbox(sock: WebSocket, upgraded: boolean, st: ResumeState):
 }
 
 function scheduleReconnect(): void {
-  if (connState.status === "reconnecting") {
+  // Nothing to schedule when the state already owns a path back to a socket: a
+  // backoff timer is pending ("reconnecting"), or a socket exists that will
+  // drive its own retry from its close handler or its connect timeout
+  // ("connecting"/"connected"). Both callers set "disconnected" before calling
+  // cb.onClose(), so a consumer that reconnects from its own close hook lands
+  // here at "connecting" — and scheduling over it would OVERWRITE connState,
+  // hiding that socket from connect()'s double-call guard, which then never
+  // aborts it: the timer's connect() adds a second live socket with the first
+  // one's listeners still bound, i.e. the duplicate server connection and
+  // double delivery documented inside connect().
+  if (
+    connState.status === "reconnecting" ||
+    connState.status === "connecting" ||
+    connState.status === "connected"
+  ) {
     return;
   }
   const step = nextBackoffDelay(reconnectDelay);

package/src/render.ts

@@ -1355,9 +1355,7 @@ function flushRender(): void {
   const anchor = captureReadAnchor();
   try {
     flushRenderInner();
-    // A clean pass means the error condition (if any) has cleared, so give a
-    // later transient error its full retry budget again. Any backlog reschedule
-    // was already issued from flushRenderInner's own end-of-body.
+    // Clean pass: give a later transient error its full retry budget again.
     renderNoProgressStreak = 0;
   } catch (err) {
     console.error("vterm: render error", err);
@@ -1525,7 +1523,6 @@ function flushRenderInner(): void {
     }
   }
 
-  // Refresh cursor state from the window.
   const win = store.getWindow();
   const newCursorAbs = win.base + win.cursorRow;
   cursorAbs = newCursorAbs;
@@ -1538,11 +1535,9 @@ function flushRenderInner(): void {
   // resulting mode is unchanged.
   syncCursorBlink();
 
-  // Alt screen: render the ephemeral grid instead of the absolute buffer.
-  // Returning here skips the dirtyLines queueing below — safe by invariant:
-  // main-buffer rows never repaint while alt is active, and the alt-exit
-  // branch below rebuilds EVERYTHING via queueRowsViewportFirst, so any line
-  // dirtied during the alt session is repainted at exit.
+  // Skips the dirtyLines queueing below — safe: main-buffer rows never
+  // repaint while alt is active, and alt-exit rebuilds via
+  // queueRowsViewportFirst, repainting any line dirtied during the alt session.
   if (store.isAlt()) {
     const altRows = store.getAltRows();
     renderAlt(altRows);
@@ -1570,7 +1565,6 @@ function flushRenderInner(): void {
     queueRowsViewportFirst();
   }
 
-  // Queue this frame's changed rows for building.
   for (const abs of ch.dirtyLines) {
     renderQueue.add(abs);
   }

package/src/store.ts

@@ -1826,6 +1826,17 @@ export class LineStore {
     if (this.highest < 0) {
       return;
     }
+    // No window established yet — the descriptor is still the initial base
+    // 0/height 0, whose bottom row is -1, below every index a line can hold.
+    // This whole pass rests on "the window's bottom row is the most recent line
+    // in the terminal", which says nothing at all when there is no window: a
+    // resume replays history BEFORE the screen frame describing the window, so
+    // taking -1 as the tail bound strands that replay and forgets it, silently
+    // (this path is not a trim, so no marker explains it). Same test `inWindow`
+    // and applyScroll's alt gate use to ask whether a window exists at all.
+    if (this.win.height <= 0) {
+      return;
+    }
     const windowBottom = this.win.base + this.win.height - 1;
     if (this.highest <= windowBottom) {
       return;
@@ -2008,6 +2019,18 @@ export class LineStore {
   }
 
   private updateWindow(msg: ScreenMessage): void {
+    // A base that is not a non-negative integer is not a screen position — the
+    // same validity test markUnconfirmedFrom applies to this very value — so it
+    // must not redefine the window's shape, for the same reason a rows-less
+    // frame must not: `base + height - 1` lands below every retained index, and
+    // truncateBelowWindow then hands the WHOLE store over as stranded past the
+    // live window. That is the silent wipe applyScreen's rows-less guard
+    // records, reached with rows present, and just as silent (this path is not a
+    // trim, so no marker explains the missing transcript). The frame's
+    // addressable rows still apply through applyLine's guard 1.
+    if (!Number.isInteger(msg.base) || msg.base < 0) {
+      return;
+    }
     const next: WindowState = {
       base: msg.base,
       height: msg.rows.length,