@cplieger/deadset-ts 8.0.0-dev.6 → 8.0.0-dev.8

package/src/intra-function-parts.ts

@@ -96,6 +96,7 @@ import type { Reference } from "./references.ts";
 import type { ProjectView } from "./session.ts";
 import { signatureOf, type SignatureNode } from "./signatures.ts";
 import { spellsNoBinding } from "./spelled-names.ts";
+import { parenthesesRemoved } from "./unwrap.ts";
 
 /** The subject kind of each part this module reads. */
 type PartKind = "parameter" | "result" | "statement" | "store" | "case";
@@ -197,11 +198,6 @@ function spanOf(file: SourceFile, root: string, node: Node): FindingPosition {
   return { ...start, endLine };
 }
 
-/** The parenthesized expression's content, through every pair of parentheses. */
-function unwrapped(node: Node): Node {
-  return isParenthesizedExpression(node) ? unwrapped(node.expression) : node;
-}
-
 /** The node the parentheses around one expression sit in. */
 function outerParent(node: Node): Node {
   return isParenthesizedExpression(node.parent) ? outerParent(node.parent) : node.parent;
@@ -209,7 +205,7 @@ function outerParent(node: Node): Node {
 
 /** The name a call is made through: the identifier, or the member a property access names. */
 function calleeName(call: CallExpression): Identifier | undefined {
-  const callee = unwrapped(call.expression);
+  const callee = parenthesesRemoved(call.expression);
   if (isIdentifier(callee)) {
     return callee;
   }
@@ -276,7 +272,7 @@ function unreachableExempt(statement: Statement): boolean {
 
 /** The value a case expression is a literal of, as a key two equal literals share, or none. */
 function caseKey(expression: Node): string | undefined {
-  const node = unwrapped(expression);
+  const node = parenthesesRemoved(expression);
   if (isStringLiteral(node) || isNoSubstitutionTemplateLiteral(node)) {
     return `s:${node.text}`;
   }
@@ -402,7 +398,7 @@ function extendedNames(files: readonly SourceFile[]): ReadonlySet<string> {
         if (isTypeReferenceNode(type)) {
           named = isQualifiedName(type.typeName) ? type.typeName.right : type.typeName;
         } else {
-          const expression = unwrapped(type.expression);
+          const expression = parenthesesRemoved(type.expression);
           named = isPropertyAccessExpression(expression) ? expression.name : expression;
         }
         if (isIdentifier(named)) {
@@ -455,7 +451,7 @@ function decoratorFixes(constructor: ConstructorDeclaration): boolean {
 
 /** The name an expression spells a class by: an identifier, or the member a property access names. */
 function spelledName(expression: Node): Identifier | undefined {
-  const node = unwrapped(expression);
+  const node = parenthesesRemoved(expression);
   if (isIdentifier(node)) {
     return node;
   }
@@ -724,8 +720,8 @@ export function projectParts<Brand>(
       if ((isImportClause(node) || isNamespaceImport(node)) && node.name !== undefined) {
         specifiers.add(position(node.name));
       }
-      if (isExportAssignment(node) && isIdentifier(unwrapped(node.expression))) {
-        specifiers.add(position(unwrapped(node.expression)));
+      if (isExportAssignment(node) && isIdentifier(parenthesesRemoved(node.expression))) {
+        specifiers.add(position(parenthesesRemoved(node.expression)));
       }
       if (isSwitchStatement(node)) {
         const holder = holderOf(node);
@@ -1325,7 +1321,7 @@ function isPlainWrite(use: Identifier): boolean {
   return (
     isBinaryExpression(parent) &&
     parent.operatorToken.kind === SyntaxKind.EqualsToken &&
-    unwrapped(parent.left) === use
+    parenthesesRemoved(parent.left) === use
   );
 }
 
@@ -1382,14 +1378,14 @@ function deadStores(
       if (!isExpressionStatement(statement)) {
         return undefined;
       }
-      const expression = unwrapped(statement.expression);
+      const expression = parenthesesRemoved(statement.expression);
       if (
         !isBinaryExpression(expression) ||
         expression.operatorToken.kind !== SyntaxKind.EqualsToken
       ) {
         return undefined;
       }
-      const target = unwrapped(expression.left);
+      const target = parenthesesRemoved(expression.left);
       return isIdentifier(target) && uses.includes(target)
         ? { target, value: expression.right }
         : undefined;

package/src/inventory.ts

@@ -50,6 +50,7 @@ import {
 import { computedComponent, nameComponent, renderRef, type Component, type Module } from "./ref.ts";
 import { isAnswered, UNANSWERED } from "./query.ts";
 import type { Handle, ProjectView } from "./session.ts";
+import { manifestAt } from "./fs/manifest.ts";
 
 /**
  * The symbol inventory of one project: every declaration the target's own files
@@ -233,8 +234,6 @@ interface ExportScope {
   readonly nameNode: Node;
 }
 
-const MANIFEST = "package.json";
-
 /** One manifest that names a package, and the directory below the root that holds it. */
 interface Named {
   readonly name: string;
@@ -255,24 +254,7 @@ export function packageScope(host: Host, root: string): (path: string) => Module
   const named = new Map<string, Named | undefined>();
 
   const manifestName = (dir: string): string | undefined => {
-    let text: string;
-    try {
-      text = host.readFile(joinPath(root, dir, MANIFEST));
-    } catch {
-      return undefined;
-    }
-    let value: unknown;
-    try {
-      value = JSON.parse(text);
-    } catch {
-      // A manifest this program cannot read names no package, which is the same
-      // answer as an absent one: the file is then scoped by the target root.
-      return undefined;
-    }
-    if (typeof value !== "object" || value === null) {
-      return undefined;
-    }
-    const name = (value as Record<string, unknown>)["name"];
+    const name = manifestAt(host, joinPath(root, dir))?.["name"];
     return typeof name === "string" && name !== "" ? name : undefined;
   };
 

package/src/json-document.ts

@@ -1,122 +1,276 @@
+import type { Position } from "./position.ts";
+
+/** A place inside a document: each member name a string, each array index a number. */
+export type Place = readonly (string | number)[];
+
 /**
- * A read of a strict JSON document beside its parse: what a parse into a value cannot
- * report, the offset of each record of one array and a member written twice.
+ * A text that is not one strict JSON document: a syntax error, data after the value, a
+ * member one object writes twice, or nesting past {@link MAX_DEPTH}. `place` is the
+ * value the fault is in, followed by the member written twice.
  */
+export class StrictJSONError extends Error {
+  readonly offset: number;
+  readonly place: Place;
 
-import type { Position } from "./position.ts";
+  constructor(reason: string, offset: number, place: Place) {
+    super(reason);
+    this.name = "StrictJSONError";
+    this.offset = offset;
+    this.place = place;
+  }
+}
 
-/** The token walk over a document `JSON.parse` accepted, so every token is well formed. */
-class Walk {
-  readonly starts: number[] = [];
-  /** The member written twice, where one is, as the offset of its name. */
-  twice: { readonly name: string; readonly offset: number } | undefined;
-  private readonly text: string;
-  private readonly array: string;
+/** One strict JSON document, read whole. */
+interface StrictDocument {
+  readonly value: unknown;
+  /**
+   * The text of every number written with a fraction or an exponent, by its JSON
+   * Pointer: a value reads `100.0` as the integer 100, so only the text tells them apart.
+   */
+  readonly fractions: ReadonlyMap<string, string>;
+  /**
+   * The offset of each value inside the top-level member a read names, by its index or
+   * its member name, in document order.
+   */
+  readonly starts: ReadonlyMap<string | number, number>;
+}
+
+/**
+ * How deep values may nest. A document this analyzer reads nests a few levels, and a
+ * bound turns a document built to exhaust the stack into a refusal.
+ */
+const MAX_DEPTH = 1000;
+
+const SPACE = /[ \t\n\r]*/uy;
+const STRING =
+  /"(?:[ !#$%&'()*+,\-./0-9:;<=>?@A-Z[\]-\u{10FFFF}]|\\(?:["\\/bfnrt]|u[0-9A-Fa-f]{4}))*"/uy;
+const NUMBER = /-?(?:0|[1-9][0-9]*)(\.[0-9]+)?([eE][+-]?[0-9]+)?/uy;
+const LITERALS: ReadonlyMap<string, unknown> = new Map<string, unknown>([
+  ["true", true],
+  ["false", false],
+  ["null", null],
+]);
+
+/** One member name spelled as a JSON Pointer token. */
+const escaped = (name: string): string => name.replaceAll("~", "~0").replaceAll("/", "~1");
+
+/** The member names and indexes a JSON Pointer holds, unescaped. */
+export function pointerSegments(pointer: string): string[] {
+  return pointer === ""
+    ? []
+    : pointer
+        .slice(1)
+        .split("/")
+        .map((token) => token.replaceAll("~1", "/").replaceAll("~0", "~"));
+}
+
+/** The JSON Pointer of a place written as segments. */
+export function pointerOf(segments: readonly string[]): string {
+  return segments.map((segment) => `/${escaped(segment)}`).join("");
+}
+
+/**
+ * The place a JSON Pointer names inside `value`, followed by `member` where it is not
+ * empty: a pointer's text does not say whether a segment of digits is an index, so the
+ * value it points into does.
+ */
+export function placeIn(value: unknown, pointer: string, member = ""): (string | number)[] {
+  const place: (string | number)[] = [];
+  let held = value;
+  for (const segment of pointerSegments(pointer)) {
+    if (Array.isArray(held)) {
+      place.push(Number(segment));
+      held = held[Number(segment)];
+    } else {
+      place.push(segment);
+      held = isRecord(held) ? held[segment] : undefined;
+    }
+  }
+  return member === "" ? place : [...place, member];
+}
+
+/**
+ * A place as a refusal names it: member names joined by full stops and an index in
+ * square brackets, as `ts.serializers[0].returns`.
+ */
+export function dotted(place: Place): string {
+  let path = "";
+  for (const segment of place) {
+    path +=
+      typeof segment === "number" ? `[${String(segment)}]` : path === "" ? segment : `.${segment}`;
+  }
+  return path;
+}
+
+class Reader {
   private at = 0;
+  private readonly path: (string | number)[] = [];
+  readonly fractions = new Map<string, string>();
+  readonly starts = new Map<string | number, number>();
+  private readonly text: string;
+  private readonly records: string | undefined;
 
-  constructor(text: string, array: string) {
+  constructor(text: string, records: string | undefined) {
     this.text = text;
-    this.array = array;
+    this.records = records;
   }
 
-  run(): void {
-    this.value("document");
+  read(): unknown {
+    const value = this.value(0);
+    this.match(SPACE);
+    if (this.at < this.text.length) {
+      this.fail("data follows the document's value");
+    }
+    return value;
   }
 
-  private skip(): void {
-    while (/[ \t\r\n]/u.test(this.text[this.at] ?? "")) {
-      this.at += 1;
-    }
+  private fail(reason: string, offset = this.at, member = ""): never {
+    throw new StrictJSONError(
+      reason,
+      offset,
+      member === "" ? [...this.path] : [...this.path, member],
+    );
   }
 
-  private string(): string {
-    const start = this.at;
-    this.at += 1;
-    while (this.text[this.at] !== '"') {
-      this.at += this.text[this.at] === "\\" ? 2 : 1;
+  private match(pattern: RegExp): string | undefined {
+    pattern.lastIndex = this.at;
+    const found = pattern.exec(this.text)?.[0];
+    this.at = found === undefined ? this.at : pattern.lastIndex;
+    return found;
+  }
+
+  private expect(char: string, what: string): void {
+    this.match(SPACE);
+    if (this.text[this.at] !== char) {
+      this.fail(`${what} is expected`);
     }
     this.at += 1;
-    return JSON.parse(this.text.slice(start, this.at)) as string;
   }
 
-  private value(role: "document" | "array" | "record" | "other"): void {
-    this.skip();
-    if (role === "record") {
-      this.starts.push(this.at);
+  private value(depth: number): unknown {
+    this.match(SPACE);
+    if (depth > MAX_DEPTH) {
+      this.fail(`values nest deeper than ${String(MAX_DEPTH)} levels`);
     }
     const char = this.text[this.at];
     if (char === "{") {
-      this.object(role);
-    } else if (char === "[") {
-      this.list(role === "array" ? "record" : "other");
-    } else if (char === '"') {
-      this.string();
-    } else {
-      while (this.at < this.text.length && !/[,\]} \t\r\n]/u.test(this.text[this.at] ?? "")) {
-        this.at += 1;
+      return this.object(depth);
+    }
+    if (char === "[") {
+      return this.array(depth);
+    }
+    const string = this.match(STRING);
+    if (string !== undefined) {
+      return JSON.parse(string) as string;
+    }
+    NUMBER.lastIndex = this.at;
+    const number = NUMBER.exec(this.text);
+    if (number !== null) {
+      this.at = NUMBER.lastIndex;
+      if (number[1] !== undefined || number[2] !== undefined) {
+        this.fractions.set(pointerOf(this.path.map(String)), number[0]);
       }
+      return Number(number[0]);
     }
+    for (const [literal, held] of LITERALS) {
+      if (this.text.startsWith(literal, this.at)) {
+        this.at += literal.length;
+        return held;
+      }
+    }
+    return this.fail(
+      char === undefined ? "the document ends where a value is expected" : "a value is expected",
+    );
   }
 
-  private object(role: string): void {
-    const seen = new Set<string>();
+  private object(depth: number): Record<string, unknown> {
+    const held: Record<string, unknown> = {};
     this.at += 1;
+    this.match(SPACE);
+    if (this.text[this.at] === "}") {
+      this.at += 1;
+      return held;
+    }
     for (;;) {
-      this.skip();
-      if (this.text[this.at] === "}") {
-        this.at += 1;
-        return;
+      this.match(SPACE);
+      const offset = this.at;
+      const spelled = this.match(STRING);
+      if (spelled === undefined) {
+        return this.fail("a member name is expected");
       }
-      if (this.text[this.at] === ",") {
-        this.at += 1;
-        this.skip();
+      const name = JSON.parse(spelled) as string;
+      if (Object.hasOwn(held, name)) {
+        this.fail(
+          `the member ${JSON.stringify(name)} is written twice, so neither value is chosen`,
+          offset,
+          name,
+        );
       }
-      const offset = this.at;
-      const name = this.string();
-      if (seen.has(name) && this.twice === undefined) {
-        this.twice = { name, offset };
+      this.expect(":", "a colon after the member name");
+      if (depth === 1 && this.path[0] === this.records) {
+        this.match(SPACE);
+        this.starts.set(name, this.at);
       }
-      seen.add(name);
-      this.skip();
+      this.path.push(name);
+      Object.defineProperty(held, name, {
+        value: this.value(depth + 1),
+        enumerable: true,
+        writable: true,
+        configurable: true,
+      });
+      this.path.pop();
+      this.match(SPACE);
+      const next = this.text[this.at];
       this.at += 1;
-      this.value(role === "document" && name === this.array ? "array" : "other");
+      if (next === "}") {
+        return held;
+      }
+      if (next !== ",") {
+        this.at -= 1;
+        this.fail("a comma or a closing brace is expected");
+      }
     }
   }
 
-  private list(element: "record" | "other"): void {
+  private array(depth: number): unknown[] {
+    const held: unknown[] = [];
+    const records = depth === 1 && this.path[0] === this.records;
     this.at += 1;
+    this.match(SPACE);
+    if (this.text[this.at] === "]") {
+      this.at += 1;
+      return held;
+    }
     for (;;) {
-      this.skip();
-      if (this.text[this.at] === "]") {
-        this.at += 1;
-        return;
+      this.match(SPACE);
+      if (records) {
+        this.starts.set(held.length, this.at);
+      }
+      this.path.push(held.length);
+      held.push(this.value(depth + 1));
+      this.path.pop();
+      this.match(SPACE);
+      const next = this.text[this.at];
+      this.at += 1;
+      if (next === "]") {
+        return held;
       }
-      if (this.text[this.at] === ",") {
-        this.at += 1;
+      if (next !== ",") {
+        this.at -= 1;
+        this.fail("a comma or a closing bracket is expected");
       }
-      this.value(element);
     }
   }
 }
 
-/** What a walk of one document found. */
-interface DocumentWalk {
-  /** The offset of each element of the document's array member, in order: an object's `{`. */
-  readonly starts: readonly number[];
-  /** The first member one object writes twice, at any depth, as the offset of its name. */
-  readonly twice: { readonly name: string; readonly offset: number } | undefined;
-}
-
 /**
- * Walks a document `JSON.parse` accepted, whose top-level member `array` holds the
- * records. A member one object writes twice reads as though it were written once, its
- * later value silently replacing the earlier one, so a document holding one is one a
- * reader names rather than reads.
+ * Reads `text` as one strict JSON document, or throws a {@link StrictJSONError}.
+ * `records` names the top-level member whose values' offsets the read keeps.
  */
-export function walkDocument(text: string, array: string): DocumentWalk {
-  const walk = new Walk(text, array);
-  walk.run();
-  return { starts: walk.starts, twice: walk.twice };
+export function readStrict(text: string, records?: string): StrictDocument {
+  const reader = new Reader(text, records);
+  const value = reader.read();
+  return { value, fractions: reader.fractions, starts: reader.starts };
 }
 
 /**
@@ -128,3 +282,14 @@ export function positionAt(text: string, file: string, offset: number): Position
   const lineStart = before.lastIndexOf("\n") + 1;
   return { path: file, line: before.split("\n").length, column: offset - lineStart + 1 };
 }
+
+/** A strict read's fault with the line and column it is at, as a refusal states it. */
+export function locatedFault(text: string, error: StrictJSONError): string {
+  const { line, column } = positionAt(text, "", error.offset);
+  return `line ${String(line)}, column ${String(column)}: ${error.message}`;
+}
+
+/** Whether a decoded JSON value is an object: not `null` and not an array. */
+export function isRecord(value: unknown): value is Record<string, unknown> {
+  return typeof value === "object" && value !== null && !Array.isArray(value);
+}

package/src/keyof-comparisons.ts

@@ -10,7 +10,6 @@ import {
   isCaseClause,
   isElementAccessExpression,
   isIdentifier,
-  isParenthesizedExpression,
   isPropertyAccessExpression,
   isSwitchStatement,
   isTypeOperatorNode,
@@ -27,6 +26,7 @@ import { renderPosition } from "./position.ts";
 import { UNANSWERED } from "./query.ts";
 import type { Reference } from "./references.ts";
 import type { ProjectView } from "./session.ts";
+import { parenthesesRemoved } from "./unwrap.ts";
 
 /** The operators that compare their operands for equality. */
 const EQUALITIES: ReadonlySet<SyntaxKind> = new Set([
@@ -44,13 +44,9 @@ interface Comparison {
   readonly other: Expression;
 }
 
-function unwrapped(node: Expression): Expression {
-  return isParenthesizedExpression(node) ? unwrapped(node.expression) : node;
-}
-
 /** The name node an operand's symbol is read at: an identifier, or a property access's name. */
 function nameOf(node: Expression): Node | undefined {
-  const at = unwrapped(node);
+  const at = parenthesesRemoved(node);
   if (isIdentifier(at)) {
     return at;
   }
@@ -132,7 +128,7 @@ export function keyofComparisonReferences<Brand>(
   }
   const named = comparisons.flatMap((one) => {
     const name = nameOf(one.keyed);
-    return name === undefined || isElementAccessExpression(unwrapped(one.other))
+    return name === undefined || isElementAccessExpression(parenthesesRemoved(one.other))
       ? []
       : [{ ...one, name }];
   });

package/src/kinds.ts

@@ -5,14 +5,6 @@ export const KINDS: ReadonlyMap<string, KindRow> = new Map(
   KIND_ROWS.map((one): [string, KindRow] => [one.code, one]),
 );
 
-/**
- * The code of every live issue kind, in ascending order. A severity key names one of
- * them or a family prefix whose range holds one; a key naming a retired code, an
- * unassigned code or a range holding no live kind is an unimplemented key, so every
- * severity a configuration sets is one some analyzer reports under.
- */
-export const LIVE_CODES: readonly string[] = KIND_ROWS.map((one) => one.code);
-
 /** The issue-kind codes whose severity the Contract fixes, in ascending order. */
 export const FIXED_SEVERITY_CODES: readonly string[] = KIND_ROWS.filter((one) => one.fixed).map(
   (one) => one.code,

package/src/manifest.ts

@@ -6,10 +6,12 @@
  */
 
 import type { Host } from "./host.ts";
-import { isAbsolutePath, joinPath, relativePath, resolvePath } from "./paths.ts";
+import { isAbsolutePath, relativePath, resolvePath } from "./paths.ts";
+import { isRecord } from "./json-document.ts";
+import { MANIFEST, manifestAt } from "./fs/manifest.ts";
+import { scriptTokens } from "./text/shell.ts";
 
 /** The manifest's own name. */
-const MANIFEST = "package.json";
 
 /** The three members that name an entry point beside `exports` and `bin`. */
 const LEGACY_MEMBERS = ["main", "module", "types"] as const;
@@ -44,10 +46,6 @@ export interface ManifestEntry {
   readonly dir: string;
 }
 
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return typeof value === "object" && value !== null && !Array.isArray(value);
-}
-
 /**
  * Whether one member's value names a file of this package rather than another
  * package or a URL. A target written with no leading dot is a path too, which is
@@ -60,24 +58,6 @@ function isTarget(value: string, requireDot: boolean): boolean {
   return !requireDot || value.startsWith("./");
 }
 
-/** Where a script's command line splits into tokens: white space and the shell's operators. */
-const SCRIPT_SEPARATORS = /\s+|&&|\|\||;|\|/u;
-
-/** A token written inside one pair of quotes. */
-const QUOTED = /^(["'])(.*)\1$/su;
-
-/**
- * Every token one script's command line holds, each with one pair of enclosing quotes
- * removed. A token holding a wildcard is a pattern rather than a path, and names no
- * entry point.
- */
-export function scriptTokens(command: string): readonly string[] {
-  return command
-    .split(SCRIPT_SEPARATORS)
-    .map((token) => token.replace(QUOTED, "$2"))
-    .filter((token) => token !== "" && !token.includes("*"));
-}
-
 /** One member's spelling below another: `exports` then `exports["."]`. */
 function below(member: string, key: string): string {
   return `${member}[${JSON.stringify(key)}]`;
@@ -111,27 +91,6 @@ function exportTargets(value: unknown, member: string, found: Omit<ManifestEntry
   }
 }
 
-/** The manifest at the target root, decoded, or undefined where there is none to read. */
-function manifestOf(host: Host, targetRoot: string): Record<string, unknown> | undefined {
-  let text: string;
-  try {
-    text = host.readFile(joinPath(targetRoot, MANIFEST));
-  } catch {
-    return undefined;
-  }
-  let value: unknown;
-  try {
-    value = JSON.parse(text);
-  } catch {
-    // A manifest this program cannot read names no entry point, which is the same
-    // answer as an absent one. What a manifest's contents say is not refused here:
-    // the package manager owns that refusal, and an analysis of a tree it rejects
-    // is not the run's subject.
-    return undefined;
-  }
-  return isRecord(value) ? value : undefined;
-}
-
 /** What one manifest declares about where its package is entered. */
 export interface Manifest {
   /**
@@ -158,7 +117,7 @@ export interface Manifest {
  * it and there is one such configuration per project, while there is one manifest.
  */
 export function readManifest(host: Host, targetRoot: string): Manifest {
-  const manifest = manifestOf(host, targetRoot);
+  const manifest = manifestAt(host, targetRoot);
   if (manifest === undefined) {
     return { entries: [], declaresExports: false };
   }