@cplieger/deadset-ts 8.0.0-dev.1 → 8.0.0-dev.11

package/src/symbol-keys.ts

@@ -12,7 +12,6 @@ import {
   isIdentifier,
   isNoSubstitutionTemplateLiteral,
   isNumericLiteral,
-  isParenthesizedExpression,
   isPropertyAccessExpression,
   isSpreadElement,
   isStringLiteral,
@@ -21,6 +20,7 @@ import {
   type Node,
   type SourceFile,
 } from "@typescript/native/ast";
+import { parenthesesRemoved } from "./unwrap.ts";
 import type { Symbol as TSSymbol, Type } from "@typescript/native/sync";
 import type { AliasChains } from "./alias-chain.ts";
 import { nodeKey, type Inventory, type InventorySymbol } from "./inventory.ts";
@@ -52,10 +52,7 @@ interface KeyedUse {
 
 /** The identifier an element access's argument names its key by, where it is a name. */
 export function keyNameOf(argument: Node): Node | undefined {
-  let at = argument;
-  while (isParenthesizedExpression(at)) {
-    at = at.expression;
-  }
+  const at = parenthesesRemoved(argument);
   if (isIdentifier(at)) {
     return at;
   }

package/src/template-field.ts

@@ -13,13 +13,16 @@
  */
 
 import { readComponent } from "./component-files.ts";
-import { ConfigError, type Analysis, type TemplateDelimiters } from "./config.ts";
+import type { ResolvedConfig, TemplateDelimiters } from "./config.ts";
 import type { DetectorInput, Evidence } from "./exempt.ts";
 import type { Host } from "./host.ts";
 import type { SymbolKind } from "./inventory.ts";
 import { memberNames } from "./member-names.ts";
 import { extensionOf, isAbsolutePath, joinPath, normalizePath, relativePath } from "./paths.ts";
 import { isComponentFile, type Position } from "./position.ts";
+import { bytewise } from "./text/compare.ts";
+import { filesBelow } from "./fs/tree.ts";
+import { UsageError } from "./usage.ts";
 
 /** One template, by its path below the target root. */
 interface TemplateFile {
@@ -50,14 +53,6 @@ const READ_BY_MARKUP: ReadonlySet<SymbolKind> = new Set([...READ_BY_A_TEMPLATE,
 /** One identifier, as the grammar of the analyzed language spells one. */
 const IDENTIFIER = /[\p{ID_Start}$_][\p{ID_Continue}$\u200C\u200D]*/uy;
 
-/** Two strings ordered bytewise. */
-function compare(a: string, b: string): number {
-  if (a === b) {
-    return 0;
-  }
-  return a < b ? -1 : 1;
-}
-
 /**
  * Every template under the configured directories, read once for the run, in path
  * order and each file once. A directory is named relative to the target root, and
@@ -66,25 +61,22 @@ function compare(a: string, b: string): number {
  * exemption it was configured for off. A symbolic link to a directory is not
  * followed.
  */
-export function readTemplates(host: Host, targetRoot: string, analysis: Analysis): Templates {
+export function readTemplates(
+  host: Host,
+  targetRoot: string,
+  analysis: ResolvedConfig["analysis"],
+): Templates {
   const files = new Map<string, string>();
   const read = (dir: string): void => {
-    const entries = [...host.readDirectory(joinPath(targetRoot, dir))].sort((a, b) =>
-      compare(a.name, b.name),
-    );
-    for (const entry of entries) {
-      const path = joinPath(dir, entry.name);
-      if (entry.directory) {
-        read(path);
-        continue;
-      }
+    for (const below of filesBelow(host, joinPath(targetRoot, dir), () => true)) {
+      const path = joinPath(dir, below);
       const absolute = joinPath(targetRoot, path);
       if (!files.has(path) && host.kindOf(absolute) === "file") {
         files.set(path, host.readFile(absolute));
       }
     }
   };
-  for (const configured of analysis.templateDirs) {
+  for (const configured of analysis.template_dirs) {
     const dir = normalizePath(configured);
     if (
       isAbsolutePath(dir) ||
@@ -92,19 +84,17 @@ export function readTemplates(host: Host, targetRoot: string, analysis: Analysis
       dir.startsWith("../") ||
       host.kindOf(joinPath(targetRoot, dir)) !== "directory"
     ) {
-      throw new ConfigError(
-        "malformed",
-        "analysis.template_dirs",
+      throw new UsageError(
         `analysis.template_dirs: ${JSON.stringify(configured)} is not a directory below the target root`,
       );
     }
     read(dir);
   }
   return {
-    delimiters: analysis.templateDelimiters,
+    delimiters: analysis.template_delimiters,
     files: [...files]
       .map(([path, text]) => ({ path, text }))
-      .sort((a, b) => compare(a.path, b.path)),
+      .sort((a, b) => bytewise(a.path, b.path)),
   };
 }
 

package/src/test-support.ts

@@ -6,7 +6,7 @@
  * test code.
  */
 
-import { CONVENTION_ROWS } from "./convention-rows.ts";
+import { CONVENTION_ROWS, TEST_LIBRARIES, TEST_LIBRARY_SCOPES } from "./convention-rows.ts";
 import { packageOfSpecifier } from "./dependencies.ts";
 import type { InventorySymbol } from "./inventory.ts";
 import type { Reference } from "./references.ts";
@@ -17,17 +17,13 @@ const SKIP_ROOT = "type-error";
 
 /**
  * The test runners and test libraries an import of which is test evidence: each runner a
- * convention row reads test files for, the platform's own runner, and the libraries below.
+ * convention row reads test files for, and the convention table's test libraries.
  */
 const TEST_PACKAGES: ReadonlySet<string> = new Set([
   ...CONVENTION_ROWS.filter((row) => row.testFiles !== undefined).map((row) => row.package),
-  "node:test",
-  "@playwright/test",
+  ...TEST_LIBRARIES,
 ]);
 
-/** The scopes every package of which is a test library. */
-const TEST_SCOPES = ["@testing-library/"] as const;
-
 /**
  * The Node.js built-in modules a bare specifier names, which are no package. The set is
  * closed: Node.js adds a new built-in under the `node:` scheme alone
@@ -94,7 +90,7 @@ function namesTestPackage(specifier: string): boolean {
   const name = specifier.startsWith("node:") ? specifier : packageOfSpecifier(specifier);
   return (
     name !== undefined &&
-    (TEST_PACKAGES.has(name) || TEST_SCOPES.some((scope) => name.startsWith(scope)))
+    (TEST_PACKAGES.has(name) || TEST_LIBRARY_SCOPES.some((scope) => name.startsWith(scope)))
   );
 }
 
@@ -134,13 +130,21 @@ function evidenceReader(
   };
 }
 
+/** The files only tests reach, split by whether each carries test evidence of its own. */
+interface TestReached {
+  /** The test-support files: test code. */
+  readonly support: ReadonlySet<string>;
+  /** The files only tests reach that are no test-support file: production code only tests use. */
+  readonly testUsed: ReadonlySet<string>;
+}
+
 /**
  * The files of one project that are test-support code, below the target root: the
  * largest set of files a test file reaches, none of them a test file or holding a root,
  * each carrying test evidence of its own, whose every user outside the set is a test
- * file. A root has a caller outside the reference graph: a runtime, a tool, a
- * configuration, or a consumer of a library's published API. `testFiles` are the files
- * the test-file rules classified.
+ * file; and the files only tests reach that are not among them. A root has a caller
+ * outside the reference graph: a runtime, a tool, a configuration, or a consumer of a
+ * library's published API. `testFiles` are the files the test-file rules classified.
  */
 export function testSupportFiles(
   symbols: readonly InventorySymbol[],
@@ -148,7 +152,7 @@ export function testSupportFiles(
   roots: readonly Root[],
   testFiles: readonly string[],
   evidence: TestEvidence,
-): ReadonlySet<string> {
+): TestReached {
   const fileOf = new Map(symbols.map((symbol) => [symbol.id, symbol.position.path]));
   const users = new Map<string, Set<string>>();
   const uses = new Map<string, Set<string>>();
@@ -203,7 +207,7 @@ export function testSupportFiles(
   const support = withoutOutsideUsers(
     new Set([...onlyTests].filter((path) => carries(onlyTests, path))),
   );
-  return support;
+  return { support, testUsed: new Set([...onlyTests].filter((path) => !support.has(path))) };
 }
 
 /** The references with every one a test-support file makes counted as a test reference. */

package/src/text/compare.ts

@@ -0,0 +1,27 @@
+/**
+ * Two strings in the order of their UTF-8 bytes, the order every set of a run is read in.
+ * That is code point order, which UTF-16 code unit order (`<` on strings) breaks above
+ * U+FFFF: a surrogate unit is below U+E000 while the code point it encodes is above U+FFFF.
+ */
+export function bytewise(a: string, b: string): number {
+  if (a === b) {
+    return 0;
+  }
+  const length = Math.min(a.length, b.length);
+  for (let at = 0; at < length; at += 1) {
+    const x = a.charCodeAt(at);
+    const y = b.charCodeAt(at);
+    if (x !== y) {
+      return ranked(x) < ranked(y) ? -1 : 1;
+    }
+  }
+  return a.length < b.length ? -1 : 1;
+}
+
+/** One UTF-16 unit moved so that a surrogate ranks above every unit of U+E000 to U+FFFF. */
+function ranked(unit: number): number {
+  if (unit >= 0xe000) {
+    return unit - 0x800;
+  }
+  return unit >= 0xd800 ? unit + 0x2000 : unit;
+}

package/src/text/glob.ts

@@ -0,0 +1,210 @@
+/**
+ * Glob patterns over paths in two forms. The configured form (the configuration, convention
+ * rows, bundler entries, workspace member patterns) has `*` and `?` within a segment, `**`
+ * across segments and brace lists. A `.gitignore` line has git's form: bracket expressions
+ * and backslash escapes, no brace lists (https://git-scm.com/docs/gitignore#_pattern_format).
+ * A configured root is not a glob: it names a symbol reference, and is read where it is used.
+ */
+
+type GlobForm = "configured" | "gitignore";
+
+/**
+ * One character of a pattern as the expression syntax reads it literally. The set escaped
+ * is closed: under the unicode flag an escape of any other character is refused outright.
+ */
+function quoted(character: string): string {
+  return /[.*+?^${}()|[\]\\/]/u.test(character) ? `\\${character}` : character;
+}
+
+/**
+ * The ASCII ranges each POSIX class a bracket expression may name holds, as git's own
+ * character table reads them, each range written as its first and last character.
+ */
+const CLASSES: ReadonlyMap<string, string> = new Map([
+  ["alnum", "09AZaz"],
+  ["alpha", "AZaz"],
+  ["blank", "\t\t  "],
+  ["cntrl", "\0\x1f\x7f\x7f"],
+  ["digit", "09"],
+  ["graph", "!~"],
+  ["lower", "az"],
+  ["print", " ~"],
+  ["punct", "!/:@[`{~"],
+  ["space", "\t\n\r\r  "],
+  ["upper", "AZ"],
+  ["xdigit", "09AFaf"],
+]);
+
+/** What a pattern git cannot read matches: nothing, as git aborts the whole match. */
+const NOTHING = "(?!)";
+
+/** One code point as a member of an expression class. */
+function member(point: number): string {
+  return `\\u{${point.toString(16)}}`;
+}
+
+/**
+ * The class a bracket expression opening at `open` denotes, and the index past its `]`,
+ * read as git's wildmatch reads it: a leading `!` or `^` negates it, a `]` first is a
+ * member, `\` escapes one character, `x-y` is a range (one whose `y` is below `x` holds
+ * `x` alone) and `[:name:]` a POSIX class. An unclosed bracket or an unknown class name
+ * matches nothing. Neither form matches the solidus.
+ */
+function bracket(pattern: string, open: number): { source: string; end: number } {
+  let at = open + 1;
+  const negated = pattern[at] === "!" || pattern[at] === "^";
+  if (negated) {
+    at += 1;
+  }
+  const next = (): number | undefined => {
+    const point = pattern.codePointAt(at);
+    at += point !== undefined && point > 0xffff ? 2 : 1;
+    return point;
+  };
+  let members = "";
+  let low: number | undefined;
+  for (let first = true; ; first = false) {
+    let point = next();
+    if (point === undefined) {
+      return { source: NOTHING, end: pattern.length };
+    }
+    if (point === 0x5d && !first) {
+      return { source: negated ? `[^/${members}]` : `(?!/)[${members}]`, end: at };
+    }
+    if (point === 0x2d && low !== undefined && at < pattern.length && pattern[at] !== "]") {
+      let high = next();
+      if (high === 0x5c) {
+        high = next();
+      }
+      if (high === undefined) {
+        return { source: NOTHING, end: pattern.length };
+      }
+      members += high >= low ? `${member(low)}-${member(high)}` : "";
+      low = undefined;
+      continue;
+    }
+    if (point === 0x5b && pattern[at] === ":") {
+      const close = pattern.indexOf("]", at + 1);
+      if (close < 0) {
+        return { source: NOTHING, end: pattern.length };
+      }
+      if (close > at + 1 && pattern[close - 1] === ":") {
+        const ranges = CLASSES.get(pattern.slice(at + 1, close - 1));
+        if (ranges === undefined) {
+          return { source: NOTHING, end: pattern.length };
+        }
+        for (let one = 0; one < ranges.length; one += 2) {
+          members += `${member(ranges.charCodeAt(one))}-${member(ranges.charCodeAt(one + 1))}`;
+        }
+        low = undefined;
+        at = close + 1;
+        continue;
+      }
+    }
+    if (point === 0x5c) {
+      point = next();
+      if (point === undefined) {
+        return { source: NOTHING, end: pattern.length };
+      }
+    }
+    members += member(point);
+    low = point;
+  }
+}
+
+/** The expression source of one pattern with no brace list. */
+function source(pattern: string, form: GlobForm): string {
+  let text = "";
+  let at = 0;
+  while (at < pattern.length) {
+    if (pattern.startsWith("**/", at)) {
+      text += "(?:[^/]*/)*";
+      at += 3;
+      continue;
+    }
+    if (pattern.startsWith("**", at)) {
+      text += ".*";
+      at += 2;
+      continue;
+    }
+    const character = pattern[at] ?? "";
+    if (form === "gitignore" && character === "[") {
+      const read = bracket(pattern, at);
+      text += read.source;
+      at = read.end;
+      continue;
+    }
+    if (form === "gitignore" && character === "\\" && at + 1 < pattern.length) {
+      text += quoted(pattern[at + 1] ?? "");
+      at += 2;
+      continue;
+    }
+    at += 1;
+    text += character === "*" ? "[^/]*" : character === "?" ? "[^/]" : quoted(character);
+  }
+  return text;
+}
+
+/** A pattern with every brace list expanded into its alternatives; a lone `{` stands for itself. */
+export function braceExpanded(pattern: string): readonly string[] {
+  const open = pattern.indexOf("{");
+  const close = open < 0 ? -1 : pattern.indexOf("}", open);
+  if (close < 0) {
+    return [pattern];
+  }
+  const before = pattern.slice(0, open);
+  const after = pattern.slice(close + 1);
+  return pattern
+    .slice(open + 1, close)
+    .split(",")
+    .flatMap((member) => braceExpanded(before + member + after));
+}
+
+/** The expression one whole-path pattern of the configured form denotes. */
+export function globExpression(pattern: string): RegExp {
+  const alternatives = braceExpanded(pattern).map((one) => source(one, "configured"));
+  return new RegExp(`^(?:${alternatives.join("|")})$`, "u");
+}
+
+/** The expression one `.gitignore` pattern denotes over a path below its file's directory. */
+export function gitignoreExpression(pattern: string): RegExp {
+  return new RegExp(`^${source(pattern, "gitignore")}$`, "u");
+}
+
+const SEGMENTS = new Map<string, RegExp>();
+
+/**
+ * Whether one directory name matches one segment of a workspace's member pattern, its brace
+ * lists already expanded. Neither `*` nor `?` matches a leading dot, as npm's workspaces read
+ * them: https://docs.npmjs.com/cli/using-npm/workspaces
+ */
+export function segmentMatches(segment: string, name: string): boolean {
+  if (name.startsWith(".") && !segment.startsWith(".")) {
+    return false;
+  }
+  let expression = SEGMENTS.get(segment);
+  if (expression === undefined) {
+    expression = globExpression(segment);
+    SEGMENTS.set(segment, expression);
+  }
+  return expression.test(name);
+}
+
+/**
+ * Whether one path's segments match a member pattern's, `**` standing for any run of segments
+ * that starts with no dot.
+ */
+export function pathMatches(pattern: readonly string[], path: readonly string[]): boolean {
+  const [head, ...rest] = pattern;
+  if (head === undefined) {
+    return path.length === 0;
+  }
+  if (head === "**") {
+    return (
+      pathMatches(rest, path) ||
+      (path.length > 0 && !(path[0] ?? "").startsWith(".") && pathMatches(pattern, path.slice(1)))
+    );
+  }
+  const [name, ...below] = path;
+  return name !== undefined && segmentMatches(head, name) && pathMatches(rest, below);
+}