@cplieger/deadset-ts 7.2.0-dev.4 → 8.0.0-dev.2

package/dist/src/suppress-file.js

@@ -8,7 +8,7 @@ import { jsonChunks } from "./json-chunks.js";
 import { joinPath } from "./paths.js";
 import { positionAt, walkDocument } from "./json-document.js";
 import { declarationKey } from "./ref.js";
-import { CODE_FORM, SUPPRESSION_WITHOUT_REASON, SuppressionError, UNSCOPED_ENTRY, blankReason, isEntryPath, isSymbolRef, siteText, } from "./suppress.js";
+import { CODE_FORM, SUPPRESSION_WITHOUT_REASON, SuppressionError, UNSCOPED_ENTRY, blankReason, isEntryPath, isPartKind, isSymbolRef, siteText, } from "./suppress.js";
 /** The name and the location the grammar fixes for the ignore file. */
 export const IGNORE_FILE = "deadset-ignore.json";
 /** The name and the location the grammar fixes for the baseline. */
@@ -107,12 +107,20 @@ function readRecord(value, site, byReference, shape) {
     if (refusals.length > 0) {
         return { records: [], refusals };
     }
-    const named = byReference.get(declarationKey(symbol, written.path)) ?? [];
+    const named = byReference.get(declarationKey(symbol, written.path)) ??
+        (isPartKind(code)
+            ? byReference.get(declarationKey(parameterHolder(symbol), written.path))
+            : undefined) ??
+        [];
     if (named.length === 0) {
         return { records: [{ ...written, bound: "" }], refusals: [] };
     }
     return { records: named.map((one) => ({ ...written, bound: one.id })), refusals: [] };
 }
+/** The reference of the declaration a parameter's reference names it under, or `ref` itself. */
+function parameterHolder(ref) {
+    return ref.endsWith(")") ? ref.slice(0, ref.lastIndexOf("(")) : ref;
+}
 function byReferenceOf(symbols) {
     const byReference = new Map();
     for (const symbol of symbols) {

package/dist/src/suppress-inline.js

@@ -4,8 +4,10 @@
  * below it, or on its own line where it trails a token there.
  */
 import { isConstructorDeclaration, SyntaxKind, } from "@typescript/native/ast";
+import { importBindings } from "./import-bindings.js";
 import { isParameterProperty, nodeKey } from "./inventory.js";
 import { byPosition, positionKey, renderPosition } from "./position.js";
+import { importRef } from "./ref.js";
 import { signatureOf } from "./signatures.js";
 import { isPartKind, SUPPRESSION_WITHOUT_REASON, SuppressionError, siteText, } from "./suppress.js";
 /**
@@ -144,7 +146,7 @@ function bindingKey(one) {
  * function also begins, for a directive, on the line of each of its parameters, and a
  * class, for a part kind, on the lines of its constructor and its constructor's parameters.
  */
-function declarationLines(file, held, symbols) {
+function declarationLines(file, held, symbols, targetRoot) {
     const below = new Map();
     const add = (offset, one) => {
         const line = file.getLineAndCharacterOfPosition(tokenStart(file.text, offset)).line + 1;
@@ -186,6 +188,20 @@ function declarationLines(file, held, symbols) {
         node.forEachChild(visit);
     };
     file.forEachChild(visit);
+    // An import binding is a subject of its own, bound on its line as a declaration is.
+    const fileId = held.declarations.get(nodeKey(file, file));
+    const moduleRef = held.symbols.find((symbol) => symbol.id === fileId)?.ref ?? "";
+    for (const name of moduleRef === "" ? [] : importBindings(file)) {
+        const position = renderPosition(file, targetRoot, name.getStart());
+        const one = { id: positionKey(position), ref: importRef(moduleRef, name.text), position };
+        let statement = name;
+        while (statement.parent.kind !== SyntaxKind.SourceFile) {
+            statement = statement.parent;
+        }
+        for (const at of [statement.pos, name.getStart()]) {
+            add(at, { declared: one, part: one });
+        }
+    }
     return below;
 }
 /**
@@ -210,7 +226,7 @@ export function inlineDirectives(project, held, targetRoot) {
         if (comments.length === 0) {
             continue;
         }
-        const below = declarationLines(file, held, symbols);
+        const below = declarationLines(file, held, symbols, targetRoot);
         for (const comment of comments) {
             const site = renderPosition(file, targetRoot, comment.offset);
             const target = trails(file, comment.offset) ? site.line : site.line + 1;

package/dist/src/suppress.js

@@ -57,6 +57,7 @@ export const GO_REF_EXPRESSIONS = [
     `^go://${GO_PATH}#${GO_IDENT}$`,
     `^go://${GO_PATH}#${GO_IDENT}(?:\\.${GO_IDENT})+$`,
     `^go://${GO_PATH}#${GO_IDENT}(?:\\.${GO_IDENT})?\\[${GO_IDENT}\\]$`,
+    `^go://${GO_PATH}#(?:${GO_IDENT}(?:\\.${GO_IDENT})?)?\\(${GO_IDENT}\\)$`,
     `^go://${GO_PATH}#${GO_FILE}:file$`,
     `^go://${GO_PATH}#${GO_PATH}(?:@${GO_VERSION})?:require$`,
     `^go://${GO_PATH}#${GO_PATH}(?:@${GO_VERSION})?:replace$`,
@@ -144,10 +145,11 @@ function claimKey(finding) {
 }
 /**
  * Whether one record names one finding. A record reaches a finding in two ways: it bound
- * the declaration at the finding's position, or it names the finding's reference and the
- * file the finding is reported in, each exactly. The second is how an entry copied from a
- * finding about a part of a declaration reaches the part, and the only way any record
- * reaches a dependency row.
+ * the declaration at the finding's position, or it names the finding's reference, or the
+ * reference of the declaration holding a part that has one of its own, and the file the
+ * finding is reported in, each exactly. The second is how an entry copied from a finding
+ * about a part of a declaration reaches the part, and the only way any record reaches a
+ * dependency row.
  */
 export function pairs(record, finding) {
     if (record.code !== finding.code) {
@@ -164,7 +166,8 @@ export function pairs(record, finding) {
     if (record.bound !== "" && record.bound === positionKey(finding.position)) {
         return true;
     }
-    return record.symbol === finding.symbol.ref && record.path === finding.position.path;
+    return ((record.symbol === finding.symbol.ref || record.symbol === finding.symbol.holder) &&
+        record.path === finding.position.path);
 }
 /**
  * Decides every record against `would`, the findings the run would produce were no record

package/dist/src/sweep.js

@@ -70,16 +70,30 @@ export function sweep(graph, input) {
     });
     return { liveUnder: live, candidates };
 }
+/**
+ * The directory a test runner reads a manual mock from, whose exports it puts in place of
+ * the module's: https://jestjs.io/docs/manual-mocks
+ */
+const MANUAL_MOCKS = "__mocks__";
+/** Whether a test runner calls or reads one export of a test file: a function, or any export of a manual mock. */
+export function runnerCalls(symbol) {
+    return symbol.kind === "function" || symbol.position.path.split("/").includes(MANUAL_MOCKS);
+}
 /**
  * Per declaration of the graph, whether the run that counts test references reaches it.
- * That run's roots are the graph's own and each test file, being the file's top level
- * and every declaration it exports, which a test runner may call; `held` seeds it as a
- * mark or an exemption seeds a sweep.
+ * That run's roots are the graph's own and, of each test file, its top level and every
+ * function it exports, which a test runner may call, and every export of a manual mock,
+ * which the runner reads; any other export of a test file, and test-support code, which
+ * runs where a test imports it, are judged as any file's are.
+ * `held` seeds it as a mark or an exemption seeds a sweep.
  */
 export function reachedWithTheTests(graph, held) {
     const tests = graph.symbols.flatMap((symbol, at) => {
-        const top = symbol.kind === "file" || graph.symbols[graph.parent[at] ?? OUTSIDE]?.kind === "file";
-        return graph.test[at] === true && top && (symbol.kind === "file" || symbol.exported)
+        const exported = symbol.exported && graph.symbols[graph.parent[at] ?? OUTSIDE]?.kind === "file";
+        const called = exported && runnerCalls(symbol);
+        return graph.test[at] === true &&
+            graph.support[at] !== true &&
+            (symbol.kind === "file" || called)
             ? [{ at, kind: "test-runner" }]
             : [];
     });
@@ -162,10 +176,11 @@ function reachable(graph, held, mode) {
 }
 /**
  * Admits every test declaration whose set of referenced production declarations is
- * non-empty and wholly dead, and returns which it admitted. The set is read from every
- * reference the test makes, which a production sweep does not count. A test-support
- * declaration that a test referencing a live target also references is a live target of
- * every test referencing it. A marked or exempt test is never admitted.
+ * non-empty and wholly dead, and returns which it admitted. An ambient declaration describes
+ * code the target does not implement, so it is no production declaration here. The set is
+ * read from every reference the test makes, which a production sweep does not count. A
+ * test-support declaration a test referencing a live target also references is a live
+ * target of every test referencing it. A marked or exempt test is never admitted.
  */
 function admitTestsOfDeadCode(graph, dead, held) {
     const testCode = (at) => graph.test[at] === true || graph.support[at] === true;
@@ -174,7 +189,9 @@ function admitTestsOfDeadCode(graph, dead, held) {
         let live = 0;
         if (testCode(at) && graph.subject[at] === true && held[at] !== true) {
             for (const edge of graph.out[at] ?? []) {
-                if (testCode(edge.to) || graph.subject[edge.to] !== true) {
+                if (testCode(edge.to) ||
+                    graph.subject[edge.to] !== true ||
+                    graph.ambient[edge.to] === true) {
                     continue;
                 }
                 targets += 1;

package/dist/src/symbol-keys.js

@@ -2,9 +2,12 @@
  * The members a unique symbol keys, used through element accesses. `value[key]`, where
  * `key` is a constant of a `unique symbol` type, reads the member of the receiver's type
  * whose computed name is that same constant, and a store through the access writes it.
- * No name node resolves to such a member: the key's name resolves to the constant.
+ * No name node resolves to such a member: the key's name resolves to the constant. An
+ * iteration reads the member its well-known iteration symbol keys.
  */
-import { isComputedPropertyName, isIdentifier, isNoSubstitutionTemplateLiteral, isNumericLiteral, isParenthesizedExpression, isPropertyAccessExpression, isStringLiteral, } from "@typescript/native/ast";
+import { isComputedPropertyName, isForOfStatement, isIdentifier, isNoSubstitutionTemplateLiteral, isNumericLiteral, isParenthesizedExpression, isPropertyAccessExpression, isSpreadElement, isStringLiteral, } from "@typescript/native/ast";
+import { nodeKey } from "./inventory.js";
+import { renderPosition } from "./position.js";
 import { isAnswered } from "./query.js";
 /** The identifier an element access's argument names its key by, where it is a name. */
 export function keyNameOf(argument) {
@@ -112,3 +115,101 @@ export function keyedUses(project, chains, resolved, properties, cap) {
         return ids.length === 0 ? [] : [{ access: one.access, ids: [...new Set(ids)] }];
     });
 }
+/** The member name `[Symbol.<name>]` spells, where a computed name spells one. */
+function wellKnownName(name) {
+    if (name === undefined || !isComputedPropertyName(name)) {
+        return undefined;
+    }
+    const key = name.expression;
+    return isPropertyAccessExpression(key) &&
+        isIdentifier(key.expression) &&
+        key.expression.text === "Symbol" &&
+        isIdentifier(key.name)
+        ? key.name.text
+        : undefined;
+}
+/**
+ * The references the iterations of one project's own files make to the iteration members
+ * of the values they iterate: a `for…of` statement and a spread element read
+ * `[Symbol.iterator]`, and a `for await…of` statement reads `[Symbol.asyncIterator]` and,
+ * which it falls back to, `[Symbol.iterator]`. Each is made by the declaration holding it.
+ */
+export function iterationReferences(project, held, chains, root, testFiles) {
+    const queries = project.queries;
+    const ownPaths = project.ownPaths();
+    const iterated = [];
+    for (const file of project.ownSourceFiles()) {
+        const fileId = held.declarations.get(nodeKey(file, file));
+        if (fileId === undefined) {
+            continue;
+        }
+        const visit = (node, from) => {
+            const holder = held.declarations.get(nodeKey(file, node)) ?? from;
+            if (isForOfStatement(node)) {
+                const protocols = node.awaitModifier === undefined ? ["iterator"] : ["asyncIterator", "iterator"];
+                iterated.push({ file, from: holder, operand: node.expression, protocols });
+            }
+            else if (isSpreadElement(node)) {
+                iterated.push({ file, from: holder, operand: node.expression, protocols: ["iterator"] });
+            }
+            node.forEachChild((child) => {
+                visit(child, holder);
+            });
+        };
+        file.forEachChild((child) => {
+            visit(child, fileId);
+        });
+    }
+    if (iterated.length === 0) {
+        return [];
+    }
+    const types = queries.typesAt(iterated.map((one) => one.operand));
+    const members = new Map();
+    const membersOf = (type) => {
+        const known = members.get(type.id);
+        if (known !== undefined) {
+            return known;
+        }
+        const keyed = [];
+        const properties = queries.propertiesOf(type);
+        for (const property of isAnswered(properties) ? properties : []) {
+            for (const handle of property.declarations) {
+                const node = ownPaths.has(handle.path) ? project.declarationAt(handle)?.node : undefined;
+                const name = wellKnownName(node?.name);
+                if (name !== undefined) {
+                    keyed.push({ name, ids: chains.declarationsOf(property) });
+                    break;
+                }
+            }
+        }
+        members.set(type.id, keyed);
+        return keyed;
+    };
+    const found = [];
+    iterated.forEach((one, index) => {
+        const type = types[index];
+        if (type === undefined || !isAnswered(type)) {
+            return;
+        }
+        const parts = type.isUnionType() || type.isIntersectionType() ? queries.constituents(type) : [type];
+        const position = renderPosition(one.file, root, one.operand.getStart());
+        for (const part of isAnswered(parts) ? parts : []) {
+            for (const member of membersOf(part)) {
+                if (!one.protocols.includes(member.name)) {
+                    continue;
+                }
+                for (const to of member.ids) {
+                    found.push({
+                        from: one.from,
+                        to,
+                        position,
+                        use: "read",
+                        resolution: "keyed",
+                        test: testFiles.has(position.path),
+                    });
+                }
+            }
+        }
+    });
+    return found;
+}

package/dist/src/test-support.js

@@ -1,19 +1,113 @@
 /**
- * Test-support code: the files only tests reach. A test reaches each one through a chain
- * of references, and every reference to a declaration of one, an import for its effects
- * included, is written in a test file or in another such file, so it is judged with the
- * tests: what it references is referenced by test code.
+ * Test-support code: the files only tests reach that carry test evidence of their own. A
+ * test reaches each one through a chain of references, and every reference to a
+ * declaration of one, an import for its effects included, is written in a test file or in
+ * another such file, so it is judged with the tests: what it references is referenced by
+ * test code.
  */
+import { CONVENTION_ROWS, TEST_LIBRARIES, TEST_LIBRARY_SCOPES } from "./convention-rows.js";
+import { packageOfSpecifier } from "./dependencies.js";
 /** The root kind that never takes a file out of test-support code: the skip only withholds. */
 const SKIP_ROOT = "type-error";
+/**
+ * The test runners and test libraries an import of which is test evidence: each runner a
+ * convention row reads test files for, and the convention table's test libraries.
+ */
+const TEST_PACKAGES = new Set([
+    ...CONVENTION_ROWS.filter((row) => row.testFiles !== undefined).map((row) => row.package),
+    ...TEST_LIBRARIES,
+]);
+/**
+ * The Node.js built-in modules a bare specifier names, which are no package. The set is
+ * closed: Node.js adds a new built-in under the `node:` scheme alone
+ * (https://nodejs.org/api/modules.html#built-in-modules-with-mandatory-node-prefix).
+ */
+const NODE_BUILTINS = new Set([
+    "assert",
+    "async_hooks",
+    "buffer",
+    "child_process",
+    "cluster",
+    "console",
+    "constants",
+    "crypto",
+    "dgram",
+    "diagnostics_channel",
+    "dns",
+    "domain",
+    "events",
+    "fs",
+    "http",
+    "http2",
+    "https",
+    "inspector",
+    "module",
+    "net",
+    "os",
+    "path",
+    "perf_hooks",
+    "process",
+    "punycode",
+    "querystring",
+    "readline",
+    "repl",
+    "stream",
+    "string_decoder",
+    "sys",
+    "timers",
+    "tls",
+    "trace_events",
+    "tty",
+    "url",
+    "util",
+    "v8",
+    "vm",
+    "wasi",
+    "worker_threads",
+    "zlib",
+]);
+/** Whether a specifier names a test runner or a test library. */
+function namesTestPackage(specifier) {
+    const name = specifier.startsWith("node:") ? specifier : packageOfSpecifier(specifier);
+    return (name !== undefined &&
+        (TEST_PACKAGES.has(name) || TEST_LIBRARY_SCOPES.some((scope) => name.startsWith(scope))));
+}
+/**
+ * Whether a file carries test evidence: an import of a test runner or a test library, or
+ * package imports, Node built-ins aside, that are all devDependencies no file imports
+ * outside the test files and `onlyTests`, the files only tests reach.
+ */
+function evidenceReader(tests, evidence) {
+    const importers = new Map();
+    for (const [path, specifiers] of evidence.imports) {
+        for (const specifier of specifiers) {
+            const name = packageOfSpecifier(specifier);
+            if (name !== undefined) {
+                importers.set(name, [...(importers.get(name) ?? []), path]);
+            }
+        }
+    }
+    return (onlyTests, path) => {
+        const specifiers = evidence.imports.get(path) ?? [];
+        if (specifiers.some(namesTestPackage)) {
+            return true;
+        }
+        const names = specifiers.flatMap((one) => packageOfSpecifier(one) ?? []);
+        const packages = names.filter((name) => !NODE_BUILTINS.has(name));
+        return (packages.length > 0 &&
+            packages.every((name) => evidence.devDependency(path, name) &&
+                (importers.get(name) ?? []).every((one) => tests.has(one) || onlyTests.has(one))));
+    };
+}
 /**
  * The files of one project that are test-support code, below the target root: the
  * largest set of files a test file reaches, none of them a test file or holding a root,
- * whose every user outside the set is a test file. A root has a caller outside the
- * reference graph: a runtime, a tool, a configuration, or a consumer of a library's
- * published API. `testFiles` are the files the test-file rules classified.
+ * each carrying test evidence of its own, whose every user outside the set is a test
+ * file; and the files only tests reach that are not among them. A root has a caller
+ * outside the reference graph: a runtime, a tool, a configuration, or a consumer of a
+ * library's published API. `testFiles` are the files the test-file rules classified.
  */
-export function testSupportFiles(symbols, references, roots, testFiles) {
+export function testSupportFiles(symbols, references, roots, testFiles, evidence) {
     const fileOf = new Map(symbols.map((symbol) => [symbol.id, symbol.position.path]));
     const users = new Map();
     const uses = new Map();
@@ -47,18 +141,25 @@ export function testSupportFiles(symbols, references, roots, testFiles) {
             }
         }
     }
-    const support = new Set([...reached].filter((path) => !rooted.has(path)));
-    for (let changed = true; changed;) {
-        changed = false;
-        for (const path of support) {
-            const from = users.get(path) ?? new Set();
-            if (![...from].every((one) => tests.has(one) || support.has(one))) {
-                support.delete(path);
-                changed = true;
+    const withoutOutsideUsers = (files) => {
+        for (let changed = true; changed;) {
+            changed = false;
+            for (const path of files) {
+                const from = users.get(path) ?? new Set();
+                if (![...from].every((one) => tests.has(one) || files.has(one))) {
+                    files.delete(path);
+                    changed = true;
+                }
             }
         }
-    }
-    return support;
+        return files;
+    };
+    // Evidence reads the files only tests reach, evidence or none, so it is fixed before the
+    // files without evidence leave the set.
+    const onlyTests = withoutOutsideUsers(new Set([...reached].filter((path) => !rooted.has(path))));
+    const carries = evidenceReader(tests, evidence);
+    const support = withoutOutsideUsers(new Set([...onlyTests].filter((path) => carries(onlyTests, path))));
+    return { support, testUsed: new Set([...onlyTests].filter((path) => !support.has(path))) };
 }
 /** The references with every one a test-support file makes counted as a test reference. */
 export function supportReferences(references, support) {

package/dist/src/type-errors.js

@@ -5,11 +5,12 @@
  * which only ever withholds a finding. `projectErrors` decides, before any of these, which
  * errors the compiler places in no file leave the project unloaded.
  */
-import { isClassDeclaration, isNoSubstitutionTemplateLiteral, isPropertyAccessExpression, isStringLiteral, } from "@typescript/native/ast";
+import { isClassDeclaration, isFunctionLikeDeclaration, isNoSubstitutionTemplateLiteral, isPropertyAccessExpression, isStringLiteral, } from "@typescript/native/ast";
 import { packageOfSpecifier } from "./dependencies.js";
 import { nodeKey } from "./inventory.js";
 import { dirnamePath, isAbsolutePath, joinPath, relativePath, resolvePath } from "./paths.js";
 import { isAnswered } from "./query.js";
+import { findWorkspace } from "./workspace.js";
 /** The compiler's codes for an import whose module it cannot find. */
 const MODULE_NOT_FOUND = new Set([2307, 2792]);
 const MANIFEST = "package.json";
@@ -163,20 +164,36 @@ function expectedModule(context, importer, specifier) {
     const manifest = name === undefined
         ? undefined
         : declaringManifest(host, dirnamePath(importer), targetRoot, name);
-    if (manifest === undefined) {
+    // No run requires a nested package that is no workspace member to be installed.
+    if (manifest === undefined ||
+        (dirnamePath(manifest) !== targetRoot && !context.member(manifest))) {
         return undefined;
     }
     const where = relativePath(targetRoot, manifest) ?? manifest;
     return `a dependency ${where} declares that is not installed: run the package manager's install`;
 }
 /**
- * The unit a type error at one offset skips: the class member holding it where a
- * top-level class does, else the top-level statement.
+ * The unit a type error at one offset skips: the innermost function holding it, else the
+ * class member holding it where a top-level class does, else the top-level statement.
  */
 function unitAt(file, offset) {
     const statement = file.statements.find((one) => one.pos <= offset && offset < one.end);
-    if (statement === undefined || !isClassDeclaration(statement)) {
-        return statement;
+    if (statement === undefined) {
+        return undefined;
+    }
+    let innermost;
+    const visit = (node) => {
+        if (offset < node.getStart() || offset >= node.end) {
+            return;
+        }
+        if (isFunctionLikeDeclaration(node)) {
+            innermost = node;
+        }
+        node.forEachChild(visit);
+    };
+    visit(statement);
+    if (innermost !== undefined || !isClassDeclaration(statement)) {
+        return innermost ?? statement;
     }
     return statement.members.find((one) => one.pos <= offset && offset < one.end) ?? statement;
 }
@@ -190,7 +207,17 @@ function messageOf(text, targetRoot) {
  * is no error here, and one in a file that is not the project's own is that file's
  * package's to answer for.
  */
-export function readErrors(project, errors, context) {
+export function readErrors(project, errors, where) {
+    let workspace = null;
+    const context = {
+        ...where,
+        member: (manifest) => {
+            if (workspace === null) {
+                workspace = findWorkspace(where.host, where.targetRoot, () => undefined);
+            }
+            return workspace?.memberOf(manifest) !== undefined;
+        },
+    };
     const files = new Map(project.ownSourceFiles().map((file) => [file.fileName, file]));
     const missing = [];
     const skips = [];