@coworker-jp/aidr 0.1.298 → 0.1.299

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@coworker-jp/aidr",
-  "version": "0.1.298",
+  "version": "0.1.299",
   "description": "AIDR setup CLI - installs ai-scanner hooks for 19+ AI coding agents",
   "type": "module",
   "bin": {

package/src/merge.mjs

@@ -150,6 +150,73 @@ export function buildCursorHooksJson(scope = "project", absHome = "") {
 }
 
 // Windsurf hooks.json — flat entries, one command per event (no matcher).
+//
+// NO `timeout` HERE, AND THAT IS DELIBERATE (#1896). Windsurf's hook entry
+// schema has no such field: the documented entry keys are `command`,
+// `powershell`, `show_output` and `working_directory`, and the page says
+// nothing about any time limit at all (docs.windsurf.com/windsurf/cascade/hooks
+// → docs.devin.ai/desktop/cascade/hooks, read 2026-08-25). The other four
+// agents each declare one because their schemas accept it; Windsurf cannot,
+// so this is a DECLARED inequality rather than an oversight — which is the
+// whole reason this comment exists. Emitting an unknown key would not buy a
+// cap and could be rejected by a future schema validation.
+//
+// What bounds a Windsurf hook instead: the in-script `run_scanner` cap
+// (`AI_SCANNER_HOOK_TIMEOUT`, default 30s) plus `ensure_scanner.sh`'s
+// `flock -w 120`. Those are OUR caps, so they hold on every editor — but
+// there is no second, editor-side net here the way there is elsewhere.
+// `tests/merge-hooks-json.test.mjs` pins both directions of that statement.
+//
+// NO `powershell` HERE EITHER, AND THAT IS A DECLARED INEQUALITY (#1907) —
+// it is NOT a claim that Windows is covered.
+//
+// What the vendor actually documents (docs.windsurf.com/windsurf/cascade/hooks
+// → docs.devin.ai/desktop/cascade/hooks, read 2026-08-25, quoted verbatim):
+//
+//   command     "The shell command to execute on **macOS/Linux** (run via
+//                `bash -c`). At least one of `command` or `powershell` must
+//                be specified."
+//   powershell  "Optional. The command to execute on **Windows** (run via
+//                `powershell -Command`). If omitted on Windows, `command` is
+//                used as a fallback."
+//
+//   and its cross-platform table, for the row we are actually in:
+//   | Windows | `command` ✓ | `powershell` ✗ | Falls back to `command` via `powershell -Command` |
+//
+// So on Windows the entry is NOT skipped. #1907 was filed on the assumption
+// that it would be; the primary source says otherwise, and this comment is
+// the corrected record. The real question is narrower and still open: what
+// gets handed to `powershell -Command` is THE PATH OF A POSIX SHELL SCRIPT
+// (`.windsurf/coworker-ai/pre_command.sh`), and every hook adapter this
+// product ships — all five agents, 42 files — is a `.sh`. There is no
+// Windows-native adapter anywhere in this tree to point a `powershell` key at.
+//
+// Why the outcome is invisible either way: the same page's exit-code table
+// says `0` proceeds, `2` blocks, and "Any other | Error | Action proceeds
+// normally". A fallback that fires and cannot run therefore produces the same
+// user-visible result as a scan that ran and found nothing. Fail-open is
+// deliberate, and it is exactly what hides this.
+//
+// UNMEASURED: whether that fallback reaches ai-scanner on a real Windows
+// machine. This development host has no Windows machine with Windsurf on it.
+//
+// Two wrong moves, spelled out so nobody makes them from this comment alone:
+//   * emit `powershell: "bash <path>.sh"` — plausible, and unverified. If Git
+//     Bash is not on PATH it exits non-zero, which the table above turns into
+//     "proceeds normally" — the same silent gap, now with a tree that CLAIMS
+//     Windows is handled. A bare `bash` on Windows can also resolve to WSL's
+//     `C:\Windows\System32\bash.exe`, which sees a different filesystem than
+//     the path we wrote.
+//   * delete this comment because "the docs say it falls back" — the fallback
+//     is documented; the fallback WORKING is not.
+//
+// HOW THIS INEQUALITY RETIRES (so it cannot sit here forever): install
+// Windsurf on a Windows machine, install these hooks, and drive a pre_* hook
+// with an input the scanner MUST block. Judge on the block (exit 2), not on a
+// log line or a telemetry field — fail-open makes "ran and allowed" and
+// "never ran" byte-identical. Then either delete this block (it reaches the
+// scanner) or add the `powershell` value the measurement showed to be right.
+// `tests/merge-hooks-json.test.mjs` pins both directions until that day.
 export function buildWindsurfHooksJson(scope = "project", absHome = "") {
   const p = scope === "user" ? `${absHome}/.windsurf/coworker-ai` : ".windsurf/coworker-ai";
   return {

package/src/templates.mjs

@@ -55,6 +55,14 @@ mkdir -p "$BIN_DIR"
 
 # macOS has no base \`timeout\` (it's in GNU coreutils). Shim it so hooks work
 # on fresh Macs without brew install coreutils.
+#
+# NOTE (issue #1879): the last branch — a bare macOS with neither \`timeout\` nor
+# \`gtimeout\` — DROPS the duration and execs directly. On such a machine every
+# \`timeout N "$BIN" ...\` below is unbounded, and the only remaining safety net
+# is the editor's own hook timeout (Claude Code / Codex: 60s, written by
+# merge.mjs; Cursor / Windsurf / Kiro: unverified). Installing coreutils is the
+# documented remedy. The shim is deliberately kept — a hook that refused to run
+# without coreutils would be worse than one that runs unbounded.
 if ! command -v timeout >/dev/null 2>&1; then
     if command -v gtimeout >/dev/null 2>&1; then
         timeout() { gtimeout "$@"; }
@@ -63,6 +71,23 @@ if ! command -v timeout >/dev/null 2>&1; then
     fi
 fi
 
+# Bounds for the two ai-scanner invocations this script makes. Both sit
+# STRICTLY ABOVE the binary's own internal network bound for that subcommand,
+# so the wrapper only ever fires on a genuinely hung binary and never pre-empts
+# a slow-but-working one. (A bound that fires on healthy-but-slow would print
+# the "we did NOT check" message spuriously — a false positive, which is how
+# guards stop being read.)
+#
+#   version: load_plan -> /verify, reqwest timeout 10s
+#            (docker/scanner/src/main.rs). 20s leaves 10s for process start.
+#   update:  /verify (10s) THEN the binary download (30s), sequential
+#            (docker/scanner/src/main.rs cmd_update) = 40s internal worst case.
+#            60s leaves 20s for hashing and the rename. Killing an update
+#            mid-flight is safe: it writes to a temp file in the same directory
+#            and only renames over \$BIN once the advertised hash matches.
+VERSION_TIMEOUT=20
+UPDATE_TIMEOUT=60
+
 # Generic throttle: true (0) if stamp missing or older than PULL_INTERVAL
 should_check_update() {
     [ ! -f "$PULL_STAMP" ] && return 0
@@ -248,7 +273,7 @@ rm -f "$UNSCANNED_STAMP"
 #      operator can act on; "|| true" turned it into silence.
 if should_check_update; then
     want_host=$(printf '%s' "$DOWNLOAD_BASE" | sed -E 's#^[a-z]+://([^/]+).*#\\1#')
-    have_host=$("$BIN" version 2>/dev/null | sed -n 's#^server: [a-z]*://\\([^/]*\\).*#\\1#p' | head -1)
+    have_host=$(timeout "$VERSION_TIMEOUT" "$BIN" version 2>/dev/null | sed -n 's#^server: [a-z]*://\\([^/]*\\).*#\\1#p' | head -1)
     if [ -n "$have_host" ] && [ -n "$want_host" ] && [ "$have_host" != "$want_host" ]; then
         echo "ai-scanner: the installed binary talks to $have_host, but this installation provisions from $want_host, so its access key can never be accepted (detection logs are refused and discarded). Re-downloading the matching binary." >&2
         download_binary "\${DOWNLOAD_BASE}/\${PLATFORM_SLUG}" || \\
@@ -256,7 +281,7 @@ if should_check_update; then
     elif [ -z "$have_host" ]; then
         echo "ai-scanner: could not read which license server the installed binary uses, so the environment match was NOT checked. If detection logs are being refused, re-run the installer." >&2
     fi
-    "$BIN" update 2>/dev/null || \\
+    timeout "$UPDATE_TIMEOUT" "$BIN" update 2>/dev/null || \\
         echo "ai-scanner: the scanner could not update itself just now. It keeps scanning with the rules it already has; if this repeats, re-run the installer or contact your IT administrator." >&2
     date +%s > "$PULL_STAMP"
 fi