@covibes/zeroshot 5.3.0 → 5.4.0

package/src/agent/agent-context-builder.js

@@ -51,42 +51,8 @@ function generateExampleFromSchema(schema) {
   return example;
 }
 
-/**
- * Build execution context for an agent
- * @param {object} params - Context building parameters
- * @param {string} params.id - Agent ID
- * @param {string} params.role - Agent role
- * @param {number} params.iteration - Current iteration number
- * @param {any} params.config - Agent configuration
- * @param {any} params.messageBus - Message bus for querying ledger
- * @param {any} params.cluster - Cluster object
- * @param {number} [params.lastTaskEndTime] - Timestamp of last task completion
- * @param {any} params.triggeringMessage - Message that triggered this execution
- * @param {string} [params.selectedPrompt] - Pre-selected prompt from _selectPrompt() (iteration-based)
- * @param {object} [params.worktree] - Worktree isolation state (if running in worktree mode)
- * @param {object} [params.isolation] - Docker isolation state (if running in Docker mode)
- * @returns {string} Assembled context string
- */
-function buildContext({
-  id,
-  role,
-  iteration,
-  config,
-  messageBus,
-  cluster,
-  lastTaskEndTime,
-  triggeringMessage,
-  selectedPrompt,
-  worktree,
-  isolation,
-}) {
-  const strategy = config.contextStrategy || { sources: [] };
-
-  let context = `You are agent "${id}" with role "${role}".\n\n`;
-  context += `Iteration: ${iteration}\n\n`;
-
-  // GLOBAL RULE: NEVER ASK QUESTIONS - Vibe agents run non-interactively
-  context += `## 🔴 CRITICAL: AUTONOMOUS EXECUTION REQUIRED\n\n`;
+function buildAutonomousSection() {
+  let context = `## 🔴 CRITICAL: AUTONOMOUS EXECUTION REQUIRED\n\n`;
   context += `You are running in a NON-INTERACTIVE cluster environment.\n\n`;
   context += `**NEVER** use AskUserQuestion or ask for user input - there is NO user to respond.\n`;
   context += `**NEVER** ask "Would you like me to..." or "Should I..." - JUST DO IT.\n`;
@@ -95,9 +61,11 @@ function buildContext({
   context += `- Choose the option that maintains code quality and correctness\n`;
   context += `- If unsure between "fix the code" vs "relax the rules" → ALWAYS fix the code\n`;
   context += `- If unsure between "do more" vs "do less" → ALWAYS do what's required, nothing more\n\n`;
+  return context;
+}
 
-  // OUTPUT STYLE - NON-NEGOTIABLE
-  context += `## 🔴 OUTPUT STYLE - NON-NEGOTIABLE\n\n`;
+function buildOutputStyleSection() {
+  let context = `## 🔴 OUTPUT STYLE - NON-NEGOTIABLE\n\n`;
   context += `**ALL OUTPUT: Maximum informativeness, minimum verbosity. NO EXCEPTIONS.**\n\n`;
   context += `This applies to EVERYTHING you output:\n`;
   context += `- Text responses\n`;
@@ -112,83 +80,137 @@ function buildContext({
   context += `- Errors: DETAILED (stack traces, repro). NEVER compress errors.\n`;
   context += `- FORBIDDEN: "I'll help...", "Let me...", "I'm going to...", "Sure!", "Great!", "Certainly!"\n\n`;
   context += `Every token costs money. Waste nothing.\n\n`;
+  return context;
+}
 
-  // GIT OPERATIONS RESTRICTION - Only when NOT running in isolation mode
-  // When isolated (worktree or Docker), agents CAN commit/push safely
-  // When NOT isolated, agents are on main branch - git operations are dangerous
-  const isIsolated = !!(worktree?.enabled || isolation?.enabled);
+function buildGitOperationsSection() {
+  let context = `## 🚫 GIT OPERATIONS - FORBIDDEN\n\n`;
+  context += `NEVER commit, push, or create PRs. You only modify files.\n`;
+  context += `The git-pusher agent handles ALL git operations AFTER validators approve.\n\n`;
+  context += `- ❌ NEVER run: git add, git commit, git push, gh pr create\n`;
+  context += `- ❌ NEVER suggest committing changes\n`;
+  context += `- ✅ Only modify files and publish your completion message when done\n\n`;
+  return context;
+}
+
+function buildHeaderContext({ id, role, iteration, isIsolated }) {
+  let context = `You are agent "${id}" with role "${role}".\n\n`;
+  context += `Iteration: ${iteration}\n\n`;
+  context += buildAutonomousSection();
+  context += buildOutputStyleSection();
   if (!isIsolated) {
-    context += `## 🚫 GIT OPERATIONS - FORBIDDEN\n\n`;
-    context += `NEVER commit, push, or create PRs. You only modify files.\n`;
-    context += `The git-pusher agent handles ALL git operations AFTER validators approve.\n\n`;
-    context += `- ❌ NEVER run: git add, git commit, git push, gh pr create\n`;
-    context += `- ❌ NEVER suggest committing changes\n`;
-    context += `- ✅ Only modify files and publish your completion message when done\n\n`;
+    context += buildGitOperationsSection();
   }
+  return context;
+}
 
-  // Add prompt from config (system prompt, instructions, output format)
-  // If selectedPrompt is provided (iteration-based), use it directly
-  // Otherwise fall back to legacy config.prompt handling
+function buildInstructionsSection({ config, selectedPrompt, id }) {
   const promptText =
     selectedPrompt || (typeof config.prompt === 'string' ? config.prompt : config.prompt?.system);
 
   if (promptText) {
-    context += `## Instructions\n\n${promptText}\n\n`;
-  } else if (config.prompt && typeof config.prompt !== 'string' && !config.prompt?.system) {
-    // FAIL HARD: prompt exists but format is unrecognized (and no selectedPrompt provided)
+    return `## Instructions\n\n${promptText}\n\n`;
+  }
+
+  if (config.prompt && typeof config.prompt !== 'string' && !config.prompt?.system) {
     throw new Error(
       `Agent "${id}" has invalid prompt format. ` +
         `Expected string or object with .system property, got: ${JSON.stringify(config.prompt).slice(0, 100)}...`
     );
   }
 
-  // Output format schema (if configured via legacy format)
-  if (config.prompt?.outputFormat) {
-    context += `## Output Schema (REQUIRED)\n\n`;
-    context += `\`\`\`json\n${JSON.stringify(config.prompt.outputFormat.example, null, 2)}\n\`\`\`\n\n`;
-    context += `STRING VALUES IN THIS SCHEMA: Dense. Factual. No filler words. No pleasantries.\n`;
-    if (config.prompt.outputFormat.rules) {
-      for (const rule of config.prompt.outputFormat.rules) {
-        context += `- ${rule}\n`;
-      }
+  return '';
+}
+
+function buildLegacyOutputSchemaSection(config) {
+  if (!config.prompt?.outputFormat) return '';
+
+  let context = `## Output Schema (REQUIRED)\n\n`;
+  context += `\`\`\`json\n${JSON.stringify(config.prompt.outputFormat.example, null, 2)}\n\`\`\`\n\n`;
+  context += `STRING VALUES IN THIS SCHEMA: Dense. Factual. No filler words. No pleasantries.\n`;
+  if (config.prompt.outputFormat.rules) {
+    for (const rule of config.prompt.outputFormat.rules) {
+      context += `- ${rule}\n`;
     }
-    context += '\n';
   }
+  context += '\n';
+  return context;
+}
 
-  // AUTO-INJECT JSON OUTPUT INSTRUCTIONS when jsonSchema is defined
-  // This ensures ALL agents with structured output schemas get explicit "output ONLY JSON" instructions
-  // Critical for less capable models (Codex, Gemini) that output prose without explicit instructions
-  if (config.jsonSchema && config.outputFormat === 'json') {
-    context += `## 🔴 OUTPUT FORMAT - JSON ONLY\n\n`;
-    context += `Your response must be ONLY valid JSON. No other text before or after.\n`;
-    context += `Start with { and end with }. Nothing else.\n\n`;
-    context += `Required schema:\n`;
-    context += `\`\`\`json\n${JSON.stringify(config.jsonSchema, null, 2)}\n\`\`\`\n\n`;
-
-    // Generate example from schema
-    const example = generateExampleFromSchema(config.jsonSchema);
-    if (example) {
-      context += `Example output:\n`;
-      context += `\`\`\`json\n${JSON.stringify(example, null, 2)}\n\`\`\`\n\n`;
-    }
+function buildJsonSchemaSection(config) {
+  if (!config.jsonSchema || config.outputFormat !== 'json') return '';
 
-    context += `CRITICAL RULES:\n`;
-    context += `- Output ONLY the JSON object - no explanation, no thinking, no preamble\n`;
-    context += `- Use EXACTLY the enum values specified (case-sensitive)\n`;
-    context += `- Include ALL required fields\n\n`;
+  let context = `## 🔴 OUTPUT FORMAT - JSON ONLY\n\n`;
+  context += `Your response must be ONLY valid JSON. No other text before or after.\n`;
+  context += `Start with { and end with }. Nothing else.\n\n`;
+  context += `Required schema:\n`;
+  context += `\`\`\`json\n${JSON.stringify(config.jsonSchema, null, 2)}\n\`\`\`\n\n`;
+
+  const example = generateExampleFromSchema(config.jsonSchema);
+  if (example) {
+    context += `Example output:\n`;
+    context += `\`\`\`json\n${JSON.stringify(example, null, 2)}\n\`\`\`\n\n`;
   }
 
-  // Add sources
-  for (const source of strategy.sources) {
-    // Resolve special 'since' values
-    let sinceTimestamp = source.since;
-    if (source.since === 'cluster_start') {
-      sinceTimestamp = cluster.createdAt;
-    } else if (source.since === 'last_task_end') {
-      // Use timestamp of last task completion, or cluster start if no tasks completed yet
-      sinceTimestamp = lastTaskEndTime || cluster.createdAt;
+  context += `CRITICAL RULES:\n`;
+  context += `- Output ONLY the JSON object - no explanation, no thinking, no preamble\n`;
+  context += `- Use EXACTLY the enum values specified (case-sensitive)\n`;
+  context += `- Include ALL required fields\n\n`;
+  return context;
+}
+
+function resolveSourceSince(source, cluster, lastTaskEndTime, lastAgentStartTime) {
+  const sinceValue = source.since;
+
+  if (sinceValue === 'cluster_start') {
+    return cluster.createdAt;
+  }
+  if (sinceValue === 'last_task_end') {
+    return lastTaskEndTime || cluster.createdAt;
+  }
+  if (sinceValue === 'last_agent_start') {
+    return lastAgentStartTime || cluster.createdAt;
+  }
+
+  if (typeof sinceValue === 'string') {
+    const parsed = Date.parse(sinceValue);
+    if (Number.isNaN(parsed)) {
+      throw new Error(
+        `Agent context source for topic ${source.topic} has invalid since value "${sinceValue}". ` +
+          'Use cluster_start, last_task_end, last_agent_start, or an ISO timestamp.'
+      );
+    }
+    return parsed;
+  }
+
+  return sinceValue;
+}
+
+function formatSourceMessagesSection(source, messages) {
+  let context = `\n## Messages from topic: ${source.topic}\n\n`;
+  for (const msg of messages) {
+    context += `[${new Date(msg.timestamp).toISOString()}] ${msg.sender}:\n`;
+    if (msg.content?.text) {
+      context += `${msg.content.text}\n`;
+    }
+    if (msg.content?.data) {
+      context += `Data: ${JSON.stringify(msg.content.data, null, 2)}\n`;
     }
+    context += '\n';
+  }
+  return context;
+}
 
+function buildSourcesSection({
+  strategy,
+  messageBus,
+  cluster,
+  lastTaskEndTime,
+  lastAgentStartTime,
+}) {
+  let context = '';
+  for (const source of strategy.sources) {
+    const sinceTimestamp = resolveSourceSince(source, cluster, lastTaskEndTime, lastAgentStartTime);
     const messages = messageBus.query({
       cluster_id: cluster.id,
       topic: source.topic,
@@ -198,134 +220,221 @@ function buildContext({
     });
 
     if (messages.length > 0) {
-      context += `\n## Messages from topic: ${source.topic}\n\n`;
-      for (const msg of messages) {
-        context += `[${new Date(msg.timestamp).toISOString()}] ${msg.sender}:\n`;
-        if (msg.content?.text) {
-          context += `${msg.content.text}\n`;
-        }
-        if (msg.content?.data) {
-          context += `Data: ${JSON.stringify(msg.content.data, null, 2)}\n`;
-        }
-        context += '\n';
-      }
+      context += formatSourceMessagesSection(source, messages);
     }
   }
+  return context;
+}
 
-  // Add triggering message
-  context += `\n## Triggering Message\n\n`;
-  context += `Topic: ${triggeringMessage.topic}\n`;
-  context += `Sender: ${triggeringMessage.sender}\n`;
-  if (triggeringMessage.content?.text) {
-    context += `\n${triggeringMessage.content.text}\n`;
+function collectCannotValidateCriteria(prevValidations) {
+  const cannotValidateCriteria = [];
+  for (const msg of prevValidations) {
+    const criteriaResults = msg.content?.data?.criteriaResults;
+    if (!Array.isArray(criteriaResults)) continue;
+    for (const cr of criteriaResults) {
+      if (cr.status !== 'CANNOT_VALIDATE' || !cr.id) continue;
+      if (cannotValidateCriteria.find((c) => c.id === cr.id)) continue;
+      cannotValidateCriteria.push({
+        id: cr.id,
+        reason: cr.reason || 'No reason provided',
+      });
+    }
   }
+  return cannotValidateCriteria;
+}
 
-  // DEFENSIVE TRUNCATION - Prevent context overflow errors
-  // Strategy: Keep ISSUE_OPENED (original task) + most recent messages
-  // Truncate from MIDDLE (oldest context messages) if too long
-  const originalLength = context.length;
+function buildCannotValidateSection(cannotValidateCriteria) {
+  if (cannotValidateCriteria.length === 0) return '';
 
-  if (originalLength > MAX_CONTEXT_CHARS) {
-    console.log(
-      `[Context] Context too large (${originalLength} chars), truncating to prevent overflow...`
-    );
+  let context = `\n## ⚠️ Permanently Unverifiable Criteria (SKIP THESE)\n\n`;
+  context += `The following criteria have PERMANENT environmental limitations (missing tools, no access).\n`;
+  context += `These limitations have not changed. Do NOT re-attempt verification.\n`;
+  context += `Mark these as CANNOT_VALIDATE again with the same reason.\n\n`;
+  for (const cv of cannotValidateCriteria) {
+    context += `- **${cv.id}**: ${cv.reason}\n`;
+  }
+  context += `\n`;
+  return context;
+}
 
-    // Split context into sections
-    const lines = context.split('\n');
+function buildValidatorSkipSection({ role, messageBus, cluster }) {
+  if (role !== 'validator') return '';
 
-    // Find critical sections that must be preserved
-    let issueOpenedStart = -1;
-    let issueOpenedEnd = -1;
-    let triggeringStart = -1;
+  const prevValidations = messageBus.query({
+    cluster_id: cluster.id,
+    topic: 'VALIDATION_RESULT',
+    since: cluster.createdAt,
+    limit: 50,
+  });
 
-    for (let i = 0; i < lines.length; i++) {
-      if (lines[i].includes('## Messages from topic: ISSUE_OPENED')) {
-        issueOpenedStart = i;
-      }
-      if (issueOpenedStart !== -1 && issueOpenedEnd === -1 && lines[i].startsWith('## ')) {
-        issueOpenedEnd = i;
-      }
-      if (lines[i].includes('## Triggering Message')) {
-        triggeringStart = i;
-        break;
-      }
-    }
+  const cannotValidateCriteria = collectCannotValidateCriteria(prevValidations);
+  return buildCannotValidateSection(cannotValidateCriteria);
+}
 
-    // Build truncated context:
-    // 1. Header (agent info, instructions, output format)
-    // 2. ISSUE_OPENED message (original task - NEVER truncate)
-    // 3. Most recent N messages (whatever fits in budget)
-    // 4. Triggering message (current event)
+function buildTriggeringMessageSection(triggeringMessage) {
+  let context = `\n## Triggering Message\n\n`;
+  context += `Topic: ${triggeringMessage.topic}\n`;
+  context += `Sender: ${triggeringMessage.sender}\n`;
+  if (triggeringMessage.content?.text) {
+    context += `\n${triggeringMessage.content.text}\n`;
+  }
+  return context;
+}
 
-    const headerEnd = issueOpenedStart !== -1 ? issueOpenedStart : triggeringStart;
-    const header = lines.slice(0, headerEnd).join('\n');
+function findContextSectionIndices(lines) {
+  let issueOpenedStart = -1;
+  let issueOpenedEnd = -1;
+  let triggeringStart = -1;
 
-    const issueOpened =
-      issueOpenedStart !== -1 && issueOpenedEnd !== -1
-        ? lines.slice(issueOpenedStart, issueOpenedEnd).join('\n')
-        : '';
+  for (let i = 0; i < lines.length; i++) {
+    if (lines[i].includes('## Messages from topic: ISSUE_OPENED')) {
+      issueOpenedStart = i;
+    }
+    if (issueOpenedStart !== -1 && issueOpenedEnd === -1 && lines[i].startsWith('## ')) {
+      issueOpenedEnd = i;
+    }
+    if (lines[i].includes('## Triggering Message')) {
+      triggeringStart = i;
+      break;
+    }
+  }
 
-    const triggeringMsg = lines.slice(triggeringStart).join('\n');
+  return { issueOpenedStart, issueOpenedEnd, triggeringStart };
+}
 
-    // Calculate remaining budget for recent messages
-    const fixedSize = header.length + issueOpened.length + triggeringMsg.length;
-    const budgetForRecent = MAX_CONTEXT_CHARS - fixedSize - 200; // 200 char buffer for markers
+function collectRecentLines(middleLines, budgetForRecent) {
+  const recentLines = [];
+  let recentSize = 0;
 
-    // Collect recent messages (from end backwards until budget exhausted)
-    const recentLines = [];
-    let recentSize = 0;
+  for (let i = middleLines.length - 1; i >= 0; i--) {
+    const line = middleLines[i];
+    const lineSize = line.length + 1;
 
-    const middleStart = issueOpenedEnd !== -1 ? issueOpenedEnd : headerEnd;
-    const middleEnd = triggeringStart;
-    const middleLines = lines.slice(middleStart, middleEnd);
+    if (recentSize + lineSize > budgetForRecent) {
+      break;
+    }
 
-    for (let i = middleLines.length - 1; i >= 0; i--) {
-      const line = middleLines[i];
-      const lineSize = line.length + 1; // +1 for newline
+    recentLines.unshift(line);
+    recentSize += lineSize;
+  }
 
-      if (recentSize + lineSize > budgetForRecent) {
-        break; // Budget exhausted
-      }
+  return recentLines;
+}
 
-      recentLines.unshift(line);
-      recentSize += lineSize;
-    }
+function truncateContextIfNeeded(context) {
+  const originalLength = context.length;
+  if (originalLength <= MAX_CONTEXT_CHARS) {
+    return context;
+  }
 
-    // Assemble truncated context
-    const parts = [header];
+  console.log(
+    `[Context] Context too large (${originalLength} chars), truncating to prevent overflow...`
+  );
 
-    if (issueOpened) {
-      parts.push(issueOpened);
-    }
+  const lines = context.split('\n');
+  const { issueOpenedStart, issueOpenedEnd, triggeringStart } = findContextSectionIndices(lines);
 
-    if (recentLines.length < middleLines.length) {
-      // Some messages were truncated
-      const truncatedCount = middleLines.length - recentLines.length;
-      parts.push(
-        `\n[...${truncatedCount} earlier context messages truncated to prevent overflow...]\n`
-      );
-    }
+  const headerEnd = issueOpenedStart !== -1 ? issueOpenedStart : triggeringStart;
+  const header = lines.slice(0, headerEnd).join('\n');
 
-    if (recentLines.length > 0) {
-      parts.push(recentLines.join('\n'));
-    }
+  const issueOpened =
+    issueOpenedStart !== -1 && issueOpenedEnd !== -1
+      ? lines.slice(issueOpenedStart, issueOpenedEnd).join('\n')
+      : '';
 
-    parts.push(triggeringMsg);
+  const triggeringMsg = lines.slice(triggeringStart).join('\n');
 
-    context = parts.join('\n');
+  const fixedSize = header.length + issueOpened.length + triggeringMsg.length;
+  const budgetForRecent = MAX_CONTEXT_CHARS - fixedSize - 200;
 
-    const truncatedLength = context.length;
-    console.log(
-      `[Context] Truncated from ${originalLength} to ${truncatedLength} chars (${Math.round((truncatedLength / originalLength) * 100)}% retained)`
+  const middleStart = issueOpenedEnd !== -1 ? issueOpenedEnd : headerEnd;
+  const middleEnd = triggeringStart;
+  const middleLines = lines.slice(middleStart, middleEnd);
+  const recentLines = collectRecentLines(middleLines, budgetForRecent);
+
+  const parts = [header];
+  if (issueOpened) {
+    parts.push(issueOpened);
+  }
+  if (recentLines.length < middleLines.length) {
+    const truncatedCount = middleLines.length - recentLines.length;
+    parts.push(
+      `\n[...${truncatedCount} earlier context messages truncated to prevent overflow...]\n`
     );
   }
+  if (recentLines.length > 0) {
+    parts.push(recentLines.join('\n'));
+  }
+  parts.push(triggeringMsg);
+
+  const truncatedContext = parts.join('\n');
+  const truncatedLength = truncatedContext.length;
+  console.log(
+    `[Context] Truncated from ${originalLength} to ${truncatedLength} chars (${Math.round((truncatedLength / originalLength) * 100)}% retained)`
+  );
+
+  return truncatedContext;
+}
 
-  // Legacy maxTokens check (for backward compatibility with agent configs)
+function applyLegacyMaxTokens(context, strategy) {
   const maxTokens = strategy.maxTokens || 100000;
   const maxChars = maxTokens * 4;
   if (context.length > maxChars) {
-    context = context.slice(0, maxChars) + '\n\n[Context truncated...]';
+    return context.slice(0, maxChars) + '\n\n[Context truncated...]';
   }
+  return context;
+}
+
+/**
+ * Build execution context for an agent
+ * @param {object} params - Context building parameters
+ * @param {string} params.id - Agent ID
+ * @param {string} params.role - Agent role
+ * @param {number} params.iteration - Current iteration number
+ * @param {any} params.config - Agent configuration
+ * @param {any} params.messageBus - Message bus for querying ledger
+ * @param {any} params.cluster - Cluster object
+ * @param {number} [params.lastTaskEndTime] - Timestamp of last task completion
+ * @param {number} [params.lastAgentStartTime] - Timestamp when this agent last started work
+ * @param {any} params.triggeringMessage - Message that triggered this execution
+ * @param {string} [params.selectedPrompt] - Pre-selected prompt from _selectPrompt() (iteration-based)
+ * @param {object} [params.worktree] - Worktree isolation state (if running in worktree mode)
+ * @param {object} [params.isolation] - Docker isolation state (if running in Docker mode)
+ * @returns {string} Assembled context string
+ */
+function buildContext({
+  id,
+  role,
+  iteration,
+  config,
+  messageBus,
+  cluster,
+  lastTaskEndTime,
+  lastAgentStartTime,
+  triggeringMessage,
+  selectedPrompt,
+  worktree,
+  isolation,
+}) {
+  const strategy = config.contextStrategy || { sources: [] };
+  const isIsolated = !!(worktree?.enabled || isolation?.enabled);
+
+  let context = buildHeaderContext({ id, role, iteration, isIsolated });
+  context += buildInstructionsSection({ config, selectedPrompt, id });
+  context += buildLegacyOutputSchemaSection(config);
+  context += buildJsonSchemaSection(config);
+  context += buildSourcesSection({
+    strategy,
+    messageBus,
+    cluster,
+    lastTaskEndTime,
+    lastAgentStartTime,
+  });
+  context += buildValidatorSkipSection({ role, messageBus, cluster });
+  context += buildTriggeringMessageSection(triggeringMessage);
+
+  context = truncateContextIfNeeded(context);
+  context = applyLegacyMaxTokens(context, strategy);
 
   return context;
 }