@coveo/quantic 3.37.5 → 3.37.7

package/force-app/main/default/lwc/quanticResultLink/__tests__/quanticResultLink.test.js

@@ -101,7 +101,7 @@ describe('c-quantic-result-link', () => {
       );
     });
 
-    it('should open the result link in a Salesforce console subtab', async () => {
+    it('should open the result link in a Salesforce console subtab when no target is specified', async () => {
       const element = createTestComponent({result: exampleSalesforceResult});
       await flushPromises();
 
@@ -115,6 +115,34 @@ describe('c-quantic-result-link', () => {
       );
     });
 
+    it('should open the Salesforce result link in a new browser tab when target is _blank', async () => {
+      const element = createTestComponent({
+        result: exampleSalesforceResult,
+        target: '_blank',
+      });
+      await flushPromises();
+
+      const linkSalesforce = element.shadowRoot.querySelector('a');
+      linkSalesforce.click();
+
+      expect(linkSalesforce.getAttribute('target')).toEqual('_blank');
+      expect(getNavigateCalledWith().pageReference).toBeUndefined();
+    });
+
+    it('should let Salesforce result links use other target values without console navigation', async () => {
+      const element = createTestComponent({
+        result: exampleSalesforceResult,
+        target: '_parent',
+      });
+      await flushPromises();
+
+      const linkSalesforce = element.shadowRoot.querySelector('a');
+      linkSalesforce.click();
+
+      expect(linkSalesforce.getAttribute('target')).toEqual('_parent');
+      expect(getNavigateCalledWith().pageReference).toBeUndefined();
+    });
+
     describe('when the result is a knowledge article', () => {
       const exampleKnowledgeArticleResult = {
         ...exampleResult,
@@ -176,6 +204,19 @@ describe('c-quantic-result-link', () => {
       expect(link.getAttribute('target')).toEqual('_self');
     });
 
+    it('should open the result link in a new tab when target is _blank', async () => {
+      const element = createTestComponent({
+        result: exampleResult,
+        target: '_blank',
+      });
+      await flushPromises();
+
+      const link = element.shadowRoot.querySelector('a');
+
+      expect(link.getAttribute('href')).toEqual(exampleResult.clickUri);
+      expect(link.getAttribute('target')).toEqual('_blank');
+    });
+
     describe('with a custom value for the target property', () => {
       it('should open the result link based on the value of the target property', async () => {
         const customTarget = '_blank';

package/force-app/main/default/lwc/quanticResultLink/quanticResultLink.html

@@ -1,5 +1,5 @@
 <template>
-  <a href={hrefValue} aria-label={ariaLabelValue} target={targetTab} onclick={handleClick} tabindex="0" role="link">
+  <a href={hrefValue} aria-label={ariaLabelValue} target={target} onclick={handleClick} tabindex="0" role="link">
     <c-quantic-result-highlighted-text-field engine-id={engineId} result={result} field={fieldToDisplay}></c-quantic-result-highlighted-text-field>
   </a>
 </template>

package/force-app/main/default/lwc/quanticResultLink/quanticResultLink.js

@@ -121,7 +121,7 @@ export default class QuanticResultLink extends NavigationMixin(
   };
 
   handleClick(event) {
-    if (this.isSalesforceLink) {
+    if (this.shouldNavigateToSalesforceRecord) {
       event.preventDefault();
       this.navigateToSalesforceRecord(event);
     }
@@ -175,21 +175,15 @@ export default class QuanticResultLink extends NavigationMixin(
       : 'clickUri';
   }
 
-  /**
-   * Returns the target for the link.
-   */
-  get targetTab() {
-    if (this.isSalesforceLink) {
-      return '_blank';
-    }
-    return this.target;
+  get shouldNavigateToSalesforceRecord() {
+    return this.isSalesforceLink && this.target === '_self';
   }
 
   /**
    * Returns the aria label value for the link.
    */
   get ariaLabelValue() {
-    if (this.isSalesforceLink) {
+    if (this.shouldNavigateToSalesforceRecord) {
       return this.labels.navigateToRecord;
     }
     return this.labels.opensInBrowserTab;

package/force-app/main/default/lwc/quanticSort/e2e/pageObject.ts

@@ -10,10 +10,6 @@ export class SortObject {
     return this.page.getByRole('combobox', {name: 'Sort by'});
   }
 
-  get sortPreviewButton(): Locator {
-    return this.page.getByRole('button', {name: 'Preview'});
-  }
-
   sortButton(buttonName: string): Locator {
     return this.page.getByRole('option', {name: buttonName});
   }
@@ -23,8 +19,7 @@ export class SortObject {
   }
 
   async focusSortDropDown(): Promise<void> {
-    await this.sortPreviewButton.click();
-    await this.page.keyboard.press('Tab');
+    await this.sortDropDown.focus();
   }
 
   async clickSortButton(buttonName: string): Promise<void> {
@@ -33,12 +28,11 @@ export class SortObject {
 
   async openSortDropdownUsingKeyboardEnter(useEnter = true): Promise<void> {
     if (useEnter) {
-      await this.page.keyboard.press('Enter');
+      await this.sortDropDown.press('Enter');
     } else {
-      await this.page.keyboard.press('Space');
+      await this.sortDropDown.press('Space');
     }
-    await this.sortButton('Oldest').isVisible();
-    await this.page.waitForTimeout(500);
+    await this.sortButton('Oldest').waitFor({state: 'visible'});
   }
 
   async waitForSortUaAnalytics(eventValue: any): Promise<Request> {

package/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts

@@ -47,25 +47,22 @@ useCaseTestCases.forEach((useCase) => {
     });
 
     test.describe('when testing accessibility', () => {
-      test('should be accessible to keyboard', async ({sort, page}) => {
-        let selectedSortLabel = await sort.sortDropDown.textContent();
-        expect(selectedSortLabel).toEqual(sortArrOptions[0]);
+      test('should be accessible to keyboard', async ({sort}) => {
+        await expect(sort.sortDropDown).toHaveText(sortArrOptions[0]);
 
         // Selecting the next sort using Enter to open dropdown, the ArrowDown, then ENTER key
         await sort.focusSortDropDown();
         await sort.openSortDropdownUsingKeyboardEnter();
-        await page.keyboard.press('ArrowDown');
-        await page.keyboard.press('Enter');
-        selectedSortLabel = await sort.sortDropDown.textContent();
-        expect(selectedSortLabel).toEqual(sortArrOptions[1]);
+        await sort.sortDropDown.press('ArrowDown');
+        await sort.sortDropDown.press('Enter');
+        await expect(sort.sortDropDown).toHaveText(sortArrOptions[1]);
 
         // Selecting the next sort using Space to open dropdown, the ArrowDown, then ENTER key
         await sort.focusSortDropDown();
         await sort.openSortDropdownUsingKeyboardEnter(false);
-        await page.keyboard.press('ArrowDown');
-        await page.keyboard.press('Enter');
-        selectedSortLabel = await sort.sortDropDown.textContent();
-        expect(selectedSortLabel).toEqual(sortArrOptions[2]);
+        await sort.sortDropDown.press('ArrowDown');
+        await sort.sortDropDown.press('Enter');
+        await expect(sort.sortDropDown).toHaveText(sortArrOptions[2]);
       });
     });
 

package/force-app/main/default/staticresources/coveobueno/browser/bueno.js

@@ -80,6 +80,7 @@ var Schema = class {
   constructor(definition) {
     this.definition = definition;
   }
+  definition;
   validate(values = {}, message = "") {
     const mergedValues = {
       ...this.default,
@@ -112,6 +113,7 @@ var Value = class {
   constructor(baseConfig = {}) {
     this.baseConfig = baseConfig;
   }
+  baseConfig;
   validate(value) {
     if (this.baseConfig.required && isNullOrUndefined(value)) {
       return "value is required.";
@@ -171,6 +173,7 @@ var NumberValue = class {
     this.config = config;
     this.value = new Value(config);
   }
+  config;
   value;
   validate(value) {
     const valueValidation = this.value.validate(value);
@@ -307,6 +310,7 @@ var ArrayValue = class {
     this.config = config;
     this.value = new Value(this.config);
   }
+  config;
   value;
   validate(input) {
     if (!isNullOrUndefined(input) && !Array.isArray(input)) {
@@ -369,6 +373,7 @@ var EnumValue = class {
     this.config = config;
     this.value = new Value(config);
   }
+  config;
   value;
   validate(value) {
     const invalid = this.value.validate(value);