@cosmicdrift/kumiko-testing 0.387.0 → 0.388.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-testing",
-  "version": "0.387.0",
+  "version": "0.388.0",
   "description": "Test template for Kumiko apps: per-flow seedTenant, app test stack, canonical test preloads, bunfig generator and integration runner.",
   "license": "MIT",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -99,9 +99,9 @@
     "kumiko-testing": "./bin/kumiko-testing.ts"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.387.0",
-    "@cosmicdrift/kumiko-guards": "0.387.0",
-    "@cosmicdrift/kumiko-types": "0.387.0",
+    "@cosmicdrift/kumiko-framework": "0.388.0",
+    "@cosmicdrift/kumiko-guards": "0.388.0",
+    "@cosmicdrift/kumiko-types": "0.388.0",
     "zod": "^4.4.3"
   },
   "peerDependencies": {
@@ -125,8 +125,8 @@
     }
   },
   "devDependencies": {
-    "@cosmicdrift/kumiko-bundled-features": "0.387.0",
-    "@cosmicdrift/kumiko-dev-server": "0.387.0",
+    "@cosmicdrift/kumiko-bundled-features": "0.388.0",
+    "@cosmicdrift/kumiko-dev-server": "0.388.0",
     "@happy-dom/global-registrator": "^20.11.2",
     "@playwright/test": "^1.62.1",
     "@testing-library/dom": "^10.4.1",

package/src/changes.json

@@ -1,4 +1,22 @@
 [
+  {
+    "version": "0.388.0",
+    "type": "improvement",
+    "title": "setupTestStack split into setup phases",
+    "detail": "setupTestStack() keeps its signature and behavior. Feature validation, storage provisioning with its DDL cleanup, cache sync, services, the job runner and the server start are separate phases in stack/test-stack-setup.ts. The cleanup on a failed setup still stops the job runner, closes cache sync and drops the test database and Redis in that order."
+  },
+  {
+    "version": "0.388.0",
+    "type": "fix",
+    "title": "Barrier, SSE reader, boundary guard and Redis helper fixes",
+    "detail": "createBarrier rejects late arrivals after a timeout instead of hanging. readSseFrames accepts CRLF and CR line endings. The error-boundary guard observes every page of the context and no longer fails on closed pages. createTestRedis disconnects the client when the initial connect fails. createE2eSeedRoutes of the e2e/seed-route subpath is also available as createE2eSeedRoutesWith, the old name stays as a deprecated alias."
+  },
+  {
+    "version": "0.388.0",
+    "type": "fix",
+    "title": "consoleCallsMentioning helper for console spies",
+    "detail": "`@cosmicdrift/kumiko-testing/helpers` exports `consoleCallsMentioning(spy, fragment)` and `ConsoleSpyLike`, replacing the per-file filters tests used to ignore console output of other test files."
+  },
   {
     "version": "0.386.0",
     "type": "fix",

package/src/e2e/boundary-guard.ts

@@ -3,7 +3,40 @@ import {
   ROOT_ERROR_FALLBACK_TEST_ID,
   SCREEN_ERROR_FALLBACK_TEST_ID,
 } from "@cosmicdrift/kumiko-types/error-boundary";
-import { test as base, expect } from "@playwright/test";
+import { type BrowserContext, test as base, expect } from "@playwright/test";
+
+export type BoundaryFindings = {
+  readonly boundaryLogs: readonly string[];
+  readonly visibleFallbacks: number;
+};
+
+const FALLBACK_SELECTOR = `[data-testid="${SCREEN_ERROR_FALLBACK_TEST_ID}"], [data-testid="${ROOT_ERROR_FALLBACK_TEST_ID}"]`;
+
+// Listens on the context so pages opened later (popups, context.newPage()) are covered too.
+export function observeErrorBoundaries(context: BrowserContext): {
+  readonly findings: () => Promise<BoundaryFindings>;
+} {
+  const boundaryLogs: string[] = [];
+  context.on("console", (msg) => {
+    if (msg.type() === "error" && msg.text().includes(ERROR_BOUNDARY_LOG_MARKER)) {
+      boundaryLogs.push(msg.text());
+    }
+  });
+  return {
+    async findings() {
+      let visibleFallbacks = 0;
+      for (const page of context.pages()) {
+        // A spec may close its page or a page may crash; counting then would throw and mask the test result.
+        if (page.isClosed()) continue;
+        visibleFallbacks += await page
+          .locator(FALLBACK_SELECTOR)
+          .count()
+          .catch(() => 0);
+      }
+      return { boundaryLogs: [...boundaryLogs], visibleFallbacks };
+    },
+  };
+}
 
 // An error boundary keeps the page alive, which also hides the failure from `pageerror`.
 // Every spec using `test` from this package fails when a boundary caught something.
@@ -13,21 +46,12 @@ export const boundaryGuardedTest = base.extend<{
 }>({
   expectErrorBoundary: [false, { option: true }],
   failOnErrorBoundary: [
-    async ({ page, expectErrorBoundary }, use) => {
-      const boundaryLogs: string[] = [];
-      page.on("console", (msg) => {
-        if (msg.type() === "error" && msg.text().includes(ERROR_BOUNDARY_LOG_MARKER)) {
-          boundaryLogs.push(msg.text());
-        }
-      });
+    async ({ context, expectErrorBoundary }, use) => {
+      const observer = observeErrorBoundaries(context);
       await use(undefined);
       // skip: the spec provokes a boundary on purpose and asserts the fallback itself
       if (expectErrorBoundary) return;
-      const visibleFallbacks = await page
-        .locator(
-          `[data-testid="${SCREEN_ERROR_FALLBACK_TEST_ID}"], [data-testid="${ROOT_ERROR_FALLBACK_TEST_ID}"]`,
-        )
-        .count();
+      const { boundaryLogs, visibleFallbacks } = await observer.findings();
       expect(
         { boundaryLogs, visibleFallbacks },
         "an error boundary caught a render/effect error",

package/src/e2e/index.ts

@@ -22,7 +22,11 @@ export {
   syntheticClientIpFor,
   totpCode,
 } from "./auth-kit";
-export { boundaryGuardedTest } from "./boundary-guard";
+export {
+  type BoundaryFindings,
+  boundaryGuardedTest,
+  observeErrorBoundaries,
+} from "./boundary-guard";
 export {
   CSRF_COOKIE_NAME,
   CSRF_HEADER_NAME,

package/src/e2e/seed-route.ts

@@ -156,7 +156,7 @@ function toCapturedMail(message: InboxMessage): CapturedMail {
 // createE2eSeedRoutes() : [])` in a server entry that also runs in prod.
 // Each route's own assertGateOpen() 404s outside the seed condition regardless
 // — this is belt-and-suspenders, not the only gate.
-export function createE2eSeedRoutes(
+export function createE2eSeedRoutesWith(
   options: E2eSeedRoutesOptions,
   bundled: SeedRouteBundledApi,
 ): readonly ExtraRouteDefinition[] {
@@ -327,3 +327,6 @@ export function createE2eSeedRoutes(
 
   return [seedTenantRoute, seedUserRoute, inboxRoute, extraSeedRoute];
 }
+
+/** @deprecated Use `createE2eSeedRoutesWith`; the old name collides with the bound `createE2eSeedRoutes` of dev-server/testing. */
+export const createE2eSeedRoutes = createE2eSeedRoutesWith;

package/src/helpers/barrier.ts

@@ -19,6 +19,8 @@ export function createBarrier(options: {
   let arrived = 0;
   let skipped = 0;
   let timer: ReturnType<typeof setTimeout> | undefined;
+  // Late arrivals after a timeout must fail loudly too instead of hanging until the test timeout.
+  let timedOutError: Error | undefined;
   const waiting: { resolve: () => void; reject: (error: Error) => void }[] = [];
 
   function openIfComplete(): void {
@@ -30,15 +32,17 @@ export function createBarrier(options: {
 
   return {
     arrive() {
+      if (timedOutError !== undefined) return Promise.reject(timedOutError);
       arrived++;
       const pending = new Promise<void>((resolve, reject) => {
         waiting.push({ resolve, reject });
       });
-      if (arrived === 1 && arrived + skipped < expected) {
+      if (timer === undefined && arrived + skipped < expected) {
         timer = setTimeout(() => {
           const error = new Error(
             `barrier timed out: ${arrived} of ${expected} arrived, ${skipped} skipped`,
           );
+          timedOutError = error;
           for (const waiter of waiting.splice(0)) waiter.reject(error);
         }, timeoutMs);
       }

package/src/helpers/console-calls.ts

@@ -0,0 +1,12 @@
+export type ConsoleSpyLike = {
+  readonly mock: { readonly calls: ReadonlyArray<ReadonlyArray<unknown>> };
+};
+
+// Other test files in the same bun process emit async console output while a console spy is
+// active, so assertions only count the calls that mention the message under test.
+export function consoleCallsMentioning(
+  spy: ConsoleSpyLike,
+  fragment: string,
+): ReadonlyArray<ReadonlyArray<unknown>> {
+  return spy.mock.calls.filter((args) => args.some((arg) => String(arg).includes(fragment)));
+}

package/src/helpers/index.ts

@@ -23,6 +23,7 @@ export {
   terminateBackendsByApplicationName,
   testDatabaseUrl,
 } from "./closed-connection-error.ts";
+export { type ConsoleSpyLike, consoleCallsMentioning } from "./console-calls.ts";
 export { type ClearableTable, clearTables, resetTestTables } from "./db-cleanup.ts";
 export {
   type E2EGeneratorOptions,

package/src/helpers/sse-frames.ts

@@ -25,6 +25,8 @@ export async function readSseFrames(
   const decoder = new TextDecoder();
   const frames: SseFrame[] = [];
   let buffer = "";
+  // A "\r" at a chunk end may be the first half of "\r\n", so it is held back until the next chunk.
+  let heldCarriageReturn: boolean = false;
   let timer: ReturnType<typeof setTimeout> | undefined;
   const timedOut = new Promise<never>((_, reject) => {
     timer = setTimeout(
@@ -40,7 +42,10 @@ export async function readSseFrames(
       if (chunk.done) {
         throw new Error(`sse stream ended before condition: ${frames.length} frames read`);
       }
-      buffer += decoder.decode(chunk.value, { stream: true });
+      const decodedText = decoder.decode(chunk.value, { stream: true });
+      const decoded: string = (heldCarriageReturn ? "\r" : "") + decodedText;
+      heldCarriageReturn = decoded.endsWith("\r");
+      buffer += (heldCarriageReturn ? decoded.slice(0, -1) : decoded).replace(/\r\n?/g, "\n");
       let separator = buffer.indexOf("\n\n");
       while (separator !== -1) {
         const rawFrame = buffer.slice(0, separator);

package/src/stack/db.ts

@@ -54,7 +54,7 @@ export function testDbTemplatePrefix(runId: string): string {
   return `kumiko_test_tpl_${runId}_`;
 }
 
-function adminUrlOf(url: string): string {
+export function adminUrlOf(url: string): string {
   return url.replace(/\/[^/]+$/, "/postgres");
 }
 
@@ -132,7 +132,7 @@ export function ensureTestDbTemplate(
   return pending;
 }
 
-async function buildTestDbTemplate(
+export async function buildTestDbTemplate(
   templateDbName: string,
   buildSchema: (db: DbConnection) => Promise<void>,
 ): Promise<void> {

package/src/stack/redis.ts

@@ -40,7 +40,13 @@ export async function createTestRedis(opts: CreateTestRedisOptions = {}): Promis
   const prefix = opts.borrowKeyPrefix ?? `kt:${generateId().slice(-8)}:`;
   // Callers that check redis.status (rate-limit resolver) must not see "connect" on their first call.
   const redis = new Redis(redisUrl, { keyPrefix: prefix, lazyConnect: true });
-  await redis.connect();
+  try {
+    await redis.connect();
+  } catch (error) {
+    // Without this the client keeps retrying in the background and holds the process open.
+    redis.disconnect();
+    throw error;
+  }
 
   async function deleteKeysMatching(pattern: string): Promise<void> {
     // Open a prefix-less client for the scan — ioredis' keyPrefix is applied