@cosmicdrift/kumiko-testing 0.351.0 → 0.353.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-testing",
-  "version": "0.351.0",
+  "version": "0.353.0",
   "description": "Test template for Kumiko apps: per-flow seedTenant, app test stack, canonical test preloads, bunfig generator and integration runner.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -75,9 +75,9 @@
     "kumiko-testing": "./bin/kumiko-testing.ts"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-bundled-features": "0.351.0",
-    "@cosmicdrift/kumiko-dev-server": "0.351.0",
-    "@cosmicdrift/kumiko-framework": "0.351.0",
+    "@cosmicdrift/kumiko-bundled-features": "0.353.0",
+    "@cosmicdrift/kumiko-dev-server": "0.353.0",
+    "@cosmicdrift/kumiko-framework": "0.353.0",
     "zod": "^4.4.3"
   },
   "peerDependencies": {

package/src/changes.json

@@ -1,4 +1,10 @@
 [
+  {
+    "version": "0.353.0",
+    "type": "fix",
+    "title": "E2E webServer infra defaults no longer override keys defined in the app's .env",
+    "detail": "E2E webServer infra defaults no longer override keys defined in the app's `.env`; precedence is shell environment, then `.env`, then the template default"
+  },
   {
     "version": "0.351.0",
     "type": "improvement",

package/src/e2e/define-app-e2e-config.ts

@@ -1,5 +1,8 @@
 import { randomUUID } from "node:crypto";
+import { existsSync, readFileSync } from "node:fs";
 import { availableParallelism } from "node:os";
+import { join } from "node:path";
+import { parseEnv } from "node:util";
 import { isRealProviderRun } from "@cosmicdrift/kumiko-framework/testing/real-providers";
 import {
   defineConfig,
@@ -32,16 +35,25 @@ const OPT_IN_SERVICE_ENV_KEYS: readonly string[] = [
   "MEILI_MASTER_KEY",
 ] satisfies readonly (keyof typeof SERVICE_ENV_DEFAULTS)[];
 
-// A `??` merge per key, not a raw process.env spread — CI or the shell
-// environment wins over the local-dev default without leaking unrelated
-// host env vars into the webServer process.
+// Bun never overrides a variable that is already set, so a default placed in
+// webServer.env would beat the same key in the app's `.env`. Keys the app's
+// `.env` defines are therefore left out and stay with the server's own loading.
+function keysDefinedInAppDotenv(): ReadonlySet<string> {
+  const dotenvPath = join(process.cwd(), ".env");
+  if (!existsSync(dotenvPath)) return new Set();
+  return new Set(Object.keys(parseEnv(readFileSync(dotenvPath, "utf-8"))));
+}
+
+// Precedence per key: shell/CI environment, then the app's `.env`, then the local-dev default.
 function infraEnvDefaults(): Record<string, string> {
+  const definedInAppDotenv = keysDefinedInAppDotenv();
   return Object.fromEntries(
     Object.entries(SERVICE_ENV_DEFAULTS).flatMap(([key, value]) => {
       const fromEnvironment = process.env[key];
       if (OPT_IN_SERVICE_ENV_KEYS.includes(key)) {
         return fromEnvironment === undefined ? [] : [[key, fromEnvironment]];
       }
+      if (fromEnvironment === undefined && definedInAppDotenv.has(key)) return [];
       return [[key, fromEnvironment ?? value]];
     }),
   );

package/src/e2e/screenshots.ts

@@ -714,6 +714,10 @@ async function growViewportToContent(page: Page, name: string, width: number): P
 // spec (solon's `shot(page, id)`, offlot's inline docs/screenshots/e2e/* writes) —
 // reuses the runner's settle logic and reduced-motion default, and is a no-op
 // when SCREENSHOT_DIR is unset so a plain e2e run never writes into the repo.
+// Limitation: the in-flight tracker attaches on the first call per page, so data
+// requests already running at that moment are invisible to it. Right after a
+// click, `await expect(...)` the loaded state (or call this once earlier on the
+// page) before the first shot.
 export async function captureScreenshot(
   page: Page,
   name: string,