@cosmicdrift/kumiko-testing 0.336.0 → 0.336.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-testing",
-  "version": "0.336.0",
+  "version": "0.336.1",
   "description": "Test template for Kumiko apps: per-flow seedTenant, app test stack, canonical test preloads, bunfig generator and integration runner.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -75,9 +75,9 @@
     "kumiko-testing": "./bin/kumiko-testing.ts"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-bundled-features": "0.336.0",
-    "@cosmicdrift/kumiko-dev-server": "0.336.0",
-    "@cosmicdrift/kumiko-framework": "0.336.0",
+    "@cosmicdrift/kumiko-bundled-features": "0.336.1",
+    "@cosmicdrift/kumiko-dev-server": "0.336.1",
+    "@cosmicdrift/kumiko-framework": "0.336.1",
     "zod": "^4.4.3"
   },
   "peerDependencies": {

package/src/changes.json

@@ -1,4 +1,16 @@
 [
+  {
+    "version": "0.336.1",
+    "type": "fix",
+    "title": "DOM preload bounds the printed output of SVG elements as well",
+    "detail": "The DOM preload's bounded print of nodes now covers SVG elements too. Before, printing an `<svg>` in a failed assertion dumped the whole happy-dom object graph (about 10 MB)."
+  },
+  {
+    "version": "0.336.1",
+    "type": "fix",
+    "title": "Scaffolded test:real only matches *.real.test.ts files",
+    "detail": "The scaffolded `test:real` script now filters on `.real.test.ts` instead of `real.test.ts`, so files such as `unreal.test.ts` no longer run under the real-provider environment."
+  },
   {
     "version": "0.335.0",
     "type": "fix",

package/src/e2e/screenshots.ts

@@ -216,6 +216,23 @@ async function restoreIdentitiesOnPage(
   if (mappings.length > 0) await page.evaluate(restoreIdentitiesInDocument);
 }
 
+// Order matters: beforeCapture first (it may hide/mask), identities after, so
+// the replaced text is what the screenshot sees. Exported for unit tests.
+export async function captureScenario(
+  page: Page,
+  scenario: Pick<Scenario, "beforeCapture" | "fullPage" | "captureStyle">,
+  mappings: readonly PresentIdentity[],
+  screenshotOptions: Omit<NonNullable<Parameters<Page["screenshot"]>[0]>, "fullPage" | "style">,
+): Promise<Buffer> {
+  if (scenario.beforeCapture) await scenario.beforeCapture(page);
+  await presentIdentitiesOnPage(page, mappings);
+  return page.screenshot({
+    ...screenshotOptions,
+    fullPage: scenario.fullPage ?? false,
+    ...(scenario.captureStyle !== undefined && { style: scenario.captureStyle }),
+  });
+}
+
 function collectPresentIdentities(): {
   readonly mappings: readonly PresentIdentity[];
   readonly register: (mappings: readonly PresentIdentity[]) => void;
@@ -303,14 +320,8 @@ export function runScreenshots(scenarios: readonly Scenario[], opts: FlatOptions
             seedTenant,
             presentIdentities: identities.register,
           });
-          if (s.beforeCapture) await s.beforeCapture(page);
-          await presentIdentitiesOnPage(page, identities.mappings);
           const path = `${outDir}/${s.name}.png`;
-          await page.screenshot({
-            path,
-            fullPage: s.fullPage ?? false,
-            ...(s.captureStyle !== undefined && { style: s.captureStyle }),
-          });
+          await captureScenario(page, s, identities.mappings, { path });
           expect.soft(statSync(path).size).toBeGreaterThan(MIN_BYTES);
         },
       );
@@ -570,19 +581,15 @@ export function runMatrix<T extends string>(
             for (const vp of plan.viewports) {
               if (plan.mode === "desktop") await page.setViewportSize(viewportSizes[vp]);
               await waitForSettledPage(page, inFlightDataRequests);
-              if (s.beforeCapture) await s.beforeCapture(page);
-              await presentIdentitiesOnPage(page, identities.mappings);
               const dir = `${projectBaseDir}/${s.name}/${locale}/${theme}`;
               mkdirSync(dir, { recursive: true });
               const path = `${dir}/${vp}.png`;
               // animations: "disabled" jumps to end-state at the engine level — immune to CSS specificity, unlike an addStyleTag injection.
               // screenshot() returns the same bytes it writes to `path` — reuse
               // them for both checks instead of a statSync/read-back roundtrip.
-              const buffer = await page.screenshot({
+              const buffer = await captureScenario(page, s, identities.mappings, {
                 path,
-                fullPage: s.fullPage ?? false,
                 animations: "disabled",
-                ...(s.captureStyle !== undefined && { style: s.captureStyle }),
               });
               expect.soft(buffer.length).toBeGreaterThan(MIN_BYTES);
               digests.push({

package/src/preload/dom.ts

@@ -65,15 +65,19 @@ if (typeof globalThis.HTMLElement !== "undefined") {
   if (proto["releasePointerCapture"] === undefined)
     proto["releasePointerCapture"] = () => undefined;
   if (proto["scrollIntoView"] === undefined) proto["scrollIntoView"] = () => undefined;
+}
 
-  // Without this, printing a happy-dom node walks its whole object graph:
-  // ownerDocument plus every React fiber property, which is 15 MB of string
-  // for a two-element tree and 0.5-1.7 s per call. A failed assertion inside
-  // waitFor pays that on every poll and blocks the loop long enough to starve
-  // React's commit and waitFor's own timeout (#3082).
+// Without this, printing a happy-dom node walks its whole object graph:
+// ownerDocument plus every React fiber property, which is 15 MB of string
+// for a two-element tree and 0.5-1.7 s per call. A failed assertion inside
+// waitFor pays that on every poll and blocks the loop long enough to starve
+// React's commit and waitFor's own timeout. On Element, not
+// HTMLElement: SVGElement does not inherit from HTMLElement.
+if (typeof globalThis.Element !== "undefined") {
+  const elementProto = globalThis.Element.prototype as unknown as Record<string | symbol, unknown>;
   const inspect = Symbol.for("nodejs.util.inspect.custom");
-  if (proto[inspect] === undefined) {
-    proto[inspect] = function (this: HTMLElement): string {
+  if (elementProto[inspect] === undefined) {
+    elementProto[inspect] = function (this: Element): string {
       const html = this.outerHTML;
       return html.length > HTML_PRINT_LIMIT ? `${html.slice(0, HTML_PRINT_LIMIT)}…` : html;
     };
@@ -84,15 +88,15 @@ if (typeof globalThis.HTMLElement !== "undefined") {
 // test files in one process, so without afterEach, React components from
 // file N stay mounted in file N+1's DOM.
 //
-// FIVE leak sources:
+// FIVE leak sources (b is NOT cleaned here):
 //
 //   a) testing-library/react container: cleanup() unmounts and removes
 //      every container node render() created.
 //
-//   b) body.replaceChildren(): clears containers not created via
-//      testing-library/react (e.g. #root via ReactDOM.createRoot +
-//      renderShell). Must run after cleanup(), since React needs its nodes
-//      to unmount.
+//   b) Containers not created via testing-library/react (e.g. #root via
+//      ReactDOM.createRoot + renderShell) are not cleaned here: the test
+//      file must unmount them itself, since body.replaceChildren() would
+//      trigger React effects outside act().
 //
 //   c) Radix DismissableLayer sets body.style.pointerEvents='none' when
 //      opening a Dialog/Popover/Dropdown.

package/src/scaffold.ts

@@ -194,9 +194,10 @@ export function renderTestSetup(input: RenderTestSetupInput): ScaffoldTestSetup
       // verified against bun 1.4), so it can't express "match only *.real.test.ts"
       // on its own — every *.test.ts file matches bun's default test glob too,
       // real.test.ts included. The positional filter narrows the run to files
-      // whose path contains "real.test.ts", so an unfiltered test:real never
+      // whose path contains ".real.test.ts" (a bare "real.test.ts" would also
+      // match unreal.test.ts), so an unfiltered test:real never
       // picks up the unit suite.
-      "test:real": `${REAL_PROVIDERS_ENV}=1 bun --config=${BUNFIG_FILES.real} test --timeout=${TEST_TIMEOUT_MS.real} real.test.ts`,
+      "test:real": `${REAL_PROVIDERS_ENV}=1 bun --config=${BUNFIG_FILES.real} test --timeout=${TEST_TIMEOUT_MS.real} .real.test.ts`,
       "test:bunfig": "bun kumiko-testing bunfig --hoisted",
       e2e: "bunx --bun playwright test",
       "e2e:real": `${REAL_PROVIDERS_ENV}=1 bunx --bun playwright test`,