@cosmicdrift/kumiko-server-runtime 0.211.0 → 0.213.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-server-runtime",
-  "version": "0.211.0",
+  "version": "0.213.0",
   "description": "Production server-boot runtime for Kumiko apps: connections, schema-drift-gate, seeds, lifecycle, graceful shutdown. Symmetric to kumiko-dev-server's runDevApp, without dev/scaffold/codegen tooling.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -80,8 +80,8 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-bundled-features": "0.211.0",
-    "@cosmicdrift/kumiko-framework": "0.211.0",
+    "@cosmicdrift/kumiko-bundled-features": "0.213.0",
+    "@cosmicdrift/kumiko-framework": "0.213.0",
     "temporal-polyfill": "^0.3.2"
   },
   "publishConfig": {

package/src/__tests__/build-prod-bundle.test.ts

@@ -12,6 +12,7 @@ import { mkdir, mkdtemp, rm, writeFile } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import {
+  buildMissingTemplateError,
   type ClientEntry,
   computeBuildId,
   discoverClientEntries,
@@ -333,4 +334,49 @@ describe("build-prod-bundle/discovery edges", () => {
     await writeFile(join(workDir, "src/client_admin.tsx"), "// bad");
     expect(discoverClientEntries(workDir)).toEqual([]);
   });
+
+  // #2305: a module only imported by another client-*.tsx still matches
+  // the entry pattern and becomes a second bundle entry.
+  test("discoverClientEntries treats a plain imported module named client-<x>.tsx as its own entry", async () => {
+    await mkdir(join(workDir, "src"), { recursive: true });
+    await writeFile(join(workDir, "src/client-app.tsx"), "// real entry");
+    await writeFile(join(workDir, "src/client-features.tsx"), "export const clientFeatures = [];");
+
+    const entries = discoverClientEntries(workDir);
+
+    expect(entries.map((e) => e.name)).toEqual(["app", "features"]);
+  });
+});
+
+describe("build-prod-bundle/buildMissingTemplateError", () => {
+  function multiEntry(): ClientEntry {
+    return {
+      name: "features",
+      sourceFile: "/Users/dev/offlot-app/src/client-features.tsx",
+      manifestKey: "client-features.js",
+      htmlPath: "features.html",
+    };
+  }
+
+  test("names the discovered source file and the client-<suffix> convention", () => {
+    const message = buildMissingTemplateError(
+      { "client-features.js": "/assets/client-features-abcd.js" },
+      multiEntry(),
+    );
+
+    expect(message).toContain("src/client-features.tsx");
+    expect(message).toContain("client-<suffix>.tsx");
+    expect(message).toContain("umbenennen");
+  });
+
+  test("single-mode entry gets no rename hint (nothing was auto-discovered by suffix)", () => {
+    const message = buildMissingTemplateError(
+      { "client.js": "/assets/client-abcd.js" },
+      clientEntry(),
+    );
+
+    expect(message).toContain("src/client.tsx");
+    expect(message).not.toContain("umbenennen");
+    expect(message).not.toContain("client-<suffix>.tsx");
+  });
 });

package/src/build-prod-bundle.ts

@@ -536,7 +536,9 @@ async function renderHtml(
   return injectAssetTags(template, manifest, entry, buildInfo);
 }
 
-function buildMissingTemplateError(manifest: BuildManifest, entry: ClientEntry): string {
+// @internal — exported for unit tests only. See #2305: the message must
+// name the source file and the filename convention.
+export function buildMissingTemplateError(manifest: BuildManifest, entry: ClientEntry): string {
   const cssLine = manifest["styles.css"]
     ? `    <link rel="stylesheet" href="/styles.css" />\n`
     : "";
@@ -544,8 +546,22 @@ function buildMissingTemplateError(manifest: BuildManifest, entry: ClientEntry):
     ? // html-ok: Error-Hilfetext (Tag-Snippet als Text), wird nie gerendert.
       `    <script type="module" src="/${entry.manifestKey}"></script>\n`
     : "";
+  const sourceBasename = basenameOf(entry.sourceFile);
+  // Single-mode entries always carry manifestKey "client.js"; any other
+  // value came from discoverMultiClientEntries' filename match.
+  const isMultiEntry = entry.manifestKey !== "client.js";
+  const discoveryHint = isMultiEntry
+    ? `"src/${sourceBasename}" wurde automatisch als eigener Bundle-Entry erkannt — ` +
+      `jede Datei nach dem Muster src/client-<suffix>.tsx zählt als Entry (hier: Suffix "${entry.name}"). ` +
+      `War das nicht beabsichtigt, z. B. weil die Datei nur ein von einem anderen client-*.tsx ` +
+      `importiertes Modul ist: Datei umbenennen (ohne "client-"-Präfix), dann verschwindet der Entry.\n` +
+      `\n` +
+      `War es beabsichtigt:\n`
+    : "";
   return (
-    `[kumiko build] kein ${entry.htmlPath} gefunden, aber es gibt JS/CSS-Output.\n` +
+    `[kumiko build] kein ${entry.htmlPath} gefunden für Entry "src/${sourceBasename}", ` +
+    `aber es gibt JS/CSS-Output.\n` +
+    discoveryHint +
     `Leg ein public/${basenameOf(entry.htmlPath)} oder ${basenameOf(entry.htmlPath)} im App-Root an, z. B.:\n` +
     `\n` +
     `<!doctype html>\n` +

package/src/compose-features.ts

@@ -39,12 +39,12 @@ export type ComposeFeaturesOptions = {
    *  (+ auth-self-registration when authOptions.signup is set) before the
    *  app features. Mirror of "auth-mode" in run{Dev,Prod}App. */
   readonly includeBundled: boolean;
-  /** Optional auth-feature-options durchgereicht an
-   *  createAuthEmailPasswordFeature. Wenn passwordReset / emailVerification
-   *  hier gesetzt sind, registriert das Feature die request-/confirm-
-   *  Handler — sonst NICHT (500 wenn die routes via auth-routes.ts
-   *  gemounted sind aber kein Handler dispatcht). Hand-in-hand mit dem
-   *  passwordReset-Block in RunProdAppAuthOptions / RunDevAppAuthOptions. */
+  /** Optional auth-feature options passed through to
+   *  createAuthEmailPasswordFeature. When passwordReset / emailVerification
+   *  are set here, the feature registers the request/confirm handlers —
+   *  otherwise it doesn't (500 if the routes are mounted via
+   *  auth-routes.ts but no handler dispatches). Goes hand-in-hand with the
+   *  passwordReset block in RunProdAppAuthOptions / RunDevAppAuthOptions. */
   readonly authOptions?: AuthEmailPasswordOptions;
 };
 
@@ -108,13 +108,12 @@ export function composeFeatures(
   return [...bundled, ...filteredApp];
 }
 
-/** Shape eines beliebigen run{Prod,Dev}App-Auth-Blocks der eine
- *  PasswordReset/EmailVerification-Konfiguration tragen kann. Die
- *  Wrapper-API (PasswordResetSetup) extends die Feature-API
- *  (PasswordResetOptions), darum reicht ein structural-typed
- *  Lookup auf den auth-only-Subset. Erlaubt buildComposeAuthOptions
- *  mit RunProd- UND RunDev-AuthOptions zu callen ohne den Helper
- *  doppelt zu bauen. */
+/** Shape of any run{Prod,Dev}App auth block that can carry a
+ *  passwordReset/emailVerification config. The wrapper API
+ *  (PasswordResetSetup) extends the feature API (PasswordResetOptions), so
+ *  a structural-typed lookup on the auth-only subset is enough. Lets
+ *  buildComposeAuthOptions be called with both RunProd- and
+ *  RunDev-AuthOptions without building the helper twice. */
 export type AuthOptionsCarrier = {
   readonly passwordReset?: PasswordResetOptions;
   readonly emailVerification?: EmailVerificationOptions;
@@ -124,24 +123,26 @@ export type AuthOptionsCarrier = {
   readonly accountLockout?: AccountLockoutOptions;
 };
 
-/** Baut den authOptions-Block für composeFeatures aus einem
- *  Wrapper-Auth-Block. Reicht NUR die feature-side-Felder
- *  (hmacSecret, tokenTtlMinutes, mode) durch — die mail-side
- *  (sendResetEmail/appResetUrl) gehört in die auth-routes-config
- *  und wird vom Wrapper separat verdrahtet.
+/** Builds the authOptions block for composeFeatures from a wrapper auth
+ *  block. Passes through ONLY the feature-side fields (hmacSecret,
+ *  tokenTtlMinutes, mode) — the mail side (sendResetEmail/appResetUrl)
+ *  belongs in the auth-routes config and is wired separately by the
+ *  wrapper.
  *
- *  Returnt undefined wenn weder passwordReset noch emailVerification
- *  gesetzt sind (composeFeatures default-deny: KEINE handler in der
- *  Registry registriert, /api/auth/request-password-reset etc. bleiben
- *  401/404). */
+ *  Returns undefined when neither passwordReset nor emailVerification is
+ *  set (composeFeatures default-deny: NO handler registered in the
+ *  registry, /api/auth/request-password-reset etc. stay 401/404). */
+// All five magic-link flows (reset/verify/signup/invite/unlock) accept the
+// same appUrl shape — a plain string, or a `(locale) => string` function for
+// apps with language-in-path routing (see SignupRequestOptions.appUrl).
 type MailFlowFields = {
-  readonly appUrl: string;
+  readonly appUrl: string | ((locale: string) => string);
   readonly tokenTtlMinutes?: number;
   readonly appName?: string;
   readonly locale?: AuthMailLocale;
 };
 
-// The magic-link mail fields shared by all four flows. Conditional spreads omit
+// The magic-link mail fields shared by all five flows. Conditional spreads omit
 // undefined keys (exactOptionalPropertyTypes) and avoid the property-write that
 // trips noPropertyAccessFromIndexSignature on the type-aliased option shapes.
 // reset/verify layer hmacSecret (+ mode) on top.