@cosmicdrift/kumiko-samples 0.392.1 → 0.392.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-samples",
-  "version": "0.392.1",
+  "version": "0.392.2",
   "description": "Source trees of the Kumiko sample recipes, sample apps and bundled features in repo layout, for tooling such as few-shot corpus builds.",
   "license": "MIT",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",

package/packages/bundled-features/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-bundled-features",
-  "version": "0.392.1",
+  "version": "0.392.2",
   "description": "Built-in features — tenant, user, auth, delivery. The stuff you'd rewrite anyway, already typed.",
   "license": "MIT",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",

package/packages/bundled-features/src/inbound-mail-foundation/changes.json

@@ -1,4 +1,16 @@
 [
+  {
+    "version": "0.392.2",
+    "type": "fix",
+    "title": "Mail sync no longer fails when reading IMAP credentials",
+    "detail": "createInboundMailSupervisor builds its provider context with auditUserId defaulting to the system user. Apps that did not set auditUserId in providerCtx got an internal error on every fetch and watch because the secrets context needs an audit identity. An explicitly set auditUserId is kept."
+  },
+  {
+    "version": "0.392.2",
+    "type": "fix",
+    "title": "Mail sync finds the stored IMAP credentials under row-level security",
+    "detail": "createInboundMailSupervisor runs outside any request, so secret reads ran without a tenant scope and the application role saw no row in read_tenant_secrets. The supervisor now wraps providerCtx.secrets with tenantScopedSecrets, which the framework exports from internal/row-level-security. inbound-provider-inmemory gains requireCredentialSecretOnFetch so tests can exercise credential reads; a new integration test runs the secrets against an application-role database."
+  },
   {
     "version": "0.392.0",
     "type": "fix",

package/packages/bundled-features/src/inbound-mail-foundation/types.ts

@@ -24,7 +24,7 @@ import type { OutboundMailMessage, OutboundMailSent } from "./outbound-mail.ts";
  *   secrets  — tenant secret reads (IMAP password, OAuth refresh token)
  *   auditUserId  — audit identity for secret reads. Handler path: unset,
  *              requireSecretsContext falls back to ctx.user.id; worker/provider
- *              path: system identity set by the resolver.
+ *              path: the supervisor sets the system identity.
  *   metricsFor — metrics handle of a feature by name, same behavior as
  *              HandlerContext.metricsFor: unregistered metrics are a silent
  *              no-op instead of a throw.

package/packages/bundled-features/src/inbound-mail-foundation/watch-supervisor.ts

@@ -49,7 +49,11 @@ import {
 } from "@cosmicdrift/kumiko-framework/crypto";
 import type { DbConnection } from "@cosmicdrift/kumiko-framework/db";
 import { fetchOne, insertOne, selectMany, updateMany } from "@cosmicdrift/kumiko-framework/db";
-import { systemScopedRunner } from "@cosmicdrift/kumiko-framework/internal/row-level-security";
+import { SYSTEM_USER_ID } from "@cosmicdrift/kumiko-framework/engine";
+import {
+  systemScopedRunner,
+  tenantScopedSecrets,
+} from "@cosmicdrift/kumiko-framework/internal/row-level-security";
 import type { DistributedLock } from "@cosmicdrift/kumiko-framework/pipeline";
 import { Temporal } from "@cosmicdrift/kumiko-types/temporal";
 import { isPlainObject } from "@cosmicdrift/kumiko-types/type-guards";
@@ -186,17 +190,25 @@ export function createInboundMailSupervisor(
   // configured TTL — real deployments (default 90s) never hit it.
   const renewIntervalMs = Math.max(50, Math.floor((leaseTtlSeconds * 1000) / 3));
   const log = deps.log ?? (() => {});
+  // The supervisor runs outside any request: secret reads need an audit
+  // identity, and under enforced row-level security they need the account's
+  // tenant scope, or the credential row is invisible and reads as missing.
+  const providerCtx: InboundMailContext = {
+    ...deps.providerCtx,
+    auditUserId: deps.providerCtx.auditUserId ?? SYSTEM_USER_ID,
+    ...(deps.providerCtx.secrets && { secrets: tenantScopedSecrets(deps.providerCtx.secrets) }),
+  };
   const systemDb = systemScopedRunner(
     deps.db,
     "mail sync supervisor polls accounts and cursors of all tenants outside a request",
   );
   const oauthTokens =
     deps.oauthTokens ??
-    (deps.providerCtx.secrets
+    (providerCtx.secrets
       ? createOAuthAccessTokenManager({
           db: systemDb,
-          secrets: deps.providerCtx.secrets,
-          providerCtx: deps.providerCtx,
+          secrets: providerCtx.secrets,
+          providerCtx,
         })
       : undefined);
 
@@ -447,7 +459,7 @@ export function createInboundMailSupervisor(
       // exhausted.
       for (;;) {
         const accessToken = await resolveAccessToken(account, plugin);
-        const result = await plugin.fetch(deps.providerCtx, account, cursor, {
+        const result = await plugin.fetch(providerCtx, account, cursor, {
           backfillWindowDays,
           maxMessages: budget,
           filterUnknownMessageIds: unknownMessageIdsFilterFor(account),
@@ -469,7 +481,7 @@ export function createInboundMailSupervisor(
     for (const account of accounts) {
       let plugin: InboundMailProviderPlugin;
       try {
-        plugin = resolveInboundProviderForAccount(deps.providerCtx, account);
+        plugin = resolveInboundProviderForAccount(providerCtx, account);
       } catch (err) {
         log(`inbound-mail: ${describeError(err)}`);
         continue;
@@ -642,7 +654,7 @@ export function createInboundMailSupervisor(
     try {
       const accessToken = await resolveAccessToken(account, plugin);
       const stop = await plugin.watch(
-        deps.providerCtx,
+        providerCtx,
         account,
         {
           onMessages: async (msgs) => {

package/packages/bundled-features/src/inbound-provider-inmemory/feature.ts

@@ -11,13 +11,16 @@
 // **Pattern basis:** mail-transport-inmemory (module-level state +
 // test-helper exports). Not for production.
 
-import type {
-  InboundFetchResult,
-  InboundMailProviderPlugin,
-  MailAccountRecord,
-  RawInboundMessage,
-  SyncCursorPayload,
+import {
+  InboundAuthError,
+  type InboundFetchResult,
+  type InboundMailContext,
+  type InboundMailProviderPlugin,
+  type MailAccountRecord,
+  type RawInboundMessage,
+  type SyncCursorPayload,
 } from "@cosmicdrift/kumiko-bundled-features/inbound-mail-foundation";
+import { requireSecretsContext } from "@cosmicdrift/kumiko-bundled-features/secrets";
 import { defineFeature } from "@cosmicdrift/kumiko-framework/engine";
 
 const FEATURE_NAME = "inbound-provider-inmemory";
@@ -38,6 +41,7 @@ type AccountState = {
   watch: WatchHandlers | null;
   nextFetchError: unknown;
   nextVerifyError: unknown;
+  credentialSecretKey: string | null;
 };
 
 const accounts = new Map<string, AccountState>();
@@ -45,7 +49,13 @@ const accounts = new Map<string, AccountState>();
 function stateFor(accountId: string): AccountState {
   let state = accounts.get(accountId);
   if (!state) {
-    state = { log: [], watch: null, nextFetchError: null, nextVerifyError: null };
+    state = {
+      log: [],
+      watch: null,
+      nextFetchError: null,
+      nextVerifyError: null,
+      credentialSecretKey: null,
+    };
     accounts.set(accountId, state);
   }
   return state;
@@ -71,6 +81,25 @@ export function failNextVerifyWith(accountId: string, err: unknown): void {
   stateFor(accountId).nextVerifyError = err;
 }
 
+/** Test helper: every fetch reads this tenant secret first, like a real
+ *  provider reads its stored credentials; a missing secret is an auth error. */
+export function requireCredentialSecretOnFetch(accountId: string, key: string): void {
+  stateFor(accountId).credentialSecretKey = key;
+}
+
+async function readCredentialSecret(
+  ctx: InboundMailContext,
+  account: MailAccountRecord,
+  key: string,
+): Promise<void> {
+  const secrets = requireSecretsContext(
+    { secrets: ctx.secrets, auditUserId: ctx.auditUserId },
+    FEATURE_NAME,
+  );
+  const secret = await secrets.get(account.tenantId, key);
+  if (!secret) throw new InboundAuthError(`${FEATURE_NAME}: no credential secret ${key}`);
+}
+
 /** Test helper: simulates the live connection terminating (the supervisor
  *  must restart with backoff). */
 export function emitWatchError(accountId: string, err: unknown): void {
@@ -111,13 +140,16 @@ export const inMemoryInboundMailPlugin: InboundMailProviderPlugin = {
       throw err;
     }
   },
-  fetch: async (_ctx, account, cursor, opts): Promise<InboundFetchResult> => {
+  fetch: async (ctx, account, cursor, opts): Promise<InboundFetchResult> => {
     const state = stateFor(account.id);
     if (state.nextFetchError) {
       const err = state.nextFetchError;
       state.nextFetchError = null;
       throw err;
     }
+    if (state.credentialSecretKey) {
+      await readCredentialSecret(ctx, account, state.credentialSecretKey);
+    }
     const offset = offsetOf(cursor);
     const slice = state.log.slice(offset, offset + opts.maxMessages);
     const nextOffset = offset + slice.length;

package/packages/bundled-features/src/inbound-provider-inmemory/index.ts

@@ -7,6 +7,7 @@ export {
   failNextVerifyWith,
   INMEMORY_PROVIDER_KEY,
   isWatching,
+  requireCredentialSecretOnFetch,
   resetInboundInMemory,
   seedInboundMessage,
 } from "./feature.ts";