@cosmicdrift/kumiko-samples 0.371.1 → 0.373.0

package/packages/bundled-features/src/shared/purge-row-file-refs.ts

@@ -0,0 +1,214 @@
+import { type DbRunner, selectMany, type WhereObject } from "@cosmicdrift/kumiko-framework/db";
+import type { EntityDefinition, Registry, TenantId } from "@cosmicdrift/kumiko-framework/engine";
+import { fileRefsTable } from "@cosmicdrift/kumiko-framework/files";
+import { propertyOf } from "@cosmicdrift/kumiko-types/type-guards";
+
+type EntityFields = EntityDefinition["fields"];
+type EntityTable = Parameters<typeof selectMany>[1];
+
+export type FileFieldPlan = {
+  /** type file|image: the fileRef-id lives directly in the entity column. */
+  readonly singleFields: readonly string[];
+  /** type files|images: resolved via file_refs (bound by entityType/entityId/fieldName). */
+  readonly multiFields: readonly string[];
+};
+
+export type SingleFileHolder = {
+  readonly table: EntityTable;
+  readonly tableHasTenantId: boolean;
+  readonly singleFields: readonly string[];
+};
+
+export type FileRefPurgeOutcome = "purged" | "missing_file_storage" | "file_delete_failed";
+
+const NO_FILE_FIELDS: FileFieldPlan = { singleFields: [], multiFields: [] };
+
+// Same set as boot-validator/entity-handler.ts FILE_FIELD_TYPES; the single/multi split
+// matters here because only plural fields resolve through file_refs.
+export function planFileFields(
+  fields: EntityFields,
+  fieldNames?: readonly string[],
+): FileFieldPlan {
+  const singleFields: string[] = [];
+  const multiFields: string[] = [];
+  for (const [name, field] of Object.entries(fields)) {
+    if (fieldNames !== undefined && !fieldNames.includes(name)) continue;
+    if (field.type === "file" || field.type === "image") singleFields.push(name);
+    else if (field.type === "files" || field.type === "images") multiFields.push(name);
+  }
+  return singleFields.length > 0 || multiFields.length > 0
+    ? { singleFields, multiFields }
+    : NO_FILE_FIELDS;
+}
+
+// Every implicit entity table with file/image fields: an unbound fileRef
+// (POST /files without entityType/entityId) can sit in single fields of
+// several entity types, so the sharing check must look beyond the purged
+// row's own table.
+export function collectSingleFileHolders(registry: Registry): readonly SingleFileHolder[] {
+  const holders: SingleFileHolder[] = [];
+  for (const proj of registry.getAllProjections().values()) {
+    if (proj.isImplicit !== true || typeof proj.source !== "string" || !proj.table) continue;
+    const entity = registry.getEntity(proj.source);
+    if (!entity) continue;
+    const { singleFields } = planFileFields(entity.fields);
+    if (singleFields.length === 0) continue;
+    holders.push({
+      table: proj.table,
+      tableHasTenantId: propertyOf(proj.table, "tenantId") !== undefined,
+      singleFields,
+    });
+  }
+  return holders;
+}
+
+// Every fileRef-id a row's file-fields reference: single fields hold the id in
+// their own column, plural fields resolve via file_refs (tenantId, entityType,
+// entityId, fieldName).
+async function collectFileRefIds(
+  db: DbRunner,
+  tenantId: TenantId,
+  entityName: string,
+  row: Record<string, unknown>,
+  plan: FileFieldPlan,
+): Promise<readonly string[]> {
+  const ids = new Set<string>();
+  for (const field of plan.singleFields) {
+    const value = row[field];
+    if (typeof value === "string" && value.length > 0) ids.add(value);
+  }
+  if (plan.multiFields.length > 0) {
+    const refRows = await selectMany<{ id: string }>(db, fileRefsTable, {
+      tenantId,
+      entityType: entityName,
+      entityId: String(row["id"]),
+      fieldName: { in: plan.multiFields },
+    });
+    for (const r of refRows) ids.add(r.id);
+  }
+  return Array.from(ids);
+}
+
+// A fileRef is bound to a DIFFERENT entity/record (or, when only some fields are
+// purged, to another field of this row) than the one being purged — its binding,
+// not the row's own single-field column, decides ownership.
+function isFileRefBoundElsewhere(
+  fileRef: Record<string, unknown>,
+  entityName: string,
+  rowId: string,
+  fieldNames: readonly string[] | undefined,
+): boolean {
+  const entityType = fileRef["entityType"];
+  const entityId = fileRef["entityId"];
+  const fieldName = fileRef["fieldName"];
+  if (typeof entityType === "string" && entityType !== entityName) return true;
+  if (typeof entityId === "string" && entityId !== rowId) return true;
+  if (
+    fieldNames !== undefined &&
+    typeof fieldName === "string" &&
+    !fieldNames.includes(fieldName)
+  ) {
+    return true;
+  }
+  return false;
+}
+
+// A single-field fileRef-id can be shared by more than one row, in the SAME
+// table or in another entity's table; with a partial field set, also by another
+// field of the same row. Purging its bytes would corrupt the holder that stays.
+async function isFileRefSharedByOtherHolder(
+  db: DbRunner,
+  holders: readonly SingleFileHolder[],
+  ownTable: EntityTable,
+  tenantId: TenantId,
+  rowId: string,
+  fileRefId: string,
+  fieldNames: readonly string[] | undefined,
+): Promise<boolean> {
+  for (const holder of holders) {
+    for (const field of holder.singleFields) {
+      const where: WhereObject = { [field]: fileRefId };
+      if (holder.table === ownTable) {
+        const fieldIsPurged = fieldNames === undefined || fieldNames.includes(field);
+        where["id"] = fieldIsPurged ? { ne: rowId } : rowId;
+      }
+      if (holder.tableHasTenantId) where["tenantId"] = tenantId;
+      const others = await selectMany(db, holder.table, where, { limit: 1 });
+      if (others.length > 0) return true;
+    }
+  }
+  return false;
+}
+
+// Deletes the un-shared fileRefs a row's file-fields reference: bytes (incl.
+// derivatives) first, then the fileRef rows — bytes before rows so a crash
+// mid-way leaves an orphaned fileRef pointing at already-gone bytes (a later
+// run's delete is idempotent) rather than a gone fileRef whose bytes leak forever.
+// The entity row itself is the caller's business. `fieldNames` narrows the purge
+// to those fields; without it every file-field of the entity is purged.
+export async function purgeRowFileRefs(args: {
+  readonly db: DbRunner;
+  readonly tenantId: TenantId;
+  readonly entityName: string;
+  readonly entity: EntityDefinition;
+  readonly table: EntityTable;
+  readonly fileHolders: readonly SingleFileHolder[];
+  readonly row: Record<string, unknown>;
+  readonly fieldNames?: readonly string[];
+  /** Returns the keys whose delete failed; undefined = no storage reachable. */
+  readonly deleteBytes: ((storageKey: string) => Promise<readonly string[]>) | undefined;
+  readonly fileRefForget: (fileRefId: string) => Promise<boolean>;
+  readonly onBytesDeleteFailed?: (failedKeys: readonly string[]) => void;
+}): Promise<FileRefPurgeOutcome> {
+  const rowId = String(args.row["id"]);
+  const plan = planFileFields(args.entity.fields, args.fieldNames);
+  const fileRefIds = await collectFileRefIds(
+    args.db,
+    args.tenantId,
+    args.entityName,
+    args.row,
+    plan,
+  );
+  if (fileRefIds.length === 0) return "purged";
+
+  const fileRefRows = await selectMany<Record<string, unknown>>(args.db, fileRefsTable, {
+    id: { in: fileRefIds },
+    tenantId: args.tenantId,
+  });
+
+  const toDelete: Record<string, unknown>[] = [];
+  for (const fileRef of fileRefRows) {
+    if (isFileRefBoundElsewhere(fileRef, args.entityName, rowId, args.fieldNames)) continue;
+    const shared = await isFileRefSharedByOtherHolder(
+      args.db,
+      args.fileHolders,
+      args.table,
+      args.tenantId,
+      rowId,
+      String(fileRef["id"]),
+      args.fieldNames,
+    );
+    if (shared) continue;
+    toDelete.push(fileRef);
+  }
+  if (toDelete.length === 0) return "purged";
+
+  if (!args.deleteBytes) return "missing_file_storage";
+
+  let anyFailed = false;
+  for (const fileRef of toDelete) {
+    const key = fileRef["storageKey"];
+    if (typeof key !== "string" || key.length === 0) continue;
+    const failedKeys = await args.deleteBytes(key);
+    if (failedKeys.length > 0) {
+      anyFailed = true;
+      args.onBytesDeleteFailed?.(failedKeys);
+    }
+  }
+  if (anyFailed) return "file_delete_failed";
+
+  for (const fileRef of toDelete) {
+    if (!(await args.fileRefForget(String(fileRef["id"])))) return "file_delete_failed";
+  }
+  return "purged";
+}

package/packages/bundled-features/src/template-resolver/changes.json

@@ -1,4 +1,10 @@
 [
+  {
+    "version": "0.372.0",
+    "type": "improvement",
+    "title": "Text examples of template variables follow the template's language",
+    "detail": "The `example` of a text or richText templateVariable is now read like `label`: an i18n key resolves to the translation of the edited template's locale, plain text stays as it is. Preview, the sample values bar and send-test therefore show German examples for a German template. Example values of other types (link, number, enum-like text values) stay as declared; put the explanation of such a value into the variable's label. Apps: register `templateVariable.text({ example: \"<app>:mail.example.x\" })` and add the key with de, en and es via `r.translations`."
+  },
   {
     "version": "0.370.0",
     "type": "improvement",

package/packages/bundled-features/src/template-resolver/template-preview.ts

@@ -57,11 +57,27 @@ const SAMPLE_LINK = "https://example.com";
 const SAMPLE_DATE = "2026-01-15";
 const SAMPLE_LIST_ROWS = 3;
 
-// A variable label is an i18n key or plain text; an unknown key reads as itself.
+// A variable label, and the example of a text variable, is an i18n key or plain text; an unknown
+// key reads as itself.
 type LabelText = (label: string) => string;
 
+function isTranslatableExample(
+  def: TemplateScalarVariableDef,
+  example: unknown,
+): example is string {
+  return (def.type === "text" || def.type === "richText") && typeof example === "string";
+}
+
+function exampleFor(
+  def: TemplateScalarVariableDef,
+  example: unknown,
+  labelText: LabelText,
+): unknown {
+  return isTranslatableExample(def, example) ? labelText(example) : example;
+}
+
 function sampleScalar(name: string, def: TemplateScalarVariableDef, labelText: LabelText): unknown {
-  if (def.example !== undefined) return def.example;
+  if (def.example !== undefined) return exampleFor(def, def.example, labelText);
   const label = def.label === undefined ? name : labelText(def.label);
   switch (def.type) {
     case "text":
@@ -85,8 +101,12 @@ function sampleRow(
   given: Readonly<Record<string, unknown>> = {},
 ): Record<string, unknown> {
   const row: Record<string, unknown> = {};
-  for (const [name, def] of Object.entries(item)) row[name] = sampleScalar(name, def, labelText);
-  return { ...row, ...given };
+  for (const [name, def] of Object.entries(item)) {
+    row[name] = Object.hasOwn(given, name)
+      ? exampleFor(def, given[name], labelText)
+      : sampleScalar(name, def, labelText);
+  }
+  return { ...given, ...row };
 }
 
 function sampleList(def: TemplateListVariableDef, labelText: LabelText): Record<string, unknown>[] {

package/packages/bundled-features/src/template-resolver/web/client-plugin.tsx

@@ -1,3 +1,4 @@
+import { EMPTY_VALUE_PLACEHOLDER } from "@cosmicdrift/kumiko-headless";
 // @runtime client
 // Client feature factory for the text-block content tree. Apps mount it via
 // createKumikoApp({ clientFeatures: [textBlocksClient()] }); it loads the
@@ -399,7 +400,7 @@ function TextBlockEditor({
     <Form
       onSubmit={onSubmit}
       testId="text-block-editor"
-      title={title || slug || "—"}
+      title={title || slug || EMPTY_VALUE_PLACEHOLDER}
       subtitle={locale !== "" ? `${slug} · (${locale})` : slug}
       actions={
         canWrite ? (

package/packages/bundled-features/src/template-resolver/web/document-editor-extensions.ts

@@ -63,7 +63,6 @@ function repeatRowListAt(doc: ProseMirrorNode, position: number | undefined): st
 export function createVariableView(
   variableLabels: Readonly<Record<string, string>>,
   systemVariables: readonly string[],
-  labelOnly = false,
 ): NodeViewRenderer {
   return ({ node, editor, getPos }) => {
     const name = String(node.attrs["name"]);
@@ -79,9 +78,6 @@ export function createVariableView(
     const hasOwnLabel = label !== undefined && label !== "" && label !== name;
     dom.append(document.createTextNode(hasOwnLabel ? label : name));
     if (hasOwnLabel) dom.title = name;
-    if (!labelOnly && hasOwnLabel) {
-      dom.append(createElementWithClass("small", "font-mono text-[10px] opacity-75", name));
-    }
     return { dom };
   };
 }
@@ -218,11 +214,7 @@ export function createDocumentEditorExtensions(labels: DocumentEditorLabels): Ex
       case DocumentVariable.name:
         return DocumentVariable.extend({
           addNodeView: () =>
-            createVariableView(
-              labels.variableLabels ?? {},
-              labels.systemVariables ?? [],
-              labels.blockLabels === true,
-            ),
+            createVariableView(labels.variableLabels ?? {}, labels.systemVariables ?? []),
         });
       case DocumentResource.name:
         return DocumentResource.extend({ addNodeView: () => createResourceView(labels) });

package/packages/bundled-features/src/template-resolver/web/placeholder-line-editor.tsx

@@ -96,13 +96,13 @@ function LineEditorBody({
         undoRedo: false,
       }),
       DocumentVariable.extend({
-        addNodeView: () => createVariableView(variableLabels, systemVariables, flat),
+        addNodeView: () => createVariableView(variableLabels, systemVariables),
       }),
       UndoRedo,
       BlockLineBreaks,
       ...(placeholder === undefined ? [] : [Placeholder.configure({ placeholder })]),
     ],
-    [variableLabels, systemVariables, flat, placeholder],
+    [variableLabels, systemVariables, placeholder],
   );
 
   const editor = useEditor({

package/packages/bundled-features/src/user-data-rights/changes.json

@@ -1,4 +1,10 @@
 [
+  {
+    "version": "0.372.0",
+    "type": "fix",
+    "title": "Account forget-cleanup removes userOwned files uploaded by someone else",
+    "detail": "runForgetCleanup now purges the bytes, derivatives and file_refs rows behind every file field whose subject is the deleted user, not only files the user uploaded; a failing byte delete keeps the user in DeletionRequested so the next run retries."
+  },
   {
     "version": "0.369.0",
     "type": "fix",

package/packages/bundled-features/src/user-data-rights/run-forget-cleanup.ts

@@ -50,6 +50,7 @@ import {
   selectMany,
   WritePurposes,
 } from "@cosmicdrift/kumiko-framework/db";
+import { deleteStoredFileAndDerivatives } from "@cosmicdrift/kumiko-framework/derivatives";
 import {
   type EscapeHatchAuditSink,
   EXT_USER_DATA,
@@ -75,7 +76,12 @@ import {
   resolveRetentionPolicyForTenant,
   resolveTenantRetentionPreset,
 } from "../data-retention/index.ts";
-import { decryptStoredPii, runInSubTransaction } from "../shared/index.ts";
+import {
+  type DeleteFileBytes,
+  decryptStoredPii,
+  purgeFilesReachingSubject,
+  runInSubTransaction,
+} from "../shared/index.ts";
 import { tenantMembershipsTable } from "../tenant/index.ts";
 import { USER_STATUS, userTable } from "../user/index.ts";
 import { selectUsersDueForForgetCleanup } from "./db/queries/forget-cleanup.ts";
@@ -450,6 +456,25 @@ async function processUser(args: {
         );
       }
 
+      // Same ordering rationale: the files are found through the entity rows a
+      // hook may hard-delete, and a file whose uploader differs from the owner
+      // is never reached by the fileRef hook (it keys on insertedById).
+      await purgeFilesReachingSubject({
+        registry,
+        db: tx,
+        subject: { kind: "user", userId },
+        subjectKey: subjectIdToKey({ kind: "user", userId }),
+        resolveDeleteBytes: resolveForgetFileBytesDeleter(buildStorageProvider),
+        missingStorage: {
+          mode: "skip",
+          warn: (tenantId) =>
+            // biome-ignore lint/suspicious/noConsole: misconfiguration visibility, same as the fileRef delete hook
+            console.warn(
+              `[user-data-rights:run-forget-cleanup] no file provider resolvable for tenantId=${tenantId} - file binaries of userId=${userId} are NOT deleted (rows kept). Mount file-foundation + a file-provider-* feature so erasure can reach the binaries.`,
+            ),
+        },
+      });
+
       for (const tenantId of tenantList) {
         currentTenantId = tenantId;
         // Refine the app-level model to THIS tenant: "single-user" only if the
@@ -576,6 +601,26 @@ async function processUser(args: {
   };
 }
 
+// A resolution failure collapses to "no storage" like in the fileRef delete hook; a failing
+// byte delete throws through the sweep so the per-user sub-tx rolls back and the next run retries.
+function resolveForgetFileBytesDeleter(
+  buildStorageProvider: RunForgetCleanupArgs["buildStorageProvider"],
+): (tenantId: TenantId) => Promise<DeleteFileBytes | undefined> {
+  return async (tenantId) => {
+    if (!buildStorageProvider) return undefined;
+    try {
+      const provider = await buildStorageProvider(tenantId);
+      return (
+        provider &&
+        ((key) => deleteStoredFileAndDerivatives(key, provider, "user-data-rights:forget-cleanup"))
+      );
+    } catch {
+      // skip: provider unresolvable (not configured) -> files skipped with a warn, like the hook
+      return undefined;
+    }
+  };
+}
+
 // Pseudo-Tenant fuer User ohne aktive Memberships. RFC4122-konforme
 // Null-UUID. Tenant-scoped Hooks finden hier nichts (no-op),
 // tenant-agnostische Hooks (z.B. user) operieren auf der globalen

package/packages/bundled-features/src/user-data-rights/web/privacy-center-screen.tsx

@@ -1,3 +1,4 @@
+import { EMPTY_VALUE_PLACEHOLDER } from "@cosmicdrift/kumiko-headless";
 // @runtime client
 // Export section (Art. 20) — the one part of user-data-rights' privacy-center
 // screen that stays custom (fw#2312). Registered as an EditExtensionSection
@@ -57,7 +58,7 @@ function failureKey(error: unknown): string {
 // Roher ISO-Instant → nur der Datums-Teil ist relevant; reiner String-Slice,
 // kein Date-API (no-date-api-Guard) und universell. Leer/null → "—".
 export function formatDate(iso: string | null | undefined): string {
-  if (!iso) return "—";
+  if (!iso) return EMPTY_VALUE_PLACEHOLDER;
   const tIndex = iso.indexOf("T");
   return tIndex > 0 ? iso.slice(0, tIndex) : iso;
 }

package/samples/apps/styleguide/src/features/demo/feature.ts

@@ -102,7 +102,7 @@ export const demoFeature = defineFeature("styleguide", (r) => {
       if (!source) return failNotFound("item", event.payload.id);
       return itemExecutor.create(
         {
-          name: `${source["name"] as string} (Copy)`,
+          name: `${source["name"]} (Copy)`,
           description: source["description"],
           quantity: source["quantity"],
           rating: source["rating"],

package/samples/apps/ui-walkthrough/src/app/seed-rental.ts

@@ -14,6 +14,7 @@ type BoardLease = {
   readonly beginn: string;
   readonly ende?: string;
   readonly miete: number;
+  readonly vorgaengerIndex?: number;
 };
 
 const BOARD_LEASES: readonly BoardLease[] = [
@@ -101,6 +102,7 @@ const BOARD_LEASES: readonly BoardLease[] = [
     beginn: "2026-01-01",
     ende: "2026-08-31",
     miete: 700,
+    vorgaengerIndex: 0,
   },
   {
     mieter: "Karl Positionsende",
@@ -229,6 +231,9 @@ export const seedRental: SeedFn = async (stack) => {
         grundmiete: eur(lease.miete),
         kuendigungsfrist: "3 Monate",
         zahltag: 3,
+        ...(lease.vorgaengerIndex !== undefined && {
+          vorgaenger: boardLeaseId(lease.vorgaengerIndex),
+        }),
       },
       TestUsers.admin,
       db,

package/samples/apps/ui-walkthrough/src/app/template-seed-data.ts

@@ -226,6 +226,8 @@ const tenantInvoiceMeta = (subject: string) => ({
   ...invoiceIssuedMeta(subject),
   senderName: "Nordlicht Immobilien GmbH",
   replyTo: "buchhaltung@nordlicht-immobilien.de",
+  headerChip: "{{noticeLabel}}",
+  tone: "{{noticeTone}}",
 });
 
 // The platform default has a due date; the tenant drafts below drop it, which

package/samples/apps/ui-walkthrough/src/features/billing/feature.ts

@@ -54,6 +54,15 @@ const INVOICE_ISSUED_VARIABLES = {
     label: "billing:mail.variable.paymentReference",
     example: "RE-2026-0142 / Yilmaz",
   }),
+  // A text example given as i18n key follows the edited template's language.
+  noticeLabel: templateVariable.text({
+    label: "billing:mail.variable.noticeLabel",
+    example: "billing:mail.example.noticeLabel",
+  }),
+  noticeTone: templateVariable.text({
+    label: "billing:mail.variable.noticeTone",
+    example: "success",
+  }),
 } as const;
 
 const PAYMENT_REMINDER_VARIABLES = {

package/samples/apps/ui-walkthrough/src/features/billing/i18n.ts

@@ -20,6 +20,9 @@ export const billingTranslations: TranslationsByLocale = {
     "billing:mail.variable.lines.amount": "Betrag",
     "billing:mail.variable.lines": "Rechnungspositionen",
     "billing:mail.variable.paymentReference": "Zahlungsreferenz",
+    "billing:mail.variable.noticeLabel": "Kennzeichen der Rechnung",
+    "billing:mail.example.noticeLabel": "Neue Rechnung",
+    "billing:mail.variable.noticeTone": "Farbe der Meldung (success, warning oder danger)",
   },
   en: {
     "billing:feature.label": "Invoices",
@@ -37,5 +40,8 @@ export const billingTranslations: TranslationsByLocale = {
     "billing:mail.variable.lines.amount": "Amount",
     "billing:mail.variable.lines": "Invoice lines",
     "billing:mail.variable.paymentReference": "Payment reference",
+    "billing:mail.variable.noticeLabel": "Invoice label",
+    "billing:mail.example.noticeLabel": "New invoice",
+    "billing:mail.variable.noticeTone": "Notice colour (success, warning or danger)",
   },
 };

package/samples/apps/ui-walkthrough/src/features/rental/entities.ts

@@ -19,6 +19,7 @@ export const leaseEntity = createEntity({
     liegenschaft: createTextField({ ...DEMO_DATA, searchable: true, sortable: true }),
     beginn: createDateField({ required: true, sortable: true, filterable: true }),
     ende: createDateField({ sortable: true }),
+    vorgaenger: { type: "reference", entity: "lease", labelField: "einheit" },
     status: createSelectField({
       options: LEASE_STATUSES,
       optionTones: { active: "ok", terminated: "bad" },

package/samples/apps/ui-walkthrough/src/features/rental/feature.ts

@@ -1,3 +1,4 @@
+import type { EventStoreExecutor } from "@cosmicdrift/kumiko-framework/db";
 import { defineFeature, i18nKey } from "@cosmicdrift/kumiko-framework/engine";
 import { failNotFound } from "@cosmicdrift/kumiko-framework/errors";
 import { z } from "zod";
@@ -30,6 +31,7 @@ import {
   leaseListEmptyScreen,
   leaseListScreen,
   leaseListShortScreen,
+  leaseSuccessionListScreen,
   partyEditScreen,
   positionEditScreen,
   recordPositionsScreen,
@@ -69,6 +71,28 @@ export const rentalFeature = defineFeature("rental", (r) => {
 
   r.crud("lease", leaseEntity, { write: open, read: open });
   r.crud("leasePosition", leasePositionEntity, { write: open, read: open });
+  // Only the interactive create path is guarded; recordPositions and adjustRent
+  // write through the executor and compute their own date ranges.
+  r.hook({
+    type: "validation",
+    target: "lease-position:create",
+    handler: (data) => {
+      const { gueltigVon, gueltigBis } = data;
+      if (
+        typeof gueltigVon === "string" &&
+        typeof gueltigBis === "string" &&
+        gueltigBis < gueltigVon
+      ) {
+        // The "(root)" issue has no rendered field, so the form also shows its
+        // error banner next to the field error.
+        return [
+          { field: "gueltigBis", error: "valid_until_before_valid_from" },
+          { field: "(root)", error: "position_period_invalid" },
+        ];
+      }
+      return null;
+    },
+  });
   r.crud("leaseParty", leasePartyEntity, { write: open, read: open });
 
   r.queryHandler({
@@ -78,7 +102,7 @@ export const rentalFeature = defineFeature("rental", (r) => {
       const row = await leaseExecutor.detail({ id: query.payload.id }, query.user, ctx.db);
       if (!row) return failNotFound("lease", query.payload.id);
       const lease = parseLeaseRow(row);
-      const countChildren = async (executor: typeof positionExecutor): Promise<number> => {
+      const countChildren = async (executor: EventStoreExecutor): Promise<number> => {
         const page = await executor.list(
           { filter: { field: "lease", op: "eq", value: lease.id }, limit: 1, totalCount: true },
           query.user,
@@ -98,6 +122,7 @@ export const rentalFeature = defineFeature("rental", (r) => {
         einheit: lease.einheit ?? "",
         liegenschaft: lease.liegenschaft ?? "",
         ende: "",
+        vorgaenger: lease.vorgaenger ?? "",
         kontostand: "0,00 €",
         notizen: "",
         partyCount: await countChildren(partyExecutor),
@@ -241,6 +266,7 @@ export const rentalFeature = defineFeature("rental", (r) => {
   r.screen(leaseHubScreen);
   r.screen(leaseDetailGapsScreen);
   r.screen(leaseListEmptyScreen);
+  r.screen(leaseSuccessionListScreen);
   r.screen(rentalDashboardScreen);
   r.screen(adjustRentScreen);
   r.screen(recordPositionsScreen);

package/samples/apps/ui-walkthrough/src/features/rental/i18n.ts

@@ -7,6 +7,7 @@ export const rentalTranslations: TranslationsByLocale = {
 
     "screen:lease-list.title": "Mietverträge",
     "screen:lease-list-short.title": "Mietverträge (gekündigt)",
+    "screen:lease-succession-list.title": "Nachfolge",
     "screen:lease-edit.title": "Mietvertrag",
     "screen:lease-detail.title": "Mietvertrag",
     "screen:lease-hub.title": "Mietvertrag Hub",
@@ -56,6 +57,7 @@ export const rentalTranslations: TranslationsByLocale = {
     "rental:entity:lease:field:liegenschaft": "Liegenschaft",
     "rental:entity:lease:field:beginn": "Beginn",
     "rental:entity:lease:field:ende": "Ende",
+    "rental:entity:lease:field:vorgaenger": "Vorgänger",
     "rental:entity:lease:field:status": "Status",
     "rental:entity:lease:field:status:option:active": "Aktiv",
     "rental:entity:lease:field:status:option:terminated": "Gekündigt",
@@ -71,6 +73,9 @@ export const rentalTranslations: TranslationsByLocale = {
     "rental:entity:leasePosition:field:betrag": "Betrag",
     "rental:entity:leasePosition:field:gueltigVon": "Gültig von",
     "rental:entity:leasePosition:field:gueltigBis": "Gültig bis",
+    "errors.validation.position_period_invalid": "Der Zeitraum der Position ist ungültig.",
+    "errors.validation.valid_until_before_valid_from":
+      "Gültig bis darf nicht vor Gültig von liegen.",
 
     "rental:entity:leaseParty:field:lease": "Mietvertrag",
     "rental:entity:leaseParty:field:name": "Name",
@@ -119,6 +124,7 @@ export const rentalTranslations: TranslationsByLocale = {
 
     "screen:lease-list.title": "Leases",
     "screen:lease-list-short.title": "Leases (terminated)",
+    "screen:lease-succession-list.title": "Succession",
     "screen:lease-edit.title": "Lease",
     "screen:lease-detail.title": "Lease",
     "screen:lease-hub.title": "Lease hub",
@@ -166,6 +172,7 @@ export const rentalTranslations: TranslationsByLocale = {
     "rental:entity:lease:field:liegenschaft": "Property",
     "rental:entity:lease:field:beginn": "Start",
     "rental:entity:lease:field:ende": "End",
+    "rental:entity:lease:field:vorgaenger": "Predecessor",
     "rental:entity:lease:field:status": "Status",
     "rental:entity:lease:field:status:option:active": "Active",
     "rental:entity:lease:field:status:option:terminated": "Terminated",
@@ -181,6 +188,8 @@ export const rentalTranslations: TranslationsByLocale = {
     "rental:entity:leasePosition:field:betrag": "Amount",
     "rental:entity:leasePosition:field:gueltigVon": "Valid from",
     "rental:entity:leasePosition:field:gueltigBis": "Valid until",
+    "errors.validation.position_period_invalid": "The position period is invalid.",
+    "errors.validation.valid_until_before_valid_from": "Valid until must not be before valid from.",
 
     "rental:entity:leaseParty:field:lease": "Lease",
     "rental:entity:leaseParty:field:name": "Name",

package/samples/apps/ui-walkthrough/src/features/rental/lease-support.ts

@@ -62,6 +62,7 @@ const leaseRowSchema = z.object({
   beginn: readDateSchema,
   status: z.string(),
   ende: readDateSchema.nullish(),
+  vorgaenger: z.string().nullish(),
   grundmiete: moneySchema,
   kuendigungsfrist: z.string().nullish(),
   zahltag: z.number().nullish(),