@cosmicdrift/kumiko-renderer 0.87.3 → 0.89.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer",
-  "version": "0.87.3",
+  "version": "0.89.0",
   "description": "Platform-agnostic React renderer for Kumiko screens. Contains the shared logic — primitives-contract, hooks, KumikoScreen, navigation & SSE abstractions — that any platform-specific renderer (web, native) composes. No DOM, no EventSource, no react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -15,8 +15,8 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.87.3",
-    "@cosmicdrift/kumiko-headless": "0.87.3",
+    "@cosmicdrift/kumiko-framework": "0.89.0",
+    "@cosmicdrift/kumiko-headless": "0.89.0",
     "react": "^19.2.6"
   },
   "devDependencies": {

package/src/components/__tests__/render-edit-logic.test.ts

@@ -1,6 +1,15 @@
 import { describe, expect, test } from "bun:test";
-import type { DispatcherError, SubmitResult } from "@cosmicdrift/kumiko-headless";
-import { resolveExtensionEntityId, shouldNotifyCaller } from "../render-edit-logic";
+import type {
+  DispatcherError,
+  EditFieldViewModel,
+  EditSectionViewModel,
+  SubmitResult,
+} from "@cosmicdrift/kumiko-headless";
+import {
+  hasEditableSection,
+  resolveExtensionEntityId,
+  shouldNotifyCaller,
+} from "../render-edit-logic";
 
 const error: DispatcherError = {
   code: "internal_error",
@@ -58,3 +67,48 @@ describe("shouldNotifyCaller", () => {
     expect(shouldNotifyCaller(validationBlocked, true)).toBe(true);
   });
 });
+
+const field = (readOnly: boolean): EditFieldViewModel => ({
+  field: "f",
+  label: "F",
+  type: "text",
+  value: "",
+  visible: true,
+  readOnly,
+  required: false,
+});
+const fieldsSection = (...readOnly: boolean[]): EditSectionViewModel => ({
+  kind: "fields",
+  columns: 1,
+  fields: readOnly.map(field),
+});
+const extensionSection: EditSectionViewModel = {
+  kind: "extension",
+  title: "Custom",
+  component: {},
+};
+
+describe("hasEditableSection", () => {
+  // A read-only inspector detail (export-job/download-attempt) marks every field
+  // readOnly + has no create/delete — there is nothing to submit, so the Save
+  // button must not render at all (a disabled one reads as a broken control).
+  test("every field readOnly → false (no Save button)", () => {
+    expect(hasEditableSection([fieldsSection(true, true, true)])).toBe(false);
+  });
+
+  test("one editable field → true", () => {
+    expect(hasEditableSection([fieldsSection(true, false)])).toBe(true);
+  });
+
+  test("editable field in a later section → true", () => {
+    expect(hasEditableSection([fieldsSection(true), fieldsSection(false)])).toBe(true);
+  });
+
+  test("extension section counts as editable (carries its own save)", () => {
+    expect(hasEditableSection([extensionSection])).toBe(true);
+  });
+
+  test("no sections → false", () => {
+    expect(hasEditableSection([])).toBe(false);
+  });
+});

package/src/components/render-edit-logic.ts

@@ -1,4 +1,12 @@
-import type { SubmitResult } from "@cosmicdrift/kumiko-headless";
+import type { EditSectionViewModel, SubmitResult } from "@cosmicdrift/kumiko-headless";
+
+// A read-only inspector form — every field readOnly, no editable section — has
+// nothing to submit, so the renderer drops the Save button rather than show a
+// dead disabled one. An extension section carries its own dirty/save, so it
+// counts as editable.
+export function hasEditableSection(sections: readonly EditSectionViewModel[]): boolean {
+  return sections.some((s) => s.kind !== "fields" || s.fields.some((f) => !f.readOnly));
+}
 
 // Single source of truth for the extension-section entity-id. The section mount
 // and persistExtensions MUST resolve the same id — otherwise a section mounts

package/src/components/render-edit.tsx

@@ -28,7 +28,11 @@ import { extensionSectionName, useExtensionSectionComponent } from "../app/exten
 import { useForm } from "../hooks/use-form";
 import { useTranslation } from "../i18n";
 import { usePrimitives } from "../primitives";
-import { resolveExtensionEntityId, shouldNotifyCaller } from "./render-edit-logic";
+import {
+  hasEditableSection,
+  resolveExtensionEntityId,
+  shouldNotifyCaller,
+} from "./render-edit-logic";
 import { RenderField } from "./render-field";
 
 // End-to-end renderer für einen entityEdit screen. Rendert aus-
@@ -243,6 +247,8 @@ export function RenderEdit<TValues extends FormValues, TCtx = unknown>(
     [screen, entity, snapshot.values, translate, featureName],
   );
 
+  const hasEditableField = hasEditableSection(vm.sections);
+
   // Persistiert alle composed Extension-Sections mit der aufgelösten entityId.
   // false = eine Section schlug fehl (ihr i18n-Key landet im Banner). Ohne
   // Entity-Kontext (create-mode ohne route-id) gibt es nichts zu schreiben.
@@ -349,15 +355,17 @@ export function RenderEdit<TValues extends FormValues, TCtx = unknown>(
           {translate("kumiko.actions.cancel")}
         </Button>
       )}
-      <Button
-        type="submit"
-        disabled={(snapshot.isUnchanged && !extensionDirty) || isSubmitting}
-        loading={isSubmitting}
-        variant="primary"
-        testId="render-edit-submit"
-      >
-        {translate(submitLabel ?? "kumiko.actions.save")}
-      </Button>
+      {hasEditableField && (
+        <Button
+          type="submit"
+          disabled={(snapshot.isUnchanged && !extensionDirty) || isSubmitting}
+          loading={isSubmitting}
+          variant="primary"
+          testId="render-edit-submit"
+        >
+          {translate(submitLabel ?? "kumiko.actions.save")}
+        </Button>
+      )}
     </>
   );